Re: [I] [Java][C] sliced RecordBatch offset info is lost when imported from c-data [arrow]

2024-05-15 Thread via GitHub
vibhatha commented on issue #41682: URL: https://github.com/apache/arrow/issues/41682#issuecomment-2113985057 I will try to reproduce this and evaluate the approach suggested by @lidavidm. I will probably need some time to try this out. -- This is an automated message from the Apache Git

Re: [I] [Java][C] sliced RecordBatch offset info is lost when imported from c-data [arrow]

2024-05-15 Thread via GitHub
lidavidm commented on issue #41682: URL: https://github.com/apache/arrow/issues/41682#issuecomment-2113961717 CC @vibhatha We also have to traverse recursively since child arrays can have their own offset -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] [Java][C] sliced RecordBatch offset info is lost when imported from c-data [arrow]

2024-05-15 Thread via GitHub
hellishfire commented on issue #41682: URL: https://github.com/apache/arrow/issues/41682#issuecomment-2113948678 > Yes, but that's different in intent than the C++ version (which just tracks an offset). Here it means we can't do a 0 copy import. I understand that, but IMO data correct

Re: [I] [Java][C] sliced RecordBatch offset info is lost when imported from c-data [arrow]

2024-05-15 Thread via GitHub
lidavidm commented on issue #41682: URL: https://github.com/apache/arrow/issues/41682#issuecomment-2113934843 Yes, but that's different in intent than the C++ version (which just tracks an offset). Here it means we can't do a 0 copy import. -- This is an automated message from the Apache

Re: [I] [Java][C] sliced RecordBatch offset info is lost when imported from c-data [arrow]

2024-05-15 Thread via GitHub
hellishfire commented on issue #41682: URL: https://github.com/apache/arrow/issues/41682#issuecomment-2113930191 > Java doesn't really have a concept of slicing, so either this needs to copy the data (at least for things that can't easily be sliced, like the validity buffer) or it should er

Re: [I] [Java][C] sliced RecordBatch offset info is lost when imported from c-data [arrow]

2024-05-15 Thread via GitHub
lidavidm commented on issue #41682: URL: https://github.com/apache/arrow/issues/41682#issuecomment-2113920997 Java doesn't really have a concept of slicing, so either this needs to copy the data (at least for things that can't easily be sliced, like the validity buffer) or it should error o