vibhatha closed pull request #41676: GH-40934: [Java] TypeLayout enhancement to
support StringView
URL: https://github.com/apache/arrow/pull/41676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vibhatha commented on PR #41676:
URL: https://github.com/apache/arrow/pull/41676#issuecomment-2120406287
Closing this PR in favor of https://github.com/apache/arrow/pull/41732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm commented on PR #41676:
URL: https://github.com/apache/arrow/pull/41676#issuecomment-2119455800
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
vibhatha commented on PR #41676:
URL: https://github.com/apache/arrow/pull/41676#issuecomment-2118490357
@lidavidm I think the scope of this PR was broadened than I anticipated.
This needs more test coverage for `RecordBatch` spec change and its usage
across the codebase. I am going to conv
vibhatha commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1604391572
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
vibhatha commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1604391205
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
lidavidm commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1604292611
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
lidavidm commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1604292469
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
vibhatha commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1604284276
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
vibhatha commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1602528886
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
lidavidm commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1602517022
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
vibhatha commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1602508993
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
lidavidm commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1602413649
##
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgum
vibhatha commented on PR #41676:
URL: https://github.com/apache/arrow/pull/41676#issuecomment-2113714065
@lidavidm could you please take a look? I am not sure the best practices for
deprecation. Should we also add docs? I mean not only Java docs, but also
documentation (rst)?
--
This is
14 matches
Mail list logo
