conbench-apache-arrow[bot] commented on PR #41599:
URL: https://github.com/apache/arrow/pull/41599#issuecomment-2129347899
After merging your PR, Conbench analyzed the 7 benchmarking runs that have
been run so far on merge-commit 799021ae6f7755dee7b92562bbd0f97428fd8925.
There were 5
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1612520321
##
ci/scripts/install_vcpkg.sh:
##
@@ -25,7 +25,7 @@ if [ "$#" -lt 1 ]; then
fi
arrow_dir=$(cd -- "$(dirname -- "$0")/../.." && pwd -P)
-default_vcpkg_version=$(c
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1612527744
##
ci/scripts/install_vcpkg.sh:
##
@@ -25,7 +25,7 @@ if [ "$#" -lt 1 ]; then
fi
arrow_dir=$(cd -- "$(dirname -- "$0")/../.." && pwd -P)
-default_vcpkg_version=$(cat "${
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1612520321
##
ci/scripts/install_vcpkg.sh:
##
@@ -25,7 +25,7 @@ if [ "$#" -lt 1 ]; then
fi
arrow_dir=$(cd -- "$(dirname -- "$0")/../.." && pwd -P)
-default_vcpkg_version=$(c
kou merged PR #41599:
URL: https://github.com/apache/arrow/pull/41599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1612517256
##
ci/scripts/install_vcpkg.sh:
##
@@ -25,7 +25,7 @@ if [ "$#" -lt 1 ]; then
fi
arrow_dir=$(cd -- "$(dirname -- "$0")/../.." && pwd -P)
-default_vcpkg_version=$(cat "${
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1610926723
##
c_glib/tool/generate-visibility-header.py:
##
@@ -0,0 +1,68 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1610926041
##
c_glib/tool/generate-visibility-header.py:
##
@@ -0,0 +1,68 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contrib
adamreeve commented on PR #41599:
URL: https://github.com/apache/arrow/pull/41599#issuecomment-2126145170
I've rebased on top of the changes from #41721 to add per-library version
headers, and added per-library visibility headers too. I've had to keep the
Gandiva build disabled due to #3695
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1604188666
##
ci/scripts/c_glib_build.sh:
##
@@ -28,17 +28,38 @@ build_root=${2}
: ${BUILD_DOCS_C_GLIB:=OFF}
with_doc=$([ "${BUILD_DOCS_C_GLIB}" == "ON" ] && echo "true" || ec
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1602806624
##
ci/scripts/c_glib_build.sh:
##
@@ -28,17 +28,38 @@ build_root=${2}
: ${BUILD_DOCS_C_GLIB:=OFF}
with_doc=$([ "${BUILD_DOCS_C_GLIB}" == "ON" ] && echo "true" || echo "fa
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1602805729
##
.github/workflows/ruby.yml:
##
@@ -305,3 +304,96 @@ jobs:
$Env:MAKE = "ridk exec make"
$ErrorActionPreference = "Continue"
rake -f ruby\
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1602432722
##
ci/scripts/c_glib_build.sh:
##
@@ -28,17 +28,38 @@ build_root=${2}
: ${BUILD_DOCS_C_GLIB:=OFF}
with_doc=$([ "${BUILD_DOCS_C_GLIB}" == "ON" ] && echo "true" || ec
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1602431330
##
c_glib/arrow-glib/array-builder.h:
##
@@ -22,70 +22,97 @@
#include
#include
#include
+#include
G_BEGIN_DECLS
#define GARROW_TYPE_ARRAY_BUILDER (garrow
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1600815849
##
c_glib/arrow-glib/codec.hpp:
##
@@ -22,13 +22,20 @@
#include
#include
+#include
Review Comment:
I think that this is needless.
```suggestion
```
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1600814373
##
c_glib/arrow-glib/array-builder.h:
##
@@ -22,70 +22,97 @@
#include
#include
#include
+#include
G_BEGIN_DECLS
#define GARROW_TYPE_ARRAY_BUILDER (garrow_array
kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1600813247
##
.github/workflows/ruby.yml:
##
@@ -305,3 +305,96 @@ jobs:
$Env:MAKE = "ridk exec make"
$ErrorActionPreference = "Continue"
rake -f ruby\
github-actions[bot] commented on PR #41599:
URL: https://github.com/apache/arrow/pull/41599#issuecomment-2110826775
Revision: 4dc31f86b45887cbd3967ba947d44dad2b483d2e
Submitted crossbow builds: [ursacomputing/crossbow @
actions-012c96d84c](https://github.com/ursacomputing/crossbow/bra
raulcd commented on PR #41599:
URL: https://github.com/apache/arrow/pull/41599#issuecomment-2110821832
@github-actions crossbow submit -g nightly-release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #41599:
URL: https://github.com/apache/arrow/pull/41599#issuecomment-2110812868
```
Invalid group(s) {'release'}. Must be one of {'homebrew', 'linux',
'example-cpp', 'verify-rc-wheels', 'packaging', 'c-glib', 'nightly-packaging',
'wheel', 'verify-rc-bi
raulcd commented on PR #41599:
URL: https://github.com/apache/arrow/pull/41599#issuecomment-2110810749
@github-actions crossbow submit -g release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1599269705
##
.github/workflows/ruby.yml:
##
@@ -305,3 +305,96 @@ jobs:
$Env:MAKE = "ridk exec make"
$ErrorActionPreference = "Continue"
rake -f
adamreeve commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1599263276
##
c_glib/arrow-glib/array-builder.h:
##
@@ -22,70 +22,97 @@
#include
#include
#include
+#include
G_BEGIN_DECLS
#define GARROW_TYPE_ARRAY_BUILDER (garrow
github-actions[bot] commented on PR #41599:
URL: https://github.com/apache/arrow/pull/41599#issuecomment-2101978908
:warning: GitHub issue #41134 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
adamreeve opened a new pull request, #41599:
URL: https://github.com/apache/arrow/pull/41599
### Rationale for this change
Allow Windows users to more easily build the GLib libraries.
### What changes are included in this PR?
* Minor fixes to allow building with MSVC:
25 matches
Mail list logo
