conbench-apache-arrow[bot] commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2115093867
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 0574988e328d483446b2b758bbc8c26bf1c82196.
There were no
lidavidm merged PR #41285:
URL: https://github.com/apache/arrow/pull/41285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apac
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2114145757
@lidavidm CIs are passing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
lidavidm commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2113989211
let's just rebase and see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2113986395
@lidavidm should we rebase and run CIs again. It seems that there was PR to
fix the breaking Gandiva issue?
And any other changes you would expect here?
--
This is an automate
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1599619916
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1599600227
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1599594505
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1599586174
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1599562522
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1599479617
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2109362196
@lidavidm sorry I misunderstood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
lidavidm commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2109347582
> @felipecrv would you mind reviewing this PR?
No, I mean get a C++ reviewer to look at the C++ build failures.
--
This is an automated message from the Apache Git Service.
To re
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2109338316
@felipecrv would you mind reviewing this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1599325648
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2109198843
Can we get a C++ maintainer to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2106449440
@lidavidm Java JNI seems to be failing due the C++ issue came across:
https://github.com/apache/arrow/pull/41628#issuecomment-2106448958
--
This is an automated message from the Apache
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2106444837
@lidavidm updated the PR and left a few comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597761476
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597761129
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597758372
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,863 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597745870
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597745620
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597745263
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,863 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597327813
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597357241
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1597326646
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2104410939
@lidavidm PR is ready for another round of reviews :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596571159
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596570774
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596570405
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596564343
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596529665
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596356979
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596355624
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596355208
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596351599
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596337631
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596319927
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,913 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1596294611
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,406 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2102509124
@lidavidm I updated the PR and left some comments too. Ready for another
round of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1595341201
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,406 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1595314792
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1594966203
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1594934640
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,945 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1594934242
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1594933751
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1594933322
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1594927564
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1594926480
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593814975
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593801037
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593800528
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,945 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593798045
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593796607
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593796073
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,945 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593794930
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,945 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593794072
##
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java:
##
@@ -0,0 +1,945 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593792986
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593779339
##
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundation
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593737442
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593687204
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593679865
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593544666
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593543076
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593521304
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593531504
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593525867
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593521304
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
lidavidm commented on code in PR #41285:
URL: https://github.com/apache/arrow/pull/41285#discussion_r1593509952
##
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java:
##
@@ -0,0 +1,1599 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vibhatha commented on PR #41285:
URL: https://github.com/apache/arrow/pull/41285#issuecomment-2099544945
@lidavidm @danepitkin This PR is ready for reviewing. Also it may need
running the CIs. (I am not sure what happened there after marking ready for
review).
--
This is an automated me
71 matches
Mail list logo