Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519041732 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -870,3 +870,22 @@ async fn test_fn_array_to_string() -> Result<()> { Ok(())

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519041732 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -870,3 +870,22 @@ async fn test_fn_array_to_string() -> Result<()> { Ok(())

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 commented on PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#issuecomment-1987436239 You can follow the `How to format .md document` section in https://arrow.apache.org/datafusion/contributor-guide/index.html#developer-s-guide to solve the formating issue -

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519025426 ## docs/source/user-guide/sql/scalar_functions.md: ## @@ -3113,6 +3113,7 @@ _Alias of [make_array](#make_array)._ ### `string_to_array` Splits a string

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519025106 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -870,3 +870,22 @@ async fn test_fn_array_to_string() -> Result<()> { Ok(()) } + +#[

[PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari opened a new pull request, #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543 ## Which issue does this PR close? Closes #9497. ## Rationale for this change This PR aims to Also, following changes are added: 1- Port Port `StringToArray`