cyb70289 commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-635798096
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset
This is an au
Marwes commented on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-635801955
https://github.com/apache/arrow/pull/7176/files#diff-64ae792f16372598b2b117c58f952626R727-R731
This is an automate
ursabot commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-635802797
[AMD64 Ubuntu 18.04 C++ Benchmark
(#108408)](https://ci.ursalabs.org/#builders/73/builds/65) builder has been
succeeded.
Revision: ef4d77ceabd23b51e052e4da58310ebacdc0fe9d
lidavidm commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635939130
> I am curious why the link error at `arrow-flight-test` occurs at
https://travis-ci.org/github/apache/arrow/jobs/692253254#L1141.
> Do we need a fix like #7266?
I think
wesm commented on pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#issuecomment-635950388
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
lidavidm commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635952431
By explicitly linking to zlib, the s390x build passes again, though tests
fail.
This is an automated message fro
fsaintjacques commented on pull request #7285:
URL: https://github.com/apache/arrow/pull/7285#issuecomment-635953947
> NOTE: This patch may hurt performance if two bitmaps differ at the very
> begining bits, as it always loads and compares 64 bits if possible. Bit
> by bit comparison w
fsaintjacques commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-635967095
> [AMD64 Ubuntu 18.04 C++ Benchmark
(#108408)](https://ci.ursalabs.org/#builders/73/builds/65) builder has been
succeeded.
>
> Revision:
[ef4d77c](https://github.com
fsaintjacques commented on a change in pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#discussion_r432476648
##
File path: cpp/src/arrow/flight/flight_test.cc
##
@@ -1556,13 +1556,14 @@ TEST_F(TestBasicAuthHandler, CheckPeerIdentity) {
ASSERT_EQ(result->bo
kiszk commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635973498
@lidavidm Thank you very much. These test failures occur at the current
master.
```
The following tests FAILED:
63 - gandiva-decimal-test (Failed)
64 - gandiv
lidavidm commented on a change in pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#discussion_r432485095
##
File path: cpp/src/arrow/flight/flight_test.cc
##
@@ -1556,13 +1556,14 @@ TEST_F(TestBasicAuthHandler, CheckPeerIdentity) {
ASSERT_EQ(result->body->T
fsaintjacques commented on a change in pull request #7256:
URL: https://github.com/apache/arrow/pull/7256#discussion_r432488488
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -139,8 +144,13 @@ std::array BasicDecimal128::ToBytes() const {
void BasicDecimal128::ToByt
fsaintjacques commented on a change in pull request #7256:
URL: https://github.com/apache/arrow/pull/7256#discussion_r432488488
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -139,8 +144,13 @@ std::array BasicDecimal128::ToBytes() const {
void BasicDecimal128::ToByt
fsaintjacques closed pull request #7256:
URL: https://github.com/apache/arrow/pull/7256
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andygrove commented on pull request #7297:
URL: https://github.com/apache/arrow/pull/7297#issuecomment-635988046
Full logs are attached to the JIRA
This is an automated message from the Apache Git Service.
To respond to the m
fsaintjacques closed pull request #7298:
URL: https://github.com/apache/arrow/pull/7298
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mr-smidge commented on pull request #7158:
URL: https://github.com/apache/arrow/pull/7158#issuecomment-635999568
@eerhardt , what's the policy on rebasing when master changes? Would you
prefer I rebase this branch onto latest master, or preseve the history as-is?
bkietz commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r432537565
##
File path: python/pyarrow/_dataset.pyx
##
@@ -42,6 +43,51 @@ def _forbid_instantiation(klass, subclasses_instead=True):
raise TypeError(msg)
+cty
nealrichardson commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-636042815
Alright, I'll tinker a bit more with this.
This is an automated message from the Apache Git Service.
To res
kiszk commented on pull request #7301:
URL: https://github.com/apache/arrow/pull/7301#issuecomment-636046069
cc @kou
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
kiszk opened a new pull request #7301:
URL: https://github.com/apache/arrow/pull/7301
This PR removes `arrow_failures` option for s390x on TravisCI. This is
because the current master can succeed all of the existing tests enabled for
s390x, as you can see https://travis-ci.org/github/apach
wesm commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636064330
@github-actions crossbow submit test-conda-cpp-valgrind
This is an automated message from the Apache Git Service.
To
wesm opened a new pull request #7302:
URL: https://github.com/apache/arrow/pull/7302
There are benign warnings in the cpp-conda-valgrind build due to accessing
uninitialized trailing bits in validity bitmaps. Fixing the warnings without
relying on compiler definitions is more complex than
github-actions[bot] commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636064999
Revision: 65d20c30b8da334ef9088d6646e1e516670e1cb2
Submitted crossbow builds: [ursa-labs/crossbow @
actions-270](https://github.com/ursa-labs/crossbow/branches/a
github-actions[bot] commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636066997
https://issues.apache.org/jira/browse/ARROW-8978
This is an automated message from the Apache Git Serv
nealrichardson commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-636086599
I did a little bit more--and judging from the size of the arrowExports.o
file, it had an effect--but could use some help going beyond this. I don't know
how to forward decl
fsaintjacques commented on pull request #7301:
URL: https://github.com/apache/arrow/pull/7301#issuecomment-636100483
I'm not sure, the CI is already heavy as it is. I don't want to stop PR
because it doesn't pass on s930x. I'm -0.5 on this one.
fsaintjacques commented on a change in pull request #7285:
URL: https://github.com/apache/arrow/pull/7285#discussion_r432527849
##
File path: cpp/src/arrow/util/bit_util.cc
##
@@ -246,6 +246,49 @@ bool BitmapEquals(const uint8_t* left, int64_t
left_offset, const uint8_t* right
fsaintjacques commented on a change in pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#discussion_r432645169
##
File path: cpp/src/arrow/compute/util_internal.h
##
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
fsaintjacques commented on a change in pull request #7292:
URL: https://github.com/apache/arrow/pull/7292#discussion_r432665221
##
File path: cpp/src/arrow/ipc/json_integration_test.cc
##
@@ -255,7 +255,7 @@ static const char* JSON_EXAMPLE = R"example(
"fields": [
{
lidavidm commented on a change in pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#discussion_r432674577
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/VectorSchemaRoot.java
##
@@ -163,8 +163,22 @@ public void clear() {
return fieldVecto
fsaintjacques edited a comment on pull request #7301:
URL: https://github.com/apache/arrow/pull/7301#issuecomment-636100483
I'm not sure, the CI is already heavy as it is. I don't want to stop PR
because it doesn't pass on s390x. I'm -0.5 on this one.
-
github-actions[bot] commented on pull request #7301:
URL: https://github.com/apache/arrow/pull/7301#issuecomment-636206075
https://issues.apache.org/jira/browse/ARROW-8982
This is an automated message from the Apache Git Serv
raulbocanegra commented on a change in pull request #7284:
URL: https://github.com/apache/arrow/pull/7284#discussion_r432762353
##
File path: cpp/cmake_modules/FindPythonLibsNew.cmake
##
@@ -246,7 +248,7 @@ FUNCTION(PYTHON_ADD_MODULE _NAME )
SET_TARGET_PROPERTIES(${_NAME
raulbocanegra commented on a change in pull request #7284:
URL: https://github.com/apache/arrow/pull/7284#discussion_r432762308
##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -120,6 +120,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
defi
wesm commented on pull request #7302:
URL: https://github.com/apache/arrow/pull/7302#issuecomment-636216700
Oops thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
nealrichardson opened a new pull request #7303:
URL: https://github.com/apache/arrow/pull/7303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
github-actions[bot] commented on pull request #7303:
URL: https://github.com/apache/arrow/pull/7303#issuecomment-636235670
https://issues.apache.org/jira/browse/ARROW-8984
This is an automated message from the Apache Git Serv
nealrichardson opened a new pull request #7304:
URL: https://github.com/apache/arrow/pull/7304
Originally reported #7058
`download.file()` can be called with different methods, mostly for legacy
reasons according to the docs, but apparently some are on systems where it has
been set
kou closed pull request #7302:
URL: https://github.com/apache/arrow/pull/7302
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
github-actions[bot] commented on pull request #7304:
URL: https://github.com/apache/arrow/pull/7304#issuecomment-636242645
https://issues.apache.org/jira/browse/ARROW-8878
This is an automated message from the Apache Git Serv
fsaintjacques commented on pull request #7301:
URL: https://github.com/apache/arrow/pull/7301#issuecomment-636254062
I'm not saying this job is heavy, the total sum is.
This is an automated message from the Apache Git Service
kou commented on pull request #7301:
URL: https://github.com/apache/arrow/pull/7301#issuecomment-636263402
Is the total sum important for our development?
I think that CI wait time is more important rather than the total sum. CI
wait time is increased when job queue is full. If job queue
xhochy closed pull request #7303:
URL: https://github.com/apache/arrow/pull/7303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
44 matches
Mail list logo
