[GitHub] [arrow] jorgecarleitao opened a new pull request #7723: ARROW-9425 [Rust][DataFusion] Made ExecutionContext sharable and sync

2020-07-13 Thread GitBox
jorgecarleitao opened a new pull request #7723: URL: https://github.com/apache/arrow/pull/7723 This is required when the library is used by other applications that leverage a long-living context. This is an automated message

[GitHub] [arrow] github-actions[bot] commented on pull request #7723: ARROW-9425 [Rust][DataFusion] Made ExecutionContext sharable and sync

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7723: URL: https://github.com/apache/arrow/pull/7723#issuecomment-657408873 https://issues.apache.org/jira/browse/ARROW-9425 This is an automated message from the Apache Git Serv

[GitHub] [arrow] mr-smidge commented on pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-13 Thread GitBox
mr-smidge commented on pull request #7654: URL: https://github.com/apache/arrow/pull/7654#issuecomment-657438635 > In general, DateTimeOffset is the preferred type to use when talking about dates and times. The reasoning is because exactly what you point out in the JIRA issue - DateTime.Ki

[GitHub] [arrow] pitrou commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453520967 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license

[GitHub] [arrow] pitrou commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453521794 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license

[GitHub] [arrow] pitrou commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453525042 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license

[GitHub] [arrow] pitrou commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453525416 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license

[GitHub] [arrow] pitrou commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657449500 I could give a try to list tables, but otherwise I think CSV or JSON would be a major PITA to edit later. This is

[GitHub] [arrow] pitrou commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657454065 Ok, list tables may be workable, but they don't make it easy to review docs simply by reading the source reST code. I'd rather keep the usual reST layout, unless you're using an ed

[GitHub] [arrow] jorgecarleitao opened a new pull request #7724: ARROW-9427: [Rust][DataFusion] Added ExecutionContext.tables()

2020-07-13 Thread GitBox
jorgecarleitao opened a new pull request #7724: URL: https://github.com/apache/arrow/pull/7724 Allows users to know what names can be passed to `table()`. This is an automated message from the Apache Git Service. To respond t

[GitHub] [arrow] sbinet commented on pull request #7712: ARROW-9416: [Go] Add testcases for some datatypes

2020-07-13 Thread GitBox
sbinet commented on pull request #7712: URL: https://github.com/apache/arrow/pull/7712#issuecomment-657458768 probably more mine (mistake) than yours :) This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] sbinet closed pull request #7712: ARROW-9416: [Go] Add testcases for some datatypes

2020-07-13 Thread GitBox
sbinet closed pull request #7712: URL: https://github.com/apache/arrow/pull/7712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7724: ARROW-9427: [Rust][DataFusion] Added ExecutionContext.tables()

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7724: URL: https://github.com/apache/arrow/pull/7724#issuecomment-657463084 https://issues.apache.org/jira/browse/ARROW-9427 This is an automated message from the Apache Git Serv

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453541169 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contrib

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453541169 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contrib

[GitHub] [arrow] pitrou commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657467563 So there are three formats to choose from: * "full" reST table layout: ```restructuredtext +--++

[GitHub] [arrow] maartenbreddels commented on pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

2020-07-13 Thread GitBox
maartenbreddels commented on pull request #7656: URL: https://github.com/apache/arrow/pull/7656#issuecomment-657470241 > ah I think I figured out the mystery of the failed compilation -- it's caused by the missing utf8proc. Of course, now the error msg makes sense. Thanks for finishi

[GitHub] [arrow] nevi-me commented on pull request #7693: ARROW-9391: [Rust] Padding added to arrays causes float32's to be incorrectly cast to float64 float64s in the case where a record batch only c

2020-07-13 Thread GitBox
nevi-me commented on pull request #7693: URL: https://github.com/apache/arrow/pull/7693#issuecomment-657473066 Hey @maxburke, may you please kindly rebase this. I can't push to urbanlogiq's fork, access rights issues. This i

[GitHub] [arrow] pitrou commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453571743 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license

[GitHub] [arrow] sir-sigurd opened a new pull request #7725: [MINOR][Python][Doc] Fix rst role dataset.rst

2020-07-13 Thread GitBox
sir-sigurd opened a new pull request #7725: URL: https://github.com/apache/arrow/pull/7725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #7725: [MINOR][Python][Doc] Fix rst role dataset.rst

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7725: URL: https://github.com/apache/arrow/pull/7725#issuecomment-657498276 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453580484 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -780,11 +741,29 @@ Status GetReader(const SchemaField& field, const std::shared_ptr& Status

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453580484 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -780,11 +741,29 @@ Status GetReader(const SchemaField& field, const std::shared_ptr& Status

[GitHub] [arrow] pitrou edited a comment on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou edited a comment on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657467563 So there are three formats to choose from: * "full" reST table layout: ```restructuredtext +--++-

[GitHub] [arrow] kszucs commented on pull request #7684: ARROW-9374: [C++][Python] Expose MakeArrayFromScalar

2020-07-13 Thread GitBox
kszucs commented on pull request #7684: URL: https://github.com/apache/arrow/pull/7684#issuecomment-657537128 It supports MapScalar, but not the union scalar because we'd need to have the type_code information stored in the union scalar value in order to properly reconstruct a union array

[GitHub] [arrow] jorisvandenbossche commented on pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-07-13 Thread GitBox
jorisvandenbossche commented on pull request #6979: URL: https://github.com/apache/arrow/pull/6979#issuecomment-657539765 @wjones1 sorry for the slow follow-up. Could you rebase the PR? This is an automated message from the A

[GitHub] [arrow] vertexclique opened a new pull request #7726: ARROW-8574 – [Rust][Arrow] Implement Debug for all plain types

2020-07-13 Thread GitBox
vertexclique opened a new pull request #7726: URL: https://github.com/apache/arrow/pull/7726 @andygrove @nevi-me @paddyhoran This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] bkietz commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
bkietz commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657556478 > I could give a try to list tables, but otherwise I think CSV or JSON would be a major PITA to edit later. Does that include tables which use the `file:` directive to refer

[GitHub] [arrow] pitrou commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657557007 > Does that include tables which use the file: directive to refer to an out-of-line table source? Do you mean you would like to edit a CSV table in a spreadsheet? -

[GitHub] [arrow] kszucs commented on a change in pull request #7684: ARROW-9374: [C++][Python] Expose MakeArrayFromScalar

2020-07-13 Thread GitBox
kszucs commented on a change in pull request #7684: URL: https://github.com/apache/arrow/pull/7684#discussion_r453648012 ## File path: cpp/src/arrow/array/util.cc ## @@ -323,15 +336,52 @@ class RepeatedArrayFactory { return Status::OK(); } - Status Visit(const FixedS

[GitHub] [arrow] kszucs commented on a change in pull request #7684: ARROW-9374: [C++][Python] Expose MakeArrayFromScalar

2020-07-13 Thread GitBox
kszucs commented on a change in pull request #7684: URL: https://github.com/apache/arrow/pull/7684#discussion_r453648012 ## File path: cpp/src/arrow/array/util.cc ## @@ -323,15 +336,52 @@ class RepeatedArrayFactory { return Status::OK(); } - Status Visit(const FixedS

[GitHub] [arrow] github-actions[bot] commented on pull request #7726: ARROW-8574 – [Rust][Arrow] Implement Debug for all plain types

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7726: URL: https://github.com/apache/arrow/pull/7726#issuecomment-657562660 https://issues.apache.org/jira/browse/ARROW-8574 This is an automated message from the Apache Git Serv

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r453670993 ## File path: csharp/src/Apache.Arrow/Arrays/Date32Array.cs ## @@ -55,16 +70,39 @@ public Date32Array(ArrayData data) public override void Acce

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r453673591 ## File path: csharp/src/Apache.Arrow/Arrays/DateArrayBuilder.cs ## @@ -0,0 +1,179 @@ +//

[GitHub] [arrow] pitrou opened a new pull request #7727: ARROW-9436: [C++][CI] Fix Valgrind failure

2020-07-13 Thread GitBox
pitrou opened a new pull request #7727: URL: https://github.com/apache/arrow/pull/7727 Some bits were left uninitialized in the expected boolean array. Also fix some warnings. This is an automated message from the Apac

[GitHub] [arrow] mr-smidge commented on a change in pull request #7654: ARROW-8581: [C#] Accept and return DateTime from DateXXArray

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7654: URL: https://github.com/apache/arrow/pull/7654#discussion_r453675969 ## File path: csharp/src/Apache.Arrow/Arrays/DelegatingArrayBuilder.cs ## @@ -0,0 +1,96 @@ +//---

[GitHub] [arrow] kszucs opened a new pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
kszucs opened a new pull request #7728: URL: https://github.com/apache/arrow/pull/7728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] kszucs commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
kszucs commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657586351 @github-actions crossbow submit wheel-osx-* This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #7727: ARROW-9436: [C++][CI] Fix Valgrind failure

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7727: URL: https://github.com/apache/arrow/pull/7727#issuecomment-657587626 https://issues.apache.org/jira/browse/ARROW-9436 This is an automated message from the Apache Git Serv

[GitHub] [arrow] github-actions[bot] commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657587629 https://issues.apache.org/jira/browse/ARROW-9437 This is an automated message from the Apache Git Serv

[GitHub] [arrow] github-actions[bot] commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657587490 Revision: bc1fecf8cd87c4415803afee53f85edd9ccab3ce Submitted crossbow builds: [ursa-labs/crossbow @ actions-407](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] mr-smidge commented on a change in pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7671: URL: https://github.com/apache/arrow/pull/7671#discussion_r453690625 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType) ValueOffse

[GitHub] [arrow] mr-smidge commented on a change in pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7671: URL: https://github.com/apache/arrow/pull/7671#discussion_r453690533 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType) ValueOffse

[GitHub] [arrow] mr-smidge commented on a change in pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7671: URL: https://github.com/apache/arrow/pull/7671#discussion_r453690865 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType) ValueOffse

[GitHub] [arrow] nevi-me closed pull request #7726: ARROW-8574: [Rust] Implement Debug for all plain types

2020-07-13 Thread GitBox
nevi-me closed pull request #7726: URL: https://github.com/apache/arrow/pull/7726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] mr-smidge commented on a change in pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-13 Thread GitBox
mr-smidge commented on a change in pull request #7671: URL: https://github.com/apache/arrow/pull/7671#discussion_r453692211 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType) ValueOffse

[GitHub] [arrow] mr-smidge commented on pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-13 Thread GitBox
mr-smidge commented on pull request #7671: URL: https://github.com/apache/arrow/pull/7671#issuecomment-657595775 > This is looking really good. I just have a few comments, and then it should be ready to merge. All comments should be addressed now :smile:. --

[GitHub] [arrow] jorisvandenbossche commented on pull request #7272: ARROW-8314: [Python] Add a Table.select method to select a subset of columns

2020-07-13 Thread GitBox
jorisvandenbossche commented on pull request #7272: URL: https://github.com/apache/arrow/pull/7272#issuecomment-657595819 @pitrou could you check the C++ test? This is an automated message from the Apache Git Service. To resp

[GitHub] [arrow] jorisvandenbossche edited a comment on pull request #7272: ARROW-8314: [Python] Add a Table.select method to select a subset of columns

2020-07-13 Thread GitBox
jorisvandenbossche edited a comment on pull request #7272: URL: https://github.com/apache/arrow/pull/7272#issuecomment-657595819 @pitrou could you check the C++ test? (fixing the linting issue) This is an automated me

[GitHub] [arrow] jorgecarleitao opened a new pull request #7729: ARROW-9420 [Rust][DataFusion] Added repartion physical plan

2020-07-13 Thread GitBox
jorgecarleitao opened a new pull request #7729: URL: https://github.com/apache/arrow/pull/7729 This is written on top of #7687, so we should merge the other first. This does not include any optimization to actually use this operation. We need to work out in a future PR. ---

[GitHub] [arrow] github-actions[bot] commented on pull request #7729: ARROW-9420 [Rust][DataFusion] Added repartion physical plan

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7729: URL: https://github.com/apache/arrow/pull/7729#issuecomment-657604297 https://issues.apache.org/jira/browse/ARROW-9420 This is an automated message from the Apache Git Serv

[GitHub] [arrow] andygrove closed pull request #7713: ARROW-8261: [Rust-DataFusion] Made limit accept integers and no longer accept expressions.

2020-07-13 Thread GitBox
andygrove closed pull request #7713: URL: https://github.com/apache/arrow/pull/7713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove closed pull request #7723: ARROW-9425: [Rust][DataFusion] Made ExecutionContext sharable and sync

2020-07-13 Thread GitBox
andygrove closed pull request #7723: URL: https://github.com/apache/arrow/pull/7723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove closed pull request #7724: ARROW-9427: [Rust][DataFusion] Added ExecutionContext.tables()

2020-07-13 Thread GitBox
andygrove closed pull request #7724: URL: https://github.com/apache/arrow/pull/7724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] pitrou opened a new pull request #7730: ARROW-9333: [Python] Expose more IPC options

2020-07-13 Thread GitBox
pitrou opened a new pull request #7730: URL: https://github.com/apache/arrow/pull/7730 Also make some optional arguments keyword-only. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] bkietz commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-13 Thread GitBox
bkietz commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453715480 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -780,11 +741,29 @@ Status GetReader(const SchemaField& field, const std::shared_ptr& Status FileReaderI

[GitHub] [arrow] jorgecarleitao commented on pull request #7729: ARROW-9420 [Rust][DataFusion] Added repartion physical plan

2020-07-13 Thread GitBox
jorgecarleitao commented on pull request #7729: URL: https://github.com/apache/arrow/pull/7729#issuecomment-657614516 One thing that is not clear to me yet is the idiom to handle RecordBatch and partitions. My understanding is that a Partition can be executed in parallel (thread), but a Re

[GitHub] [arrow] jorisvandenbossche merged pull request #7725: [Python][Doc] Fix rst role dataset.rst

2020-07-13 Thread GitBox
jorisvandenbossche merged pull request #7725: URL: https://github.com/apache/arrow/pull/7725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] jorgecarleitao commented on pull request #7729: ARROW-9420 [Rust][DataFusion] Added repartion physical plan

2020-07-13 Thread GitBox
jorgecarleitao commented on pull request #7729: URL: https://github.com/apache/arrow/pull/7729#issuecomment-657615416 Another point of contest here is that I have not tested what happens to rows with one key whose value is null.

[GitHub] [arrow] jorisvandenbossche commented on pull request #7725: [Python][Doc] Fix rst role dataset.rst

2020-07-13 Thread GitBox
jorisvandenbossche commented on pull request #7725: URL: https://github.com/apache/arrow/pull/7725#issuecomment-657615407 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] github-actions[bot] commented on pull request #7730: ARROW-9333: [Python] Expose more IPC options

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7730: URL: https://github.com/apache/arrow/pull/7730#issuecomment-657618643 https://issues.apache.org/jira/browse/ARROW-9333 This is an automated message from the Apache Git Serv

[GitHub] [arrow] kszucs commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
kszucs commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657626261 This heavily increases the build time (by ~1000s), I'm trying to find an alternative solution. This is an automate

[GitHub] [arrow] pitrou opened a new pull request #7731: ARROW-9428: [C++][Doc] Update buffer allocation documentation

2020-07-13 Thread GitBox
pitrou opened a new pull request #7731: URL: https://github.com/apache/arrow/pull/7731 Use Result-returning AllocateBuffer() version in example. Also improve cross-referencing in some places. This is an automated messa

[GitHub] [arrow] kszucs commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
kszucs commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657629261 @github-actions crossbow submit wheel-osx-cp37m This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] github-actions[bot] commented on pull request #7731: ARROW-9428: [C++][Doc] Update buffer allocation documentation

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7731: URL: https://github.com/apache/arrow/pull/7731#issuecomment-657629920 https://issues.apache.org/jira/browse/ARROW-9428 This is an automated message from the Apache Git Serv

[GitHub] [arrow] github-actions[bot] commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657630349 Revision: 3918afa462f461c4c3e63858fa7273b8354e3e8c Submitted crossbow builds: [ursa-labs/crossbow @ actions-408](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] kszucs opened a new pull request #7732: [Python][CI] Create a build for validating python docstrings

2020-07-13 Thread GitBox
kszucs opened a new pull request #7732: URL: https://github.com/apache/arrow/pull/7732 Using the existing numpydoc checker in archery. I've enabled a single rule to check undocumented arguments. This is an automated message

[GitHub] [arrow] github-actions[bot] commented on pull request #7732: [Python][CI] Create a build for validating python docstrings

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7732: URL: https://github.com/apache/arrow/pull/7732#issuecomment-657640362 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] kszucs commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
kszucs commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657656109 @github-actions crossbow submit wheel-osx-cp37m This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] github-actions[bot] commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657657271 Revision: c0a81d435f49e437334e2f12fa0b666b92bdaf3c Submitted crossbow builds: [ursa-labs/crossbow @ actions-409](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] kszucs commented on pull request #7727: ARROW-9436: [C++][CI] Fix Valgrind failure

2020-07-13 Thread GitBox
kszucs commented on pull request #7727: URL: https://github.com/apache/arrow/pull/7727#issuecomment-657657578 @github-actions crossbow submit conda-cpp-valgrind This is an automated message from the Apache Git Service. To res

[GitHub] [arrow] kszucs commented on pull request #7727: ARROW-9436: [C++][CI] Fix Valgrind failure

2020-07-13 Thread GitBox
kszucs commented on pull request #7727: URL: https://github.com/apache/arrow/pull/7727#issuecomment-657673216 @github-actions crossbow submit test-conda-cpp-valgrind This is an automated message from the Apache Git Service. T

[GitHub] [arrow] kszucs commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
kszucs commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657673393 @github-actions crossbow submit wheel-osx-* This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #7728: ARROW-9437: [Python][Packaging] Hombrew fails to install build dependencies in the macOS wheel builds

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7728: URL: https://github.com/apache/arrow/pull/7728#issuecomment-657674145 Revision: c0a81d435f49e437334e2f12fa0b666b92bdaf3c Submitted crossbow builds: [ursa-labs/crossbow @ actions-410](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] github-actions[bot] commented on pull request #7727: ARROW-9436: [C++][CI] Fix Valgrind failure

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7727: URL: https://github.com/apache/arrow/pull/7727#issuecomment-657674238 Revision: 5bb36e669d872a07a3848b669670316627000282 Submitted crossbow builds: [ursa-labs/crossbow @ actions-410](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] bkietz commented on a change in pull request #7731: ARROW-9428: [C++][Doc] Update buffer allocation documentation

2020-07-13 Thread GitBox
bkietz commented on a change in pull request #7731: URL: https://github.com/apache/arrow/pull/7731#discussion_r453792540 ## File path: docs/source/cpp/memory.rst ## @@ -71,11 +74,12 @@ You can allocate a buffer yourself by calling one of the :func:`arrow::AllocateBuffer` or :f

[GitHub] [arrow] wesm commented on a change in pull request #7684: ARROW-9374: [C++][Python] Expose MakeArrayFromScalar

2020-07-13 Thread GitBox
wesm commented on a change in pull request #7684: URL: https://github.com/apache/arrow/pull/7684#discussion_r453807979 ## File path: cpp/src/arrow/array/array_test.cc ## @@ -384,6 +398,40 @@ TEST_F(TestArray, TestMakeArrayFromScalar) { } } +TEST_F(TestArray, TestMakeArray

[GitHub] [arrow] wesm closed pull request #7684: ARROW-9374: [C++][Python] Expose MakeArrayFromScalar

2020-07-13 Thread GitBox
wesm closed pull request #7684: URL: https://github.com/apache/arrow/pull/7684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm closed pull request #7731: ARROW-9428: [C++][Doc] Update buffer allocation documentation

2020-07-13 Thread GitBox
wesm closed pull request #7731: URL: https://github.com/apache/arrow/pull/7731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
wesm commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657692574 > Do you mean you would like to edit a CSV table in a spreadsheet? Yeah I think that would be the idea This is

[GitHub] [arrow] pitrou commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657696511 I think that would be a rather terrible doc writing experience: each time you want to update those docs, you have to fire a different tool for some part of the page. Also, you woul

[GitHub] [arrow] wesm commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
wesm commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657697264 I guess it's a matter of perspective. I don't feel at all comfortable editing the RST tables, whereas I would be fine editing a CSV file

[GitHub] [arrow] wesm closed pull request #7727: ARROW-9436: [C++][CI] Fix Valgrind failure

2020-07-13 Thread GitBox
wesm closed pull request #7727: URL: https://github.com/apache/arrow/pull/7727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] wesm edited a comment on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
wesm edited a comment on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657697264 I guess it's a matter of perspective. I don't feel at all comfortable editing the RST tables, whereas I would be fine editing a CSV file. Many text editors (e.g. emacs, vim) h

[GitHub] [arrow] pitrou commented on pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
pitrou commented on pull request #7695: URL: https://github.com/apache/arrow/pull/7695#issuecomment-657699568 The three options I would be comfortable with are those I proposed in my comment above. I think it would be clumsy to have to edit separate _files_ using a spreadsheet editor to up

[GitHub] [arrow] wesm closed pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-13 Thread GitBox
wesm closed pull request #7695: URL: https://github.com/apache/arrow/pull/7695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] pitrou opened a new pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
pitrou opened a new pull request #7733: URL: https://github.com/apache/arrow/pull/7733 Also add argument-checking variants of SliceBuffer, SliceMutableBuffer, Array::Slice and ArrayData::Slice. Should fix the following issue: * https://bugs.chromium.org/p/oss-fuzz/issues/detail?id

[GitHub] [arrow] wesm closed pull request #7730: ARROW-9333: [Python] Expose more IPC options

2020-07-13 Thread GitBox
wesm closed pull request #7730: URL: https://github.com/apache/arrow/pull/7730 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] francisco-hoo commented on pull request #7334: ARROW-5082: [Python] Substantially reduce Python wheel package and install size

2020-07-13 Thread GitBox
francisco-hoo commented on pull request #7334: URL: https://github.com/apache/arrow/pull/7334#issuecomment-657701553 How can I download this ~15MB .whl version of PyArrow? Just find the `pyarrow-0.17.1-cp38-cp38-manylinux2014_x86_64.whl (63.8 MB)` version. Due to AWS Lambda-Layers lim

[GitHub] [arrow] pitrou commented on pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
pitrou commented on pull request #7733: URL: https://github.com/apache/arrow/pull/7733#issuecomment-657701477 @github-actions crossbow submit conda-cpp-valgrind This is an automated message from the Apache Git Service. To res

[GitHub] [arrow] pitrou commented on pull request #7334: ARROW-5082: [Python] Substantially reduce Python wheel package and install size

2020-07-13 Thread GitBox
pitrou commented on pull request #7334: URL: https://github.com/apache/arrow/pull/7334#issuecomment-657704528 @francisco-hoo For now this is only available in nightly builds: https://arrow.apache.org/docs/python/install.html#installing-nightly-packages Soon we will release a 1.0.0

[GitHub] [arrow] pitrou commented on pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
pitrou commented on pull request #7733: URL: https://github.com/apache/arrow/pull/7733#issuecomment-657706437 I've checked that this runs fine on Valgrind. This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] bkietz commented on a change in pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
bkietz commented on a change in pull request #7733: URL: https://github.com/apache/arrow/pull/7733#discussion_r453830282 ## File path: cpp/src/arrow/buffer.cc ## @@ -43,6 +44,56 @@ Result> Buffer::CopySlice(const int64_t start, return std::move(new_buffer); } +namespace

[GitHub] [arrow] pitrou commented on a change in pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7733: URL: https://github.com/apache/arrow/pull/7733#discussion_r453832881 ## File path: cpp/src/arrow/array/data.cc ## @@ -105,6 +106,22 @@ std::shared_ptr ArrayData::Slice(int64_t off, int64_t len) const { return copy; } +R

[GitHub] [arrow] pitrou commented on a change in pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7733: URL: https://github.com/apache/arrow/pull/7733#discussion_r453833318 ## File path: cpp/src/arrow/array/concatenate.cc ## @@ -151,6 +151,10 @@ static Status PutOffsets(const std::shared_ptr& src, Offset first_offset retur

[GitHub] [arrow] pitrou commented on a change in pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7733: URL: https://github.com/apache/arrow/pull/7733#discussion_r453833175 ## File path: cpp/src/arrow/buffer.cc ## @@ -43,6 +44,56 @@ Result> Buffer::CopySlice(const int64_t start, return std::move(new_buffer); } +namespace

[GitHub] [arrow] pitrou commented on a change in pull request #7733: ARROW-9439: [C++] Fix crash on invalid IPC input

2020-07-13 Thread GitBox
pitrou commented on a change in pull request #7733: URL: https://github.com/apache/arrow/pull/7733#discussion_r453835979 ## File path: cpp/src/arrow/array/data.cc ## @@ -105,6 +106,22 @@ std::shared_ptr ArrayData::Slice(int64_t off, int64_t len) const { return copy; } +R

[GitHub] [arrow] vertexclique opened a new pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

2020-07-13 Thread GitBox
vertexclique opened a new pull request #7734: URL: https://github.com/apache/arrow/pull/7734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] pitrou commented on pull request #7272: ARROW-8314: [Python] Add a Table.select method to select a subset of columns

2020-07-13 Thread GitBox
pitrou commented on pull request #7272: URL: https://github.com/apache/arrow/pull/7272#issuecomment-657714249 @jorisvandenbossche I'll take a look when I'm done with 1.0.0-critical tasks. Hopefully before the end of the week :-)

[GitHub] [arrow] github-actions[bot] commented on pull request #7734: ARROW-8480: [Rust] Use NonNull well aligned pointer as Unique reference

2020-07-13 Thread GitBox
github-actions[bot] commented on pull request #7734: URL: https://github.com/apache/arrow/pull/7734#issuecomment-657714889 https://issues.apache.org/jira/browse/ARROW-8480 This is an automated message from the Apache Git Serv

  1   2   >