vvellanki commented on a change in pull request #7782:
URL: https://github.com/apache/arrow/pull/7782#discussion_r455560320
##
File path: cpp/src/gandiva/precompiled/timestamp_arithmetic.cc
##
@@ -66,7 +96,7 @@ extern "C" {
if (end_tm.TmMday() < start_tm.TmMday()) {
tianchen92 commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-659219834
>My current understanding is there is a cycle here which needs to be broken
(@tianchen92 please let me know if understand the issues correcty).
@emkornfield sorry for the
kszucs opened a new pull request #7783:
URL: https://github.com/apache/arrow/pull/7783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#issuecomment-659257753
https://issues.apache.org/jira/browse/ARROW-9504
This is an automated message from the Apache Git Serv
pitrou commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659319039
I think this PR is wrong. The null count is incremented when the pending
data is committed to the builder.
This is
pitrou commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455681439
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -284,6 +284,66 @@ def test_take_indices_types():
arr.take(indices)
+def test_take_o
pitrou commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659322407
Actually, we're lucky: the null count is overwritten by
`UnsafeAppendToBitmap(const uint8_t* valid_bytes, int64_t length)`. Still, I
think it was hasty to merge this PR during the
sunchao commented on pull request #7751:
URL: https://github.com/apache/arrow/pull/7751#issuecomment-659329634
@jorgecarleitao thanks! seems this is not a bug in C++ as Parquet only uses
int32 to represent date while Arrow uses both int32 and int64. Therefore, when
you write a int64 date f
liyafan82 commented on pull request #7748:
URL: https://github.com/apache/arrow/pull/7748#issuecomment-659333289
> Thanks for doing this. Could you please be sure to add this function to
https://github.com/apache/arrow/blob/master/docs/source/cpp/compute.rst?
Done. Thanks for your ki
kszucs commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455723033
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -284,6 +284,66 @@ def test_take_indices_types():
arr.take(indices)
+def test_take_o
kszucs commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455723338
##
File path: python/pyarrow/_compute.pyx
##
@@ -189,7 +191,7 @@ num_kernels: {}
with nogil:
result = GetResultValue(self.base_func.Exe
kszucs commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455723830
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -284,6 +284,66 @@ def test_take_indices_types():
arr.take(indices)
+def test_take_o
pitrou opened a new pull request #7784:
URL: https://github.com/apache/arrow/pull/7784
Vendor relevant code from the portable-snippets library (~ public domain):
https://github.com/nemequ/portable-snippets/tree/master/safe-math
Also fix some bugs in checked arithmetic (null values
kszucs opened a new pull request #7785:
URL: https://github.com/apache/arrow/pull/7785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659361027
@github-actions crossbow submit wheel-osx-cp37m wheel-osx-cp35m
This is an automated message from the Apache Git Se
github-actions[bot] commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659364085
Revision: 60ab09e1bc0808f0b46b8f45cd4619871d30ec7f
Submitted crossbow builds: [ursa-labs/crossbow @
actions-426](https://github.com/ursa-labs/crossbow/branches/a
kszucs closed pull request #7779:
URL: https://github.com/apache/arrow/pull/7779
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #7784:
URL: https://github.com/apache/arrow/pull/7784#issuecomment-659371394
https://issues.apache.org/jira/browse/ARROW-9402
This is an automated message from the Apache Git Serv
kszucs commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455723033
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -284,6 +284,66 @@ def test_take_indices_types():
arr.take(indices)
+def test_take_o
kszucs commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455741020
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -284,6 +284,66 @@ def test_take_indices_types():
arr.take(indices)
+def test_take_o
kszucs commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455741659
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -284,6 +284,66 @@ def test_take_indices_types():
arr.take(indices)
+def test_take_o
kszucs commented on a change in pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#discussion_r455742169
##
File path: dev/tasks/python-wheels/travis.osx.yml
##
@@ -64,7 +62,7 @@ install:
# install the built wheel and test dependencies
- install_wheel arro
kszucs commented on a change in pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#discussion_r455742672
##
File path: dev/tasks/python-wheels/travis.osx.yml
##
@@ -74,8 +72,8 @@ install:
# crossbow dependencies for deployment
- unset MACOSX_DEPLOYMENT_T
kszucs commented on a change in pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#discussion_r455742672
##
File path: dev/tasks/python-wheels/travis.osx.yml
##
@@ -74,8 +72,8 @@ install:
# crossbow dependencies for deployment
- unset MACOSX_DEPLOYMENT_T
pitrou commented on a change in pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#discussion_r455743862
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -284,6 +284,66 @@ def test_take_indices_types():
arr.take(indices)
+def test_take_o
wesm commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659391073
Apologies. Perhaps we can open a JIRA to enhance test coverage around this
issue
This is an automated message from t
pitrou commented on pull request #7783:
URL: https://github.com/apache/arrow/pull/7783#issuecomment-659406064
AppVeyor: https://ci.appveyor.com/project/kszucs/arrow/builds/34131280
This is an automated message from the Apache
pitrou closed pull request #7783:
URL: https://github.com/apache/arrow/pull/7783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mrkn commented on pull request #7780:
URL: https://github.com/apache/arrow/pull/7780#issuecomment-659414501
Committing the pending data does not occur every time after calling
`AppendNull` so `null_count` couldn't reflect the number of nulls in realtime
without incrementing in `AppendNull`
kszucs commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659463129
@github-actions crossbow submit wheel-osx-cp37m wheel-osx-cp35m
This is an automated message from the Apache Git Se
github-actions[bot] commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659465395
Revision: 981632a97bacf594277ae29339ccae8d8fb21e0f
Submitted crossbow builds: [ursa-labs/crossbow @
actions-427](https://github.com/ursa-labs/crossbow/branches/a
pitrou commented on pull request #7784:
URL: https://github.com/apache/arrow/pull/7784#issuecomment-659504776
I think I finally squashed the horrid Windows preprocessor macro issues
(Windows headers define OPTIONAL, but you can't undef it blindly because other
subsequent includes may requi
pitrou commented on pull request #7784:
URL: https://github.com/apache/arrow/pull/7784#issuecomment-659505609
@wesm You'll probably want to take a look at the codegen changes when you
have some time.
This is an automated mes
github-actions[bot] commented on pull request #7771:
URL: https://github.com/apache/arrow/pull/7771#issuecomment-659592893
https://issues.apache.org/jira/browse/ARROW-9479
This is an automated message from the Apache Git Serv
kszucs commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659605453
Ran the builds manually:
- [cp37m](https://travis-ci.org/github/ursa-labs/crossbow/builds/708848647):
green
- [cp35m](https://travis-ci.org/github/ursa-labs/crossbow/builds/70
kszucs commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659606947
Luckily the build times have improved by ~8 minutes.
This is an automated message from the Apache Git Service.
To r
kszucs commented on a change in pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#discussion_r456007128
##
File path: dev/tasks/python-wheels/travis.osx.yml
##
@@ -18,6 +18,35 @@ os: osx
osx_image: xcode11.3
language: generic
+addons:
+ homebrew:
+pack
kszucs commented on a change in pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#discussion_r456007128
##
File path: dev/tasks/python-wheels/travis.osx.yml
##
@@ -18,6 +18,35 @@ os: osx
osx_image: xcode11.3
language: generic
+addons:
+ homebrew:
+pack
github-actions[bot] commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659610053
https://issues.apache.org/jira/browse/ARROW-9506
This is an automated message from the Apache Git Serv
miriambron opened a new issue #7786:
URL: https://github.com/apache/arrow/issues/7786
While trying to use VarCharVector safe set method,
seems that if the new value size is greater then the existing one,
the value is overriding the next bytes in the vector.
kszucs commented on pull request #7785:
URL: https://github.com/apache/arrow/pull/7785#issuecomment-659619537
All green, merging.
This is an automated message from the Apache Git Service.
To respond to the message, please log
kszucs closed pull request #7785:
URL: https://github.com/apache/arrow/pull/7785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kszucs opened a new pull request #7787:
URL: https://github.com/apache/arrow/pull/7787
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #7778:
URL: https://github.com/apache/arrow/pull/7778#issuecomment-659640498
Closing in favor of #7787
This is an automated message from the Apache Git Service.
To respond to the message, ple
kszucs closed pull request #7778:
URL: https://github.com/apache/arrow/pull/7778
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kszucs commented on pull request #7787:
URL: https://github.com/apache/arrow/pull/7787#issuecomment-659640576
@github-actions crossbow submit verify-rc-source-*
This is an automated message from the Apache Git Service.
To res
github-actions[bot] commented on pull request #7787:
URL: https://github.com/apache/arrow/pull/7787#issuecomment-659641547
Revision: aef165c1c9725d20dcea7a5f4326c5a9b7f21910
Submitted crossbow builds: [ursa-labs/crossbow @
actions-428](https://github.com/ursa-labs/crossbow/branches/a
nealrichardson commented on pull request #7778:
URL: https://github.com/apache/arrow/pull/7778#issuecomment-659642691
FWIW you don't need a new PR, you can just edit the scripts again on the
same branch to say rc1 instead of rc0.
---
paddyhoran opened a new pull request #7788:
URL: https://github.com/apache/arrow/pull/7788
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #7788:
URL: https://github.com/apache/arrow/pull/7788#issuecomment-659648161
https://issues.apache.org/jira/browse/ARROW-9503
This is an automated message from the Apache Git Serv
patrickpai opened a new pull request #7789:
URL: https://github.com/apache/arrow/pull/7789
This patch makes arrow's Lz4Codec compatible with the Hadoop Lz4Codec by
prepending 8 bytes (two `uint32_t`s representing expected decompressed size in
bytes and compressed size in bytes) to arrow's
github-actions[bot] commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-659655618
https://issues.apache.org/jira/browse/PARQUET-1878
This is an automated message from the Apache Git Se
patrickpai commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-659656433
Run clang-format on cpp
This is an automated message from the Apache Git Service.
To respond to the message, pl
patrickpai commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-659664170
@github-actions autotune Run clang-format on cpp
This is an automated message from the Apache Git Service.
To r
nealrichardson commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-659665810
So, one of the things we haven't sorted out about the comment-bot is that
when it pushes its commit, GitHub Actions builds aren't triggered. You'll want
to look at the buil
patrickpai commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-659667262
Gotcha, thanks for letting me know!
This is an automated message from the Apache Git Service.
To respond to the
eerhardt commented on a change in pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#discussion_r456091623
##
File path: csharp/src/Apache.Arrow/Arrays/Date64Array.cs
##
@@ -15,56 +15,94 @@
using Apache.Arrow.Types;
using System;
-using System.Collections.Ge
kszucs opened a new pull request #7790:
URL: https://github.com/apache/arrow/pull/7790
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #7790:
URL: https://github.com/apache/arrow/pull/7790#issuecomment-659704680
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
wjones1 commented on pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#issuecomment-659710775
I have the unittests passing locally but they seem to be failing in CI. I
probably need to rebase again and test. Will do so when I get some time this
weekend.
-
patrickpai commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-659770909
@github-actions autotune Run clang-format on cpp
This is an automated message from the Apache Git Service.
To r
fredgan commented on pull request #7752:
URL: https://github.com/apache/arrow/pull/7752#issuecomment-659776260
@sbinet
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
fredgan commented on pull request #7754:
URL: https://github.com/apache/arrow/pull/7754#issuecomment-659776069
@sbinet Hi, would you mind having a look?
This is an automated message from the Apache Git Service.
To respond to
kszucs commented on pull request #7787:
URL: https://github.com/apache/arrow/pull/7787#issuecomment-659783459
@github-actions crossbow submit verify-rc-binaries-* verify-rc-wheels-*
This is an automated message from the Apach
github-actions[bot] commented on pull request #7787:
URL: https://github.com/apache/arrow/pull/7787#issuecomment-659783962
Revision: aef165c1c9725d20dcea7a5f4326c5a9b7f21910
Submitted crossbow builds: [ursa-labs/crossbow @
actions-429](https://github.com/ursa-labs/crossbow/branches/a
sunchao closed pull request #7788:
URL: https://github.com/apache/arrow/pull/7788
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
66 matches
Mail list logo
