emkornfield opened a new pull request #7805:
URL: https://github.com/apache/arrow/pull/7805
Draft PR to enable round trip to TZ info to hopefully solve spark issues.
This is an automated message from the Apache Git Service.
T
emkornfield commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660844779
@github-actions crossbow submit test-conda-python-3.7-spark-master
This is an automated message from the Apach
jorgecarleitao opened a new pull request #7806:
URL: https://github.com/apache/arrow/pull/7806
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
emkornfield commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660848232
@github-actions crossbow submit test-conda-python-3.7-spark-master
This is an automated message from the Apach
github-actions[bot] commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660848831
https://issues.apache.org/jira/browse/ARROW-9528
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #7806:
URL: https://github.com/apache/arrow/pull/7806#issuecomment-660848829
https://issues.apache.org/jira/browse/ARROW-9527
This is an automated message from the Apache Git Serv
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457121068
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj))
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457121774
##
File path: python/pyarrow/scalar.pxi
##
@@ -331,7 +331,8 @@ cdef class Date64Scalar(Scalar):
def as_py(self):
"""
-Return thi
kou commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660855376
@github-actions crossbow submit test-conda-python-3.8-spark-master
This is an automated message from the Apache Git Se
github-actions[bot] commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660856056
Revision: a5b2a51665ab1383fb371ecd76bb3c20c4bf8726
Submitted crossbow builds: [ursa-labs/crossbow @
actions-433](https://github.com/ursa-labs/crossbow/branches/a
kou commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660856402
We can use task listed only in
https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L1930 for
`crossbow submit`.
We don't have `...-3.7-...` task. We only have `...-3.8-
emkornfield commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-660857649
@kou 3.8 should be fine. Thank you!. I copied the command from the previous
PR related to datetimes, I guess CI has changed since then.
-
jorgecarleitao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-660877250
@sunchao , I moved the coverage to run on the docker image and added
reporting to codecov to github's workflow.
Since coverage reporting requires a different compilat
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457173202
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj)) {
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457176423
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def test
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457177694
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj)) {
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457178228
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def test
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457178426
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def test
zhztheplayer commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-660927861
Sorry I am reconsidering whether to use JVM direct memory as a limit of
native buffer allocation. By Oracle's explanation[1] about direct memory,
direct memory seems only to
zhztheplayer edited a comment on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-660927861
Sorry I am reconsidering whether to use JVM direct memory as a limit of
native buffer allocation. Technically by Oracle's explanation[1] about direct
memory, direct me
kszucs closed pull request #7801:
URL: https://github.com/apache/arrow/pull/7801
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kszucs commented on pull request #7800:
URL: https://github.com/apache/arrow/pull/7800#issuecomment-660948169
Thanks @projjal!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kszucs closed pull request #7800:
URL: https://github.com/apache/arrow/pull/7800
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kszucs commented on pull request #7799:
URL: https://github.com/apache/arrow/pull/7799#issuecomment-660949359
Thanks @jorgecarleitao, it looks like a nice improvement. Currently I'm
working on the next release candidate, but I'll take a look at it afterwards.
-
kszucs closed pull request #7792:
URL: https://github.com/apache/arrow/pull/7792
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kszucs commented on pull request #7792:
URL: https://github.com/apache/arrow/pull/7792#issuecomment-660949955
Closing in favor of
https://github.com/apache/arrow/commit/83679f3b46e2c12e8f506c76323341c1d05b7d01#diff-3ebb5f8536634a43ccb884fcd453b1cdL88
--
praveenbingo commented on pull request #7782:
URL: https://github.com/apache/arrow/pull/7782#issuecomment-660959362
thanks @sagnikc-dremio
This is an automated message from the Apache Git Service.
To respond to the message,
praveenbingo closed pull request #7782:
URL: https://github.com/apache/arrow/pull/7782
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mr-smidge commented on pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#issuecomment-660971998
@eerhardt , is there a way to re-trigger build checks? The `C# / AMD64
MacOS 10.15 C# 2.2.103 (pull_request)` check failed with an unhelpful "This
check failed" error message -
projjal commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r45731
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -16,6 +16,7 @@
// under the License.
// String functions
+#include
Review comment:
projjal commented on a change in pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#discussion_r457316490
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -322,6 +387,138 @@ const char* trim_utf8(gdv_int64 context, const char*
data, gdv_int32 data_
kszucs commented on pull request #7793:
URL: https://github.com/apache/arrow/pull/7793#issuecomment-661050757
@ursabot benchmark --suite-filter=value-parsing
This is an automated message from the Apache Git Service.
To respon
romainfrancois opened a new pull request #7807:
URL: https://github.com/apache/arrow/pull/7807
Either passing down NULL or a Schema.
But perhaps a schema is confusing because the only thing that is being
controlled by it here is the types, not their order etc .. which I believe
fee
github-actions[bot] commented on pull request #7807:
URL: https://github.com/apache/arrow/pull/7807#issuecomment-661060579
https://issues.apache.org/jira/browse/ARROW-6537
This is an automated message from the Apache Git Serv
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457421000
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj))
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457422354
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def
bkietz removed a comment on pull request #7793:
URL: https://github.com/apache/arrow/pull/7793#issuecomment-660406335
@ursabot benchmark diff --suite-filter=value-parsing
This is an automated message from the Apache Git Servi
ursabot removed a comment on pull request #7793:
URL: https://github.com/apache/arrow/pull/7793#issuecomment-660406370
[AMD64 Ubuntu 18.04 C++ Benchmark
(#120194)](https://ci.ursalabs.org/#builders/73/builds/96) builder failed.
Revision: 008b24cda168481b01f4caf696403e4d7358f191
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457425287
##
File path: python/pyarrow/tests/test_array.py
##
@@ -300,6 +301,8 @@ def test_nulls(ty):
def test_array_from_scalar():
today = datetime.date.today()
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457436813
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj)) {
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457436813
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj)) {
pitrou commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457445991
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3325,6 +3325,21 @@ def test_cast_timestamp_unit():
assert result.equals(expected)
+def test
MosheVai commented on issue #1336:
URL: https://github.com/apache/arrow/issues/1336#issuecomment-661101732
@wesm I seem to run into the exact same problem is it fixed?
This is an automated message from the Apache Git Service.
kszucs commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661106422
My main concern with this solution is while it resolves the pandas
roundtrip, the intermediate array values are different.
People may "rely" on the previous buggy behavior, and I
kszucs edited a comment on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661106422
My main concern with this solution is while it resolves the pandas
roundtrip, the intermediate array values are different.
People may "rely" on the previous buggy behavior
kszucs closed pull request #7790:
URL: https://github.com/apache/arrow/pull/7790
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kszucs opened a new pull request #7808:
URL: https://github.com/apache/arrow/pull/7808
All of the nightly conda package builds are failing with dependency
resolution issues:
https://github.com/ursa-labs/crossbow/branches/all?query=nightly-2020-07-20-0-azure-conda
Hopefully updating
kszucs commented on pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#issuecomment-661118394
@github-actions crossbow submit -g conda
This is an automated message from the Apache Git Service.
To respond to th
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457510267
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj))
emkornfield commented on a change in pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#discussion_r457510267
##
File path: cpp/src/arrow/python/inference.cc
##
@@ -332,6 +329,13 @@ class TypeInferrer {
++int_count_;
} else if (PyDateTime_Check(obj))
github-actions[bot] commented on pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#issuecomment-661126012
Revision: 1ef88e3fc2d69ff1af46e840e0afb8c7d497f929
Submitted crossbow builds: [ursa-labs/crossbow @
actions-434](https://github.com/ursa-labs/crossbow/branches/a
emkornfield commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661127682
@kszucs Breaking users is a concern, I'll add an environment variable for
both this change and the previous one that can keep the old buggy behavior.
Just to clarify: was act
kszucs commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661130910
> @kszucs Breaking users is a concern, I'll add an environment variable for
both this change and the previous one that can keep the old buggy behavior.
Just to clarify: was actuall
kszucs edited a comment on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661130910
> @kszucs Breaking users is a concern, I'll add an environment variable for
both this change and the previous one that can keep the old buggy behavior.
Just to clarify: was
sunchao commented on pull request #7797:
URL: https://github.com/apache/arrow/pull/7797#issuecomment-661139731
Thanks @jorgecarleitao ! IMO the compilation time is important so let's see
of #7799 goes. I'll take a look later today.
eerhardt commented on pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#issuecomment-661158367
> is there a way to re-trigger build checks?
In other repos I've used the "Ru-run jobs" button on the "Checks" tab:
](https://ci.ursalabs.org/#builders/98/builds/646) builder failed.
Revision: 12840af97c9903a36877f7e494ed54fccbde1217
Clone Arro
eerhardt commented on a change in pull request #7654:
URL: https://github.com/apache/arrow/pull/7654#discussion_r457569636
##
File path: csharp/src/Apache.Arrow/Arrays/DelegatingArrayBuilder.cs
##
@@ -0,0 +1,96 @@
+//
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661209001
@ursabot crossbow submit test-conda-python-3.8-spark-master
This is an automated message from the Apache Git S
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661210665
@kszucs is there a way to kick off Spark integration tests right now on
master?
This is an automated message
sbinet commented on pull request #7752:
URL: https://github.com/apache/arrow/pull/7752#issuecomment-661234225
(apologies: I don't get notifications when a commit is force-pushed, and
also I am on holidays with spotty internet access)
I'd say just create a minimal dataset to go through th
BryanCutler commented on pull request #7805:
URL: https://github.com/apache/arrow/pull/7805#issuecomment-661238238
Just to clarify things, is the main concern with this patch over keeping the
previous buggy behavior? Besides that are these changes producing correct
results and passing roun
andygrove opened a new pull request #7809:
URL: https://github.com/apache/arrow/pull/7809
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kszucs commented on pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#issuecomment-661255732
The windows failures must be caused by the recent CF dependency updates (at
least setuptools has a different build hash).
They are not mandatory for the release, so +1.
--
andygrove commented on pull request #7798:
URL: https://github.com/apache/arrow/pull/7798#issuecomment-661255507
@yordan-pavlov This is exciting! I will start reviewing this later today.
This is an automated message from the
kszucs edited a comment on pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#issuecomment-661255732
The windows failures must be caused by the recent CF dependency updates (at
least setuptools has a different build hash). cc @xhochy
They are not mandatory for the r
kszucs closed pull request #7808:
URL: https://github.com/apache/arrow/pull/7808
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andygrove closed pull request #7795:
URL: https://github.com/apache/arrow/pull/7795
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7806:
URL: https://github.com/apache/arrow/pull/7806
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661257796
@BryanCutler I already submitted them, the spark tests are still running
https://github.com/ursa-labs/crossbow/branches/all?query=build-871
---
github-actions[bot] commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661260249
https://issues.apache.org/jira/browse/ARROW-9534
This is an automated message from the Apache Git Serv
xhochy commented on a change in pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#discussion_r457615350
##
File path: dev/tasks/conda-recipes/azure.win.yml
##
@@ -34,11 +34,10 @@ jobs:
- task: CondaEnvironment@1
inputs:
-packageSpecs: 'pyt
andygrove commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661264618
@jorgecarleitao fyi
This is an automated message from the Apache Git Service.
To respond to the message, please
xhochy opened a new pull request #7810:
URL: https://github.com/apache/arrow/pull/7810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661269532
@BryanCutler seems like the spark tests are passing with the current master.
This is an automated message from the
xhochy commented on pull request #7810:
URL: https://github.com/apache/arrow/pull/7810#issuecomment-661270079
@github-actions crossbow submit conda-win-vs2017-py36
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7810:
URL: https://github.com/apache/arrow/pull/7810#issuecomment-661271016
Revision: 621022a99122277494b14693dd085b61ee02d1cb
Submitted crossbow builds: [ursa-labs/crossbow @
actions-436](https://github.com/ursa-labs/crossbow/branches/a
jorgecarleitao commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661276604
Nice! I just needed this in my ballista's PR!
following [this SO answer](https://stackoverflow.com/a/40776087/931303),
what do you think of
```
trait Litera
andygrove commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661283955
@jorgecarleitao Oh, that is much nicer. Do you want to PR that and I'll
close this one?
This is an automated me
jorgecarleitao commented on pull request #7809:
URL: https://github.com/apache/arrow/pull/7809#issuecomment-661286169
I can take it.
This is an automated message from the Apache Git Service.
To respond to the message, please
patrickpai commented on pull request #7789:
URL: https://github.com/apache/arrow/pull/7789#issuecomment-661292801
Does anyone know if I'm supposed to be able to see logs for failing checks?
When I view the details for a failing check, I can't see any error messages to
help figure out what
kszucs commented on a change in pull request #7808:
URL: https://github.com/apache/arrow/pull/7808#discussion_r457650256
##
File path: dev/tasks/conda-recipes/azure.win.yml
##
@@ -34,11 +34,10 @@ jobs:
- task: CondaEnvironment@1
inputs:
-packageSpecs: 'pyt
andygrove closed pull request #7809:
URL: https://github.com/apache/arrow/pull/7809
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
BryanCutler commented on pull request #7802:
URL: https://github.com/apache/arrow/pull/7802#issuecomment-661296416
great, thanks @kszucs !
This is an automated message from the Apache Git Service.
To respond to the message, p
kszucs commented on pull request #7782:
URL: https://github.com/apache/arrow/pull/7782#issuecomment-661305131
@praveenbingo please don't forget to add the relevant components
`[C++][Gandiva]` to the pull request's title.
Thi
jorgecarleitao opened a new pull request #7811:
URL: https://github.com/apache/arrow/pull/7811
@andygrove fyi
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
jorgecarleitao commented on a change in pull request #7811:
URL: https://github.com/apache/arrow/pull/7811#discussion_r457663076
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -378,9 +378,44 @@ pub fn col(name: &str) -> Expr {
Expr::UnresolvedColumn(name.to_owned()
andygrove commented on pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#issuecomment-661308588
fyi @jorgecarleitao
This is an automated message from the Apache Git Service.
To respond to the message, please
andygrove opened a new pull request #7812:
URL: https://github.com/apache/arrow/pull/7812
This allows physical expressions to be printed in a human-readable form and
is a step towards a printable physical plan.
This is an au
github-actions[bot] commented on pull request #7812:
URL: https://github.com/apache/arrow/pull/7812#issuecomment-661311089
https://issues.apache.org/jira/browse/ARROW-9507
This is an automated message from the Apache Git Serv
1 - 100 of 140 matches
Mail list logo
