github-actions[bot] commented on pull request #8803:
URL: https://github.com/apache/arrow/pull/8803#issuecomment-735625165
https://issues.apache.org/jira/browse/ARROW-10772
This is an automated message from the Apache Git Ser
ritchie46 commented on a change in pull request #8803:
URL: https://github.com/apache/arrow/pull/8803#discussion_r532413954
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -214,19 +215,20 @@ where
let null_count = array.null_count();
-// This iteration i
Dandandan commented on a change in pull request #8803:
URL: https://github.com/apache/arrow/pull/8803#discussion_r532415763
##
File path: rust/arrow/src/compute/kernels/take.rs
##
@@ -214,19 +215,20 @@ where
let null_count = array.null_count();
-// This iteration i
jhorstmann commented on pull request #8800:
URL: https://github.com/apache/arrow/pull/8800#issuecomment-735656117
LGTM. I really would have expected the compiler to figure this out and do
the optimization itself.
This is
ch-sc commented on pull request #8715:
URL: https://github.com/apache/arrow/pull/8715#issuecomment-735682092
Hey, sorry I didn't look into github last weekend. @nevi-me can you re-open
the PR? I'll try to fix the integration tests.
-
pitrou closed pull request #8786:
URL: https://github.com/apache/arrow/pull/8786
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou closed pull request #8774:
URL: https://github.com/apache/arrow/pull/8774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-735722392
Well, at least the ASAN CI job failure seems related:
```
clang: error: no such file or directory: 'debug//libgtestd.so'
```
cc @kou @xhochy
--
Dandandan opened a new pull request #8804:
URL: https://github.com/apache/arrow/pull/8804
Hashing takes up some more time in the hash joins and is visible in
profiling (about 1.31% of total instructions)
This also upgrades to ahash 0.6, this takes automatically advantage of
speciali
github-actions[bot] commented on pull request #8804:
URL: https://github.com/apache/arrow/pull/8804#issuecomment-735749565
https://issues.apache.org/jira/browse/ARROW-10775
This is an automated message from the Apache Git Ser
pitrou commented on pull request #8763:
URL: https://github.com/apache/arrow/pull/8763#issuecomment-735776115
CI failures should be unrelated, merging.
This is an automated message from the Apache Git Service.
To respond to t
pitrou closed pull request #8763:
URL: https://github.com/apache/arrow/pull/8763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lidavidm commented on a change in pull request #8725:
URL: https://github.com/apache/arrow/pull/8725#discussion_r532583653
##
File path: cpp/src/arrow/flight/client_header_internal.h
##
@@ -22,6 +22,8 @@
#include "arrow/flight/client_middleware.h"
#include "arrow/result.h"
lidavidm commented on a change in pull request #8780:
URL: https://github.com/apache/arrow/pull/8780#discussion_r532590005
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightClient.java
##
@@ -87,6 +89,7 @@
private final MethodDescriptor
doPu
pitrou commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-735832288
Rebased, I'm writing some micro-benchmarks.
This is an automated message from the Apache Git Service.
To respond to
andygrove closed pull request #8785:
URL: https://github.com/apache/arrow/pull/8785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8743:
URL: https://github.com/apache/arrow/pull/8743
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on pull request #8762:
URL: https://github.com/apache/arrow/pull/8762#issuecomment-735850164
@jorgecarleitao Could you rebase please when you have time
This is an automated message from the Apache Git Serv
pitrou commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-735860929
Variant benchmarks:
* before:
```
ConstructTrivialVariant 13290 ns13287 ns52532
items_per_second=752.595M/s
ConstructNonTrivialVariant 111230
pitrou commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-735861424
Compute overhead benchmarks:
* before:
```
BM_CastDispatch 971704 ns 971533 ns 698
items_per_second=1054k/s
BM_CastDispatchBaseline
pitrou commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-735866570
@bkietz Do you know why all Github CI checks are skipped here?
This is an automated message from the Apache Git Ser
wesm commented on issue #8767:
URL: https://github.com/apache/arrow/issues/8767#issuecomment-735894436
This was sent to the mailing list
This is an automated message from the Apache Git Service.
To respond to the message, ple
wesm closed issue #8767:
URL: https://github.com/apache/arrow/issues/8767
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
wesm commented on a change in pull request #8755:
URL: https://github.com/apache/arrow/pull/8755#discussion_r532731697
##
File path: python/pyarrow/tests/test_io.py
##
@@ -163,6 +163,34 @@ def test_python_file_readinto():
assert len(dst_buf) == length
+def test_pyt
pitrou commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-735900749
AppVeyor seems to indicate that MSVC isn't picking up / implementing the
copy constructor correctly :-(
This is an
jorisvandenbossche opened a new pull request #8805:
URL: https://github.com/apache/arrow/pull/8805
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wesm commented on a change in pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#discussion_r532736857
##
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##
@@ -589,37 +590,9 @@ class PrimitiveFilterImpl {
void ExecNonNull() {
// Fast filt
github-actions[bot] commented on pull request #8805:
URL: https://github.com/apache/arrow/pull/8805#issuecomment-735916541
https://issues.apache.org/jira/browse/ARROW-10725
This is an automated message from the Apache Git Ser
lyndonb-bq commented on a change in pull request #8725:
URL: https://github.com/apache/arrow/pull/8725#discussion_r532762600
##
File path: cpp/src/arrow/flight/flight_test.cc
##
@@ -1186,6 +1188,139 @@ class TestBasicHeaderAuthMiddleware : public
::testing::Test {
std::shar
ritchie46 commented on pull request #8803:
URL: https://github.com/apache/arrow/pull/8803#issuecomment-735933382
Already experimented a bit for the stringarray variant.
https://github.com/ritchie46/polars/pull/193
This is an
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r532786362
##
File path: cpp/src/arrow/ipc/reader.cc
##
@@ -107,6 +108,23 @@ Status InvalidMessageType(MessageType expected,
MessageType actual) {
// -
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r532814153
##
File path: cpp/src/arrow/array/util.cc
##
@@ -74,6 +75,204 @@ class ArrayDataWrapper {
std::shared_ptr* out_;
};
+class ArrayDataEndianSwapper {
+ pu
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r532819514
##
File path: cpp/src/arrow/array/util.cc
##
@@ -74,6 +75,204 @@ class ArrayDataWrapper {
std::shared_ptr* out_;
};
+class ArrayDataEndianSwapper {
+ pu
jorisvandenbossche commented on a change in pull request #8805:
URL: https://github.com/apache/arrow/pull/8805#discussion_r532839071
##
File path: python/pyarrow/compute.py
##
@@ -155,7 +157,7 @@ def _handle_options(name, option_class, options, kwargs):
"Function {
pitrou opened a new pull request #8806:
URL: https://github.com/apache/arrow/pull/8806
This is a useful primitive when maximum performance isn't required, for
example when testing.
This is an automated message from the Apach
github-actions[bot] commented on pull request #8806:
URL: https://github.com/apache/arrow/pull/8806#issuecomment-735994565
https://issues.apache.org/jira/browse/ARROW-10776
This is an automated message from the Apache Git Ser
alamb commented on pull request #8715:
URL: https://github.com/apache/arrow/pull/8715#issuecomment-735996221
I am sorry I missed the integration test failures on this PR :(
This is an automated message from the Apache Git Ser
alamb commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-736096684
I agree with @Dandandan 's comments 👍
This is an automated message from the Apache Git Service.
To respond to the m
alamb commented on a change in pull request #8731:
URL: https://github.com/apache/arrow/pull/8731#discussion_r532947785
##
File path: rust/sql/src/postgres/reader.rs
##
@@ -0,0 +1,938 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment:
got
alamb commented on a change in pull request #8781:
URL: https://github.com/apache/arrow/pull/8781#discussion_r532949648
##
File path: rust/benchmarks/src/bin/nyctaxi.rs
##
@@ -92,7 +92,7 @@ async fn datafusion_sql_benchmarks(
debug: bool,
) -> Result<()> {
let mut qu
alamb closed pull request #8792:
URL: https://github.com/apache/arrow/pull/8792
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on a change in pull request #8762:
URL: https://github.com/apache/arrow/pull/8762#discussion_r532955833
##
File path: rust/datafusion/src/physical_plan/hash_join.rs
##
@@ -260,18 +261,23 @@ fn build_batch_from_indices(
// this is just for symmetry of the co
lidavidm closed pull request #8725:
URL: https://github.com/apache/arrow/pull/8725
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
lidavidm commented on pull request #8655:
URL: https://github.com/apache/arrow/pull/8655#issuecomment-736116249
I believe this is superseded by #8725, which I've just merged
This is an automated message from the Apache Git Se
andygrove closed pull request #8762:
URL: https://github.com/apache/arrow/pull/8762
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove opened a new pull request #8807:
URL: https://github.com/apache/arrow/pull/8807
Add SQL support for LEFT and RIGHT join
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on pull request #8807:
URL: https://github.com/apache/arrow/pull/8807#issuecomment-736132425
https://issues.apache.org/jira/browse/ARROW-10750
This is an automated message from the Apache Git Ser
andygrove commented on a change in pull request #8794:
URL: https://github.com/apache/arrow/pull/8794#discussion_r532995916
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -2720,6 +2743,42 @@ mod tests {
.collect()
}
+#[test]
+fn test_cast
andygrove commented on a change in pull request #8794:
URL: https://github.com/apache/arrow/pull/8794#discussion_r532995916
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -2720,6 +2743,42 @@ mod tests {
.collect()
}
+#[test]
+fn test_cast
andygrove commented on a change in pull request #8794:
URL: https://github.com/apache/arrow/pull/8794#discussion_r532996931
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -376,6 +378,27 @@ pub fn cast(array: &ArrayRef, to_type: &DataType) ->
Result {
I
traversc opened a new pull request #8808:
URL: https://github.com/apache/arrow/pull/8808
R arrow doesn't compile with cpp11 0.1.
https://issues.apache.org/jira/browse/ARROW-10774
This is an automated message from the
nealrichardson commented on a change in pull request #8808:
URL: https://github.com/apache/arrow/pull/8808#discussion_r533012545
##
File path: r/DESCRIPTION
##
@@ -48,7 +48,7 @@ Suggests:
rmarkdown,
testthat,
tibble
-LinkingTo: cpp11
+LinkingTo: cpp11 (>= 0.2.0)
github-actions[bot] commented on pull request #8808:
URL: https://github.com/apache/arrow/pull/8808#issuecomment-736161920
https://issues.apache.org/jira/browse/ARROW-10774
This is an automated message from the Apache Git Ser
traversc commented on a change in pull request #8808:
URL: https://github.com/apache/arrow/pull/8808#discussion_r533021128
##
File path: r/DESCRIPTION
##
@@ -48,7 +48,7 @@ Suggests:
rmarkdown,
testthat,
tibble
-LinkingTo: cpp11
+LinkingTo: cpp11 (>= 0.2.0)
Revie
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736172872
It seems that the latest GoogleTest doesn't use the default
`CMAKE_XXX_OUTPUT_DIRECTORY`:
https://github.com/google/googletest/blob/master/googletest/cmake/internal_utils.cmake#L159-L
kou commented on a change in pull request #8805:
URL: https://github.com/apache/arrow/pull/8805#discussion_r533032135
##
File path: python/pyarrow/compute.py
##
@@ -155,7 +157,7 @@ def _handle_options(name, option_class, options, kwargs):
"Function {!r} expected a
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736217882
It seems that the template type name `T` is conflicted with Visual C++.
Could you try this patch?
```diff
diff --git a/cpp/src/parquet/statistics_test.cc
b/cpp/src/parquet/s
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736219706
Could you add required GoogleTest version check?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index bdf15
rjzamora opened a new pull request #8809:
URL: https://github.com/apache/arrow/pull/8809
Simple fix to avoid calling `statistics.has_min_max` when `statistics ==
None` in `RowGroupInfo.statistics`.
This is an automated messa
arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736241590
Thanks @kou!!! Pushed your suggestions
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #8809:
URL: https://github.com/apache/arrow/pull/8809#issuecomment-736244736
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736255535
Is this related in C++ / AMD64 Windows 2019?
```
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(527,33):
error C2039: 'TearDownTest
Dandandan commented on pull request #8796:
URL: https://github.com/apache/arrow/pull/8796#issuecomment-736283187
@jorgecarleitao
Maybe I'm saying something weird/impossible, but would it also be possible/
beneficial to store the buffer in a `Vec`?
This way it could simplify mutation
Dandandan edited a comment on pull request #8796:
URL: https://github.com/apache/arrow/pull/8796#issuecomment-736283187
@jorgecarleitao
Maybe I'm saying something weird/impossible, but would it also be possible/
beneficial to store the buffer in a `Vec`?
This way it could simplify m
Dandandan edited a comment on pull request #8796:
URL: https://github.com/apache/arrow/pull/8796#issuecomment-736283187
@jorgecarleitao
Maybe I'm saying something weird/impossible, but would it also be possible/
beneficial to store the (mutable) buffer in a `Vec`?
This way it could
Dandandan commented on pull request #8799:
URL: https://github.com/apache/arrow/pull/8799#issuecomment-736289423
Would be nice if we can get this merged. Would like to create a follow-up
based on some other PRs and discussion / iterations with @ritchie46 with
further improvements
---
66 matches
Mail list logo
