yordan-pavlov commented on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-790979386
@Dandandan I would be happy to collaborate on this;
I have been using MS Visual Studio for profiling DataFusion and Arrow, and
most of the time it works fairly well and gi
jorgecarleitao commented on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-790980785
fwiw, I strongly agree with you, @yordan-pavlov on _all_ those marks. I
recently went through the `arrow/` module of the parquet crate and concluded
exactly the same (inclu
yordan-pavlov edited a comment on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-790979386
@Dandandan I would be happy to collaborate on this;
I have been using MS Visual Studio for profiling DataFusion and Arrow, and
most of the time it works fairly well
yordan-pavlov edited a comment on pull request #9588:
URL: https://github.com/apache/arrow/pull/9588#issuecomment-790979386
@Dandandan I would be happy to collaborate on this;
I have been using MS Visual Studio for profiling DataFusion and Arrow, and
most of the time it works fairly well
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587870368
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587872742
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
nealrichardson commented on pull request #9621:
URL: https://github.com/apache/arrow/pull/9621#issuecomment-790998553
With an assist from @bkietz, I've written a very basic R wrapper that
exercises this in
https://github.com/apache/arrow/commit/aa530cb586462bee98390d129575fe1622ffb222.
It
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587884449
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587887231
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587889678
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587896214
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
jonkeane commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791014063
@github-actions crossbow submit test-r-install-macos
This is an automated message from the Apache Git Service.
To
nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587897840
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587897840
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587898227
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
jonkeane commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791019223
@github-actions crossbow submit test-r-install-macos
This is an automated message from the Apache Git Service.
To
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587899030
##
File path: run-cmake-format.py
##
@@ -52,6 +52,7 @@
'cpp/cmake_modules/FindRapidJSONAlt.cmake',
'cpp/cmake_modules/FindSnappyAlt.cmake',
jonkeane commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791027678
@github-actions crossbow submit test-r-install-macos
This is an automated message from the Apache Git Service.
To
jonkeane commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791031149
@github-actions crossbow submit test-r-install-macos
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791031621
Revision: d1f7611e496c99c7c8d9f32c4b0d35fe4fee0b38
Submitted crossbow builds: [ursacomputing/crossbow @
actions-176](https://github.com/ursacomputing/crossbow/br
ianmcook commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587917115
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
expor
ianmcook commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587917624
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
expor
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791036107
@github-actions crossbow submit test-r-minimal-build
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791036468
Revision: 318371fbaa07f1b6fcdf71f58d7d5460a931da13
Submitted crossbow builds: [ursacomputing/crossbow @
actions-177](https://github.com/ursacomputing/crossbow/br
nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587918983
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
ianmcook commented on pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#issuecomment-791036882
@github-actions crossbow submit test-build-vcpkg-win
wheel-manylinux2010-cp36m wheel-windows-cp36m
This is an au
github-actions[bot] commented on pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#issuecomment-791037231
Revision: d7f0e2236b55ce0ecd2815ccd07e7235288f385b
Submitted crossbow builds: [ursacomputing/crossbow @
actions-178](https://github.com/ursacomputing/crossbow/br
nealrichardson commented on pull request #9586:
URL: https://github.com/apache/arrow/pull/9586#issuecomment-791039254
I'll add a couple more tests, particularly around error handling, but I'd
like to move on to other issues and get this merged so that others can test it
out more widely. cc
kou commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587924544
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
kou commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587924707
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
martinblostein commented on pull request #9442:
URL: https://github.com/apache/arrow/pull/9442#issuecomment-791042920
Is there anything I can do here? Seems like low-hanging fruit.
This is an automated message from the Apache
martinblostein edited a comment on pull request #9442:
URL: https://github.com/apache/arrow/pull/9442#issuecomment-791042920
Is there anything I can do here? Seems like a straightforward change.
This is an automated message f
nealrichardson commented on pull request #9442:
URL: https://github.com/apache/arrow/pull/9442#issuecomment-791043943
@pitrou can you give this a review/merge please?
This is an automated message from the Apache Git Service.
jonkeane commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791044239
@github-actions crossbow submit test-r-install-macos
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791061098
Revision: 9856d8aa91f4f334897e00333b560150fbe54296
Submitted crossbow builds: [ursacomputing/crossbow @
actions-179](https://github.com/ursacomputing/crossbow/br
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587952686
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
ianmcook commented on pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#issuecomment-791072177
@github-actions crossbow submit test-build-vcpkg-win
wheel-manylinux2010-cp36m wheel-windows-cp36m
This is an au
ianmcook commented on a change in pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#discussion_r587955204
##
File path: cpp/cmake_modules/Usevcpkg.cmake
##
@@ -0,0 +1,214 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
ianmcook commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587956206
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
expor
nealrichardson closed pull request #9442:
URL: https://github.com/apache/arrow/pull/9442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
github-actions[bot] commented on pull request #9553:
URL: https://github.com/apache/arrow/pull/9553#issuecomment-791077751
Revision: 2e6905a7262a6139c52c4007fd95f58b378e71ca
Submitted crossbow builds: [ursacomputing/crossbow @
actions-180](https://github.com/ursacomputing/crossbow/br
nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587961901
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791095464
@github-actions crossbow submit test-r-minimal-build
This is an automated message from the Apache Git Service.
To
ianmcook removed a comment on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-790887608
@github-actions crossbow submit -g r
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791095801
Revision: 27c514cb1b14e7125e8ba50714c6480c93dc231a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-181](https://github.com/ursacomputing/crossbow/br
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791103746
@github-actions crossbow submit test-r-minimal-build
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791104150
Revision: a810b3fce373c7f5090e367e5a6afc70db60414a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-182](https://github.com/ursacomputing/crossbow/br
jonkeane commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791106222
@github-actions crossbow submit test-r-install-macos
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #9579:
URL: https://github.com/apache/arrow/pull/9579#issuecomment-791110809
Revision: 4068f471efc55584dbfea5df454af19dfcb1492d
Submitted crossbow builds: [ursacomputing/crossbow @
actions-183](https://github.com/ursacomputing/crossbow/br
ianmcook commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r587998671
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
expor
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791117362
@github-actions crossbow submit test-r-minimal-build
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791117825
Revision: 9479c6ce079c7230b0e290dcb5658436d1d62fde
Submitted crossbow builds: [ursacomputing/crossbow @
actions-184](https://github.com/ursacomputing/crossbow/br
kou closed pull request #9553:
URL: https://github.com/apache/arrow/pull/9553
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791139873
@github-actions crossbow submit -g r
This is an automated message from the Apache Git Service.
To respond to the
ianmcook commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r588021512
##
File path: dev/tasks/r/azure.linux.yml
##
@@ -47,6 +47,9 @@ jobs:
export R_ORG={{ r_org }}
export R_IMAGE={{ r_image }}
expor
ianmcook removed a comment on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791139873
@github-actions crossbow submit -g r
This is an automated message from the Apache Git Service.
To respond
cyb70289 commented on pull request #9633:
URL: https://github.com/apache/arrow/pull/9633#issuecomment-791150699
Also update PR comment to match latest code? `semaphore` -> `pipe`
This is an automated message from the Apache G
xuanqing94 commented on issue #9325:
URL: https://github.com/apache/arrow/issues/9325#issuecomment-791152745
@joeyac Sorry to bring it up again... but I am deeply confused about this
line of code:
`auto column_struct =
std::static_pointer_cast(table->GetColumnByName("column")->chunk(0))
michalursa commented on pull request #9621:
URL: https://github.com/apache/arrow/pull/9621#issuecomment-791153213
> Before digging into the details too much, my main issue with what I see is
that I don't agree with making hash aggregation a callable function through
`CallFunction`.
>
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791154080
@github-actions crossbow submit test-r-minimal-build
This is an automated message from the Apache Git Service.
To
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791154662
@github-actions crossbow submit -g r
This is an automated message from the Apache Git Service.
To respond to the
ianmcook removed a comment on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791154080
@github-actions crossbow submit test-r-minimal-build
This is an automated message from the Apache Git Ser
ianmcook commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791155609
@github-actions crossbow submit test-r-without-dataset-parquet-s3
This is an automated message from the Apache Gi
github-actions[bot] commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791158004
Revision: 6eda5896c638ca1c7af577c02ec56bd802a2fe42
Submitted crossbow builds: [ursacomputing/crossbow @
actions-185](https://github.com/ursacomputing/crossbow/br
github-actions[bot] commented on pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#issuecomment-791158165
Revision: 6eda5896c638ca1c7af577c02ec56bd802a2fe42
Submitted crossbow builds: [ursacomputing/crossbow @
actions-186](https://github.com/ursacomputing/crossbow/br
emkornfield commented on a change in pull request #8949:
URL: https://github.com/apache/arrow/pull/8949#discussion_r588044636
##
File path:
java/compression/src/main/java/org/apache/arrow/compression/CommonsCompressionFactory.java
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Ap
emkornfield commented on issue #9628:
URL: https://github.com/apache/arrow/issues/9628#issuecomment-791183396
First one seems reasonable to me.
Second one, I'm not sure about it. This seems intentional:
https://github.com/apache/arrow/commit/96f3d6176d8c95717f4ff45e4226161de3168b05
liyafan82 commented on pull request #8949:
URL: https://github.com/apache/arrow/pull/8949#issuecomment-791193697
> @liyafan82 nice work. Left a few comments about API and structure let me
know what you think.
@emkornfield Thanks a lot for your comments. I will resolve them one by one
liyafan82 commented on a change in pull request #8949:
URL: https://github.com/apache/arrow/pull/8949#discussion_r588067931
##
File path: java/compression/pom.xml
##
@@ -0,0 +1,56 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-791209166
@pitrou Yup I found your changes to Random 6 days ago in Arrow-11662. Things
did break after that. Now I’m trying to figure out whether it is my ORC writer
or Decimal128 gene
101 - 170 of 170 matches
Mail list logo
