[GitHub] [arrow-rs] codecov-commenter commented on pull request #1133: Make parquet::arrow::array_reader private (#1032)

2022-01-05 Thread GitBox
codecov-commenter commented on pull request #1133: URL: https://github.com/apache/arrow-rs/pull/1133#issuecomment-1005467991 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1133: Make parquet::arrow::array_reader private (#1032)

2022-01-05 Thread GitBox
codecov-commenter edited a comment on pull request #1133: URL: https://github.com/apache/arrow-rs/pull/1133#issuecomment-1005467991 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow] ursabot edited a comment on pull request #11855: ARROW-13735: [C++][Python] Creating a Map array with non-default field names segfaults

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #11855: URL: https://github.com/apache/arrow/pull/11855#issuecomment-1005379375 Benchmark runs are scheduled for baseline = 7235698e7f7da021e6fa64201f69bf77d1625aac and contender = 31a07be1d9dc2f7c9720cc0fdcd7f083d947aba1. 31a07be1d9dc2f7c9720cc0fd

[GitHub] [arrow-datafusion] liukun4515 opened a new issue #1522: support sorting decimal data type

2022-01-05 Thread GitBox
liukun4515 opened a new issue #1522: URL: https://github.com/apache/arrow-datafusion/issues/1522 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** After some pull request from https://github.com/apache/arrow-datafusion/issues/1

[GitHub] [arrow-datafusion] liukun4515 edited a comment on issue #122: Implement DECIMAL type

2022-01-05 Thread GitBox
liukun4515 edited a comment on issue #122: URL: https://github.com/apache/arrow-datafusion/issues/122#issuecomment-975036335 - [ ] create external csv table with decimal data type in SQL parse and logical plan. - [x] decimal scalar #1393 - [x] create table and select column with dec

[GitHub] [arrow-rs] tustvold opened a new pull request #1134: Move more parquet functionality behind experimental feature flag (#1032)

2022-01-05 Thread GitBox
tustvold opened a new pull request #1134: URL: https://github.com/apache/arrow-rs/pull/1134 Draft as builds on #1133 # Which issue does this PR close? Closes #1032 # Rationale for this change See ticket # What changes are included in this PR? This

[GitHub] [arrow] AlenkaF opened a new pull request #12081: ARROW-10643: [Python] Pandas<->pyarrow roundtrip failing to recreate index for empty dataframe

2022-01-05 Thread GitBox
AlenkaF opened a new pull request #12081: URL: https://github.com/apache/arrow/pull/12081 This PR adds a check to the `_reconstruct_index` in `pandas_compat.py ` so that the roundtrip is correct for an empty `pandas.DataFrame` with and index. -- This is an automated message from the Apac

[GitHub] [arrow] github-actions[bot] commented on pull request #12081: ARROW-10643: [Python] Pandas<->pyarrow roundtrip failing to recreate index for empty dataframe

2022-01-05 Thread GitBox
github-actions[bot] commented on pull request #12081: URL: https://github.com/apache/arrow/pull/12081#issuecomment-1005516466 https://issues.apache.org/jira/browse/ARROW-10643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1134: Move more parquet functionality behind experimental feature flag (#1032)

2022-01-05 Thread GitBox
tustvold commented on a change in pull request #1134: URL: https://github.com/apache/arrow-rs/pull/1134#discussion_r778668774 ## File path: parquet/src/compression.rs ## @@ -20,26 +20,30 @@ //! See [`Compression`](crate::basic::Compression) enum for all available compression

[GitHub] [arrow] thisisnic commented on a change in pull request #12073: ARROW-14919: [R] write_parquet() drops attributes for grouped dataframes

2022-01-05 Thread GitBox
thisisnic commented on a change in pull request #12073: URL: https://github.com/apache/arrow/pull/12073#discussion_r778671081 ## File path: r/R/metadata.R ## @@ -115,7 +115,7 @@ apply_arrow_r_metadata <- function(x, r_metadata) { remove_attributes <- function(x) { removed_a

[GitHub] [arrow] AlenkaF commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-05 Thread GitBox
AlenkaF commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r778695741 ## File path: python/pyarrow/table.pxi ## @@ -2442,6 +2602,46 @@ def _from_pydict(cls, mapping, schema, metadata): raise TypeError('Schema must b

[GitHub] [arrow] vibhatha commented on pull request #11993: ARROW-15153: [Python] Expose ReferencedBufferSize to python

2022-01-05 Thread GitBox
vibhatha commented on pull request #11993: URL: https://github.com/apache/arrow/pull/11993#issuecomment-1005563766 @westonpace thank you for the review. I will update the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] ursabot edited a comment on pull request #12019: ARROW-15244: [Format] Clarify that offsets are monotonic for binary like arrays

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #12019: URL: https://github.com/apache/arrow/pull/12019#issuecomment-1005379380 Benchmark runs are scheduled for baseline = 31a07be1d9dc2f7c9720cc0fdcd7f083d947aba1 and contender = e7dc8f573773d2463be997236ceef7bffd6d00c5. e7dc8f573773d2463be997236

[GitHub] [arrow-datafusion] ic4y commented on pull request #1520: use bumpalo for GroupState

2022-01-05 Thread GitBox
ic4y commented on pull request #1520: URL: https://github.com/apache/arrow-datafusion/pull/1520#issuecomment-1005596623 @alamb Sorry, there are three problems now 1. 3.8.0 version of BumpVec does not implement the Drop trait, so the GroupState is not really freed and there will be a

[GitHub] [arrow-rs] alamb commented on issue #1120: More frequent major releases for arrow-rs

2022-01-05 Thread GitBox
alamb commented on issue #1120: URL: https://github.com/apache/arrow-rs/issues/1120#issuecomment-1005601790 > If the master has the API-change commit after the last release, how to handle this? @liukun4515 the proposal is that the following release would have a new major (rather th

[GitHub] [arrow-rs] alamb commented on issue #1120: More frequent major releases for arrow-rs

2022-01-05 Thread GitBox
alamb commented on issue #1120: URL: https://github.com/apache/arrow-rs/issues/1120#issuecomment-1005605490 > I wonder if we might further simplify matters by releasing weekly and incrementing the version based on if there are any new breaking changes on master since the last release.

[GitHub] [arrow-rs] alamb commented on issue #1128: Implement `Array` for `ArrayRef`

2022-01-05 Thread GitBox
alamb commented on issue #1128: URL: https://github.com/apache/arrow-rs/issues/1128#issuecomment-1005615737 I was able to use the borrow idea like this, but it still requires two generic arguments to `as_primitive_array` (and thus requires many code level changes which I am trying to avoid

[GitHub] [arrow-rs] alamb edited a comment on issue #1128: Implement `Array` for `ArrayRef`

2022-01-05 Thread GitBox
alamb edited a comment on issue #1128: URL: https://github.com/apache/arrow-rs/issues/1128#issuecomment-1005615737 I was able to use the borrow idea like this, but it still requires two generic arguments to `as_primitive_array` (and thus requires many code level changes which I am trying t

[GitHub] [arrow-rs] alamb commented on pull request #1129: Implement Array for ArrayRef, Improve as_* kernels to take `&dyn Array`

2022-01-05 Thread GitBox
alamb commented on pull request #1129: URL: https://github.com/apache/arrow-rs/pull/1129#issuecomment-1005616808 For other reviewers, there are a bunch of good comments from @tustvold on https://github.com/apache/arrow-rs/issues/1128#issuecomment-1003747568 related to alternate approaches

[GitHub] [arrow-datafusion] alamb commented on pull request #1520: use bumpalo for GroupState

2022-01-05 Thread GitBox
alamb commented on pull request #1520: URL: https://github.com/apache/arrow-datafusion/pull/1520#issuecomment-1005634682 It is fascinating that calling the `Drop` function for `GroupState` consumes so much time in your profile. ```rust /// The state that is built for each output

[GitHub] [arrow-datafusion] alamb commented on pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

2022-01-05 Thread GitBox
alamb commented on pull request #1519: URL: https://github.com/apache/arrow-datafusion/pull/1519#issuecomment-1005636331 Thanks again @james727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-datafusion] alamb merged pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

2022-01-05 Thread GitBox
alamb merged pull request #1519: URL: https://github.com/apache/arrow-datafusion/pull/1519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1381: [Feat] Quarterly Support

2022-01-05 Thread GitBox
alamb commented on pull request #1381: URL: https://github.com/apache/arrow-datafusion/pull/1381#issuecomment-1005637138 Marking as stale pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-rs] alamb commented on a change in pull request #1041: Generify ColumnReaderImpl and RecordReader (#1040)

2022-01-05 Thread GitBox
alamb commented on a change in pull request #1041: URL: https://github.com/apache/arrow-rs/pull/1041#discussion_r778775604 ## File path: parquet/src/column/reader/decoder.rs ## @@ -0,0 +1,253 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

[GitHub] [arrow-rs] alamb commented on a change in pull request #1041: Generify ColumnReaderImpl and RecordReader (#1040)

2022-01-05 Thread GitBox
alamb commented on a change in pull request #1041: URL: https://github.com/apache/arrow-rs/pull/1041#discussion_r778775711 ## File path: parquet/src/column/reader.rs ## @@ -440,63 +435,29 @@ impl ColumnReaderImpl { Ok(true) } } +} -#[inline] -

[GitHub] [arrow-rs] alamb commented on a change in pull request #1041: Generify ColumnReaderImpl and RecordReader (#1040)

2022-01-05 Thread GitBox
alamb commented on a change in pull request #1041: URL: https://github.com/apache/arrow-rs/pull/1041#discussion_r778776658 ## File path: parquet/src/arrow/record_reader/buffer.rs ## @@ -0,0 +1,196 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [arrow-rs] alamb commented on a change in pull request #1129: Implement Array for ArrayRef, Improve as_* kernels to take `&dyn Array`

2022-01-05 Thread GitBox
alamb commented on a change in pull request #1129: URL: https://github.com/apache/arrow-rs/pull/1129#discussion_r778779669 ## File path: arrow/src/array/cast.rs ## @@ -21,7 +21,7 @@ use crate::array::*; use crate::datatypes::*; /// Force downcast ArrayRef to PrimitiveArray

[GitHub] [arrow-rs] alamb commented on a change in pull request #1129: Implement Array for ArrayRef, Improve as_* kernels to take `&dyn Array`

2022-01-05 Thread GitBox
alamb commented on a change in pull request #1129: URL: https://github.com/apache/arrow-rs/pull/1129#discussion_r778779669 ## File path: arrow/src/array/cast.rs ## @@ -21,7 +21,7 @@ use crate::array::*; use crate::datatypes::*; /// Force downcast ArrayRef to PrimitiveArray

[GitHub] [arrow-rs] alamb commented on pull request #1092: Add Schema::with_metadata and Field::with_metadata

2022-01-05 Thread GitBox
alamb commented on pull request #1092: URL: https://github.com/apache/arrow-rs/pull/1092#issuecomment-1005644865 Since there are no objections or comments, merging this one in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-rs] alamb merged pull request #1092: Add Schema::with_metadata and Field::with_metadata

2022-01-05 Thread GitBox
alamb merged pull request #1092: URL: https://github.com/apache/arrow-rs/pull/1092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #1039: BooleanBufferBuilder::append_packed (#1038)

2022-01-05 Thread GitBox
jhorstmann commented on a change in pull request #1039: URL: https://github.com/apache/arrow-rs/pull/1039#discussion_r778789580 ## File path: arrow/src/array/builder.rs ## @@ -398,6 +399,95 @@ impl BooleanBufferBuilder { } } +/// Append `count` bits from `to

[GitHub] [arrow] ursabot edited a comment on pull request #11886: ARROW-13035: [C++] indices_nonzero compute function

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #11886: URL: https://github.com/apache/arrow/pull/11886#issuecomment-1005379384 Benchmark runs are scheduled for baseline = e7dc8f573773d2463be997236ceef7bffd6d00c5 and contender = 8e18cf343fdfbde0fe817f110ec316f22f420c2e. 8e18cf343fdfbde0fe817f110

[GitHub] [arrow-rs] yordan-pavlov commented on pull request #1133: Make parquet::arrow::array_reader experimental (#1032)

2022-01-05 Thread GitBox
yordan-pavlov commented on pull request #1133: URL: https://github.com/apache/arrow-rs/pull/1133#issuecomment-1005663528 No concerns from me - I think the APIs in `array_reader` definitely need some work and I wouldn't be surprised if some breaking changes might be necessary, so a mechanis

[GitHub] [arrow] thisisnic closed pull request #12016: ARROW-14603: [Doc] Tutorial - R bindings

2022-01-05 Thread GitBox
thisisnic closed pull request #12016: URL: https://github.com/apache/arrow/pull/12016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow] thisisnic closed pull request #12018: ARROW-14757: [Doc] Steps in making your first PR - R bindings

2022-01-05 Thread GitBox
thisisnic closed pull request #12018: URL: https://github.com/apache/arrow/pull/12018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow] lidavidm commented on a change in pull request #11964: ARROW-15067: [C++] Add tracing spans to the scanner

2022-01-05 Thread GitBox
lidavidm commented on a change in pull request #11964: URL: https://github.com/apache/arrow/pull/11964#discussion_r778809806 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -97,6 +98,58 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, return fut;

[GitHub] [arrow] thisisnic commented on a change in pull request #11942: ARROW-14762: [Doc] Additional info and resources

2022-01-05 Thread GitBox
thisisnic commented on a change in pull request #11942: URL: https://github.com/apache/arrow/pull/11942#discussion_r778808275 ## File path: docs/source/developers/guide/resources.rst ## @@ -27,3 +27,41 @@ Additional information and resourc

[GitHub] [arrow] ursabot commented on pull request #12018: ARROW-14757: [Doc] Steps in making your first PR - R bindings

2022-01-05 Thread GitBox
ursabot commented on pull request #12018: URL: https://github.com/apache/arrow/pull/12018#issuecomment-1005679950 Benchmark runs are scheduled for baseline = 3bf06f2fdb7966be4e513564d2df553d09ae98b1 and contender = 67a29fdffec3c2646b29aa07b49729305aac0d38. 67a29fdffec3c2646b29aa07b4972930

[GitHub] [arrow] ursabot commented on pull request #12016: ARROW-14603: [Doc] Tutorial - R bindings

2022-01-05 Thread GitBox
ursabot commented on pull request #12016: URL: https://github.com/apache/arrow/pull/12016#issuecomment-1005679942 Benchmark runs are scheduled for baseline = 08096d4125fcbfe43ecf48614a15f1205cd4e8f3 and contender = 3bf06f2fdb7966be4e513564d2df553d09ae98b1. 3bf06f2fdb7966be4e513564d2df553d

[GitHub] [arrow] amol- commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-05 Thread GitBox
amol- commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r778812702 ## File path: python/pyarrow/table.pxi ## @@ -2442,6 +2602,46 @@ def _from_pydict(cls, mapping, schema, metadata): raise TypeError('Schema must be

[GitHub] [arrow] pitrou commented on a change in pull request #12030: ARROW-9186: [R] Allow specifying CSV file encoding

2022-01-05 Thread GitBox
pitrou commented on a change in pull request #12030: URL: https://github.com/apache/arrow/pull/12030#discussion_r778813936 ## File path: r/src/io.cpp ## @@ -178,4 +180,134 @@ void io___BufferOutputStream__Write( StopIfNotOk(stream->Write(RAW(bytes), bytes.size())); } +//

[GitHub] [arrow] lidavidm commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-05 Thread GitBox
lidavidm commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r778815533 ## File path: cpp/examples/arrow/exec_plan_examples.cc ## @@ -0,0 +1,1122 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] pitrou commented on pull request #12077: ARROW-15109: [Python] List status of optional components in show_versions

2022-01-05 Thread GitBox
pitrou commented on pull request #12077: URL: https://github.com/apache/arrow/pull/12077#issuecomment-1005687521 Should this be a separate function instead, e.g. `show_components()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] lidavidm commented on pull request #12080: ARROW-15118: [C++] Avoid bitmap buffer if all inputs are all valid for Scalar Kernels

2022-01-05 Thread GitBox
lidavidm commented on pull request #12080: URL: https://github.com/apache/arrow/pull/12080#issuecomment-1005691660 Right, you don't get to see the actual data during preallocation. However it's called from here: https://github.com/apache/arrow/blob/ecacff0f4e1059887ea6ff78254c4ae9ff3ea102/

[GitHub] [arrow] ursabot edited a comment on pull request #12016: ARROW-14603: [Doc] Tutorial - R bindings

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #12016: URL: https://github.com/apache/arrow/pull/12016#issuecomment-1005679942 Benchmark runs are scheduled for baseline = 08096d4125fcbfe43ecf48614a15f1205cd4e8f3 and contender = 3bf06f2fdb7966be4e513564d2df553d09ae98b1. 3bf06f2fdb7966be4e513564d

[GitHub] [arrow-rs] alamb closed issue #1128: Implement `Array` for `ArrayRef`

2022-01-05 Thread GitBox
alamb closed issue #1128: URL: https://github.com/apache/arrow-rs/issues/1128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-rs] alamb merged pull request #1129: Implement Array for ArrayRef, Improve as_* kernels to take `&dyn Array`

2022-01-05 Thread GitBox
alamb merged pull request #1129: URL: https://github.com/apache/arrow-rs/pull/1129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-rs] alamb commented on pull request #1127: *_dyn_scalar kernels: Support Float32Array and Float64Array,

2022-01-05 Thread GitBox
alamb commented on pull request #1127: URL: https://github.com/apache/arrow-rs/pull/1127#issuecomment-1005701163 This is now ready for review @liukun4515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] ursabot edited a comment on pull request #12018: ARROW-14757: [Doc] Steps in making your first PR - R bindings

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #12018: URL: https://github.com/apache/arrow/pull/12018#issuecomment-1005679950 Benchmark runs are scheduled for baseline = 3bf06f2fdb7966be4e513564d2df553d09ae98b1 and contender = 67a29fdffec3c2646b29aa07b49729305aac0d38. 67a29fdffec3c2646b29aa07b

[GitHub] [arrow] jeszyb commented on pull request #12077: ARROW-15109: [Python] List status of optional components in show_versions

2022-01-05 Thread GitBox
jeszyb commented on pull request #12077: URL: https://github.com/apache/arrow/pull/12077#issuecomment-1005707057 I agree `_versions()` is no longer accurate. IMO it'd be good to keep debugging information like these in one place though -- we could switch to `arrow_info()` for Python as wel

[GitHub] [arrow-cookbook] lidavidm commented on a change in pull request #113: [Java]: Java cookbook recipes

2022-01-05 Thread GitBox
lidavidm commented on a change in pull request #113: URL: https://github.com/apache/arrow-cookbook/pull/113#discussion_r778826343 ## File path: java/source/create.rst ## @@ -0,0 +1,134 @@ +== +Creating arrow objects +== + +A vector is the

[GitHub] [arrow-cookbook] lidavidm commented on pull request #113: [Java]: Java cookbook recipes

2022-01-05 Thread GitBox
lidavidm commented on pull request #113: URL: https://github.com/apache/arrow-cookbook/pull/113#issuecomment-1005708795 Ah, I submitted early, sorry. I'm still going through this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [arrow] paleolimbot commented on a change in pull request #12030: ARROW-9186: [R] Allow specifying CSV file encoding

2022-01-05 Thread GitBox
paleolimbot commented on a change in pull request #12030: URL: https://github.com/apache/arrow/pull/12030#discussion_r778851474 ## File path: r/src/io.cpp ## @@ -178,4 +180,134 @@ void io___BufferOutputStream__Write( StopIfNotOk(stream->Write(RAW(bytes), bytes.size())); }

[GitHub] [arrow-cookbook] lidavidm commented on a change in pull request #113: [Java]: Java cookbook recipes

2022-01-05 Thread GitBox
lidavidm commented on a change in pull request #113: URL: https://github.com/apache/arrow-cookbook/pull/113#discussion_r778846417 ## File path: java/source/io.rst ## @@ -0,0 +1,354 @@ + +Reading and writing data + + +Recipes relat

[GitHub] [arrow] lidavidm closed pull request #11853: ARROW-1699: [C++] forward, backward fill kernel functions

2022-01-05 Thread GitBox
lidavidm closed pull request #11853: URL: https://github.com/apache/arrow/pull/11853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] lidavidm commented on pull request #11853: ARROW-1699: [C++] forward, backward fill kernel functions

2022-01-05 Thread GitBox
lidavidm commented on pull request #11853: URL: https://github.com/apache/arrow/pull/11853#issuecomment-1005735261 Ah shoot, I forgot to ask you to update the docs. I'll file a minor PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] lidavidm opened a new pull request #12082: MINOR: [Docs] Add fill_null functions to docs

2022-01-05 Thread GitBox
lidavidm opened a new pull request #12082: URL: https://github.com/apache/arrow/pull/12082 Add the docs for the functions from ARROW-1699/PR #11853 since they were omitted in the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] lidavidm commented on pull request #12082: MINOR: [Docs] Add fill_null functions to docs

2022-01-05 Thread GitBox
lidavidm commented on pull request #12082: URL: https://github.com/apache/arrow/pull/12082#issuecomment-1005738220 CC @AlvinJ15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow] ursabot commented on pull request #11853: ARROW-1699: [C++] forward, backward fill kernel functions

2022-01-05 Thread GitBox
ursabot commented on pull request #11853: URL: https://github.com/apache/arrow/pull/11853#issuecomment-1005743192 Benchmark runs are scheduled for baseline = 67a29fdffec3c2646b29aa07b49729305aac0d38 and contender = ec38aebb36e99e54e69089cbc6a623a616575dde. ec38aebb36e99e54e69089cbc6a623a6

[GitHub] [arrow-cookbook] lidavidm commented on a change in pull request #114: Fix hyperlink

2022-01-05 Thread GitBox
lidavidm commented on a change in pull request #114: URL: https://github.com/apache/arrow-cookbook/pull/114#discussion_r778876256 ## File path: r/content/arrays.Rmd ## @@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects. The returned object will be an Arrow o ### S

[GitHub] [arrow] lidavidm commented on pull request #12040: ARROW-15199: [Java] Update protobuf-maven-plugin to avoid 'Text file busy' failure

2022-01-05 Thread GitBox
lidavidm commented on pull request #12040: URL: https://github.com/apache/arrow/pull/12040#issuecomment-1005756921 @davisusanibar would you like to take a glance here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] eerhardt commented on a change in pull request #12044: ARROW-13294: [C#] Create Flight example server and client

2022-01-05 Thread GitBox
eerhardt commented on a change in pull request #12044: URL: https://github.com/apache/arrow/pull/12044#discussion_r77251 ## File path: csharp/examples/FlightAspServerExample/FlightAspServerExample.csproj ## @@ -0,0 +1,39 @@ + + + + + +net6.0 Review comment: Ye

[GitHub] [arrow] ursabot edited a comment on pull request #11853: ARROW-1699: [C++] forward, backward fill kernel functions

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #11853: URL: https://github.com/apache/arrow/pull/11853#issuecomment-1005743192 Benchmark runs are scheduled for baseline = 67a29fdffec3c2646b29aa07b49729305aac0d38 and contender = ec38aebb36e99e54e69089cbc6a623a616575dde. ec38aebb36e99e54e69089cbc

[GitHub] [arrow] ursabot edited a comment on pull request #11238: ARROW-13628: [Rust] Activate IPC month_day_nano_interval integration test for rust

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #11238: URL: https://github.com/apache/arrow/pull/11238#issuecomment-1005379386 Benchmark runs are scheduled for baseline = 8e18cf343fdfbde0fe817f110ec316f22f420c2e and contender = acce03b723c10ba996be6cb4992d5e770d159267. acce03b723c10ba996be6cb49

[GitHub] [arrow] zeroshade commented on a change in pull request #11514: ARROW-14430: [Go] Basic Expression, Field Reference and Datum handling

2022-01-05 Thread GitBox
zeroshade commented on a change in pull request #11514: URL: https://github.com/apache/arrow/pull/11514#discussion_r778899010 ## File path: go/arrow/compute/utils.go ## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

[GitHub] [arrow] zeroshade commented on a change in pull request #11514: ARROW-14430: [Go] Basic Expression, Field Reference and Datum handling

2022-01-05 Thread GitBox
zeroshade commented on a change in pull request #11514: URL: https://github.com/apache/arrow/pull/11514#discussion_r778899954 ## File path: go/arrow/datatype_fixedwidth.go ## @@ -220,17 +220,17 @@ func (t Time64) ToTime(unit TimeUnit) time.Time { } const ( - Nanosecon

[GitHub] [arrow] davisusanibar commented on pull request #12040: ARROW-15199: [Java] Update protobuf-maven-plugin to avoid 'Text file busy' failure

2022-01-05 Thread GitBox
davisusanibar commented on pull request #12040: URL: https://github.com/apache/arrow/pull/12040#issuecomment-1005782798 Hi team, what about protobuf plugin dependency on [dataset module ](https://github.com/apache/arrow/blob/ec38aebb36e99e54e69089cbc6a623a616575dde/java/dataset/pom.xml#L114

[GitHub] [arrow-datafusion] james727 commented on pull request #1519: Fix single_distinct_to_groupby for arbitrary expressions

2022-01-05 Thread GitBox
james727 commented on pull request #1519: URL: https://github.com/apache/arrow-datafusion/pull/1519#issuecomment-1005797032 No problem, glad it's useful. Appreciate the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] westonpace commented on a change in pull request #11964: ARROW-15067: [C++] Add tracing spans to the scanner

2022-01-05 Thread GitBox
westonpace commented on a change in pull request #11964: URL: https://github.com/apache/arrow/pull/11964#discussion_r778913505 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -97,6 +98,58 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, return fut;

[GitHub] [arrow] lidavidm commented on a change in pull request #11964: ARROW-15067: [C++] Add tracing spans to the scanner

2022-01-05 Thread GitBox
lidavidm commented on a change in pull request #11964: URL: https://github.com/apache/arrow/pull/11964#discussion_r778917610 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -97,6 +98,58 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, return fut;

[GitHub] [arrow] github-actions[bot] commented on pull request #12083: ARROW-14744: [R] open_dataset() error when `schema` argument supplied, but `column_names` not supplied to `CSVReadOptions`

2022-01-05 Thread GitBox
github-actions[bot] commented on pull request #12083: URL: https://github.com/apache/arrow/pull/12083#issuecomment-1005827714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] toppyy opened a new pull request #12083: ARROW-14744: [R] open_dataset() error when `schema` argument supplied, but `column_names` not supplied to `CSVReadOptions`

2022-01-05 Thread GitBox
toppyy opened a new pull request #12083: URL: https://github.com/apache/arrow/pull/12083 Supplement CsvReadOptions with column_names from schema if column_names are not set in read_options -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] lidavidm commented on a change in pull request #11964: ARROW-15067: [C++] Add tracing spans to the scanner

2022-01-05 Thread GitBox
lidavidm commented on a change in pull request #11964: URL: https://github.com/apache/arrow/pull/11964#discussion_r778918999 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -97,6 +98,58 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, return fut;

[GitHub] [arrow] lidavidm commented on pull request #12040: ARROW-15199: [Java] Update protobuf-maven-plugin to avoid 'Text file busy' failure

2022-01-05 Thread GitBox
lidavidm commented on pull request #12040: URL: https://github.com/apache/arrow/pull/12040#issuecomment-1005835836 Ah good catch, thank you! I've fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] ursabot edited a comment on pull request #11855: ARROW-13735: [C++][Python] Creating a Map array with non-default field names segfaults

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #11855: URL: https://github.com/apache/arrow/pull/11855#issuecomment-1005379375 Benchmark runs are scheduled for baseline = 7235698e7f7da021e6fa64201f69bf77d1625aac and contender = 31a07be1d9dc2f7c9720cc0fdcd7f083d947aba1. 31a07be1d9dc2f7c9720cc0fd

[GitHub] [arrow-rs] alamb merged pull request #1133: Make parquet::arrow::array_reader experimental (#1032)

2022-01-05 Thread GitBox
alamb merged pull request #1133: URL: https://github.com/apache/arrow-rs/pull/1133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] eerhardt commented on a change in pull request #12044: ARROW-13294: [C#] Create Flight example server and client

2022-01-05 Thread GitBox
eerhardt commented on a change in pull request #12044: URL: https://github.com/apache/arrow/pull/12044#discussion_r778892642 ## File path: csharp/examples/FlightAspServerExample/Services/InMemoryFlightServer.cs ## @@ -0,0 +1,158 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [arrow] ursabot edited a comment on pull request #11818: ARROW-14822: [C++] Implement floor/ceil/round for temporal objects

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #11818: URL: https://github.com/apache/arrow/pull/11818#issuecomment-1005379389 Benchmark runs are scheduled for baseline = acce03b723c10ba996be6cb4992d5e770d159267 and contender = edab145e364d70138c9e266892820589a2932884. edab145e364d70138c9e26689

[GitHub] [arrow] jonkeane commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
jonkeane commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1005931563 @github-actions crossbow submit homebrew-r-autobrew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] github-actions[bot] commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
github-actions[bot] commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1005932505 Revision: 9594a9e8dca49aa8cb9cceaec5a052d5f748d187 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1368](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-rs] helgikrs opened a new pull request #1135: feat: union schema serialization/deserialization for ipc

2022-01-05 Thread GitBox
helgikrs opened a new pull request #1135: URL: https://github.com/apache/arrow-rs/pull/1135 # Which issue does this PR close? Adds support for serializing a schema containing a union for ipc. Needed for #654, but does not close it. # What changes are included in this PR?

[GitHub] [arrow] jvanstraten opened a new pull request #12084: ARROW-15029: [C++] Split compute/kernels/scalar_string.cc

2022-01-05 Thread GitBox
jvanstraten opened a new pull request #12084: URL: https://github.com/apache/arrow/pull/12084 This PR splits compute/kernels/scalar_string.cc into a file for ASCII/binary-based kernels and a file for UTF-8-based kernels to speed up compilation and improve readability. Kernel definitions wi

[GitHub] [arrow] github-actions[bot] commented on pull request #12084: ARROW-15029: [C++] Split compute/kernels/scalar_string.cc

2022-01-05 Thread GitBox
github-actions[bot] commented on pull request #12084: URL: https://github.com/apache/arrow/pull/12084#issuecomment-1005940193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] ursabot edited a comment on pull request #12019: ARROW-15244: [Format] Clarify that offsets are monotonic for binary like arrays

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #12019: URL: https://github.com/apache/arrow/pull/12019#issuecomment-1005379380 Benchmark runs are scheduled for baseline = 31a07be1d9dc2f7c9720cc0fdcd7f083d947aba1 and contender = e7dc8f573773d2463be997236ceef7bffd6d00c5. e7dc8f573773d2463be997236

[GitHub] [arrow] jonkeane commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
jonkeane commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1005985658 @github-actions crossbow submit homebrew-r-autobrew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] github-actions[bot] commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
github-actions[bot] commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1005986416 Revision: dfe4db8cf3dc5cc9e474bb3dde798801f8cde25d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1369](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] westonpace commented on pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-05 Thread GitBox
westonpace commented on pull request #12033: URL: https://github.com/apache/arrow/pull/12033#issuecomment-1006001511 I've been capturing some of the usability improvements we are identifying here: https://issues.apache.org/jira/browse/ARROW-15257 -- This is an automated message from the

[GitHub] [arrow] wjones127 commented on pull request #11894: ARROW-14029: [R] Repair map_batches()

2022-01-05 Thread GitBox
wjones127 commented on pull request #11894: URL: https://github.com/apache/arrow/pull/11894#issuecomment-1006005568 @jonkeane If you have time to review, I think it would be cool to get this into 7.0.0. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [arrow] westonpace commented on issue #11799: arrow::compute `hash_*` functions matching input types

2022-01-05 Thread GitBox
westonpace commented on issue #11799: URL: https://github.com/apache/arrow/issues/11799#issuecomment-1006005593 Sorry for the delay but here is an update on a few things. We are working on documenting the C++ exec plans API here: https://github.com/apache/arrow/pull/12033 The

[GitHub] [arrow] ursabot edited a comment on pull request #12060: ARROW-15216: [GLib] Add Arrow::RoundToMultipleOptions

2022-01-05 Thread GitBox
ursabot edited a comment on pull request #12060: URL: https://github.com/apache/arrow/pull/12060#issuecomment-1005379392 Benchmark runs are scheduled for baseline = edab145e364d70138c9e266892820589a2932884 and contender = 627720bcfd3671bbe40c22abb8ac3ef006b8f32e. 627720bcfd3671bbe40c22abb

[GitHub] [arrow] jonkeane commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
jonkeane commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1006016576 @github-actions crossbow submit homebrew-r-autobrew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] github-actions[bot] commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
github-actions[bot] commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1006017309 Revision: 631bb2f8305d04090951d90bbe8da4f7457ee022 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1370](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] ElenaHenderson commented on pull request #9272: [WIP] Benchmark placebo

2022-01-05 Thread GitBox
ElenaHenderson commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-1006026601 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] ursabot commented on pull request #9272: [WIP] Benchmark placebo

2022-01-05 Thread GitBox
ursabot commented on pull request #9272: URL: https://github.com/apache/arrow/pull/9272#issuecomment-1006026609 Commit efcd862d87912e4efd93da3dc124d3b31d5d3e6b already has scheduled benchmark runs. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [arrow-rs] alamb closed issue #1111: ArrowArrayReader Reads Too Many Values From Bit-Packed Runs

2022-01-05 Thread GitBox
alamb closed issue #: URL: https://github.com/apache/arrow-rs/issues/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-rs] alamb commented on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)

2022-01-05 Thread GitBox
alamb commented on pull request #1130: URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1006033515 Thanks again @yordan-pavlov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-rs] alamb merged pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)

2022-01-05 Thread GitBox
alamb merged pull request #1130: URL: https://github.com/apache/arrow-rs/pull/1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] jonkeane commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
jonkeane commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1006034270 @github-actions crossbow submit homebrew-r-autobrew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] github-actions[bot] commented on pull request #12079: ARROW-15249: [R] Autobrew + AWS sdk dependency [WIP]

2022-01-05 Thread GitBox
github-actions[bot] commented on pull request #12079: URL: https://github.com/apache/arrow/pull/12079#issuecomment-1006035194 Revision: 9847ac879f0e36ebcdd849f6a97a6991cff82e0a Submitted crossbow builds: [ursacomputing/crossbow @ actions-1371](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-rs] alamb commented on pull request #1107: Dyn comparison of interval arrays (#1106)

2022-01-05 Thread GitBox
alamb commented on pull request #1107: URL: https://github.com/apache/arrow-rs/pull/1107#issuecomment-1006036222 @tustvold I took the liberty of merging this PR from master -- will merge when the CI has passed -- This is an automated message from the Apache Git Service. To respond to th

  1   2   3   >