[GitHub] [arrow-datafusion] selvavm commented on issue #1533: When using Dataframe getting empty row but pretty print contain rows

2022-01-10 Thread GitBox
selvavm commented on issue #1533: URL: https://github.com/apache/arrow-datafusion/issues/1533#issuecomment-1008620650 Hi @alamb. Thanks for response. I will see if I can do a self contained reproducer. Sorry, I am new to Parquet files and Datafusion, so having trouble in understanding it.

[GitHub] [arrow-datafusion] selvavm edited a comment on issue #1533: When using Dataframe getting empty row but pretty print contain rows

2022-01-10 Thread GitBox
selvavm edited a comment on issue #1533: URL: https://github.com/apache/arrow-datafusion/issues/1533#issuecomment-1008620650 Hi @alamb. Thanks for response. I will see if I can do a self contained reproducer. Sorry, I am new to Parquet files and Datafusion, so having trouble in understand

[GitHub] [arrow-datafusion] selvavm edited a comment on issue #1533: When using Dataframe getting empty row but pretty print contain rows

2022-01-10 Thread GitBox
selvavm edited a comment on issue #1533: URL: https://github.com/apache/arrow-datafusion/issues/1533#issuecomment-1008620650 Hi @alamb. Thanks for response. I will see if I can do a self contained reproducer. Sorry, I am new to Parquet files and Datafusion, so having trouble in understand

[GitHub] [arrow-datafusion] selvavm edited a comment on issue #1533: When using Dataframe getting empty row but pretty print contain rows

2022-01-10 Thread GitBox
selvavm edited a comment on issue #1533: URL: https://github.com/apache/arrow-datafusion/issues/1533#issuecomment-1008620650 Hi @alamb. Thanks for response. I will see if I can do a self contained reproducer. Sorry, I am new to Parquet files and Datafusion, so having trouble in understand

[GitHub] [arrow] kou merged pull request #12111: MINOR: [GLib][Doc] Fix wrong build directory in README.md

2022-01-10 Thread GitBox
kou merged pull request #12111: URL: https://github.com/apache/arrow/pull/12111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] AlenkaF commented on a change in pull request #11942: ARROW-14762: [Doc] Additional info and resources

2022-01-10 Thread GitBox
AlenkaF commented on a change in pull request #11942: URL: https://github.com/apache/arrow/pull/11942#discussion_r780968335 ## File path: docs/source/developers/guide/resources.rst ## @@ -27,3 +27,52 @@ Additional information and resources

[GitHub] [arrow] colinbs commented on pull request #12111: MINOR: [GLib][Doc] Fix wrong build directory in README.md

2022-01-10 Thread GitBox
colinbs commented on pull request #12111: URL: https://github.com/apache/arrow/pull/12111#issuecomment-1008632873 That was quick, thanks for renaming the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1526: A simplified memory manager for query execution

2022-01-10 Thread GitBox
yjshen commented on a change in pull request #1526: URL: https://github.com/apache/arrow-datafusion/pull/1526#discussion_r780988323 ## File path: datafusion/src/execution/memory_manager.rs ## @@ -0,0 +1,320 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1526: A simplified memory manager for query execution

2022-01-10 Thread GitBox
yjshen commented on a change in pull request #1526: URL: https://github.com/apache/arrow-datafusion/pull/1526#discussion_r780991701 ## File path: datafusion/src/execution/memory_manager.rs ## @@ -0,0 +1,320 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11985: ARROW-12545: [Python][Docs] Fill in section about Custom Schema and Field Metadata

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #11985: URL: https://github.com/apache/arrow/pull/11985#discussion_r780991165 ## File path: docs/source/python/data.rst ## @@ -431,4 +431,52 @@ around, so if your data is already in table form, then use Custom Schema and

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r781008612 ## File path: python/pyarrow/table.pxi ## @@ -2442,6 +2602,46 @@ def _from_pydict(cls, mapping, schema, metadata): raise TypeError('Sc

[GitHub] [arrow-datafusion] yjshen commented on pull request #1526: A simplified memory manager for query execution

2022-01-10 Thread GitBox
yjshen commented on pull request #1526: URL: https://github.com/apache/arrow-datafusion/pull/1526#issuecomment-1008690139 @houqp @alamb Thanks for your detailed and insightful review! ### Resolved: - The maintained total trackers' memory and the background threads that updat

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #1526: A simplified memory manager for query execution

2022-01-10 Thread GitBox
yjshen edited a comment on pull request #1526: URL: https://github.com/apache/arrow-datafusion/pull/1526#issuecomment-1008690139 @houqp @alamb Thanks for your detailed and insightful review! ### Resolved: - The maintained total trackers' memory and the background threads that

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #1526: A simplified memory manager for query execution

2022-01-10 Thread GitBox
yjshen edited a comment on pull request #1526: URL: https://github.com/apache/arrow-datafusion/pull/1526#issuecomment-1008690139 @houqp @alamb Thanks for your detailed and insightful review! ### Resolved: - The maintained total trackers' memory and the background threads that

[GitHub] [arrow] jorisvandenbossche commented on pull request #12091: ARROW-14798: [C++][Python] Add child window to PrettyPrintOptions

2022-01-10 Thread GitBox
jorisvandenbossche commented on pull request #12091: URL: https://github.com/apache/arrow/pull/12091#issuecomment-1008730856 I understand that `PrettyPrintOptions` is generic, but so that also means that the interpretation of "child" depends on what you are printing. For example, fo

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11991: ARROW-13554: [C++] Remove deprecated Scanner::Scan

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #11991: URL: https://github.com/apache/arrow/pull/11991#discussion_r781060788 ## File path: python/pyarrow/_dataset.pyx ## @@ -2239,10 +2233,6 @@ cdef class Scanner(_Weakrefable): use_threads : bool, default True

[GitHub] [arrow] dragosmg commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008741422 @github-actions crossbow submit test-ubuntu-default-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] github-actions[bot] commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
github-actions[bot] commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008742252 Revision: c72ceea5cb9d4e2d3abd804f65437d8c534ac067 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1381](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-rs] tustvold commented on pull request #1134: Move more parquet functionality behind experimental feature flag (#1032)

2022-01-10 Thread GitBox
tustvold commented on pull request #1134: URL: https://github.com/apache/arrow-rs/pull/1134#issuecomment-1008747051 Looking into test failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12078: ARROW-14448: [Python] Update pyarrow.array() docstring note on timestamp (timezone) conversion

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12078: URL: https://github.com/apache/arrow/pull/12078#discussion_r781073566 ## File path: python/pyarrow/array.pxi ## @@ -159,9 +159,10 @@ def array(object obj, type=None, mask=None, size=None, from_pandas=None,

[GitHub] [arrow] vibhatha opened a new pull request #12112: ARROW-15183: [Python][Docs] Add Missing Dataset Write Options

2022-01-10 Thread GitBox
vibhatha opened a new pull request #12112: URL: https://github.com/apache/arrow/pull/12112 This PR includes a minor documentation update for showing how `max_open_files`, `min_rows_per_group` and `max_rows_per_group` parameters can be used in Python dataset API. The disucssion on t

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11993: ARROW-15153: [Python] Expose ReferencedBufferSize to python

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #11993: URL: https://github.com/apache/arrow/pull/11993#discussion_r781082338 ## File path: python/pyarrow/array.pxi ## @@ -986,14 +986,49 @@ cdef class Array(_PandasConvertible): @property def nbytes(self):

[GitHub] [arrow] github-actions[bot] commented on pull request #12112: ARROW-15183: [Python][Docs] Add Missing Dataset Write Options

2022-01-10 Thread GitBox
github-actions[bot] commented on pull request #12112: URL: https://github.com/apache/arrow/pull/12112#issuecomment-1008757286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11978: ARROW-15137: [Dev] Update archery crossbow latest-prefix to work with nightly dates

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #11978: URL: https://github.com/apache/arrow/pull/11978#discussion_r781096878 ## File path: dev/archery/archery/crossbow/core.py ## @@ -536,17 +536,34 @@ def _latest_prefix_id(self, prefix): latest = -1

[GitHub] [arrow] AlenkaF commented on a change in pull request #12097: ARROW-14590: [R] Implement lubridate::week

2022-01-10 Thread GitBox
AlenkaF commented on a change in pull request #12097: URL: https://github.com/apache/arrow/pull/12097#discussion_r781103385 ## File path: r/R/dplyr-funcs-datetime.R ## @@ -101,6 +101,10 @@ register_bindings_datetime <- function() { Expression$create("day_of_week", x, optio

[GitHub] [arrow] edponce commented on a change in pull request #11978: ARROW-15137: [Dev] Update archery crossbow latest-prefix to work with nightly dates

2022-01-10 Thread GitBox
edponce commented on a change in pull request #11978: URL: https://github.com/apache/arrow/pull/11978#discussion_r781104442 ## File path: dev/archery/archery/crossbow/core.py ## @@ -537,17 +537,36 @@ def _latest_prefix_id(self, prefix): latest = -1 return

[GitHub] [arrow-datafusion] alamb commented on issue #1533: When using Dataframe getting empty row but pretty print contain rows

2022-01-10 Thread GitBox
alamb commented on issue #1533: URL: https://github.com/apache/arrow-datafusion/issues/1533#issuecomment-1008775801 > Not an elegant approach. Is there any util to combine all Vec into one RecordBatch? @selvavm you can `RecordBatch::concat` for that purpose: https://docs.rs

[GitHub] [arrow-datafusion] alamb commented on pull request #1525: Add stddev operator

2022-01-10 Thread GitBox
alamb commented on pull request #1525: URL: https://github.com/apache/arrow-datafusion/pull/1525#issuecomment-1008776459 Unless anyone has another other thoughts on this PR I'll plan to merge it later today -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] AlenkaF commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-10 Thread GitBox
AlenkaF commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r781106452 ## File path: python/pyarrow/table.pxi ## @@ -1016,6 +1064,28 @@ cdef class RecordBatch(_PandasConvertible): entries.append((name, column))

[GitHub] [arrow] vibhatha opened a new pull request #12113: Test and support for Suffix [WIP]

2022-01-10 Thread GitBox
vibhatha opened a new pull request #12113: URL: https://github.com/apache/arrow/pull/12113 ARROW-14679 [R] [C++] Handle suffix argument in joins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] github-actions[bot] commented on pull request #12113: Test and support for Suffix [WIP]

2022-01-10 Thread GitBox
github-actions[bot] commented on pull request #12113: URL: https://github.com/apache/arrow/pull/12113#issuecomment-1008782878 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow] dragosmg commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008790700 @github-actions crossbow submit test-ubuntu-default-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] rok commented on pull request #12105: ARROW-14098: [C++] subtract(time, time) -> interval kernel

2022-01-10 Thread GitBox
rok commented on pull request #12105: URL: https://github.com/apache/arrow/pull/12105#issuecomment-1008792702 Thanks for the review @edponce! I'm doubting myself a bit here - the Jira is asking for interval return type while this returns time at the moment. @cpcloud are we looking to ret

[GitHub] [arrow] github-actions[bot] commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
github-actions[bot] commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008797522 Revision: a3a759d0c4e5c6be968aad9c6452ca091c4491c2 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1382](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] dragosmg commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008798846 I think I am on the right track as the documentation job is failing with a code 3 which indicates we are on the correct branch of the conditional statement in `r_deps.sh` `

[GitHub] [arrow] dragosmg edited a comment on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg edited a comment on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008798846 I think I am on the right track as the docs job is failing with a code 3 which indicates we are on the correct branch of the conditional statement in `r_deps.sh` ```

[GitHub] [arrow-datafusion] Igosuki commented on pull request #68: Experimenting with arrow2

2022-01-10 Thread GitBox
Igosuki commented on pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#issuecomment-1008810117 I'm working on a new integration branch between the arrow2 that still has RecordBatch and the latest datafusion merged into @houqp 's branch, porting decimal type support

[GitHub] [arrow-datafusion] Igosuki commented on pull request #68: Experimenting with arrow2

2022-01-10 Thread GitBox
Igosuki commented on pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#issuecomment-1008810346 Will make a PR on @houqp 's fork when it's ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow-datafusion] Igosuki commented on issue #1532: Discussion: Switch DataFusion to using arrow2?

2022-01-10 Thread GitBox
Igosuki commented on issue #1532: URL: https://github.com/apache/arrow-datafusion/issues/1532#issuecomment-1008816041 Btw the latest arrow2 commit that still has RecordBatch is https://github.com/jorgecarleitao/arrow2/commit/ef7937dfe56033c2cc491482c67587b52cd91554 it would probably be go

[GitHub] [arrow] AlenkaF commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-10 Thread GitBox
AlenkaF commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r781171676 ## File path: python/pyarrow/table.pxi ## @@ -671,13 +671,61 @@ cdef class RecordBatch(_PandasConvertible): Returns --- Rec

[GitHub] [arrow] lidavidm commented on pull request #12000: ARROW-14705: [C++][Python] Handle more types in UnifySchemas

2022-01-10 Thread GitBox
lidavidm commented on pull request #12000: URL: https://github.com/apache/arrow/pull/12000#issuecomment-1008852544 I've used some #ifdefs so that ConcatenateTables can cast columns as necessary now. I still have some TODOs listed up top before I can undraft this. -- This is an automated

[GitHub] [arrow] edponce commented on pull request #12105: ARROW-14098: [C++] subtract(time, time) -> interval kernel

2022-01-10 Thread GitBox
edponce commented on pull request #12105: URL: https://github.com/apache/arrow/pull/12105#issuecomment-1008854270 Oops! Good that you noticed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] dragosmg commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008854900 @github-actions crossbow submit test-ubuntu-default-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] github-actions[bot] commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
github-actions[bot] commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008855952 Revision: bb08a408246f972dedce8c42597d7c50284c08fa Submitted crossbow builds: [ursacomputing/crossbow @ actions-1383](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] rok commented on a change in pull request #12097: ARROW-14590: [R] Implement lubridate::week

2022-01-10 Thread GitBox
rok commented on a change in pull request #12097: URL: https://github.com/apache/arrow/pull/12097#discussion_r781176982 ## File path: r/R/dplyr-funcs-datetime.R ## @@ -101,6 +101,10 @@ register_bindings_datetime <- function() { Expression$create("day_of_week", x, options =

[GitHub] [arrow] rok commented on pull request #12105: ARROW-14098: [C++] subtract(time, time) -> interval kernel

2022-01-10 Thread GitBox
rok commented on pull request #12105: URL: https://github.com/apache/arrow/pull/12105#issuecomment-1008861004 Although returning time is kind of semantically wrong. Duration is already covered so intervals it is. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] MironAtHome opened a new issue #12114: Build just doesn't work on windows. Any chance to put together decent .vcproj files?

2022-01-10 Thread GitBox
MironAtHome opened a new issue #12114: URL: https://github.com/apache/arrow/issues/12114 Hey guys, would you accept a few decent .vcproj files to build on windows? What you have with all these cmake and vcpkg is a. overly complicated b. doesn't work and the worst of it, with .vc

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12048: ARROW-15210: [Python] Pyarrow compute functions convert args with `__arrow_array__`.

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12048: URL: https://github.com/apache/arrow/pull/12048#discussion_r781185927 ## File path: python/pyarrow/_compute.pyx ## @@ -416,7 +416,8 @@ cdef class MetaFunction(Function): cdef _pack_compute_args(object values, v

[GitHub] [arrow] thisisnic commented on a change in pull request #12097: ARROW-14590: [R] Implement lubridate::week

2022-01-10 Thread GitBox
thisisnic commented on a change in pull request #12097: URL: https://github.com/apache/arrow/pull/12097#discussion_r78114 ## File path: r/R/dplyr-funcs-datetime.R ## @@ -101,6 +101,10 @@ register_bindings_datetime <- function() { Expression$create("day_of_week", x, opt

[GitHub] [arrow] thisisnic commented on a change in pull request #11942: ARROW-14762: [Doc] Additional info and resources

2022-01-10 Thread GitBox
thisisnic commented on a change in pull request #11942: URL: https://github.com/apache/arrow/pull/11942#discussion_r781190097 ## File path: docs/source/developers/guide/resources.rst ## @@ -27,3 +27,51 @@ Additional information and resourc

[GitHub] [arrow] thisisnic commented on a change in pull request #11942: ARROW-14762: [Doc] Additional info and resources

2022-01-10 Thread GitBox
thisisnic commented on a change in pull request #11942: URL: https://github.com/apache/arrow/pull/11942#discussion_r781190097 ## File path: docs/source/developers/guide/resources.rst ## @@ -27,3 +27,51 @@ Additional information and resourc

[GitHub] [arrow-cookbook] davisusanibar commented on a change in pull request #113: [Java]: Java cookbook recipes

2022-01-10 Thread GitBox
davisusanibar commented on a change in pull request #113: URL: https://github.com/apache/arrow-cookbook/pull/113#discussion_r781194359 ## File path: Makefile ## @@ -1,7 +1,7 @@ all: html -html: py r +html: py r j Review comment: When change to java I see ouput: "ma

[GitHub] [arrow-cookbook] lidavidm commented on a change in pull request #113: [Java]: Java cookbook recipes

2022-01-10 Thread GitBox
lidavidm commented on a change in pull request #113: URL: https://github.com/apache/arrow-cookbook/pull/113#discussion_r781195350 ## File path: Makefile ## @@ -1,7 +1,7 @@ all: html -html: py r +html: py r j Review comment: Ah, really? Hmm. (Oh, it might be getting

[GitHub] [arrow] kszucs commented on pull request #11821: ARROW-13841: [Doc] Document the different subcomponents that make up the CI and how they fit together

2022-01-10 Thread GitBox
kszucs commented on pull request #11821: URL: https://github.com/apache/arrow/pull/11821#issuecomment-1008881317 @thisisnic needs a rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12026: ARROW-12706: [Python] Drop Python 3.6 support

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12026: URL: https://github.com/apache/arrow/pull/12026#discussion_r781198805 ## File path: python/pyarrow/compat.pxi ## @@ -31,12 +29,8 @@ def encode_file_path(path): return encoded_path -if sys.version_info >=

[GitHub] [arrow] dragosmg commented on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg commented on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008886621 I think the docs might be failing due to `remotes::install_deps(dependencies = c("Config/Needs/webiste"))` only installing `pkgdown` and not it's dependencies, one of which is

[GitHub] [arrow] dragosmg edited a comment on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg edited a comment on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008886621 I think the docs might be failing due to `remotes::install_deps(dependencies = c("Config/Needs/website"))` only installing `pkgdown` and not it's dependencies, one of w

[GitHub] [arrow] dragosmg edited a comment on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg edited a comment on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008886621 I think the docs are failing due to `remotes::install_deps(dependencies = c("Config/Needs/website"))` only installing `pkgdown` and not it's dependencies, one of which

[GitHub] [arrow] dragosmg edited a comment on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg edited a comment on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008886621 I think the docs are failing due to `remotes::install_deps(dependencies = c("Config/Needs/website"))` only installing `pkgdown` and not its dependencies, one of which i

[GitHub] [arrow-rs] paddyhoran commented on a change in pull request #1146: Implement SIMD comparison operations for types with less than 4 lanes (i128)

2022-01-10 Thread GitBox
paddyhoran commented on a change in pull request #1146: URL: https://github.com/apache/arrow-rs/pull/1146#discussion_r781201456 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -1471,53 +1471,65 @@ where let null_bit_buffer = combine_option_bitmap(left.data_re

[GitHub] [arrow] dragosmg edited a comment on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg edited a comment on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008886621 I think the docs are failing due to `remotes::install_deps(dependencies = c("Config/Needs/website"))` only installing `pkgdown` and not its dependencies, one of which i

[GitHub] [arrow] jorisvandenbossche closed pull request #11985: ARROW-12545: [Python][Docs] Fill in section about Custom Schema and Field Metadata

2022-01-10 Thread GitBox
jorisvandenbossche closed pull request #11985: URL: https://github.com/apache/arrow/pull/11985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: git

[GitHub] [arrow] jorisvandenbossche closed pull request #12061: ARROW-15043: [Python][Docs] Include time64 to type conversion table for pandas <-> arrow

2022-01-10 Thread GitBox
jorisvandenbossche closed pull request #12061: URL: https://github.com/apache/arrow/pull/12061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: git

[GitHub] [arrow] dragosmg edited a comment on pull request #11921: ARROW-12743 [R] Add DESCRIPTION fields for dev dependencies

2022-01-10 Thread GitBox
dragosmg edited a comment on pull request #11921: URL: https://github.com/apache/arrow/pull/11921#issuecomment-1008886621 I think the docs are failing due to `remotes::install_deps(dependencies = c("Config/Needs/website"))` only installing `pkgdown` and not its dependencies, one of which i

[GitHub] [arrow] pitrou closed pull request #12085: ARROW-15248: [C++][Docs] Improve docs about linting/formatting

2022-01-10 Thread GitBox
pitrou closed pull request #12085: URL: https://github.com/apache/arrow/pull/12085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] jorisvandenbossche commented on pull request #12061: ARROW-15043: [Python][Docs] Include time64 to type conversion table for pandas <-> arrow

2022-01-10 Thread GitBox
jorisvandenbossche commented on pull request #12061: URL: https://github.com/apache/arrow/pull/12061#issuecomment-1008896283 @sanjibansg do you have a JIRA user name? Then I can properly attribute the issue resolve to you. -- This is an automated message from the Apache Git Service. To r

[GitHub] [arrow] ursabot commented on pull request #12061: ARROW-15043: [Python][Docs] Include time64 to type conversion table for pandas <-> arrow

2022-01-10 Thread GitBox
ursabot commented on pull request #12061: URL: https://github.com/apache/arrow/pull/12061#issuecomment-1008899887 Benchmark runs are scheduled for baseline = 3b8b4582fb6cb56830340e74d270d1acce6bad34 and contender = 05c616231b32b2f2956a4cbddd7987cba9eb9f5d. 05c616231b32b2f2956a4cbddd7987cb

[GitHub] [arrow] ursabot commented on pull request #12085: ARROW-15248: [C++][Docs] Improve docs about linting/formatting

2022-01-10 Thread GitBox
ursabot commented on pull request #12085: URL: https://github.com/apache/arrow/pull/12085#issuecomment-1008899897 Benchmark runs are scheduled for baseline = 05c616231b32b2f2956a4cbddd7987cba9eb9f5d and contender = 8ac0944cde06bdb8ec75d18ae1a77010c605c2de. 8ac0944cde06bdb8ec75d18ae1a77010

[GitHub] [arrow] ursabot commented on pull request #11985: ARROW-12545: [Python][Docs] Fill in section about Custom Schema and Field Metadata

2022-01-10 Thread GitBox
ursabot commented on pull request #11985: URL: https://github.com/apache/arrow/pull/11985#issuecomment-1008899880 Benchmark runs are scheduled for baseline = 4f0984e7f98ae40a70d2137de6b2da6a0f362a26 and contender = 3b8b4582fb6cb56830340e74d270d1acce6bad34. 3b8b4582fb6cb56830340e74d270d1ac

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12007: ARROW-15087: [Python][Docs] Document MapArray and update parent class to ListArray

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12007: URL: https://github.com/apache/arrow/pull/12007#discussion_r781217907 ## File path: python/pyarrow/tests/test_array.py ## @@ -2643,6 +2643,30 @@ def test_fixed_size_list_array_flatten(): assert arr2.flatten()

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12007: ARROW-15087: [Python][Docs] Document MapArray and update parent class to ListArray

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12007: URL: https://github.com/apache/arrow/pull/12007#discussion_r781218260 ## File path: python/pyarrow/tests/test_array.py ## @@ -2643,6 +2643,30 @@ def test_fixed_size_list_array_flatten(): assert arr2.flatten()

[GitHub] [arrow] pitrou commented on a change in pull request #11946: ARROW-13663: [C++] RecordBatchReader STL-like iteration

2022-01-10 Thread GitBox
pitrou commented on a change in pull request #11946: URL: https://github.com/apache/arrow/pull/11946#discussion_r781218663 ## File path: cpp/src/arrow/record_batch.h ## @@ -234,6 +234,67 @@ class ARROW_EXPORT RecordBatchReader { return batch; } + class RecordBatchRea

[GitHub] [arrow] pitrou commented on pull request #12109: MINOR: fix spelling of python

2022-01-10 Thread GitBox
pitrou commented on pull request #12109: URL: https://github.com/apache/arrow/pull/12109#issuecomment-1008904800 Thanks :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] pitrou closed pull request #12109: MINOR: fix spelling of python

2022-01-10 Thread GitBox
pitrou closed pull request #12109: URL: https://github.com/apache/arrow/pull/12109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] pitrou edited a comment on pull request #12109: MINOR: fix spelling of python

2022-01-10 Thread GitBox
pitrou edited a comment on pull request #12109: URL: https://github.com/apache/arrow/pull/12109#issuecomment-1008904800 Thanks @domoritz :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r781223239 ## File path: python/pyarrow/table.pxi ## @@ -1016,6 +1065,21 @@ cdef class RecordBatch(_PandasConvertible): entries.append((name,

[GitHub] [arrow] ursabot commented on pull request #12109: MINOR: fix spelling of python

2022-01-10 Thread GitBox
ursabot commented on pull request #12109: URL: https://github.com/apache/arrow/pull/12109#issuecomment-1008909165 Benchmark runs are scheduled for baseline = 8ac0944cde06bdb8ec75d18ae1a77010c605c2de and contender = 4ddcb352dc49f7a91ffd160c8a708908cf003f33. 4ddcb352dc49f7a91ffd160c8a708908

[GitHub] [arrow] ursabot edited a comment on pull request #11985: ARROW-12545: [Python][Docs] Fill in section about Custom Schema and Field Metadata

2022-01-10 Thread GitBox
ursabot edited a comment on pull request #11985: URL: https://github.com/apache/arrow/pull/11985#issuecomment-1008899880 Benchmark runs are scheduled for baseline = 4f0984e7f98ae40a70d2137de6b2da6a0f362a26 and contender = 3b8b4582fb6cb56830340e74d270d1acce6bad34. 3b8b4582fb6cb56830340e74d

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r781224257 ## File path: python/pyarrow/table.pxi ## @@ -2442,6 +2589,46 @@ def _from_pydict(cls, mapping, schema, metadata): raise TypeError('Sc

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r781224600 ## File path: python/pyarrow/table.pxi ## @@ -2442,6 +2589,46 @@ def _from_pydict(cls, mapping, schema, metadata): raise TypeError('Sc

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12010: ARROW-6001 [Python]: Add from_pylist() and to_pylist() to pyarrow.Table to convert list of records

2022-01-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #12010: URL: https://github.com/apache/arrow/pull/12010#discussion_r781224257 ## File path: python/pyarrow/table.pxi ## @@ -2442,6 +2589,46 @@ def _from_pydict(cls, mapping, schema, metadata): raise TypeError('Sc

[GitHub] [arrow] pitrou commented on a change in pull request #12077: ARROW-15109: [Python] Add show_info() to print build, component, and system info

2022-01-10 Thread GitBox
pitrou commented on a change in pull request #12077: URL: https://github.com/apache/arrow/pull/12077#discussion_r781226322 ## File path: python/pyarrow/memory.pxi ## @@ -247,3 +247,11 @@ def jemalloc_set_decay_ms(decay_ms): that this change will only affect future memo

[GitHub] [arrow] sanjibansg commented on pull request #12061: ARROW-15043: [Python][Docs] Include time64 to type conversion table for pandas <-> arrow

2022-01-10 Thread GitBox
sanjibansg commented on pull request #12061: URL: https://github.com/apache/arrow/pull/12061#issuecomment-1008914416 > @sanjibansg do you have a JIRA user name? Then I can properly attribute the issue resolve to you. @jorisvandenbossche Yes, my JIRA username is `sanjibansg`. Thanks!

[GitHub] [arrow] pitrou commented on a change in pull request #12089: ARROW-9285: [C++] Detect unauthorized memory allocations in function kernels

2022-01-10 Thread GitBox
pitrou commented on a change in pull request #12089: URL: https://github.com/apache/arrow/pull/12089#discussion_r781228567 ## File path: cpp/src/arrow/compute/exec.cc ## @@ -697,7 +771,18 @@ class ScalarExecutor : public KernelExecutorImpl { } } +// To check

[GitHub] [arrow] ursabot edited a comment on pull request #11985: ARROW-12545: [Python][Docs] Fill in section about Custom Schema and Field Metadata

2022-01-10 Thread GitBox
ursabot edited a comment on pull request #11985: URL: https://github.com/apache/arrow/pull/11985#issuecomment-1008899880 Benchmark runs are scheduled for baseline = 4f0984e7f98ae40a70d2137de6b2da6a0f362a26 and contender = 3b8b4582fb6cb56830340e74d270d1acce6bad34. 3b8b4582fb6cb56830340e74d

[GitHub] [arrow] thisisnic commented on issue #11934: [R] errors when downloading parquet files from s3.

2022-01-10 Thread GitBox
thisisnic commented on issue #11934: URL: https://github.com/apache/arrow/issues/11934#issuecomment-1008921648 Thanks for the report @JasperSch . Just to confirm, do you get any problems printing the retrieved data in the last step, or not, i.e. is it just the point at which you're runnin

[GitHub] [arrow] thisisnic commented on a change in pull request #11942: ARROW-14762: [Doc] Additional info and resources

2022-01-10 Thread GitBox
thisisnic commented on a change in pull request #11942: URL: https://github.com/apache/arrow/pull/11942#discussion_r781235986 ## File path: docs/source/developers/guide/resources.rst ## @@ -27,3 +27,51 @@ Additional information and resourc

[GitHub] [arrow] rok commented on a change in pull request #12097: ARROW-14590: [R] Implement lubridate::week

2022-01-10 Thread GitBox
rok commented on a change in pull request #12097: URL: https://github.com/apache/arrow/pull/12097#discussion_r781236541 ## File path: r/R/dplyr-funcs-datetime.R ## @@ -101,6 +101,10 @@ register_bindings_datetime <- function() { Expression$create("day_of_week", x, options =

[GitHub] [arrow] ursabot edited a comment on pull request #12061: ARROW-15043: [Python][Docs] Include time64 to type conversion table for pandas <-> arrow

2022-01-10 Thread GitBox
ursabot edited a comment on pull request #12061: URL: https://github.com/apache/arrow/pull/12061#issuecomment-1008899887 Benchmark runs are scheduled for baseline = 3b8b4582fb6cb56830340e74d270d1acce6bad34 and contender = 05c616231b32b2f2956a4cbddd7987cba9eb9f5d. 05c616231b32b2f2956a4cbdd

[GitHub] [arrow] jorisvandenbossche commented on pull request #12061: ARROW-15043: [Python][Docs] Include time64 to type conversion table for pandas <-> arrow

2022-01-10 Thread GitBox
jorisvandenbossche commented on pull request #12061: URL: https://github.com/apache/arrow/pull/12061#issuecomment-1008933942 Thanks, updated the JIRA issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion] domodwyer opened a new issue #1538: Quantile support

2022-01-10 Thread GitBox
domodwyer opened a new issue #1538: URL: https://github.com/apache/arrow-datafusion/issues/1538 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I would like to efficiently aggregate (approximate) quantile values from a column of

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1146: Implement SIMD comparison operations for types with less than 4 lanes (i128)

2022-01-10 Thread GitBox
codecov-commenter edited a comment on pull request #1146: URL: https://github.com/apache/arrow-rs/pull/1146#issuecomment-1008318204 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1146?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow] paleolimbot commented on issue #11934: [R] errors when downloading parquet files from s3.

2022-01-10 Thread GitBox
paleolimbot commented on issue #11934: URL: https://github.com/apache/arrow/issues/11934#issuecomment-1008942966 I couldn't reproduce this using minio locally...is there anything that I'm not understanding about your setup? If you can modify this example to reproduce your error we will be

[GitHub] [arrow] lidavidm commented on a change in pull request #12089: ARROW-9285: [C++] Detect unauthorized memory allocations in function kernels

2022-01-10 Thread GitBox
lidavidm commented on a change in pull request #12089: URL: https://github.com/apache/arrow/pull/12089#discussion_r781256754 ## File path: cpp/src/arrow/compute/exec.cc ## @@ -697,7 +771,18 @@ class ScalarExecutor : public KernelExecutorImpl { } } +// To chec

[GitHub] [arrow] ursabot edited a comment on pull request #12085: ARROW-15248: [C++][Docs] Improve docs about linting/formatting

2022-01-10 Thread GitBox
ursabot edited a comment on pull request #12085: URL: https://github.com/apache/arrow/pull/12085#issuecomment-1008899897 Benchmark runs are scheduled for baseline = 05c616231b32b2f2956a4cbddd7987cba9eb9f5d and contender = 8ac0944cde06bdb8ec75d18ae1a77010c605c2de. 8ac0944cde06bdb8ec75d18ae

[GitHub] [arrow-datafusion] domodwyer opened a new pull request #1539: approx_quantile() aggregation function

2022-01-10 Thread GitBox
domodwyer opened a new pull request #1539: URL: https://github.com/apache/arrow-datafusion/pull/1539 # Which issue does this PR close? Closes #1538. # What changes are included in this PR? A new `approx_quantile()` aggregation function. This PR also includes support f

[GitHub] [arrow-rs] sum12 commented on issue #38: Read temporal values from JSON

2022-01-10 Thread GitBox
sum12 commented on issue #38: URL: https://github.com/apache/arrow-rs/issues/38#issuecomment-1008956010 @alamb I would like to take a stab at this one (if it is still relevant) Thanks for looking :-) -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [arrow] ursabot edited a comment on pull request #12109: MINOR: fix spelling of python

2022-01-10 Thread GitBox
ursabot edited a comment on pull request #12109: URL: https://github.com/apache/arrow/pull/12109#issuecomment-1008909165 Benchmark runs are scheduled for baseline = 8ac0944cde06bdb8ec75d18ae1a77010c605c2de and contender = 4ddcb352dc49f7a91ffd160c8a708908cf003f33. 4ddcb352dc49f7a91ffd160c8

[GitHub] [arrow] nealrichardson commented on pull request #11738: ARROW-14169: [R] altrep for factors

2022-01-10 Thread GitBox
nealrichardson commented on pull request #11738: URL: https://github.com/apache/arrow/pull/11738#issuecomment-1008967677 @jonkeane are we trying to land this for 7.0.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] mbrobbel commented on pull request #12100: ARROW-15061: [C++] Add logging for kernel functions and exec plan nodes

2022-01-10 Thread GitBox
mbrobbel commented on pull request #12100: URL: https://github.com/apache/arrow/pull/12100#issuecomment-1008994369 Some example output in Jaeger: TPC-H query 1: ![Screenshot 2022-01-10 at 16 24 36](https://user-images.githubusercontent.com/5501570/148791478-3ffdb9db-0bfb-48ea-a322

  1   2   3   4   >