[GitHub] [arrow] github-actions[bot] commented on pull request #12199: ARROW-15380: [Python][Release] NumPy ABI incompatibility during verification

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12199: URL: https://github.com/apache/arrow/pull/12199#issuecomment-1017223137 https://issues.apache.org/jira/browse/ARROW-15380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-datafusion] pjmore commented on issue #1488: Float column type inferred as utf8 when reading csv

2022-01-20 Thread GitBox
pjmore commented on issue #1488: URL: https://github.com/apache/arrow-datafusion/issues/1488#issuecomment-1017226028 It looks like the type inference issues are caused by some numbers in scientific notation: ``` ❯ SELECT v1 from x where v1 not like '%.%'; +---+ | v1|

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017232988 @github-actions crossbow submit verify-rc-source-python-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017233907 Revision: 44617210c608b0beefb015cc37a39e374c23d191 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1408](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017239258 @github-actions crossbow submit verify-rc-source-python-* --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017240005 Revision: 44617210c608b0beefb015cc37a39e374c23d191 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1409](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] vibhatha commented on a change in pull request #12110: ARROW-15212: [C++] Handle suffix argument in joins

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12110: URL: https://github.com/apache/arrow/pull/12110#discussion_r788526908 ## File path: cpp/src/arrow/compute/exec/hash_join_node.cc ## @@ -275,30 +275,56 @@ Status HashJoinSchema::ValidateSchemas(JoinType join_type, const Sch

[GitHub] [arrow] ursabot edited a comment on pull request #10333: ARROW-12607: [Website] Doc section for Dataset Java bindings

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #10333: URL: https://github.com/apache/arrow/pull/10333#issuecomment-1016767910 Benchmark runs are scheduled for baseline = 39adf19f31a529eaec35704685532feee1d8c7a4 and contender = 58ca356659067577e6932a636cebafb6ccc7c0df. 58ca356659067577e6932a636

[GitHub] [arrow] ursabot edited a comment on pull request #12182: ARROW-15360: [Python] Check slice bounds in Buffer.slice()

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #12182: URL: https://github.com/apache/arrow/pull/12182#issuecomment-1016767971 Benchmark runs are scheduled for baseline = 09f23ed7fd248dd7d5e16dfeccef035e97f336e0 and contender = fd580db7573f56ef57bfa8ba97caa67e69a79ef6. fd580db7573f56ef57bfa8ba9

[GitHub] [arrow] AlenkaF opened a new pull request #12201: ARROW-15345: [Doc][Guide] Finding JIRA issues - minor corrections

2022-01-20 Thread GitBox
AlenkaF opened a new pull request #12201: URL: https://github.com/apache/arrow/pull/12201 Changed last sentence in the **Finding good first issues** section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow] github-actions[bot] commented on pull request #12200: ARROW-15344: [Doc][Guide] Communication - minor corrections

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12200: URL: https://github.com/apache/arrow/pull/12200#issuecomment-1017287739 https://issues.apache.org/jira/browse/ARROW-15344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] github-actions[bot] commented on pull request #12201: ARROW-15345: [Doc][Guide] Finding JIRA issues - minor corrections

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12201: URL: https://github.com/apache/arrow/pull/12201#issuecomment-1017290675 https://issues.apache.org/jira/browse/ARROW-15345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] pdet commented on pull request #11730: ARROW-14745: [R] Enable true duckdb streaming

2022-01-20 Thread GitBox
pdet commented on pull request #11730: URL: https://github.com/apache/arrow/pull/11730#issuecomment-1017303484 I've checked the comments of @westonpace, and by releasing (in the unique_ptr sense) the chunk pointers when scanning arrow objects instead of deleting them, the error is fixed, s

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017304464 @github-actions crossbow submit verify-rc-source-python-macos* --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017308065 @github-actions crossbow submit verify-rc-source-windows --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017309204 Revision: df0f92ccdcf483963b0f014953ab029a0df9f802 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1410](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] dragosmg commented on a change in pull request #12179: ARROW-14609 [R] left_join by argument error message mismatch

2022-01-20 Thread GitBox
dragosmg commented on a change in pull request #12179: URL: https://github.com/apache/arrow/pull/12179#discussion_r787565796 ## File path: r/tests/testthat/_snaps/dplyr-join.md ## @@ -0,0 +1,50 @@ +# Error handling + +Code + (expect_error(left_join(arrow_table(example_

[GitHub] [arrow-datafusion] liukun4515 commented on issue #1488: Float column type inferred as utf8 when reading csv

2022-01-20 Thread GitBox
liukun4515 commented on issue #1488: URL: https://github.com/apache/arrow-datafusion/issues/1488#issuecomment-1017317756 > maybe arrow-rs can't handle this situation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017321175 Revision: df0f92ccdcf483963b0f014953ab029a0df9f802 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1411](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] dragosmg commented on a change in pull request #12179: ARROW-14609 [R] left_join by argument error message mismatch

2022-01-20 Thread GitBox
dragosmg commented on a change in pull request #12179: URL: https://github.com/apache/arrow/pull/12179#discussion_r788617132 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -90,8 +90,56 @@ test_that("Error handling", { left_tab %>% left_join(to_join, by = "no

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788630545 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017341911 @github-actions crossbow submit verify-rc-source-python-macos* --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017344675 Revision: 1c7c55da2ca0132583a6d54e62e7746facf93d94 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1412](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788650049 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788650049 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788652775 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow-rs] tustvold commented on pull request #1180: Preserve dictionary encoding when decoding parquet into Arrow arrays (#171)

2022-01-20 Thread GitBox
tustvold commented on pull request #1180: URL: https://github.com/apache/arrow-rs/pull/1180#issuecomment-1017397095 I've pushed a commit that fixes the handling of empty dictionaries. I vacillated between returning an error if trying to read data from a column with an empty dictionary, or

[GitHub] [arrow] github-actions[bot] commented on pull request #12202: ARROW-15378: [C++][Release] GTest linking error during windows verification

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12202: URL: https://github.com/apache/arrow/pull/12202#issuecomment-1017397111 https://issues.apache.org/jira/browse/ARROW-15378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] ursabot edited a comment on pull request #11726: ARROW-14738: [Python][Doc] Make return types clickable

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #11726: URL: https://github.com/apache/arrow/pull/11726#issuecomment-1016768053 Benchmark runs are scheduled for baseline = fd580db7573f56ef57bfa8ba97caa67e69a79ef6 and contender = e9e16c9da7a76718640f2b3f23200a3755790011. e9e16c9da7a76718640f2b3f2

[GitHub] [arrow-rs] tustvold edited a comment on pull request #1180: Preserve dictionary encoding when decoding parquet into Arrow arrays (#171)

2022-01-20 Thread GitBox
tustvold edited a comment on pull request #1180: URL: https://github.com/apache/arrow-rs/pull/1180#issuecomment-1017397095 I've pushed a commit that fixes the handling of empty dictionaries. I vacillated between returning an error if trying to read data from a column with an empty dictiona

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788668858 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788673710 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] ursabot edited a comment on pull request #11679: ARROW-14671: [Python][Doc] Documentation on how to integrate PyArrow and R

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #11679: URL: https://github.com/apache/arrow/pull/11679#issuecomment-1016767925 Benchmark runs are scheduled for baseline = 58ca356659067577e6932a636cebafb6ccc7c0df and contender = 53e7293f04787842c55b795adefcc1aa21b59cd7. 53e7293f04787842c55b795ad

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788675215 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow-datafusion] FauxFaux opened a new issue #1619: Support for BitwiseAnd `&`, BitOr `|` binary operators

2022-01-20 Thread GitBox
FauxFaux opened a new issue #1619: URL: https://github.com/apache/arrow-datafusion/issues/1619 My parquet file contains a bitpacked `flags` (i32, but pretend it's u32). The 2nd bit in `flags` indicates whether the record is a potato or not. I would like to be able to access this from SQL.

[GitHub] [arrow] github-actions[bot] commented on pull request #12203: ARROW-15387 [R] Un-skip chunked array test for decimal256()

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12203: URL: https://github.com/apache/arrow/pull/12203#issuecomment-1017407058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017407754 @github-actions crossbow submit verify-rc-source-windows --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017409596 @github-actions crossbow submit verify-rc-source-windows --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788686633 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] kszucs commented on pull request #12199: ARROW-15380: [Python][Release] NumPy ABI incompatibility during verification

2022-01-20 Thread GitBox
kszucs commented on pull request #12199: URL: https://github.com/apache/arrow/pull/12199#issuecomment-1017417723 Resolves the verification issue: https://github.com/apache/arrow/pull/12187#issuecomment-1017344675 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017417832 Revision: f8f46c8cf901b810fd03f766e36407c2a259f78c Submitted crossbow builds: [ursacomputing/crossbow @ actions-1413](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs closed pull request #12199: ARROW-15380: [Python][Release] NumPy ABI incompatibility during verification

2022-01-20 Thread GitBox
kszucs closed pull request #12199: URL: https://github.com/apache/arrow/pull/12199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] pitrou opened a new pull request #12204: ARROW-15388: [C++] Avoid including absl from flatbuffers

2022-01-20 Thread GitBox
pitrou opened a new pull request #12204: URL: https://github.com/apache/arrow/pull/12204 There may be an incomplete/broken copy of the Abseil library lying around (for example because of a race condition while installing it as a bundled library). Since absl is only used by Flatbuf

[GitHub] [arrow] pitrou commented on pull request #12204: ARROW-15388: [C++] Avoid including absl from flatbuffers

2022-01-20 Thread GitBox
pitrou commented on pull request #12204: URL: https://github.com/apache/arrow/pull/12204#issuecomment-1017419378 @coryan Not sure whether you have an opinion on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1180: Preserve dictionary encoding when decoding parquet into Arrow arrays (#171)

2022-01-20 Thread GitBox
tustvold commented on a change in pull request #1180: URL: https://github.com/apache/arrow-rs/pull/1180#discussion_r788688649 ## File path: parquet/src/arrow/array_reader/byte_array_dictionary.rs ## @@ -0,0 +1,510 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [arrow] ursabot commented on pull request #12199: ARROW-15380: [Python][Release] NumPy ABI incompatibility during verification

2022-01-20 Thread GitBox
ursabot commented on pull request #12199: URL: https://github.com/apache/arrow/pull/12199#issuecomment-1017419639 Benchmark runs are scheduled for baseline = c5358787ee8f7b80f067292f49e5f032854041b9 and contender = 190dba53c1d741036c02755be25f67b50d384e96. 190dba53c1d741036c02755be25f67b5

[GitHub] [arrow-rs] alamb commented on a change in pull request #1210: Improve changelog generator script settings

2022-01-20 Thread GitBox
alamb commented on a change in pull request #1210: URL: https://github.com/apache/arrow-rs/pull/1210#discussion_r788689611 ## File path: dev/release/update_change_log.sh ## @@ -36,7 +36,9 @@ pushd ${SOURCE_TOP_DIR} docker run -it --rm -e CHANGELOG_GITHUB_TOKEN=$CHANGELOG_GITHU

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1180: Preserve dictionary encoding when decoding parquet into Arrow arrays (#171)

2022-01-20 Thread GitBox
tustvold commented on a change in pull request #1180: URL: https://github.com/apache/arrow-rs/pull/1180#discussion_r788690328 ## File path: parquet/src/arrow/arrow_reader.rs ## @@ -470,9 +454,78 @@ mod tests { 2, ConvertedType::UTF8, Some(

[GitHub] [arrow-rs] alamb opened a new pull request #1212: Prepare for 8.0.0 release: Update CHANGELOG and versions

2022-01-20 Thread GitBox
alamb opened a new pull request #1212: URL: https://github.com/apache/arrow-rs/pull/1212 Prepares for 8.0.0 release Changelog was made via script (changes in https://github.com/apache/arrow-rs/pull/1210) and fiddling with the titles and tags on PR/issues You can see the re

[GitHub] [arrow] dragosmg commented on a change in pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-20 Thread GitBox
dragosmg commented on a change in pull request #12170: URL: https://github.com/apache/arrow/pull/12170#discussion_r788692203 ## File path: r/R/dataset-format.R ## @@ -309,14 +309,52 @@ FileWriteOptions <- R6Class("FileWriteOptions", inherit = ArrowObject, public = list(

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788694350 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] kszucs commented on pull request #12202: ARROW-15378: [C++][Release] GTest linking error during windows verification

2022-01-20 Thread GitBox
kszucs commented on pull request #12202: URL: https://github.com/apache/arrow/pull/12202#issuecomment-1017426225 Seems like this is the workaround we use for daily testing https://github.com/apache/arrow/blob/master/ci/appveyor-cpp-setup.bat#L85 -- This is an automated message from the A

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788695753 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] dragosmg commented on a change in pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-20 Thread GitBox
dragosmg commented on a change in pull request #12170: URL: https://github.com/apache/arrow/pull/12170#discussion_r788696012 ## File path: r/R/dataset-format.R ## @@ -309,14 +309,52 @@ FileWriteOptions <- R6Class("FileWriteOptions", inherit = ArrowObject, public = list(

[GitHub] [arrow] dragosmg commented on a change in pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-20 Thread GitBox
dragosmg commented on a change in pull request #12170: URL: https://github.com/apache/arrow/pull/12170#discussion_r788696012 ## File path: r/R/dataset-format.R ## @@ -309,14 +309,52 @@ FileWriteOptions <- R6Class("FileWriteOptions", inherit = ArrowObject, public = list(

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017428842 Revision: f8f46c8cf901b810fd03f766e36407c2a259f78c Submitted crossbow builds: [ursacomputing/crossbow @ actions-1414](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788698379 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788700062 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] github-actions[bot] commented on pull request #12204: ARROW-15388: [C++] Avoid including absl from flatbuffers

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12204: URL: https://github.com/apache/arrow/pull/12204#issuecomment-1017432643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788702782 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] ursabot edited a comment on pull request #12199: ARROW-15380: [Python][Release] NumPy ABI incompatibility during verification

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #12199: URL: https://github.com/apache/arrow/pull/12199#issuecomment-1017419639 Benchmark runs are scheduled for baseline = c5358787ee8f7b80f067292f49e5f032854041b9 and contender = 190dba53c1d741036c02755be25f67b50d384e96. 190dba53c1d741036c02755be

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788704891 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] dragosmg commented on a change in pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-20 Thread GitBox
dragosmg commented on a change in pull request #12170: URL: https://github.com/apache/arrow/pull/12170#discussion_r788711531 ## File path: r/R/dataset-format.R ## @@ -309,14 +309,52 @@ FileWriteOptions <- R6Class("FileWriteOptions", inherit = ArrowObject, public = list(

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788715701 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017447486 @github-actions crossbow submit verify-rc-source-windows --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017450200 @github-actions crossbow submit verify-rc-source-js-macos* --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017450877 Revision: 699be7fb42e2ea568893df91c17ee3edefd29140 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1415](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788720711 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] kszucs closed pull request #12201: ARROW-15345: [Doc][Guide] Finding JIRA issues - minor corrections

2022-01-20 Thread GitBox
kszucs closed pull request #12201: URL: https://github.com/apache/arrow/pull/12201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] ursabot commented on pull request #12201: ARROW-15345: [Doc][Guide] Finding JIRA issues - minor corrections

2022-01-20 Thread GitBox
ursabot commented on pull request #12201: URL: https://github.com/apache/arrow/pull/12201#issuecomment-1017460135 Benchmark runs are scheduled for baseline = 190dba53c1d741036c02755be25f67b50d384e96 and contender = 5d336310c06e138ef2bf7e74fe0e374d0645631f. 5d336310c06e138ef2bf7e74fe0e374d

[GitHub] [arrow] kszucs closed pull request #12200: ARROW-15344: [Doc][Guide] Communication - minor corrections

2022-01-20 Thread GitBox
kszucs closed pull request #12200: URL: https://github.com/apache/arrow/pull/12200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] Igosuki commented on pull request #1556: Officially maintained Arrow2 branch

2022-01-20 Thread GitBox
Igosuki commented on pull request #1556: URL: https://github.com/apache/arrow-datafusion/pull/1556#issuecomment-1017460977 Great work @houqp Le jeu. 20 janv. 2022 à 08:27, Yijie Shen ***@***.***> a écrit : > Wow! Milestone reached! Thanks for driving on this and making it h

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788726816 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] kszucs closed pull request #12194: ARROW-15383: [Release] Add a script to update MSYS2 package

2022-01-20 Thread GitBox
kszucs closed pull request #12194: URL: https://github.com/apache/arrow/pull/12194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788727689 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788730263 ## File path: cpp/examples/arrow/execution_plan_documentation_examples.cc ## @@ -0,0 +1,901 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [arrow] ursabot commented on pull request #12200: ARROW-15344: [Doc][Guide] Communication - minor corrections

2022-01-20 Thread GitBox
ursabot commented on pull request #12200: URL: https://github.com/apache/arrow/pull/12200#issuecomment-1017470550 Benchmark runs are scheduled for baseline = 5d336310c06e138ef2bf7e74fe0e374d0645631f and contender = 60208b18aff0b3495a0762f3ab1fefb038cee200. 60208b18aff0b3495a0762f3ab1fefb0

[GitHub] [arrow] ursabot commented on pull request #12194: ARROW-15383: [Release] Add a script to update MSYS2 package

2022-01-20 Thread GitBox
ursabot commented on pull request #12194: URL: https://github.com/apache/arrow/pull/12194#issuecomment-1017470587 Benchmark runs are scheduled for baseline = 60208b18aff0b3495a0762f3ab1fefb038cee200 and contender = 84f929c3b1125a522d318d551559830aecafb89f. 84f929c3b1125a522d318d551559830a

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017472611 Revision: 699be7fb42e2ea568893df91c17ee3edefd29140 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1416](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs commented on pull request #12205: MINOR: [CI] Skip matlab builds if the pull request has WIP in its title

2022-01-20 Thread GitBox
kszucs commented on pull request #12205: URL: https://github.com/apache/arrow/pull/12205#issuecomment-1017477762 Build is skipped as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788735307 ## File path: cpp/examples/arrow/execution_plan_documentation_examples.cc ## @@ -0,0 +1,901 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [arrow] ursabot edited a comment on pull request #12201: ARROW-15345: [Doc][Guide] Finding JIRA issues - minor corrections

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #12201: URL: https://github.com/apache/arrow/pull/12201#issuecomment-1017460135 Benchmark runs are scheduled for baseline = 190dba53c1d741036c02755be25f67b50d384e96 and contender = 5d336310c06e138ef2bf7e74fe0e374d0645631f. 5d336310c06e138ef2bf7e74f

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788743782 ## File path: cpp/examples/arrow/execution_plan_documentation_examples.cc ## @@ -0,0 +1,901 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [arrow] ursabot edited a comment on pull request #12200: ARROW-15344: [Doc][Guide] Communication - minor corrections

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #12200: URL: https://github.com/apache/arrow/pull/12200#issuecomment-1017470550 Benchmark runs are scheduled for baseline = 5d336310c06e138ef2bf7e74fe0e374d0645631f and contender = 60208b18aff0b3495a0762f3ab1fefb038cee200. 60208b18aff0b3495a0762f3a

[GitHub] [arrow] ursabot edited a comment on pull request #12186: ARROW-15343: [Doc][Guide] Introduction and the checklist - minor corrections

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #12186: URL: https://github.com/apache/arrow/pull/12186#issuecomment-1016768058 Benchmark runs are scheduled for baseline = e9e16c9da7a76718640f2b3f23200a3755790011 and contender = deb6e132da927abeb0be4d0b8ad5eee8d49d9980. deb6e132da927abeb0be4d0b8

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-20 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r788751815 ## File path: cpp/src/arrow/compute/kernels/scalar_nested_test.cc ## @@ -225,6 +225,167 @@ TEST(TestScalarNested, StructField) { } } +TEST(TestSc

[GitHub] [arrow] kszucs commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
kszucs commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017495488 @github-actions crossbow submit verify-rc-source-js-macos* --param release=7.0.0 --param rc=0 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-20 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r788753004 ## File path: cpp/src/arrow/compute/kernels/scalar_nested_test.cc ## @@ -225,6 +225,167 @@ TEST(TestScalarNested, StructField) { } } +TEST(TestSc

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788757219 ## File path: cpp/examples/arrow/execution_plan_documentation_examples.cc ## @@ -0,0 +1,901 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [arrow] vibhatha commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
vibhatha commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788695753 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] lidavidm commented on a change in pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-20 Thread GitBox
lidavidm commented on a change in pull request #12033: URL: https://github.com/apache/arrow/pull/12033#discussion_r788761495 ## File path: docs/source/cpp/streaming_execution.rst ## @@ -305,3 +305,497 @@ Datasets may be scanned multiple times; just make multiple scan nodes fr

[GitHub] [arrow] kszucs commented on pull request #12202: ARROW-15378: [C++][Release] GTest linking error during windows verification

2022-01-20 Thread GitBox
kszucs commented on pull request #12202: URL: https://github.com/apache/arrow/pull/12202#issuecomment-1017503648 Build is passing here https://github.com/apache/arrow/pull/12187#issuecomment-1017450877 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [arrow] kszucs closed pull request #12202: ARROW-15378: [C++][Release] GTest linking error during windows verification

2022-01-20 Thread GitBox
kszucs closed pull request #12202: URL: https://github.com/apache/arrow/pull/12202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] github-actions[bot] commented on pull request #12187: [Release] Verify 7.0.0 RC0 [WIP]

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12187: URL: https://github.com/apache/arrow/pull/12187#issuecomment-1017506694 Revision: 147840ef744f1fcfbb92314e29dbbaac8f56c70d Submitted crossbow builds: [ursacomputing/crossbow @ actions-1417](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] ursabot commented on pull request #12202: ARROW-15378: [C++][Release] GTest linking error during windows verification

2022-01-20 Thread GitBox
ursabot commented on pull request #12202: URL: https://github.com/apache/arrow/pull/12202#issuecomment-1017507046 Benchmark runs are scheduled for baseline = 84f929c3b1125a522d318d551559830aecafb89f and contender = e9f9d40d04cb5e34739598b41026c192a9f3fa27. e9f9d40d04cb5e34739598b41026c192

[GitHub] [arrow] github-actions[bot] commented on pull request #12206: ARROW-15377: [Release] Bump nodejs version to 16 in the macOS verification builds

2022-01-20 Thread GitBox
github-actions[bot] commented on pull request #12206: URL: https://github.com/apache/arrow/pull/12206#issuecomment-1017507295 https://issues.apache.org/jira/browse/ARROW-15377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] lidavidm commented on a change in pull request #12136: ARROW-14092: [C++] subtract(date, duration) -> timestamp kernel

2022-01-20 Thread GitBox
lidavidm commented on a change in pull request #12136: URL: https://github.com/apache/arrow/pull/12136#discussion_r788767993 ## File path: docs/source/cpp/compute.rst ## @@ -420,39 +420,39 @@ precisions/scales will be promoted appropriately. Mixed decimal and floating-point a

[GitHub] [arrow] kszucs commented on pull request #12206: ARROW-15377: [Release] Bump nodejs version to 16 in the macOS verification builds

2022-01-20 Thread GitBox
kszucs commented on pull request #12206: URL: https://github.com/apache/arrow/pull/12206#issuecomment-1017513781 Tested here https://github.com/apache/arrow/pull/12187#issuecomment-1017506694 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [arrow] kszucs closed pull request #12206: ARROW-15377: [Release] Bump nodejs version to 16 in the macOS verification builds

2022-01-20 Thread GitBox
kszucs closed pull request #12206: URL: https://github.com/apache/arrow/pull/12206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] ursabot edited a comment on pull request #12194: ARROW-15383: [Release] Add a script to update MSYS2 package

2022-01-20 Thread GitBox
ursabot edited a comment on pull request #12194: URL: https://github.com/apache/arrow/pull/12194#issuecomment-1017470587 Benchmark runs are scheduled for baseline = 60208b18aff0b3495a0762f3ab1fefb038cee200 and contender = 84f929c3b1125a522d318d551559830aecafb89f. 84f929c3b1125a522d318d551

  1   2   3   4   >