[GitHub] [arrow] ursabot commented on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment

2022-01-21 Thread GitBox
ursabot commented on pull request #12214: URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018269017 Benchmark runs are scheduled for baseline = 658bec37aa5cbdd53b5e4cdc81b8ba3962e67f11 and contender = a2fe24fe970bce082782225c16ff7ac45989884b. a2fe24fe970bce082782225c16ff7ac4

[GitHub] [arrow] kszucs commented on a change in pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment

2022-01-21 Thread GitBox
kszucs commented on a change in pull request #12214: URL: https://github.com/apache/arrow/pull/12214#discussion_r789433557 ## File path: .travis.yml ## @@ -162,8 +162,6 @@ jobs: " allow_failures: -- name: "Go on ARM" -- name: "Go on s390x" Review commen

[GitHub] [arrow] ursabot edited a comment on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12214: URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018269017 Benchmark runs are scheduled for baseline = 658bec37aa5cbdd53b5e4cdc81b8ba3962e67f11 and contender = a2fe24fe970bce082782225c16ff7ac45989884b. a2fe24fe970bce082782225c1

[GitHub] [arrow] AlenkaF opened a new pull request #12218: ARROW-14816: [R] Implement bindings for lubridate::mday

2022-01-21 Thread GitBox
AlenkaF opened a new pull request #12218: URL: https://github.com/apache/arrow/pull/12218 Adding a binding for `lubridate::mday` in _expressions.R_ and a test for date and timestamp. Note: `day()` is an aliase for `mday()` in lubridate. -- This is an automated message from the Apa

[GitHub] [arrow] kszucs commented on pull request #12219: [Release] Verify 7.0.0 RC3 [WIP]

2022-01-21 Thread GitBox
kszucs commented on pull request #12219: URL: https://github.com/apache/arrow/pull/12219#issuecomment-1018298762 @github-actions crossbow submit --group verify-rc-source --param release=7.0.0 --param rc=3 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] github-actions[bot] commented on pull request #12218: ARROW-14816: [R] Implement bindings for lubridate::mday

2022-01-21 Thread GitBox
github-actions[bot] commented on pull request #12218: URL: https://github.com/apache/arrow/pull/12218#issuecomment-1018320604 https://issues.apache.org/jira/browse/ARROW-14816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] ursabot edited a comment on pull request #12202: ARROW-15378: [C++][Release] GTest linking error during windows verification

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12202: URL: https://github.com/apache/arrow/pull/12202#issuecomment-1017507046 Benchmark runs are scheduled for baseline = 84f929c3b1125a522d318d551559830aecafb89f and contender = e9f9d40d04cb5e34739598b41026c192a9f3fa27. e9f9d40d04cb5e34739598b41

[GitHub] [arrow] kszucs closed pull request #12217: [Release] Verify 7.0.0 RC2 [WIP]

2022-01-21 Thread GitBox
kszucs closed pull request #12217: URL: https://github.com/apache/arrow/pull/12217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] kszucs commented on pull request #12217: [Release] Verify 7.0.0 RC2 [WIP]

2022-01-21 Thread GitBox
kszucs commented on pull request #12217: URL: https://github.com/apache/arrow/pull/12217#issuecomment-1018337712 Closig in favor of #12219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [arrow-datafusion] jhorstmann commented on issue #1570: Memory Limited GroupBy (Externalized / Spill)

2022-01-21 Thread GitBox
jhorstmann commented on issue #1570: URL: https://github.com/apache/arrow-datafusion/issues/1570#issuecomment-1018351513 For hash aggregation I quite like the implementation described in https://dl.acm.org/doi/pdf/10.1145/2588555.2610507 (4.4). The algorithm there optimizes for cache loca

[GitHub] [arrow-datafusion] yjshen opened a new pull request #1624: Optimize `SortPreservingMergeStream` to avoid `SortKeyCursor` sharing

2022-01-21 Thread GitBox
yjshen opened a new pull request #1624: URL: https://github.com/apache/arrow-datafusion/pull/1624 # Which issue does this PR close? Closes #. This PR is based on #1596 so please review that one first. # Rationale for this change In `SortPreservingMergeStream`

[GitHub] [arrow] ursabot edited a comment on pull request #12168: ARROW-15316 [R] Make a one-function pointer function

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12168: URL: https://github.com/apache/arrow/pull/12168#issuecomment-1016932208 Benchmark runs are scheduled for baseline = 657d21ad6e56cc6c2c9b1aeeb5cea983210296b6 and contender = a061c4cc07a047cf30b590091f35856f1bd3fa96. a061c4cc07a047cf30b590091

[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1625: fix dependabot

2022-01-21 Thread GitBox
xudong963 opened a new pull request #1625: URL: https://github.com/apache/arrow-datafusion/pull/1625 # Which issue does this PR close? try to fix dependabot # Rationale for this change # What changes are included in this PR? # Are there any user-f

[GitHub] [arrow] kszucs commented on pull request #12220: [Python] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
kszucs commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018378191 Crossbow builds: https://github.com/ursacomputing/crossbow/branches/all?query=build-594 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-cookbook] thisisnic merged pull request #117: Update reading_and_writing_data.Rmd (formatting)

2022-01-21 Thread GitBox
thisisnic merged pull request #117: URL: https://github.com/apache/arrow-cookbook/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] cyb70289 commented on pull request #12196: [RFC] ARROW-15282: [C++][FlightRPC] Support non-grpc data planes

2022-01-21 Thread GitBox
cyb70289 commented on pull request #12196: URL: https://github.com/apache/arrow/pull/12196#issuecomment-1018387095 Thanks @lidavidm ! Now looks to me UCX transport is the better way. My main concern of the data plane approach is that we have to build by ourselves the data tran

[GitHub] [arrow-rs] tustvold opened a new issue #1217: Dictionary Uniqueness and Sortedness

2022-01-21 Thread GitBox
tustvold opened a new issue #1217: URL: https://github.com/apache/arrow-rs/issues/1217 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** A schema Field currently has a `dict_is_ordered` field. Much like `dict_id` this is non-tr

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #1596: Consolidate sort and external_sort

2022-01-21 Thread GitBox
yjshen edited a comment on pull request #1596: URL: https://github.com/apache/arrow-datafusion/pull/1596#issuecomment-1017112437 @alamb I find some of my messages for you are lost, maybe because of my unstable network. Yes, I think the PR is ready for another round of review now.

[GitHub] [arrow-datafusion] thinkharderdev commented on a change in pull request #1622: Handle merging of evolved schemas in ParquetExec

2022-01-21 Thread GitBox
thinkharderdev commented on a change in pull request #1622: URL: https://github.com/apache/arrow-datafusion/pull/1622#discussion_r789563040 ## File path: datafusion/src/physical_plan/file_format/parquet.rs ## @@ -385,9 +388,35 @@ fn build_row_group_predicate( } } +// Ma

[GitHub] [arrow-rs] tustvold opened a new issue #1218: Cast Dictionary Options

2022-01-21 Thread GitBox
tustvold opened a new issue #1218: URL: https://github.com/apache/arrow-rs/issues/1218 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Currently when casting an array to DictionaryArray, the code will compute a new dictionary

[GitHub] [arrow] github-actions[bot] commented on pull request #12219: [Release] Verify 7.0.0 RC3 [WIP]

2022-01-21 Thread GitBox
github-actions[bot] commented on pull request #12219: URL: https://github.com/apache/arrow/pull/12219#issuecomment-1018415013 Revision: 5adb80d28ae7d1b74210edb293ef3e9f15a0dd6e Submitted crossbow builds: [ursacomputing/crossbow @ actions-1420](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] ursabot edited a comment on pull request #12206: ARROW-15377: [Release] Bump nodejs version to 16 in the macOS verification builds

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12206: URL: https://github.com/apache/arrow/pull/12206#issuecomment-1017515469 Benchmark runs are scheduled for baseline = e9f9d40d04cb5e34739598b41026c192a9f3fa27 and contender = df37b41d62c674543e2885a0f3d27219b5fedcf9. df37b41d62c674543e2885a0f

[GitHub] [arrow] kszucs commented on pull request #12220: [Python] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
kszucs commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018432929 Crossbow builds: https://github.com/ursacomputing/crossbow/branches/all?query=build-595 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] bkmgit commented on pull request #12196: [RFC] ARROW-15282: [C++][FlightRPC] Support non-grpc data planes

2022-01-21 Thread GitBox
bkmgit commented on pull request #12196: URL: https://github.com/apache/arrow/pull/12196#issuecomment-1018442427 How were the tests run? Assume the [flight benchmark](https://github.com/cyb70289/arrow/blob/flight-data-plane/cpp/src/arrow/flight/flight_benchmark.cc) as described at https:/

[GitHub] [arrow] lianghanzhen opened a new pull request #12221: Fix typo

2022-01-21 Thread GitBox
lianghanzhen opened a new pull request #12221: URL: https://github.com/apache/arrow/pull/12221 `iff` -> `if` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [arrow-rs] alamb commented on pull request #1210: Improve changelog generator script settings

2022-01-21 Thread GitBox
alamb commented on pull request #1210: URL: https://github.com/apache/arrow-rs/pull/1210#issuecomment-1018442845 > Very cool, we should steal this for datafusion as well :D Yeah it is quite neat. It is something @jorgecarleitao found and setup. It never really worked well with a `ac

[GitHub] [arrow-rs] alamb merged pull request #1210: Improve changelog generator script settings

2022-01-21 Thread GitBox
alamb merged pull request #1210: URL: https://github.com/apache/arrow-rs/pull/1210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] github-actions[bot] commented on pull request #12221: Fix typo

2022-01-21 Thread GitBox
github-actions[bot] commented on pull request #12221: URL: https://github.com/apache/arrow/pull/12221#issuecomment-1018442943 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow-datafusion] alamb commented on pull request #1595: Fix null comparison for Parquet pruning predicate

2022-01-21 Thread GitBox
alamb commented on pull request #1595: URL: https://github.com/apache/arrow-datafusion/pull/1595#issuecomment-1018443298 Thanks @houqp ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow] github-actions[bot] commented on pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
github-actions[bot] commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018446614 https://issues.apache.org/jira/browse/ARROW-15403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-rs] tustvold opened a new pull request #1219: Do not concatenate identical dictionaries

2022-01-21 Thread GitBox
tustvold opened a new pull request #1219: URL: https://github.com/apache/arrow-rs/pull/1219 # Which issue does this PR close? Closes #504 # Rationale for this change See ticket # What changes are included in this PR? Adds `ArrayData::ptr_eq` and then uses

[GitHub] [arrow-rs] alamb merged pull request #1212: Prepare for 8.0.0 release: Update CHANGELOG and versions

2022-01-21 Thread GitBox
alamb merged pull request #1212: URL: https://github.com/apache/arrow-rs/pull/1212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] kszucs commented on pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
kszucs commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018454851 Seems like this is going to resolve the packaging issues. We should update the ORC version in vcpkg on long term, so we can remove these workarounds. @dongjoon-hyun or @i

[GitHub] [arrow] kszucs commented on pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
kszucs commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018459001 Crossbow builds for the M1 wheels: https://github.com/ursacomputing/crossbow/branches/all?query=build-596 -- This is an automated message from the Apache Git Service. To respo

[GitHub] [arrow] kszucs commented on pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
kszucs commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018465800 The M1 wheel builds are failing due to a different patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] ursabot edited a comment on pull request #12190: ARROW-15372: [C++][Gandiva] Gandiva now depends on boost/crc.hpp which is missing from the trimmed boost archive

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12190: URL: https://github.com/apache/arrow/pull/12190#issuecomment-1017006820 Benchmark runs are scheduled for baseline = a061c4cc07a047cf30b590091f35856f1bd3fa96 and contender = c5358787ee8f7b80f067292f49e5f032854041b9. c5358787ee8f7b80f067292f4

[GitHub] [arrow] AlenkaF commented on pull request #12178: ARROW-9664: [Python] Array/ChunkedArray.to_pandas do not support types_mapper keyword

2022-01-21 Thread GitBox
AlenkaF commented on pull request #12178: URL: https://github.com/apache/arrow/pull/12178#issuecomment-1018467474 @jorisvandenbossche Looking at the docstrings for the `types_mapper` I think item 1) from your list should test if `None` is added in the mapping function, then the default con

[GitHub] [arrow] kszucs closed pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
kszucs closed pull request #12220: URL: https://github.com/apache/arrow/pull/12220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] ursabot commented on pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
ursabot commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018471473 Benchmark runs are scheduled for baseline = a2fe24fe970bce082782225c16ff7ac45989884b and contender = c507b71ae0a7191cae0d23fa9d8a2b95a8d035b3. c507b71ae0a7191cae0d23fa9d8a2b95

[GitHub] [arrow] jorisvandenbossche commented on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-01-21 Thread GitBox
jorisvandenbossche commented on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1018472457 Can you print an example of what json file the scripts outputs eg for the 7.0 release? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow] kszucs closed pull request #12219: [Release] Verify 7.0.0 RC3 [WIP]

2022-01-21 Thread GitBox
kszucs closed pull request #12219: URL: https://github.com/apache/arrow/pull/12219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] kszucs commented on pull request #12219: [Release] Verify 7.0.0 RC3 [WIP]

2022-01-21 Thread GitBox
kszucs commented on pull request #12219: URL: https://github.com/apache/arrow/pull/12219#issuecomment-1018475559 Closing in favor of #1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] kszucs commented on pull request #12222: [Release] Verify 7.0.0 RC4 [WIP]

2022-01-21 Thread GitBox
kszucs commented on pull request #1: URL: https://github.com/apache/arrow/pull/1#issuecomment-1018476068 Crossbow checks https://github.com/ursacomputing/crossbow/branches/all?query=build-597 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] ursabot edited a comment on pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1018471473 Benchmark runs are scheduled for baseline = a2fe24fe970bce082782225c16ff7ac45989884b and contender = c507b71ae0a7191cae0d23fa9d8a2b95a8d035b3. c507b71ae0a7191cae0d23fa9

[GitHub] [arrow] thisisnic commented on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-01-21 Thread GitBox
thisisnic commented on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1018488508 > Can you print an example of what json file the scripts outputs eg for the 7.0 release? Certainly can. For the main docs, you manually add the dev version in the JS,

[GitHub] [arrow] ursabot edited a comment on pull request #9702: ARROW-11297: [C++][Python] Add ORC writer options

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #9702: URL: https://github.com/apache/arrow/pull/9702#issuecomment-1017587725 Benchmark runs are scheduled for baseline = df37b41d62c674543e2885a0f3d27219b5fedcf9 and contender = c39caedc2e9296fcb53d1c587708836ec6628ddb. c39caedc2e9296fcb53d1c58770

[GitHub] [arrow] jorisvandenbossche commented on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-01-21 Thread GitBox
jorisvandenbossche commented on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1018499699 > For the main docs, you manually add the dev version in the JS, right? Ah, no, it would actually be good this is handled by the script as well. I added it ma

[GitHub] [arrow] kszucs opened a new pull request #12223: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
kszucs opened a new pull request #12223: URL: https://github.com/apache/arrow/pull/12223 Forgot to update the JNI files in https://github.com/apache/arrow/pull/12153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] kszucs commented on pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
kszucs commented on pull request #12223: URL: https://github.com/apache/arrow/pull/12223#issuecomment-1018503152 Crossbow build https://github.com/ursacomputing/crossbow/branches/all?page=2&query=build-598 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] kszucs edited a comment on pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
kszucs edited a comment on pull request #12223: URL: https://github.com/apache/arrow/pull/12223#issuecomment-1018503152 Crossbow build https://github.com/ursacomputing/crossbow/branches/all?query=build-598 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] coryan commented on pull request #12188: ARROW-14385: [C++] update google-cloud-cpp

2022-01-21 Thread GitBox
coryan commented on pull request #12188: URL: https://github.com/apache/arrow/pull/12188#issuecomment-1018503782 Ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [arrow] lidavidm commented on pull request #12196: [RFC] ARROW-15282: [C++][FlightRPC] Support non-grpc data planes

2022-01-21 Thread GitBox
lidavidm commented on pull request #12196: URL: https://github.com/apache/arrow/pull/12196#issuecomment-1018506973 > My main concern of the data plane approach is that we have to build by ourselves the data transmission over raw data plane libraries. A robust, high performance communicatio

[GitHub] [arrow] vibhatha commented on pull request #12175: ARROW-15154: [R] Expose ReferencedBufferSize to R

2022-01-21 Thread GitBox
vibhatha commented on pull request #12175: URL: https://github.com/apache/arrow/pull/12175#issuecomment-1018508787 @thisisnic thank you very much for the review. I will update the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] kszucs commented on pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
kszucs commented on pull request #12223: URL: https://github.com/apache/arrow/pull/12223#issuecomment-1018512168 Resolved the linux build issue https://github.com/ursacomputing/crossbow/runs/4896845577?check_suite_focus=true -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kszucs closed pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
kszucs closed pull request #12223: URL: https://github.com/apache/arrow/pull/12223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] thisisnic commented on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-01-21 Thread GitBox
thisisnic commented on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1018512860 > > For the main docs, you manually add the dev version in the JS, right? > > Ah, no, it would actually be good this is handled by the script as well. I added it manual

[GitHub] [arrow] thisisnic edited a comment on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-01-21 Thread GitBox
thisisnic edited a comment on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1018512860 > > For the main docs, you manually add the dev version in the JS, right? > > Ah, no, it would actually be good this is handled by the script as well. I added it

[GitHub] [arrow] ursabot commented on pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
ursabot commented on pull request #12223: URL: https://github.com/apache/arrow/pull/12223#issuecomment-1018514721 Benchmark runs are scheduled for baseline = c507b71ae0a7191cae0d23fa9d8a2b95a8d035b3 and contender = 584b360f0f272791112490981518d4a989a93630. 584b360f0f272791112490981518d4a9

[GitHub] [arrow] kszucs closed pull request #12222: [Release] Verify 7.0.0 RC4 [WIP]

2022-01-21 Thread GitBox
kszucs closed pull request #1: URL: https://github.com/apache/arrow/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] kszucs commented on pull request #12222: [Release] Verify 7.0.0 RC4 [WIP]

2022-01-21 Thread GitBox
kszucs commented on pull request #1: URL: https://github.com/apache/arrow/pull/1#issuecomment-1018516002 Closing in favor of #12224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow] github-actions[bot] commented on pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
github-actions[bot] commented on pull request #12223: URL: https://github.com/apache/arrow/pull/12223#issuecomment-1018516850 https://issues.apache.org/jira/browse/ARROW-15404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] kszucs commented on pull request #12224: [Release] Verify 7.0.0 RC5 [WIP]

2022-01-21 Thread GitBox
kszucs commented on pull request #12224: URL: https://github.com/apache/arrow/pull/12224#issuecomment-1018518446 @github-actions crossbow submit --group verify-rc-source --param release=7.0.0 --param rc=5 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow-rs] tustvold commented on pull request #1180: Preserve dictionary encoding when decoding parquet into Arrow arrays (#171)

2022-01-21 Thread GitBox
tustvold commented on pull request #1180: URL: https://github.com/apache/arrow-rs/pull/1180#issuecomment-1018518863 Added some benchmarks ``` arrow_array_reader/read StringDictionary, dictionary encoded, mandatory, no NULLs - old

[GitHub] [arrow] jorisvandenbossche commented on pull request #12212: ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

2022-01-21 Thread GitBox
jorisvandenbossche commented on pull request #12212: URL: https://github.com/apache/arrow/pull/12212#issuecomment-1018519800 Yes, that looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1180: Preserve dictionary encoding when decoding parquet into Arrow arrays (#171)

2022-01-21 Thread GitBox
tustvold commented on a change in pull request #1180: URL: https://github.com/apache/arrow-rs/pull/1180#discussion_r789670379 ## File path: parquet/src/arrow/array_reader/byte_array_dictionary.rs ## @@ -341,7 +341,9 @@ where Some(keys) => {

[GitHub] [arrow] lidavidm commented on a change in pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-01-21 Thread GitBox
lidavidm commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r789672276 ## File path: format/FlightSql.proto ## @@ -867,6 +867,153 @@ enum SqlSupportsConvert { SQL_CONVERT_VARCHAR = 19; } +enum SqlDatetimeSubcode { + S

[GitHub] [arrow] ursabot edited a comment on pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12223: URL: https://github.com/apache/arrow/pull/12223#issuecomment-1018514721 Benchmark runs are scheduled for baseline = c507b71ae0a7191cae0d23fa9d8a2b95a8d035b3 and contender = 584b360f0f272791112490981518d4a989a93630. 584b360f0f272791112490981

[GitHub] [arrow] lidavidm commented on pull request #11982: ARROW-15313: [C++][Java][FlightRPC] Implement type info method to flight-sql

2022-01-21 Thread GitBox
lidavidm commented on pull request #11982: URL: https://github.com/apache/arrow/pull/11982#issuecomment-1018529907 While I'm trying to resolve these last protocol things I'll also let the ML know and see if anyone else wants to take a look here, sorry for the back-and-forth -- This is a

[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2022-01-21 Thread GitBox
rok commented on pull request #11889: URL: https://github.com/apache/arrow/pull/11889#issuecomment-1018532256 @github-actions crossbow submit -g nightly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] cyb70289 commented on pull request #12196: [RFC] ARROW-15282: [C++][FlightRPC] Support non-grpc data planes

2022-01-21 Thread GitBox
cyb70289 commented on pull request #12196: URL: https://github.com/apache/arrow/pull/12196#issuecomment-1018535080 > How were the tests run? Assume the [flight benchmark](https://github.com/cyb70289/arrow/blob/flight-data-plane/cpp/src/arrow/flight/flight_benchmark.cc) as described at htt

[GitHub] [arrow] rok commented on pull request #12218: ARROW-14816: [R] Implement bindings for lubridate::mday

2022-01-21 Thread GitBox
rok commented on pull request #12218: URL: https://github.com/apache/arrow/pull/12218#issuecomment-1018552687 Would this be a candidate for another c++ kernel? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [arrow-datafusion] alamb commented on pull request #1625: fix dependabot

2022-01-21 Thread GitBox
alamb commented on pull request #1625: URL: https://github.com/apache/arrow-datafusion/pull/1625#issuecomment-1018556330 Thanks @xudong963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow-datafusion] alamb merged pull request #1625: fix dependabot

2022-01-21 Thread GitBox
alamb merged pull request #1625: URL: https://github.com/apache/arrow-datafusion/pull/1625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1475: Use`eq_dyn`, `neq_dyn`, `lt_dyn`, `lt_eq_dyn`, `gt_dyn`, `gt_eq_dyn` kernels from arrow

2022-01-21 Thread GitBox
alamb commented on pull request #1475: URL: https://github.com/apache/arrow-datafusion/pull/1475#issuecomment-1018556979 Switching back to draft until the underlying arrow kernel support is done -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1626: Update etcd-client requirement from 0.7 to 0.8

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #1626: URL: https://github.com/apache/arrow-datafusion/pull/1626 Updates the requirements on [etcd-client](https://github.com/etcdv3/etcd-client) to permit the latest version. Release notes Sourced from https://github.com/etcdv3/etcd-clie

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1627: Update pyo3 requirement from 0.14 to 0.15

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #1627: URL: https://github.com/apache/arrow-datafusion/pull/1627 Updates the requirements on [pyo3](https://github.com/pyo3/pyo3) to permit the latest version. Release notes Sourced from https://github.com/pyo3/pyo3/releases";>pyo3's rele

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1628: Update md-5 requirement from ^0.9.1 to ^0.10.0

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #1628: URL: https://github.com/apache/arrow-datafusion/pull/1628 Updates the requirements on [md-5](https://github.com/RustCrypto/hashes) to permit the latest version. Commits https://github.com/RustCrypto/hashes/commit/75298d36b940065

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1629: Update sha2 requirement from ^0.9.1 to ^0.10.1

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #1629: URL: https://github.com/apache/arrow-datafusion/pull/1629 Updates the requirements on [sha2](https://github.com/RustCrypto/hashes) to permit the latest version. Commits https://github.com/RustCrypto/hashes/commit/4c1d9dab614af86

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1631: Update hashbrown requirement from 0.11 to 0.12

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #1631: URL: https://github.com/apache/arrow-datafusion/pull/1631 Updates the requirements on [hashbrown](https://github.com/rust-lang/hashbrown) to permit the latest version. Changelog Sourced from https://github.com/rust-lang/hashbrown/b

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1630: Update blake2 requirement from ^0.9.2 to ^0.10.2

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #1630: URL: https://github.com/apache/arrow-datafusion/pull/1630 Updates the requirements on [blake2](https://github.com/RustCrypto/hashes) to permit the latest version. Commits https://github.com/RustCrypto/hashes/commit/b13d7726f3da6

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1632: Update clap requirement from 2.33 to 3.0

2022-01-21 Thread GitBox
dependabot[bot] opened a new pull request #1632: URL: https://github.com/apache/arrow-datafusion/pull/1632 Updates the requirements on [clap](https://github.com/clap-rs/clap) to permit the latest version. Release notes Sourced from https://github.com/clap-rs/clap/releases";>clap's

[GitHub] [arrow] github-actions[bot] commented on pull request #12224: [Release] Verify 7.0.0 RC5 [WIP]

2022-01-21 Thread GitBox
github-actions[bot] commented on pull request #12224: URL: https://github.com/apache/arrow/pull/12224#issuecomment-1018561771 Revision: b3703086bbb0d7ea18b474b80f69fec5b078639a Submitted crossbow builds: [ursacomputing/crossbow @ actions-1421](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1596: Consolidate sort and external_sort

2022-01-21 Thread GitBox
alamb commented on a change in pull request #1596: URL: https://github.com/apache/arrow-datafusion/pull/1596#discussion_r789710587 ## File path: datafusion/src/physical_plan/sorts/sort_preserving_merge.rs ## @@ -304,6 +303,9 @@ pub(crate) struct SortPreservingMergeStream {

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1596: Consolidate sort and external_sort

2022-01-21 Thread GitBox
yjshen commented on a change in pull request #1596: URL: https://github.com/apache/arrow-datafusion/pull/1596#discussion_r789714537 ## File path: datafusion/src/physical_plan/sorts/sort_preserving_merge.rs ## @@ -304,6 +303,9 @@ pub(crate) struct SortPreservingMergeStream {

[GitHub] [arrow] lidavidm commented on a change in pull request #12136: ARROW-14092: [C++] subtract(date, duration) -> timestamp kernel

2022-01-21 Thread GitBox
lidavidm commented on a change in pull request #12136: URL: https://github.com/apache/arrow/pull/12136#discussion_r789714967 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -1693,7 +1692,9 @@ struct ArithmeticFunction : ScalarFunction { if (values->s

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1625: fix dependabot

2022-01-21 Thread GitBox
xudong963 commented on pull request #1625: URL: https://github.com/apache/arrow-datafusion/pull/1625#issuecomment-1018568735 It works😹 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow-datafusion] alamb closed issue #1571: Consolidate the `SortExec` code (so there is only a single sort operator that does in memory sorting if it has enough memory budget but then spill

2022-01-21 Thread GitBox
alamb closed issue #1571: URL: https://github.com/apache/arrow-datafusion/issues/1571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb merged pull request #1596: Consolidate sort and external_sort

2022-01-21 Thread GitBox
alamb merged pull request #1596: URL: https://github.com/apache/arrow-datafusion/pull/1596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1596: Consolidate sort and external_sort

2022-01-21 Thread GitBox
alamb commented on pull request #1596: URL: https://github.com/apache/arrow-datafusion/pull/1596#issuecomment-1018571531 FYI @houqp @Dandandan @liukun4515 @andygrove -- while @yjshen has done performance analysis and this change should not affect the performance of queries that stay al

[GitHub] [arrow-datafusion] alamb commented on pull request #1596: Consolidate sort and external_sort

2022-01-21 Thread GitBox
alamb commented on pull request #1596: URL: https://github.com/apache/arrow-datafusion/pull/1596#issuecomment-1018572115 Epic work @yjshen -- thanks again for all the work and thank you @tustvold for the help reviewing -- This is an automated message from the Apache Git Service. To re

[GitHub] [arrow-datafusion] alamb commented on issue #1573: SQL level tests for when sorting exceeded available memory and had to spill to disk

2022-01-21 Thread GitBox
alamb commented on issue #1573: URL: https://github.com/apache/arrow-datafusion/issues/1573#issuecomment-1018572979 > However, since spill metrics are not exposed by sort yet, the current test cannot assert spill count > 0. Do you think it's appropriate if I add spill count as well as spi

[GitHub] [arrow] rok commented on a change in pull request #12136: ARROW-14092: [C++] subtract(date, duration) -> timestamp kernel

2022-01-21 Thread GitBox
rok commented on a change in pull request #12136: URL: https://github.com/apache/arrow/pull/12136#discussion_r789718949 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -1693,7 +1692,9 @@ struct ArithmeticFunction : ScalarFunction { if (values->size()

[GitHub] [arrow] lidavidm commented on a change in pull request #12136: ARROW-14092: [C++] subtract(date, duration) -> timestamp kernel

2022-01-21 Thread GitBox
lidavidm commented on a change in pull request #12136: URL: https://github.com/apache/arrow/pull/12136#discussion_r789719762 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -1693,7 +1692,9 @@ struct ArithmeticFunction : ScalarFunction { if (values->s

[GitHub] [arrow] vibhatha commented on pull request #12033: ARROW-15091: [C++][Doc] Document nodes in C++ streaming execution engine

2022-01-21 Thread GitBox
vibhatha commented on pull request #12033: URL: https://github.com/apache/arrow/pull/12033#issuecomment-1018576644 @lidavidm added some modifications based on the review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] github-actions[bot] commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2022-01-21 Thread GitBox
github-actions[bot] commented on pull request #11889: URL: https://github.com/apache/arrow/pull/11889#issuecomment-1018577499 Revision: aed4157ff68fcde5f16a472cd689640dc624f588 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1422](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-datafusion] alamb commented on pull request #1627: Update pyo3 requirement from 0.14 to 0.15

2022-01-21 Thread GitBox
alamb commented on pull request #1627: URL: https://github.com/apache/arrow-datafusion/pull/1627#issuecomment-1018577560 It's working @xudong963 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow] ursabot edited a comment on pull request #12199: ARROW-15380: [Python][Release] NumPy ABI incompatibility during verification

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12199: URL: https://github.com/apache/arrow/pull/12199#issuecomment-1017419639 Benchmark runs are scheduled for baseline = c5358787ee8f7b80f067292f49e5f032854041b9 and contender = 190dba53c1d741036c02755be25f67b50d384e96. 190dba53c1d741036c02755be

[GitHub] [arrow-datafusion] alamb opened a new issue #1633: (Left Over?) pyarrow does not compile

2022-01-21 Thread GitBox
alamb opened a new issue #1633: URL: https://github.com/apache/arrow-datafusion/issues/1633 **Describe the bug** I am not sure this is a bug but I was surprised that datafusion still had an optional py03 dependency: https://github.com/apache/arrow-datafusion/pull/1627 There are so

[GitHub] [arrow] ursabot edited a comment on pull request #12179: ARROW-14609 [R] left_join by argument error message mismatch

2022-01-21 Thread GitBox
ursabot edited a comment on pull request #12179: URL: https://github.com/apache/arrow/pull/12179#issuecomment-1017699140 Benchmark runs are scheduled for baseline = c39caedc2e9296fcb53d1c587708836ec6628ddb and contender = b1b8728ee692359f6990ef8d188c88f482f632b6. b1b8728ee692359f6990ef8d1

[GitHub] [arrow-datafusion] alamb opened a new pull request #1634: Remove `pyarrow` module

2022-01-21 Thread GitBox
alamb opened a new pull request #1634: URL: https://github.com/apache/arrow-datafusion/pull/1634 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/1633 # Rationale for this change See https://github.com/apache/arrow-datafusion/issues

  1   2   3   >