[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1639: fix a cte block with same name for many times

2022-01-22 Thread GitBox
xudong963 opened a new pull request #1639: URL: https://github.com/apache/arrow-datafusion/pull/1639 # Which issue does this PR close? Fix a cte block with same name for many times # Rationale for this change # What changes are included in this PR?

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1639: fix a cte block with same name for many times

2022-01-22 Thread GitBox
xudong963 commented on pull request #1639: URL: https://github.com/apache/arrow-datafusion/pull/1639#issuecomment-1019091358 It is a unreasonable behavior that a single cte block with the same name for many times. But currently, datafusion doesn't process it correctly. ```sql //

[GitHub] [arrow-datafusion] liukun4515 opened a new pull request #1640: support hash decimal array and group by

2022-01-22 Thread GitBox
liukun4515 opened a new pull request #1640: URL: https://github.com/apache/arrow-datafusion/pull/1640 # Which issue does this PR close? Closes #1535 # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

[GitHub] [arrow-datafusion] yjshen opened a new pull request #1641: Add `spill_count` and `spilled_bytes` into `BaselineMetrics`, test sort with spill

2022-01-22 Thread GitBox
yjshen opened a new pull request #1641: URL: https://github.com/apache/arrow-datafusion/pull/1641 # Which issue does this PR close? Closes #1611 and #1573 . # Rationale for this change Report `spill_count` and `spilled_bytes` in `BaselineMetrics` since these might

[GitHub] [arrow-datafusion] yjshen commented on pull request #1641: Add `spill_count` and `spilled_bytes` to `BaselineMetrics`, test sort with spill

2022-01-22 Thread GitBox
yjshen commented on pull request #1641: URL: https://github.com/apache/arrow-datafusion/pull/1641#issuecomment-1019113932 Hi @alamb, could you please help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1641: Add `spill_count` and `spilled_bytes` to `BaselineMetrics`, test sort with spill

2022-01-22 Thread GitBox
liukun4515 commented on a change in pull request #1641: URL: https://github.com/apache/arrow-datafusion/pull/1641#discussion_r790122013 ## File path: datafusion/src/physical_plan/metrics/value.rs ## @@ -401,10 +413,12 @@ impl MetricValue { match self { Sel

[GitHub] [arrow] ursabot edited a comment on pull request #12223: ARROW-15404: [Java][Packaging] Use bundled ORC for building java JNI jars

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12223: URL: https://github.com/apache/arrow/pull/12223#issuecomment-1018514721 Benchmark runs are scheduled for baseline = c507b71ae0a7191cae0d23fa9d8a2b95a8d035b3 and contender = 584b360f0f272791112490981518d4a989a93630. 584b360f0f272791112490981

[GitHub] [arrow] ursabot edited a comment on pull request #9702: ARROW-11297: [C++][Python] Add ORC writer options

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #9702: URL: https://github.com/apache/arrow/pull/9702#issuecomment-1017587725 Benchmark runs are scheduled for baseline = df37b41d62c674543e2885a0f3d27219b5fedcf9 and contender = c39caedc2e9296fcb53d1c587708836ec6628ddb. c39caedc2e9296fcb53d1c58770

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1552: enhance arithmetic operation for array with scalar

2022-01-22 Thread GitBox
liukun4515 commented on pull request #1552: URL: https://github.com/apache/arrow-datafusion/pull/1552#issuecomment-1019132928 After the arrow-rs 8.0.0 are released, we convert this reviewable -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] kszucs commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
kszucs commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019139161 @github-actions crossbow submit -g wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow] github-actions[bot] commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
github-actions[bot] commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019140114 Revision: 48c0c87302d4c78e359824cf9b76cf2a8dad88b2 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1427](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1640: support hash decimal array and group by

2022-01-22 Thread GitBox
liukun4515 commented on pull request #1640: URL: https://github.com/apache/arrow-datafusion/pull/1640#issuecomment-1019140756 I will add more integration tests after the arrow-rs 8.0.0 is released. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [arrow] kszucs commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
kszucs commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019155690 Need to rebuild the windows images. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] lianghanzhen closed pull request #12221: [Doc]: Fix typo

2022-01-22 Thread GitBox
lianghanzhen closed pull request #12221: URL: https://github.com/apache/arrow/pull/12221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-un

[GitHub] [arrow] ursabot edited a comment on pull request #12218: ARROW-14816: [R] Implement bindings for lubridate::mday

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12218: URL: https://github.com/apache/arrow/pull/12218#issuecomment-1018683263 Benchmark runs are scheduled for baseline = 584b360f0f272791112490981518d4a989a93630 and contender = 3fa2d2171a11e1823036a842ec99fd010014eb82. 3fa2d2171a11e1823036a842e

[GitHub] [arrow-datafusion] alamb opened a new issue #1642: Allow use of `?` to return `DataFusionError`s in methods that return`ArrowErrors`

2022-01-22 Thread GitBox
alamb opened a new issue #1642: URL: https://github.com/apache/arrow-datafusion/issues/1642 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Improve DataFusion error conversions Now that @matthewmturner made a DataFusionErr

[GitHub] [arrow-datafusion] alamb opened a new pull request #1643: Add `DataFusionError` -> `ArrowError` conversion

2022-01-22 Thread GitBox
alamb opened a new pull request #1643: URL: https://github.com/apache/arrow-datafusion/pull/1643 # Which issue does this PR close? Resolves: https://github.com/apache/arrow-datafusion/issues/1642 # Rationale for this change Please see https://github.com/apache/arrow-dat

[GitHub] [arrow-datafusion] alamb opened a new issue #1644: Remove non idomatic DataFusionError::into_arrow_external_error in favor of `From` conversion

2022-01-22 Thread GitBox
alamb opened a new issue #1644: URL: https://github.com/apache/arrow-datafusion/issues/1644 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** The way to convert `DataFusionError` into an `ArrowError` is confusing for Rust programme

[GitHub] [arrow-datafusion] alamb opened a new pull request #1645: Remove non idiomatic `DataFusionError::into_arrow_external_error` in favor of From conversion

2022-01-22 Thread GitBox
alamb opened a new pull request #1645: URL: https://github.com/apache/arrow-datafusion/pull/1645 Builds on https://github.com/apache/arrow-datafusion/pull/1643, so draft until that is merged # Which issue does this PR close? closes https://github.com/apache/arrow-datafusion/issues

[GitHub] [arrow-datafusion] alamb opened a new issue #1646: Consolidate Schema and RecordBatch projection #1638

2022-01-22 Thread GitBox
alamb opened a new issue #1646: URL: https://github.com/apache/arrow-datafusion/issues/1646 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** @hntd187 added `RecordBatch::project` and `Schema::project` in https://github.com/apache

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1645: Remove non idiomatic `DataFusionError::into_arrow_external_error` in favor of From conversion

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1645: URL: https://github.com/apache/arrow-datafusion/pull/1645#discussion_r790136002 ## File path: datafusion/src/physical_plan/cross_join.rs ## @@ -331,8 +331,7 @@ fn build_batch( let scalar = ScalarValue::try_from_arr

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1643: Add `DataFusionError` -> `ArrowError` conversion

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1643: URL: https://github.com/apache/arrow-datafusion/pull/1643#discussion_r790136063 ## File path: datafusion/src/error.rs ## @@ -74,6 +74,8 @@ pub enum DataFusionError { impl DataFusionError { /// Wraps this [DataFusionErro

[GitHub] [arrow-datafusion] alamb merged pull request #1624: Optimize `SortPreservingMergeStream` to avoid `SortKeyCursor` sharing

2022-01-22 Thread GitBox
alamb merged pull request #1624: URL: https://github.com/apache/arrow-datafusion/pull/1624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1624: Optimize `SortPreservingMergeStream` to avoid `SortKeyCursor` sharing

2022-01-22 Thread GitBox
alamb commented on pull request #1624: URL: https://github.com/apache/arrow-datafusion/pull/1624#issuecomment-1019221306 Thanks again @yjshen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow-datafusion] alamb commented on pull request #1621: feat: Support Substring(str [from int] [for int])

2022-01-22 Thread GitBox
alamb commented on pull request #1621: URL: https://github.com/apache/arrow-datafusion/pull/1621#issuecomment-1019222596 @ovr would you like to address the discrepancies that @xudong963 found with postgres? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow-datafusion] alamb commented on pull request #1645: Remove non idiomatic `DataFusionError::into_arrow_external_error` in favor of From conversion

2022-01-22 Thread GitBox
alamb commented on pull request #1645: URL: https://github.com/apache/arrow-datafusion/pull/1645#issuecomment-1019225299 We can probably remove any instances of code like ``` .map_err(DataFusionError::ArrowError) ``` as well 🤔 -- This is an automa

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1622: Handle merging of evolved schemas in ParquetExec

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1622: URL: https://github.com/apache/arrow-datafusion/pull/1622#discussion_r790137229 ## File path: datafusion/src/physical_plan/file_format/parquet.rs ## @@ -457,22 +518,313 @@ fn read_partition( #[cfg(test)] mod tests { -us

[GitHub] [arrow-datafusion] alamb commented on pull request #1627: Update pyo3 requirement from 0.14 to 0.15

2022-01-22 Thread GitBox
alamb commented on pull request #1627: URL: https://github.com/apache/arrow-datafusion/pull/1627#issuecomment-1019233981 Seems like a good change to me 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion] alamb merged pull request #1626: Update etcd-client requirement from 0.7 to 0.8

2022-01-22 Thread GitBox
alamb merged pull request #1626: URL: https://github.com/apache/arrow-datafusion/pull/1626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb merged pull request #1627: Update pyo3 requirement from 0.14 to 0.15

2022-01-22 Thread GitBox
alamb merged pull request #1627: URL: https://github.com/apache/arrow-datafusion/pull/1627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1628: Update md-5 requirement from ^0.9.1 to ^0.10.0

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1628: URL: https://github.com/apache/arrow-datafusion/pull/1628#discussion_r790138080 ## File path: datafusion/Cargo.toml ## @@ -64,7 +64,7 @@ pin-project-lite= "^0.2.7" tokio = { version = "1.0", features = ["macros", "rt", "rt-mul

[GitHub] [arrow-datafusion] alamb commented on pull request #1631: Update hashbrown requirement from 0.11 to 0.12

2022-01-22 Thread GitBox
alamb commented on pull request #1631: URL: https://github.com/apache/arrow-datafusion/pull/1631#issuecomment-1019235635 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-datafusion] alamb merged pull request #1631: Update hashbrown requirement from 0.11 to 0.12

2022-01-22 Thread GitBox
alamb merged pull request #1631: URL: https://github.com/apache/arrow-datafusion/pull/1631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb closed issue #1535: support hasher for decimal type

2022-01-22 Thread GitBox
alamb closed issue #1535: URL: https://github.com/apache/arrow-datafusion/issues/1535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb merged pull request #1640: support hash decimal array and group by

2022-01-22 Thread GitBox
alamb merged pull request #1640: URL: https://github.com/apache/arrow-datafusion/pull/1640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1628: Update md-5 requirement from ^0.9.1 to ^0.10.0

2022-01-22 Thread GitBox
xudong963 commented on a change in pull request #1628: URL: https://github.com/apache/arrow-datafusion/pull/1628#discussion_r790138838 ## File path: datafusion/Cargo.toml ## @@ -64,7 +64,7 @@ pin-project-lite= "^0.2.7" tokio = { version = "1.0", features = ["macros", "rt", "rt

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1639: fix a cte block with same name for many times

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1639: URL: https://github.com/apache/arrow-datafusion/pull/1639#discussion_r790139091 ## File path: datafusion/src/sql/planner.rs ## @@ -213,9 +213,19 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { ) -> Result { let

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1639: fix a cte block with same name for many times

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1639: URL: https://github.com/apache/arrow-datafusion/pull/1639#discussion_r790139091 ## File path: datafusion/src/sql/planner.rs ## @@ -213,9 +213,19 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { ) -> Result { let

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1639: fix a cte block with same name for many times

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1639: URL: https://github.com/apache/arrow-datafusion/pull/1639#discussion_r790139091 ## File path: datafusion/src/sql/planner.rs ## @@ -213,9 +213,19 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { ) -> Result { let

[GitHub] [arrow] ursabot edited a comment on pull request #12179: ARROW-14609 [R] left_join by argument error message mismatch

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12179: URL: https://github.com/apache/arrow/pull/12179#issuecomment-1017699140 Benchmark runs are scheduled for baseline = c39caedc2e9296fcb53d1c587708836ec6628ddb and contender = b1b8728ee692359f6990ef8d188c88f482f632b6. b1b8728ee692359f6990ef8d1

[GitHub] [arrow-datafusion] alamb merged pull request #1641: Add `spill_count` and `spilled_bytes` to `BaselineMetrics`, test sort with spill

2022-01-22 Thread GitBox
alamb merged pull request #1641: URL: https://github.com/apache/arrow-datafusion/pull/1641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb closed issue #1611: Report `spill_count` as well as `spill_bytes` in sort metrics

2022-01-22 Thread GitBox
alamb closed issue #1611: URL: https://github.com/apache/arrow-datafusion/issues/1611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb commented on pull request #1641: Add `spill_count` and `spilled_bytes` to `BaselineMetrics`, test sort with spill

2022-01-22 Thread GitBox
alamb commented on pull request #1641: URL: https://github.com/apache/arrow-datafusion/pull/1641#issuecomment-1019245100 Thank you @yjshen and @liukun4515 for the review ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1640: support hash decimal array and group by

2022-01-22 Thread GitBox
liukun4515 commented on pull request #1640: URL: https://github.com/apache/arrow-datafusion/pull/1640#issuecomment-1019247862 > LGTM 👍 Thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] ursabot edited a comment on pull request #12175: ARROW-15154: [R] Expose ReferencedBufferSize to R

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12175: URL: https://github.com/apache/arrow/pull/12175#issuecomment-1018683282 Benchmark runs are scheduled for baseline = 3fa2d2171a11e1823036a842ec99fd010014eb82 and contender = e291d0f408df588048b6971819fc4e65b0093154. e291d0f408df588048b697181

[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1647: update md-5, sha2, blake2

2022-01-22 Thread GitBox
xudong963 opened a new pull request #1647: URL: https://github.com/apache/arrow-datafusion/pull/1647 # Which issue does this PR close? Closes #1630 #1629 #1628 # Rationale for this change https://docs.rs/blake2/latest/blake2/index.html # What changes are

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1216: Update DECIMAL_RE to allow scientific notation in auto inferred schemas

2022-01-22 Thread GitBox
codecov-commenter edited a comment on pull request #1216: URL: https://github.com/apache/arrow-rs/pull/1216#issuecomment-1018769785 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1639: fix a cte block with same name for many times

2022-01-22 Thread GitBox
xudong963 commented on a change in pull request #1639: URL: https://github.com/apache/arrow-datafusion/pull/1639#discussion_r790145841 ## File path: datafusion/src/sql/planner.rs ## @@ -213,9 +213,19 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { ) -> Result {

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1639: fix a cte block with same name for many times

2022-01-22 Thread GitBox
xudong963 commented on pull request #1639: URL: https://github.com/apache/arrow-datafusion/pull/1639#issuecomment-1019277489 Fixed, plz take another look when you have time @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [arrow-datafusion] thinkharderdev commented on a change in pull request #1622: Handle merging of evolved schemas in ParquetExec

2022-01-22 Thread GitBox
thinkharderdev commented on a change in pull request #1622: URL: https://github.com/apache/arrow-datafusion/pull/1622#discussion_r790151401 ## File path: datafusion/src/physical_plan/file_format/parquet.rs ## @@ -457,22 +518,313 @@ fn read_partition( #[cfg(test)] mod tests

[GitHub] [arrow-rs] jhorstmann opened a new pull request #1221: Remove explicit simd arithmetic kernels except for division/modulo

2022-01-22 Thread GitBox
jhorstmann opened a new pull request #1221: URL: https://github.com/apache/arrow-rs/pull/1221 # Which issue does this PR close? Removes explicit simd arithmetic kernels, except for division/modulo, as compiler autovectorization actually generates better code. Also adds a new

[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #1221: Remove explicit simd arithmetic kernels except for division/modulo

2022-01-22 Thread GitBox
jhorstmann commented on a change in pull request #1221: URL: https://github.com/apache/arrow-rs/pull/1221#discussion_r790152266 ## File path: arrow/src/buffer/immutable.rs ## @@ -153,6 +153,7 @@ impl Buffer { /// /// Note that this should be used cautiously, and the r

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1221: Remove explicit simd arithmetic kernels except for division/modulo

2022-01-22 Thread GitBox
codecov-commenter commented on pull request #1221: URL: https://github.com/apache/arrow-rs/pull/1221#issuecomment-1019292094 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0

2022-01-22 Thread GitBox
xudong963 commented on a change in pull request #1632: URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790154552 ## File path: datafusion-cli/Cargo.toml ## @@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"; rust-version = "1.58"

[GitHub] [arrow] github-actions[bot] commented on pull request #12229: ARROW-15414: [java] RangeEqualsVisitor does not work for BitVector

2022-01-22 Thread GitBox
github-actions[bot] commented on pull request #12229: URL: https://github.com/apache/arrow/pull/12229#issuecomment-1019298378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] wzx140 commented on pull request #12229: ARROW-15414: [java] RangeEqualsVisitor does not work for BitVector

2022-01-22 Thread GitBox
wzx140 commented on pull request #12229: URL: https://github.com/apache/arrow/pull/12229#issuecomment-1019300112 Please see: https://issues.apache.org/jira/browse/ARROW-15414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] ursabot edited a comment on pull request #12092: ARROW-12735: [C++] Write GDB plugin

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12092: URL: https://github.com/apache/arrow/pull/12092#issuecomment-1017765706 Benchmark runs are scheduled for baseline = b1b8728ee692359f6990ef8d188c88f482f632b6 and contender = a3efe72f99b1b9f23b1d11afc648f4306d32e330. a3efe72f99b1b9f23b1d11afc

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1221: Remove explicit simd arithmetic kernels except for division/modulo

2022-01-22 Thread GitBox
codecov-commenter edited a comment on pull request #1221: URL: https://github.com/apache/arrow-rs/pull/1221#issuecomment-1019292094 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow-julia] NHDaly commented on pull request #267: Proposal: change `@scopedenum` to make modules to avoid type piracy

2022-01-22 Thread GitBox
NHDaly commented on pull request #267: URL: https://github.com/apache/arrow-julia/pull/267#issuecomment-1019308997 Hooray. Thanks! How will the release process work under the new setup? Should I have bumped a version number in my PR? Or will you do that separately afterwards? -- T

[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2022-01-22 Thread GitBox
rok commented on pull request #11889: URL: https://github.com/apache/arrow/pull/11889#issuecomment-1019334362 @kou could you please review if this change makes sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-julia] ericphanson commented on pull request #278: Create CONTRIBUTING.md

2022-01-22 Thread GitBox
ericphanson commented on pull request #278: URL: https://github.com/apache/arrow-julia/pull/278#issuecomment-1019337802 It would be great if this could cover the answer to https://github.com/apache/arrow-julia/pull/267#issuecomment-1019308997 - often when folks contribute a fix or feature

[GitHub] [arrow] dongjoon-hyun commented on pull request #12220: ARROW-15403: [Python][Packaging] Use bundled ORC to build the python wheels

2022-01-22 Thread GitBox
dongjoon-hyun commented on pull request #12220: URL: https://github.com/apache/arrow/pull/12220#issuecomment-1019343606 Thank you for pinging me, @kszucs . Yes, I remember your email last year. - https://lists.apache.org/thread/l3wjm2r6l57pz1q3o7wx57zvgzh7nxgl The ORC library i

[GitHub] [arrow] ursabot edited a comment on pull request #12204: ARROW-15388: [C++] Avoid including absl from flatbuffers

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12204: URL: https://github.com/apache/arrow/pull/12204#issuecomment-1017865670 Benchmark runs are scheduled for baseline = a3efe72f99b1b9f23b1d11afc648f4306d32e330 and contender = 22dc537e581b385b53ce579a03786a2db0bd4487. 22dc537e581b385b53ce579a0

[GitHub] [arrow] wjones127 opened a new pull request #12230: ARROW-15415: [C++] Fixes for Windows Debug build

2022-01-22 Thread GitBox
wjones127 opened a new pull request #12230: URL: https://github.com/apache/arrow/pull/12230 This fixes various issues I encountered while trying to create a debug build on Windows using MSVC and vcpkg: * Python debug and release libraries are passed, but our Cmake scripts only expe

[GitHub] [arrow] github-actions[bot] commented on pull request #12230: ARROW-15415: [C++] Fixes for Windows Debug build

2022-01-22 Thread GitBox
github-actions[bot] commented on pull request #12230: URL: https://github.com/apache/arrow/pull/12230#issuecomment-1019346664 https://issues.apache.org/jira/browse/ARROW-15415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] wjones127 commented on a change in pull request #12230: ARROW-15415: [C++] Fixes for Windows Debug build

2022-01-22 Thread GitBox
wjones127 commented on a change in pull request #12230: URL: https://github.com/apache/arrow/pull/12230#discussion_r790178468 ## File path: cpp/cmake_modules/BuildUtils.cmake ## @@ -370,7 +370,7 @@ function(ADD_ARROW_LIB LIB_NAME) target_link_libraries(${LIB_NAME}_shared

[GitHub] [arrow] kszucs commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
kszucs commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019346895 @github-actions crossbow submit wheel-manylinux* wheel-macos* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] github-actions[bot] commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
github-actions[bot] commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019347019 Revision: c41df578108c99ad88fbf03782502ec8d60fb572 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1428](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1632: Update clap requirement from 2.33 to 3.0

2022-01-22 Thread GitBox
houqp commented on a change in pull request #1632: URL: https://github.com/apache/arrow-datafusion/pull/1632#discussion_r790179174 ## File path: datafusion-cli/Cargo.toml ## @@ -27,7 +27,7 @@ repository = "https://github.com/apache/arrow-datafusion"; rust-version = "1.58" [

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1643: Add `DataFusionError` -> `ArrowError` conversion

2022-01-22 Thread GitBox
houqp commented on a change in pull request #1643: URL: https://github.com/apache/arrow-datafusion/pull/1643#discussion_r790179772 ## File path: datafusion/src/error.rs ## @@ -74,6 +74,8 @@ pub enum DataFusionError { impl DataFusionError { /// Wraps this [DataFusionErro

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1643: Add `DataFusionError` -> `ArrowError` conversion

2022-01-22 Thread GitBox
alamb commented on a change in pull request #1643: URL: https://github.com/apache/arrow-datafusion/pull/1643#discussion_r790180757 ## File path: datafusion/src/error.rs ## @@ -74,6 +74,8 @@ pub enum DataFusionError { impl DataFusionError { /// Wraps this [DataFusionErro

[GitHub] [arrow-datafusion] alamb merged pull request #1643: Add `DataFusionError` -> `ArrowError` conversion

2022-01-22 Thread GitBox
alamb merged pull request #1643: URL: https://github.com/apache/arrow-datafusion/pull/1643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb closed issue #1642: Allow use of `?` to return `DataFusionError`s in methods that return`ArrowErrors`

2022-01-22 Thread GitBox
alamb closed issue #1642: URL: https://github.com/apache/arrow-datafusion/issues/1642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-rs] alamb merged pull request #1216: Update DECIMAL_RE to allow scientific notation in auto inferred schemas

2022-01-22 Thread GitBox
alamb merged pull request #1216: URL: https://github.com/apache/arrow-rs/pull/1216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-rs] alamb closed issue #1215: Extend schema inference to allow scientific notation for floating point types

2022-01-22 Thread GitBox
alamb closed issue #1215: URL: https://github.com/apache/arrow-rs/issues/1215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-rs] alamb commented on pull request #1216: Update DECIMAL_RE to allow scientific notation in auto inferred schemas

2022-01-22 Thread GitBox
alamb commented on pull request #1216: URL: https://github.com/apache/arrow-rs/pull/1216#issuecomment-1019351276 Thanks @pjmore and @liukun4515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] ursabot edited a comment on pull request #12213: ARROW-15399: [Release][JS] Increase minimum NodeJS version to 16

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12213: URL: https://github.com/apache/arrow/pull/12213#issuecomment-1017938857 Benchmark runs are scheduled for baseline = 22dc537e581b385b53ce579a03786a2db0bd4487 and contender = 33f89f6f32b451206906f5cdbef415ff055428f8. 33f89f6f32b451206906f5cdb

[GitHub] [arrow-datafusion] andygrove opened a new issue #1648: Cannot query parquet files generated by Apache Spark from datafusion-cli

2022-01-22 Thread GitBox
andygrove opened a new issue #1648: URL: https://github.com/apache/arrow-datafusion/issues/1648 **Describe the bug** I have a data set created by Apache Spark and I tried to query it from the DataFusion CLI. It failed, saying that a parquet file was corrupt. ``` CREATE EXT

[GitHub] [arrow-datafusion] Jimexist merged pull request #1647: update md-5, sha2, blake2

2022-01-22 Thread GitBox
Jimexist merged pull request #1647: URL: https://github.com/apache/arrow-datafusion/pull/1647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

[GitHub] [arrow-datafusion] Jimexist closed pull request #1630: Update blake2 requirement from ^0.9.2 to ^0.10.2

2022-01-22 Thread GitBox
Jimexist closed pull request #1630: URL: https://github.com/apache/arrow-datafusion/pull/1630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #1630: Update blake2 requirement from ^0.9.2 to ^0.10.2

2022-01-22 Thread GitBox
dependabot[bot] commented on pull request #1630: URL: https://github.com/apache/arrow-datafusion/pull/1630#issuecomment-1019394818 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major

[GitHub] [arrow-datafusion] yjshen commented on issue #1636: Provide RuntimeEnv to ExecutionContext

2022-01-22 Thread GitBox
yjshen commented on issue #1636: URL: https://github.com/apache/arrow-datafusion/issues/1636#issuecomment-1019397093 Thanks for the detailed explanation of the use case in Influx, haven't thought of it before. I think it would be great to have this. -- This is an automated message from

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1628: Update md-5 requirement from ^0.9.1 to ^0.10.0

2022-01-22 Thread GitBox
xudong963 commented on pull request #1628: URL: https://github.com/apache/arrow-datafusion/pull/1628#issuecomment-1019397695 plz close the ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1629: Update sha2 requirement from ^0.9.1 to ^0.10.1

2022-01-22 Thread GitBox
xudong963 commented on pull request #1629: URL: https://github.com/apache/arrow-datafusion/pull/1629#issuecomment-1019397729 plz close the ticket -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] ursabot edited a comment on pull request #12211: ARROW-15394: [CI][Docs] Fix env variable to ensure doxygen is used in doc build

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12211: URL: https://github.com/apache/arrow/pull/12211#issuecomment-1017938865 Benchmark runs are scheduled for baseline = 33f89f6f32b451206906f5cdbef415ff055428f8 and contender = d49e2160586ded206e5f4ee8f5785cc68e299d1d. d49e2160586ded206e5f4ee8f

[GitHub] [arrow-datafusion] dependabot[bot] closed pull request #1629: Update sha2 requirement from ^0.9.1 to ^0.10.1

2022-01-22 Thread GitBox
dependabot[bot] closed pull request #1629: URL: https://github.com/apache/arrow-datafusion/pull/1629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #1629: Update sha2 requirement from ^0.9.1 to ^0.10.1

2022-01-22 Thread GitBox
dependabot[bot] commented on pull request #1629: URL: https://github.com/apache/arrow-datafusion/pull/1629#issuecomment-1019398283 Looks like sha2 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow-datafusion] dependabot[bot] closed pull request #1628: Update md-5 requirement from ^0.9.1 to ^0.10.0

2022-01-22 Thread GitBox
dependabot[bot] closed pull request #1628: URL: https://github.com/apache/arrow-datafusion/pull/1628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #1628: Update md-5 requirement from ^0.9.1 to ^0.10.0

2022-01-22 Thread GitBox
dependabot[bot] commented on pull request #1628: URL: https://github.com/apache/arrow-datafusion/pull/1628#issuecomment-1019398285 Looks like md-5 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] kszucs commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
kszucs commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019401883 @github-actions crossbow submit wheel-manylinux* wheel-macos* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] github-actions[bot] commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
github-actions[bot] commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019402023 Revision: f1828588a4a9a5fe2649e533e9733edf8de6985c Submitted crossbow builds: [ursacomputing/crossbow @ actions-1429](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] kszucs commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
kszucs commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019403188 @github-actions crossbow submit wheel-macos-big-sur-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] github-actions[bot] commented on pull request #12227: [Python][Packaging] Use vcpkg manifest and update vcpkg version

2022-01-22 Thread GitBox
github-actions[bot] commented on pull request #12227: URL: https://github.com/apache/arrow/pull/12227#issuecomment-1019403286 Revision: a7b868de86487b566939694d3021893287d7210a Submitted crossbow builds: [ursacomputing/crossbow @ actions-1430](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] emkornfield commented on a change in pull request #12216: ARROW-14047: [C++] Parquet Arrow read table can produce invalid array [WIP]

2022-01-22 Thread GitBox
emkornfield commented on a change in pull request #12216: URL: https://github.com/apache/arrow/pull/12216#discussion_r790222470 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -3719,6 +3719,77 @@ TEST(TestArrowReaderAdHoc, WriteBatchedNestedNullableString

[GitHub] [arrow] emkornfield commented on a change in pull request #12216: ARROW-14047: [C++] Parquet Arrow read table can produce invalid array [WIP]

2022-01-22 Thread GitBox
emkornfield commented on a change in pull request #12216: URL: https://github.com/apache/arrow/pull/12216#discussion_r790222470 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -3719,6 +3719,77 @@ TEST(TestArrowReaderAdHoc, WriteBatchedNestedNullableString

[GitHub] [arrow] ursabot edited a comment on pull request #12210: ARROW-15393: [Release][Crossbow] Fall back to dev0 when the generated scm version number doesn't have a distance

2022-01-22 Thread GitBox
ursabot edited a comment on pull request #12210: URL: https://github.com/apache/arrow/pull/12210#issuecomment-1017938876 Benchmark runs are scheduled for baseline = d49e2160586ded206e5f4ee8f5785cc68e299d1d and contender = 6b0ce275391bfac7526b96a4b36ffcb1cb149b24. 6b0ce275391bfac7526b96a4b

[GitHub] [arrow-datafusion] houqp commented on issue #1648: Cannot query parquet files generated by Apache Spark from datafusion-cli

2022-01-22 Thread GitBox
houqp commented on issue #1648: URL: https://github.com/apache/arrow-datafusion/issues/1648#issuecomment-1019426734 This is because we are not providing file extension as search suffix in https://github.com/apache/arrow-datafusion/blob/9c5ccae240ce38b084128e8d7ff0752d0e2318a6/datafusion/sr

[GitHub] [arrow-datafusion] houqp closed issue #700: Improve performance polling / task sharing mechanism in Ballista

2022-01-22 Thread GitBox
houqp closed issue #700: URL: https://github.com/apache/arrow-datafusion/issues/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [arrow-datafusion] houqp merged pull request #1560: Introduce push-based task scheduling for Ballista

2022-01-22 Thread GitBox
houqp merged pull request #1560: URL: https://github.com/apache/arrow-datafusion/pull/1560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] houqp closed issue #1221: Task assignment between Scheduler and Executors

2022-01-22 Thread GitBox
houqp closed issue #1221: URL: https://github.com/apache/arrow-datafusion/issues/1221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

  1   2   >