[GitHub] [arrow-rs] codecov-commenter commented on pull request #1238: dyn compare for binary array

2022-01-25 Thread GitBox
codecov-commenter commented on pull request #1238: URL: https://github.com/apache/arrow-rs/pull/1238#issuecomment-1020912306 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow] ursabot edited a comment on pull request #12229: ARROW-15414: [Java] Fix RangeEqualsVisitor for BitVector

2022-01-25 Thread GitBox
ursabot edited a comment on pull request #12229: URL: https://github.com/apache/arrow/pull/12229#issuecomment-1020104357 Benchmark runs are scheduled for baseline = 512c5f1d454d21440f1ce1f8fa77cbb3b6cf8b42 and contender = daa5c18e9697a6455a7a75fec19594543c17b21e. daa5c18e9697a6455a7a75fec

[GitHub] [arrow-datafusion] yjshen commented on issue #1573: SQL tests for when sorting exceeded available memory and had to spill to disk

2022-01-25 Thread GitBox
yjshen commented on issue #1573: URL: https://github.com/apache/arrow-datafusion/issues/1573#issuecomment-1020913511 @alamb Ah, that makes sense. I will do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] Crystrix opened a new pull request #12251: ARROW-15441: [C++] Fix incorrect result of hash_count a null type column

2022-01-25 Thread GitBox
Crystrix opened a new pull request #12251: URL: https://github.com/apache/arrow/pull/12251 The result of hash_count such array is incorrect. For a table like this: argument key NULL 1 NULL 1 The result is :

[GitHub] [arrow] github-actions[bot] commented on pull request #12251: ARROW-15441: [C++] Fix incorrect result of hash_count a null type column

2022-01-25 Thread GitBox
github-actions[bot] commented on pull request #12251: URL: https://github.com/apache/arrow/pull/12251#issuecomment-1020915967 https://issues.apache.org/jira/browse/ARROW-15441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #1665: Skip some path in list_file_with_suffix.

2022-01-25 Thread GitBox
Jimexist commented on a change in pull request #1665: URL: https://github.com/apache/arrow-datafusion/pull/1665#discussion_r791457473 ## File path: datafusion/src/datasource/object_store/mod.rs ## @@ -141,7 +141,7 @@ pub trait ObjectStore: Sync + Send + Debug { let suf

[GitHub] [arrow-datafusion] dependabot[bot] opened a new pull request #1671: Update clap requirement from 2.33 to 3.0

2022-01-25 Thread GitBox
dependabot[bot] opened a new pull request #1671: URL: https://github.com/apache/arrow-datafusion/pull/1671 Updates the requirements on [clap](https://github.com/clap-rs/clap) to permit the latest version. Release notes Sourced from https://github.com/clap-rs/clap/releases";>clap's

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8510: ARROW-1614: [C++] Add a Tensor logical value type with constant dimensions, implemented using ExtensionType

2022-01-25 Thread GitBox
jorisvandenbossche commented on a change in pull request #8510: URL: https://github.com/apache/arrow/pull/8510#discussion_r791482403 ## File path: cpp/src/arrow/extension_type_test.cc ## @@ -333,4 +334,144 @@ TEST_F(TestExtensionType, ValidateExtensionArray) { ASSERT_OK(ext_

[GitHub] [arrow] bkmgit commented on pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-01-25 Thread GitBox
bkmgit commented on pull request #11882: URL: https://github.com/apache/arrow/pull/11882#issuecomment-1020947191 Comparisons of the form: ``` ValidateBetween(Datum(std::make_shared("zzz")), Datum(ArrayFromJSON(TypeTraits::type_singleton(), "[]")), Datum(ArrayFromJSO

[GitHub] [arrow] pitrou commented on a change in pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-25 Thread GitBox
pitrou commented on a change in pull request #12231: URL: https://github.com/apache/arrow/pull/12231#discussion_r791487536 ## File path: python/pyarrow/orc.py ## @@ -330,7 +330,9 @@ def read_table(source, columns=None, filesystem=None): """ -def write_table(table, where, *

[GitHub] [arrow] jorisvandenbossche commented on pull request #8510: ARROW-1614: [C++] Add a Tensor logical value type with constant dimensions, implemented using ExtensionType

2022-01-25 Thread GitBox
jorisvandenbossche commented on pull request #8510: URL: https://github.com/apache/arrow/pull/8510#issuecomment-1020954761 > would there be interest in folding the Pandas side of these third-party extensions into Pandas also? That will be something to discuss in the pandas project.

[GitHub] [arrow] pitrou commented on a change in pull request #12243: ARROW-15436: [Release][Python] Disable verification of gdb tests on windows and a flaky test on apple M1

2022-01-25 Thread GitBox
pitrou commented on a change in pull request #12243: URL: https://github.com/apache/arrow/pull/12243#discussion_r791511838 ## File path: dev/tasks/tasks.yml ## @@ -904,6 +904,8 @@ tasks: TEST_DEFAULT: 0 TEST_INTEGRATION_JAVA: 0 TEST_{{ target|upper }}

[GitHub] [arrow] pitrou closed pull request #12242: ARROW-15433: [Doc] Fix warnings when building

2022-01-25 Thread GitBox
pitrou closed pull request #12242: URL: https://github.com/apache/arrow/pull/12242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] pitrou commented on a change in pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
pitrou commented on a change in pull request #11916: URL: https://github.com/apache/arrow/pull/11916#discussion_r791519069 ## File path: dev/tasks/conda-recipes/arrow-cpp/meta.yaml ## @@ -81,6 +82,7 @@ outputs: - lz4-c - numpy - orc # [unix] +

[GitHub] [arrow] ursabot commented on pull request #12242: ARROW-15433: [Doc] Fix warnings when building

2022-01-25 Thread GitBox
ursabot commented on pull request #12242: URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453 Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6716f3da

[GitHub] [arrow] pitrou commented on pull request #10350: ARROW-12814: [C++][Gandiva] Implements ABS, FLOOR, PI, SQRT, SIGN, LSHIFT, RSHIFT, CEIL, TRUNC, LN and LOG2 functions

2022-01-25 Thread GitBox
pitrou commented on pull request #10350: URL: https://github.com/apache/arrow/pull/10350#issuecomment-1020984593 I would rather if a Gandiva developer vetted this PR. @pravindra perhaps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-rs] HaoYang670 commented on issue #751: Add examples to Rust Docs for arrow::array::UnionArray

2022-01-25 Thread GitBox
HaoYang670 commented on issue #751: URL: https://github.com/apache/arrow-rs/issues/751#issuecomment-1020991748 I'd like to try if no one has been doing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] xhochy commented on a change in pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
xhochy commented on a change in pull request #11916: URL: https://github.com/apache/arrow/pull/11916#discussion_r791530051 ## File path: dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh ## @@ -23,6 +23,7 @@ export PYARROW_WITH_PARQUET=1 export PYARROW_WITH_PLASMA=1 export P

[GitHub] [arrow] xhochy commented on a change in pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
xhochy commented on a change in pull request #11916: URL: https://github.com/apache/arrow/pull/11916#discussion_r791530610 ## File path: dev/tasks/conda-recipes/arrow-cpp/meta.yaml ## @@ -81,6 +82,7 @@ outputs: - lz4-c - numpy - orc # [unix] +

[GitHub] [arrow] xhochy commented on pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
xhochy commented on pull request #11916: URL: https://github.com/apache/arrow/pull/11916#issuecomment-1020994353 > Thanks @xhochy . Some of it a little over my head I must confess, but it all LGTM. Most of the fixed were general conda fixes and not related to the google-cloud-cpp ad

[GitHub] [arrow-rs] HaoYang670 commented on issue #1108: Add native comparison kernel support for BinaryArray

2022-01-25 Thread GitBox
HaoYang670 commented on issue #1108: URL: https://github.com/apache/arrow-rs/issues/1108#issuecomment-1020994550 I do not include `DictionaryArray` in my PR, because I do not find a straight forward way to build a binary dictionary. If it is needed, I will include it later in my PR. --

[GitHub] [arrow] pitrou commented on a change in pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
pitrou commented on a change in pull request #11916: URL: https://github.com/apache/arrow/pull/11916#discussion_r791532477 ## File path: dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh ## @@ -23,6 +23,7 @@ export PYARROW_WITH_PARQUET=1 export PYARROW_WITH_PLASMA=1 export P

[GitHub] [arrow] pitrou commented on a change in pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
pitrou commented on a change in pull request #11916: URL: https://github.com/apache/arrow/pull/11916#discussion_r791532646 ## File path: dev/tasks/conda-recipes/arrow-cpp/meta.yaml ## @@ -81,6 +82,7 @@ outputs: - lz4-c - numpy - orc # [unix] +

[GitHub] [arrow] ursabot edited a comment on pull request #12242: ARROW-15433: [Doc] Fix warnings when building

2022-01-25 Thread GitBox
ursabot edited a comment on pull request #12242: URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453 Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6

[GitHub] [arrow] dragosmg commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-25 Thread GitBox
dragosmg commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r791548170 ## File path: r/tests/testthat/test-Array.R ## @@ -985,3 +985,14 @@ test_that("Array to C-interface", { delete_arrow_schema(schema_ptr) delete_arro

[GitHub] [arrow] cyb70289 commented on a change in pull request #12239: ARROW-15374: [C++][FlightRPC] Add support for MemoryManager in data methods

2022-01-25 Thread GitBox
cyb70289 commented on a change in pull request #12239: URL: https://github.com/apache/arrow/pull/12239#discussion_r791564011 ## File path: cpp/src/arrow/flight/client.cc ## @@ -460,6 +462,11 @@ class GrpcIpcMessageReader : public ipc::MessageReader { stream_finished_ = t

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1671: Update clap requirement from 2.33 to 3.0

2022-01-25 Thread GitBox
xudong963 commented on pull request #1671: URL: https://github.com/apache/arrow-datafusion/pull/1671#issuecomment-1021032356 ignore @dependabot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow-datafusion] xudong963 edited a comment on pull request #1671: Update clap requirement from 2.33 to 3.0

2022-01-25 Thread GitBox
xudong963 edited a comment on pull request #1671: URL: https://github.com/apache/arrow-datafusion/pull/1671#issuecomment-1021032356 @dependabot close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #1671: Update clap requirement from 2.33 to 3.0

2022-01-25 Thread GitBox
dependabot[bot] commented on pull request #1671: URL: https://github.com/apache/arrow-datafusion/pull/1671#issuecomment-1021032879 Sorry, only users with push access can use that command. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1238: dyn compare for binary array

2022-01-25 Thread GitBox
tustvold commented on a change in pull request #1238: URL: https://github.com/apache/arrow-rs/pull/1238#discussion_r791568279 ## File path: arrow/src/compute/kernels/comparison.rs ## @@ -3843,6 +3960,114 @@ mod tests { assert_eq!(neq_dyn_scalar(&array, 8).unwrap(), exp

[GitHub] [arrow] xhochy commented on pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
xhochy commented on pull request #11916: URL: https://github.com/apache/arrow/pull/11916#issuecomment-1021083949 JIRA for the GCC 7.5 (cuda and ppc64le) compilation issue: https://issues.apache.org/jira/browse/ARROW-15444 -- This is an automated message from the Apache Git Service. To re

[GitHub] [arrow] xhochy commented on a change in pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-25 Thread GitBox
xhochy commented on a change in pull request #11916: URL: https://github.com/apache/arrow/pull/11916#discussion_r791616291 ## File path: dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh ## @@ -23,6 +23,7 @@ export PYARROW_WITH_PARQUET=1 export PYARROW_WITH_PLASMA=1 export P

[GitHub] [arrow] vibhatha opened a new pull request #12252: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-25 Thread GitBox
vibhatha opened a new pull request #12252: URL: https://github.com/apache/arrow/pull/12252 Adding a fix: Could be caused due to the smaller number of data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] github-actions[bot] commented on pull request #12252: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-25 Thread GitBox
github-actions[bot] commented on pull request #12252: URL: https://github.com/apache/arrow/pull/12252#issuecomment-1021091474 https://issues.apache.org/jira/browse/ARROW-15438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] bkmgit commented on pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-01-25 Thread GitBox
bkmgit commented on pull request #11882: URL: https://github.com/apache/arrow/pull/11882#issuecomment-1021091591 Implicit casting is not implemented for between, but is available in the other comparison kernels. Created another [issue](https://issues.apache.org/jira/browse/ARROW-15446) for

[GitHub] [arrow] ursabot edited a comment on pull request #12236: ARROW-15423: [C++][Dev] Make GDB plugin auto-load friendly

2022-01-25 Thread GitBox
ursabot edited a comment on pull request #12236: URL: https://github.com/apache/arrow/pull/12236#issuecomment-1020590959 Benchmark runs are scheduled for baseline = daa5c18e9697a6455a7a75fec19594543c17b21e and contender = 443d09548b03e8ee90aa8b9229e2f8a264c9c915. 443d09548b03e8ee90aa8b922

[GitHub] [arrow] ursabot edited a comment on pull request #12242: ARROW-15433: [Doc] Fix warnings when building

2022-01-25 Thread GitBox
ursabot edited a comment on pull request #12242: URL: https://github.com/apache/arrow/pull/12242#issuecomment-1020983453 Benchmark runs are scheduled for baseline = 9fb6defaecd3df3bfd40519118ae248c85df16dd and contender = 231d0a6b30e7017f0e07162b6716f3da49a674d0. 231d0a6b30e7017f0e07162b6

[GitHub] [arrow-rs] alamb merged pull request #1237: Improve documentation for Bitmap

2022-01-25 Thread GitBox
alamb merged pull request #1237: URL: https://github.com/apache/arrow-rs/pull/1237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] alamb commented on issue #1661: thread 'tokio-runtime-worker' panicked at 'not implemented: Take not supported for data type Decimal(18, 4)

2022-01-25 Thread GitBox
alamb commented on issue #1661: URL: https://github.com/apache/arrow-datafusion/issues/1661#issuecomment-1021097346 I am waiting on the final approval needed to release 8.0.0. I hope I can get this today -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] pitrou opened a new pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
pitrou opened a new pull request #12253: URL: https://github.com/apache/arrow/pull/12253 Even though the GDB extension should theoretically work with a release build, it's difficult to test for, as we can't lookup any variables from the GDB prompt. -- This is an automated message from t

[GitHub] [arrow] github-actions[bot] commented on pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
github-actions[bot] commented on pull request #12253: URL: https://github.com/apache/arrow/pull/12253#issuecomment-1021113689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] filmor commented on pull request #12193: ARROW-15381: [C#] Bump dependencies for C# Arrow.Flight and allow netstandard2.0

2022-01-25 Thread GitBox
filmor commented on pull request #12193: URL: https://github.com/apache/arrow/pull/12193#issuecomment-1021113761 @eerhardt Could you have a look? This would enable using Flight in .NET Framework projects. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] pitrou commented on pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
pitrou commented on pull request #12253: URL: https://github.com/apache/arrow/pull/12253#issuecomment-1021113880 @github-actions crossbow submit -g python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] paleolimbot commented on a change in pull request #12208: ARROW-14419 [R] Add filter + join test

2022-01-25 Thread GitBox
paleolimbot commented on a change in pull request #12208: URL: https://github.com/apache/arrow/pull/12208#discussion_r791642605 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -173,3 +173,31 @@ test_that("mutate then join", { ) ) }) + +test_that("filter then joi

[GitHub] [arrow] github-actions[bot] commented on pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
github-actions[bot] commented on pull request #12253: URL: https://github.com/apache/arrow/pull/12253#issuecomment-1021122947 Revision: 9c5d859589d985386442c0f212fb103e24bec172 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1483](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] dragosmg commented on a change in pull request #12208: ARROW-14419 [R] Add filter + join test

2022-01-25 Thread GitBox
dragosmg commented on a change in pull request #12208: URL: https://github.com/apache/arrow/pull/12208#discussion_r791659038 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -173,3 +173,31 @@ test_that("mutate then join", { ) ) }) + +test_that("filter then join",

[GitHub] [arrow] paleolimbot commented on a change in pull request #12208: ARROW-14419 [R] Add filter + join test

2022-01-25 Thread GitBox
paleolimbot commented on a change in pull request #12208: URL: https://github.com/apache/arrow/pull/12208#discussion_r791675682 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -173,3 +173,31 @@ test_that("mutate then join", { ) ) }) + +test_that("filter then joi

[GitHub] [arrow] dragosmg commented on a change in pull request #12208: ARROW-14419 [R] Add filter + join test

2022-01-25 Thread GitBox
dragosmg commented on a change in pull request #12208: URL: https://github.com/apache/arrow/pull/12208#discussion_r791680941 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -173,3 +173,31 @@ test_that("mutate then join", { ) ) }) + +test_that("filter then join",

[GitHub] [arrow] dragosmg commented on a change in pull request #12208: ARROW-14419 [R] Add filter + join test

2022-01-25 Thread GitBox
dragosmg commented on a change in pull request #12208: URL: https://github.com/apache/arrow/pull/12208#discussion_r791680941 ## File path: r/tests/testthat/test-dplyr-join.R ## @@ -173,3 +173,31 @@ test_that("mutate then join", { ) ) }) + +test_that("filter then join",

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791685056 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,169 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArra

[GitHub] [arrow] kszucs commented on pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
kszucs commented on pull request #12253: URL: https://github.com/apache/arrow/pull/12253#issuecomment-1021159677 Can we remove the `PYARROW_TEST_GDB=OFF` flags from #12243 once this is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] kszucs edited a comment on pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
kszucs edited a comment on pull request #12253: URL: https://github.com/apache/arrow/pull/12253#issuecomment-1021159677 Can we remove the `PYARROW_TEST_GDB=OFF` flags from #12243 once this is merged (presuming a new RC)? -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow] pitrou commented on pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
pitrou commented on pull request #12253: URL: https://github.com/apache/arrow/pull/12253#issuecomment-1021161499 If these are all non-debug builds, then probably, yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] rok commented on a change in pull request #8510: ARROW-1614: [C++] Add a Tensor logical value type with constant dimensions, implemented using ExtensionType

2022-01-25 Thread GitBox
rok commented on a change in pull request #8510: URL: https://github.com/apache/arrow/pull/8510#discussion_r791700615 ## File path: cpp/src/arrow/extension_type_test.cc ## @@ -333,4 +334,144 @@ TEST_F(TestExtensionType, ValidateExtensionArray) { ASSERT_OK(ext_arr4->ValidateF

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791702912 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,169 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #1672: upgrade clap to version 3

2022-01-25 Thread GitBox
Jimexist opened a new pull request #1672: URL: https://github.com/apache/arrow-datafusion/pull/1672 # Which issue does this PR close? Closes #1671 # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791705325 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,167 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791705730 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,169 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1672: upgrade clap to version 3

2022-01-25 Thread GitBox
xudong963 commented on a change in pull request #1672: URL: https://github.com/apache/arrow-datafusion/pull/1672#discussion_r791714484 ## File path: datafusion-cli/src/main.rs ## @@ -154,23 +154,23 @@ pub async fn main() -> Result<()> { Ok(()) } -fn is_valid_file(dir: S

[GitHub] [arrow] kszucs commented on pull request #12245: ARROW-15437: [Python][FlightRPC] Fix flaky test test_interrupt

2022-01-25 Thread GitBox
kszucs commented on pull request #12245: URL: https://github.com/apache/arrow/pull/12245#issuecomment-1021190719 @lidavidm do we have a reproducer perhaps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] lidavidm commented on a change in pull request #12251: ARROW-15441: [C++][Compute] Fix incorrect result of hash_count a null type column

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12251: URL: https://github.com/apache/arrow/pull/12251#discussion_r791715298 ## File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc ## @@ -2811,5 +2811,98 @@ TEST(GroupBy, SmallChunkSizeSumOnly) {

[GitHub] [arrow] lidavidm commented on pull request #12245: ARROW-15437: [Python][FlightRPC] Fix flaky test test_interrupt

2022-01-25 Thread GitBox
lidavidm commented on pull request #12245: URL: https://github.com/apache/arrow/pull/12245#issuecomment-1021198811 Not really, except running the test in a loop (though --pdb makes it much more likely) -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791729070 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,167 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArra

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791729886 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,167 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow] kszucs closed pull request #12245: ARROW-15437: [Python][FlightRPC] Fix flaky test test_interrupt

2022-01-25 Thread GitBox
kszucs closed pull request #12245: URL: https://github.com/apache/arrow/pull/12245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] alamb commented on issue #1661: thread 'tokio-runtime-worker' panicked at 'not implemented: Take not supported for data type Decimal(18, 4)

2022-01-25 Thread GitBox
alamb commented on issue #1661: URL: https://github.com/apache/arrow-datafusion/issues/1661#issuecomment-1021208551 Released https://lists.apache.org/thread/b803mt0g8czbz3l31230053o2q728mqw 🎉 I will get a PR up to upgrade datafusion -- This is an automated message from the Apache

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791739035 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,167 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArra

[GitHub] [arrow] lidavidm commented on a change in pull request #12239: ARROW-15374: [C++][FlightRPC] Add support for MemoryManager in data methods

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12239: URL: https://github.com/apache/arrow/pull/12239#discussion_r791739985 ## File path: cpp/src/arrow/flight/client.cc ## @@ -460,6 +462,11 @@ class GrpcIpcMessageReader : public ipc::MessageReader { stream_finished_ = t

[GitHub] [arrow] ursabot commented on pull request #12245: ARROW-15437: [Python][FlightRPC] Fix flaky test test_interrupt

2022-01-25 Thread GitBox
ursabot commented on pull request #12245: URL: https://github.com/apache/arrow/pull/12245#issuecomment-1021211208 Benchmark runs are scheduled for baseline = 231d0a6b30e7017f0e07162b6716f3da49a674d0 and contender = 0fa4b9ca1e7b13ac230f85075d86d783eeea6a74. 0fa4b9ca1e7b13ac230f85075d86d783

[GitHub] [arrow-datafusion] alamb opened a new pull request #1673: Update to arrow 8.0.0

2022-01-25 Thread GitBox
alamb opened a new pull request #1673: URL: https://github.com/apache/arrow-datafusion/pull/1673 # Which issue does this PR close? N/A # Rationale for this change Update to latest arrow, getting among other things, improvements for decimal type, and parquet utf8 validation

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r791741717 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -429,6 +429,167 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow] Crystrix commented on a change in pull request #12251: ARROW-15441: [C++][Compute] Fix incorrect result of hash_count a null type column

2022-01-25 Thread GitBox
Crystrix commented on a change in pull request #12251: URL: https://github.com/apache/arrow/pull/12251#discussion_r791742401 ## File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc ## @@ -2811,5 +2811,98 @@ TEST(GroupBy, SmallChunkSizeSumOnly) {

[GitHub] [arrow] raulcd commented on a change in pull request #12252: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-25 Thread GitBox
raulcd commented on a change in pull request #12252: URL: https://github.com/apache/arrow/pull/12252#discussion_r791743995 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -3804,6 +3807,8 @@ def _get_compare_pair(data_source, record_batch, file_format, col_id): nu

[GitHub] [arrow-datafusion] alamb commented on pull request #1673: Update to arrow 8.0.0

2022-01-25 Thread GitBox
alamb commented on pull request #1673: URL: https://github.com/apache/arrow-datafusion/pull/1673#issuecomment-1021214521 cc @liukun4515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow] kszucs commented on pull request #12253: ARROW-15442: [C++][Python] Skip GDB tests on a non-debug build

2022-01-25 Thread GitBox
kszucs commented on pull request #12253: URL: https://github.com/apache/arrow/pull/12253#issuecomment-1021217229 @github-actions crossbow submit wheel-macos-big-sur-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] lidavidm commented on a change in pull request #12136: ARROW-14092: [C++] subtract(date, duration) -> timestamp kernel

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12136: URL: https://github.com/apache/arrow/pull/12136#discussion_r791745928 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.cc ## @@ -109,6 +109,39 @@ void ReplaceNullWithOtherType(ValueDescr* first, size_t count) {

[GitHub] [arrow] vibhatha commented on a change in pull request #12252: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-25 Thread GitBox
vibhatha commented on a change in pull request #12252: URL: https://github.com/apache/arrow/pull/12252#discussion_r791749029 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -3804,6 +3807,8 @@ def _get_compare_pair(data_source, record_batch, file_format, col_id):

[GitHub] [arrow] vibhatha commented on a change in pull request #12252: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-25 Thread GitBox
vibhatha commented on a change in pull request #12252: URL: https://github.com/apache/arrow/pull/12252#discussion_r791749029 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -3804,6 +3807,8 @@ def _get_compare_pair(data_source, record_batch, file_format, col_id):

[GitHub] [arrow-datafusion] alamb merged pull request #1667: feat: Support quarter granularity in date_trunc function

2022-01-25 Thread GitBox
alamb merged pull request #1667: URL: https://github.com/apache/arrow-datafusion/pull/1667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb closed pull request #1381: [Feat] Quarterly Support

2022-01-25 Thread GitBox
alamb closed pull request #1381: URL: https://github.com/apache/arrow-datafusion/pull/1381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on pull request #1381: [Feat] Quarterly Support

2022-01-25 Thread GitBox
alamb commented on pull request #1381: URL: https://github.com/apache/arrow-datafusion/pull/1381#issuecomment-1021222179 Completed in https://github.com/apache/arrow-datafusion/pull/1667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] rafael-telles opened a new pull request #12254: [FlightRPC][Java] JDBC driver for Flight SQL

2022-01-25 Thread GitBox
rafael-telles opened a new pull request #12254: URL: https://github.com/apache/arrow/pull/12254 This implements a JDBC driver able to communicate to Flight SQL sources. So far this covers: - Metadata retrieval by DatabaseMetadata, ResultSetMetadata, etc. - Query execution by sta

[GitHub] [arrow] lidavidm commented on a change in pull request #12248: ARROW-1888: [C++] Implement Struct Casts

2022-01-25 Thread GitBox
lidavidm commented on a change in pull request #12248: URL: https://github.com/apache/arrow/pull/12248#discussion_r791750845 ## File path: cpp/src/arrow/compute/kernels/scalar_cast_nested.cc ## @@ -150,6 +150,73 @@ void AddListCast(CastFunction* func) { DCHECK_OK(func->AddKe

[GitHub] [arrow] jonkeane commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-25 Thread GitBox
jonkeane commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r791756282 ## File path: r/tests/testthat/test-Array.R ## @@ -985,3 +985,14 @@ test_that("Array to C-interface", { delete_arrow_schema(schema_ptr) delete_arro

[GitHub] [arrow] ursabot edited a comment on pull request #12245: ARROW-15437: [Python][FlightRPC] Fix flaky test test_interrupt

2022-01-25 Thread GitBox
ursabot edited a comment on pull request #12245: URL: https://github.com/apache/arrow/pull/12245#issuecomment-1021211208 Benchmark runs are scheduled for baseline = 231d0a6b30e7017f0e07162b6716f3da49a674d0 and contender = 0fa4b9ca1e7b13ac230f85075d86d783eeea6a74. 0fa4b9ca1e7b13ac230f85075

[GitHub] [arrow] AlenkaF commented on pull request #12178: ARROW-9664: [Python] Array/ChunkedArray.to_pandas do not support types_mapper keyword

2022-01-25 Thread GitBox
AlenkaF commented on pull request #12178: URL: https://github.com/apache/arrow/pull/12178#issuecomment-1021233071 Got it! Will do it as soon as I am back (next week). Hope that's ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-cookbook] amol- commented on pull request #125: [Java]: Setup java arrow cookbook doc and testing baseline

2022-01-25 Thread GitBox
amol- commented on pull request #125: URL: https://github.com/apache/arrow-cookbook/pull/125#issuecomment-1021234192 To ease PR management for the other recipe java PRs (that depend on this one) I'm going to merge this one. I'll create a PR to integrate the CI for the Java part. -- This

[GitHub] [arrow-cookbook] amol- merged pull request #125: [Java]: Setup java arrow cookbook doc and testing baseline

2022-01-25 Thread GitBox
amol- merged pull request #125: URL: https://github.com/apache/arrow-cookbook/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [arrow] dragosmg commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-25 Thread GitBox
dragosmg commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r791766856 ## File path: r/tests/testthat/test-Array.R ## @@ -985,3 +985,14 @@ test_that("Array to C-interface", { delete_arrow_schema(schema_ptr) delete_arro

[GitHub] [arrow] pitrou opened a new pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro

2022-01-25 Thread GitBox
pitrou opened a new pull request #12255: URL: https://github.com/apache/arrow/pull/12255 Fix the following compilation error on Ubuntu 18.04: ``` /arrow/cpp/src/arrow/adapters/orc/options.h:73:13: error: In the GNU C Library, "major" is defined by . For historical compatibility, i

[GitHub] [arrow] pitrou commented on a change in pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro

2022-01-25 Thread GitBox
pitrou commented on a change in pull request #12255: URL: https://github.com/apache/arrow/pull/12255#discussion_r791769465 ## File path: python/pyarrow/tests/test_orc.py ## @@ -299,219 +299,219 @@ def test_orcfile_readwrite_with_bad_writeoptions(): # batch_size must be a p

[GitHub] [arrow] pitrou commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro

2022-01-25 Thread GitBox
pitrou commented on pull request #12255: URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021239845 @iajoiner FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [arrow] rok commented on a change in pull request #12136: ARROW-14092: [C++] subtract(date, duration) -> timestamp kernel

2022-01-25 Thread GitBox
rok commented on a change in pull request #12136: URL: https://github.com/apache/arrow/pull/12136#discussion_r791769717 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.cc ## @@ -109,6 +109,39 @@ void ReplaceNullWithOtherType(ValueDescr* first, size_t count) { }

[GitHub] [arrow] pitrou commented on pull request #12255: ARROW-15447: [C++] Avoid conflict between ORC options API and glibc-defined macro

2022-01-25 Thread GitBox
pitrou commented on pull request #12255: URL: https://github.com/apache/arrow/pull/12255#issuecomment-1021240552 @github-actions crossbow submit -g cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] rok commented on a change in pull request #12136: ARROW-14092: [C++] subtract(date, duration) -> timestamp kernel

2022-01-25 Thread GitBox
rok commented on a change in pull request #12136: URL: https://github.com/apache/arrow/pull/12136#discussion_r791770325 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.cc ## @@ -109,6 +109,39 @@ void ReplaceNullWithOtherType(ValueDescr* first, size_t count) { }

[GitHub] [arrow-cookbook] amol- commented on pull request #133: Java Cookbook CI

2022-01-25 Thread GitBox
amol- commented on pull request #133: URL: https://github.com/apache/arrow-cookbook/pull/133#issuecomment-1021242687 Will add deploy part as soon as I confirmed that the testing part works as expected -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-25 Thread GitBox
jorisvandenbossche commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r791773567 ## File path: r/tests/testthat/test-Array.R ## @@ -985,3 +985,14 @@ test_that("Array to C-interface", { delete_arrow_schema(schema_ptr) d

[GitHub] [arrow] dragosmg commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-25 Thread GitBox
dragosmg commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r791778184 ## File path: r/tests/testthat/test-Array.R ## @@ -985,3 +985,14 @@ test_that("Array to C-interface", { delete_arrow_schema(schema_ptr) delete_arro

[GitHub] [arrow-datafusion] Ted-Jiang commented on a change in pull request #1665: Skip some path in list_file_with_suffix.

2022-01-25 Thread GitBox
Ted-Jiang commented on a change in pull request #1665: URL: https://github.com/apache/arrow-datafusion/pull/1665#discussion_r791778966 ## File path: datafusion/src/datasource/object_store/mod.rs ## @@ -141,7 +141,7 @@ pub trait ObjectStore: Sync + Send + Debug { let su

[GitHub] [arrow] jonkeane commented on a change in pull request #12240: ARROW-14442 [R]behaviour when converting timestamps with "" as tzone

2022-01-25 Thread GitBox
jonkeane commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r791779372 ## File path: r/tests/testthat/test-Array.R ## @@ -985,3 +985,14 @@ test_that("Array to C-interface", { delete_arrow_schema(schema_ptr) delete_arro

  1   2   3   4   5   6   >