[GitHub] [arrow-datafusion] xudong963 commented on issue #1688: Testing result of String related built-in functions

2022-01-27 Thread GitBox
xudong963 commented on issue #1688: URL: https://github.com/apache/arrow-datafusion/issues/1688#issuecomment-1022950128 About `substr` & `substring` I believe now datafusion supports `substring` and `select substring("" from x for y)`. BTW the behavior is the same as Postgres. ``

[GitHub] [arrow] thisisnic closed pull request #12244: ARROW-14807: [R] Implement bindings for lubridate am and pm

2022-01-27 Thread GitBox
thisisnic closed pull request #12244: URL: https://github.com/apache/arrow/pull/12244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow] ursabot commented on pull request #12244: ARROW-14807: [R] Implement bindings for lubridate am and pm

2022-01-27 Thread GitBox
ursabot commented on pull request #12244: URL: https://github.com/apache/arrow/pull/12244#issuecomment-1022965753 Benchmark runs are scheduled for baseline = 01855c791056b7f712e6df82acf97ad3ab7b823a and contender = 79800d4a374586a1e66bb85fc05966066ba2199a. 79800d4a374586a1e66bb85fc0596606

[GitHub] [arrow] ursabot edited a comment on pull request #12244: ARROW-14807: [R] Implement bindings for lubridate am and pm

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12244: URL: https://github.com/apache/arrow/pull/12244#issuecomment-1022965753 Benchmark runs are scheduled for baseline = 01855c791056b7f712e6df82acf97ad3ab7b823a and contender = 79800d4a374586a1e66bb85fc05966066ba2199a. 79800d4a374586a1e66bb85fc

[GitHub] [arrow] ursabot edited a comment on pull request #12152: ARROW-15123: [R] CSV dataset file header read in as data

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12152: URL: https://github.com/apache/arrow/pull/12152#issuecomment-1022242315 Benchmark runs are scheduled for baseline = 0b95b625cc5f2423498bdafdcc5acad968909933 and contender = 458271315688fab239798ea146a12f06fa18e262. 458271315688fab239798ea14

[GitHub] [arrow] pitrou commented on a change in pull request #12270: ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #12270: URL: https://github.com/apache/arrow/pull/12270#discussion_r793431660 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -2392,6 +2392,29 @@ struct NonZeroVisitor { return Status::OK(); } + + tem

[GitHub] [arrow-cookbook] amol- commented on a change in pull request #131: [Java]: Java cookbook for create arrow object

2022-01-27 Thread GitBox
amol- commented on a change in pull request #131: URL: https://github.com/apache/arrow-cookbook/pull/131#discussion_r793435741 ## File path: java/source/create.rst ## @@ -30,8 +30,135 @@ Array of Int (32-bit integer value) intVector.set(2, 3); intVector.setValueCount(3)

[GitHub] [arrow] pitrou commented on pull request #12274: PARQUET-2115: [C++] Parquet dictionary bit widths are limited to 32 bits

2022-01-27 Thread GitBox
pitrou commented on pull request #12274: URL: https://github.com/apache/arrow/pull/12274#issuecomment-1023032800 @tachyonwill Very nice! Which fuzzer is this, by the way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] pitrou commented on a change in pull request #12274: PARQUET-2115: [C++] Parquet dictionary bit widths are limited to 32 bits

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #12274: URL: https://github.com/apache/arrow/pull/12274#discussion_r793437109 ## File path: cpp/src/parquet/encoding.cc ## @@ -1486,8 +1486,9 @@ class DictDecoderImpl : public DecoderImpl, virtual public DictDecoder { return;

[GitHub] [arrow] pitrou commented on pull request #12263: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-27 Thread GitBox
pitrou commented on pull request #12263: URL: https://github.com/apache/arrow/pull/12263#issuecomment-1023039625 This fixes the failure for me while it could be reproduced quite reliably on master. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [arrow] pitrou closed pull request #12263: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-27 Thread GitBox
pitrou closed pull request #12263: URL: https://github.com/apache/arrow/pull/12263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] pitrou closed pull request #12241: ARROW-15390: [Dev][C++][Doc] Document the GDB extension

2022-01-27 Thread GitBox
pitrou closed pull request #12241: URL: https://github.com/apache/arrow/pull/12241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] pitrou closed pull request #12238: ARROW-15427: [C++][Gandiva] Use a lock guard to hold a mutex

2022-01-27 Thread GitBox
pitrou closed pull request #12238: URL: https://github.com/apache/arrow/pull/12238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] ursabot commented on pull request #12238: ARROW-15427: [C++][Gandiva] Use a lock guard to hold a mutex

2022-01-27 Thread GitBox
ursabot commented on pull request #12238: URL: https://github.com/apache/arrow/pull/12238#issuecomment-1023048351 Benchmark runs are scheduled for baseline = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1 and contender = 3cc48bea05f7752e0b6f3adb3fb45bef840b09ae. 3cc48bea05f7752e0b6f3adb3fb45bef

[GitHub] [arrow] ursabot commented on pull request #12241: ARROW-15390: [Dev][C++][Doc] Document the GDB extension

2022-01-27 Thread GitBox
ursabot commented on pull request #12241: URL: https://github.com/apache/arrow/pull/12241#issuecomment-1023048342 Benchmark runs are scheduled for baseline = 5a51c6d2f83cdd47a006c02e624f08f992a0b761 and contender = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1. f1dc9698dad0fbcb28c4041185bb8bc5

[GitHub] [arrow] ursabot commented on pull request #12263: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-27 Thread GitBox
ursabot commented on pull request #12263: URL: https://github.com/apache/arrow/pull/12263#issuecomment-1023048330 Benchmark runs are scheduled for baseline = 79800d4a374586a1e66bb85fc05966066ba2199a and contender = 5a51c6d2f83cdd47a006c02e624f08f992a0b761. 5a51c6d2f83cdd47a006c02e624f08f9

[GitHub] [arrow-cookbook] amol- merged pull request #134: [Java]: Java cookbook for create arrow schema

2022-01-27 Thread GitBox
amol- merged pull request #134: URL: https://github.com/apache/arrow-cookbook/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [arrow] ursabot edited a comment on pull request #12263: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12263: URL: https://github.com/apache/arrow/pull/12263#issuecomment-1023048330 Benchmark runs are scheduled for baseline = 79800d4a374586a1e66bb85fc05966066ba2199a and contender = 5a51c6d2f83cdd47a006c02e624f08f992a0b761. 5a51c6d2f83cdd47a006c02e6

[GitHub] [arrow] ursabot edited a comment on pull request #12244: ARROW-14807: [R] Implement bindings for lubridate am and pm

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12244: URL: https://github.com/apache/arrow/pull/12244#issuecomment-1022965753 Benchmark runs are scheduled for baseline = 01855c791056b7f712e6df82acf97ad3ab7b823a and contender = 79800d4a374586a1e66bb85fc05966066ba2199a. 79800d4a374586a1e66bb85fc

[GitHub] [arrow] pitrou commented on a change in pull request #12239: ARROW-15374: [C++][FlightRPC] Add support for MemoryManager in data methods

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #12239: URL: https://github.com/apache/arrow/pull/12239#discussion_r793461781 ## File path: cpp/src/arrow/flight/flight_cuda_test.cc ## @@ -0,0 +1,201 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow] pitrou commented on pull request #12105: ARROW-14098: [C++] subtract(time, time) -> duration kernel

2022-01-27 Thread GitBox
pitrou commented on pull request #12105: URL: https://github.com/apache/arrow/pull/12105#issuecomment-1023070060 @rok Are you done with this? I see you're still pushing changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] xhochy commented on pull request #11916: ARROW-14506: [C++] Conda support for google-cloud-cpp

2022-01-27 Thread GitBox
xhochy commented on pull request #11916: URL: https://github.com/apache/arrow/pull/11916#issuecomment-1023070504 Waiting for: - https://github.com/conda-forge/ctng-compilers-feedstock/pull/82 - https://github.com/conda-forge/r_clang_activation-feedstock/pull/2 - https://github.c

[GitHub] [arrow] pitrou commented on a change in pull request #12091: ARROW-14798: [C++][Python][R] Add container window to PrettyPrintOptions

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #12091: URL: https://github.com/apache/arrow/pull/12091#discussion_r793475309 ## File path: python/pyarrow/table.pxi ## @@ -74,9 +74,14 @@ cdef class ChunkedArray(_PandasConvertible): How much to indent right the content

[GitHub] [arrow] ursabot edited a comment on pull request #12241: ARROW-15390: [Dev][C++][Doc] Document the GDB extension

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12241: URL: https://github.com/apache/arrow/pull/12241#issuecomment-1023048342 Benchmark runs are scheduled for baseline = 5a51c6d2f83cdd47a006c02e624f08f992a0b761 and contender = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1. f1dc9698dad0fbcb28c404118

[GitHub] [arrow] rok commented on pull request #12105: ARROW-14098: [C++] subtract(time, time) -> duration kernel

2022-01-27 Thread GitBox
rok commented on pull request #12105: URL: https://github.com/apache/arrow/pull/12105#issuecomment-1023080043 @pitrou It's done, I just noticed the kernel output type was off. Please proceed :). -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] vibhatha opened a new pull request #12275: ARROW-15262: [C++] Create a ToTable sink node

2022-01-27 Thread GitBox
vibhatha opened a new pull request #12275: URL: https://github.com/apache/arrow/pull/12275 This PR includes an addition of a Sink node customized to obtain the output from an streaming execution. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] ursabot edited a comment on pull request #12238: ARROW-15427: [C++][Gandiva] Use a lock guard to hold a mutex

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12238: URL: https://github.com/apache/arrow/pull/12238#issuecomment-1023048351 Benchmark runs are scheduled for baseline = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1 and contender = 3cc48bea05f7752e0b6f3adb3fb45bef840b09ae. 3cc48bea05f7752e0b6f3adb3

[GitHub] [arrow-datafusion] alamb closed issue #1676: Regression: Merge assertion: `'assertion failed: i < self.len()'` in array_primitive.rs while merging non overlapping streams

2022-01-27 Thread GitBox
alamb closed issue #1676: URL: https://github.com/apache/arrow-datafusion/issues/1676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow-datafusion] alamb merged pull request #1678: Fix bug while merging `RecordBatch`, add `SortPreservingMerge` fuzz tester

2022-01-27 Thread GitBox
alamb merged pull request #1678: URL: https://github.com/apache/arrow-datafusion/pull/1678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb commented on issue #1669: Support reading from CSV, Avro and Json files that have mergeable/compatible, but not identical schemas

2022-01-27 Thread GitBox
alamb commented on issue #1669: URL: https://github.com/apache/arrow-datafusion/issues/1669#issuecomment-1023099056 > Since I made this mess I feel duty-bound to clean it up :) I can take this one. I wouldn't describe this as a mess ! The ability to merge multiple parquet files

[GitHub] [arrow] github-actions[bot] commented on pull request #12275: ARROW-15262: [C++] Create a ToTable sink node

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #12275: URL: https://github.com/apache/arrow/pull/12275#issuecomment-1023119264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] alamb commented on issue #1202: Add doc examples for `eq_dyn` etc.

2022-01-27 Thread GitBox
alamb commented on issue #1202: URL: https://github.com/apache/arrow-rs/issues/1202#issuecomment-1023126818 Thanks @HaoYang670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow-datafusion] alamb merged pull request #1687: Make `SortPreservingMergeStream` stable on input stream order

2022-01-27 Thread GitBox
alamb merged pull request #1687: URL: https://github.com/apache/arrow-datafusion/pull/1687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow-datafusion] alamb closed issue #1686: Stable `SortPreservingMergeStream`

2022-01-27 Thread GitBox
alamb closed issue #1686: URL: https://github.com/apache/arrow-datafusion/issues/1686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

[GitHub] [arrow] c-jamie commented on pull request #12270: ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function

2022-01-27 Thread GitBox
c-jamie commented on pull request #12270: URL: https://github.com/apache/arrow/pull/12270#issuecomment-1023131136 Amazing - thanks a mill @pitrou for helping me with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] paleolimbot commented on a change in pull request #11730: ARROW-14745: [R] Enable true duckdb streaming

2022-01-27 Thread GitBox
paleolimbot commented on a change in pull request #11730: URL: https://github.com/apache/arrow/pull/11730#discussion_r793532447 ## File path: r/R/duckdb.R ## @@ -155,6 +154,5 @@ to_arrow <- function(.data) { # Run the query res <- DBI::dbSendQuery(dbplyr::remote_con(.data

[GitHub] [arrow] paleolimbot commented on a change in pull request #11730: ARROW-14745: [R] Enable true duckdb streaming

2022-01-27 Thread GitBox
paleolimbot commented on a change in pull request #11730: URL: https://github.com/apache/arrow/pull/11730#discussion_r793533925 ## File path: r/R/duckdb.R ## @@ -155,6 +154,5 @@ to_arrow <- function(.data) { # Run the query res <- DBI::dbSendQuery(dbplyr::remote_con(.data

[GitHub] [arrow] ursabot edited a comment on pull request #12263: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12263: URL: https://github.com/apache/arrow/pull/12263#issuecomment-1023048330 Benchmark runs are scheduled for baseline = 79800d4a374586a1e66bb85fc05966066ba2199a and contender = 5a51c6d2f83cdd47a006c02e624f08f992a0b761. 5a51c6d2f83cdd47a006c02e6

[GitHub] [arrow] ursabot edited a comment on pull request #12231: ARROW-14783: [C++][Python] Fix the write ORC in BytesIO issue

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12231: URL: https://github.com/apache/arrow/pull/12231#issuecomment-1022313266 Benchmark runs are scheduled for baseline = 458271315688fab239798ea146a12f06fa18e262 and contender = f9f6fdbb7518c09b833cb6b78bc202008d28e865. f9f6fdbb7518c09b833cb6b78

[GitHub] [arrow] cyb70289 closed pull request #12272: ARROW-15467: [Go][Parquet] Fix pqarrow decimal tests on s390x

2022-01-27 Thread GitBox
cyb70289 closed pull request #12272: URL: https://github.com/apache/arrow/pull/12272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] ursabot commented on pull request #12272: ARROW-15467: [Go][Parquet] Fix pqarrow decimal tests on s390x

2022-01-27 Thread GitBox
ursabot commented on pull request #12272: URL: https://github.com/apache/arrow/pull/12272#issuecomment-1023190865 Benchmark runs are scheduled for baseline = 3cc48bea05f7752e0b6f3adb3fb45bef840b09ae and contender = 09e4a5e04c9e39169b5264e0aa98a5cf0945ecba. 09e4a5e04c9e39169b5264e0aa98a5cf

[GitHub] [arrow] lidavidm commented on a change in pull request #12275: ARROW-15262: [C++] Create a ToTable sink node

2022-01-27 Thread GitBox
lidavidm commented on a change in pull request #12275: URL: https://github.com/apache/arrow/pull/12275#discussion_r793595631 ## File path: cpp/src/arrow/compute/exec/sink_node.cc ## @@ -232,6 +232,77 @@ class ConsumingSinkNode : public ExecNode { std::shared_ptr consumer_;

[GitHub] [arrow] ursabot edited a comment on pull request #12272: ARROW-15467: [Go][Parquet] Fix pqarrow decimal tests on s390x

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12272: URL: https://github.com/apache/arrow/pull/12272#issuecomment-1023190865 Benchmark runs are scheduled for baseline = 3cc48bea05f7752e0b6f3adb3fb45bef840b09ae and contender = 09e4a5e04c9e39169b5264e0aa98a5cf0945ecba. 09e4a5e04c9e39169b5264e0a

[GitHub] [arrow] vibhatha commented on a change in pull request #12275: ARROW-15262: [C++] Create a ToTable sink node

2022-01-27 Thread GitBox
vibhatha commented on a change in pull request #12275: URL: https://github.com/apache/arrow/pull/12275#discussion_r793615621 ## File path: cpp/src/arrow/compute/exec/sink_node.cc ## @@ -232,6 +232,77 @@ class ConsumingSinkNode : public ExecNode { std::shared_ptr consumer_;

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-27 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r793616706 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -430,81 +430,56 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow] pitrou commented on pull request #12091: ARROW-14798: [C++][Python][R] Add container window to PrettyPrintOptions

2022-01-27 Thread GitBox
pitrou commented on pull request #12091: URL: https://github.com/apache/arrow/pull/12091#issuecomment-1023227484 @jorisvandenbossche Do you want to make a final review here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] pitrou closed pull request #12270: ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function

2022-01-27 Thread GitBox
pitrou closed pull request #12270: URL: https://github.com/apache/arrow/pull/12270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] ursabot commented on pull request #12270: ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function

2022-01-27 Thread GitBox
ursabot commented on pull request #12270: URL: https://github.com/apache/arrow/pull/12270#issuecomment-1023231506 Benchmark runs are scheduled for baseline = 09e4a5e04c9e39169b5264e0aa98a5cf0945ecba and contender = ce0964ed1eeb1881ddae3e84a8860316538ef0b7. ce0964ed1eeb1881ddae3e84a8860316

[GitHub] [arrow] pitrou commented on a change in pull request #12274: PARQUET-2115: [C++] Parquet dictionary bit widths are limited to 32 bits

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #12274: URL: https://github.com/apache/arrow/pull/12274#discussion_r793437109 ## File path: cpp/src/parquet/encoding.cc ## @@ -1486,8 +1486,9 @@ class DictDecoderImpl : public DecoderImpl, virtual public DictDecoder { return;

[GitHub] [arrow] pitrou closed pull request #12203: ARROW-15387 [R] Un-skip chunked array test for decimal256()

2022-01-27 Thread GitBox
pitrou closed pull request #12203: URL: https://github.com/apache/arrow/pull/12203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] ursabot edited a comment on pull request #12270: ARROW-15218: [C++] Add decimal support to the indices_nonzero compute function

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12270: URL: https://github.com/apache/arrow/pull/12270#issuecomment-1023231506 Benchmark runs are scheduled for baseline = 09e4a5e04c9e39169b5264e0aa98a5cf0945ecba and contender = ce0964ed1eeb1881ddae3e84a8860316538ef0b7. ce0964ed1eeb1881ddae3e84a

[GitHub] [arrow] ursabot edited a comment on pull request #12241: ARROW-15390: [Dev][C++][Doc] Document the GDB extension

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12241: URL: https://github.com/apache/arrow/pull/12241#issuecomment-1023048342 Benchmark runs are scheduled for baseline = 5a51c6d2f83cdd47a006c02e624f08f992a0b761 and contender = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1. f1dc9698dad0fbcb28c404118

[GitHub] [arrow] ursabot commented on pull request #12203: ARROW-15387 [R] Un-skip chunked array test for decimal256()

2022-01-27 Thread GitBox
ursabot commented on pull request #12203: URL: https://github.com/apache/arrow/pull/12203#issuecomment-1023241065 Benchmark runs are scheduled for baseline = ce0964ed1eeb1881ddae3e84a8860316538ef0b7 and contender = 2e6ff658dd95be0ed4375914d055fa758af0d42c. 2e6ff658dd95be0ed4375914d055fa75

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-27 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r793617156 ## File path: cpp/src/arrow/compute/api_scalar.h ## @@ -1350,5 +1375,20 @@ ARROW_EXPORT Result AssumeTimezone(const Datum& values,

[GitHub] [arrow] ursabot edited a comment on pull request #12203: ARROW-15387 [R] Un-skip chunked array test for decimal256()

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12203: URL: https://github.com/apache/arrow/pull/12203#issuecomment-1023241065 Benchmark runs are scheduled for baseline = ce0964ed1eeb1881ddae3e84a8860316538ef0b7 and contender = 2e6ff658dd95be0ed4375914d055fa758af0d42c. 2e6ff658dd95be0ed4375914d

[GitHub] [arrow-julia] NHDaly commented on issue #261: `pyarrow` unable to load Arrow data written by `Arrow.jl`

2022-01-27 Thread GitBox
NHDaly commented on issue #261: URL: https://github.com/apache/arrow-julia/issues/261#issuecomment-1023252549 👍 thanks both for the very clear discussion. :) We were also trying to parse the arrow from Python, and we independently ran into the same thing 😁 😅 +1 for adding a note abo

[GitHub] [arrow] nealrichardson commented on a change in pull request #11730: ARROW-14745: [R] Enable true duckdb streaming

2022-01-27 Thread GitBox
nealrichardson commented on a change in pull request #11730: URL: https://github.com/apache/arrow/pull/11730#discussion_r793660623 ## File path: r/R/duckdb.R ## @@ -155,6 +154,5 @@ to_arrow <- function(.data) { # Run the query res <- DBI::dbSendQuery(dbplyr::remote_con(.d

[GitHub] [arrow] nealrichardson commented on a change in pull request #11730: ARROW-14745: [R] Enable true duckdb streaming

2022-01-27 Thread GitBox
nealrichardson commented on a change in pull request #11730: URL: https://github.com/apache/arrow/pull/11730#discussion_r793661589 ## File path: r/R/duckdb.R ## @@ -155,6 +154,5 @@ to_arrow <- function(.data) { # Run the query res <- DBI::dbSendQuery(dbplyr::remote_con(.d

[GitHub] [arrow] Crystrix commented on pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2022-01-27 Thread GitBox
Crystrix commented on pull request #12032: URL: https://github.com/apache/arrow/pull/12032#issuecomment-1023270334 > @Crystrix sorry, it looks like merging your other PR means this one needs rebasing now @lidavidm, the rebasing is done. -- This is an automated message from the

[GitHub] [arrow] pitrou opened a new pull request #12276: ARROW-15461: [C++] Avoid clang bug in ReverseBitmap

2022-01-27 Thread GitBox
pitrou opened a new pull request #12276: URL: https://github.com/apache/arrow/pull/12276 Clang 12 would generate buggy code for the `GetReversedBlock` utility function. (see report in https://github.com/llvm/llvm-project/issues/53421) Rewrite it in a more optimized way, also circu

[GitHub] [arrow] pitrou commented on pull request #12276: ARROW-15461: [C++] Avoid clang bug in ReverseBitmap

2022-01-27 Thread GitBox
pitrou commented on pull request #12276: URL: https://github.com/apache/arrow/pull/12276#issuecomment-1023276154 @github-actions crossbow submit -g cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] pitrou commented on pull request #12276: ARROW-15461: [C++] Avoid clang bug in ReverseBitmap

2022-01-27 Thread GitBox
pitrou commented on pull request #12276: URL: https://github.com/apache/arrow/pull/12276#issuecomment-1023276616 @kszucs : potential candidate for 7.0.0 :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] github-actions[bot] commented on pull request #12276: ARROW-15461: [C++] Avoid clang bug in ReverseBitmap

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #12276: URL: https://github.com/apache/arrow/pull/12276#issuecomment-1023277314 https://issues.apache.org/jira/browse/ARROW-15461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] github-actions[bot] commented on pull request #12276: ARROW-15461: [C++] Avoid clang bug in ReverseBitmap

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #12276: URL: https://github.com/apache/arrow/pull/12276#issuecomment-1023279528 Revision: ba8b4de98092275e1bf8b339b9b4c2b3a8939fc1 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1509](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] pitrou commented on pull request #12273: ARROW-15435: [C++][Doc] Improve API docs coverage

2022-01-27 Thread GitBox
pitrou commented on pull request #12273: URL: https://github.com/apache/arrow/pull/12273#issuecomment-1023282116 Conflicts fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] pitrou commented on pull request #12252: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-27 Thread GitBox
pitrou commented on pull request #12252: URL: https://github.com/apache/arrow/pull/12252#issuecomment-1023284508 Should this be closed now that #12263 has been merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] pitrou commented on pull request #12105: ARROW-14098: [C++] subtract(time, time) -> duration kernel

2022-01-27 Thread GitBox
pitrou commented on pull request #12105: URL: https://github.com/apache/arrow/pull/12105#issuecomment-1023286752 Hmm, can you look at the test failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] pitrou commented on a change in pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r793681883 ## File path: cpp/src/arrow/compute/kernels/scalar_compare.cc ## @@ -746,6 +808,279 @@ std::shared_ptr MakeScalarMinMax(std::string name, return func;

[GitHub] [arrow] okadakk commented on a change in pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-27 Thread GitBox
okadakk commented on a change in pull request #12271: URL: https://github.com/apache/arrow/pull/12271#discussion_r793684657 ## File path: c_glib/arrow-glib/compute.cpp ## @@ -5192,3 +5301,21 @@ garrow_round_to_multiple_options_get_raw(GArrowRoundToMultipleOptions *options)

[GitHub] [arrow] okadakk commented on a change in pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-27 Thread GitBox
okadakk commented on a change in pull request #12271: URL: https://github.com/apache/arrow/pull/12271#discussion_r793684657 ## File path: c_glib/arrow-glib/compute.cpp ## @@ -5192,3 +5301,21 @@ garrow_round_to_multiple_options_get_raw(GArrowRoundToMultipleOptions *options)

[GitHub] [arrow] okadakk commented on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-27 Thread GitBox
okadakk commented on pull request #12271: URL: https://github.com/apache/arrow/pull/12271#issuecomment-1023292758 @kou Thank you for reviewing! I faced an unsolvable problem... Could you tell me how to fix it? -- This is an automated message from the Apache Git Service. To r

[GitHub] [arrow] lidavidm commented on pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2022-01-27 Thread GitBox
lidavidm commented on pull request #12032: URL: https://github.com/apache/arrow/pull/12032#issuecomment-1023294426 @github-actions autotune -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] thisisnic commented on a change in pull request #12083: ARROW-14744: [R] open_dataset() error when `schema` argument supplied, but `column_names` not supplied to `CSVReadOptions`

2022-01-27 Thread GitBox
thisisnic commented on a change in pull request #12083: URL: https://github.com/apache/arrow/pull/12083#discussion_r793688513 ## File path: r/R/dataset-format.R ## @@ -122,6 +122,30 @@ CsvFileFormat$create <- function(..., opts = csv_file_forma

[GitHub] [arrow-julia] NHDaly commented on issue #279: New package release process

2022-01-27 Thread GitBox
NHDaly commented on issue #279: URL: https://github.com/apache/arrow-julia/issues/279#issuecomment-1023310925 > would the maintainer that triggered `@JuliaReleaseVote` pass in the intended bump , i.e. `@JuliaReleaseVote register patch` or `@JuliaReleaseVote register("patch")` or something

[GitHub] [arrow] okadakk commented on pull request #12269: ARROW-15462: [GLib] Add GArrow{Month,DayTime,MonthDayNano}Interval{Scalar,Array,ArrayBuilder}

2022-01-27 Thread GitBox
okadakk commented on pull request #12269: URL: https://github.com/apache/arrow/pull/12269#issuecomment-1023317305 @kou Thank you reviewing! I add interval.{h, hpp} to arrow-glib.{h, hpp} and fixed order! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-27 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r793703981 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -428,6 +428,273 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow] jorisvandenbossche commented on pull request #12215: ARROW-14101: [C++] multiply(duration, integer) -> duration kernel

2022-01-27 Thread GitBox
jorisvandenbossche commented on pull request #12215: URL: https://github.com/apache/arrow/pull/12215#issuecomment-1023321980 For the `mutiply_checked`, should we add a test for a duration that would go out of bounds? Or is this already sufficiently covered by integer `multiply_checked` tes

[GitHub] [arrow] jorisvandenbossche commented on pull request #12137: ARROW-14095: [C++] subtract(timestamp, duration) -> timestamp kernel

2022-01-27 Thread GitBox
jorisvandenbossche commented on pull request #12137: URL: https://github.com/apache/arrow/pull/12137#issuecomment-1023324209 This is now a test only change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] pitrou commented on a change in pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r793690969 ## File path: cpp/src/arrow/compute/kernels/scalar_compare.cc ## @@ -156,39 +212,49 @@ struct Maximum { } }; +// Check if timestamp timezones are com

[GitHub] [arrow] pitrou closed pull request #12273: ARROW-15435: [C++][Doc] Improve API docs coverage

2022-01-27 Thread GitBox
pitrou closed pull request #12273: URL: https://github.com/apache/arrow/pull/12273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] pitrou commented on pull request #11956: ARROW-10456: [R] Implement MapType and MapArray

2022-01-27 Thread GitBox
pitrou commented on pull request #11956: URL: https://github.com/apache/arrow/pull/11956#issuecomment-1023335788 Some conflicts need to be fixed. Also @thisisnic or @jonkeane can one of you give this a final review? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow-cookbook] davisusanibar opened a new pull request #137: [Java]: Java cookbook for create arrow flight

2022-01-27 Thread GitBox
davisusanibar opened a new pull request #137: URL: https://github.com/apache/arrow-cookbook/pull/137 [Java]: Java cookbook for create arrow read/write IPC format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] ursabot commented on pull request #12273: ARROW-15435: [C++][Doc] Improve API docs coverage

2022-01-27 Thread GitBox
ursabot commented on pull request #12273: URL: https://github.com/apache/arrow/pull/12273#issuecomment-1023337633 Benchmark runs are scheduled for baseline = 2e6ff658dd95be0ed4375914d055fa758af0d42c and contender = 816c986753dc1b7fd85934d703ad4d88abe38424. 816c986753dc1b7fd85934d703ad4d88

[GitHub] [arrow] bkmgit commented on a change in pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-01-27 Thread GitBox
bkmgit commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r793731000 ## File path: cpp/src/arrow/compute/kernels/scalar_compare.cc ## @@ -156,39 +212,49 @@ struct Maximum { } }; +// Check if timestamp timezones are com

[GitHub] [arrow-cookbook] davisusanibar commented on pull request #136: [Java]: Java cookbook for create arrow read/write IPC format

2022-01-27 Thread GitBox
davisusanibar commented on pull request #136: URL: https://github.com/apache/arrow-cookbook/pull/136#issuecomment-1023341908 https://issues.apache.org/jira/browse/ARROW-14882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow] bkmgit commented on a change in pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-01-27 Thread GitBox
bkmgit commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r793732155 ## File path: cpp/src/arrow/compute/kernels/scalar_compare.cc ## @@ -746,6 +805,199 @@ std::shared_ptr MakeScalarMinMax(std::string name, return func;

[GitHub] [arrow] bkmgit commented on a change in pull request #11882: ARROW-9843: [C++][Python] Implement Between ternary kernel and Python bindings

2022-01-27 Thread GitBox
bkmgit commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r793735145 ## File path: cpp/src/arrow/compute/kernels/scalar_compare_test.cc ## @@ -1865,5 +1928,654 @@ TEST(TestMaxElementWiseMinElementWise, CommonTemporal) {

[GitHub] [arrow] lidavidm commented on a change in pull request #12239: ARROW-15374: [C++][FlightRPC] Add support for MemoryManager in data methods

2022-01-27 Thread GitBox
lidavidm commented on a change in pull request #12239: URL: https://github.com/apache/arrow/pull/12239#discussion_r793736383 ## File path: cpp/src/arrow/flight/flight_cuda_test.cc ## @@ -0,0 +1,201 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [arrow] pitrou commented on a change in pull request #12198: ARROW-15386: [Integration] Unskip test cases

2022-01-27 Thread GitBox
pitrou commented on a change in pull request #12198: URL: https://github.com/apache/arrow/pull/12198#discussion_r793738446 ## File path: dev/archery/archery/integration/datagen.py ## @@ -1618,10 +1614,13 @@ def _temp_path(): .skip_category('Go') .skip_category

[GitHub] [arrow-rs] matthewmturner opened a new pull request #1243: Remove Copy trait from dyn scalar kernels

2022-01-27 Thread GitBox
matthewmturner opened a new pull request #1243: URL: https://github.com/apache/arrow-rs/pull/1243 # Which issue does this PR close? No existing issue. # Rationale for this change In the context of https://github.com/apache/arrow-datafusion/pull/1685 I am trying to use

[GitHub] [arrow] rok commented on pull request #12137: ARROW-14095: [C++] subtract(timestamp, duration) -> timestamp kernel

2022-01-27 Thread GitBox
rok commented on pull request #12137: URL: https://github.com/apache/arrow/pull/12137#issuecomment-1023357606 @jorisvandenbossche It would appear test + doc only yes. [ARROW-14095](https://github.com/apache/arrow/pull/12136/files#diff-3eafd7246f6a8c699f10d46e3276852fe44b6853b5517ef10396e561

[GitHub] [arrow] thisisnic commented on a change in pull request #12083: ARROW-14744: [R] open_dataset() error when `schema` argument supplied, but `column_names` not supplied to `CSVReadOptions`

2022-01-27 Thread GitBox
thisisnic commented on a change in pull request #12083: URL: https://github.com/apache/arrow/pull/12083#discussion_r793747392 ## File path: r/R/dataset-format.R ## @@ -122,6 +122,27 @@ CsvFileFormat$create <- function(..., opts = csv_file_forma

[GitHub] [arrow] ursabot edited a comment on pull request #12238: ARROW-15427: [C++][Gandiva] Use a lock guard to hold a mutex

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12238: URL: https://github.com/apache/arrow/pull/12238#issuecomment-1023048351 Benchmark runs are scheduled for baseline = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1 and contender = 3cc48bea05f7752e0b6f3adb3fb45bef840b09ae. 3cc48bea05f7752e0b6f3adb3

[GitHub] [arrow] rok commented on pull request #12215: ARROW-14101: [C++] multiply(duration, integer) -> duration kernel

2022-01-27 Thread GitBox
rok commented on pull request #12215: URL: https://github.com/apache/arrow/pull/12215#issuecomment-1023358897 > For the `mutiply_checked`, should we add a test for a duration that would go out of bounds? Or is this already sufficiently covered by integer `multiply_checked` tests if that is

[GitHub] [arrow] ursabot edited a comment on pull request #12273: ARROW-15435: [C++][Doc] Improve API docs coverage

2022-01-27 Thread GitBox
ursabot edited a comment on pull request #12273: URL: https://github.com/apache/arrow/pull/12273#issuecomment-1023337633 Benchmark runs are scheduled for baseline = 2e6ff658dd95be0ed4375914d055fa758af0d42c and contender = 816c986753dc1b7fd85934d703ad4d88abe38424. 816c986753dc1b7fd85934d70

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12268: ARROW-15485: [Release][Java] Fix java jars upload script

2022-01-27 Thread GitBox
github-actions[bot] removed a comment on pull request #12268: URL: https://github.com/apache/arrow/pull/12268#issuecomment-1022112632 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Coul

[GitHub] [arrow] github-actions[bot] commented on pull request #12268: ARROW-15485: [Release][Java] Fix java jars upload script

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #12268: URL: https://github.com/apache/arrow/pull/12268#issuecomment-1023367285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1243: Remove Copy trait from dyn scalar kernels

2022-01-27 Thread GitBox
codecov-commenter commented on pull request #1243: URL: https://github.com/apache/arrow-rs/pull/1243#issuecomment-1023367497 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow] kszucs commented on pull request #12268: ARROW-15485: [Release][Java] Fix java jars upload script

2022-01-27 Thread GitBox
kszucs commented on pull request #12268: URL: https://github.com/apache/arrow/pull/12268#issuecomment-1023367978 > Ah, is the previous pom's information used without this? Yes, it created signatures for non-existent files by not zeroing out those variables. -- This is an automated

[GitHub] [arrow] pitrou commented on pull request #12055: ARROW-11989: [C++][Python] Improve ChunkedArray's complexity for the access of elements

2022-01-27 Thread GitBox
pitrou commented on pull request #12055: URL: https://github.com/apache/arrow/pull/12055#issuecomment-1023368737 @edponce Are you willing to push this forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

  1   2   3   >