[GitHub] [arrow] kou commented on a change in pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-28 Thread GitBox
kou commented on a change in pull request #12271: URL: https://github.com/apache/arrow/pull/12271#discussion_r794293854 ## File path: c_glib/arrow-glib/compute.cpp ## @@ -5192,3 +5301,21 @@ garrow_round_to_multiple_options_get_raw(GArrowRoundToMultipleOptions *options) retu

[GitHub] [arrow] cyb70289 opened a new pull request #12280: ARROW-15493: [C++][Gandiva] Init ExpressionCacheKey.mode_

2022-01-28 Thread GitBox
cyb70289 opened a new pull request #12280: URL: https://github.com/apache/arrow/pull/12280 Class member mode_ is not initialized in one of ExpressionCacheKey constructors, but it is used to compare equality of two instances. It causes flaky gandiva-filter-test failures. -- This is a

[GitHub] [arrow] ursabot edited a comment on pull request #12263: ARROW-15438: [Python] Flaky test test_write_dataset_max_open_files

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12263: URL: https://github.com/apache/arrow/pull/12263#issuecomment-1023048330 Benchmark runs are scheduled for baseline = 79800d4a374586a1e66bb85fc05966066ba2199a and contender = 5a51c6d2f83cdd47a006c02e624f08f992a0b761. 5a51c6d2f83cdd47a006c02e6

[GitHub] [arrow] github-actions[bot] commented on pull request #12280: ARROW-15493: [C++][Gandiva] Init ExpressionCacheKey.mode_

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12280: URL: https://github.com/apache/arrow/pull/12280#issuecomment-1023993789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] tustvold commented on issue #1032: Reduce Public Parquet API

2022-01-28 Thread GitBox
tustvold commented on issue #1032: URL: https://github.com/apache/arrow-rs/issues/1032#issuecomment-1023995119 @asayers thank you for reporting, I'll take a look later today and see what we can do 👍 -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [arrow] ursabot edited a comment on pull request #12268: ARROW-15485: [Release][Java] Fix java jars upload script

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12268: URL: https://github.com/apache/arrow/pull/12268#issuecomment-1023670703 Benchmark runs are scheduled for baseline = 11f31839963077e5c793b040b1901f43812bbfe1 and contender = b1ae6029687aa3bb756c61a189c88125128cf026. b1ae6029687aa3bb756c61a18

[GitHub] [arrow] westonpace closed pull request #12160: ARROW-13467: [C++] Support delta dictionaries in the IPC file format

2022-01-28 Thread GitBox
westonpace closed pull request #12160: URL: https://github.com/apache/arrow/pull/12160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [arrow-julia] kou commented on issue #279: New package release process

2022-01-28 Thread GitBox
kou commented on issue #279: URL: https://github.com/apache/arrow-julia/issues/279#issuecomment-1024000808 It seems that we can run test in source archive by the following: ```console $ wget https://github.com/apache/arrow-julia/archive/refs/tags/v2.2.0.tar.gz $ tar xvf v2.2.0.t

[GitHub] [arrow] ursabot commented on pull request #12160: ARROW-13467: [C++] Support delta dictionaries in the IPC file format

2022-01-28 Thread GitBox
ursabot commented on pull request #12160: URL: https://github.com/apache/arrow/pull/12160#issuecomment-1024007598 Benchmark runs are scheduled for baseline = 8905de9b3db1667eff7678a3cad2de0b64ff46bf and contender = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1. 3663971f17cc5cc32bb389ad959eb5b3

[GitHub] [arrow-julia] kou edited a comment on issue #279: New package release process

2022-01-28 Thread GitBox
kou edited a comment on issue #279: URL: https://github.com/apache/arrow-julia/issues/279#issuecomment-1023959150 @quinnj Thanks for proposing new release process! It seems that this process doesn't satisfy https://www.apache.org/legal/release-policy.html (see also https://infra.apa

[GitHub] [arrow] kou closed pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-28 Thread GitBox
kou closed pull request #12271: URL: https://github.com/apache/arrow/pull/12271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow] ursabot commented on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-28 Thread GitBox
ursabot commented on pull request #12271: URL: https://github.com/apache/arrow/pull/12271#issuecomment-1024014621 Benchmark runs are scheduled for baseline = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1 and contender = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67. c692c8842a959c2af0e68bc2f20f72d5

[GitHub] [arrow] ursabot edited a comment on pull request #12160: ARROW-13467: [C++] Support delta dictionaries in the IPC file format

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12160: URL: https://github.com/apache/arrow/pull/12160#issuecomment-1024007598 Benchmark runs are scheduled for baseline = 8905de9b3db1667eff7678a3cad2de0b64ff46bf and contender = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1. 3663971f17cc5cc32bb389ad9

[GitHub] [arrow] ursabot edited a comment on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12271: URL: https://github.com/apache/arrow/pull/12271#issuecomment-1024014621 Benchmark runs are scheduled for baseline = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1 and contender = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67. c692c8842a959c2af0e68bc2f

[GitHub] [arrow-julia] kiszk commented on issue #279: New package release process

2022-01-28 Thread GitBox
kiszk commented on issue #279: URL: https://github.com/apache/arrow-julia/issues/279#issuecomment-1024033019 For all of the Apache projects, ASF defines the common rules for releasing the package. As @kou refers, it would be good to read documents at https://www.apache.org/legal/

[GitHub] [arrow] Crystrix commented on pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2022-01-28 Thread GitBox
Crystrix commented on pull request #12032: URL: https://github.com/apache/arrow/pull/12032#issuecomment-1024033265 @lidavidm, new builds are triggered, the failure should be irrelevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [arrow] kou commented on pull request #12269: ARROW-15462: [GLib] Add GArrow{Month,DayTime,MonthDayNano}Interval{Scalar,Array,ArrayBuilder}

2022-01-28 Thread GitBox
kou commented on pull request #12269: URL: https://github.com/apache/arrow/pull/12269#issuecomment-1024046035 Thanks. I've pushed fixes for the followings: * Long line * Indent * Poor spec description It seems that we need auto formatter... TODO: Review tests.

[GitHub] [arrow] kou commented on pull request #12269: ARROW-15462: [GLib] Add GArrow{Month,DayTime,MonthDayNano}Interval{Scalar,Array,ArrayBuilder}

2022-01-28 Thread GitBox
kou commented on pull request #12269: URL: https://github.com/apache/arrow/pull/12269#issuecomment-1024047245 Could you rebase on master after you pull my changes to remove diffs for `version.h.in` from this pull request? -- This is an automated message from the Apache Git Service. To re

[GitHub] [arrow] pitrou commented on pull request #12276: ARROW-15461: [C++] Avoid clang bug in ReverseBitmap

2022-01-28 Thread GitBox
pitrou commented on pull request #12276: URL: https://github.com/apache/arrow/pull/12276#issuecomment-1024049307 > Is valgrind job error due to timeout? Yes, unfortunately. You can run it locally using `archery docker run conda-cpp-valgrind`, IIRC. -- This is an automated message

[GitHub] [arrow] ursabot edited a comment on pull request #12276: ARROW-15461: [C++] Avoid clang bug in ReverseBitmap

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12276: URL: https://github.com/apache/arrow/pull/12276#issuecomment-1023885081 Benchmark runs are scheduled for baseline = b1ae6029687aa3bb756c61a189c88125128cf026 and contender = 8905de9b3db1667eff7678a3cad2de0b64ff46bf. 8905de9b3db1667eff7678a3c

[GitHub] [arrow-datafusion] yjshen opened a new pull request #1691: Add `MemTrackingMetrics` to ease memory tracking for non-limited memory consumers

2022-01-28 Thread GitBox
yjshen opened a new pull request #1691: URL: https://github.com/apache/arrow-datafusion/pull/1691 # Which issue does this PR close? Closes #1569. # Rationale for this change The kinds of requesting memory consumers are pretty limited. As shown in #587, we only have 3 o

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1691: Add `MemTrackingMetrics` to ease memory tracking for non-limited memory consumers

2022-01-28 Thread GitBox
yjshen commented on a change in pull request #1691: URL: https://github.com/apache/arrow-datafusion/pull/1691#discussion_r794407926 ## File path: datafusion/src/physical_plan/sorts/sort.rs ## @@ -139,41 +143,43 @@ impl ExternalSorter { let stream = read_spill_a

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1691: Add `MemTrackingMetrics` to ease memory tracking for non-limited memory consumers

2022-01-28 Thread GitBox
yjshen commented on a change in pull request #1691: URL: https://github.com/apache/arrow-datafusion/pull/1691#discussion_r794407926 ## File path: datafusion/src/physical_plan/sorts/sort.rs ## @@ -139,41 +143,43 @@ impl ExternalSorter { let stream = read_spill_a

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1691: Add `MemTrackingMetrics` to ease memory tracking for non-limited memory consumers

2022-01-28 Thread GitBox
yjshen commented on a change in pull request #1691: URL: https://github.com/apache/arrow-datafusion/pull/1691#discussion_r794407926 ## File path: datafusion/src/physical_plan/sorts/sort.rs ## @@ -139,41 +143,43 @@ impl ExternalSorter { let stream = read_spill_a

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #1691: Add `MemTrackingMetrics` to ease memory tracking for non-limited memory consumers

2022-01-28 Thread GitBox
yjshen commented on a change in pull request #1691: URL: https://github.com/apache/arrow-datafusion/pull/1691#discussion_r794407926 ## File path: datafusion/src/physical_plan/sorts/sort.rs ## @@ -139,41 +143,43 @@ impl ExternalSorter { let stream = read_spill_a

[GitHub] [arrow] ursabot edited a comment on pull request #12241: ARROW-15390: [Dev][C++][Doc] Document the GDB extension

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12241: URL: https://github.com/apache/arrow/pull/12241#issuecomment-1023048342 Benchmark runs are scheduled for baseline = 5a51c6d2f83cdd47a006c02e624f08f992a0b761 and contender = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1. f1dc9698dad0fbcb28c404118

[GitHub] [arrow-rs] alamb commented on issue #1032: Reduce Public Parquet API

2022-01-28 Thread GitBox
alamb commented on issue #1032: URL: https://github.com/apache/arrow-rs/issues/1032#issuecomment-1024116811 IOx did as well https://github.com/influxdata/influxdb_iox/blob/main/parquet_file/Cargo.toml#L20 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1687: Make `SortPreservingMergeStream` stable on input stream order

2022-01-28 Thread GitBox
alamb commented on a change in pull request #1687: URL: https://github.com/apache/arrow-datafusion/pull/1687#discussion_r794414913 ## File path: datafusion/src/physical_plan/sorts/sort_preserving_merge.rs ## @@ -58,6 +58,27 @@ use crate::physical_plan::{ /// provided each part

[GitHub] [arrow] kszucs commented on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
kszucs commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024123179 @github-actions crossbow submit verify-rc-source-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow] github-actions[bot] commented on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024123107 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow] github-actions[bot] commented on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024124036 Revision: e8b6e3274c91a35fd4e634a95df76c6e4103a5b9 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1513](https://github.com/ursacomputing/crossbo

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1687: Make `SortPreservingMergeStream` stable on input stream order

2022-01-28 Thread GitBox
xudong963 commented on a change in pull request #1687: URL: https://github.com/apache/arrow-datafusion/pull/1687#discussion_r794425301 ## File path: datafusion/src/physical_plan/sorts/sort_preserving_merge.rs ## @@ -58,6 +58,27 @@ use crate::physical_plan::{ /// provided each

[GitHub] [arrow-rs] alamb merged pull request #1242: Rename the function `len` to `bit_len` for `Bitmap`

2022-01-28 Thread GitBox
alamb merged pull request #1242: URL: https://github.com/apache/arrow-rs/pull/1242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-rs] alamb closed issue #1233: Rename `Bitmap::len` to `Bitmap::bit_len`

2022-01-28 Thread GitBox
alamb closed issue #1233: URL: https://github.com/apache/arrow-rs/issues/1233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-datafusion] alamb commented on issue #1690: DiskManager and TempFiles getting created several times per query

2022-01-28 Thread GitBox
alamb commented on issue #1690: URL: https://github.com/apache/arrow-datafusion/issues/1690#issuecomment-1024137010 cc @yjshen I plan to work on these items today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] kszucs commented on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
kszucs commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024138684 @github-actions crossbow submit verify-rc-source-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow] kszucs removed a comment on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
kszucs removed a comment on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024139135 github-actions crossbow submit --group verify-rc-source --param release=7.0.0 --param rc=8 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [arrow] kszucs commented on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
kszucs commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024139135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [arrow] github-actions[bot] commented on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024139496 Revision: 39a7b945d4891cec2fbd6e79ac99e5658dbb1076 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1514](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] github-actions[bot] commented on pull request #12281: [Dev][Release] Nightly source verification

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024139966 Revision: 39a7b945d4891cec2fbd6e79ac99e5658dbb1076 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1515](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] github-actions[bot] commented on pull request #12281: ARROW-15483: [Release] Exercise source verification builds on a nightly basis

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024142214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] github-actions[bot] removed a comment on pull request #12281: ARROW-15483: [Release] Exercise source verification builds on a nightly basis

2022-01-28 Thread GitBox
github-actions[bot] removed a comment on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024123107 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Coul

[GitHub] [arrow-datafusion] alamb opened a new issue #1692: Support predicate pruning on `CaseExpr` expressions

2022-01-28 Thread GitBox
alamb opened a new issue #1692: URL: https://github.com/apache/arrow-datafusion/issues/1692 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** In certain situations , IOx is likely going to make predicates that look like the followi

[GitHub] [arrow] kszucs commented on pull request #12281: ARROW-15483: [Release] Exercise source verification builds on a nightly basis

2022-01-28 Thread GitBox
kszucs commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024147227 @github-actions crossbow submit verify-rc-source-csharp-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] kszucs closed pull request #12280: ARROW-15493: [C++][Gandiva] Init ExpressionCacheKey.mode_

2022-01-28 Thread GitBox
kszucs closed pull request #12280: URL: https://github.com/apache/arrow/pull/12280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] github-actions[bot] commented on pull request #12281: ARROW-15483: [Release] Exercise source verification builds on a nightly basis

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12281: URL: https://github.com/apache/arrow/pull/12281#issuecomment-1024147933 Revision: f4e0cad3eeb26d72c9238cbff6fc4d7b57ef3632 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1516](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] ursabot commented on pull request #12280: ARROW-15493: [C++][Gandiva] Init ExpressionCacheKey.mode_

2022-01-28 Thread GitBox
ursabot commented on pull request #12280: URL: https://github.com/apache/arrow/pull/12280#issuecomment-1024148552 Benchmark runs are scheduled for baseline = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67 and contender = a27c55660e575a3987283d5d9e443642db48f215. a27c55660e575a3987283d5d9e443642

[GitHub] [arrow-rs] tustvold opened a new pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental

2022-01-28 Thread GitBox
tustvold opened a new pull request #1244: URL: https://github.com/apache/arrow-rs/pull/1244 # Which issue does this PR close? Closes #1032 # Rationale for this change #1134 was a tad overzealous and moved some functionality behind the experimental flags that downstream

[GitHub] [arrow-datafusion] alamb opened a new issue #1693: Expression Simplification for`Expr::Case` expressions

2022-01-28 Thread GitBox
alamb opened a new issue #1693: URL: https://github.com/apache/arrow-datafusion/issues/1693 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** In certain situations , IOx is likely going to make predicates that look like the followi

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1244: Revert making parquet::data_type and parquet::arrow::schema experimental

2022-01-28 Thread GitBox
codecov-commenter commented on pull request #1244: URL: https://github.com/apache/arrow-rs/pull/1244#issuecomment-1024162244 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1244?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow] ursabot edited a comment on pull request #12160: ARROW-13467: [C++] Support delta dictionaries in the IPC file format

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12160: URL: https://github.com/apache/arrow/pull/12160#issuecomment-1024007598 Benchmark runs are scheduled for baseline = 8905de9b3db1667eff7678a3cad2de0b64ff46bf and contender = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1. 3663971f17cc5cc32bb389ad9

[GitHub] [arrow] ursabot edited a comment on pull request #12280: ARROW-15493: [C++][Gandiva] Init ExpressionCacheKey.mode_

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12280: URL: https://github.com/apache/arrow/pull/12280#issuecomment-1024148552 Benchmark runs are scheduled for baseline = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67 and contender = a27c55660e575a3987283d5d9e443642db48f215. a27c55660e575a3987283d5d9

[GitHub] [arrow-datafusion] alamb opened a new issue #1694: Public Expr simplification API

2022-01-28 Thread GitBox
alamb opened a new issue #1694: URL: https://github.com/apache/arrow-datafusion/issues/1694 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** In IOx each table is broken up logically into chunks (like row groups in parquet files) b

[GitHub] [arrow] rok commented on pull request #11889: ARROW-14708: [C++] Adding missing abseil dependencies to enable static flight build

2022-01-28 Thread GitBox
rok commented on pull request #11889: URL: https://github.com/apache/arrow/pull/11889#issuecomment-1024181485 @kou I'm still working on the missing symbols, please don't merge :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [arrow] kszucs merged pull request #12282: MINOR: [Release][Python] Disable gdb tests in windows wheel and source verification builds

2022-01-28 Thread GitBox
kszucs merged pull request #12282: URL: https://github.com/apache/arrow/pull/12282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-28 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r794491952 ## File path: cpp/src/arrow/compute/kernels/scalar_nested_test.cc ## @@ -225,6 +225,423 @@ TEST(TestScalarNested, StructField) { } } +void CheckMap

[GitHub] [arrow] dhruv9vats commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-28 Thread GitBox
dhruv9vats commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r794508978 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -428,6 +428,271 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArra

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-28 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r794509929 ## File path: cpp/src/arrow/compute/kernels/scalar_nested.cc ## @@ -428,6 +428,271 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a StructArray"

[GitHub] [arrow] ursabot edited a comment on pull request #12238: ARROW-15427: [C++][Gandiva] Use a lock guard to hold a mutex

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12238: URL: https://github.com/apache/arrow/pull/12238#issuecomment-1023048351 Benchmark runs are scheduled for baseline = f1dc9698dad0fbcb28c4041185bb8bc56e96aee1 and contender = 3cc48bea05f7752e0b6f3adb3fb45bef840b09ae. 3cc48bea05f7752e0b6f3adb3

[GitHub] [arrow] lidavidm commented on a change in pull request #12014: ARROW-10924: [C++] Validate temporal data in ValidateArrayFull

2022-01-28 Thread GitBox
lidavidm commented on a change in pull request #12014: URL: https://github.com/apache/arrow/pull/12014#discussion_r794516464 ## File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc ## @@ -1652,13 +1693,7 @@ TEST(GroupBy, MinMaxTypes) { field("hash_mi

[GitHub] [arrow] lidavidm commented on pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2022-01-28 Thread GitBox
lidavidm commented on pull request #12032: URL: https://github.com/apache/arrow/pull/12032#issuecomment-1024247801 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] lidavidm closed pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2022-01-28 Thread GitBox
lidavidm closed pull request #12032: URL: https://github.com/apache/arrow/pull/12032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] ursabot commented on pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2022-01-28 Thread GitBox
ursabot commented on pull request #12032: URL: https://github.com/apache/arrow/pull/12032#issuecomment-1024252094 Benchmark runs are scheduled for baseline = d035ff048a3d87d39746f8559fe09010a2961599 and contender = 39367db2dab321dbbf4d12d2229020614b049dde. 39367db2dab321dbbf4d12d222902061

[GitHub] [arrow] ursabot edited a comment on pull request #12271: ARROW-15463: [GLib] Add arrow::compute::Utf8NormalizeOptions bindings

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12271: URL: https://github.com/apache/arrow/pull/12271#issuecomment-1024014621 Benchmark runs are scheduled for baseline = 3663971f17cc5cc32bb389ad959eb5b30dacb1e1 and contender = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67. c692c8842a959c2af0e68bc2f

[GitHub] [arrow] lidavidm commented on a change in pull request #12162: ARROW-15089: [C++][Compute] Implement kernel to lookup a MapArray item for a given key

2022-01-28 Thread GitBox
lidavidm commented on a change in pull request #12162: URL: https://github.com/apache/arrow/pull/12162#discussion_r794532289 ## File path: docs/source/python/api/compute.rst ## @@ -504,6 +505,7 @@ Compute Options IndexOptions JoinOptions MakeStructOptions + MapArr

[GitHub] [arrow] jonkeane commented on a change in pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-28 Thread GitBox
jonkeane commented on a change in pull request #12170: URL: https://github.com/apache/arrow/pull/12170#discussion_r791867264 ## File path: r/R/dataset-format.R ## @@ -309,14 +309,57 @@ FileWriteOptions <- R6Class("FileWriteOptions", inherit = ArrowObject, public = list(

[GitHub] [arrow] ursabot edited a comment on pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12032: URL: https://github.com/apache/arrow/pull/12032#issuecomment-1024252094 Benchmark runs are scheduled for baseline = d035ff048a3d87d39746f8559fe09010a2961599 and contender = 39367db2dab321dbbf4d12d2229020614b049dde. 39367db2dab321dbbf4d12d22

[GitHub] [arrow] lidavidm commented on a change in pull request #12124: ARROW-14093: [C++] subtract(date, date) -> duration kernel

2022-01-28 Thread GitBox
lidavidm commented on a change in pull request #12124: URL: https://github.com/apache/arrow/pull/12124#discussion_r794550124 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc ## @@ -2437,14 +2462,35 @@ void RegisterScalarArithmetic(FunctionRegistry* registry) {

[GitHub] [arrow] lidavidm commented on a change in pull request #12137: ARROW-14095: [C++] subtract(timestamp, duration) -> timestamp kernel

2022-01-28 Thread GitBox
lidavidm commented on a change in pull request #12137: URL: https://github.com/apache/arrow/pull/12137#discussion_r794554238 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -1030,6 +1030,80 @@ TEST_F(ScalarTemporalTest, TestTemporalSubtractDateAndDura

[GitHub] [arrow] dragosmg commented on a change in pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-28 Thread GitBox
dragosmg commented on a change in pull request #12170: URL: https://github.com/apache/arrow/pull/12170#discussion_r794555446 ## File path: r/R/dataset-format.R ## @@ -309,14 +309,57 @@ FileWriteOptions <- R6Class("FileWriteOptions", inherit = ArrowObject, public = list(

[GitHub] [arrow] jonkeane commented on a change in pull request #11956: ARROW-10456: [R] Implement MapType and MapArray

2022-01-28 Thread GitBox
jonkeane commented on a change in pull request #11956: URL: https://github.com/apache/arrow/pull/11956#discussion_r794551527 ## File path: r/tests/testthat/test-data-type.R ## @@ -367,6 +367,46 @@ test_that("list type works as expected", { expect_equal(x$value_field, field("

[GitHub] [arrow-datafusion] alamb opened a new pull request #1695: Lazy TempDir creation in DiskManager

2022-01-28 Thread GitBox
alamb opened a new pull request #1695: URL: https://github.com/apache/arrow-datafusion/pull/1695 # Which issue does this PR close? Related https://github.com/apache/arrow-datafusion/issues/1690 First part of https://github.com/apache/arrow-datafusion/issues/1690: only do IO /

[GitHub] [arrow-datafusion] alamb commented on pull request #1695: Lazy TempDir creation in DiskManager

2022-01-28 Thread GitBox
alamb commented on pull request #1695: URL: https://github.com/apache/arrow-datafusion/pull/1695#issuecomment-1024282103 cc @yjshen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] lidavidm commented on a change in pull request #12139: ARROW-14097: [C++] subtract(time, duration) -> time kernel

2022-01-28 Thread GitBox
lidavidm commented on a change in pull request #12139: URL: https://github.com/apache/arrow/pull/12139#discussion_r794561816 ## File path: cpp/src/arrow/compute/kernels/scalar_cast_temporal.cc ## @@ -519,6 +521,16 @@ std::shared_ptr GetDurationCast() { // Between durations

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1684: Move `information_schema` tests out of execution/context.rs to `sql_integration` tests

2022-01-28 Thread GitBox
alamb commented on a change in pull request #1684: URL: https://github.com/apache/arrow-datafusion/pull/1684#discussion_r794569032 ## File path: datafusion/tests/sql/mod.rs ## @@ -693,6 +695,21 @@ fn make_timestamp_nano_table() -> Result> { make_timestamp_table::() } +/

[GitHub] [arrow-datafusion] alamb merged pull request #1684: Move `information_schema` tests out of execution/context.rs to `sql_integration` tests

2022-01-28 Thread GitBox
alamb merged pull request #1684: URL: https://github.com/apache/arrow-datafusion/pull/1684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [arrow] kszucs opened a new pull request #12283: [Release] Support release verification without a conda environment

2022-01-28 Thread GitBox
kszucs opened a new pull request #12283: URL: https://github.com/apache/arrow/pull/12283 Depends on #12281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [arrow] github-actions[bot] commented on pull request #12283: [Release] Support release verification without a conda environment

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12283: URL: https://github.com/apache/arrow/pull/12283#issuecomment-1024297030 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you op

[GitHub] [arrow] rok commented on a change in pull request #12137: ARROW-14095: [C++] subtract(timestamp, duration) -> timestamp kernel

2022-01-28 Thread GitBox
rok commented on a change in pull request #12137: URL: https://github.com/apache/arrow/pull/12137#discussion_r794575186 ## File path: docs/source/cpp/compute.rst ## @@ -450,9 +450,9 @@ Mixed time resolution temporal inputs will be cast to finest input resolution. +--

[GitHub] [arrow] rok commented on a change in pull request #12137: ARROW-14095: [C++] subtract(timestamp, duration) -> timestamp kernel

2022-01-28 Thread GitBox
rok commented on a change in pull request #12137: URL: https://github.com/apache/arrow/pull/12137#discussion_r794575325 ## File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc ## @@ -1030,6 +1030,80 @@ TEST_F(ScalarTemporalTest, TestTemporalSubtractDateAndDurationC

[GitHub] [arrow-datafusion] alamb opened a new pull request #1696: Alamb/move more code

2022-01-28 Thread GitBox
alamb opened a new pull request #1696: URL: https://github.com/apache/arrow-datafusion/pull/1696 # Which issue does this PR close? re https://github.com/apache/arrow-datafusion/issues/743 Follow on to https://github.com/apache/arrow-datafusion/pull/1684 Built on the gre

[GitHub] [arrow] wjones127 commented on pull request #11956: ARROW-10456: [R] Implement MapType and MapArray

2022-01-28 Thread GitBox
wjones127 commented on pull request #11956: URL: https://github.com/apache/arrow/pull/11956#issuecomment-1024317901 > What do the map types look like when they get pulled into R? I don't think I saw a test that showed that (but maybe I missed it)? Would if make sense to have a test like th

[GitHub] [arrow] jonkeane closed pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-28 Thread GitBox
jonkeane closed pull request #12170: URL: https://github.com/apache/arrow/pull/12170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow] jonkeane commented on a change in pull request #11971: ARROW-15040: [R] Enable write_csv_arrow to take a RecordBatchReader as input

2022-01-28 Thread GitBox
jonkeane commented on a change in pull request #11971: URL: https://github.com/apache/arrow/pull/11971#discussion_r794603415 ## File path: r/R/csv.R ## @@ -692,7 +692,7 @@ write_csv_arrow <- function(x, x <- Table$create(x) } - assert_that(is_writable_table(x)) + as

[GitHub] [arrow] ursabot commented on pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-28 Thread GitBox
ursabot commented on pull request #12170: URL: https://github.com/apache/arrow/pull/12170#issuecomment-1024331333 Benchmark runs are scheduled for baseline = 39367db2dab321dbbf4d12d2229020614b049dde and contender = 07ec0a12d430dc9151678b6f00d5c6fc0598f034. 07ec0a12d430dc9151678b6f00d5c6fc

[GitHub] [arrow] lidavidm opened a new pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
lidavidm opened a new pull request #12284: URL: https://github.com/apache/arrow/pull/12284 Prevent us from mixing system/bundled gRPC and Protobuf, since gRPC itself links to Protobuf and having two copies of Protobuf linked will lead to runtime errors or crashes. -- This is an automate

[GitHub] [arrow] github-actions[bot] commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
github-actions[bot] commented on pull request #12284: URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024341354 https://issues.apache.org/jira/browse/ARROW-15495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] lidavidm commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
lidavidm commented on pull request #12284: URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024342666 For many of the Crossbow builds, this should have the effect of bundling both Protobuf and gRPC, since the system Protobuf is too old to support Flight/Flight SQL. -- This

[GitHub] [arrow] lidavidm commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
lidavidm commented on pull request #12284: URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024348698 CC @kszucs @kou, I originally had it raise an error, but this is less disruptive. I checked that the tests indeed fail on Ubuntu 21.04 when you mix the two. -- This is an

[GitHub] [arrow-datafusion] Igosuki opened a new pull request #1697: [arrow2] Merge arrow2 and datafusion latest

2022-01-28 Thread GitBox
Igosuki opened a new pull request #1697: URL: https://github.com/apache/arrow-datafusion/pull/1697 # Which issue does this PR close? None # Rationale for this change Updates the arrow2 branch with the latest of arrow2 and datafusion master # What changes are included

[GitHub] [arrow] lidavidm edited a comment on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
lidavidm edited a comment on pull request #12284: URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024348698 CC @kszucs @kou, I originally had it raise an error, but this is less disruptive. I checked that the tests indeed fail on Ubuntu 21.04 when you mix the two, and that th

[GitHub] [arrow] ursabot edited a comment on pull request #12170: ARROW-14461 [R] write_dataset() allows users to pass invalid additional arguments

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12170: URL: https://github.com/apache/arrow/pull/12170#issuecomment-1024331333 Benchmark runs are scheduled for baseline = 39367db2dab321dbbf4d12d2229020614b049dde and contender = 07ec0a12d430dc9151678b6f00d5c6fc0598f034. 07ec0a12d430dc9151678b6f0

[GitHub] [arrow] kszucs commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
kszucs commented on pull request #12284: URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024350939 > I originally had it raise an error, but this is less disruptive. My first thought was to raise too, but this looks like a better way to handle it. > I checked that

[GitHub] [arrow] kszucs edited a comment on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
kszucs edited a comment on pull request #12284: URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024350939 > I originally had it raise an error, but this is less disruptive. My first thought was to raise too, but this looks like a better way to handle it. > I ch

[GitHub] [arrow] jonkeane commented on a change in pull request #12185: ARROW-15020: [R] Add bindings for new dataset writing options

2022-01-28 Thread GitBox
jonkeane commented on a change in pull request #12185: URL: https://github.com/apache/arrow/pull/12185#discussion_r794606763 ## File path: r/R/dataset-write.R ## @@ -111,6 +121,10 @@ write_dataset <- function(dataset, hive_style = TRUE,

[GitHub] [arrow] lidavidm commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match

2022-01-28 Thread GitBox
lidavidm commented on pull request #12284: URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024352290 > Did you manage to reproduce it with `UBUNTU=21.04 archery docker run ubuntu-cpp`? I will give that a try -- This is an automated message from the Apache Git Service

[GitHub] [arrow-datafusion] alamb commented on pull request #1695: Lazy TempDir creation in DiskManager

2022-01-28 Thread GitBox
alamb commented on pull request #1695: URL: https://github.com/apache/arrow-datafusion/pull/1695#issuecomment-1024353939 > If I read our code correctly. when executing a plan, we need to create RuntimeEnv where will create a DiskManager instance. So I can't understand if there will be so

[GitHub] [arrow-datafusion] alamb edited a comment on pull request #1695: Lazy TempDir creation in DiskManager

2022-01-28 Thread GitBox
alamb edited a comment on pull request #1695: URL: https://github.com/apache/arrow-datafusion/pull/1695#issuecomment-1024353939 > If I read our code correctly. when executing a plan, we need to create RuntimeEnv where will create a DiskManager instance. So I can't understand if there will

[GitHub] [arrow] kszucs commented on pull request #12283: [Release] Support release verification without a conda environment

2022-01-28 Thread GitBox
kszucs commented on pull request #12283: URL: https://github.com/apache/arrow/pull/12283#issuecomment-1024357582 @github-actions crossbow submit verify-rc-source-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow] ursabot edited a comment on pull request #12280: ARROW-15493: [C++][Gandiva] Init ExpressionCacheKey.mode_

2022-01-28 Thread GitBox
ursabot edited a comment on pull request #12280: URL: https://github.com/apache/arrow/pull/12280#issuecomment-1024148552 Benchmark runs are scheduled for baseline = c692c8842a959c2af0e68bc2f20f72d5f2a2ec67 and contender = a27c55660e575a3987283d5d9e443642db48f215. a27c55660e575a3987283d5d9

  1   2   3   4   >