codecov-commenter edited a comment on pull request #1154:
URL: https://github.com/apache/arrow-rs/pull/1154#issuecomment-1009835577
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
tustvold commented on issue #1692:
URL:
https://github.com/apache/arrow-datafusion/issues/1692#issuecomment-1025578145
@alamb could you assign this ticket to me please :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pitrou closed pull request #12239:
URL: https://github.com/apache/arrow/pull/12239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
pitrou closed pull request #12274:
URL: https://github.com/apache/arrow/pull/12274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
ursabot commented on pull request #12239:
URL: https://github.com/apache/arrow/pull/12239#issuecomment-1025583247
Benchmark runs are scheduled for baseline =
690e22f8256d2d4fe548cdbdaf2d70362780fdff and contender =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e.
a7f518ca90fa12ac0edad59e70486b96
ursabot commented on pull request #12274:
URL: https://github.com/apache/arrow/pull/12274#issuecomment-1025583265
Benchmark runs are scheduled for baseline =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e and contender =
ab8462c42e238612d79f8ff6393cf8b8c3a7179e.
ab8462c42e238612d79f8ff6393cf8b8
pitrou commented on pull request #12014:
URL: https://github.com/apache/arrow/pull/12014#issuecomment-1025599895
@JabariBooker Integration data is generated in Python by Archery here:
https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/datagen.py#L196
You can
ursabot edited a comment on pull request #12239:
URL: https://github.com/apache/arrow/pull/12239#issuecomment-1025583247
Benchmark runs are scheduled for baseline =
690e22f8256d2d4fe548cdbdaf2d70362780fdff and contender =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e.
a7f518ca90fa12ac0edad59e7
ursabot edited a comment on pull request #12274:
URL: https://github.com/apache/arrow/pull/12274#issuecomment-1025583265
Benchmark runs are scheduled for baseline =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e and contender =
ab8462c42e238612d79f8ff6393cf8b8c3a7179e.
ab8462c42e238612d79f8ff63
jorisvandenbossche closed pull request #12295:
URL: https://github.com/apache/arrow/pull/12295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: git
ursabot commented on pull request #12295:
URL: https://github.com/apache/arrow/pull/12295#issuecomment-1025643225
Benchmark runs are scheduled for baseline =
ab8462c42e238612d79f8ff6393cf8b8c3a7179e and contender =
ad073b7c0fec80ce88aaf1e7d6a78104711952f2.
ad073b7c0fec80ce88aaf1e7d6a78104
ursabot edited a comment on pull request #12295:
URL: https://github.com/apache/arrow/pull/12295#issuecomment-1025643225
Benchmark runs are scheduled for baseline =
ab8462c42e238612d79f8ff6393cf8b8c3a7179e and contender =
ad073b7c0fec80ce88aaf1e7d6a78104711952f2.
ad073b7c0fec80ce88aaf1e7d
ursabot edited a comment on pull request #12239:
URL: https://github.com/apache/arrow/pull/12239#issuecomment-1025583247
Benchmark runs are scheduled for baseline =
690e22f8256d2d4fe548cdbdaf2d70362780fdff and contender =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e.
a7f518ca90fa12ac0edad59e7
vvellanki commented on a change in pull request #10350:
URL: https://github.com/apache/arrow/pull/10350#discussion_r795639530
##
File path: cpp/src/gandiva/precompiled/extended_math_ops.cc
##
@@ -384,19 +493,61 @@ gdv_int64 get_power_of_10(gdv_int32 exp) {
return power_of_10
ursabot edited a comment on pull request #12239:
URL: https://github.com/apache/arrow/pull/12239#issuecomment-1025583247
Benchmark runs are scheduled for baseline =
690e22f8256d2d4fe548cdbdaf2d70362780fdff and contender =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e.
a7f518ca90fa12ac0edad59e7
pitrou commented on pull request #12286:
URL: https://github.com/apache/arrow/pull/12286#issuecomment-1025715053
I am a bit skeptical about this. As you point out, this might only be useful
for simple applications, otherwise I expect the traces to be too copious and
lack too much context t
AlenkaF opened a new pull request #12300:
URL: https://github.com/apache/arrow/pull/12300
This PR adds a check for the name of the column in `_get_extension_dtypes()`
from `pandas_compat.py` to fix an error when using `pd.iterval_range` index
with empty dataframe in Pandas roundtrip.
--
github-actions[bot] commented on pull request #12300:
URL: https://github.com/apache/arrow/pull/12300#issuecomment-1025720391
https://issues.apache.org/jira/browse/ARROW-15253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
pitrou commented on pull request #12286:
URL: https://github.com/apache/arrow/pull/12286#issuecomment-1025721424
cc @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
kszucs commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025732438
@github-actions crossbow submit verify-rc-source-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
github-actions[bot] commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025733642
Revision: 411f2ba2fd61305b21e6c38fc1f614a5b0febe5c
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1547](https://github.com/ursacomputing/crossbo
lidavidm commented on pull request #12286:
URL: https://github.com/apache/arrow/pull/12286#issuecomment-1025735144
Right, we could attach allocations as an event on the currently active span,
and then we'd have context (though, that would lose events if there is no
active span).
`p
kszucs commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025747628
@github-actions crossbow submit verify-rc-source-python-macos-conda-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025748632
Revision: 7babddecd4ba481b3ed318238cc2ba8e7da8ade9
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1548](https://github.com/ursacomputing/crossbo
pitrou commented on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025756294
Thank you @Crystrix , will merge now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
pitrou closed pull request #12298:
URL: https://github.com/apache/arrow/pull/12298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
ursabot commented on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025759670
Benchmark runs are scheduled for baseline =
ad073b7c0fec80ce88aaf1e7d6a78104711952f2 and contender =
d8f8c09622adad19cd054b220665b1313b52c15d.
d8f8c09622adad19cd054b220665b131
paleolimbot commented on pull request #11971:
URL: https://github.com/apache/arrow/pull/11971#issuecomment-1025762338
It may be worth rebasing this and seeing if it still segfaults! I know there
were some updates to the Scanner that fixed some segfaults for me when I was
writing tests for
pitrou commented on a change in pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#discussion_r795687618
##
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##
@@ -1091,8 +1153,17 @@ struct GroupedMeanImpl : public
GroupedReducingAggregator out_type
paleolimbot commented on pull request #11971:
URL: https://github.com/apache/arrow/pull/11971#issuecomment-1025766774
Also linking ARROW-15128 since it seems like a blocker for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
ursabot edited a comment on pull request #12274:
URL: https://github.com/apache/arrow/pull/12274#issuecomment-1025583265
Benchmark runs are scheduled for baseline =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e and contender =
ab8462c42e238612d79f8ff6393cf8b8c3a7179e.
ab8462c42e238612d79f8ff63
lidavidm closed pull request #12137:
URL: https://github.com/apache/arrow/pull/12137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
alamb commented on issue #1693:
URL:
https://github.com/apache/arrow-datafusion/issues/1693#issuecomment-1025777506
Another simplification that can be done that @tustvold came up with is:
```
CASE
WHEN X THEN A
WHEN Y THEN B
...
ELSE Q
END
```
a
ursabot commented on pull request #12137:
URL: https://github.com/apache/arrow/pull/12137#issuecomment-102515
Benchmark runs are scheduled for baseline =
d8f8c09622adad19cd054b220665b1313b52c15d and contender =
d7473260ba73c2a5bdb68f1505afcdea7884f494.
d7473260ba73c2a5bdb68f1505afcdea
ursabot edited a comment on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025759670
Benchmark runs are scheduled for baseline =
ad073b7c0fec80ce88aaf1e7d6a78104711952f2 and contender =
d8f8c09622adad19cd054b220665b1313b52c15d.
d8f8c09622adad19cd054b220
lidavidm commented on a change in pull request #12139:
URL: https://github.com/apache/arrow/pull/12139#discussion_r795705061
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -2090,6 +2146,34 @@ std::shared_ptr
MakeArithmeticFunctionFloatingPointNotNull(
ursabot edited a comment on pull request #12137:
URL: https://github.com/apache/arrow/pull/12137#issuecomment-102515
Benchmark runs are scheduled for baseline =
d8f8c09622adad19cd054b220665b1313b52c15d and contender =
d7473260ba73c2a5bdb68f1505afcdea7884f494.
d7473260ba73c2a5bdb68f150
rok commented on a change in pull request #12139:
URL: https://github.com/apache/arrow/pull/12139#discussion_r795717545
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -2090,6 +2146,34 @@ std::shared_ptr
MakeArithmeticFunctionFloatingPointNotNull(
ret
rok commented on a change in pull request #12139:
URL: https://github.com/apache/arrow/pull/12139#discussion_r795725075
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -214,6 +214,62 @@ struct SubtractChecked {
}
};
+template
+struct SubtractTimeDu
lidavidm commented on a change in pull request #12139:
URL: https://github.com/apache/arrow/pull/12139#discussion_r795726185
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -214,6 +214,62 @@ struct SubtractChecked {
}
};
+template
+struct SubtractT
thisisnic commented on a change in pull request #12277:
URL: https://github.com/apache/arrow/pull/12277#discussion_r795727853
##
File path: r/R/dataset-format.R
##
@@ -133,10 +133,36 @@ CsvFileFormat$create <- function(...,
schema_names <- names(schema)
if (!is.null(sch
rok commented on a change in pull request #12139:
URL: https://github.com/apache/arrow/pull/12139#discussion_r795728909
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -214,6 +214,62 @@ struct SubtractChecked {
}
};
+template
+struct SubtractTimeDu
thisisnic commented on a change in pull request #12277:
URL: https://github.com/apache/arrow/pull/12277#discussion_r795729473
##
File path: r/R/dataset-format.R
##
@@ -133,10 +133,36 @@ CsvFileFormat$create <- function(...,
schema_names <- names(schema)
if (!is.null(sch
wjones127 commented on pull request #12286:
URL: https://github.com/apache/arrow/pull/12286#issuecomment-1025817778
> I am a bit skeptical about this. As you point out, this might only be
useful for simple applications, otherwise I expect the traces to be too copious
and lack too much cont
alamb merged pull request #1714:
URL: https://github.com/apache/arrow-datafusion/pull/1714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
kszucs commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025820723
@github-actions crossbow submit verify-rc-source-python-linux-conda-amd64
verify-rc-source-integration-linux-conda-amd64
--
This is an automated message from the Apache Git Se
alamb merged pull request #1700:
URL: https://github.com/apache/arrow-datafusion/pull/1700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
alamb closed issue #1690:
URL: https://github.com/apache/arrow-datafusion/issues/1690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
github-actions[bot] commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025823082
Revision: efe943c47a48fe2b1aaa86508dfef9510a6cee49
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1549](https://github.com/ursacomputing/crossbo
alamb merged pull request #1665:
URL: https://github.com/apache/arrow-datafusion/pull/1665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
alamb closed issue #1648:
URL: https://github.com/apache/arrow-datafusion/issues/1648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
alamb commented on pull request #1665:
URL:
https://github.com/apache/arrow-datafusion/pull/1665#issuecomment-1025825470
Thanks @Ted-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jonkeane closed pull request #12287:
URL: https://github.com/apache/arrow/pull/12287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
alamb commented on issue #115:
URL:
https://github.com/apache/arrow-datafusion/issues/115#issuecomment-1025827117
I am not sure -- @andygrove filed the original ticket here
https://issues.apache.org/jira/browse/ARROW-10714
This one may not be relevant any more? I am not sure.
--
ursabot commented on pull request #12287:
URL: https://github.com/apache/arrow/pull/12287#issuecomment-1025829491
Benchmark runs are scheduled for baseline =
d7473260ba73c2a5bdb68f1505afcdea7884f494 and contender =
d4e16a52e687935cd1d6205d987a837dd03d0d59.
d4e16a52e687935cd1d6205d987a837d
pitrou commented on pull request #12286:
URL: https://github.com/apache/arrow/pull/12286#issuecomment-1025829726
The nice thing with OpenTracing is that it adds context to trace events, so
you can know which workload item the allocations are part of.
--
This is an automated message from
rok commented on a change in pull request #12124:
URL: https://github.com/apache/arrow/pull/12124#discussion_r795747278
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -2437,14 +2462,35 @@ void RegisterScalarArithmetic(FunctionRegistry*
registry) {
pitrou opened a new pull request #12301:
URL: https://github.com/apache/arrow/pull/12301
Tests for optional components could be silently skipped if by accident the
component would fail importing despite being built.
--
This is an automated message from the Apache Git Service.
To respond
pitrou commented on pull request #12301:
URL: https://github.com/apache/arrow/pull/12301#issuecomment-1025843606
@github-actions crossbow submit -g python -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
github-actions[bot] commented on pull request #12301:
URL: https://github.com/apache/arrow/pull/12301#issuecomment-1025843674
https://issues.apache.org/jira/browse/ARROW-15504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
github-actions[bot] commented on pull request #12301:
URL: https://github.com/apache/arrow/pull/12301#issuecomment-1025845749
Revision: 9a38be5d52a2957cbe991b3282743b3ccf59c8a6
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1550](https://github.com/ursacomputing/crossbo
kszucs commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025859515
@github-actions crossbow submit verify-rc-source-python-linux-conda-amd64
verify-rc-source-integration-linux-conda-amd64
--
This is an automated message from the Apache Git Se
lidavidm commented on pull request #12286:
URL: https://github.com/apache/arrow/pull/12286#issuecomment-1025859851
> I was planning on documenting next using perf to trace calls to the memory
pool, but maybe open tracing would be more worthwhile. I'll look into that.
FWIW I got this
lidavidm commented on a change in pull request #12124:
URL: https://github.com/apache/arrow/pull/12124#discussion_r795762911
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -2437,14 +2462,35 @@ void RegisterScalarArithmetic(FunctionRegistry*
registry) {
lidavidm commented on a change in pull request #12124:
URL: https://github.com/apache/arrow/pull/12124#discussion_r795763192
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -2437,14 +2462,35 @@ void RegisterScalarArithmetic(FunctionRegistry*
registry) {
github-actions[bot] commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025861520
Revision: 423b6b6163eeeb68632f6c118ccb544d278b00f6
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1551](https://github.com/ursacomputing/crossbo
ursabot edited a comment on pull request #12287:
URL: https://github.com/apache/arrow/pull/12287#issuecomment-1025829491
Benchmark runs are scheduled for baseline =
d7473260ba73c2a5bdb68f1505afcdea7884f494 and contender =
d4e16a52e687935cd1d6205d987a837dd03d0d59.
d4e16a52e687935cd1d6205d9
kszucs commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025872243
@github-actions crossbow submit verify-rc-source-python-linux-conda-amd64
verify-rc-source-integration-linux-conda-amd64
--
This is an automated message from the Apache Git Se
github-actions[bot] commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025874431
Revision: 65d87bf70f592df214fb13a56d655c2d5cc70e6e
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1552](https://github.com/ursacomputing/crossbo
kszucs commented on a change in pull request #12301:
URL: https://github.com/apache/arrow/pull/12301#discussion_r795771053
##
File path: ci/scripts/python_test.sh
##
@@ -30,4 +30,14 @@ export ARROW_GDB_SCRIPT=${arrow_dir}/cpp/gdb_arrow.py
# Enable some checks inside Python its
wjones127 commented on a change in pull request #12216:
URL: https://github.com/apache/arrow/pull/12216#discussion_r795772660
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -3675,6 +3675,116 @@ TEST(TestArrowReaderAdHoc,
LARGE_MEMORY_TEST(LargeStringColu
tustvold commented on issue #1693:
URL:
https://github.com/apache/arrow-datafusion/issues/1693#issuecomment-1025890407
I think the boolean transformation as written is subtly wrong, I think I
have the correct one but I'm just double-checking it
--
This is an automated message from the A
lidavidm opened a new pull request #12302:
URL: https://github.com/apache/arrow/pull/12302
Add a method to explicitly close FlightClient in anticipation of
implementing alternative transports which may need this, and to provide an
interface for things like ARROW-15473. Because this did not
github-actions[bot] commented on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1025893827
https://issues.apache.org/jira/browse/ARROW-15487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
pitrou commented on a change in pull request #12301:
URL: https://github.com/apache/arrow/pull/12301#discussion_r795783704
##
File path: ci/scripts/python_test.sh
##
@@ -30,4 +30,14 @@ export ARROW_GDB_SCRIPT=${arrow_dir}/cpp/gdb_arrow.py
# Enable some checks inside Python its
kszucs commented on a change in pull request #12301:
URL: https://github.com/apache/arrow/pull/12301#discussion_r795786943
##
File path: ci/scripts/python_test.sh
##
@@ -30,4 +30,14 @@ export ARROW_GDB_SCRIPT=${arrow_dir}/cpp/gdb_arrow.py
# Enable some checks inside Python its
pitrou commented on a change in pull request #12301:
URL: https://github.com/apache/arrow/pull/12301#discussion_r795796985
##
File path: ci/scripts/python_test.sh
##
@@ -30,4 +30,14 @@ export ARROW_GDB_SCRIPT=${arrow_dir}/cpp/gdb_arrow.py
# Enable some checks inside Python its
ursabot edited a comment on pull request #12274:
URL: https://github.com/apache/arrow/pull/12274#issuecomment-1025583265
Benchmark runs are scheduled for baseline =
a7f518ca90fa12ac0edad59e70486b96c8c72f8e and contender =
ab8462c42e238612d79f8ff6393cf8b8c3a7179e.
ab8462c42e238612d79f8ff63
kszucs commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025916342
@github-actions crossbow submit
verify-rc-source-integration-linux-ubuntu-18.04-amd64
verify-rc-source-integration-linux-conda-amd64
--
This is an automated message from the
github-actions[bot] commented on pull request #12283:
URL: https://github.com/apache/arrow/pull/12283#issuecomment-1025917943
Revision: ee3c552896787a93b78832b561d7fb45bb20a4d9
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1553](https://github.com/ursacomputing/crossbo
rok commented on a change in pull request #12124:
URL: https://github.com/apache/arrow/pull/12124#discussion_r795801648
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -2437,14 +2462,35 @@ void RegisterScalarArithmetic(FunctionRegistry*
registry) {
ursabot edited a comment on pull request #12295:
URL: https://github.com/apache/arrow/pull/12295#issuecomment-1025643225
Benchmark runs are scheduled for baseline =
ab8462c42e238612d79f8ff6393cf8b8c3a7179e and contender =
ad073b7c0fec80ce88aaf1e7d6a78104711952f2.
ad073b7c0fec80ce88aaf1e7d
zeroshade commented on pull request #12158:
URL: https://github.com/apache/arrow/pull/12158#issuecomment-1025935325
Hey @brancz The reason for a lack of `StringDictionaryBuilder` is that it's
really just a special case of the `BinaryDictionaryBuilder` which can be
instantiated with the pro
vibhatha commented on pull request #12185:
URL: https://github.com/apache/arrow/pull/12185#issuecomment-1025961158
>
@jonkeane I tried `devtools::document()` and the resultant diff is the
following. I am adding the diff, because it edited a set of files. Just want to
make sure whet
vibhatha removed a comment on pull request #12185:
URL: https://github.com/apache/arrow/pull/12185#issuecomment-1025961158
>
@jonkeane I tried `devtools::document()` and the resultant diff is the
following. I am adding the diff, because it edited a set of files. Just want to
make s
drauschenbach commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1025968885
I'm looking to get up to speed on the Go bindings through this PR, and so
far I can get most of the tests to run (not including ones that require a
`PARQUET_TEST_DATA` di
drauschenbach edited a comment on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1025968885
I'm looking to get up to speed on the Go bindings through this PR, and so
far I can get most of the tests to run (not including ones that require a
`PARQUET_TEST_D
tustvold opened a new issue #1716:
URL: https://github.com/apache/arrow-datafusion/issues/1716
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
I noticed Datafusion is not able to simplify the expression
```
A ^ !A
wjones127 commented on pull request #1711:
URL:
https://github.com/apache/arrow-datafusion/pull/1711#issuecomment-1025981760
> @wjones127 looks like the newly added CI job is failing.
@houqp Thanks. I got it passing now in my branch:
https://github.com/wjones127/arrow-datafusion/run
alamb commented on issue #1710:
URL:
https://github.com/apache/arrow-datafusion/issues/1710#issuecomment-1025985382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
alamb removed a comment on issue #1710:
URL:
https://github.com/apache/arrow-datafusion/issues/1710#issuecomment-1025985470
Thank you for the report @OscarTHZhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zeroshade commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1025988162
@drauschenbach So that's actually a bug I found also and put up a PR for. It
came about due to a change I made in the interface to simplify things and then
I forgot to update
github-actions[bot] commented on pull request #12303:
URL: https://github.com/apache/arrow/pull/12303#issuecomment-1025988591
https://issues.apache.org/jira/browse/ARROW-15509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
drauschenbach commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1025990117
Also, in reference to the `PARQUET_TEST_DATA` env var mentioned above I
found `ci/scripts/go_test.sh`, and that explains a required `-test` tag. But I
also don't make it
zeroshade commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1025992928
So, for the `PARQUET_TEST_DATA` it refers to the directory that pulls down
the sample parquet files which are in the submodule loaded in the cpp source as
you can see referen
drauschenbach commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1025997231
> Judging from the directory paths I assume you're running this on a Mac
using an ARM64 CPU?
Correct. Ah, I just noticed that Mac arm64 is not in the GitHub CI buil
drauschenbach commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1025997702
> Please try using the branch in PR: #12303 until it gets merged. Try that
out and if it doesn't work let me know by commenting on that PR
Thanks! I'll check it out
zeroshade commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1026001035
@drauschenbach Yea, the CI matrix runs on a mac using amd64, and we have
Linux arm64v8 run by travis CI but we don't have MacOS + arm64
--
This is an automated message from
tustvold commented on issue #1716:
URL:
https://github.com/apache/arrow-datafusion/issues/1716#issuecomment-1026004441
On a related note it is unable to simplify expressions of the form
```
A ^ (!A v B)
```
--
This is an automated message from the Apache Git Service.
To
zeroshade commented on pull request #12149:
URL: https://github.com/apache/arrow/pull/12149#issuecomment-1026020029
@drauschenbach seeing as I don't currently have access to an arm64 Mac
system, if you do manage to track down the cause of that crash (given the
failure in the compress tests
1 - 100 of 235 matches
Mail list logo
