vibhatha commented on a change in pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r839211160
##
File path: cpp/examples/arrow/udf_example.cc
##
@@ -0,0 +1,253 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
ursabot edited a comment on pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#issuecomment-1083123344
Benchmark runs are scheduled for baseline =
c515a6924f6002a70f1046b1642629867bacabd2 and contender =
33df4c789e7dd6b4f590783ae69d4faa49e47e04.
33df4c789e7dd6b4f590783ae
ursabot edited a comment on pull request #12729:
URL: https://github.com/apache/arrow/pull/12729#issuecomment-1082893955
Benchmark runs are scheduled for baseline =
50fab73da58c9f76fbe675d661e56087e2f5fb52 and contender =
c515a6924f6002a70f1046b1642629867bacabd2.
c515a6924f6002a70f1046b16
ursabot edited a comment on pull request #12537:
URL: https://github.com/apache/arrow/pull/12537#issuecomment-1082832095
Benchmark runs are scheduled for baseline =
0deefd1838bf4706232b90b72da010698010f7b6 and contender =
50fab73da58c9f76fbe675d661e56087e2f5fb52.
50fab73da58c9f76fbe675d66
mbrobbel closed pull request #12328:
URL: https://github.com/apache/arrow/pull/12328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
westonpace commented on pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#issuecomment-1084197255
@vibhatha I'm not entirely clear on the concern. I don't mind if we have an
inheritence tree of object structs. For example, this would be ok (this is
totally made up and
westonpace edited a comment on pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#issuecomment-1084197255
@vibhatha I'm not entirely clear on the concern. I don't mind if we have an
inheritence tree of object structs. For example, this would be ok (this is
totally made
ursabot edited a comment on pull request #12741:
URL: https://github.com/apache/arrow/pull/12741#issuecomment-1081239721
Benchmark runs are scheduled for baseline =
dbea4ffde6afba8eba7cd26c78b270ed1a5178a9 and contender =
f4cc59313043493628b39fe757e2796fc74ac42f.
f4cc59313043493628b39fe75
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline =
556ee23e539015bd414dc8df46a3b7a0c7404381 and contender =
77e2a113362e8b623f685d851ae98eb7358f5166.
77e2a113362e8b623f685d851
ursabot edited a comment on pull request #12730:
URL: https://github.com/apache/arrow/pull/12730#issuecomment-1081290089
Benchmark runs are scheduled for baseline =
f4cc59313043493628b39fe757e2796fc74ac42f and contender =
556ee23e539015bd414dc8df46a3b7a0c7404381.
556ee23e539015bd414dc8df4
github-actions[bot] commented on pull request #12762:
URL: https://github.com/apache/arrow/pull/12762#issuecomment-1084221178
https://issues.apache.org/jira/browse/ARROW-16057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
AlenkaF opened a new pull request #12762:
URL: https://github.com/apache/arrow/pull/12762
This PR adds docstring examples to:
- `pyarrow.RecordBatch` class methods and attributes
- `pyarrow.record_batch`
- `to_pandas` for `_PandasConvertible`
--
This is an automated message f
kou closed pull request #12760:
URL: https://github.com/apache/arrow/pull/12760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
viirya commented on a change in pull request #1469:
URL: https://github.com/apache/arrow-rs/pull/1469#discussion_r839292775
##
File path: arrow/src/array/equal/union.rs
##
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
vibhatha commented on a change in pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r839296023
##
File path: cpp/examples/arrow/aggregate_example.cc
##
@@ -0,0 +1,135 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review comment
viirya commented on a change in pull request #1469:
URL: https://github.com/apache/arrow-rs/pull/1469#discussion_r839296459
##
File path: arrow/src/array/equal/utils.rs
##
@@ -66,7 +66,14 @@ pub(super) fn equal_nulls(
#[inline]
pub(super) fn base_equal(lhs: &ArrayData, rhs:
viirya commented on a change in pull request #1469:
URL: https://github.com/apache/arrow-rs/pull/1469#discussion_r839296915
##
File path: arrow/src/array/equal/union.rs
##
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
ursabot commented on pull request #12760:
URL: https://github.com/apache/arrow/pull/12760#issuecomment-1084233023
Benchmark runs are scheduled for baseline =
3eb1bac0b54a7f883986a1af7cbdf6f3607b1052 and contender =
4a90e3994fc9fc10b968ab3439dec636385dec22.
4a90e3994fc9fc10b968ab3439dec636
doki23 commented on pull request #2054:
URL:
https://github.com/apache/arrow-datafusion/pull/2054#issuecomment-1084234833
I find that logical plan before optimization could be invalid like
`plan.project(a,b,c).project(b,c).filter(a>1)`, but it can be optimized with
'filter push down' rule
doki23 edited a comment on pull request #2054:
URL:
https://github.com/apache/arrow-datafusion/pull/2054#issuecomment-1084234833
I find that logical plan before optimization could be invalid. For example,
`plan.project(a,b,c).project(b,c).filter(a>1)`, but it can be optimized with
'filter
viirya commented on a change in pull request #1469:
URL: https://github.com/apache/arrow-rs/pull/1469#discussion_r839300380
##
File path: arrow/src/array/equal/union.rs
##
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor l
doki23 edited a comment on pull request #2054:
URL:
https://github.com/apache/arrow-datafusion/pull/2054#issuecomment-1084234833
I add pre-check after optimization. But it seems that it's always valid
after optimization😂. So this pr may be unnecessary. I'm going to close it
temporarily if
doki23 edited a comment on pull request #2054:
URL:
https://github.com/apache/arrow-datafusion/pull/2054#issuecomment-1084234833
I add pre-check after optimization. Although there's no unified validation
framework, but it seems that it's always valid after optimization😂. So this pr
may be
doki23 edited a comment on pull request #2054:
URL:
https://github.com/apache/arrow-datafusion/pull/2054#issuecomment-1084234833
I add pre-check after optimization. Although there's no unified validation
framework, but it seems that it's always valid after optimization😂. So this pr
may be
codecov-commenter edited a comment on pull request #1469:
URL: https://github.com/apache/arrow-rs/pull/1469#issuecomment-1074462490
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
ursabot edited a comment on pull request #12760:
URL: https://github.com/apache/arrow/pull/12760#issuecomment-1084233023
Benchmark runs are scheduled for baseline =
3eb1bac0b54a7f883986a1af7cbdf6f3607b1052 and contender =
4a90e3994fc9fc10b968ab3439dec636385dec22.
4a90e3994fc9fc10b968ab343
emkornfield opened a new pull request #12763:
URL: https://github.com/apache/arrow/pull/12763
Work in progress.
This fixes some error in the C++ build and gets basic code for a python
implementation done.
Still needs:
- unit/integration tests in python
- Verification t
emkornfield commented on pull request #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1084259382
@pitrou @kszucs this still isn't ready for review but I have it compiling
locally. I was wondering if there are cross-bow or other actions I should be
taking to verify pack
brancz opened a new pull request #12764:
URL: https://github.com/apache/arrow/pull/12764
The package deleted in this commit is an outdated copy of a package that
used to be an internal package in the Go standard library, but since
then it has been moved to the publicly accessible golan
jackwener commented on pull request #2054:
URL:
https://github.com/apache/arrow-datafusion/pull/2054#issuecomment-1084263246
😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ursabot edited a comment on pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#issuecomment-1083123344
Benchmark runs are scheduled for baseline =
c515a6924f6002a70f1046b1642629867bacabd2 and contender =
33df4c789e7dd6b4f590783ae69d4faa49e47e04.
33df4c789e7dd6b4f590783ae
ursabot edited a comment on pull request #12729:
URL: https://github.com/apache/arrow/pull/12729#issuecomment-1082893955
Benchmark runs are scheduled for baseline =
50fab73da58c9f76fbe675d661e56087e2f5fb52 and contender =
c515a6924f6002a70f1046b1642629867bacabd2.
c515a6924f6002a70f1046b16
brancz commented on pull request #12764:
URL: https://github.com/apache/arrow/pull/12764#issuecomment-1084263407
cc @zeroshade @sbinet @emkornfield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ursabot edited a comment on pull request #12537:
URL: https://github.com/apache/arrow/pull/12537#issuecomment-1082832095
Benchmark runs are scheduled for baseline =
0deefd1838bf4706232b90b72da010698010f7b6 and contender =
50fab73da58c9f76fbe675d661e56087e2f5fb52.
50fab73da58c9f76fbe675d66
vibhatha commented on a change in pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r839332923
##
File path: cpp/src/arrow/python/udf.cc
##
@@ -0,0 +1,125 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
emkornfield commented on pull request #12753:
URL: https://github.com/apache/arrow/pull/12753#issuecomment-1084272066
It looks like the test failures are unrelated (something going on with S3 on
Mac?)
--
This is an automated message from the Apache Git Service.
To respond to the message,
thisisnic opened a new issue #172:
URL: https://github.com/apache/arrow-cookbook/issues/172
This feature will be available in the next release and we should add some
recipes for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
dragosmg commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r839347871
##
File path: r/tests/testthat/helper-skip.R
##
@@ -78,3 +78,7 @@ process_is_running <- function(x) {
cmd <- sprintf("ps aux | grep '%s' | grep -v gre
dragosmg commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r839348181
##
File path: r/tests/testthat/helper-skip.R
##
@@ -78,3 +78,7 @@ process_is_running <- function(x) {
cmd <- sprintf("ps aux | grep '%s' | grep -v gre
dragosmg commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r839351248
##
File path: r/tests/testthat/test-Array.R
##
@@ -260,18 +260,28 @@ test_that("array supports POSIXct (ARROW-3340)", {
expect_array_roundtrip(times2,
ursabot edited a comment on pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#issuecomment-1083123344
Benchmark runs are scheduled for baseline =
c515a6924f6002a70f1046b1642629867bacabd2 and contender =
33df4c789e7dd6b4f590783ae69d4faa49e47e04.
33df4c789e7dd6b4f590783ae
ursabot edited a comment on pull request #12729:
URL: https://github.com/apache/arrow/pull/12729#issuecomment-1082893955
Benchmark runs are scheduled for baseline =
50fab73da58c9f76fbe675d661e56087e2f5fb52 and contender =
c515a6924f6002a70f1046b1642629867bacabd2.
c515a6924f6002a70f1046b16
ursabot edited a comment on pull request #12748:
URL: https://github.com/apache/arrow/pull/12748#issuecomment-1083156315
Benchmark runs are scheduled for baseline =
33df4c789e7dd6b4f590783ae69d4faa49e47e04 and contender =
64560af62391cb8823b3af3ac60991c0de59bac3.
64560af62391cb8823b3af3ac
dragosmg commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r839361095
##
File path: r/tests/testthat/test-Array.R
##
@@ -260,18 +260,28 @@ test_that("array supports POSIXct (ARROW-3340)", {
expect_array_roundtrip(times2,
github-actions[bot] commented on pull request #12763:
URL: https://github.com/apache/arrow/pull/12763#issuecomment-1084303467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
thinkharderdev commented on a change in pull request #2111:
URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839383936
##
File path: datafusion/core/Cargo.toml
##
@@ -60,9 +62,10 @@ async-trait = "0.1.41"
avro-rs = { version = "0.13", features = ["snappy"]
Dandandan commented on pull request #2128:
URL:
https://github.com/apache/arrow-datafusion/pull/2128#issuecomment-1084330984
> How about
> ```rust
> let mut owned_string = Vec::with_capacity(args.len()-1);
> for arg_index in 1..args.len() {
> let arg = &args[arg_index]
AlenkaF opened a new pull request #12766:
URL: https://github.com/apache/arrow/pull/12766
This PR corrects a page name change missing in toctree (leftover from
https://github.com/apache/arrow/pull/12483)
--
This is an automated message from the Apache Git Service.
To respond to the messa
alamb commented on a change in pull request #1499:
URL: https://github.com/apache/arrow-rs/pull/1499#discussion_r839405739
##
File path: arrow/src/compute/kernels/boolean.rs
##
@@ -575,10 +577,242 @@ where
Ok(PrimitiveArrayfrom(data))
}
+/// Creates a (mostly) zero-
Dandandan commented on pull request #2124:
URL:
https://github.com/apache/arrow-datafusion/pull/2124#issuecomment-1084366628
> I think we are good as long as we don't invoke rust functions from the
JIT'd code. I am curious if cranelift will be smart enough to auto vectorize
the loop thoug
Dandandan edited a comment on pull request #2124:
URL:
https://github.com/apache/arrow-datafusion/pull/2124#issuecomment-1084366628
> I think we are good as long as we don't invoke rust functions from the
JIT'd code. I am curious if cranelift will be smart enough to auto vectorize
the loo
Dandandan merged pull request #2124:
URL: https://github.com/apache/arrow-datafusion/pull/2124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: git
Dandandan closed issue #2123:
URL: https://github.com/apache/arrow-datafusion/issues/2123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-u
ursabot edited a comment on pull request #12713:
URL: https://github.com/apache/arrow/pull/12713#issuecomment-1081604521
Benchmark runs are scheduled for baseline =
556ee23e539015bd414dc8df46a3b7a0c7404381 and contender =
77e2a113362e8b623f685d851ae98eb7358f5166.
77e2a113362e8b623f685d851
ursabot edited a comment on pull request #12699:
URL: https://github.com/apache/arrow/pull/12699#issuecomment-1081604559
Benchmark runs are scheduled for baseline =
5cedd25efdced48fb809d7eef6729c4db4a9879d and contender =
6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8.
6773da12bbc3c7c5ba96f10f7
ursabot edited a comment on pull request #12730:
URL: https://github.com/apache/arrow/pull/12730#issuecomment-1081290089
Benchmark runs are scheduled for baseline =
f4cc59313043493628b39fe757e2796fc74ac42f and contender =
556ee23e539015bd414dc8df46a3b7a0c7404381.
556ee23e539015bd414dc8df4
ursabot edited a comment on pull request #12733:
URL: https://github.com/apache/arrow/pull/12733#issuecomment-1081604542
Benchmark runs are scheduled for baseline =
77e2a113362e8b623f685d851ae98eb7358f5166 and contender =
5cedd25efdced48fb809d7eef6729c4db4a9879d.
5cedd25efdced48fb809d7eef
Dandandan commented on a change in pull request #2108:
URL: https://github.com/apache/arrow-datafusion/pull/2108#discussion_r839422630
##
File path: datafusion/common/src/dfschema.rs
##
@@ -281,6 +282,18 @@ impl DFSchema {
.all(|(dffield, arrowfield)| dffield.name(
Dandandan commented on a change in pull request #2108:
URL: https://github.com/apache/arrow-datafusion/pull/2108#discussion_r839422630
##
File path: datafusion/common/src/dfschema.rs
##
@@ -281,6 +282,18 @@ impl DFSchema {
.all(|(dffield, arrowfield)| dffield.name(
github-actions[bot] commented on pull request #12765:
URL: https://github.com/apache/arrow/pull/12765#issuecomment-1084376483
https://issues.apache.org/jira/browse/ARROW-15523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
msathis commented on a change in pull request #1969:
URL: https://github.com/apache/arrow-datafusion/pull/1969#discussion_r839429696
##
File path: datafusion/physical-expr/src/conditional_expressions.rs
##
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software Foundation (ASF) un
eitsupi commented on pull request #12531:
URL: https://github.com/apache/arrow/pull/12531#issuecomment-1084385365
I noticed that the multi-level menu in the nav bar cannot be opened from
smart phones.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ursabot edited a comment on pull request #12729:
URL: https://github.com/apache/arrow/pull/12729#issuecomment-1082893955
Benchmark runs are scheduled for baseline =
50fab73da58c9f76fbe675d661e56087e2f5fb52 and contender =
c515a6924f6002a70f1046b1642629867bacabd2.
c515a6924f6002a70f1046b16
ursabot edited a comment on pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#issuecomment-1083123344
Benchmark runs are scheduled for baseline =
c515a6924f6002a70f1046b1642629867bacabd2 and contender =
33df4c789e7dd6b4f590783ae69d4faa49e47e04.
33df4c789e7dd6b4f590783ae
ursabot edited a comment on pull request #12748:
URL: https://github.com/apache/arrow/pull/12748#issuecomment-1083156315
Benchmark runs are scheduled for baseline =
33df4c789e7dd6b4f590783ae69d4faa49e47e04 and contender =
64560af62391cb8823b3af3ac60991c0de59bac3.
64560af62391cb8823b3af3ac
tustvold commented on pull request #1510:
URL: https://github.com/apache/arrow-rs/pull/1510#issuecomment-1084403088
Yup, ticket to follow is here - https://github.com/hyperium/tonic/issues/946
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
ursabot edited a comment on pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#issuecomment-1083123344
Benchmark runs are scheduled for baseline =
c515a6924f6002a70f1046b1642629867bacabd2 and contender =
33df4c789e7dd6b4f590783ae69d4faa49e47e04.
33df4c789e7dd6b4f590783ae
ursabot edited a comment on pull request #12402:
URL: https://github.com/apache/arrow/pull/12402#issuecomment-1083179426
Benchmark runs are scheduled for baseline =
64560af62391cb8823b3af3ac60991c0de59bac3 and contender =
ba04e7f8573ffd42442ffa589e4cbe61256ece7b.
ba04e7f8573ffd42442ffa589
ursabot edited a comment on pull request #12748:
URL: https://github.com/apache/arrow/pull/12748#issuecomment-1083156315
Benchmark runs are scheduled for baseline =
33df4c789e7dd6b4f590783ae69d4faa49e47e04 and contender =
64560af62391cb8823b3af3ac60991c0de59bac3.
64560af62391cb8823b3af3ac
vibhatha commented on a change in pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r839484191
##
File path: cpp/examples/arrow/udf_example.cc
##
@@ -0,0 +1,264 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
vibhatha commented on a change in pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r839515132
##
File path: python/pyarrow/_compute.pyx
##
@@ -199,6 +202,135 @@ FunctionDoc = namedtuple(
"options_required"))
+cdef wrap_arity(const CArity
lidavidm commented on issue #12761:
URL: https://github.com/apache/arrow/issues/12761#issuecomment-1084490811
Thank you! I've crossposted this on GitHub, do you mind if we keep the
discussion there?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
vibhatha commented on pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#issuecomment-1084498299
> @vibhatha I'm not entirely clear on the concern. I don't mind if we have
an inheritence tree of object structs. For example, this would be ok (this is
totally made up and li
paleolimbot commented on a change in pull request #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r839098244
##
File path: r/R/chunked-array.R
##
@@ -148,6 +153,12 @@ ChunkedArray$create <- function(..., type = NULL) {
ChunkedArray__from_list(list2(...), t
lidavidm commented on a change in pull request #12442:
URL: https://github.com/apache/arrow/pull/12442#discussion_r839533464
##
File path: cpp/src/arrow/flight/transport/ucx/ucx_server.cc
##
@@ -0,0 +1,646 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
lccnl commented on issue #12761:
URL: https://github.com/apache/arrow/issues/12761#issuecomment-1084500931
yes sure, can you keep this issue open though until it is solved? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
paleolimbot commented on a change in pull request #12751:
URL: https://github.com/apache/arrow/pull/12751#discussion_r839534767
##
File path: r/R/chunked-array.R
##
@@ -148,6 +153,12 @@ ChunkedArray$create <- function(..., type = NULL) {
ChunkedArray__from_list(list2(...), t
vibhatha commented on a change in pull request #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r839546515
##
File path: cpp/src/arrow/python/udf.cc
##
@@ -0,0 +1,125 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
HaoYang670 opened a new issue #1511:
URL: https://github.com/apache/arrow-rs/issues/1511
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/substring.rs#L44
ursabot edited a comment on pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#issuecomment-1083123344
Benchmark runs are scheduled for baseline =
c515a6924f6002a70f1046b1642629867bacabd2 and contender =
33df4c789e7dd6b4f590783ae69d4faa49e47e04.
33df4c789e7dd6b4f590783ae
ursabot edited a comment on pull request #12402:
URL: https://github.com/apache/arrow/pull/12402#issuecomment-1083179426
Benchmark runs are scheduled for baseline =
64560af62391cb8823b3af3ac60991c0de59bac3 and contender =
ba04e7f8573ffd42442ffa589e4cbe61256ece7b.
ba04e7f8573ffd42442ffa589
ursabot edited a comment on pull request #12748:
URL: https://github.com/apache/arrow/pull/12748#issuecomment-1083156315
Benchmark runs are scheduled for baseline =
33df4c789e7dd6b4f590783ae69d4faa49e47e04 and contender =
64560af62391cb8823b3af3ac60991c0de59bac3.
64560af62391cb8823b3af3ac
lidavidm commented on a change in pull request #12664:
URL: https://github.com/apache/arrow/pull/12664#discussion_r839545462
##
File path: cpp/src/arrow/dataset/file_parquet_test.cc
##
@@ -390,6 +390,38 @@ TEST_P(TestParquetFileFormatScan,
ScanRecordBatchReaderWithVirtualColum
vibhatha opened a new pull request #12767:
URL: https://github.com/apache/arrow/pull/12767
This is a minor PR including a fix for the streaming execution plan code. In
a currently reviewing PR an issue was raised and reflecting the suggesting
change for this example.
cc @pitrou
HaoYang670 opened a new pull request #1512:
URL: https://github.com/apache/arrow-rs/pull/1512
# Which issue does this PR close?
Closes #1511.
# Rationale for this change
Improve the performance and do some clean-up work.
# What changes are included in this PR?
1.
vibhatha commented on a change in pull request #12664:
URL: https://github.com/apache/arrow/pull/12664#discussion_r839559528
##
File path: cpp/src/arrow/dataset/file_parquet_test.cc
##
@@ -390,6 +390,38 @@ TEST_P(TestParquetFileFormatScan,
ScanRecordBatchReaderWithVirtualColum
vibhatha commented on a change in pull request #12664:
URL: https://github.com/apache/arrow/pull/12664#discussion_r839561013
##
File path: cpp/src/arrow/dataset/file_parquet_test.cc
##
@@ -390,6 +390,38 @@ TEST_P(TestParquetFileFormatScan,
ScanRecordBatchReaderWithVirtualColum
vibhatha commented on a change in pull request #12664:
URL: https://github.com/apache/arrow/pull/12664#discussion_r839561245
##
File path: cpp/src/arrow/dataset/file_parquet_test.cc
##
@@ -390,6 +390,38 @@ TEST_P(TestParquetFileFormatScan,
ScanRecordBatchReaderWithVirtualColum
lidavidm commented on a change in pull request #12739:
URL: https://github.com/apache/arrow/pull/12739#discussion_r839557302
##
File path: docs/source/java/quickstartguide.rst
##
@@ -0,0 +1,325 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contri
ursabot edited a comment on pull request #12483:
URL: https://github.com/apache/arrow/pull/12483#issuecomment-1081614132
Benchmark runs are scheduled for baseline =
6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8 and contender =
7de798a0bb120920553f1bef3b05dfc6637c0f7a.
7de798a0bb120920553f1bef3
ursabot edited a comment on pull request #12699:
URL: https://github.com/apache/arrow/pull/12699#issuecomment-1081604559
Benchmark runs are scheduled for baseline =
5cedd25efdced48fb809d7eef6729c4db4a9879d and contender =
6773da12bbc3c7c5ba96f10f76b31dda3c1c2bc8.
6773da12bbc3c7c5ba96f10f7
ursabot edited a comment on pull request #12733:
URL: https://github.com/apache/arrow/pull/12733#issuecomment-1081604542
Benchmark runs are scheduled for baseline =
77e2a113362e8b623f685d851ae98eb7358f5166 and contender =
5cedd25efdced48fb809d7eef6729c4db4a9879d.
5cedd25efdced48fb809d7eef
lidavidm commented on a change in pull request #12719:
URL: https://github.com/apache/arrow/pull/12719#discussion_r839569118
##
File path: cpp/src/arrow/flight/flight_benchmark.cc
##
@@ -124,7 +124,7 @@ Status WaitForReady(FlightClient* client, const
FlightCallOptions& call_op
ursabot edited a comment on pull request #12585:
URL: https://github.com/apache/arrow/pull/12585#issuecomment-1083374008
Benchmark runs are scheduled for baseline =
ba04e7f8573ffd42442ffa589e4cbe61256ece7b and contender =
ea4ab77a25c1df59d1d4f79b23d5bced841f7ba3.
ea4ab77a25c1df59d1d4f79b2
ursabot edited a comment on pull request #12402:
URL: https://github.com/apache/arrow/pull/12402#issuecomment-1083179426
Benchmark runs are scheduled for baseline =
64560af62391cb8823b3af3ac60991c0de59bac3 and contender =
ba04e7f8573ffd42442ffa589e4cbe61256ece7b.
ba04e7f8573ffd42442ffa589
ursabot edited a comment on pull request #12748:
URL: https://github.com/apache/arrow/pull/12748#issuecomment-1083156315
Benchmark runs are scheduled for baseline =
33df4c789e7dd6b4f590783ae69d4faa49e47e04 and contender =
64560af62391cb8823b3af3ac60991c0de59bac3.
64560af62391cb8823b3af3ac
github-actions[bot] commented on pull request #12767:
URL: https://github.com/apache/arrow/pull/12767#issuecomment-1084556954
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you op
Dandandan commented on a change in pull request #1512:
URL: https://github.com/apache/arrow-rs/pull/1512#discussion_r839589250
##
File path: arrow/src/compute/kernels/substring.rs
##
@@ -24,56 +24,74 @@ use crate::{
error::{ArrowError, Result},
};
-#[allow(clippy::unnec
codecov-commenter edited a comment on pull request #1499:
URL: https://github.com/apache/arrow-rs/pull/1499#issuecomment-1081695010
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1499?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
Dandandan commented on a change in pull request #1512:
URL: https://github.com/apache/arrow-rs/pull/1512#discussion_r839592294
##
File path: arrow/src/compute/kernels/substring.rs
##
@@ -24,56 +24,74 @@ use crate::{
error::{ArrowError, Result},
};
-#[allow(clippy::unnec
1 - 100 of 279 matches
Mail list logo
