[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12770: URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469 Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6

[GitHub] [arrow] ursabot edited a comment on pull request #12452: ARROW-14292: [C++][Python] Join foundation for Tables

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12452: URL: https://github.com/apache/arrow/pull/12452#issuecomment-1082063171 Benchmark runs are scheduled for baseline = 4d0436a04cd8e1b01b7f4ae6169973760088c702 and contender = 09a794a6977a3d44cab34db1373c632170d5bae7. 09a794a6977a3d44cab34db13

[GitHub] [arrow] ursabot edited a comment on pull request #12564: ARROW-15818: [R] Implement initial Substrait consumer in the R bindings

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12564: URL: https://github.com/apache/arrow/pull/12564#issuecomment-1081875949 Benchmark runs are scheduled for baseline = 6f9b07a41b50a6d2db37a28912ad22148453fc54 and contender = 4d0436a04cd8e1b01b7f4ae6169973760088c702. 4d0436a04cd8e1b01b7f4ae61

[GitHub] [arrow] ursabot edited a comment on pull request #12522: ARROW-15580: [Python] Make pytz an actual optional dependency of PyArrow

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12522: URL: https://github.com/apache/arrow/pull/12522#issuecomment-1082076337 Benchmark runs are scheduled for baseline = 09a794a6977a3d44cab34db1373c632170d5bae7 and contender = d7fbf5260433dee08ae219e8aec34169cd610652. d7fbf5260433dee08ae219e8a

[GitHub] [arrow] ursabot edited a comment on pull request #12768: ARROW-16082: [Flight][Go] Allow specifying a net.Listener

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12768: URL: https://github.com/apache/arrow/pull/12768#issuecomment-1085227477 Benchmark runs are scheduled for baseline = a1f32fab62540f4d4260e70f6953e96903d07a5a and contender = c845cd09db0a6ba52a574b29e15130ca2b866df3. c845cd09db0a6ba52a574b29e

[GitHub] [arrow] ursabot edited a comment on pull request #12750: MINOR: [R] add some verbosity to homebrew tests

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12750: URL: https://github.com/apache/arrow/pull/12750#issuecomment-1084856182 Benchmark runs are scheduled for baseline = d4798ef1c6428bd6f6d51e7e3b0b6579e9ba6542 and contender = a1a255bfa683dc59da36afbf4f767681e9f88327. a1a255bfa683dc59da36afbf4

[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12770: URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469 Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6

[GitHub] [arrow] ursabot edited a comment on pull request #12768: ARROW-16082: [Flight][Go] Allow specifying a net.Listener

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12768: URL: https://github.com/apache/arrow/pull/12768#issuecomment-1085227477 Benchmark runs are scheduled for baseline = a1f32fab62540f4d4260e70f6953e96903d07a5a and contender = c845cd09db0a6ba52a574b29e15130ca2b866df3. c845cd09db0a6ba52a574b29e

[GitHub] [arrow] ursabot edited a comment on pull request #12750: MINOR: [R] add some verbosity to homebrew tests

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12750: URL: https://github.com/apache/arrow/pull/12750#issuecomment-1084856182 Benchmark runs are scheduled for baseline = d4798ef1c6428bd6f6d51e7e3b0b6579e9ba6542 and contender = a1a255bfa683dc59da36afbf4f767681e9f88327. a1a255bfa683dc59da36afbf4

[GitHub] [arrow-rs] viirya edited a comment on issue #1404: Triage remaining integration test failures with other Arrow implementations

2022-04-01 Thread GitBox
viirya edited a comment on issue #1404: URL: https://github.com/apache/arrow-rs/issues/1404#issuecomment-1067593726 Working list: * generate_decimal128_case (fixed: #1439) * generate_decimal256_case (I've tried locally, but seems we don't have decimal256 support yet, so a few poin

[GitHub] [arrow-rs] HaoYang670 commented on pull request #1512: Speed up the `substring` kernel

2022-04-01 Thread GitBox
HaoYang670 commented on pull request #1512: URL: https://github.com/apache/arrow-rs/pull/1512#issuecomment-1085574499 Hi @Dandandan ! These are some changes since your last review: 1. Use dynamic `Fn` trait with `Box`, so that there is no repeated code. 2. Give up using purely function

[GitHub] [arrow-rs] HaoYang670 commented on a change in pull request #1512: Speed up the `substring` kernel

2022-04-01 Thread GitBox
HaoYang670 commented on a change in pull request #1512: URL: https://github.com/apache/arrow-rs/pull/1512#discussion_r840342708 ## File path: arrow/src/compute/kernels/substring.rs ## @@ -24,56 +24,61 @@ use crate::{ error::{ArrowError, Result}, }; -#[allow(clippy::unne

[GitHub] [arrow-rs] HaoYang670 commented on a change in pull request #1512: Speed up the `substring` kernel

2022-04-01 Thread GitBox
HaoYang670 commented on a change in pull request #1512: URL: https://github.com/apache/arrow-rs/pull/1512#discussion_r840344253 ## File path: arrow/src/compute/kernels/substring.rs ## @@ -24,56 +24,61 @@ use crate::{ error::{ArrowError, Result}, }; -#[allow(clippy::unne

[GitHub] [arrow-rs] HaoYang670 edited a comment on pull request #1512: Speed up the `substring` kernel

2022-04-01 Thread GitBox
HaoYang670 edited a comment on pull request #1512: URL: https://github.com/apache/arrow-rs/pull/1512#issuecomment-1085574499 Hi @Dandandan ! These are some changes since your last review: 1. Use dynamic `Fn` trait with `Box`, so that there is no repeated code. 2. Give up using purely f

[GitHub] [arrow-rs] HaoYang670 commented on a change in pull request #1512: Speed up the `substring` kernel

2022-04-01 Thread GitBox
HaoYang670 commented on a change in pull request #1512: URL: https://github.com/apache/arrow-rs/pull/1512#discussion_r840350610 ## File path: arrow/src/compute/kernels/substring.rs ## @@ -24,56 +24,61 @@ use crate::{ error::{ArrowError, Result}, }; -#[allow(clippy::unne

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1512: Speed up the `substring` kernel

2022-04-01 Thread GitBox
codecov-commenter edited a comment on pull request #1512: URL: https://github.com/apache/arrow-rs/pull/1512#issuecomment-1085408190 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1512?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow-rs] HaoYang670 commented on a change in pull request #1512: Speed up the `substring` kernel

2022-04-01 Thread GitBox
HaoYang670 commented on a change in pull request #1512: URL: https://github.com/apache/arrow-rs/pull/1512#discussion_r840355050 ## File path: arrow/src/compute/kernels/substring.rs ## @@ -24,56 +24,61 @@ use crate::{ error::{ArrowError, Result}, }; -#[allow(clippy::unne

[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12770: URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469 Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6

[GitHub] [arrow] ursabot edited a comment on pull request #12768: ARROW-16082: [Flight][Go] Allow specifying a net.Listener

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12768: URL: https://github.com/apache/arrow/pull/12768#issuecomment-1085227477 Benchmark runs are scheduled for baseline = a1f32fab62540f4d4260e70f6953e96903d07a5a and contender = c845cd09db0a6ba52a574b29e15130ca2b866df3. c845cd09db0a6ba52a574b29e

[GitHub] [arrow] ursabot edited a comment on pull request #12766: MINOR: [Docs] rename developers/advanced to in developers/overview dev toctree

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12766: URL: https://github.com/apache/arrow/pull/12766#issuecomment-1085333035 Benchmark runs are scheduled for baseline = c845cd09db0a6ba52a574b29e15130ca2b866df3 and contender = bda70875d2957bf1c890ef0457ce7836dd797aa6. bda70875d2957bf1c890ef045

[GitHub] [arrow] ursabot edited a comment on pull request #12770: MINOR: [R] Avoid {glue}'s whitespace trimming

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12770: URL: https://github.com/apache/arrow/pull/12770#issuecomment-1085227469 Benchmark runs are scheduled for baseline = a1a255bfa683dc59da36afbf4f767681e9f88327 and contender = a1f32fab62540f4d4260e70f6953e96903d07a5a. a1f32fab62540f4d4260e70f6

[GitHub] [arrow] ursabot edited a comment on pull request #12768: ARROW-16082: [Flight][Go] Allow specifying a net.Listener

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12768: URL: https://github.com/apache/arrow/pull/12768#issuecomment-1085227477 Benchmark runs are scheduled for baseline = a1f32fab62540f4d4260e70f6953e96903d07a5a and contender = c845cd09db0a6ba52a574b29e15130ca2b866df3. c845cd09db0a6ba52a574b29e

[GitHub] [arrow] ursabot edited a comment on pull request #12766: MINOR: [Docs] rename developers/advanced to in developers/overview dev toctree

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12766: URL: https://github.com/apache/arrow/pull/12766#issuecomment-1085333035 Benchmark runs are scheduled for baseline = c845cd09db0a6ba52a574b29e15130ca2b866df3 and contender = bda70875d2957bf1c890ef0457ce7836dd797aa6. bda70875d2957bf1c890ef045

[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #1499: Alternative implementation of nullif kernel by slicing nested buffers

2022-04-01 Thread GitBox
jhorstmann commented on a change in pull request #1499: URL: https://github.com/apache/arrow-rs/pull/1499#discussion_r840416500 ## File path: arrow/src/compute/kernels/boolean.rs ## @@ -575,10 +577,241 @@ where Ok(PrimitiveArrayfrom(data)) } +/// Creates a (mostly)

[GitHub] [arrow] AlenkaF opened a new pull request #12772: ARROW-16058: [Python] Address docstrings for Table class, methods, attributes and constructor

2022-04-01 Thread GitBox
AlenkaF opened a new pull request #12772: URL: https://github.com/apache/arrow/pull/12772 This PR adds docstring examples to: - `pyarrow.Table` class methods and attributes - `pyarrow.table` - `to_pandas` for `_PandasConvertible` - `pyarrow.TableGroupBy` class - `pyarrow.c

[GitHub] [arrow] github-actions[bot] commented on pull request #12772: ARROW-16058: [Python] Address docstrings for Table class, methods, attributes and constructor

2022-04-01 Thread GitBox
github-actions[bot] commented on pull request #12772: URL: https://github.com/apache/arrow/pull/12772#issuecomment-1085701461 https://issues.apache.org/jira/browse/ARROW-16058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] ursabot edited a comment on pull request #12452: ARROW-14292: [C++][Python] Join foundation for Tables

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12452: URL: https://github.com/apache/arrow/pull/12452#issuecomment-1082063171 Benchmark runs are scheduled for baseline = 4d0436a04cd8e1b01b7f4ae6169973760088c702 and contender = 09a794a6977a3d44cab34db1373c632170d5bae7. 09a794a6977a3d44cab34db13

[GitHub] [arrow] ursabot edited a comment on pull request #12522: ARROW-15580: [Python] Make pytz an actual optional dependency of PyArrow

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12522: URL: https://github.com/apache/arrow/pull/12522#issuecomment-1082076337 Benchmark runs are scheduled for baseline = 09a794a6977a3d44cab34db1373c632170d5bae7 and contender = d7fbf5260433dee08ae219e8aec34169cd610652. d7fbf5260433dee08ae219e8a

[GitHub] [arrow] ursabot edited a comment on pull request #12712: ARROW-16026: [C++] Add support for the serial executor to expose an async generator as an iterable

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12712: URL: https://github.com/apache/arrow/pull/12712#issuecomment-1082145892 Benchmark runs are scheduled for baseline = d7fbf5260433dee08ae219e8aec34169cd610652 and contender = b56c0d8e765b06733afb4fe07879413de759c458. b56c0d8e765b06733afb4fe07

[GitHub] [arrow-datafusion] gaojun2048 commented on pull request #1881: add udf/udaf plugin

2022-04-01 Thread GitBox
gaojun2048 commented on pull request #1881: URL: https://github.com/apache/arrow-datafusion/pull/1881#issuecomment-1085716579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [arrow] ursabot edited a comment on pull request #12712: ARROW-16026: [C++] Add support for the serial executor to expose an async generator as an iterable

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12712: URL: https://github.com/apache/arrow/pull/12712#issuecomment-1082145892 Benchmark runs are scheduled for baseline = d7fbf5260433dee08ae219e8aec34169cd610652 and contender = b56c0d8e765b06733afb4fe07879413de759c458. b56c0d8e765b06733afb4fe07

[GitHub] [arrow] ursabot edited a comment on pull request #12700: ARROW-15656: [C++] [R] Make valgrind builds slightly quicker

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12700: URL: https://github.com/apache/arrow/pull/12700#issuecomment-1082456979 Benchmark runs are scheduled for baseline = b56c0d8e765b06733afb4fe07879413de759c458 and contender = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e. 6f10dab8a2204e1fa39c851e3

[GitHub] [arrow] ursabot edited a comment on pull request #12522: ARROW-15580: [Python] Make pytz an actual optional dependency of PyArrow

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12522: URL: https://github.com/apache/arrow/pull/12522#issuecomment-1082076337 Benchmark runs are scheduled for baseline = 09a794a6977a3d44cab34db1373c632170d5bae7 and contender = d7fbf5260433dee08ae219e8aec34169cd610652. d7fbf5260433dee08ae219e8a

[GitHub] [arrow] ursabot edited a comment on pull request #12768: ARROW-16082: [Flight][Go] Allow specifying a net.Listener

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12768: URL: https://github.com/apache/arrow/pull/12768#issuecomment-1085227477 Benchmark runs are scheduled for baseline = a1f32fab62540f4d4260e70f6953e96903d07a5a and contender = c845cd09db0a6ba52a574b29e15130ca2b866df3. c845cd09db0a6ba52a574b29e

[GitHub] [arrow] ursabot edited a comment on pull request #12766: MINOR: [Docs] rename developers/advanced to in developers/overview dev toctree

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12766: URL: https://github.com/apache/arrow/pull/12766#issuecomment-1085333035 Benchmark runs are scheduled for baseline = c845cd09db0a6ba52a574b29e15130ca2b866df3 and contender = bda70875d2957bf1c890ef0457ce7836dd797aa6. bda70875d2957bf1c890ef045

[GitHub] [arrow] dragosmg commented on a change in pull request #12589: ARROW-14848 [R] Implement bindings for lubridate's parse_date_time, parse_date_time2, and fast_strptime

2022-04-01 Thread GitBox
dragosmg commented on a change in pull request #12589: URL: https://github.com/apache/arrow/pull/12589#discussion_r822916289 ## File path: r/R/dplyr-funcs-datetime.R ## @@ -167,4 +167,33 @@ register_bindings_datetime <- function() { register_binding("date", function(x) {

[GitHub] [arrow] ursabot edited a comment on pull request #12768: ARROW-16082: [Flight][Go] Allow specifying a net.Listener

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12768: URL: https://github.com/apache/arrow/pull/12768#issuecomment-1085227477 Benchmark runs are scheduled for baseline = a1f32fab62540f4d4260e70f6953e96903d07a5a and contender = c845cd09db0a6ba52a574b29e15130ca2b866df3. c845cd09db0a6ba52a574b29e

[GitHub] [arrow] ursabot edited a comment on pull request #12766: MINOR: [Docs] rename developers/advanced to in developers/overview dev toctree

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12766: URL: https://github.com/apache/arrow/pull/12766#issuecomment-1085333035 Benchmark runs are scheduled for baseline = c845cd09db0a6ba52a574b29e15130ca2b866df3 and contender = bda70875d2957bf1c890ef0457ce7836dd797aa6. bda70875d2957bf1c890ef045

[GitHub] [arrow-datafusion] yjshen opened a new pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen opened a new pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on a change in pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#discussion_r840496480 ## File path: benchmarks/queries/q1.sql ## @@ -1,21 +1,12 @@ select l_returnflag, l_linestatus, -sum(l_quantity) as sum_qty, -s

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on a change in pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#discussion_r840501793 ## File path: datafusion/core/src/physical_plan/sorts/sort2.rs ## @@ -0,0 +1,1147 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [arrow-rs] jhorstmann commented on issue #1515: cannot read parquet file

2022-04-01 Thread GitBox
jhorstmann commented on issue #1515: URL: https://github.com/apache/arrow-rs/issues/1515#issuecomment-1085798994 Can confirm the issue with the given file: ``` thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', parquet/src/record/reader.rs:134:52 stack bac

[GitHub] [arrow-datafusion] yjshen commented on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085799873 A modified version of TPC-H q1: select l_returnflag, l_linestatus, l_quantity, l_extendedprice, l_discount, l_tax fro

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen edited a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085799873 A modified version of TPC-H q1: select l_returnflag, l_linestatus, l_quantity, l_extendedprice, l_discount, l_tax

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen edited a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085799873 A modified version of TPC-H q1: ```sql select l_returnflag, l_linestatus, l_quantity, l_extendedprice, l_discount,

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on a change in pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#discussion_r840510928 ## File path: datafusion/core/src/physical_plan/sorts/sort2.rs ## @@ -0,0 +1,1147 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [arrow-datafusion] yjshen removed a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen removed a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085799873 A modified version of TPC-H q1: ```sql select l_returnflag, l_linestatus, l_quantity, l_extendedprice, l_discount,

[GitHub] [arrow-datafusion] yjshen commented on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085806095 A modified version of TPC-H q1: ```sql select l_returnflag, l_linestatus, l_quantity, l_extendedprice, l_discount, l_

[GitHub] [arrow] dragosmg commented on a change in pull request #12240: ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone

2022-04-01 Thread GitBox
dragosmg commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r840515303 ## File path: r/tests/testthat/test-Array.R ## @@ -260,18 +260,30 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2,

[GitHub] [arrow] dragosmg commented on a change in pull request #12240: ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone

2022-04-01 Thread GitBox
dragosmg commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r840515680 ## File path: r/tests/testthat/test-Array.R ## @@ -260,18 +260,30 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2,

[GitHub] [arrow] lidavidm commented on pull request #12442: ARROW-15706: [C++][FlightRPC] Implement a UCX transport

2022-04-01 Thread GitBox
lidavidm commented on pull request #12442: URL: https://github.com/apache/arrow/pull/12442#issuecomment-1085818111 For the first test: that's intentional, the test is explicitly checking what happens when we use a client connected to a server that has shut down. For the second one: I

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1509: Parquet Storage Interface (#1473)

2022-04-01 Thread GitBox
codecov-commenter commented on pull request #1509: URL: https://github.com/apache/arrow-rs/pull/1509#issuecomment-1085840903 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-datafusion] doki23 closed pull request #2054: add some pre-check for LogicalPlanBuilder

2022-04-01 Thread GitBox
doki23 closed pull request #2054: URL: https://github.com/apache/arrow-datafusion/pull/2054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github

[GitHub] [arrow-datafusion] msathis commented on a change in pull request #1969: Coalesce function

2022-04-01 Thread GitBox
msathis commented on a change in pull request #1969: URL: https://github.com/apache/arrow-datafusion/pull/1969#discussion_r840540700 ## File path: datafusion/physical-expr/src/conditional_expressions.rs ## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] [arrow] dragosmg commented on a change in pull request #12240: ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone

2022-04-01 Thread GitBox
dragosmg commented on a change in pull request #12240: URL: https://github.com/apache/arrow/pull/12240#discussion_r840553110 ## File path: r/tests/testthat/test-Array.R ## @@ -260,18 +260,30 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2,

[GitHub] [arrow] ursabot edited a comment on pull request #12766: MINOR: [Docs] rename developers/advanced to in developers/overview dev toctree

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12766: URL: https://github.com/apache/arrow/pull/12766#issuecomment-1085333035 Benchmark runs are scheduled for baseline = c845cd09db0a6ba52a574b29e15130ca2b866df3 and contender = bda70875d2957bf1c890ef0457ce7836dd797aa6. bda70875d2957bf1c890ef045

[GitHub] [arrow-rs] jhorstmann opened a new issue #1516: Allow creating buffers from externally owned memory like Vec or String

2022-04-01 Thread GitBox
jhorstmann opened a new issue #1516: URL: https://github.com/apache/arrow-rs/issues/1516 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I'd like to process data that is coming from outside arrow using arrow compute kernels w

[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #1494: RFC: Decouple buffer deallocation from ffi and allow creating buffers from rust vec

2022-04-01 Thread GitBox
jhorstmann commented on a change in pull request #1494: URL: https://github.com/apache/arrow-rs/pull/1494#discussion_r840584006 ## File path: arrow/src/alloc/mod.rs ## @@ -121,3 +124,30 @@ pub unsafe fn reallocate( handle_alloc_error(Layout::from_size_align_unchecked(n

[GitHub] [arrow] benmosher commented on issue #12663: [TS] Typescript compatibility

2022-04-01 Thread GitBox
benmosher commented on issue #12663: URL: https://github.com/apache/arrow/issues/12663#issuecomment-1085901800 I can't even import from `@apache-arrow/ts` in version 7.0.0 because of the `.js` paths. I made a [comment](https://github.com/apache/arrow/commit/20b66c255ff617c438775e54081eaa02

[GitHub] [arrow-datafusion] gaojun2048 commented on pull request #2131: [Ballista] Add ballista plugin manager and UDF plugin

2022-04-01 Thread GitBox
gaojun2048 commented on pull request #2131: URL: https://github.com/apache/arrow-datafusion/pull/2131#issuecomment-1085902625 @thinkharderdev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] ursabot edited a comment on pull request #12766: MINOR: [Docs] rename developers/advanced to in developers/overview dev toctree

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12766: URL: https://github.com/apache/arrow/pull/12766#issuecomment-1085333035 Benchmark runs are scheduled for baseline = c845cd09db0a6ba52a574b29e15130ca2b866df3 and contender = bda70875d2957bf1c890ef0457ce7836dd797aa6. bda70875d2957bf1c890ef045

[GitHub] [arrow-rs] tustvold commented on issue #1473: Requirements for Async Parquet API

2022-04-01 Thread GitBox
tustvold commented on issue #1473: URL: https://github.com/apache/arrow-rs/issues/1473#issuecomment-1085914732 Ok so an update on this. I implemented this proposal in #1509, along with a number of modifications to help improve its performance - e.g. avoid copying buffers, etc... I then cre

[GitHub] [arrow] ursabot edited a comment on pull request #12728: ARROW-16042: [GO] Fix header file preprocessor issues

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12728: URL: https://github.com/apache/arrow/pull/12728#issuecomment-1082511579 Benchmark runs are scheduled for baseline = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e and contender = ac58b8d5e5f424e2f81da680d3e5c2278c8ed92c. ac58b8d5e5f424e2f81da680d

[GitHub] [arrow] ursabot edited a comment on pull request #12712: ARROW-16026: [C++] Add support for the serial executor to expose an async generator as an iterable

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12712: URL: https://github.com/apache/arrow/pull/12712#issuecomment-1082145892 Benchmark runs are scheduled for baseline = d7fbf5260433dee08ae219e8aec34169cd610652 and contender = b56c0d8e765b06733afb4fe07879413de759c458. b56c0d8e765b06733afb4fe07

[GitHub] [arrow] ursabot edited a comment on pull request #12700: ARROW-15656: [C++] [R] Make valgrind builds slightly quicker

2022-04-01 Thread GitBox
ursabot edited a comment on pull request #12700: URL: https://github.com/apache/arrow/pull/12700#issuecomment-1082456979 Benchmark runs are scheduled for baseline = b56c0d8e765b06733afb4fe07879413de759c458 and contender = 6f10dab8a2204e1fa39c851e3ccc1f17d48b275e. 6f10dab8a2204e1fa39c851e3

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on a change in pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#discussion_r840501793 ## File path: datafusion/core/src/physical_plan/sorts/sort2.rs ## @@ -0,0 +1,1147 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on a change in pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#discussion_r840501793 ## File path: datafusion/core/src/physical_plan/sorts/sort2.rs ## @@ -0,0 +1,1147 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [arrow-datafusion] yjshen commented on a change in pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on a change in pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#discussion_r840510928 ## File path: datafusion/core/src/physical_plan/sorts/sort2.rs ## @@ -0,0 +1,1147 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [arrow-datafusion] tustvold commented on issue #2044: wrong result when operation parquet

2022-04-01 Thread GitBox
tustvold commented on issue #2044: URL: https://github.com/apache/arrow-datafusion/issues/2044#issuecomment-1085943742 This is likely related to https://github.com/apache/arrow-rs/issues/1459 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [arrow] cyb70289 commented on pull request #12442: ARROW-15706: [C++][FlightRPC] Implement a UCX transport

2022-04-01 Thread GitBox
cyb70289 commented on pull request #12442: URL: https://github.com/apache/arrow/pull/12442#issuecomment-1085951869 > Unfortunately, it's not suitable in my testing, because it requires setting up an error handler, and I found that doing this disables certain transports by default, most not

[GitHub] [arrow-datafusion] yjshen commented on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen commented on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085966913 On a newer Linux Desktop: ``` H/W path Device Class Description =

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen edited a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085966913 A modified version of TPC-H q1: ```sql select l_returnflag, l_linestatus, l_quantity, l_extendedprice, l_discount,

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840652075 ## File path: cpp/src/arrow/dataset/file_ipc.cc ## @@ -151,6 +171,13 @@ Result IpcFileFormat::ScanBatchesAsync( ARROW_ASSIGN_OR_RAISE(generator,

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen edited a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085966913 On a newer Linux Desktop: ``` H/W path Device Class Description ==

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840652525 ## File path: cpp/src/arrow/dataset/file_ipc.cc ## @@ -151,6 +171,13 @@ Result IpcFileFormat::ScanBatchesAsync( ARROW_ASSIGN_OR_RAISE(generator,

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840653966 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -146,6 +210,22 @@ opentelemetry::trace::StartSpanOptions SpanOptionsWithParent( retu

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840654393 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -146,6 +210,22 @@ opentelemetry::trace::StartSpanOptions SpanOptionsWithParent( retu

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840655386 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -101,6 +102,69 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, }; } +/// \

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840655533 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -101,6 +102,69 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, }; } +/// \

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840656652 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -101,6 +102,69 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, }; } +/// \

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840658110 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -88,9 +88,10 @@ Iterator WrapIterator( template AsyncGenerator WrapAsyncGenerator(AsyncGe

[GitHub] [arrow] dragosmg commented on pull request #12589: ARROW-14848 [R] Implement bindings for lubridate's parse_date_time, parse_date_time2, and fast_strptime

2022-04-01 Thread GitBox
dragosmg commented on pull request #12589: URL: https://github.com/apache/arrow/pull/12589#issuecomment-1085989317 There seems to be a registration issue with `replace_substring_regex`: https://github.com/apache/arrow/runs/5787187215?check_suite_focus=true#step:20:18491 -- This is an aut

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840659660 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -88,9 +88,10 @@ Iterator WrapIterator( template AsyncGenerator WrapAsyncGenerator(AsyncGe

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840662518 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -88,9 +88,10 @@ Iterator WrapIterator( template AsyncGenerator WrapAsyncGenerator(AsyncGe

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840662518 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -88,9 +88,10 @@ Iterator WrapIterator( template AsyncGenerator WrapAsyncGenerator(AsyncGe

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840658110 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -88,9 +88,10 @@ Iterator WrapIterator( template AsyncGenerator WrapAsyncGenerator(AsyncGe

[GitHub] [arrow] joosthooz commented on a change in pull request #12609: ARROW-15067: [C++] Add tracing spans to the scanner

2022-04-01 Thread GitBox
joosthooz commented on a change in pull request #12609: URL: https://github.com/apache/arrow/pull/12609#discussion_r840655386 ## File path: cpp/src/arrow/util/tracing_internal.h ## @@ -101,6 +102,69 @@ AsyncGenerator WrapAsyncGenerator(AsyncGenerator wrapped, }; } +/// \

[GitHub] [arrow] dhruv9vats commented on pull request #12724: ARROW-15643: [C++] Cast to select subset of fields of a StructArray

2022-04-01 Thread GitBox
dhruv9vats commented on pull request #12724: URL: https://github.com/apache/arrow/pull/12724#issuecomment-1086001429 Would we have to address the other cases talked about in the JIRA in this PR itself, or will that involve follow-up PRs? -- This is an automated message from the Apache Gi

[GitHub] [arrow-datafusion] yjshen removed a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen removed a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085806095 A modified version of TPC-H q1: ```sql select l_returnflag, l_linestatus, l_quantity, l_extendedprice, l_discount,

[GitHub] [arrow] jonkeane commented on a change in pull request #12769: ARROW-16076: [R] Bindings for the new TPC-H generator

2022-04-01 Thread GitBox
jonkeane commented on a change in pull request #12769: URL: https://github.com/apache/arrow/pull/12769#discussion_r840671717 ## File path: r/src/tpch-gen.cpp ## @@ -0,0 +1,168 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

[GitHub] [arrow] jonkeane commented on a change in pull request #12769: ARROW-16076: [R] Bindings for the new TPC-H generator

2022-04-01 Thread GitBox
jonkeane commented on a change in pull request #12769: URL: https://github.com/apache/arrow/pull/12769#discussion_r840674052 ## File path: r/src/tpch-gen.cpp ## @@ -0,0 +1,167 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

[GitHub] [arrow] jonkeane commented on a change in pull request #12769: ARROW-16076: [R] Bindings for the new TPC-H generator

2022-04-01 Thread GitBox
jonkeane commented on a change in pull request #12769: URL: https://github.com/apache/arrow/pull/12769#discussion_r840675008 ## File path: r/R/tpch.R ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

[GitHub] [arrow] jonkeane commented on a change in pull request #12769: ARROW-16076: [R] Bindings for the new TPC-H generator

2022-04-01 Thread GitBox
jonkeane commented on a change in pull request #12769: URL: https://github.com/apache/arrow/pull/12769#discussion_r840675008 ## File path: r/R/tpch.R ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

[GitHub] [arrow] jonkeane commented on a change in pull request #12769: ARROW-16076: [R] Bindings for the new TPC-H generator

2022-04-01 Thread GitBox
jonkeane commented on a change in pull request #12769: URL: https://github.com/apache/arrow/pull/12769#discussion_r840676107 ## File path: r/src/tpch-gen.cpp ## @@ -0,0 +1,167 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen edited a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085966913 On a newer Linux Desktop: ``` H/W path Device Class Description ==

[GitHub] [arrow-datafusion] yjshen edited a comment on pull request #2132: WIP: Reduce sort memory usage v1

2022-04-01 Thread GitBox
yjshen edited a comment on pull request #2132: URL: https://github.com/apache/arrow-datafusion/pull/2132#issuecomment-1085966913 On my Linux Desktop: ``` H/W path Device Class Description ===

[GitHub] [arrow] jonkeane commented on a change in pull request #12769: ARROW-16076: [R] Bindings for the new TPC-H generator

2022-04-01 Thread GitBox
jonkeane commented on a change in pull request #12769: URL: https://github.com/apache/arrow/pull/12769#discussion_r840677810 ## File path: r/src/tpch-gen.cpp ## @@ -0,0 +1,167 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

[GitHub] [arrow] Johnnathanalmeida commented on pull request #12758: [Gandiva][C++] Fix castINTERVALDAY and castINTERVALYEAR

2022-04-01 Thread GitBox
Johnnathanalmeida commented on pull request #12758: URL: https://github.com/apache/arrow/pull/12758#issuecomment-1086020388 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-rs] alamb merged pull request #1514: Prepare for release version `11.1.0`

2022-04-01 Thread GitBox
alamb merged pull request #1514: URL: https://github.com/apache/arrow-rs/pull/1514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] lidavidm commented on pull request #12724: ARROW-15643: [C++] Cast to select subset of fields of a StructArray

2022-04-01 Thread GitBox
lidavidm commented on pull request #12724: URL: https://github.com/apache/arrow/pull/12724#issuecomment-1086087718 I think we can file a separate JIRA to handle reordering fields via a cast. -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   3   >