[GitHub] [arrow] AlenkaF commented on pull request #14275: ARROW-17160: [C++] Create a base directory for PyArrow CPP header files

2022-10-07 Thread GitBox
AlenkaF commented on PR #14275: URL: https://github.com/apache/arrow/pull/14275#issuecomment-1271193121 Done: https://issues.apache.org/jira/browse/ARROW-17958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [arrow-julia] bkamins commented on issue #324: filtering DataFrame loaded from feather file triggers `deleteat!` error

2022-10-07 Thread GitBox
bkamins commented on issue #324: URL: https://github.com/apache/arrow-julia/issues/324#issuecomment-1271193134 @quinnj - I would propose to resolve it in Arrow.jl. I.e. add a method `deleteat!` for `::Arrow.Primitive` (or whatever type makes sense) that throws an informative error. The poin

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14333: ARROW-17950: [Docs][Python] Add more info about the change in PyArrow C++ API

2022-10-07 Thread GitBox
jorisvandenbossche commented on code in PR #14333: URL: https://github.com/apache/arrow/pull/14333#discussion_r989777443 ## docs/source/python/integration/extending.rst: ## @@ -50,12 +50,23 @@ This will not include other parts of the Arrow API, which you will need to include y

[GitHub] [arrow] pitrou commented on a diff in pull request #14339: ARROW-17927: [C++] Changed SleepABitAsync to use a thread pool to reduce the # of threads required

2022-10-07 Thread GitBox
pitrou commented on code in PR #14339: URL: https://github.com/apache/arrow/pull/14339#discussion_r989787914 ## cpp/src/arrow/testing/gtest_util.cc: ## @@ -767,22 +769,20 @@ void BusyWait(double seconds, std::function predicate) { } } -Future<> SleepAsync(double seconds)

[GitHub] [arrow-datafusion] b41sh commented on a diff in pull request #3732: fix subquery where exists distinct

2022-10-07 Thread GitBox
b41sh commented on code in PR #3732: URL: https://github.com/apache/arrow-datafusion/pull/3732#discussion_r989794524 ## datafusion/optimizer/src/decorrelate_where_exists.rs: ## @@ -137,8 +137,14 @@ fn optimize_exists( let subqry_inputs = query_info.query.subquery.inputs();

[GitHub] [arrow] kou commented on a diff in pull request #14333: ARROW-17950: [Docs][Python] Add more info about the change in PyArrow C++ API

2022-10-07 Thread GitBox
kou commented on code in PR #14333: URL: https://github.com/apache/arrow/pull/14333#discussion_r989799690 ## docs/source/python/integration/extending.rst: ## @@ -50,12 +50,23 @@ This will not include other parts of the Arrow API, which you will need to include yourself (for ex

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2840: Expose ArrowNativeTypeOp trait to make it useful for type bound

2022-10-07 Thread GitBox
tustvold commented on code in PR #2840: URL: https://github.com/apache/arrow-rs/pull/2840#discussion_r989796756 ## arrow/src/datatypes/native.rs: ## @@ -16,114 +16,113 @@ // under the License. use crate::error::{ArrowError, Result}; +pub use arrow_array::ArrowPrimitiveType;

[GitHub] [arrow] ursabot commented on pull request #14329: ARROW-17945: [Website][Release] Use https:// for search.maven.org

2022-10-07 Thread GitBox
ursabot commented on PR #14329: URL: https://github.com/apache/arrow/pull/14329#issuecomment-1271256346 Benchmark runs are scheduled for baseline = 2fca0b4e0d00d91518b7f427e886fb0212359101 and contender = c29ca51f44eaf41c3a2f6f72e3e23a7b428211c2. c29ca51f44eaf41c3a2f6f72e3e23a7b428211c2 is

[GitHub] [arrow-rs] tustvold closed issue #2839: Introducing ArrowNativeTypeOp made it impossible to call kernels from generics

2022-10-07 Thread GitBox
tustvold closed issue #2839: Introducing ArrowNativeTypeOp made it impossible to call kernels from generics URL: https://github.com/apache/arrow-rs/issues/2839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-rs] tustvold merged pull request #2840: Expose ArrowNativeTypeOp trait to make it useful for type bound

2022-10-07 Thread GitBox
tustvold merged PR #2840: URL: https://github.com/apache/arrow-rs/pull/2840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [arrow] kiszk commented on pull request #14275: ARROW-17160: [C++] Create a base directory for PyArrow CPP header files

2022-10-07 Thread GitBox
kiszk commented on PR #14275: URL: https://github.com/apache/arrow/pull/14275#issuecomment-1271264978 I am sorry for rerunning this travis ci job at https://app.travis-ci.com/github/apache/arrow/builds/256419696 while the job was succeeded. -- This is an automated message from the Apache

[GitHub] [arrow-rs] ursabot commented on pull request #2840: Expose ArrowNativeTypeOp trait to make it useful for type bound

2022-10-07 Thread GitBox
ursabot commented on PR #2840: URL: https://github.com/apache/arrow-rs/pull/2840#issuecomment-1271266388 Benchmark runs are scheduled for baseline = 37c867921c434974e908b22bafe0fc84f0de2ad0 and contender = 8dd94a97441822c88274d31b6782fb6bf3e4ecd8. 8dd94a97441822c88274d31b6782fb6bf3e4ecd8 i

[GitHub] [arrow] AlenkaF commented on pull request #14275: ARROW-17160: [C++] Create a base directory for PyArrow CPP header files

2022-10-07 Thread GitBox
AlenkaF commented on PR #14275: URL: https://github.com/apache/arrow/pull/14275#issuecomment-1271266519 > I am sorry for rerunning this travis ci job at https://app.travis-ci.com/github/apache/arrow/builds/256419696 while the job was already succeeded. No problem at all =) -- This

[GitHub] [arrow] kou opened a new pull request, #14342: ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel

2022-10-07 Thread GitBox
kou opened a new pull request, #14342: URL: https://github.com/apache/arrow/pull/14342 If we build with -DCMAKE_BUILD_TYPE=MinSizeRel, our SIMD related code may violate the one-definition-rule. See also ARROW-15664 and https://issues.apache.org/jira/browse/ARROW-15678?focusedCommentId=17613

[GitHub] [arrow] kou commented on pull request #14342: ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel

2022-10-07 Thread GitBox
kou commented on PR #14342: URL: https://github.com/apache/arrow/pull/14342#issuecomment-1271300369 @github-actions crossbow submit test-r-install-local-minsizerel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [arrow] github-actions[bot] commented on pull request #14342: ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14342: URL: https://github.com/apache/arrow/pull/14342#issuecomment-1271300442 https://issues.apache.org/jira/browse/ARROW-15678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #14342: ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14342: URL: https://github.com/apache/arrow/pull/14342#issuecomment-1271300491 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #14342: ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14342: URL: https://github.com/apache/arrow/pull/14342#issuecomment-1271302524 Revision: 22cdaf67f926fd0fb0204ef8084372780acc0a73 Submitted crossbow builds: [ursacomputing/crossbow @ actions-de96a45a25](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] nosterlu commented on issue #13747: [Python] group_by functionality directly on large dataset, instead of on a table?

2022-10-07 Thread GitBox
nosterlu commented on issue #13747: URL: https://github.com/apache/arrow/issues/13747#issuecomment-1271311187 Thank you @legout. Duckdb works really well, but polars is struggling. Maybe I am doing something wrong. But anyway here is how it worked for me ```python # pyarrow

[GitHub] [arrow] kou commented on pull request #14342: ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel

2022-10-07 Thread GitBox
kou commented on PR #14342: URL: https://github.com/apache/arrow/pull/14342#issuecomment-1271314326 @github-actions crossbow submit test-r-install-local-minsizerel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [arrow] github-actions[bot] commented on pull request #14342: ARROW-15678: [C++] Add support for -DCMAKE_BUILD_TYPE=MinSizeRel

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14342: URL: https://github.com/apache/arrow/pull/14342#issuecomment-1271316132 Revision: 1f4d567127ad2cc607af6136da31dd8e6ec8b795 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1d3ee175be](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] milesgranger commented on pull request #14106: ARROW-15545: [Python][C++] Support casting to extension type

2022-10-07 Thread GitBox
milesgranger commented on PR #14106: URL: https://github.com/apache/arrow/pull/14106#issuecomment-1271331799 Is there anything else we ought to address? I don't think the two failing jobs are related. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [arrow-datafusion] zhoudongyan opened a new pull request, #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
zhoudongyan opened a new pull request, #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751 # Which issue does this PR close? Closes #3733 # Rationale for this change # What changes are included in this PR? Changes: do not use col(), w

[GitHub] [arrow] raulcd commented on pull request #13552: Enable Cython tests on windows wheels

2022-10-07 Thread GitBox
raulcd commented on PR #13552: URL: https://github.com/apache/arrow/pull/13552#issuecomment-1271356322 @github-actions crossbow submit wheel-windows* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #13552: Enable Cython tests on windows wheels

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #13552: URL: https://github.com/apache/arrow/pull/13552#issuecomment-1271358184 Revision: 49b13998271a4cce6ae42a18207d7b18b7d55713 Submitted crossbow builds: [ursacomputing/crossbow @ actions-44417c02af](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow-datafusion] zhoudongyan commented on pull request #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
zhoudongyan commented on PR #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751#issuecomment-1271363363 @alamb PTAL, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-rs] tustvold commented on issue #2647: Divide By Zero Panics in Unchecked Arithmetic Kernels

2022-10-07 Thread GitBox
tustvold commented on issue #2647: URL: https://github.com/apache/arrow-rs/issues/2647#issuecomment-1271377326 Further to this the divide kernel is currently using `math_op` which assumes no side-effects as it evaluates for null slots. This effectively makes the current kernel useless for i

[GitHub] [arrow-datafusion] liukun4515 opened a new issue, #3752: move `type coercion` for agg/agg udf

2022-10-07 Thread GitBox
liukun4515 opened a new issue, #3752: URL: https://github.com/apache/arrow-datafusion/issues/3752 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** part of https://github.com/apache/arrow-datafusion/issues/3582 **Describe the

[GitHub] [arrow-rs] tustvold opened a new pull request, #2841: Simplify ArrowNativeType

2022-10-07 Thread GitBox
tustvold opened a new pull request, #2841: URL: https://github.com/apache/arrow-rs/pull/2841 # Which issue does this PR close? Closes #. # Rationale for this change #2840 made this public, prior to releasing lets take the opportunity to clean it up a a b

[GitHub] [arrow-rs] alamb commented on issue #2837: Inconsistent Dyn Scalar Kernels

2022-10-07 Thread GitBox
alamb commented on issue #2837: URL: https://github.com/apache/arrow-rs/issues/2837#issuecomment-1271392250 Other related PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] alamb commented on issue #2837: Inconsistent Dyn Scalar Kernels

2022-10-07 Thread GitBox
alamb commented on issue #2837: URL: https://github.com/apache/arrow-rs/issues/2837#issuecomment-1271391847 Renaming the kernels sounds good to me 👍 > I would therefore like to propose adding new [eq | lt_eq | ...]_dyn_primitive_scalar comparison kernels, and deprecating the old [eq

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2841: Simplify ArrowNativeType

2022-10-07 Thread GitBox
tustvold commented on code in PR #2841: URL: https://github.com/apache/arrow-rs/pull/2841#discussion_r989920458 ## arrow/src/datatypes/native.rs: ## @@ -19,110 +19,72 @@ use crate::error::{ArrowError, Result}; pub use arrow_array::ArrowPrimitiveType; pub use arrow_buffer::{Arr

[GitHub] [arrow] romainfrancois commented on a diff in pull request #14271: ARROW-17187: [R] Improve lazy ALTREP implementation for String

2022-10-07 Thread GitBox
romainfrancois commented on code in PR #14271: URL: https://github.com/apache/arrow/pull/14271#discussion_r989930529 ## r/src/altrep.cpp: ## @@ -800,41 +864,35 @@ struct AltrepVectorString : public AltrepVectorBase> { return Representation(alt); } -BEGIN_CPP11

[GitHub] [arrow] legout closed issue #14336: Large differences in loading time, whe loading data from s3 bucket depending on filesystem

2022-10-07 Thread GitBox
legout closed issue #14336: Large differences in loading time, whe loading data from s3 bucket depending on filesystem URL: https://github.com/apache/arrow/issues/14336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] milesgranger commented on pull request #14326: ARROW-14596: [C++][Python] Read table nested struct fields in columns

2022-10-07 Thread GitBox
milesgranger commented on PR #14326: URL: https://github.com/apache/arrow/pull/14326#issuecomment-1271411341 I generally agree with the first two points, although I do like the explicitness of a leading dot. The third point, it could be a potentially buggy convenience add on. ie. `

[GitHub] [arrow-datafusion] alamb commented on pull request #3578: extract OR clause for join

2022-10-07 Thread GitBox
alamb commented on PR #3578: URL: https://github.com/apache/arrow-datafusion/pull/3578#issuecomment-1271411927 I am sorry for the late review here -- it is on my list. Basically I am struggling to find time enough to sit down and convince myself that this is a correct transformation in all

[GitHub] [arrow-rs] tustvold commented on issue #2837: Inconsistent Dyn Scalar Kernels

2022-10-07 Thread GitBox
tustvold commented on issue #2837: URL: https://github.com/apache/arrow-rs/issues/2837#issuecomment-1271416479 > Would it be better to simply not have the dyn_primitive_scalar kernels and instead use docstrings or something else to show how to the kernels with primitives? The issue i

[GitHub] [arrow] github-actions[bot] commented on pull request #14343: ARROW-17863: [Python] Deprecate Plasma Python bindings

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14343: URL: https://github.com/apache/arrow/pull/14343#issuecomment-1271419043 https://issues.apache.org/jira/browse/ARROW-17863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-rs] alamb commented on issue #2837: Inconsistent Dyn Scalar Kernels

2022-10-07 Thread GitBox
alamb commented on issue #2837: URL: https://github.com/apache/arrow-rs/issues/2837#issuecomment-1271423016 If https://github.com/apache/arrow-rs/pull/1074#issuecomment-999105444 causes issues for the rest of the implementation, I don't feel strongly about it -- This is an automated messa

[GitHub] [arrow] js8544 commented on pull request #14310: ARROW-17872: [C++][CI] Reduce macOS CI dependencies

2022-10-07 Thread GitBox
js8544 commented on PR #14310: URL: https://github.com/apache/arrow/pull/14310#issuecomment-1271431401 @github-actions crossbow submit -g nightly-release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] jorisvandenbossche commented on pull request #14343: ARROW-17863: [Python] Deprecate Plasma Python bindings

2022-10-07 Thread GitBox
jorisvandenbossche commented on PR #14343: URL: https://github.com/apache/arrow/pull/14343#issuecomment-1271432647 You still need to add warnings in the code as well? (`warnings.warn(..)`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] github-actions[bot] commented on pull request #14310: ARROW-17872: [C++][CI] Reduce macOS CI dependencies

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14310: URL: https://github.com/apache/arrow/pull/14310#issuecomment-1271432890 Revision: 082fe8fa4c44e9949f02c9ce74ac42af2419a788 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1eda97770c](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] js8544 commented on a diff in pull request #14310: ARROW-17872: [C++][CI] Reduce macOS CI dependencies

2022-10-07 Thread GitBox
js8544 commented on code in PR #14310: URL: https://github.com/apache/arrow/pull/14310#discussion_r98995 ## cpp/Brewfile: ## @@ -28,8 +28,6 @@ brew "git" brew "glog" brew "googletest" brew "grpc" -brew "llvm" -brew "llvm@12" Review Comment: done -- This is an auto

[GitHub] [arrow-datafusion] alamb commented on pull request #3742: Introduce public API to call type coercion

2022-10-07 Thread GitBox
alamb commented on PR #3742: URL: https://github.com/apache/arrow-datafusion/pull/3742#issuecomment-1271435093 I have had some thoughts about this API and want to try something different -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] js8544 commented on a diff in pull request #14310: ARROW-17872: [C++][CI] Reduce macOS CI dependencies

2022-10-07 Thread GitBox
js8544 commented on code in PR #14310: URL: https://github.com/apache/arrow/pull/14310#discussion_r989957207 ## .github/workflows/cpp.yml: ## @@ -182,10 +182,9 @@ jobs: key: cpp-ccache-macos-${{ hashFiles('cpp/**') }} restore-keys: cpp-ccache-macos-

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
alamb commented on code in PR #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751#discussion_r989957630 ## datafusion/core/src/dataframe.rs: ## @@ -125,7 +125,10 @@ impl DataFrame { .iter() .map(|name| self.plan.schema().field_with_unqualif

[GitHub] [arrow-datafusion] alamb commented on issue #3671: DataFusion 13.0.0 Release

2022-10-07 Thread GitBox
alamb commented on issue #3671: URL: https://github.com/apache/arrow-datafusion/issues/3671#issuecomment-1271438793 BTW I have a half written blog post about DataFusion improvements in the last 3-6 months which I hope to get up shortly. Thanks @andygrove -- This is an automated message

[GitHub] [arrow] raulcd commented on pull request #13552: Enable Cython tests on windows wheels

2022-10-07 Thread GitBox
raulcd commented on PR #13552: URL: https://github.com/apache/arrow/pull/13552#issuecomment-1271439210 @github-actions crossbow submit wheel-windows* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #13552: Enable Cython tests on windows wheels

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #13552: URL: https://github.com/apache/arrow/pull/13552#issuecomment-1271440772 Revision: 34a9915fc57bdf5c7a407114449173b452c67b19 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c6b9cae0e0](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow-datafusion] alamb commented on pull request #3746: Prep for 13.0.0 release

2022-10-07 Thread GitBox
alamb commented on PR #3746: URL: https://github.com/apache/arrow-datafusion/pull/3746#issuecomment-1271453495 LGTM -- luck number 13~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3746: Prep for 13.0.0 release

2022-10-07 Thread GitBox
alamb commented on code in PR #3746: URL: https://github.com/apache/arrow-datafusion/pull/3746#discussion_r989960678 ## datafusion/CHANGELOG.md: ## @@ -19,6 +19,222 @@ # Changelog +## [13.0.0](https://github.com/apache/arrow-datafusion/tree/13.0.0) (2022-10-06) + +[Full C

[GitHub] [arrow-datafusion] alamb merged pull request #3746: Prep for 13.0.0 release

2022-10-07 Thread GitBox
alamb merged PR #3746: URL: https://github.com/apache/arrow-datafusion/pull/3746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-datafusion] ursabot commented on pull request #3746: Prep for 13.0.0 release

2022-10-07 Thread GitBox
ursabot commented on PR #3746: URL: https://github.com/apache/arrow-datafusion/pull/3746#issuecomment-1271454811 Benchmark runs are scheduled for baseline = 242b5c5427c4c2322a6530c3cd813ffcee30a234 and contender = 807a0c1d2963f6ca327d316badb4ed0fa77e9f21. 807a0c1d2963f6ca327d316badb4ed0fa

[GitHub] [arrow] thisisnic commented on pull request #14276: ARROW-17366: [R] Support purrr-style lambda functions in .fns argument to across()

2022-10-07 Thread GitBox
thisisnic commented on PR #14276: URL: https://github.com/apache/arrow/pull/14276#issuecomment-1271457157 Closing this PR to merge the other one which I needed to open to run things on CI after it was approved - https://github.com/apache/arrow/pull/14327 -- This is an automated message fr

[GitHub] [arrow] thisisnic closed pull request #14276: ARROW-17366: [R] Support purrr-style lambda functions in .fns argument to across()

2022-10-07 Thread GitBox
thisisnic closed pull request #14276: ARROW-17366: [R] Support purrr-style lambda functions in .fns argument to across() URL: https://github.com/apache/arrow/pull/14276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] thisisnic commented on pull request #14327: ARROW-17366: [R] Support purrr-style lambda functions in .fns argument to across()

2022-10-07 Thread GitBox
thisisnic commented on PR #14327: URL: https://github.com/apache/arrow/pull/14327#issuecomment-1271458100 See https://github.com/apache/arrow/pull/14276 for code review - needed to open a second PR due to CI not running on changes made after approval -- This is an automated message from

[GitHub] [arrow] thisisnic merged pull request #14327: ARROW-17366: [R] Support purrr-style lambda functions in .fns argument to across()

2022-10-07 Thread GitBox
thisisnic merged PR #14327: URL: https://github.com/apache/arrow/pull/14327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [arrow] AlenkaF commented on pull request #14343: ARROW-17863: [Python] Deprecate Plasma Python bindings

2022-10-07 Thread GitBox
AlenkaF commented on PR #14343: URL: https://github.com/apache/arrow/pull/14343#issuecomment-1271471985 Thanks @jorisvandenbossche, wasn't sure what is still missing! Will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [arrow-datafusion] unvalley commented on pull request #3750: Fix `ListingTableUrl` to decode percent

2022-10-07 Thread GitBox
unvalley commented on PR #3750: URL: https://github.com/apache/arrow-datafusion/pull/3750#issuecomment-1271478747 @alamb PTAL? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [arrow-rs] tustvold opened a new issue, #2842: RFC: Encode Scalars as `dyn Any` in Scalar dyn Kernels

2022-10-07 Thread GitBox
tustvold opened a new issue, #2842: URL: https://github.com/apache/arrow-rs/issues/2842 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** As expanded upon in https://github.com/apache/arrow-rs/issues/2837 currently the encod

[GitHub] [arrow-rs] tustvold commented on issue #2837: Inconsistent Dyn Scalar Kernels

2022-10-07 Thread GitBox
tustvold commented on issue #2837: URL: https://github.com/apache/arrow-rs/issues/2837#issuecomment-1271482265 Alternative proposal in https://github.com/apache/arrow-rs/issues/2842 - FWIW this would allow removing a lot of scalar dispatch logic from DataFusion -- This is an automated mes

[GitHub] [arrow] js8544 commented on pull request #14310: ARROW-17872: [C++][CI] Reduce macOS CI dependencies

2022-10-07 Thread GitBox
js8544 commented on PR #14310: URL: https://github.com/apache/arrow/pull/14310#issuecomment-1271488708 @github-actions crossbow submit -g nightly-release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow-rs] tustvold opened a new pull request, #2843: Update actions/labeler to v4.0.2

2022-10-07 Thread GitBox
tustvold opened a new pull request, #2843: URL: https://github.com/apache/arrow-rs/pull/2843 Perhaps this will stop it failing??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow] github-actions[bot] commented on pull request #14310: ARROW-17872: [C++][CI] Reduce macOS CI dependencies

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14310: URL: https://github.com/apache/arrow/pull/14310#issuecomment-1271490288 Revision: 7b3e76886bd0cb200500b38846ff3a790f1e0e8e Submitted crossbow builds: [ursacomputing/crossbow @ actions-91a5712953](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow-rs] tustvold commented on pull request #2843: Update actions/labeler to v4.0.2

2022-10-07 Thread GitBox
tustvold commented on PR #2843: URL: https://github.com/apache/arrow-rs/pull/2843#issuecomment-1271490611 ![image](https://user-images.githubusercontent.com/1781103/194546413-ef08d5eb-46bd-48cf-b3f0-30d12d76e0e3.png) :tada: -- This is an automated message from the Apache Git Service. T

[GitHub] [arrow] lidavidm commented on issue #14336: Large differences in loading time, whe loading data from s3 bucket depending on filesystem

2022-10-07 Thread GitBox
lidavidm commented on issue #14336: URL: https://github.com/apache/arrow/issues/14336#issuecomment-1271493192 This is https://issues.apache.org/jira/browse/ARROW-17961 for completeness -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-rs] tustvold merged pull request #2843: Update actions/labeler to v4.0.2

2022-10-07 Thread GitBox
tustvold merged PR #2843: URL: https://github.com/apache/arrow-rs/pull/2843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [arrow-datafusion] zhoudongyan commented on pull request #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
zhoudongyan commented on PR #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751#issuecomment-1271500640 @alamb May I know how can I fix the failed check so I can merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow-rs] ursabot commented on pull request #2843: Update actions/labeler to v4.0.2

2022-10-07 Thread GitBox
ursabot commented on PR #2843: URL: https://github.com/apache/arrow-rs/pull/2843#issuecomment-1271501553 Benchmark runs are scheduled for baseline = 8dd94a97441822c88274d31b6782fb6bf3e4ecd8 and contender = fe6c66c4cb2e3d37fed25b85c138ecf9a03928f0. fe6c66c4cb2e3d37fed25b85c138ecf9a03928f0 i

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3750: Fix `ListingTableUrl` to decode percent

2022-10-07 Thread GitBox
tustvold commented on code in PR #3750: URL: https://github.com/apache/arrow-datafusion/pull/3750#discussion_r990014407 ## datafusion/core/src/datasource/listing/url.rs: ## @@ -108,7 +109,8 @@ impl ListingTableUrl { /// Creates a new [`ListingTableUrl`] from a url and opt

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3750: Fix `ListingTableUrl` to decode percent

2022-10-07 Thread GitBox
tustvold commented on code in PR #3750: URL: https://github.com/apache/arrow-datafusion/pull/3750#discussion_r990015784 ## datafusion/core/src/datasource/listing/url.rs: ## @@ -246,6 +248,9 @@ mod tests { let url = ListingTableUrl::parse("file:///foo").unwrap();

[GitHub] [arrow-datafusion] Dandandan commented on issue #3747: DataFusionError(Internal("The size of the sorted batch is larger than the size of the input batch: 2120 > 2312"))

2022-10-07 Thread GitBox
Dandandan commented on issue #3747: URL: https://github.com/apache/arrow-datafusion/issues/3747#issuecomment-1271514648 I think the code should update the size > I think I am able to trigger it using the query below: > > ```sql > CREATE EXTERNAL TABLE decimal_simple ( >

[GitHub] [arrow-ballista] andygrove opened a new pull request, #326: update labeler

2022-10-07 Thread GitBox
andygrove opened a new pull request, #326: URL: https://github.com/apache/arrow-ballista/pull/326 # Which issue does this PR close? N/A # Rationale for this change Fix labeler action # What changes are included in this PR? # Are there any us

[GitHub] [arrow-ballista] andygrove merged pull request #324: Dependabot stop suggesting arrow and datafusion updates

2022-10-07 Thread GitBox
andygrove merged PR #324: URL: https://github.com/apache/arrow-ballista/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2841: Simplify ArrowNativeType

2022-10-07 Thread GitBox
tustvold commented on code in PR #2841: URL: https://github.com/apache/arrow-rs/pull/2841#discussion_r990026535 ## arrow/src/compute/kernels/arithmetic.rs: ## @@ -2145,23 +2145,13 @@ mod tests { } #[test] -#[cfg(not(feature = "simd"))] fn test_int_array_modu

[GitHub] [arrow-rs] tustvold opened a new pull request, #2844: Add labeller permissions block

2022-10-07 Thread GitBox
tustvold opened a new pull request, #2844: URL: https://github.com/apache/arrow-rs/pull/2844 Try suggestion from https://github.com/actions/labeler/issues/446#issuecomment-1271520860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow-ballista] andygrove merged pull request #323: Show job stages metrics

2022-10-07 Thread GitBox
andygrove merged PR #323: URL: https://github.com/apache/arrow-ballista/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-ballista] andygrove closed issue #306: [UI] Show list of query stages with metrics

2022-10-07 Thread GitBox
andygrove closed issue #306: [UI] Show list of query stages with metrics URL: https://github.com/apache/arrow-ballista/issues/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-ballista] andygrove closed issue #101: Leverage Atomic for the in-memory states in Scheduler

2022-10-07 Thread GitBox
andygrove closed issue #101: Leverage Atomic for the in-memory states in Scheduler URL: https://github.com/apache/arrow-ballista/issues/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow-ballista] andygrove merged pull request #319: Atomic support for enhancement

2022-10-07 Thread GitBox
andygrove merged PR #319: URL: https://github.com/apache/arrow-ballista/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-datafusion] alamb commented on pull request #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
alamb commented on PR #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751#issuecomment-1271530572 > @alamb May I know how can I fix the failed check so I can merge this PR? I don't think the failure is related to changes in this PR: #3743 -- This is an automated messa

[GitHub] [arrow-datafusion] alamb closed issue #3733: `DataFrame::select_columns` doesn't work with names containing "."

2022-10-07 Thread GitBox
alamb closed issue #3733: `DataFrame::select_columns` doesn't work with names containing "." URL: https://github.com/apache/arrow-datafusion/issues/3733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow-datafusion] alamb merged pull request #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
alamb merged PR #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-datafusion] alamb commented on pull request #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
alamb commented on PR #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751#issuecomment-1271530828 Thanks @zhoudongyan -- that was a great first contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow-ballista] andygrove merged pull request #326: update labeler

2022-10-07 Thread GitBox
andygrove merged PR #326: URL: https://github.com/apache/arrow-ballista/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-rs] alamb commented on issue #2842: RFC: Encode Scalars as `dyn Any` in Scalar dyn Kernels

2022-10-07 Thread GitBox
alamb commented on issue #2842: URL: https://github.com/apache/arrow-rs/issues/2842#issuecomment-1271531990 I think this sounds like a great idea. I didn't realize Any was implemented for the basic types -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [arrow-datafusion] alamb commented on pull request #3749: remove `type coercion` for physical ScalarFunction

2022-10-07 Thread GitBox
alamb commented on PR #3749: URL: https://github.com/apache/arrow-datafusion/pull/3749#issuecomment-1271532758 The CI checks appear to be failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-ballista] andygrove commented on pull request #325: Upgrade to DataFusion 13.0.0-rc1

2022-10-07 Thread GitBox
andygrove commented on PR #325: URL: https://github.com/apache/arrow-ballista/pull/325#issuecomment-1271535806 cc @avantgardnerio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow-datafusion] ursabot commented on pull request #3751: Fix DataFrame::select_columns to handle column names with a period

2022-10-07 Thread GitBox
ursabot commented on PR #3751: URL: https://github.com/apache/arrow-datafusion/pull/3751#issuecomment-1271541199 Benchmark runs are scheduled for baseline = 807a0c1d2963f6ca327d316badb4ed0fa77e9f21 and contender = de9c7c50f1407d6afe252bf2082e031ce8ccf354. de9c7c50f1407d6afe252bf2082e031ce

[GitHub] [arrow] ritchie46 commented on issue #13747: [Python] group_by functionality directly on large dataset, instead of on a table?

2022-10-07 Thread GitBox
ritchie46 commented on issue #13747: URL: https://github.com/apache/arrow/issues/13747#issuecomment-1271541267 > Thank you @legout. Duckdb works really well, but polars is struggling. Maybe I am doing something wrong. > > But anyway here is how it worked for me > > ```python

[GitHub] [arrow] lwhite1 commented on pull request #13248: ARROW-16673: [Java] C data interface: Allow ownership transferring for imported buffer

2022-10-07 Thread GitBox
lwhite1 commented on PR #13248: URL: https://github.com/apache/arrow/pull/13248#issuecomment-1271543460 Hi @emkornfield, just checking in to see if this is still doable for you this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-rs] tustvold merged pull request #2844: Add labeller permissions block

2022-10-07 Thread GitBox
tustvold merged PR #2844: URL: https://github.com/apache/arrow-rs/pull/2844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [arrow] lidavidm commented on pull request #14182: ARROW-17786: [Java] Read CSV files using org.apache.arrow.dataset.jni.NativeDatasetFactory

2022-10-07 Thread GitBox
lidavidm commented on PR #14182: URL: https://github.com/apache/arrow/pull/14182#issuecomment-1271551567 @github-actions crossbow submit *java* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-rs] ursabot commented on pull request #2844: Add labeller permissions block

2022-10-07 Thread GitBox
ursabot commented on PR #2844: URL: https://github.com/apache/arrow-rs/pull/2844#issuecomment-1271551954 Benchmark runs are scheduled for baseline = fe6c66c4cb2e3d37fed25b85c138ecf9a03928f0 and contender = 88267f867bca16b57603d255a167c064e602d747. 88267f867bca16b57603d255a167c064e602d747 i

[GitHub] [arrow] github-actions[bot] commented on pull request #14182: ARROW-17786: [Java] Read CSV files using org.apache.arrow.dataset.jni.NativeDatasetFactory

2022-10-07 Thread GitBox
github-actions[bot] commented on PR #14182: URL: https://github.com/apache/arrow/pull/14182#issuecomment-1271552971 Revision: 98c6d1d2e94ec7bb29a2d7b224c18bf20b5eb5db Submitted crossbow builds: [ursacomputing/crossbow @ actions-e54f92cb9c](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] lidavidm commented on pull request #14182: ARROW-17786: [Java] Read CSV files using org.apache.arrow.dataset.jni.NativeDatasetFactory

2022-10-07 Thread GitBox
lidavidm commented on PR #14182: URL: https://github.com/apache/arrow/pull/14182#issuecomment-1271554278 CI shows a flake in testTable: ``` Error: org.apache.arrow.c.RoundtripTest.testTable Time elapsed: 0.031 s <<< ERROR! java.lang.IllegalStateException: Cannot import releas

[GitHub] [arrow-datafusion] andygrove closed issue #3724: Add support for DISTINCT projections in `decorrelate_where_exists`

2022-10-07 Thread GitBox
andygrove closed issue #3724: Add support for DISTINCT projections in `decorrelate_where_exists` URL: https://github.com/apache/arrow-datafusion/issues/3724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow-datafusion] andygrove merged pull request #3732: fix subquery where exists distinct

2022-10-07 Thread GitBox
andygrove merged PR #3732: URL: https://github.com/apache/arrow-datafusion/pull/3732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] ursabot commented on pull request #3732: fix subquery where exists distinct

2022-10-07 Thread GitBox
ursabot commented on PR #3732: URL: https://github.com/apache/arrow-datafusion/pull/3732#issuecomment-1271575463 Benchmark runs are scheduled for baseline = de9c7c50f1407d6afe252bf2082e031ce8ccf354 and contender = 1e1de829db4540248165c0acb01e1a0ed12c4624. 1e1de829db4540248165c0acb01e1a0ed

[GitHub] [arrow] raulcd commented on pull request #13552: Enable Cython tests on windows wheels

2022-10-07 Thread GitBox
raulcd commented on PR #13552: URL: https://github.com/apache/arrow/pull/13552#issuecomment-1271579261 @github-actions crossbow submit wheel-windows* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   3   4   >