Re: [PR] Support extracting struct fields as Variant using ExtensionType [arrow-rs]

2026-04-07 Thread via GitHub
sdf-jkl commented on code in PR #9598: URL: https://github.com/apache/arrow-rs/pull/9598#discussion_r3048457085 ## parquet-variant-compute/src/variant_get.rs: ## @@ -4376,4 +4434,167 @@ mod test { ); } } + +/// Test extracting a struct with mixed t

[PR] ParquetMetaDataPushDecoder API to clear all buffered ranges [arrow-rs]

2026-04-07 Thread via GitHub
nathanb9 opened a new pull request, #9673: URL: https://github.com/apache/arrow-rs/pull/9673 ## Rationale for this change `ParquetMetaDataPushDecoder` clears exact requested ranges, but larger speculative pushed ranges can remain buffered in `PushBuffers`. This adds a way for callers

Re: [I] [CI] hombrew-cpp job is currently failing [arrow]

2026-04-07 Thread via GitHub
kou commented on issue #49681: URL: https://github.com/apache/arrow/issues/49681#issuecomment-4202958085 Correct. Let's revisit this after 24.0.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] feat(c,ci,go): add vcpkg-based build + ci, fix go imports [arrow-adbc]

2026-04-07 Thread via GitHub
amoeba closed pull request #3591: feat(c,ci,go): add vcpkg-based build + ci, fix go imports URL: https://github.com/apache/arrow-adbc/pull/3591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] feat(c,ci,go): add vcpkg-based build + ci, fix go imports [arrow-adbc]

2026-04-07 Thread via GitHub
amoeba commented on PR #3591: URL: https://github.com/apache/arrow-adbc/pull/3591#issuecomment-4203159951 I'm going to close this as the already-merged PR https://github.com/apache/arrow-adbc/pull/2858 does most of what I was trying to do here. -- This is an automated message from the Ap

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048375238 ## arrow/compute/internal/kernels/vector_sort_support.go: ## @@ -0,0 +1,211 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048350669 ## arrow/compute/vector_sort.go: ## @@ -0,0 +1,391 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

Re: [PR] feat: Add support for Run-End Encoded arrays [arrow-dotnet]

2026-04-07 Thread via GitHub
CurtHagenlocher commented on code in PR #308: URL: https://github.com/apache/arrow-dotnet/pull/308#discussion_r3048363746 ## src/Apache.Arrow/Ipc/ArrowStreamWriter.cs: ## @@ -797,6 +840,7 @@ private protected void WriteRecordBatchInternal(RecordBatch recordBatch)

Re: [PR] feat: Add support for Run-End Encoded arrays [arrow-dotnet]

2026-04-07 Thread via GitHub
CurtHagenlocher commented on code in PR #308: URL: https://github.com/apache/arrow-dotnet/pull/308#discussion_r3048367571 ## src/Apache.Arrow/Arrays/RunEndEncodedArray.cs: ## @@ -0,0 +1,399 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor

Re: [PR] ParquetMetaDataPushDecoder API to clear all buffered ranges [arrow-rs]

2026-04-07 Thread via GitHub
nathanb9 commented on code in PR #9673: URL: https://github.com/apache/arrow-rs/pull/9673#discussion_r3048630874 ## parquet/src/util/push_buffers.rs: ## @@ -156,7 +156,6 @@ impl PushBuffers { } /// Clear all buffered ranges and their corresponding data -#[cfg(fea

Re: [PR] ParquetMetaDataPushDecoder API to clear all buffered ranges [arrow-rs]

2026-04-07 Thread via GitHub
nathanb9 commented on code in PR #9673: URL: https://github.com/apache/arrow-rs/pull/9673#discussion_r3048630874 ## parquet/src/util/push_buffers.rs: ## @@ -156,7 +156,6 @@ impl PushBuffers { } /// Clear all buffered ranges and their corresponding data -#[cfg(fea

Re: [PR] chore(rust): bump tokio from 1.50.0 to 1.51.0 in /rust [arrow-adbc]

2026-04-07 Thread via GitHub
lidavidm merged PR #4192: URL: https://github.com/apache/arrow-adbc/pull/4192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] GH-49651: [C++][FlightRPC] Fix ODBC Linux test segmentation fault [arrow]

2026-04-07 Thread via GitHub
lidavidm commented on PR #49688: URL: https://github.com/apache/arrow/pull/49688#issuecomment-4203239445 Hmm, why are there two copies of gRPC in the first place? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] chore(java): bump the linters group in /java with 3 updates [arrow-adbc]

2026-04-07 Thread via GitHub
lidavidm commented on PR #4187: URL: https://github.com/apache/arrow-adbc/pull/4187#issuecomment-4203717525 Waiting for https://github.com/uber/NullAway/issues/1511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] chore(go/adbc): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.59.0 to 1.97.3 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
lidavidm merged PR #4195: URL: https://github.com/apache/arrow-adbc/pull/4195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] chore(go/adbc): bump github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream from 1.6.4 to 1.7.8 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] commented on PR #4196: URL: https://github.com/apache/arrow-adbc/pull/4196#issuecomment-4203727722 Looks like github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service.

Re: [PR] chore(go/adbc): bump github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream from 1.6.4 to 1.7.8 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] closed pull request #4196: chore(go/adbc): bump github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream from 1.6.4 to 1.7.8 in /go/adbc URL: https://github.com/apache/arrow-adbc/pull/4196 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]

2026-04-07 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #49682: URL: https://github.com/apache/arrow/pull/49682#issuecomment-4203884738 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 35fb62e6224617d5ae749533654e9f8c7a6250c7. There were no

Re: [I] Proposal to re-architect Arrow Swift [arrow-swift]

2026-04-07 Thread via GitHub
willtemperley commented on issue #154: URL: https://github.com/apache/arrow-swift/issues/154#issuecomment-4204021628 @abandy, thanks for the feedback! To clarify, when I mentioned IPC, I was specifically referring to the [Arrow IPC Format](https://arrow.apache.org/docs/cpp/api/ipc.html#read

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048555983 ## arrow/compute/internal/kernels/vector_sort_physical.go: ## @@ -0,0 +1,873 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] chore(go/adbc): bump the opentelemetry group across 1 directory with 6 updates [arrow-adbc]

2026-04-07 Thread via GitHub
lidavidm merged PR #4188: URL: https://github.com/apache/arrow-adbc/pull/4188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] docs: improve docs for homebrew post-release task [arrow-adbc]

2026-04-07 Thread via GitHub
lidavidm merged PR #4186: URL: https://github.com/apache/arrow-adbc/pull/4186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] GH-49614: [C++] Fix silent truncation in base64_decode on invalid input [arrow]

2026-04-07 Thread via GitHub
kou commented on PR #49660: URL: https://github.com/apache/arrow/pull/49660#issuecomment-4203122418 Oh, sorry. I forgot to reply this... Yes. Let's proceed with `arrow::Result`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] GH-49669: [Python] Expose the experimental async device API through Python [arrow]

2026-04-07 Thread via GitHub
CurtHagenlocher commented on code in PR #49670: URL: https://github.com/apache/arrow/pull/49670#discussion_r3048397512 ## python/pyarrow/includes/libarrow.pxd: ## @@ -3179,6 +3179,9 @@ cdef extern from "arrow/c/abi.h": int64_t device_id int32_t device_type +

Re: [PR] GH-49676: [Python][Packaging] Avoid rebuilding all base images by not pulling base images on docker build [arrow]

2026-04-07 Thread via GitHub
raulcd commented on PR #49678: URL: https://github.com/apache/arrow/pull/49678#issuecomment-4204286267 @kou any idea what might be the issue here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] GH-49676: [Python][Packaging] Avoid rebuilding all base images by not pulling base images on docker build [arrow]

2026-04-07 Thread via GitHub
kou commented on PR #49678: URL: https://github.com/apache/arrow/pull/49678#issuecomment-4204337780 I'll take a look at this in a few hours! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Make AdbcCommandTimeoutProperty optional for setting CommandTimeout\n… [arrow-adbc]

2026-04-07 Thread via GitHub
dandandanliu915 opened a new pull request, #4197: URL: https://github.com/apache/arrow-adbc/pull/4197 Previously, setting CommandTimeout required AdbcCommandTimeoutProperty to be set first, throwing InvalidOperationException if it was not. Now, AdbcCommandTimeoutProperty is nullable and Com

Re: [PR] GH-49669: [Python] Expose the experimental async device API through Python [arrow]

2026-04-07 Thread via GitHub
CurtHagenlocher commented on PR #49670: URL: https://github.com/apache/arrow/pull/49670#issuecomment-4202826950 Heh... clearly I understood the code even less than I'd thought... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Support extracting struct fields as Variant using ExtensionType [arrow-rs]

2026-04-07 Thread via GitHub
sdf-jkl commented on code in PR #9598: URL: https://github.com/apache/arrow-rs/pull/9598#discussion_r3048591246 ## parquet-variant-compute/src/variant_get.rs: ## @@ -86,15 +88,14 @@ pub(crate) fn follow_shredded_path_element<'a>( return Ok(missing_path_step());

Re: [PR] GH-49534: [R] Implement dplyr recode_values(), replace_values(), and replace_when() [arrow]

2026-04-07 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #49536: URL: https://github.com/apache/arrow/pull/49536#issuecomment-4203275628 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bb4e492872c3112f68897e0046eae4088f15eff9. There were no

Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.273.1 to 0.275.0 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
lidavidm merged PR #4189: URL: https://github.com/apache/arrow-adbc/pull/4189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[PR] chore(go/adbc): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.59.0 to 1.97.3 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4195: URL: https://github.com/apache/arrow-adbc/pull/4195 Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.59.0 to 1.97.3. Commits https://github.com/aws/aws-sdk-go-v2/commit/90650dd22735ab

[PR] chore(go/adbc): bump github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream from 1.6.4 to 1.7.8 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4196: URL: https://github.com/apache/arrow-adbc/pull/4196 Bumps [github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream](https://github.com/aws/aws-sdk-go-v2) from 1.6.4 to 1.7.8. Commits https://github.com/aws/aws-sdk-go-v2/commit/e3

Re: [I] [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]

2026-04-07 Thread via GitHub
kou commented on issue #49586: URL: https://github.com/apache/arrow/issues/49586#issuecomment-4202418690 Issue resolved by pull request 49682 https://github.com/apache/arrow/pull/49682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]

2026-04-07 Thread via GitHub
kou commented on issue #49586: URL: https://github.com/apache/arrow/issues/49586#issuecomment-4202421379 @raulcd I've added "24.0.0" milestone not "25.0.0" for easy to verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]

2026-04-07 Thread via GitHub
kou merged PR #49682: URL: https://github.com/apache/arrow/pull/49682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [I] The release workflow failed with timeout and we did not publish 19.0.0 docs [arrow-java]

2026-04-07 Thread via GitHub
raulcd commented on issue #1107: URL: https://github.com/apache/arrow-java/issues/1107#issuecomment-4200418022 We should definitely also bump the 5 minutes timeout for the job if we have to upload that many assets :) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
alinaliBQ commented on code in PR #49603: URL: https://github.com/apache/arrow/pull/49603#discussion_r3047759373 ## .github/workflows/cpp_extra.yml: ## @@ -73,6 +73,13 @@ on: schedule: - cron: | 0 0 * * * + workflow_dispatch: Review Comment: Thanks! --

Re: [PR] ParquetPushDecoder API to clear all buffered ranges [arrow-rs]

2026-04-07 Thread via GitHub
alamb commented on PR #9624: URL: https://github.com/apache/arrow-rs/pull/9624#issuecomment-4202234140 Thanks again @nathanb9 and @AndreaBozzo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [MATLAB] Deprecate Feather reader and writer [arrow]

2026-04-07 Thread via GitHub
kou commented on issue #49684: URL: https://github.com/apache/arrow/issues/49684#issuecomment-4202205676 Ah, we don't need to add deprecation warnings "by 24.0.0". 24.0.0 is already feature frozen. We can do this by 25.0.0. -- This is an automated message from the Apache Git Service. To r

Re: [I] Add a way to clear out all buffered ranges from `ParquetPushDecoder` [arrow-rs]

2026-04-07 Thread via GitHub
alamb closed issue #8676: Add a way to clear out all buffered ranges from `ParquetPushDecoder` URL: https://github.com/apache/arrow-rs/issues/8676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] GH-49651: [C++][FlightRPC] Fix ODBC Linux test segmentation fault [arrow]

2026-04-07 Thread via GitHub
alinaliBQ opened a new pull request, #49688: URL: https://github.com/apache/arrow/pull/49688 ### Rationale for this change GH-49651 ### What changes are included in this PR? Pass `ARROW_TEST_LINKAGE: "static"` to Linux ODBC tests. Update CMakeLists.txt to enable static test l

Re: [PR] GH-49651: [C++][FlightRPC] Fix ODBC Linux test segmentation fault [arrow]

2026-04-07 Thread via GitHub
github-actions[bot] commented on PR #49688: URL: https://github.com/apache/arrow/pull/49688#issuecomment-4202294101 :warning: GitHub issue #49651 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Add option to Azure client to ignore unparsable paths [arrow-rs-object-store]

2026-04-07 Thread via GitHub
tustvold commented on PR #376: URL: https://github.com/apache/arrow-rs-object-store/pull/376#issuecomment-4201403770 This PR was closed due to inactivity, the issue is still open -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
amoeba commented on PR #49603: URL: https://github.com/apache/arrow/pull/49603#issuecomment-4201335418 Thanks for taking a look @raulcd. It's okay if this doesn't make it for 24 but if it's at all possible that'd be great. Re: the jobs running on any tag, I'm not seeing what you see,

Re: [PR] fix(parquet): fix CDC panic on nested ListArrays with null entries [arrow-rs]

2026-04-07 Thread via GitHub
alamb merged PR #9644: URL: https://github.com/apache/arrow-rs/pull/9644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [I] [Parquet] ArrowWriter with CDC panics on nested ListArrays [arrow-rs]

2026-04-07 Thread via GitHub
alamb closed issue #9637: [Parquet] ArrowWriter with CDC panics on nested ListArrays URL: https://github.com/apache/arrow-rs/issues/9637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix(parquet): fix CDC panic on nested ListArrays with null entries [arrow-rs]

2026-04-07 Thread via GitHub
alamb commented on PR #9644: URL: https://github.com/apache/arrow-rs/pull/9644#issuecomment-4201239049 šŸ”Ø šŸ› -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] [R] CRAN packaging checklist for version 24.0.0 [arrow]

2026-04-07 Thread via GitHub
thisisnic commented on issue #49685: URL: https://github.com/apache/arrow/issues/49685#issuecomment-4201667623 Let's cherry-pick [bb4e492](https://github.com/apache/arrow/commit/bb4e492872c3112f68897e0046eae4088f15eff9) over too -- This is an automated message from the Apache Git Service

[PR] docs: improve docs for homebrew post-release task [arrow-adbc]

2026-04-07 Thread via GitHub
amoeba opened a new pull request, #4186: URL: https://github.com/apache/arrow-adbc/pull/4186 Improves the docs for the post-release task to update the Homebrew packages. It turns out Homebrew has an automation for updating packages so the release manager should usually only have to check th

Re: [PR] chore(csharp): Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.4.0 [arrow-adbc]

2026-04-07 Thread via GitHub
CurtHagenlocher merged PR #4194: URL: https://github.com/apache/arrow-adbc/pull/4194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
amoeba commented on code in PR #49603: URL: https://github.com/apache/arrow/pull/49603#discussion_r3047749495 ## .github/workflows/cpp_extra.yml: ## @@ -73,6 +73,13 @@ on: schedule: - cron: | 0 0 * * * + workflow_dispatch: Review Comment: https://github.com

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
zeroshade commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048286064 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
zeroshade commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048288475 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
zeroshade commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048290598 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] chore(go/adbc): bump google.golang.org/grpc from 1.79.3 to 1.80.0 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
zeroshade merged PR #4190: URL: https://github.com/apache/arrow-adbc/pull/4190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.

Re: [PR] chore(go/adbc): bump modernc.org/sqlite from 1.48.0 to 1.48.1 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
zeroshade merged PR #4191: URL: https://github.com/apache/arrow-adbc/pull/4191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048332046 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
amoeba commented on code in PR #49603: URL: https://github.com/apache/arrow/pull/49603#discussion_r3047075890 ## .github/workflows/cpp_extra.yml: ## @@ -73,6 +73,13 @@ on: schedule: - cron: | 0 0 * * * + workflow_dispatch: Review Comment: The flow is a bit

Re: [PR] GH-49582: [C++][FlightRPC] Add ODBC Debian support [arrow]

2026-04-07 Thread via GitHub
alinaliBQ closed pull request #49583: GH-49582: [C++][FlightRPC] Add ODBC Debian support URL: https://github.com/apache/arrow/pull/49583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
raulcd commented on code in PR #49603: URL: https://github.com/apache/arrow/pull/49603#discussion_r3047308613 ## .github/workflows/cpp_extra.yml: ## @@ -73,6 +73,13 @@ on: schedule: - cron: | 0 0 * * * + workflow_dispatch: Review Comment: I see, I did not u

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048187258 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048256452 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048254469 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] feat(arrow/compute): sort support [arrow-go]

2026-04-07 Thread via GitHub
hamilton-earthscope commented on code in PR #749: URL: https://github.com/apache/arrow-go/pull/749#discussion_r3048263784 ## arrow/compute/internal/kernels/vector_sort.go: ## @@ -0,0 +1,476 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [I] [R] Improve interface for working with schemas [arrow]

2026-04-07 Thread via GitHub
tanho63 commented on issue #35071: URL: https://github.com/apache/arrow/issues/35071#issuecomment-4202608344 > Hi [@tanho63](https://github.com/tanho63), normally I'd say open a new issue, but I'll answer here to prevent the admin! If you wanna follow up more, please open a new issue and ta

Re: [PR] GH-49651: [C++][FlightRPC] Fix ODBC Linux test segmentation fault [arrow]

2026-04-07 Thread via GitHub
alinaliBQ commented on PR #49688: URL: https://github.com/apache/arrow/pull/49688#issuecomment-4202648401 @lidavidm @kou This PR is ready for review, please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-49614: [C++] Fix silent truncation in base64_decode on invalid input [arrow]

2026-04-07 Thread via GitHub
Reranko05 commented on PR #49660: URL: https://github.com/apache/arrow/pull/49660#issuecomment-4202659957 Hi @kou, just following up on this. I can proceed with updating `base64_decode()` to return `arrow::Result` and adjust the affected call sites accordingly. Please let me know if

[I] Unnecessary dependency on regex crate [arrow-rs]

2026-04-07 Thread via GitHub
abgros opened a new issue, #9672: URL: https://github.com/apache/arrow-rs/issues/9672 I noticed that this project has a transitive dependency on the regex crate via `arrow-string`. Apparently the purpose of this is to allow you to run queries on a string column to see whether they match a r

Re: [I] [C++] Deprecate Feather reader and writer [arrow]

2026-04-07 Thread via GitHub
sgilmore10 commented on issue #49231: URL: https://github.com/apache/arrow/issues/49231#issuecomment-4201126526 > [@sgilmore10](https://github.com/sgilmore10) [@kevingurney](https://github.com/kevingurney) Could you work on this for MATLAB? @kou - Yes, I'll create an issue for depre

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
alinaliBQ commented on code in PR #49603: URL: https://github.com/apache/arrow/pull/49603#discussion_r3047687030 ## .github/workflows/cpp_extra.yml: ## @@ -73,6 +73,13 @@ on: schedule: - cron: | 0 0 * * * + workflow_dispatch: Review Comment: @amoeba Could y

[PR] chore(go/adbc): bump google.golang.org/grpc from 1.79.3 to 1.80.0 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4190: URL: https://github.com/apache/arrow-adbc/pull/4190 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.79.3 to 1.80.0. Release notes Sourced from https://github.com/grpc/grpc-go/releases";>google.golang.org/grpc'

[PR] chore(go/adbc): bump modernc.org/sqlite from 1.48.0 to 1.48.1 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4191: URL: https://github.com/apache/arrow-adbc/pull/4191 Bumps [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) from 1.48.0 to 1.48.1. Changelog Sourced from https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md";>modernc.org/sql

[PR] chore(go/adbc): bump the opentelemetry group in /go/adbc with 6 updates [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4188: URL: https://github.com/apache/arrow-adbc/pull/4188 Bumps the opentelemetry group in /go/adbc with 6 updates: | Package | From | To | | --- | --- | --- | | [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetr

[PR] chore(go/adbc): bump google.golang.org/api from 0.273.1 to 0.275.0 in /go/adbc [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4189: URL: https://github.com/apache/arrow-adbc/pull/4189 Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.273.1 to 0.275.0. Release notes Sourced from https://github.com/googleapis/google-api-go-c

[PR] chore(java): bump the linters group in /java with 3 updates [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4187: URL: https://github.com/apache/arrow-adbc/pull/4187 Bumps the linters group in /java with 3 updates: [org.checkerframework:checker-qual](https://github.com/typetools/checker-framework), [org.checkerframework:checker](https://github.com/typet

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
amoeba commented on code in PR #49603: URL: https://github.com/apache/arrow/pull/49603#discussion_r3047690271 ## .github/workflows/cpp_extra.yml: ## @@ -73,6 +73,13 @@ on: schedule: - cron: | 0 0 * * * + workflow_dispatch: Review Comment: Absolutely. I'll f

[PR] chore(rust): bump tokio from 1.50.0 to 1.51.0 in /rust [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4192: URL: https://github.com/apache/arrow-adbc/pull/4192 Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.50.0 to 1.51.0. Release notes Sourced from https://github.com/tokio-rs/tokio/releases";>tokio's releases. Tokio v1.51.

Re: [PR] ParquetPushDecoder API to clear all buffered ranges [arrow-rs]

2026-04-07 Thread via GitHub
alamb merged PR #9624: URL: https://github.com/apache/arrow-rs/pull/9624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing [arrow]

2026-04-07 Thread via GitHub
alinaliBQ commented on PR #49603: URL: https://github.com/apache/arrow/pull/49603#issuecomment-4201470708 > I am unsure this is ready yet, sorry it took me a couple days for review, it was Easter and had some family around. My main concern is around, the tag hasn't been updated to match th

Re: [PR] GH-49586: [C++][CI] StructToStructSubset test failure with libc++ 22.1.1 [arrow]

2026-04-07 Thread via GitHub
zanmato1984 commented on PR #49682: URL: https://github.com/apache/arrow/pull/49682#issuecomment-4201150524 Thanks for the fix. Switching from `std::multimap::extract(key)` to `lower_bound(key)` + `erase(iterator)` is the right change here. It makes duplicate-field selection determin

Re: [PR] feat(local): explicit close with error checking for LocalFileSystem [arrow-rs-object-store]

2026-04-07 Thread via GitHub
crepererum commented on code in PR #676: URL: https://github.com/apache/arrow-rs-object-store/pull/676#discussion_r3046529686 ## src/local.rs: ## @@ -137,6 +137,37 @@ impl From for super::Error { } } +/// Explicitly close a file, checking for errors that would be silent

Re: [PR] GH-49676: [Python][Packaging] Avoid rebuilding all base images by not pulling base images on docker build [arrow]

2026-04-07 Thread via GitHub
github-actions[bot] commented on PR #49678: URL: https://github.com/apache/arrow/pull/49678#issuecomment-4199097510 Revision: b45c2874d6ce646d654b2f4c04494c01593303dc Submitted crossbow builds: [ursacomputing/crossbow @ actions-946cdff5a8](https://github.com/ursacomputing/crossbow/bra

Re: [PR] [Parquet] Improve dictionary decoder by unrolling loops [arrow-rs]

2026-04-07 Thread via GitHub
alamb commented on code in PR #9662: URL: https://github.com/apache/arrow-rs/pull/9662#discussion_r3045089507 ## parquet/src/encodings/rle.rs: ## @@ -352,7 +352,7 @@ impl RleDecoder { // that damage L1d-cache occupancy. This results in a ~18% performance drop #[inline(

Re: [PR] [Parquet] Improve dictionary decoder by unrolling loops [arrow-rs]

2026-04-07 Thread via GitHub
alamb commented on PR #9662: URL: https://github.com/apache/arrow-rs/pull/9662#issuecomment-4199064912 > Thanks @alamb improving Parquet decoding perf piece by piece šŸš€ Indeed -- step by step we'll have this thing screaming -- This is an automated message from the Apache Git Service.

Re: [PR] GH-49534: [R] Implement dplyr recode_values(), replace_values(), and replace_when() [arrow]

2026-04-07 Thread via GitHub
jonkeane commented on code in PR #49536: URL: https://github.com/apache/arrow/pull/49536#discussion_r3045612412 ## r/R/dplyr-funcs-conditional.R: ## @@ -15,6 +15,169 @@ # specific language governing permissions and limitations # under the License. +#' Parse logical condition

Re: [PR] feat: Add support for Run-End Encoded arrays [arrow-dotnet]

2026-04-07 Thread via GitHub
Copilot commented on code in PR #308: URL: https://github.com/apache/arrow-dotnet/pull/308#discussion_r3045654722 ## test/Apache.Arrow.Tests/RunEndEncodedArrayTests.cs: ## @@ -0,0 +1,366 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor li

Re: [PR] GH-49534: [R] Implement dplyr recode_values(), replace_values(), and replace_when() [arrow]

2026-04-07 Thread via GitHub
jonkeane commented on PR #49536: URL: https://github.com/apache/arrow/pull/49536#issuecomment-4199642477 @github-actions crossbow submit -g r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] GH-49534: [R] Implement dplyr recode_values(), replace_values(), and replace_when() [arrow]

2026-04-07 Thread via GitHub
github-actions[bot] commented on PR #49536: URL: https://github.com/apache/arrow/pull/49536#issuecomment-4199663041 Revision: 825940b2c2ecce9691a204c76dc77c80afc564d2 Submitted crossbow builds: [ursacomputing/crossbow @ actions-40f5a339fc](https://github.com/ursacomputing/crossbow/bra

Re: [PR] feat(parquet): fuse level encoding passes and batch null runs in column writer [arrow-rs]

2026-04-07 Thread via GitHub
jhorstmann commented on code in PR #9653: URL: https://github.com/apache/arrow-rs/pull/9653#discussion_r3045683398 ## parquet/src/arrow/arrow_writer/levels.rs: ## @@ -751,6 +825,11 @@ pub(crate) struct ArrayLevels { /// cached logical nulls of the array. logical_null

Re: [I] [arrow-avro] Implement full Apache Avro v1.12.0 specification support [arrow-rs]

2026-04-07 Thread via GitHub
mzabaluev commented on issue #8703: URL: https://github.com/apache/arrow-rs/issues/8703#issuecomment-4201710482 Note that changing behavior based on feature flags is a footgun: because features are enabled additively across a workspace, one package requiring the `avro_1_12` feature from arr

[PR] chore: bump the actions group with 3 updates [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4193: URL: https://github.com/apache/arrow-adbc/pull/4193 Bumps the actions group with 3 updates: [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv), [ruby/setup-ruby](https://github.com/ruby/setup-ruby) and [docker/login-action](https:/

[PR] chore(csharp): Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.4.0 [arrow-adbc]

2026-04-07 Thread via GitHub
dependabot[bot] opened a new pull request, #4194: URL: https://github.com/apache/arrow-adbc/pull/4194 Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 18.3.0 to 18.4.0. Release notes _Sourced from [Microsoft.NET.Test.Sdk's releases](https://github

Re: [PR] GH-49534: [R] Implement dplyr recode_values(), replace_values(), and replace_when() [arrow]

2026-04-07 Thread via GitHub
thisisnic merged PR #49536: URL: https://github.com/apache/arrow/pull/49536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] GH-49534: [R] Implement dplyr recode_values(), replace_values(), and replace_when() [arrow]

2026-04-07 Thread via GitHub
thisisnic commented on PR #49536: URL: https://github.com/apache/arrow/pull/49536#issuecomment-4201648962 CI failure appears to be unrelated (duckddb installation) so I'll merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [R] Implement dplyr recode_values(), replace_values(), and replace_when() [arrow]

2026-04-07 Thread via GitHub
thisisnic commented on issue #49534: URL: https://github.com/apache/arrow/issues/49534#issuecomment-4201661377 Issue resolved by pull request 49536 https://github.com/apache/arrow/pull/49536 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] feat: Add support for Run-End Encoded arrays [arrow-dotnet]

2026-04-07 Thread via GitHub
Copilot commented on code in PR #308: URL: https://github.com/apache/arrow-dotnet/pull/308#discussion_r3047801024 ## src/Apache.Arrow/Ipc/ArrowStreamWriter.cs: ## @@ -797,6 +840,7 @@ private protected void WriteRecordBatchInternal(RecordBatch recordBatch) recor

Re: [PR] GH-49669: [Python] Expose the experimental async device API through Python [arrow]

2026-04-07 Thread via GitHub
Copilot commented on code in PR #49670: URL: https://github.com/apache/arrow/pull/49670#discussion_r3047815289 ## python/pyarrow/src/arrow/python/async_stream.h: ## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] chore: Bump github.com/andybalholm/brotli from 1.2.0 to 1.2.1 [arrow-go]

2026-04-07 Thread via GitHub
zeroshade merged PR #753: URL: https://github.com/apache/arrow-go/pull/753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [I] [Python][Interchange protocol] Suppress warnings for pandas 4.0.0 and update docs [arrow]

2026-04-07 Thread via GitHub
raulcd commented on issue #49628: URL: https://github.com/apache/arrow/issues/49628#issuecomment-4197797498 Issue resolved by pull request 49630 https://github.com/apache/arrow/pull/49630 -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   3   >