Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-05-07 Thread via GitHub
raulcd commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2098769430 I will have to manually include: https://github.com/apache/arrow/pull/41466/commits/2fd3fcc6e9c2bbd4b105f14306f0ea8bd7d59cec into 16.1.0 in order to have a passing java-jars job as we

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-05-02 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2089691314 After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 14c54bbfb7d9305e79a2c2d016c34a655773e5cb. There were

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-05-01 Thread via GitHub
lidavidm merged PR #41466: URL: https://github.com/apache/arrow/pull/41466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-05-01 Thread via GitHub
lidavidm commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2089282218 We can merge this regardless and @vibhatha can file a new ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-05-01 Thread via GitHub
vibhatha commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2088901863 @lidavidm this seems to be from the recent maven build update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-05-01 Thread via GitHub
bkietz commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2088861280 The error doesn't seem related to filesystem anymore: https://github.com/ursacomputing/crossbow/actions/runs/8903205653/job/24451424677#step:6:16247 I'm not sure what it means

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-04-30 Thread via GitHub
github-actions[bot] commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2087746360 Revision: 2fd3fcc6e9c2bbd4b105f14306f0ea8bd7d59cec Submitted crossbow builds: [ursacomputing/crossbow @

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-04-30 Thread via GitHub
lidavidm commented on code in PR #41466: URL: https://github.com/apache/arrow/pull/41466#discussion_r1585706584 ## dev/tasks/java-jars/github.yml: ## @@ -80,7 +80,7 @@ jobs: fail-fast: false matrix: platform: - - { runs_on: ["macos-latest"],

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-04-30 Thread via GitHub
lidavidm commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2087744100 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to