Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-04 Thread via GitHub
hiltontj commented on PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#issuecomment-2094293292 Thanks for closing it out @alamb! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-04 Thread via GitHub
alamb commented on PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#issuecomment-2094138650 Thanks again @hiltontj ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-04 Thread via GitHub
alamb merged PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-04 Thread via GitHub
alamb commented on PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#issuecomment-2094132984 I merged up from main to get the clippy fixes The archery integration test failure does not appear to be related: https://github.com/apache/arrow-rs/issues/5719 -- This is an

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-02 Thread via GitHub
alamb commented on PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#issuecomment-2091575792 PR to fix clippy is here: https://github.com/apache/arrow-rs/pull/5710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-02 Thread via GitHub
alamb commented on PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#issuecomment-2091434518 I believe the clippy failure is unrelated (it is due to the new version of rust, nothing in this PR) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-02 Thread via GitHub
alamb commented on code in PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#discussion_r1588267804 ## parquet/src/bloom_filter/mod.rs: ## @@ -16,7 +16,61 @@ // under the License. //! Bloom filter implementation specific to Parquet, as described -//! in the

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-02 Thread via GitHub
hiltontj commented on PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#issuecomment-2091072092 Looks like Clippy is unhappy after 1.78. I will likely wait for that to get fixed upstream and then merge/rebase. -- This is an automated message from the Apache Git Service. To

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-01 Thread via GitHub
hiltontj commented on code in PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#discussion_r1587027649 ## parquet/src/bloom_filter/mod.rs: ## @@ -16,7 +16,61 @@ // under the License. //! Bloom filter implementation specific to Parquet, as described -//! in the

Re: [PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-01 Thread via GitHub
hiltontj commented on code in PR #5705: URL: https://github.com/apache/arrow-rs/pull/5705#discussion_r1587027143 ## parquet/src/bloom_filter/mod.rs: ## @@ -16,7 +16,61 @@ // under the License. //! Bloom filter implementation specific to Parquet, as described -//! in the

[PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-01 Thread via GitHub
hiltontj opened a new pull request, #5705: URL: https://github.com/apache/arrow-rs/pull/5705 Added documentation detailing the sizing of bloom filters in the parquet crate. # Which issue does this PR close? There is currently no issue for this change. #