[GitHub] [beam] vmarquez edited a comment on issue #10546: [BEAM-9008] Add CassandraIO readAll method

2020-04-03 Thread GitBox
vmarquez edited a comment on issue #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#issuecomment-607043571 Hi @iemejia I've been busy with work and life but was finally able to this just about finished up! To get around the connection

[GitHub] [beam] vmarquez commented on issue #10546: [BEAM-9008] Add CassandraIO readAll method

2020-04-03 Thread GitBox
vmarquez commented on issue #10546: [BEAM-9008] Add CassandraIO readAll method URL: https://github.com/apache/beam/pull/10546#issuecomment-608958438 @iemejia I've fixed the merge conflicts now with a rebase and I'm ready for further review. Thanks in advance!

[GitHub] [beam] pabloem commented on issue #11310: [BEAM-6217] Fixing typos on javadoc

2020-04-03 Thread GitBox
pabloem commented on issue #11310: [BEAM-6217] Fixing typos on javadoc URL: https://github.com/apache/beam/pull/11310#issuecomment-608955985 Thanks for your contribution! This is an automated message from the Apache Git

[GitHub] [beam] pabloem merged pull request #11310: [BEAM-6217] Fixing typos on javadoc

2020-04-03 Thread GitBox
pabloem merged pull request #11310: [BEAM-6217] Fixing typos on javadoc URL: https://github.com/apache/beam/pull/11310 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403393322 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403351916 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403390955 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403323329 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403319053 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403251962 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403391405 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction co

2020-04-03 Thread GitBox
chamikaramj commented on a change in pull request #11185: [BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags added by remote SDKs and propagate restriction coders. URL: https://github.com/apache/beam/pull/11185#discussion_r403320577 ## File path:

[GitHub] [beam] lukecwik commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
lukecwik commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#discussion_r403407082 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -1206,6 +1210,15

[GitHub] [beam] lukecwik commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
lukecwik commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#issuecomment-608952454 retest this please This is an automated message from the

[GitHub] [beam] robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#discussion_r403403332 ## File path:

[GitHub] [beam] robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#discussion_r403403766 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -1206,6 +1210,15

[GitHub] [beam] robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#discussion_r403405278 ## File path:

[GitHub] [beam] pabloem commented on issue #11310: [BEAM-6217] Fixing typos on javadoc

2020-04-03 Thread GitBox
pabloem commented on issue #11310: [BEAM-6217] Fixing typos on javadoc URL: https://github.com/apache/beam/pull/11310#issuecomment-608948612 Run Java PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
robertwb commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#discussion_r403402959 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -1206,6 +1210,11

[GitHub] [beam] robertwb opened a new pull request #11313: Rename ResolveArtifact to ResolveArtifacts

2020-04-03 Thread GitBox
robertwb opened a new pull request #11313: Rename ResolveArtifact to ResolveArtifacts URL: https://github.com/apache/beam/pull/11313 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] ihji commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
ihji commented on a change in pull request #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#discussion_r403390422 ## File path:

[GitHub] [beam] ihji commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
ihji commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#issuecomment-608857763 @lukecwik Ready to merge. Please trigger the test and take a final look.

[GitHub] [beam] lukecwik commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java

2020-04-03 Thread GitBox
lukecwik commented on issue #11205: [BEAM-9578] Enumerating artifacts is too expensive in Java URL: https://github.com/apache/beam/pull/11205#issuecomment-608803659 retest this please This is an automated message from the

[GitHub] [beam] Hannah-Jiang commented on issue #11307: [BEAM-9136] (test remove behavior) remove nose

2020-04-03 Thread GitBox
Hannah-Jiang commented on issue #11307: [BEAM-9136] (test remove behavior) remove nose URL: https://github.com/apache/beam/pull/11307#issuecomment-608785737 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0

2020-04-03 Thread GitBox
Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0 URL: https://github.com/apache/beam/pull/11308#issuecomment-608784317 Run Go Postcommit This is an automated

[GitHub] [beam] Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0

2020-04-03 Thread GitBox
Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0 URL: https://github.com/apache/beam/pull/11308#issuecomment-608784594 Run Java PreCommit This is an automated

[GitHub] [beam] pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines

2020-04-03 Thread GitBox
pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines URL: https://github.com/apache/beam/pull/11309#issuecomment-608782560 Run Python PreCommit This is an automated message

[GitHub] [beam] pabloem commented on issue #11310: [BEAM-6217] Fixing typos on javadoc

2020-04-03 Thread GitBox
pabloem commented on issue #11310: [BEAM-6217] Fixing typos on javadoc URL: https://github.com/apache/beam/pull/11310#issuecomment-608774034 Run Portable_Python PreCommit This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table

2020-04-03 Thread GitBox
pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-608768810 Run Python 3.7 PostCommit This is an automated message

[GitHub] [beam] robertwb merged pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
robertwb merged pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305 This is an automated message from the Apache Git Service. To

[GitHub] [beam] robertwb commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
robertwb commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#issuecomment-608763196 Yeah, I'm tracking that bug. This doesn't make things worse.

[GitHub] [beam] robertwb opened a new pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.

2020-04-03 Thread GitBox
robertwb opened a new pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner. URL: https://github.com/apache/beam/pull/11312 Also updates artifact staging service to handle dependencies from multiple environments.

[GitHub] [beam] robertwb opened a new pull request #11311: [BEAM-9577] Attempt to stage resources via new API in portable runner.

2020-04-03 Thread GitBox
robertwb opened a new pull request #11311: [BEAM-9577] Attempt to stage resources via new API in portable runner. URL: https://github.com/apache/beam/pull/11311 R: @ihji This should be a fairly straightforward change for you. Thank you for your

[GitHub] [beam] AldairCoronel commented on issue #11310: [BEAM-6217] Fixing typos on javadoc

2020-04-03 Thread GitBox
AldairCoronel commented on issue #11310: [BEAM-6217] Fixing typos on javadoc URL: https://github.com/apache/beam/pull/11310#issuecomment-608727463 R: @pabloem This is an automated message from the Apache Git Service. To

[GitHub] [beam] AldairCoronel opened a new pull request #11310: [BEAM-6217] Fixing typos on javadoc

2020-04-03 Thread GitBox
AldairCoronel opened a new pull request #11310: [BEAM-6217] Fixing typos on javadoc URL: https://github.com/apache/beam/pull/11310 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to

[GitHub] [beam] robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.

2020-04-03 Thread GitBox
robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags. URL: https://github.com/apache/beam/pull/11283#issuecomment-608712255 @rohdesamuel is this good to go? This is an

[GitHub] [beam] robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.

2020-04-03 Thread GitBox
robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags. URL: https://github.com/apache/beam/pull/11283#issuecomment-608712134 Run Python PreCommit This is an automated

[GitHub] [beam] aaltay merged pull request #11306: [BEAM-9687] Change delimeter to a dash as the pipe is a reserved symbol in Windows in file names

2020-04-03 Thread GitBox
aaltay merged pull request #11306: [BEAM-9687] Change delimeter to a dash as the pipe is a reserved symbol in Windows in file names URL: https://github.com/apache/beam/pull/11306 This is an automated message from the Apache

[GitHub] [beam] lostluck edited a comment on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck edited a comment on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#issuecomment-608705326 That appears to have been the case since https://github.com/apache/beam/pull/11305 Edit:

[GitHub] [beam] lostluck edited a comment on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck edited a comment on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#issuecomment-608705326 That appears to have been the case since https://github.com/apache/beam/pull/11305 Edit:

[GitHub] [beam] lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#issuecomment-608705326 That appears to have been the case since https://github.com/apache/beam/pull/11305

[GitHub] [beam] lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#issuecomment-608704872 In the post commit, it doesn't look the dataflow jobs still don't like the current situation. They claim

[GitHub] [beam] pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350683 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350549 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350428 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -641,12 +641,19 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#discussion_r403350713 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -657,6 +664,10 @@ def

[GitHub] [beam] lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#issuecomment-608678863 Run Go PostCommit This is an automated

[GitHub] [beam] robertwb commented on issue #11235: [BEAM-9618] Pull bundle descriptors.

2020-04-03 Thread GitBox
robertwb commented on issue #11235: [BEAM-9618] Pull bundle descriptors. URL: https://github.com/apache/beam/pull/11235#issuecomment-608674803 @lukecwik Was there anything more you wanted me to do on this? This is an

[GitHub] [beam] pabloem commented on issue #11296: [BEAM-9640] Sketching watermark tracking on FnApiRunner

2020-04-03 Thread GitBox
pabloem commented on issue #11296: [BEAM-9640] Sketching watermark tracking on FnApiRunner URL: https://github.com/apache/beam/pull/11296#issuecomment-608670206 unable to repro these errors locally. This is an automated

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r403338432 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r403337969 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -663,14 +662,10 @@ def split(self,

[GitHub] [beam] pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines

2020-04-03 Thread GitBox
pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines URL: https://github.com/apache/beam/pull/11309#issuecomment-608656002 Run Python PreCommit This is an automated message

[GitHub] [beam] reuvenlax commented on a change in pull request #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
reuvenlax commented on a change in pull request #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#discussion_r403328568 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java ##

[GitHub] [beam] reuvenlax commented on a change in pull request #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
reuvenlax commented on a change in pull request #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#discussion_r403328672 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlUtils.java ##

[GitHub] [beam] reuvenlax commented on a change in pull request #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
reuvenlax commented on a change in pull request #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#discussion_r403328610 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCalcRel.java

[GitHub] [beam] robertwb commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
robertwb commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403320150 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] tvalentyn commented on issue #11301: [BEAM-9688] Fixes platform-dependent assumptions in subprocess_server_test.py.

2020-04-03 Thread GitBox
tvalentyn commented on issue #11301: [BEAM-9688] Fixes platform-dependent assumptions in subprocess_server_test.py. URL: https://github.com/apache/beam/pull/11301#issuecomment-608645372 Run Python2_PVR_Flink PreCommit This

[GitHub] [beam] rohdesamuel commented on issue #11306: [BEAM-9687] Change delimeter to a dash as the pipe is a reserved symbol in Windows in file names

2020-04-03 Thread GitBox
rohdesamuel commented on issue #11306: [BEAM-9687] Change delimeter to a dash as the pipe is a reserved symbol in Windows in file names URL: https://github.com/apache/beam/pull/11306#issuecomment-608644347 Thanks Ahmet! This

[GitHub] [beam] TheNeuralBit commented on issue #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
TheNeuralBit commented on issue #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#issuecomment-608640348 PostCommit doesn't get it either.. This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines

2020-04-03 Thread GitBox
pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines URL: https://github.com/apache/beam/pull/11309#issuecomment-608639250 Run Python 3.5 PostCommit This is an automated

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
TheNeuralBit commented on a change in pull request #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#discussion_r403298589 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlUtils.java

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
TheNeuralBit commented on a change in pull request #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#discussion_r403295011 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
TheNeuralBit commented on a change in pull request #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#discussion_r403298538 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCalcRel.java

[GitHub] [beam] TheNeuralBit commented on issue #11259: Use attachValues in SQL

2020-04-03 Thread GitBox
TheNeuralBit commented on issue #11259: Use attachValues in SQL URL: https://github.com/apache/beam/pull/11259#issuecomment-608636384 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403292561 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403292561 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403292756 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table

2020-04-03 Thread GitBox
pabloem commented on issue #11244: [BEAM-3097] _ReadFromBigQuery supports valueprovider for table URL: https://github.com/apache/beam/pull/11244#issuecomment-608634124 i dont understand why it's failing on permission issues now..

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403290897 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines

2020-04-03 Thread GitBox
pabloem commented on issue #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines URL: https://github.com/apache/beam/pull/11309#issuecomment-608631810 Run Python 3.5 PostCommit This is an automated

[GitHub] [beam] pabloem opened a new pull request #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines

2020-04-03 Thread GitBox
pabloem opened a new pull request #11309: [BEAM-9691] Ensuring BQ Native Source is avoided on FnApi pipelines URL: https://github.com/apache/beam/pull/11309 Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] robertwb commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
robertwb commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403284304 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] robertwb commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
robertwb commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403281683 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] lostluck commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0

2020-04-03 Thread GitBox
lostluck commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0 URL: https://github.com/apache/beam/pull/11308#issuecomment-608625833 Run Go Postcommit This is an automated message

[GitHub] [beam] lostluck commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0

2020-04-03 Thread GitBox
lostluck commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0 URL: https://github.com/apache/beam/pull/11308#issuecomment-608625754 Ack. Thanks! Hopefully, this doesn't need to last much longer.

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403270941 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0

2020-04-03 Thread GitBox
Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0 URL: https://github.com/apache/beam/pull/11308#issuecomment-608624111 > LGTM > > Probably should get a review from @lostluck and/or @youngoli as well. Thanks Kyle!

[GitHub] [beam] Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0

2020-04-03 Thread GitBox
Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.22.0 URL: https://github.com/apache/beam/pull/11308#issuecomment-608623798 Cc: @lostluck, @youngoli This is an

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403268545 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.21.0

2020-04-03 Thread GitBox
Hannah-Jiang commented on issue #11308: [BEAM-9685] remove Go SDK container from release process from 2.21.0 URL: https://github.com/apache/beam/pull/11308#issuecomment-608622458 @ibzib This is an automated message from the

[GitHub] [beam] Hannah-Jiang opened a new pull request #11308: [BEAM-9685] remove Go SDK container from release process from 2.21.0

2020-04-03 Thread GitBox
Hannah-Jiang opened a new pull request #11308: [BEAM-9685] remove Go SDK container from release process from 2.21.0 URL: https://github.com/apache/beam/pull/11308 Go SDK is not mutual enough to publish the container. It is no longer part of release from 2.21.0.

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403265533 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403265387 ## File path: sdks/go/pkg/beam/artifact/materialize_test.go ## @@

[GitHub] [beam] Hannah-Jiang opened a new pull request #11307: [BEAM-9136] (test remove behavior) remove nose

2020-04-03 Thread GitBox
Hannah-Jiang opened a new pull request #11307: [BEAM-9136] (test remove behavior) remove nose URL: https://github.com/apache/beam/pull/11307 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on a change in pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#discussion_r403251324 ## File path: sdks/go/pkg/beam/artifact/materialize.go ## @@ -31,15

[GitHub] [beam] ibzib commented on issue #11269: [BEAM-9199] Require Dataflow --region in Python SDK.

2020-04-03 Thread GitBox
ibzib commented on issue #11269: [BEAM-9199] Require Dataflow --region in Python SDK. URL: https://github.com/apache/beam/pull/11269#issuecomment-608605547 I found quite a few more examples where --region needed to be added. Because this is a breaking change and it's very likely I've

[GitHub] [beam] tvalentyn commented on issue #11301: [BEAM-9688] Fixes platform-dependent assumptions in subprocess_server_test.py.

2020-04-03 Thread GitBox
tvalentyn commented on issue #11301: [BEAM-9688] Fixes platform-dependent assumptions in subprocess_server_test.py. URL: https://github.com/apache/beam/pull/11301#issuecomment-608600883 Applied YAPF This is an automated

[GitHub] [beam] pabloem commented on issue #11296: [BEAM-9640] Sketching watermark tracking on FnApiRunner

2020-04-03 Thread GitBox
pabloem commented on issue #11296: [BEAM-9640] Sketching watermark tracking on FnApiRunner URL: https://github.com/apache/beam/pull/11296#issuecomment-608600369 This is the output of watermark_manager.show() for one pipeline:

[GitHub] [beam] kennknowles commented on a change in pull request #10958: [BEAM] Submitting final communication strategy

2020-04-03 Thread GitBox
kennknowles commented on a change in pull request #10958: [BEAM] Submitting final communication strategy URL: https://github.com/apache/beam/pull/10958#discussion_r403223897 ## File path: channels and communication strategy/.gitkeep ## @@ -0,0 +1 @@ + Review comment:

[GitHub] [beam] lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
lostluck commented on issue #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305#issuecomment-608587473 Run Go Postcommit This is an automated

[GitHub] [beam] aaltay commented on issue #11306: [BEAM-9687] Change delimeter to a dash as the pipe is a reserved symbol in Windows in file names

2020-04-03 Thread GitBox
aaltay commented on issue #11306: [BEAM-9687] Change delimeter to a dash as the pipe is a reserved symbol in Windows in file names URL: https://github.com/apache/beam/pull/11306#issuecomment-608573647 LGTM This is an

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-04-03 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r403112986 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,246 @@ +# +# Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-04-03 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r403107814 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,246 @@ +# +# Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms

2020-04-03 Thread GitBox
TheNeuralBit commented on a change in pull request #10760: [BEAM-9545] Dataframe transforms URL: https://github.com/apache/beam/pull/10760#discussion_r403112100 ## File path: sdks/python/apache_beam/dataframe/transforms.py ## @@ -0,0 +1,246 @@ +# +# Licensed to the Apache

[GitHub] [beam] robertwb opened a new pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present.

2020-04-03 Thread GitBox
robertwb opened a new pull request #11305: [BEAM-9577] Update container boot code to stage from dependencies, if present. URL: https://github.com/apache/beam/pull/11305 Falls back to legacy staging if no dependencies are present and the retrieval token is non-trivial. Currently

[GitHub] [beam] pabloem commented on issue #11302: [BEAM-9607] Populate source data from SDF

2020-04-03 Thread GitBox
pabloem commented on issue #11302: [BEAM-9607] Populate source data from SDF URL: https://github.com/apache/beam/pull/11302#issuecomment-608550897 Thanks Boyuan! This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem merged pull request #11302: [BEAM-9607] Populate source data from SDF

2020-04-03 Thread GitBox
pabloem merged pull request #11302: [BEAM-9607] Populate source data from SDF URL: https://github.com/apache/beam/pull/11302 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] lucaslrolim commented on issue #7677: [BEAM-6768] BigQuery dynamic destinations for Python SDK Streaming Inserts

2020-04-03 Thread GitBox
lucaslrolim commented on issue #7677: [BEAM-6768] BigQuery dynamic destinations for Python SDK Streaming Inserts URL: https://github.com/apache/beam/pull/7677#issuecomment-608547176 Hello @ihji and @pabloem, Thank you for this feature, it will help me a lot! Any documentation about

[GitHub] [beam] boyuanzz merged pull request #11199: [BEAM-9562] Update Timer encoding with respect of dynamic timers

2020-04-03 Thread GitBox
boyuanzz merged pull request #11199: [BEAM-9562] Update Timer encoding with respect of dynamic timers URL: https://github.com/apache/beam/pull/11199 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] boyuanzz commented on issue #11199: [BEAM-9562] Update Timer encoding with respect of dynamic timers

2020-04-03 Thread GitBox
boyuanzz commented on issue #11199: [BEAM-9562] Update Timer encoding with respect of dynamic timers URL: https://github.com/apache/beam/pull/11199#issuecomment-608539461 All tests passed. i'm going to merge it. Thanks, everyone!

  1   2   >