[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612327959 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] angoenka opened a new pull request #11395: [Cherrypick 11365] [BEAM-9735] Adding Always trigger and using it in Reshuffle

2020-04-10 Thread GitBox
angoenka opened a new pull request #11395: [Cherrypick 11365] [BEAM-9735] Adding Always trigger and using it in Reshuffle URL: https://github.com/apache/beam/pull/11395 R: @ibzib **Please** add a meaningful description for your change here

[GitHub] [beam] angoenka closed pull request #11394: [cherrypick-11385] TOIL: Update Unified worker image

2020-04-10 Thread GitBox
angoenka closed pull request #11394: [cherrypick-11385] TOIL: Update Unified worker image URL: https://github.com/apache/beam/pull/11394 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] HuangLED commented on issue #11393: [DRAFT] Make StateBacked validation test not just run against fnapi python runner

2020-04-10 Thread GitBox
HuangLED commented on issue #11393: [DRAFT] Make StateBacked validation test not just run against fnapi python runner URL: https://github.com/apache/beam/pull/11393#issuecomment-612286370 R: @robertwb cc: @ananvay

[GitHub] [beam] HuangLED commented on a change in pull request #11393: [DRAFT] Remove the limit of StateBacked validation test on python fnapi runner.

2020-04-10 Thread GitBox
HuangLED commented on a change in pull request #11393: [DRAFT] Remove the limit of StateBacked validation test on python fnapi runner. URL: https://github.com/apache/beam/pull/11393#discussion_r406996972 ## File path:

[GitHub] [beam] HuangLED opened a new pull request #11393: [DRAFT] Remove the limit of StateBacked validation test on python fnapi runner.

2020-04-10 Thread GitBox
HuangLED opened a new pull request #11393: [DRAFT] Remove the limit of StateBacked validation test on python fnapi runner. URL: https://github.com/apache/beam/pull/11393 DRAFT for suggestion. Thank you for your contribution! Follow this checklist

[GitHub] [beam] angoenka commented on issue #11385: TOIL: Update Unified worker image

2020-04-10 Thread GitBox
angoenka commented on issue #11385: TOIL: Update Unified worker image URL: https://github.com/apache/beam/pull/11385#issuecomment-612278911 Note: All the Dataflow Runner V2 tests are passing. y This is an automated

[GitHub] [beam] angoenka merged pull request #11385: TOIL: Update Unified worker image

2020-04-10 Thread GitBox
angoenka merged pull request #11385: TOIL: Update Unified worker image URL: https://github.com/apache/beam/pull/11385 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612278707 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] Hannah-Jiang commented on issue #11372: [BEAM-9443] support direct_num_workers=0

2020-04-10 Thread GitBox
Hannah-Jiang commented on issue #11372: [BEAM-9443] support direct_num_workers=0 URL: https://github.com/apache/beam/pull/11372#issuecomment-612271655 The failures are not related to the PR, so merge it. This is an automated

[GitHub] [beam] Hannah-Jiang merged pull request #11372: [BEAM-9443] support direct_num_workers=0

2020-04-10 Thread GitBox
Hannah-Jiang merged pull request #11372: [BEAM-9443] support direct_num_workers=0 URL: https://github.com/apache/beam/pull/11372 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11372: [BEAM-9443] support direct_num_workers=0

2020-04-10 Thread GitBox
Hannah-Jiang commented on a change in pull request #11372: [BEAM-9443] support direct_num_workers=0 URL: https://github.com/apache/beam/pull/11372#discussion_r406987566 ## File path: CHANGES.md ## @@ -47,6 +47,33 @@ * Fixed X (Java/Python)

[GitHub] [beam] pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-10 Thread GitBox
pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#issuecomment-612271558 attempting to rebase. let's see how far that takes me... This is an

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-10 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-612264169 @lastomato Do you think we should add `FhirIO.Read` implementations that paginate through

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612269800 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612242492 Thanks for the very concrete actionable pointer! I will give that a try. This is an

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612268084 now linkage checker is giving me no output: ``` jferriero@shadow-gallery:~/VersionControl/beam$ sdks/java/build-tools/beam-linkage-check.sh Fri 10 Apr 2020

[GitHub] [beam] jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612259919 @lukecwik would it be a reasonable compromise to introduce a `google_oauth_clients_verion`? If not I believe we are at an impass. Reasoning / Research /

[GitHub] [beam] aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-10 Thread GitBox
aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#issuecomment-612264998 Run Java PostCommit This is an automated

[GitHub] [beam] aaltay commented on issue #11338: [BEAM-7923] Screendiff Integration Tests

2020-04-10 Thread GitBox
aaltay commented on issue #11338: [BEAM-7923] Screendiff Integration Tests URL: https://github.com/apache/beam/pull/11338#issuecomment-612264842 > A Jira ticket was created 3 hours ago about the error https://issues.apache.org/jira/browse/BEAM-9736 > > Global name

[GitHub] [beam] aaltay commented on issue #11338: [BEAM-7923] Screendiff Integration Tests

2020-04-10 Thread GitBox
aaltay commented on issue #11338: [BEAM-7923] Screendiff Integration Tests URL: https://github.com/apache/beam/pull/11338#issuecomment-612264898 retest this please This is an automated message from the Apache Git Service. To

[GitHub] [beam] jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612259919 @lukecwik would it be a reasonable compromise to introduce a `google_oauth_clients_verion`? If not I believe we are at an impass. Reasoning / Research /

[GitHub] [beam] aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-10 Thread GitBox
aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#issuecomment-612264607 Run Java PostCommit This is an automated

[GitHub] [beam] aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-10 Thread GitBox
aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#issuecomment-612264643 Run Dataflow ValidatesRunner This is an

[GitHub] [beam] jaketf commented on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-10 Thread GitBox
jaketf commented on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-612264169 @lastomato Do you think we should add `FhirIO.Read` implementations that paginate through

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612261337 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-10 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-612261234 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] allenpradeep opened a new pull request #11392: [BEAM-9739] Retry SpannerIO write on Schema change

2020-04-10 Thread GitBox
allenpradeep opened a new pull request #11392: [BEAM-9739] Retry SpannerIO write on Schema change URL: https://github.com/apache/beam/pull/11392 Spanner aborts all transactions in flight when there is a schema change and returns an Aborted Exception. The client is expected to retry the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612260628 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612260585 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-10 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-612260260 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612259919 @lukecwik would it be a reasonable compromise to introduce a `google_oauth_clients_verion`? If not I believe we are at an impass. Reasoning / Research /

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612259919 @lukecwik would it be a reasonable compromise to introduce a `google_oauth_clients_verion`? If not I believe we are at an impass. Reasoning / Research /

[GitHub] [beam] lukecwik commented on a change in pull request #11236: [BEAM-7505] Create SideInput Python Jenkins jobs

2020-04-10 Thread GitBox
lukecwik commented on a change in pull request #11236: [BEAM-7505] Create SideInput Python Jenkins jobs URL: https://github.com/apache/beam/pull/11236#discussion_r406967962 ## File path: .test-infra/jenkins/SideInputTestSuite.groovy ## @@ -0,0 +1,156 @@ +/* + * Licensed

[GitHub] [beam] lukecwik commented on a change in pull request #11236: [BEAM-7505] Create SideInput Python Jenkins jobs

2020-04-10 Thread GitBox
lukecwik commented on a change in pull request #11236: [BEAM-7505] Create SideInput Python Jenkins jobs URL: https://github.com/apache/beam/pull/11236#discussion_r406949975 ## File path: .test-infra/jenkins/LoadTestsBuilder.groovy ## @@ -54,6 +54,16 @@ class

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-10 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-612256393 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] stale[bot] commented on issue #9543: [BEAM-8206] Fix syntax errors in Java doc for PipelineRunner

2020-04-10 Thread GitBox
stale[bot] commented on issue #9543: [BEAM-8206] Fix syntax errors in Java doc for PipelineRunner URL: https://github.com/apache/beam/pull/9543#issuecomment-612254798 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-10 Thread GitBox
tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r406968173 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -609,7 +611,8 @@ def __init__(

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-10 Thread GitBox
tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r406969613 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1570,6 +1584,10 @@ class

[GitHub] [beam] robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.

2020-04-10 Thread GitBox
robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-612246441 R: @lukecwik This is an automated message from the Apache Git

[GitHub] [beam] robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.

2020-04-10 Thread GitBox
robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-612246262 Run Python2_PVR_Flink PreCommit This is an automated message from

[GitHub] [beam] robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.

2020-04-10 Thread GitBox
robertwb commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-612246232 Run Java PreCommit This is an automated message from the Apache

[GitHub] [beam] robertwb commented on issue #11371: [BEAM-9738] Update dataflow to setup correct docker environment options.

2020-04-10 Thread GitBox
robertwb commented on issue #11371: [BEAM-9738] Update dataflow to setup correct docker environment options. URL: https://github.com/apache/beam/pull/11371#issuecomment-612245771 Looks like there's failing tests that need to be updated.

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612245275 @lukecwik some progress I was able to update storage / cloudresourcemanager that way. However, in

[GitHub] [beam] robertwb commented on issue #11342: [BEAM-9577] New artifact staging and retrieval service for Java.

2020-04-10 Thread GitBox
robertwb commented on issue #11342: [BEAM-9577] New artifact staging and retrieval service for Java. URL: https://github.com/apache/beam/pull/11342#issuecomment-612245120 R: @lukecwik CC: @ihji This is an automated

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612242492 Thanks for the pointer! I will give that a try. This is an automated message from the Apache Git

[GitHub] [beam] lukecwik edited a comment on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
lukecwik edited a comment on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612242130 > @lukecwik that's what I thought to but when I do that I get the output in [this comment](https://github.com/apache/beam/pull/11151#discussion_r406551322)

[GitHub] [beam] lukecwik commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
lukecwik commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612242130 > @lukecwik that's what I thought to but when I do that I get the output in [this comment](https://github.com/apache/beam/pull/11151#discussion_r406551322)

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612237829 @lukecwik that's what I thought to but when I do that I get the output in [this comment](https://github.com/apache/beam/pull/11151#discussion_r406551322)

[GitHub] [beam] lukecwik commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
lukecwik commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612237090 Note that your dependency report seems to be showing that you should be able to update to the version needed by the healthcare lib.

[GitHub] [beam] robertwb commented on issue #11240: [BEAM-8466] Make strip_iterable more strict

2020-04-10 Thread GitBox
robertwb commented on issue #11240: [BEAM-8466] Make strip_iterable more strict URL: https://github.com/apache/beam/pull/11240#issuecomment-612235305 Any updates on this? This is an automated message from the Apache Git

[GitHub] [beam] lukecwik edited a comment on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
lukecwik edited a comment on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612234407 > @lukecwik I ran the linkeage check "as-is" ([log](https://gist.github.com/suztomo/3178f298bd315e2cc3897b5528a961b8)) and IIUC this has no issues. >

[GitHub] [beam] lukecwik commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
lukecwik commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612234407 > @lukecwik I ran the linkeage check "as-is" ([log](https://gist.github.com/suztomo/3178f298bd315e2cc3897b5528a961b8)) and IIUC this has no issues. > > Is

[GitHub] [beam] jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf edited a comment on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612232240 @lukecwik I ran the linkeage check "as-is" ([log](https://gist.github.com/suztomo/3178f298bd315e2cc3897b5528a961b8)) and IIUC this has no issues. Is

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612232240 @lukecwik I ran the linkeage check "as-is" ([log](https://gist.github.com/suztomo/3178f298bd315e2cc3897b5528a961b8)) and IIUC this has no issues. Is this

[GitHub] [beam] suztomo opened a new pull request #11391: [BEAM-9444] Rebasing old version of PR 11156 (no need to review)

2020-04-10 Thread GitBox
suztomo opened a new pull request #11391: [BEAM-9444] Rebasing old version of PR 11156 (no need to review) URL: https://github.com/apache/beam/pull/11391 ``` suztomo-macbookpro44% git log -3 commit b47744e6c69f5646a2c91026952aff65decc20b2 (HEAD -> BEAM-9444-rebase-c00df443,

[GitHub] [beam] mf2199 commented on a change in pull request #8457: [BEAM-3342] Create a Cloud Bigtable IO connector for Python

2020-04-10 Thread GitBox
mf2199 commented on a change in pull request #8457: [BEAM-3342] Create a Cloud Bigtable IO connector for Python URL: https://github.com/apache/beam/pull/8457#discussion_r406953225 ## File path: sdks/python/apache_beam/io/gcp/bigtableio.py ## @@ -141,3 +144,123 @@ def

[GitHub] [beam] robertwb commented on issue #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle

2020-04-10 Thread GitBox
robertwb commented on issue #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle URL: https://github.com/apache/beam/pull/11365#issuecomment-612227407 Can you please create a cherry-pick to the release? This

[GitHub] [beam] robertwb merged pull request #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle

2020-04-10 Thread GitBox
robertwb merged pull request #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle URL: https://github.com/apache/beam/pull/11365 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] robertwb commented on a change in pull request #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle

2020-04-10 Thread GitBox
robertwb commented on a change in pull request #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle URL: https://github.com/apache/beam/pull/11365#discussion_r406952462 ## File path: sdks/python/apache_beam/transforms/trigger.py ## @@ -367,6 +367,47 @@ def

[GitHub] [beam] pabloem commented on issue #11335: [BEAM-9692]: Make CombineValues portable

2020-04-10 Thread GitBox
pabloem commented on issue #11335: [BEAM-9692]: Make CombineValues portable URL: https://github.com/apache/beam/pull/11335#issuecomment-612225788 retest this please This is an automated message from the Apache Git Service. To

[GitHub] [beam] robertwb commented on issue #11390: [BEAM-9738] Update dataflow to setup correct docker environment options.

2020-04-10 Thread GitBox
robertwb commented on issue #11390: [BEAM-9738] Update dataflow to setup correct docker environment options. URL: https://github.com/apache/beam/pull/11390#issuecomment-612225114 R: @ibzib This is an automated message from

[GitHub] [beam] robertwb opened a new pull request #11390: [BEAM-9738] Update dataflow to setup correct docker environment options.

2020-04-10 Thread GitBox
robertwb opened a new pull request #11390: [BEAM-9738] Update dataflow to setup correct docker environment options. URL: https://github.com/apache/beam/pull/11390 Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] boyuanzz merged pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers

2020-04-10 Thread GitBox
boyuanzz merged pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers URL: https://github.com/apache/beam/pull/11373 This is an automated message from the Apache Git

[GitHub] [beam] lukecwik commented on issue #11236: [BEAM-7505] Create SideInput Python Jenkins jobs

2020-04-10 Thread GitBox
lukecwik commented on issue #11236: [BEAM-7505] Create SideInput Python Jenkins jobs URL: https://github.com/apache/beam/pull/11236#issuecomment-612223312 taking a look now. This is an automated message from the Apache Git

[GitHub] [beam] robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt…

2020-04-10 Thread GitBox
robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt… URL: https://github.com/apache/beam/pull/11371#issuecomment-61919 Run Python PreCommit This is an automated

[GitHub] [beam] robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt…

2020-04-10 Thread GitBox
robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt… URL: https://github.com/apache/beam/pull/11371#issuecomment-61970 Run Portable_Python PreCommit This is an

[GitHub] [beam] pabloem commented on issue #11389: Refactor the BCJ and capture controls to be more testable

2020-04-10 Thread GitBox
pabloem commented on issue #11389: Refactor the BCJ and capture controls to be more testable URL: https://github.com/apache/beam/pull/11389#issuecomment-612221061 retest this please This is an automated message from the

[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)

2020-04-10 Thread GitBox
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag) URL: https://github.com/apache/beam/pull/11381#issuecomment-612220776 trigger tests This is an automated message

[GitHub] [beam] rohdesamuel commented on issue #11389: Refactor the BCJ and capture controls to be more testable

2020-04-10 Thread GitBox
rohdesamuel commented on issue #11389: Refactor the BCJ and capture controls to be more testable URL: https://github.com/apache/beam/pull/11389#issuecomment-612219324 R: @pabloem This is an automated message from the Apache

[GitHub] [beam] rohdesamuel opened a new pull request #11389: Refactor the BCJ and capture controls to be more testable

2020-04-10 Thread GitBox
rohdesamuel opened a new pull request #11389: Refactor the BCJ and capture controls to be more testable URL: https://github.com/apache/beam/pull/11389 Change-Id: I51c5869a30ab4c82d727486604a77e3fc300f5be This pulls out the capture control logic from the BCJ into a "Limiter" class.

[GitHub] [beam] suztomo opened a new pull request #11388: [BEAM-9444] Clean version of PR 11156 (no need to review)

2020-04-10 Thread GitBox
suztomo opened a new pull request #11388: [BEAM-9444] Clean version of PR 11156 (no need to review) URL: https://github.com/apache/beam/pull/11388 Checking pull request validation for #11156 Thank you for your contribution! Follow this checklist to

[GitHub] [beam] ibzib commented on issue #11384: [BEAM-9736] Fix from_container_image call

2020-04-10 Thread GitBox
ibzib commented on issue #11384: [BEAM-9736] Fix from_container_image call URL: https://github.com/apache/beam/pull/11384#issuecomment-612216645 Ah, makes sense. Thanks for the pointer This is an automated message from the

[GitHub] [beam] pabloem commented on issue #11384: [BEAM-9736] Fix from_container_image call

2020-04-10 Thread GitBox
pabloem commented on issue #11384: [BEAM-9736] Fix from_container_image call URL: https://github.com/apache/beam/pull/11384#issuecomment-612216359 (that's fyi) This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem commented on issue #11384: [BEAM-9736] Fix from_container_image call

2020-04-10 Thread GitBox
pabloem commented on issue #11384: [BEAM-9736] Fix from_container_image call URL: https://github.com/apache/beam/pull/11384#issuecomment-612216309 The failures seem related to missing worker containers on the dataflow side

[GitHub] [beam] ibzib commented on issue #11384: [BEAM-9736] Fix from_container_image call

2020-04-10 Thread GitBox
ibzib commented on issue #11384: [BEAM-9736] Fix from_container_image call URL: https://github.com/apache/beam/pull/11384#issuecomment-612215754 I'm not sure what's causing the test failures, but I'm pretty certain it's not this PR.

[GitHub] [beam] ibzib merged pull request #11384: [BEAM-9736] Fix from_container_image call

2020-04-10 Thread GitBox
ibzib merged pull request #11384: [BEAM-9736] Fix from_container_image call URL: https://github.com/apache/beam/pull/11384 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] suztomo closed pull request #11387: [BEAM-9444] rebased version of PR 11156

2020-04-10 Thread GitBox
suztomo closed pull request #11387: [BEAM-9444] rebased version of PR 11156 URL: https://github.com/apache/beam/pull/11387 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] suztomo opened a new pull request #11387: [BEAM-9444] rebased version of PR 11156

2020-04-10 Thread GitBox
suztomo opened a new pull request #11387: [BEAM-9444] rebased version of PR 11156 URL: https://github.com/apache/beam/pull/11387 Rebased version of https://github.com/apache/beam/pull/11156. Experimenting pull request validation. Thank you for

[GitHub] [beam] angoenka commented on issue #11385: TOIL: Update Unified worker image

2020-04-10 Thread GitBox
angoenka commented on issue #11385: TOIL: Update Unified worker image URL: https://github.com/apache/beam/pull/11385#issuecomment-612212602 Flink error seems to be unrelated. This is an automated message from the Apache Git

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-10 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-612210945 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-10 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-612207439 Run Full Website Test This is an automated message from the Apache Git Service. To

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-10 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r406931472 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-10 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r406931239 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] udim opened a new pull request #11386: [BEAM-9737] Adding debugging information

2020-04-10 Thread GitBox
udim opened a new pull request #11386: [BEAM-9737] Adding debugging information URL: https://github.com/apache/beam/pull/11386 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help

[GitHub] [beam] boyuanzz commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers

2020-04-10 Thread GitBox
boyuanzz commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers URL: https://github.com/apache/beam/pull/11373#discussion_r406921308 ## File path: sdks/go/pkg/beam/model/pipeline_v1/beam_runner_api.pb.go

[GitHub] [beam] robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt…

2020-04-10 Thread GitBox
robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt… URL: https://github.com/apache/beam/pull/11371#issuecomment-612195376 Run PythonLint PreCommit This is an automated

[GitHub] [beam] boyuanzz commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers

2020-04-10 Thread GitBox
boyuanzz commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers URL: https://github.com/apache/beam/pull/11373#discussion_r406918619 ## File path: sdks/go/pkg/beam/model/pipeline_v1/beam_runner_api.pb.go

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-10 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-612191775 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ananvay commented on issue #11385: TOIL: Update Unified worker image

2020-04-10 Thread GitBox
ananvay commented on issue #11385: TOIL: Update Unified worker image URL: https://github.com/apache/beam/pull/11385#issuecomment-612191399 Thanks a lot Ankur! LGTM This is an automated message from the Apache Git

[GitHub] [beam] angoenka opened a new pull request #11385: TOIL: Update Unified worker image

2020-04-10 Thread GitBox
angoenka opened a new pull request #11385: TOIL: Update Unified worker image URL: https://github.com/apache/beam/pull/11385 R: @ananvay **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] pabloem commented on issue #11384: [BEAM-9736] Fix from_container_image call

2020-04-10 Thread GitBox
pabloem commented on issue #11384: [BEAM-9736] Fix from_container_image call URL: https://github.com/apache/beam/pull/11384#issuecomment-612188611 FYI https://github.com/apache/beam/pull/11383 has been merged. This is an

[GitHub] [beam] pabloem merged pull request #11383: [BEAM-9736] Fix from_container_image call

2020-04-10 Thread GitBox
pabloem merged pull request #11383: [BEAM-9736] Fix from_container_image call URL: https://github.com/apache/beam/pull/11383 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb merged pull request #11311: [BEAM-9577] Attempt to stage resources via new API in portable runner.

2020-04-10 Thread GitBox
robertwb merged pull request #11311: [BEAM-9577] Attempt to stage resources via new API in portable runner. URL: https://github.com/apache/beam/pull/11311 This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] robertwb commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers

2020-04-10 Thread GitBox
robertwb commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers URL: https://github.com/apache/beam/pull/11373#discussion_r406912246 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto

[GitHub] [beam] pabloem commented on issue #11382: Fix break caused by #11370.

2020-04-10 Thread GitBox
pabloem commented on issue #11382: Fix break caused by #11370. URL: https://github.com/apache/beam/pull/11382#issuecomment-612182137 discussed w Robert. Closing this. IDK. ^^' This is an automated message from the Apache Git

[GitHub] [beam] pabloem closed pull request #11382: Fix break caused by #11370.

2020-04-10 Thread GitBox
pabloem closed pull request #11382: Fix break caused by #11370. URL: https://github.com/apache/beam/pull/11382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] ibzib commented on issue #11382: Fix break caused by #11370.

2020-04-10 Thread GitBox
ibzib commented on issue #11382: Fix break caused by #11370. URL: https://github.com/apache/beam/pull/11382#issuecomment-612181551 This is duped by #11383, can we close one of these? This is an automated message from the

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-10 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-612180516 retest this please This is an automated message from the

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-10 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-612180668 run flink validatesrunner This is an automated message from

  1   2   >