[GitHub] [beam] damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-14 Thread GitBox
damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r408584291 ## File path: learning/katas/go/Introduction/Hello Beam/Hello Beam/pkg/task/task.go ## @@ -0,0 +1,24

[GitHub] [beam] youngoli commented on issue #11423: [BEAM-9642] Fix infinite recursion.

2020-04-14 Thread GitBox
youngoli commented on issue #11423: [BEAM-9642] Fix infinite recursion. URL: https://github.com/apache/beam/pull/11423#issuecomment-613760696 Agreed. I did what validation I could, but neither lint or gofmt caught this one. I think go vet would've caught it, but it was annoying to use (if I

[GitHub] [beam] youngoli merged pull request #11423: [BEAM-9642] Fix infinite recursion.

2020-04-14 Thread GitBox
youngoli merged pull request #11423: [BEAM-9642] Fix infinite recursion. URL: https://github.com/apache/beam/pull/11423 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [beam] lostluck commented on issue #11423: [BEAM-9642] Fix infinite recursion.

2020-04-14 Thread GitBox
lostluck commented on issue #11423: [BEAM-9642] Fix infinite recursion. URL: https://github.com/apache/beam/pull/11423#issuecomment-613759173 Thanks! If we could get some kind of github static check to have caught that for us that would have been great. Good thing we had a quick import afte

[GitHub] [beam] youngoli opened a new pull request #11423: [BEAM-9642] Fix infinite recursion.

2020-04-14 Thread GitBox
youngoli opened a new pull request #11423: [BEAM-9642] Fix infinite recursion. URL: https://github.com/apache/beam/pull/11423 Small fix. I debated bundling this in a larger PR but I was worried I might forget. Thank you for your contribution! Follow th

[GitHub] [beam] youngoli commented on issue #11423: [BEAM-9642] Fix infinite recursion.

2020-04-14 Thread GitBox
youngoli commented on issue #11423: [BEAM-9642] Fix infinite recursion. URL: https://github.com/apache/beam/pull/11423#issuecomment-613754243 R: @lostluck This is an automated message from the Apache Git Service. To respond t

[GitHub] [beam] pabloem opened a new pull request #11422: Removing underscore from _ReadFromBigQuery to make it external. It re…

2020-04-14 Thread GitBox
pabloem opened a new pull request #11422: Removing underscore from _ReadFromBigQuery to make it external. It re… URL: https://github.com/apache/beam/pull/11422 It remains experimental. r: @kamilwu cc: @chamikaramj **Please** add a meaningful description for your change here

[GitHub] [beam] lostluck merged pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck merged pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on issue #11404: Fixing type names for BQ Avro Tools

2020-04-14 Thread GitBox
pabloem commented on issue #11404: Fixing type names for BQ Avro Tools URL: https://github.com/apache/beam/pull/11404#issuecomment-613747348 https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java#L23

[GitHub] [beam] tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml

2020-04-14 Thread GitBox
tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml URL: https://github.com/apache/beam/pull/11399#issuecomment-613747240 Run Java PreCommit This is an automated message from t

[GitHub] [beam] tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml

2020-04-14 Thread GitBox
tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml URL: https://github.com/apache/beam/pull/11399#issuecomment-613747057 Run Python2_PVR_Flink PreCommit This is an automated m

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408509101 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408508964 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -75

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408509078 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507914 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@ -914,1

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507854 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ## @@ -326,8

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507693 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ## @@ -367,6

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507730 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ## @@ -367,6

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507780 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ## @@ -367,6

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507669 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -14

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408507507 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507558 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -14

[GitHub] [beam] pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-14 Thread GitBox
pabloem commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#discussion_r408507610 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -75

[GitHub] [beam] pabloem commented on issue #11404: Fixing type names for BQ Avro Tools

2020-04-14 Thread GitBox
pabloem commented on issue #11404: Fixing type names for BQ Avro Tools URL: https://github.com/apache/beam/pull/11404#issuecomment-613740743 I found it in sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java?l=213-261 -

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-14 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [x] Unit test for FhirIO dead letter handling - [x] Migrate ITs to para

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-14 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-613738430 Run Full Website Test This is an automated message from the Apache Git Service. To respon

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-14 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [x] Unit test for FhirIO dead letter handling - [x] Migrate ITs to para

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-14 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [x] Unit test for FhirIO dead letter handling - [x] Migrate ITs to para

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-14 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [x] Unit test for FhirIO dead letter handling - [x] Migrate ITs to para

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-14 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [x] Unit test for FhirIO dead letter handling - [ ] Migrate ITs to para

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-14 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-613737579 Run Full Website Test This is an automated message from the Apache Git Service. To respon

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-14 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [x] Unit test for FhirIO dead letter handling - [ ] Add IT for FhirIO.R

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-04-14 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r408491512 ## File path: website/src/documentation/programming-guide.md ## @@ -1970,7 +1976,1078 @@ records.apply("WriteToText", See t

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-04-14 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r408486134 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java ## @@ -3427,7 +3427,7 @@ public vo

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-04-14 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r408487773 ## File path: website/src/documentation/programming-guide.md ## @@ -1970,7 +1976,1078 @@ records.apply("WriteToText", See t

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-04-14 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r408488549 ## File path: website/src/documentation/programming-guide.md ## @@ -1970,7 +1976,1108 @@ records.apply("WriteToText", See t

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-04-14 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r408487454 ## File path: website/src/documentation/programming-guide.md ## @@ -1970,7 +1976,1076 @@ records.apply("WriteToText", See t

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas

2020-04-14 Thread GitBox
TheNeuralBit commented on a change in pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#discussion_r408490573 ## File path: website/src/documentation/programming-guide.md ## @@ -1970,7 +1976,1108 @@ records.apply("WriteToText", See t

[GitHub] [beam] ibzib commented on issue #11417: [BEAM-9756] Nexmark: only use --region in Dataflow.

2020-04-14 Thread GitBox
ibzib commented on issue #11417: [BEAM-9756] Nexmark: only use --region in Dataflow. URL: https://github.com/apache/beam/pull/11417#issuecomment-613727368 Run Dataflow Runner Nexmark Tests This is an automated message from th

[GitHub] [beam] tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml

2020-04-14 Thread GitBox
tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml URL: https://github.com/apache/beam/pull/11399#issuecomment-613725645 > Please apply your change to > > https://github.com/apache/beam/blob/4a7eb329734131e1ef90419f405986de94a30846/b

[GitHub] [beam] lukecwik commented on a change in pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls.

2020-04-14 Thread GitBox
lukecwik commented on a change in pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls. URL: https://github.com/apache/beam/pull/11414#discussion_r408487984 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDo

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-04-14 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-613722634 cc: @Ardagan This is an automated message from the Apache Git Service. To respo

[GitHub] [beam] jkff commented on a change in pull request #11406: [BEAM-9748] Move Reparallelize transform to Reshuffle

2020-04-14 Thread GitBox
jkff commented on a change in pull request #11406: [BEAM-9748] Move Reparallelize transform to Reshuffle URL: https://github.com/apache/beam/pull/11406#discussion_r408484775 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Reshuffle.java ## @@ -65

[GitHub] [beam] boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-14 Thread GitBox
boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r408483552 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRa

[GitHub] [beam] boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-14 Thread GitBox
boyuanzz commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r408483381 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRa

[GitHub] [beam] youngoli commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
youngoli commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408477556 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] youngoli commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
youngoli commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408481881 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] youngoli commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
youngoli commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408477833 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] boyuanzz commented on a change in pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls.

2020-04-14 Thread GitBox
boyuanzz commented on a change in pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls. URL: https://github.com/apache/beam/pull/11414#discussion_r408482142 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDo

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-04-14 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-613720045 It looks like PreCommit failures are just flakes or persistent failures at this point. I think I've addressed all of the PR comments, I ju

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408481474 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +260,166 @@ func T

[GitHub] [beam] thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408479609 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +260,166 @@ f

[GitHub] [beam] thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408478965 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ f

[GitHub] [beam] Hannah-Jiang opened a new pull request #11421: [release-2.21.0] Cherrypick license_java

2020-04-14 Thread GitBox
Hannah-Jiang opened a new pull request #11421: [release-2.21.0] Cherrypick license_java URL: https://github.com/apache/beam/pull/11421 R: @ibzib Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly a

[GitHub] [beam] ibzib commented on issue #11417: [BEAM-9756] Nexmark: only use --region in Dataflow.

2020-04-14 Thread GitBox
ibzib commented on issue #11417: [BEAM-9756] Nexmark: only use --region in Dataflow. URL: https://github.com/apache/beam/pull/11417#issuecomment-613714882 Run Seed Job This is an automated message from the Apache Git Service.

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-14 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r408473046 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRa

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-14 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r408473046 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRa

[GitHub] [beam] lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-14 Thread GitBox
lukecwik commented on a change in pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418#discussion_r408473271 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRa

[GitHub] [beam] Hannah-Jiang merged pull request #11416: [BEAM-9136] reduce third_party_dependencies size

2020-04-14 Thread GitBox
Hannah-Jiang merged pull request #11416: [BEAM-9136] reduce third_party_dependencies size URL: https://github.com/apache/beam/pull/11416 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] stale[bot] commented on issue #10857: [BEAM-8889] Upgrade guava to 28.0-jre

2020-04-14 Thread GitBox
stale[bot] commented on issue #10857: [BEAM-8889] Upgrade guava to 28.0-jre URL: https://github.com/apache/beam/pull/10857#issuecomment-613709936 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408468603 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408468636 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] lukecwik commented on issue #11420: [BEAM-9577] Fix test to create urls from paths which are compatible with Windows.

2020-04-14 Thread GitBox
lukecwik commented on issue #11420: [BEAM-9577] Fix test to create urls from paths which are compatible with Windows. URL: https://github.com/apache/beam/pull/11420#issuecomment-613708529 R: @tvalentyn @robertwb This is an a

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408468620 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] lukecwik opened a new pull request #11420: [BEAM-9577] Fix test to create urls from paths which are compatible with Windows.

2020-04-14 Thread GitBox
lukecwik opened a new pull request #11420: [BEAM-9577] Fix test to create urls from paths which are compatible with Windows. URL: https://github.com/apache/beam/pull/11420 Tested manually on a Windows VM with Python 3.7 Thank you for your contribution!

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io

2020-04-14 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] [WIP] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-611125298 TODOs: - [x] ValueProvider support - [x] Add example usage to javadoc - [x] Unit test for FhirIO dead letter handling - [ ] Add IT for FhirIO.R

[GitHub] [beam] iemejia commented on issue #11406: [BEAM-9748] Move Reparallelize transform to Reshuffle

2020-04-14 Thread GitBox
iemejia commented on issue #11406: [BEAM-9748] Move Reparallelize transform to Reshuffle URL: https://github.com/apache/beam/pull/11406#issuecomment-613706077 Changes addressed and renamed to the suggested name by Eugene. PTAL again @lukecwik -

[GitHub] [beam] lukecwik commented on issue #11409: [BEAM-2939] Update unbounded source as SDF wrapper to resume successfully.

2020-04-14 Thread GitBox
lukecwik commented on issue #11409: [BEAM-2939] Update unbounded source as SDF wrapper to resume successfully. URL: https://github.com/apache/beam/pull/11409#issuecomment-613703212 Run Java PreCommit This is an automated mess

[GitHub] [beam] robertwb commented on a change in pull request #11335: [BEAM-9692]: Make CombineValues portable

2020-04-14 Thread GitBox
robertwb commented on a change in pull request #11335: [BEAM-9692]: Make CombineValues portable URL: https://github.com/apache/beam/pull/11335#discussion_r408461679 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -110,22 +110,27 @@ class Dat

[GitHub] [beam] robertwb commented on a change in pull request #11335: [BEAM-9692]: Make CombineValues portable

2020-04-14 Thread GitBox
robertwb commented on a change in pull request #11335: [BEAM-9692]: Make CombineValues portable URL: https://github.com/apache/beam/pull/11335#discussion_r408461337 ## File path: sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py ## @@ -111,3 +111,38 @@ def e

[GitHub] [beam] Ardagan commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
Ardagan commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408453789 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] iemejia commented on issue #11028: BEAM-2546 Beam IO for InfluxDB

2020-04-14 Thread GitBox
iemejia commented on issue #11028: BEAM-2546 Beam IO for InfluxDB URL: https://github.com/apache/beam/pull/11028#issuecomment-613695575 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-04-14 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-613694546 Run CommunityMetrics PreCommit This is an automated message from the Apache Git

[GitHub] [beam] Hannah-Jiang commented on issue #11416: [BEAM-9136] reduce third_party_dependencies size

2020-04-14 Thread GitBox
Hannah-Jiang commented on issue #11416: [BEAM-9136] reduce third_party_dependencies size URL: https://github.com/apache/beam/pull/11416#issuecomment-613692624 Run Java PreCommit This is an automated message from the Apache Gi

[GitHub] [beam] Ardagan commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
Ardagan commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408448451 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] chunyang edited a comment on issue #11404: Fixing type names for BQ Avro Tools

2020-04-14 Thread GitBox
chunyang edited a comment on issue #11404: Fixing type names for BQ Avro Tools URL: https://github.com/apache/beam/pull/11404#issuecomment-613683445 Does Java handle `BOOL` in a different part of the code? I can't tell from BigQueryAvroUtils.java. Either way I think it makes sense to suppor

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-04-14 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-613684342 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-04-14 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-613684230 Run CommunityMetrics PreCommit This is an automated message from the Apache Git

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-04-14 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-613684149 Run Python PreCommit This is an automated message from the Apache Git Service. T

[GitHub] [beam] chunyang commented on issue #11404: Fixing type names for BQ Avro Tools

2020-04-14 Thread GitBox
chunyang commented on issue #11404: Fixing type names for BQ Avro Tools URL: https://github.com/apache/beam/pull/11404#issuecomment-613683445 Does Java handle `BOOL` in a different part of the code? I can't tell from BigQueryAvroUtils.java. Either way I think it makes sense to support `BOOL

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408431325 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408433143 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408430834 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408433930 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408434733 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-14 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-613681105 @lukecwik ptal so @jaketf won't have to rebase if changes look fine This is an automated message fr

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408430781 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r408432853 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -50,25 +50,25 @@ For i

[GitHub] [beam] ibzib commented on issue #11417: [BEAM-9756] Nexmark: only use --region in Dataflow.

2020-04-14 Thread GitBox
ibzib commented on issue #11417: [BEAM-9756] Nexmark: only use --region in Dataflow. URL: https://github.com/apache/beam/pull/11417#issuecomment-613681012 Run Dataflow Runner Nexmark Tests This is an automated message from th

[GitHub] [beam] amaliujia commented on issue #10946: [BEAM-9363] TUMBLE as TVF

2020-04-14 Thread GitBox
amaliujia commented on issue #10946: [BEAM-9363] TUMBLE as TVF URL: https://github.com/apache/beam/pull/10946#issuecomment-613679461 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] robertwb opened a new pull request #11419: [BEAM-9561] Add a framework for running pandas doctests with beam dataframes.

2020-04-14 Thread GitBox
robertwb opened a new pull request #11419: [BEAM-9561] Add a framework for running pandas doctests with beam dataframes. URL: https://github.com/apache/beam/pull/11419 R: @TheNeuralBit Depends on https://github.com/apache/beam/pull/11264 Thank

[GitHub] [beam] udim commented on issue #11386: [BEAM-9737] Fix website postcommit

2020-04-14 Thread GitBox
udim commented on issue #11386: [BEAM-9737] Fix website postcommit URL: https://github.com/apache/beam/pull/11386#issuecomment-613669573 Run Full Website Test This is an automated message from the Apache Git Service. To respon

[GitHub] [beam] Ardagan edited a comment on issue #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-14 Thread GitBox
Ardagan edited a comment on issue #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#issuecomment-613597087 R: @soyrice @rosetn This is an automated message from

[GitHub] [beam] boyuanzz opened a new pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker

2020-04-14 Thread GitBox
boyuanzz opened a new pull request #11418: [BEAM-8872] Support split at fraction for OffsetRangeTracker URL: https://github.com/apache/beam/pull/11418 **Please** add a meaningful description for your change here Thank you for your contribution! Follow

[GitHub] [beam] thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408403890 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ f

[GitHub] [beam] thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408401030 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ f

[GitHub] [beam] thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
thetorpedodog commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408412639 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ f

[GitHub] [beam] lukecwik commented on issue #11409: [BEAM-2939] Update unbounded source as SDF wrapper to resume successfully.

2020-04-14 Thread GitBox
lukecwik commented on issue #11409: [BEAM-2939] Update unbounded source as SDF wrapper to resume successfully. URL: https://github.com/apache/beam/pull/11409#issuecomment-613656085 Run Java PreCommit This is an automated mess

[GitHub] [beam] lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state

2020-04-14 Thread GitBox
lostluck commented on a change in pull request #11413: [BEAM-9746] check for 0 length copies from state URL: https://github.com/apache/beam/pull/11413#discussion_r408403428 ## File path: sdks/go/pkg/beam/core/runtime/harness/statemgr_test.go ## @@ -258,6 +261,167 @@ func T

[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)

2020-04-14 Thread GitBox
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag) URL: https://github.com/apache/beam/pull/11381#issuecomment-613655133 Run Java PreCommit This is an automated mess

  1   2   >