piotr-szuberski commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r429087219
##
File path: sdks/python/test-suites/dataflow/py2/build.gradle
##
@@ -205,3 +205,20 @@ task chicagoTaxiExample {
}
}
}
+
+task runPerform
piotr-szuberski commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r429088004
##
File path: .test-infra/jenkins/job_PerformanceTests_Python.groovy
##
@@ -58,117 +26,59 @@ def dataflowPipelineArgs = [
temp_location : 'g
piotr-szuberski commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r429088765
##
File path: .test-infra/jenkins/job_PerformanceTests_Python.groovy
##
@@ -58,117 +26,59 @@ def dataflowPipelineArgs = [
temp_location : 'g
piotr-szuberski commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r429094648
##
File path: sdks/python/test-suites/dataflow/common.gradle
##
@@ -109,4 +109,21 @@ task validatesRunnerStreamingTests {
args '-c', ". ${en
piotr-szuberski commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r429095714
##
File path: sdks/python/test-suites/dataflow/common.gradle
##
@@ -109,4 +109,21 @@ task validatesRunnerStreamingTests {
args '-c', ". ${en
piotr-szuberski edited a comment on pull request #11661:
URL: https://github.com/apache/beam/pull/11661#issuecomment-63279
@tvalentyn Thank you much for your review! I made the requested changes. I'm
still not sure about the part of the dashboards so please add a word whether my
answer
piotr-szuberski commented on pull request #11661:
URL: https://github.com/apache/beam/pull/11661#issuecomment-63279
@tvalentyn I made the requested changes. I'm not sure about the part of
dashboards so please add a word whether my answer is sufficient.
piotr-szuberski edited a comment on pull request #11661:
URL: https://github.com/apache/beam/pull/11661#issuecomment-63279
This is an automated message from the Apache Git Service.
To respond to the message, please log on
piotr-szuberski edited a comment on pull request #11661:
URL: https://github.com/apache/beam/pull/11661#issuecomment-626801208
@markflyhigh Could I ask you for review?
This is an automated message from the Apache Git Service.
piotr-szuberski edited a comment on pull request #11661:
URL: https://github.com/apache/beam/pull/11661#issuecomment-63279
@tvalentyn Thank you much for your review! I made the requested changes. I'm
still not sure about the part of the dashboards so please add a word whether my
answer
purbanow opened a new pull request #11794:
URL: https://github.com/apache/beam/pull/11794
This PR is part of adding SnowflakeIO to Java SDK
[BEAM-9893](https://issues.apache.org/jira/browse/BEAM-9893). Precisely this PR
is adding write operation to SnowflakeIO
[BEAM-9894](https://issues.a
iemejia commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632558819
Run CommunityMetrics PreCommit
This is an automated message from the Apache Git Service.
To respond to the messag
iemejia commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632558904
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
purbanow commented on a change in pull request #11794:
URL: https://github.com/apache/beam/pull/11794#discussion_r429105275
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeServiceImpl.java
##
@@ -1,90 +0,0 @@
-/*
- * Licensed to the
purbanow commented on a change in pull request #11794:
URL: https://github.com/apache/beam/pull/11794#discussion_r429105275
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeServiceImpl.java
##
@@ -1,90 +0,0 @@
-/*
- * Licensed to the
mxm commented on pull request #11777:
URL: https://github.com/apache/beam/pull/11777#issuecomment-632572299
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
mwalenia commented on pull request #11775:
URL: https://github.com/apache/beam/pull/11775#issuecomment-632580795
First precommit passed, launching second
This is an automated message from the Apache Git Service.
To respond to
mwalenia commented on pull request #11775:
URL: https://github.com/apache/beam/pull/11775#issuecomment-632580694
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
mwalenia commented on pull request #11775:
URL: https://github.com/apache/beam/pull/11775#issuecomment-632601472
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
RyanSkraba commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r429149206
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/BeamBatchWorker.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache
RyanSkraba commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r429155712
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/package-info.java
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Soft
kamilwu opened a new pull request #11795:
URL: https://github.com/apache/beam/pull/11795
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.a
kamilwu commented on pull request #11795:
URL: https://github.com/apache/beam/pull/11795#issuecomment-632612022
Run Python 2 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
RyanSkraba commented on pull request #10888:
URL: https://github.com/apache/beam/pull/10888#issuecomment-632621478
I ran the `validatesRunner` tests again and the partition /tmp directory
wasn't filled with zip files! Thanks for your speedy attention, LGTM!
--
purbanow commented on pull request #11794:
URL: https://github.com/apache/beam/pull/11794#issuecomment-632624409
Hi @RyanSkraba will you find a moment to make a CR for this PR?
This is an automated message from the Apache Git
kamilwu commented on pull request #11795:
URL: https://github.com/apache/beam/pull/11795#issuecomment-632631059
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
kamilwu commented on pull request #11795:
URL: https://github.com/apache/beam/pull/11795#issuecomment-632647909
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please log
kgabryje opened a new pull request #11796:
URL: https://github.com/apache/beam/pull/11796
Currently code samples are fetched from Beam Github's master branch. So in
order to make change in code and then write a document piece with code sample,
it was necessary create 2 PRs - one with chang
kgabryje commented on pull request #11796:
URL: https://github.com/apache/beam/pull/11796#issuecomment-632648552
Hi @rezarokni , this PR solves the issue submitted by you. Can you take a
look?
Also @pabloem , I'd appreciate if you took a look as well.
--
mwalenia commented on pull request #11566:
URL: https://github.com/apache/beam/pull/11566#issuecomment-632663593
@tysonjh What do you think about it now? I added Javadocs and some tests -
do you feel some tests are still missing? Let me know!
--
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r429202254
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r429213646
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to th
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r429213709
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to th
mwalenia commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r429213975
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the
stale[bot] commented on pull request #11186:
URL: https://github.com/apache/beam/pull/11186#issuecomment-632681994
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
epicfaace opened a new pull request #11797:
URL: https://github.com/apache/beam/pull/11797
Fix beam release guide template so that it shows up, and so that it also
highlights syntax in markdown.
It turns out, the `` part of the template was what was causing
the display issues.
epicfaace opened a new pull request #11798:
URL: https://github.com/apache/beam/pull/11798
R: @udim.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s
naipath opened a new pull request #11799:
URL: https://github.com/apache/beam/pull/11799
This pull request adds support for `ValueProvider` for
RedisConnectionConfiguration.
Thank you for your contribution! Follow this checklist to help us
incorporate
epicfaace commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-632723409
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r429283778
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/package-info.java
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Softwa
epicfaace commented on a change in pull request #11788:
URL: https://github.com/apache/beam/pull/11788#discussion_r429283691
##
File path: .test-infra/jenkins/README.md
##
@@ -84,6 +84,7 @@ Beam Jenkins overview page:
[link](https://builds.apache.org/view/A-D/view/Beam/
| bea
epicfaace commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-632724234
Run Python PreCommit
Run Python 3.7 PostCommit
Run Python 3.8 PostCommit
This is an automated mes
naipath commented on pull request #11799:
URL: https://github.com/apache/beam/pull/11799#issuecomment-632724291
R: @jbonofre
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pulasthi commented on pull request #10888:
URL: https://github.com/apache/beam/pull/10888#issuecomment-632724710
@RyanSkraba Thank you so much for your review and feedback
This is an automated message from the Apache Git Serv
kamilwu commented on pull request #11776:
URL: https://github.com/apache/beam/pull/11776#issuecomment-632724995
R: @aaltay Could you take a look?
Website staging is not working at the moment, fix is in progress:
https://github.com/apache/beam/pull/11796
epicfaace opened a new pull request #11800:
URL: https://github.com/apache/beam/pull/11800
R: @youngoli
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
review
pulasthi commented on pull request #10888:
URL: https://github.com/apache/beam/pull/10888#issuecomment-632725227
@iemejia Would we be able to merge this into the master so it would be
included in the 2.23.0 release? let me know what else needs to happen on my end
to proceed.
---
santhh commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r429296219
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the A
santhh commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r429297298
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the A
santhh commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r429297864
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/DLPDeidentifyText.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the A
epicfaace commented on pull request #11759:
URL: https://github.com/apache/beam/pull/11759#issuecomment-632737396
I don't like this approach. I think it's best to manually add code snippets
as in #11790.
This is an automated
epicfaace closed pull request #11759:
URL: https://github.com/apache/beam/pull/11759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
epicfaace opened a new pull request #11801:
URL: https://github.com/apache/beam/pull/11801
Use Hugo's `--minify` flag to minify website assets, such as HTML files.
Size of the `dist` folder has changed from 41M -> 39M. R: @aaltay
Thank you for your co
lostluck merged pull request #11768:
URL: https://github.com/apache/beam/pull/11768
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck merged pull request #11782:
URL: https://github.com/apache/beam/pull/11782
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck commented on pull request #11782:
URL: https://github.com/apache/beam/pull/11782#issuecomment-632807038
I like that the tests are very nicely separated for the different cases eg.
Unknown being more permissive than any of the stricter checks. Well done!
--
chadrik commented on a change in pull request #11632:
URL: https://github.com/apache/beam/pull/11632#discussion_r429361766
##
File path: sdks/python/apache_beam/dataframe/convert.py
##
@@ -16,13 +16,23 @@
from __future__ import absolute_import
+import typing
+
import insp
lostluck commented on a change in pull request #11791:
URL: https://github.com/apache/beam/pull/11791#discussion_r429361145
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##
@@ -266,33 +267,85 @@ func (n *DataSource) Progress() ProgressReportSnapshot {
r
epicfaace commented on a change in pull request #11780:
URL: https://github.com/apache/beam/pull/11780#discussion_r429376885
##
File path: website/www/site/content/en/community/mascot.md
##
@@ -0,0 +1,52 @@
+---
+title: "Beam Mascot"
+---
+
+
+# Beam Mascot Design
+
+This page
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632831985
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
iemejia commented on a change in pull request #11780:
URL: https://github.com/apache/beam/pull/11780#discussion_r429122732
##
File path: website/www/site/content/en/community/mascot.md
##
@@ -0,0 +1,52 @@
+---
+title: "Beam Mascot"
+---
+
+
+# Beam Mascot Design
+
+This page co
stale[bot] commented on pull request #10528:
URL: https://github.com/apache/beam/pull/10528#issuecomment-632834816
This pull request has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any
time.
--
stale[bot] closed pull request #10528:
URL: https://github.com/apache/beam/pull/10528
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632932510
D'oh Python PreCommit is failing just because 2.22.0 containers haven't been
built yet. I'll merge now
This
TheNeuralBit merged pull request #11778:
URL: https://github.com/apache/beam/pull/11778
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
epicfaace opened a new pull request #11802:
URL: https://github.com/apache/beam/pull/11802
Update I/O documentation links to point to the appropriate pydoc / javadoc /
godoc pages. Also, create a more complete I/O matrix that has all the existing
I/O's used in all three languages, with a t
66 matches
Mail list logo
