[GitHub] [beam] TheNeuralBit merged pull request #11904: Update Beam website to release 2.22.0

2020-06-09 Thread GitBox
TheNeuralBit merged pull request #11904: URL: https://github.com/apache/beam/pull/11904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] lukecwik commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-06-09 Thread GitBox
lukecwik commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-640693597 > @tysonjh > > I added some tests with 1000 windows. However, there's a problem with them: the side input is empty and no elements are accessed. I think it's because of

[GitHub] [beam] TheNeuralBit commented on pull request #11910: Add blog post announcing the 2.22.0 release

2020-06-09 Thread GitBox
TheNeuralBit commented on pull request #11910: URL: https://github.com/apache/beam/pull/11910#issuecomment-640844042 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] reubenvanammers commented on pull request #11955: [BEAM-10220] add support for implicit nulls

2020-06-09 Thread GitBox
reubenvanammers commented on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641056136 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] robertwb commented on pull request #11935: [BEAM-9577] Remove use of legacy artifact service in Python.

2020-06-09 Thread GitBox
robertwb commented on pull request #11935: URL: https://github.com/apache/beam/pull/11935#issuecomment-640920980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] sabhyankar opened a new pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

2020-06-09 Thread GitBox
sabhyankar opened a new pull request #11950: URL: https://github.com/apache/beam/pull/11950 This PR adds a new PTransform (SplunkIO) that writes events to [Splunk's Http Event Collector](https://dev.splunk.com/enterprise/docs/dataapps/httpeventcollector/). R: @pabloem

[GitHub] [beam] chamikaramj commented on pull request #11911: [BEAM-10186] Send an error to the runner for certain split and progress failures

2020-06-09 Thread GitBox
chamikaramj commented on pull request #11911: URL: https://github.com/apache/beam/pull/11911#issuecomment-640721859 PTAL. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] chunyang commented on pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

2020-06-09 Thread GitBox
chunyang commented on pull request #11923: URL: https://github.com/apache/beam/pull/11923#issuecomment-641037942 I think there's an attempt to fix the failures in #11946? I will wait for that and rebase. This is an

[GitHub] [beam] TheNeuralBit commented on pull request #11904: Update Beam website to release 2.22.0

2020-06-09 Thread GitBox
TheNeuralBit commented on pull request #11904: URL: https://github.com/apache/beam/pull/11904#issuecomment-640839785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] apilloud commented on a change in pull request #11868: [BEAM-9363] Support HOP and SESSION as TVF

2020-06-09 Thread GitBox
apilloud commented on a change in pull request #11868: URL: https://github.com/apache/beam/pull/11868#discussion_r437068988 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -85,6 +97,85 @@

[GitHub] [beam] amaliujia merged pull request #11953: [BEAM-9191] Add Jira Link (BEAM-9191) to empty @Ignore message

2020-06-09 Thread GitBox
amaliujia merged pull request #11953: URL: https://github.com/apache/beam/pull/11953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] stale[bot] commented on pull request #9544: [BEAM-8191] Fixes potentially large number of tasks on Spark after Flatten.pCollections()

2020-06-09 Thread GitBox
stale[bot] commented on pull request #9544: URL: https://github.com/apache/beam/pull/9544#issuecomment-641261228 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] robertwb commented on a change in pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

2020-06-09 Thread GitBox
robertwb commented on a change in pull request #11932: URL: https://github.com/apache/beam/pull/11932#discussion_r437009347 ## File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/ArtifactRetrievalService.java ## @@ -89,34 +92,41 @@

[GitHub] [beam] amaliujia merged pull request #11948: [BEAM-10213] @Ignore: fix the test for testCastToDateWithCase.

2020-06-09 Thread GitBox
amaliujia merged pull request #11948: URL: https://github.com/apache/beam/pull/11948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] kamilwu commented on pull request #11946: Fix VideoIntelligence IT tests

2020-06-09 Thread GitBox
kamilwu commented on pull request #11946: URL: https://github.com/apache/beam/pull/11946#issuecomment-640558788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] ibzib commented on a change in pull request #11910: Add blog post announcing the 2.22.0 release

2020-06-09 Thread GitBox
ibzib commented on a change in pull request #11910: URL: https://github.com/apache/beam/pull/11910#discussion_r437002987 ## File path: website/www/site/content/en/blog/beam-2.22.0.md ## @@ -0,0 +1,53 @@ +--- +title: "Apache Beam 2.22.0" +date: 2020-06-08 00:00:01 -0800

[GitHub] [beam] robertwb merged pull request #11626: Cleanup ToString transforms.

2020-06-09 Thread GitBox
robertwb merged pull request #11626: URL: https://github.com/apache/beam/pull/11626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] amaliujia opened a new pull request #11953: [BEAM-9191] Add Jira Link (BEAM-9191) to empty @Ignore message

2020-06-09 Thread GitBox
amaliujia opened a new pull request #11953: URL: https://github.com/apache/beam/pull/11953 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] pabloem commented on pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

2020-06-09 Thread GitBox
pabloem commented on pull request #11950: URL: https://github.com/apache/beam/pull/11950#issuecomment-640877094 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kamilwu commented on pull request #11923: [BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

2020-06-09 Thread GitBox
kamilwu commented on pull request #11923: URL: https://github.com/apache/beam/pull/11923#issuecomment-641129841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] chamikaramj commented on pull request #11930: [BEAM-10202] make cross-language testing scripts OSX-compatible

2020-06-09 Thread GitBox
chamikaramj commented on pull request #11930: URL: https://github.com/apache/beam/pull/11930#issuecomment-640814941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] chamikaramj commented on pull request #11942: [BEAM-10208] add cross-language KafkaIO integration test

2020-06-09 Thread GitBox
chamikaramj commented on pull request #11942: URL: https://github.com/apache/beam/pull/11942#issuecomment-640814319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] iemejia edited a comment on pull request #11909: [BEAM-8134] Grafana dashboards for Nexmark tests

2020-06-09 Thread GitBox
iemejia edited a comment on pull request #11909: URL: https://github.com/apache/beam/pull/11909#issuecomment-641060650 Hello, thanks for the already done fixes. For retention policy I think it matters for historical reasons. There are presentations also where we highlight that data that

[GitHub] [beam] udim removed a comment on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
udim removed a comment on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-640785723 retest This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] reuvenlax commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-09 Thread GitBox
reuvenlax commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437509966 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -116,4 +131,267 @@ private ObjectMapper objectMapper() {

[GitHub] [beam] lukecwik commented on pull request #11821: [BEAM-10097, BEAM-5982, BEAM-3080] Use primitive views directly instead of transforming KV> to the view type via a naive ma

2020-06-09 Thread GitBox
lukecwik commented on pull request #11821: URL: https://github.com/apache/beam/pull/11821#issuecomment-640687823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] sclukas77 opened a new pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

2020-06-09 Thread GitBox
sclukas77 opened a new pull request #11951: URL: https://github.com/apache/beam/pull/11951 Made it possible to set BigQueryIO's writeDisposition in a Beam SQL big query table. R: @TheNeuralBit Post-Commit Tests Status (on master branch)

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

2020-06-09 Thread GitBox
TheNeuralBit commented on a change in pull request #11951: URL: https://github.com/apache/beam/pull/11951#discussion_r436984551 ## File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTableProviderTest.java ## @@

[GitHub] [beam] TobKed commented on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-09 Thread GitBox
TobKed commented on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-641137700 After rethinking gh-actions I made some updates which changes CI behavior dependent on the triggering event as presented below: * **on pull_request** - operates on PR

[GitHub] [beam] boyuanzz commented on pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-09 Thread GitBox
boyuanzz commented on pull request #11749: URL: https://github.com/apache/beam/pull/11749#issuecomment-641001191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] pawelpasterz commented on pull request #11946: Fix VideoIntelligence IT tests

2020-06-09 Thread GitBox
pawelpasterz commented on pull request #11946: URL: https://github.com/apache/beam/pull/11946#issuecomment-640703811 @kamilwu LGTM, thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit opened a new pull request #11947: Fix links for type hint changes in 2.21 blog post

2020-06-09 Thread GitBox
TheNeuralBit opened a new pull request #11947: URL: https://github.com/apache/beam/pull/11947 R: @ibzib @udim Post-Commit Tests Status (on master branch) Lang | SDK | Apex |

[GitHub] [beam] amaliujia commented on pull request #11868: [BEAM-9363] Support HOP and SESSION as TVF

2020-06-09 Thread GitBox
amaliujia commented on pull request #11868: URL: https://github.com/apache/beam/pull/11868#issuecomment-640953451 I have tried to add more tests from BeamSQL Calcite to bring TVF syntax to a similar level of testing with existing GROUP BY windows in BeamSQL Calcite.

[GitHub] [beam] willbattel commented on pull request #10187: [BEAM-8376] Initial version of firestore connector JavaSDK

2020-06-09 Thread GitBox
willbattel commented on pull request #10187: URL: https://github.com/apache/beam/pull/10187#issuecomment-640889945 Hey @fredzqm @clement are there any updates regarding the mentioned non-atomic batch writing capability?

[GitHub] [beam] udim commented on a change in pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
udim commented on a change in pull request #11939: URL: https://github.com/apache/beam/pull/11939#discussion_r436908464 ## File path: sdks/python/apache_beam/typehints/typehints_test.py ## @@ -612,54 +613,70 @@ def test_match_type_variables(self):

[GitHub] [beam] amaliujia commented on a change in pull request #11868: [BEAM-9363] Support HOP and SESSION as TVF

2020-06-09 Thread GitBox
amaliujia commented on a change in pull request #11868: URL: https://github.com/apache/beam/pull/11868#discussion_r437064277 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -95,29 +186,19 @@

[GitHub] [beam] iemejia edited a comment on pull request #11891: [BEAM-4766] Migrate to use vendored protobuf for bytestring

2020-06-09 Thread GitBox
iemejia edited a comment on pull request #11891: URL: https://github.com/apache/beam/pull/11891#issuecomment-640847297 Oh I missed that one. I suppose this is ok. Thanks for the info. Our deps have become huge I really wish we could find a way to make them smaller but it seems we only can

[GitHub] [beam] dpcollins-google commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

2020-06-09 Thread GitBox
dpcollins-google commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r437419585 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/DeduplicationFn.java ## @@ -0,0 +1,111 @@

[GitHub] [beam] kamilwu removed a comment on pull request #11946: Fix VideoIntelligence IT tests

2020-06-09 Thread GitBox
kamilwu removed a comment on pull request #11946: URL: https://github.com/apache/beam/pull/11946#issuecomment-640558788 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] saavan-google-intern edited a comment on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
saavan-google-intern edited a comment on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-640875992 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] stale[bot] closed pull request #11217: [BEAM-9416] BIP-1: Convert Avro metadata to Schema options

2020-06-09 Thread GitBox
stale[bot] closed pull request #11217: URL: https://github.com/apache/beam/pull/11217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] saavan-google-intern commented on a change in pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
saavan-google-intern commented on a change in pull request #11939: URL: https://github.com/apache/beam/pull/11939#discussion_r436920471 ## File path: sdks/python/apache_beam/typehints/typehints_test.py ## @@ -612,54 +613,70 @@ def test_match_type_variables(self):

[GitHub] [beam] robertwb commented on pull request #11949: Simplify Python on Flink runner instructions.

2020-06-09 Thread GitBox
robertwb commented on pull request #11949: URL: https://github.com/apache/beam/pull/11949#issuecomment-640891635 Reading it again, I simply separated out the Python vs. Portable instructions completely for readability. PTAL.

[GitHub] [beam] udim commented on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
udim commented on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-640785723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] chamikaramj commented on a change in pull request #11930: [BEAM-10202] make cross-language testing scripts OSX-compatible

2020-06-09 Thread GitBox
chamikaramj commented on a change in pull request #11930: URL: https://github.com/apache/beam/pull/11930#discussion_r437050130 ## File path: sdks/python/scripts/run_expansion_services.sh ## @@ -133,4 +136,7 @@ case $STARTSTOP in fi ;; esac -flock -u 200 + +if [[

[GitHub] [beam] jaketf commented on a change in pull request #11702: [BEAM-9990] Add Conditional Update and Conditional Create to FhirIO

2020-06-09 Thread GitBox
jaketf commented on a change in pull request #11702: URL: https://github.com/apache/beam/pull/11702#discussion_r436837505 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java ## @@ -155,17 +168,53 @@ *

[GitHub] [beam] TheNeuralBit merged pull request #11947: Fix links for type hint changes in 2.21 blog post

2020-06-09 Thread GitBox
TheNeuralBit merged pull request #11947: URL: https://github.com/apache/beam/pull/11947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] amaliujia opened a new pull request #11948: [BEAM-10213] @Ignore: fix the test for testCastToDateWithCase.

2020-06-09 Thread GitBox
amaliujia opened a new pull request #11948: URL: https://github.com/apache/beam/pull/11948 see: https://jira.apache.org/jira/browse/BEAM-10213 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] udim commented on a change in pull request #11947: Fix links for type hint changes in 2.21 blog post

2020-06-09 Thread GitBox
udim commented on a change in pull request #11947: URL: https://github.com/apache/beam/pull/11947#discussion_r436866222 ## File path: website/www/site/content/en/blog/beam-2.21.0.md ## @@ -44,10 +44,10 @@ for example usage. `process()`) with

[GitHub] [beam] TobKed edited a comment on pull request #11877: [BEAM-10184] Build python wheels on GitHub Actions for Linux/MacOS

2020-06-09 Thread GitBox
TobKed edited a comment on pull request #11877: URL: https://github.com/apache/beam/pull/11877#issuecomment-639667163 cc @potiuk, @brucearctor This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] reubenvanammers removed a comment on pull request #11955: [BEAM-10220] add support for implicit nulls

2020-06-09 Thread GitBox
reubenvanammers removed a comment on pull request #11955: URL: https://github.com/apache/beam/pull/11955#issuecomment-641056136 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] TheNeuralBit commented on pull request #11951: [BEAM-8828] Added BigQueryTableProvider WriteDisposition configuration

2020-06-09 Thread GitBox
TheNeuralBit commented on pull request #11951: URL: https://github.com/apache/beam/pull/11951#issuecomment-640874884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] pabloem commented on a change in pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

2020-06-09 Thread GitBox
pabloem commented on a change in pull request #11950: URL: https://github.com/apache/beam/pull/11950#discussion_r436992485 ## File path: sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEvent.java ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache

[GitHub] [beam] boyuanzz commented on a change in pull request #11941: [BEAM-2939] Fix splittable DoFn lifecycle.

2020-06-09 Thread GitBox
boyuanzz commented on a change in pull request #11941: URL: https://github.com/apache/beam/pull/11941#discussion_r436861894 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -193,7 +193,21 @@ bundleFinalizer);

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

2020-06-09 Thread GitBox
vmarquez commented on a change in pull request #10546: URL: https://github.com/apache/beam/pull/10546#discussion_r436855523 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -326,7 +371,78 @@ private CassandraIO() {}

[GitHub] [beam] lukecwik commented on pull request #11891: [BEAM-4766] Migrate to use vendored protobuf for bytestring

2020-06-09 Thread GitBox
lukecwik commented on pull request #11891: URL: https://github.com/apache/beam/pull/11891#issuecomment-640697082 beam-sdks-java-core depends on beam-model-pipeline which depends on beam-vendor-grpc-1_26_0 so what you initially thought was correct, was there an issue in how you dumped the

[GitHub] [beam] apilloud commented on a change in pull request #11834: [BEAM-10117] Correct erroneous Job Failed message

2020-06-09 Thread GitBox
apilloud commented on a change in pull request #11834: URL: https://github.com/apache/beam/pull/11834#discussion_r436896488 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java ## @@ -137,8 +137,8 @@ void

[GitHub] [beam] sabhyankar commented on pull request #11950: [BEAM-8596]: Add SplunkIO transform to write messages to Splunk

2020-06-09 Thread GitBox
sabhyankar commented on pull request #11950: URL: https://github.com/apache/beam/pull/11950#issuecomment-640865650 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] reubenvanammers opened a new pull request #11955: [BEAM-10220] add support for implicit nulls

2020-06-09 Thread GitBox
reubenvanammers opened a new pull request #11955: URL: https://github.com/apache/beam/pull/11955 Currently, RowJson.java doesn't have support for deserialising JSON with fields missing - it fails, even if the beam schema is nullable. This is often a problem for reading JSON as nulls are

[GitHub] [beam] amaliujia merged pull request #11952: [BEAM-10215] @Ignore: Concat now works with varargs

2020-06-09 Thread GitBox
amaliujia merged pull request #11952: URL: https://github.com/apache/beam/pull/11952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] rezarokni commented on a change in pull request #11929: [BEAM-10201] Add deadletter support to JsonToRow

2020-06-09 Thread GitBox
rezarokni commented on a change in pull request #11929: URL: https://github.com/apache/beam/pull/11929#discussion_r437411646 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java ## @@ -72,10 +79,44 @@ @Experimental(Kind.SCHEMAS) public

[GitHub] [beam] robertwb opened a new pull request #11949: Simplify Python on Flink runner instructions.

2020-06-09 Thread GitBox
robertwb opened a new pull request #11949: URL: https://github.com/apache/beam/pull/11949 Also fix formatting broken during website transition due to BEAM-10214. Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] amaliujia commented on pull request #11948: [BEAM-10213] @Ignore: fix the test for testCastToDateWithCase.

2020-06-09 Thread GitBox
amaliujia commented on pull request #11948: URL: https://github.com/apache/beam/pull/11948#issuecomment-640855940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] kamilwu merged pull request #11946: Fix VideoIntelligence IT tests

2020-06-09 Thread GitBox
kamilwu merged pull request #11946: URL: https://github.com/apache/beam/pull/11946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] iemejia merged pull request #11945: [BEAM-10211] Upgrade Spark to version 2.4.6

2020-06-09 Thread GitBox
iemejia merged pull request #11945: URL: https://github.com/apache/beam/pull/11945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] henryken commented on a change in pull request #11936: [BEAM-9679] Add CombinePerKey to Core Transforms Go Katas

2020-06-09 Thread GitBox
henryken commented on a change in pull request #11936: URL: https://github.com/apache/beam/pull/11936#discussion_r437487228 ## File path: learning/katas/go/Core Transforms/Combine/Combine PerKey/task.md ## @@ -0,0 +1,47 @@ + + +# Combine - Combine PerKey Review comment:

[GitHub] [beam] robertwb commented on pull request #11932: [BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

2020-06-09 Thread GitBox
robertwb commented on pull request #11932: URL: https://github.com/apache/beam/pull/11932#issuecomment-640894856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] saavan-google-intern commented on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
saavan-google-intern commented on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-640875992 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] kamilwu opened a new pull request #11946: Fix VideoIntelligence IT tests

2020-06-09 Thread GitBox
kamilwu opened a new pull request #11946: URL: https://github.com/apache/beam/pull/11946 VideoIntelligence IT tests use presence label annotations for comparing actual results to expected results, which is made available only when the client sets LabelDetectionConfig.model to

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-06-09 Thread GitBox
kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-640618844 @tysonjh I added some tests with 1000 windows. However, there's a problem with them: the side input is empty and no elements are accessed. I think it's because of wrong

[GitHub] [beam] iemejia commented on pull request #11891: [BEAM-4766] Migrate to use vendored protobuf for bytestring

2020-06-09 Thread GitBox
iemejia commented on pull request #11891: URL: https://github.com/apache/beam/pull/11891#issuecomment-640847297 Oh I missed that one. I suppose this is ok. Thanks for the info. Our deps have become huge I really wish we could find a way to make them smaller but it seems we only can get

[GitHub] [beam] ibzib commented on a change in pull request #11904: Update Beam website to release 2.22.0

2020-06-09 Thread GitBox
ibzib commented on a change in pull request #11904: URL: https://github.com/apache/beam/pull/11904#discussion_r436954412 ## File path: website/www/site/content/en/get-started/downloads.md ## @@ -87,10 +87,17 @@ versions denoted `0.x.y`. ## Releases +### 2.22.0

[GitHub] [beam] damondouglas commented on a change in pull request #11936: [BEAM-9679] Add CombinePerKey to Core Transforms Go Katas

2020-06-09 Thread GitBox
damondouglas commented on a change in pull request #11936: URL: https://github.com/apache/beam/pull/11936#discussion_r437054701 ## File path: learning/katas/go/Core Transforms/Combine/Combine PerKey/task.md ## @@ -0,0 +1,47 @@ + + +# Combine - Combine PerKey Review comment:

[GitHub] [beam] lukecwik commented on a change in pull request #11749: [BEAM-9977] Implement ReadFromKafkaViaSDF

2020-06-09 Thread GitBox
lukecwik commented on a change in pull request #11749: URL: https://github.com/apache/beam/pull/11749#discussion_r436875673 ## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java ## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache

[GitHub] [beam] TheNeuralBit merged pull request #11910: Add blog post announcing the 2.22.0 release

2020-06-09 Thread GitBox
TheNeuralBit merged pull request #11910: URL: https://github.com/apache/beam/pull/11910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] amaliujia commented on pull request #11953: [BEAM-9191] Add Jira Link (BEAM-9191) to empty @Ignore message

2020-06-09 Thread GitBox
amaliujia commented on pull request #11953: URL: https://github.com/apache/beam/pull/11953#issuecomment-640886850 R: @robinyqiu This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] kamilwu opened a new pull request #11956: [BEAM-8133] Publishing results of Nexmark tests to InfluxDB

2020-06-09 Thread GitBox
kamilwu opened a new pull request #11956: URL: https://github.com/apache/beam/pull/11956 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] pabloem commented on pull request #11824: [BEAM-10101] Add HttpIO / HttpFileSystem (Python)

2020-06-09 Thread GitBox
pabloem commented on pull request #11824: URL: https://github.com/apache/beam/pull/11824#issuecomment-640880406 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robertwb commented on pull request #11938: [BEAM-9577] Remove uses of legacy artifact service in Java.

2020-06-09 Thread GitBox
robertwb commented on pull request #11938: URL: https://github.com/apache/beam/pull/11938#issuecomment-640892661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] amaliujia opened a new pull request #11952: [BEAM-10215] @Ignore: Concat now works with varargs

2020-06-09 Thread GitBox
amaliujia opened a new pull request #11952: URL: https://github.com/apache/beam/pull/11952 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] lostluck commented on a change in pull request #11936: [BEAM-9679] Add CombinePerKey to Core Transforms Go Katas

2020-06-09 Thread GitBox
lostluck commented on a change in pull request #11936: URL: https://github.com/apache/beam/pull/11936#discussion_r437014738 ## File path: learning/katas/go/Core Transforms/Combine/Combine PerKey/task.md ## @@ -0,0 +1,47 @@ + + +# Combine - Combine PerKey Review comment:

[GitHub] [beam] chamikaramj commented on pull request #11928: [ BEAM-3788] Updates kafka.py pydocs

2020-06-09 Thread GitBox
chamikaramj commented on pull request #11928: URL: https://github.com/apache/beam/pull/11928#issuecomment-640721629 Tests pass now. PTAL. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] amaliujia commented on pull request #11952: [BEAM-10215] @Ignore: Concat now works with varargs

2020-06-09 Thread GitBox
amaliujia commented on pull request #11952: URL: https://github.com/apache/beam/pull/11952#issuecomment-640885354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] saavan-google-intern removed a comment on pull request #11939: [BEAM-10197] Support typehints for Python's frozenset

2020-06-09 Thread GitBox
saavan-google-intern removed a comment on pull request #11939: URL: https://github.com/apache/beam/pull/11939#issuecomment-640875992 > The `bare frozenset` test still fails Fixed by removing unneeded name comparison from TypeVariable equality checks

[GitHub] [beam] pabloem commented on pull request #11940: [BEAM-6215] Additional tests for FlatMap label.

2020-06-09 Thread GitBox
pabloem commented on pull request #11940: URL: https://github.com/apache/beam/pull/11940#issuecomment-640740820 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] stale[bot] commented on pull request #11217: [BEAM-9416] BIP-1: Convert Avro metadata to Schema options

2020-06-09 Thread GitBox
stale[bot] commented on pull request #11217: URL: https://github.com/apache/beam/pull/11217#issuecomment-641302000 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[GitHub] [beam] lukecwik commented on pull request #11941: [BEAM-2939] Fix splittable DoFn lifecycle.

2020-06-09 Thread GitBox
lukecwik commented on pull request #11941: URL: https://github.com/apache/beam/pull/11941#issuecomment-640687485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] mxm commented on a change in pull request #11928: [ BEAM-3788] Updates kafka.py pydocs

2020-06-09 Thread GitBox
mxm commented on a change in pull request #11928: URL: https://github.com/apache/beam/pull/11928#discussion_r437272373 ## File path: sdks/python/apache_beam/io/external/kafka.py ## @@ -68,11 +110,7 @@ class ReadFromKafka(ExternalTransform): each item in the specified

[GitHub] [beam] robertwb commented on pull request #11940: [BEAM-6215] Additional tests for FlatMap label.

2020-06-09 Thread GitBox
robertwb commented on pull request #11940: URL: https://github.com/apache/beam/pull/11940#issuecomment-640892361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] ibzib commented on a change in pull request #11949: Simplify Python on Flink runner instructions.

2020-06-09 Thread GitBox
ibzib commented on a change in pull request #11949: URL: https://github.com/apache/beam/pull/11949#discussion_r436981715 ## File path: website/www/site/content/en/documentation/runners/flink.md ## @@ -276,36 +276,48 @@ If you have a Flink `JobManager` running on your local

[GitHub] [beam] aromanenko-dev removed a comment on pull request #11396: [BEAM-9742] Add Configurable FluentBackoff to JdbcIO Write

2020-06-09 Thread GitBox
aromanenko-dev removed a comment on pull request #11396: URL: https://github.com/apache/beam/pull/11396#issuecomment-640562379 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb commented on a change in pull request #11949: Simplify Python on Flink runner instructions.

2020-06-09 Thread GitBox
robertwb commented on a change in pull request #11949: URL: https://github.com/apache/beam/pull/11949#discussion_r437006323 ## File path: website/www/site/content/en/documentation/runners/flink.md ## @@ -276,36 +276,48 @@ If you have a Flink `JobManager` running on your local

[GitHub] [beam] ihji commented on pull request #11942: [BEAM-10208] add cross-language KafkaIO integration test

2020-06-09 Thread GitBox
ihji commented on pull request #11942: URL: https://github.com/apache/beam/pull/11942#issuecomment-640938156 I don't think they are related to the change. Java Precommit failure is unrelated because this PR only has Python changes and I can confirm that newly added test passed in both py2

<    1   2