pabloem commented on pull request #12085:
URL: https://github.com/apache/beam/pull/12085#issuecomment-652206523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #12086:
URL: https://github.com/apache/beam/pull/12086#issuecomment-652206508
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem merged pull request #12123:
URL: https://github.com/apache/beam/pull/12123
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on a change in pull request #12123:
URL: https://github.com/apache/beam/pull/12123#discussion_r448128821
##
File path: sdks/python/apache_beam/metrics/metric_test.py
##
@@ -159,15 +163,26 @@ def process(self, element):
res = pipeline.run()
pabloem merged pull request #12103:
URL: https://github.com/apache/beam/pull/12103
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-652204041
thanks @lastomato !
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on a change in pull request #12084:
URL: https://github.com/apache/beam/pull/12084#discussion_r448126874
##
File path: sdks/python/apache_beam/io/gcp/gce_metadata_util.py
##
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
pabloem commented on a change in pull request #12084:
URL: https://github.com/apache/beam/pull/12084#discussion_r448121982
##
File path: sdks/python/apache_beam/io/gcp/bigquery_io_metadata.py
##
@@ -0,0 +1,55 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
milantracy commented on pull request #10487:
URL: https://github.com/apache/beam/pull/10487#issuecomment-652203139
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
milantracy edited a comment on pull request #10487:
URL: https://github.com/apache/beam/pull/10487#issuecomment-652202776
seems that PreCommit failure is not related to the PR
https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/12039/console
milantracy commented on pull request #10487:
URL: https://github.com/apache/beam/pull/10487#issuecomment-652202776
seems that PreCommit is not related to the PR
https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/12039/console
pabloem merged pull request #12087:
URL: https://github.com/apache/beam/pull/12087
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12087:
URL: https://github.com/apache/beam/pull/12087#issuecomment-652197338
thanks @ihji
This is an automated message from the Apache Git Service.
To respond to the message, please log on
piotr-szuberski commented on a change in pull request #12022:
URL: https://github.com/apache/beam/pull/12022#discussion_r448116884
##
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/external/JdbcExternalWrite.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed
pabloem commented on pull request #12119:
URL: https://github.com/apache/beam/pull/12119#issuecomment-652189108
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12087:
URL: https://github.com/apache/beam/pull/12087#issuecomment-652187973
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
youngoli commented on a change in pull request #12141:
URL: https://github.com/apache/beam/pull/12141#discussion_r448071459
##
File path: sdks/go/pkg/beam/core/graph/coder/row.go
##
@@ -0,0 +1,379 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-652183739
looks like it's transient. (As of recently, you should be able to run the
test by yourself with the code phrase)
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-652183488
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11765:
URL: https://github.com/apache/beam/pull/11765#issuecomment-652180770
just to confirm: have you verified that this imports (and tests) well into
google repository?
@rohdesamuel
lukecwik commented on pull request #12137:
URL: https://github.com/apache/beam/pull/12137#issuecomment-652178160
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r448104124
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -488,90 +492,32 @@
||
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r448096760
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##
@@ -91,7 +91,8 @@ def __init__(
bundle_repeat=0,
piotr-szuberski commented on a change in pull request #12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r448100807
##
File path: sdks/python/apache_beam/io/external/jdbc.py
##
@@ -0,0 +1,116 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
piotr-szuberski commented on a change in pull request #12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r448100807
##
File path: sdks/python/apache_beam/io/external/jdbc.py
##
@@ -0,0 +1,116 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
piotr-szuberski commented on a change in pull request #12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r448099062
##
File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
##
@@ -0,0 +1,138 @@
+#
+# Licensed to the Apache Software Foundation
piotr-szuberski commented on a change in pull request #12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r448098803
##
File path: sdks/python/apache_beam/io/external/jdbc.py
##
@@ -0,0 +1,134 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
piotr-szuberski commented on a change in pull request #12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r448098803
##
File path: sdks/python/apache_beam/io/external/jdbc.py
##
@@ -0,0 +1,134 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r448079892
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java
##
@@ -306,6 +308,18 @@ public static
lukecwik commented on pull request #12137:
URL: https://github.com/apache/beam/pull/12137#issuecomment-652147585
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
udim commented on pull request #12129:
URL: https://github.com/apache/beam/pull/12129#issuecomment-652140583
Also, please add a JIRA :)
This is an automated message from the Apache Git Service.
To respond to the message,
steveniemitz opened a new pull request #12144:
URL: https://github.com/apache/beam/pull/12144
If a job is configured to upload multiple files to the same destination,
they'll end up attempting to overwrite each other in parallel, causing the
runner to need to retry multiple times until
milantracy commented on pull request #10487:
URL: https://github.com/apache/beam/pull/10487#issuecomment-652128780
@TheNeuralBit @amaliujia @aaltay sorry for updating the PR after such a
long time , feel free to leave your comments.
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r448060178
##
File path: sdks/python/apache_beam/transforms/core.py
##
@@ -320,6 +320,22 @@ def split_and_size(self, element, restriction):
for part in
davidyan74 commented on a change in pull request #12047:
URL: https://github.com/apache/beam/pull/12047#discussion_r448058760
##
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##
@@ -570,6 +576,23 @@ def _log_lull_in_bundle_processor(self, processor):
lastomato commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-652124759
Thanks, Pablo. Is this something I should look into, or is it transient?
This is an automated message from the
aaltay commented on pull request #12142:
URL: https://github.com/apache/beam/pull/12142#issuecomment-652120930
R: @chamikaramj - any concerns about this bundle size change?
This is an automated message from the Apache Git
davidyan74 opened a new pull request #12143:
URL: https://github.com/apache/beam/pull/12143
Adding full thread dump upon lull detection for Dataflow Java worker.
Thank you for your contribution! Follow this checklist to help us
incorporate your
corvin-quodai commented on pull request #12142:
URL: https://github.com/apache/beam/pull/12142#issuecomment-652120114
R: @aaltay
R: @y1chi
I am not sure how rounding up the source bundle size would affect other
parts of beam. Would appreciate your input. Happy to change this PR
corvin-quodai opened a new pull request #12142:
URL: https://github.com/apache/beam/pull/12142
Depending on runner and the mongo collection to read, the bundle size can
fall below 1mb which resulted in Source Bundles with weight=0. This lead to a
zero division error (raised from
aaltay commented on a change in pull request #12047:
URL: https://github.com/apache/beam/pull/12047#discussion_r448052626
##
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##
@@ -570,6 +576,23 @@ def _log_lull_in_bundle_processor(self, processor):
milantracy commented on a change in pull request #10487:
URL: https://github.com/apache/beam/pull/10487#discussion_r448052689
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/AvroPubsubMessageToRow.java
##
@@ -0,0
milantracy commented on a change in pull request #10487:
URL: https://github.com/apache/beam/pull/10487#discussion_r448052137
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java
##
@@ -339,6 +350,35 @@ public static Schema
tweise merged pull request #12140:
URL: https://github.com/apache/beam/pull/12140
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tweise commented on a change in pull request #12140:
URL: https://github.com/apache/beam/pull/12140#discussion_r448034061
##
File path: website/www/site/content/en/documentation/sdks/python-streaming.md
##
@@ -168,9 +168,7 @@ Python streaming execution does not currently
youngoli merged pull request #12124:
URL: https://github.com/apache/beam/pull/12124
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tweise commented on a change in pull request #12140:
URL: https://github.com/apache/beam/pull/12140#discussion_r448033172
##
File path: website/www/site/content/en/documentation/sdks/python-streaming.md
##
@@ -168,9 +168,7 @@ Python streaming execution does not currently
Ardagan commented on pull request #12139:
URL: https://github.com/apache/beam/pull/12139#issuecomment-652098133
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
Ardagan commented on pull request #12139:
URL: https://github.com/apache/beam/pull/12139#issuecomment-652098053
Run Python 2 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
youngoli commented on a change in pull request #12127:
URL: https://github.com/apache/beam/pull/12127#discussion_r448028531
##
File path: sdks/go/pkg/beam/core/graph/coder/bytes_test.go
##
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
youngoli commented on a change in pull request #12124:
URL: https://github.com/apache/beam/pull/12124#discussion_r448027552
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##
@@ -302,12 +302,23 @@ func (n *DataSource) Split(splits []int64, frac float64,
bufSize
youngoli commented on pull request #12124:
URL: https://github.com/apache/beam/pull/12124#issuecomment-652092483
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-652090261
@lukecwik do you happen to have time to review this? Looks like cham is OOO
I'd like to get this in before the release cut tomorrow since it fixes a
significant issue
y1chi commented on a change in pull request #12140:
URL: https://github.com/apache/beam/pull/12140#discussion_r448021758
##
File path: website/www/site/content/en/documentation/sdks/python-streaming.md
##
@@ -168,9 +168,7 @@ Python streaming execution does not currently
TheNeuralBit merged pull request #12035:
URL: https://github.com/apache/beam/pull/12035
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-652085431
I'll merge once this passes
This is an automated message from the Apache Git Service.
To respond to the message,
udim commented on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-652079902
@saavan-google-intern I haven't taken a close look, but the failing tests
could be due changes in this PR. PTAL
n3lsok commented on a change in pull request #11405:
URL: https://github.com/apache/beam/pull/11405#discussion_r448014725
##
File path:
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##
@@ -123,8 +123,24 @@ public static Read read() {
* Like
aaltay commented on pull request #12126:
URL: https://github.com/apache/beam/pull/12126#issuecomment-652078379
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on a change in pull request #12140:
URL: https://github.com/apache/beam/pull/12140#discussion_r448012845
##
File path: website/www/site/content/en/documentation/sdks/python-streaming.md
##
@@ -168,9 +168,7 @@ Python streaming execution does not currently
lostluck commented on pull request #12141:
URL: https://github.com/apache/beam/pull/12141#issuecomment-652076911
R: @youngoli @tysonjh
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck opened a new pull request #12141:
URL: https://github.com/apache/beam/pull/12141
Adds row encoder and decoder function generators, using reflection. Doesn't
provide single element convenience functions for encoding and decoding struct
values.
Doesn't support looking up
rohdesamuel commented on pull request #11765:
URL: https://github.com/apache/beam/pull/11765#issuecomment-652071096
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
rohdesamuel commented on pull request #11765:
URL: https://github.com/apache/beam/pull/11765#issuecomment-652070641
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
apilloud commented on pull request #12138:
URL: https://github.com/apache/beam/pull/12138#issuecomment-652069731
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #12135:
URL: https://github.com/apache/beam/pull/12135#issuecomment-652068919
It doesn't seem to be related though, but that Java Precommit didn't finish
and it had a failed test.
This is
TheNeuralBit commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-652067737
The only failure in Python precommit seems to be due to BEAM-10007. I think
this is safe to merge after an LGTM
TheNeuralBit commented on pull request #12035:
URL: https://github.com/apache/beam/pull/12035#issuecomment-652067854
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit edited a comment on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-652067737
The only failure in Python precommit seems to be a flake due to BEAM-10007.
I think this is safe to merge after an LGTM
TheNeuralBit commented on pull request #12136:
URL: https://github.com/apache/beam/pull/12136#issuecomment-652067240
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #12084:
URL: https://github.com/apache/beam/pull/12084#issuecomment-652066216
Run Python 3.5 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
tweise opened a new pull request #12140:
URL: https://github.com/apache/beam/pull/12140
This was pointed out by a user.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ]
pabloem commented on pull request #12035:
URL: https://github.com/apache/beam/pull/12035#issuecomment-652065015
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #12125:
URL: https://github.com/apache/beam/pull/12125#issuecomment-652064977
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12125:
URL: https://github.com/apache/beam/pull/12125#issuecomment-652064746
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aaltay merged pull request #12130:
URL: https://github.com/apache/beam/pull/12130
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Ardagan opened a new pull request #12139:
URL: https://github.com/apache/beam/pull/12139
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
ibzib commented on pull request #12138:
URL: https://github.com/apache/beam/pull/12138#issuecomment-652048626
Looks like the new release hasn't been uploaded to maven central yet.
This is an automated message from the Apache
iemejia merged pull request #12064:
URL: https://github.com/apache/beam/pull/12064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
iemejia commented on pull request #12064:
URL: https://github.com/apache/beam/pull/12064#issuecomment-652048238
Thanks @JozoVilcek we should probably add some doc explaining that decision
in the future, but not worth to block the PR for this.
ibzib opened a new pull request #12138:
URL: https://github.com/apache/beam/pull/12138
R: @apilloud
cc: @robinyqiu @amaliujia
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
aaltay commented on pull request #12130:
URL: https://github.com/apache/beam/pull/12130#issuecomment-652041807
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #12035:
URL: https://github.com/apache/beam/pull/12035#issuecomment-652029350
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik commented on pull request #12137:
URL: https://github.com/apache/beam/pull/12137#issuecomment-652021896
R: @jbonofre @ajamato
CC: @iemejia @mxm
This is an automated message from the Apache Git Service.
To
davidyan74 commented on pull request #12047:
URL: https://github.com/apache/beam/pull/12047#issuecomment-652022287
@tvalentyn Added a unit test. PTAL. Thank you!
This is an automated message from the Apache Git Service.
To
lukecwik opened a new pull request #12137:
URL: https://github.com/apache/beam/pull/12137
* Ensure that the Consumer uses a thread safe object to pass the messages
through (Consumer is invoked on a separate thread as per
rohdesamuel commented on pull request #11765:
URL: https://github.com/apache/beam/pull/11765#issuecomment-652015699
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-652002592
Run XVR_Spark PostCommit
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-652002495
Run XVR_Flink PostCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12119:
URL: https://github.com/apache/beam/pull/12119#issuecomment-652000592
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-65251
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #12125:
URL: https://github.com/apache/beam/pull/12125#issuecomment-651999756
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-65147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aaltay commented on pull request #12130:
URL: https://github.com/apache/beam/pull/12130#issuecomment-651999466
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12123:
URL: https://github.com/apache/beam/pull/12123#issuecomment-651999437
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aaltay commented on a change in pull request #12130:
URL: https://github.com/apache/beam/pull/12130#discussion_r447930638
##
File path: sdks/java/container/license_scripts/pull_licenses_java.py
##
@@ -39,7 +39,7 @@
from urllib.request import urlopen, URLError, HTTPError
pabloem commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-651993513
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-651993429
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-651993623
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-651988106
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
1 - 100 of 123 matches
Mail list logo