robertwb merged pull request #12361:
URL: https://github.com/apache/beam/pull/12361
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
leiyiz commented on pull request #12365:
URL: https://github.com/apache/beam/pull/12365#issuecomment-663351585
`R: @pabloem `
`R: @y1chi `
This is an automated message from the Apache Git Service.
To respond to the
leiyiz opened a new pull request #12365:
URL: https://github.com/apache/beam/pull/12365
changed parser and serialization code to use the same json format to
represent models, added auction_price model and corrected the behavior of query
0 - 2 to align with the nexmark specification.
youngoli commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r459851264
##
File path: sdks/go/pkg/beam/core/runtime/exec/sdf.go
##
@@ -325,6 +337,63 @@ func (n *ProcessSizedElementsAndRestrictions) String()
string {
youngoli commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r459850801
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##
@@ -302,31 +302,67 @@ func (n *DataSource) Split(splits []int64, frac float64,
bufSize
youngoli commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r459848001
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##
@@ -302,31 +302,67 @@ func (n *DataSource) Split(splits []int64, frac float64,
bufSize
youngoli commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r459841473
##
File path: sdks/go/pkg/beam/core/runtime/exec/translate.go
##
@@ -418,7 +418,8 @@ func (b *builder) makeLink(from string, id linkID) (Node,
error) {
chamikaramj commented on pull request #12355:
URL: https://github.com/apache/beam/pull/12355#issuecomment-663332591
LGTM other than the note about Docker.
This is an automated message from the Apache Git Service.
To respond
Hannah-Jiang commented on pull request #12364:
URL: https://github.com/apache/beam/pull/12364#issuecomment-663325401
> R: @Hannah-Jiang
>
> Hannah, do you know if running the PythonDocker PreCommit will test this,
or if any extra steps have to be taken to make sure Jenkins uses the
kennknowles commented on pull request #12354:
URL: https://github.com/apache/beam/pull/12354#issuecomment-663316534
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on pull request #12349:
URL: https://github.com/apache/beam/pull/12349#issuecomment-663316609
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem merged pull request #12335:
URL: https://github.com/apache/beam/pull/12335
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tvalentyn commented on pull request #12239:
URL: https://github.com/apache/beam/pull/12239#issuecomment-663310669
thanks a lot for this work, @lazylynx. Sorry for taking too long to respond,
will try to take a look tomorrow.
tvalentyn edited a comment on pull request #12239:
URL: https://github.com/apache/beam/pull/12239#issuecomment-663310669
thanks a lot for this work, @lazylynx. Sorry for taking too long to respond,
will try to take a closer look tomorrow.
kennknowles commented on pull request #12359:
URL: https://github.com/apache/beam/pull/12359#issuecomment-663306620
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
youngoli merged pull request #12364:
URL: https://github.com/apache/beam/pull/12364
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
youngoli commented on pull request #12364:
URL: https://github.com/apache/beam/pull/12364#issuecomment-663306219
PythonDocker Precommit has these lines:
```
17:15:48 Fetching from https://github.com/etcd-io/etcd.git
17:15:48 Resolving github.com/etcd-io/etcd:
tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r459084533
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -154,41 +155,60 @@ if [[ $confirmation = "y" ]]; then
rm -rf
ettirapp commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663301394
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ettirapp commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663300035
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
KevinGG commented on pull request #12339:
URL: https://github.com/apache/beam/pull/12339#issuecomment-663297219
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459796883
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -15,12 +15,16 @@
# limitations under the License.
#
-"""A
robertwb merged pull request #11963:
URL: https://github.com/apache/beam/pull/11963
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
youngoli commented on pull request #12364:
URL: https://github.com/apache/beam/pull/12364#issuecomment-663293791
CC: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please log
robertwb commented on pull request #11963:
URL: https://github.com/apache/beam/pull/11963#issuecomment-663293495
:sdks:python:test-suites:dataflow:py2:preCommitIT_streaming is unrelated.
This is an automated message from the
chamikaramj commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459795347
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -15,12 +15,17 @@
# limitations under the License.
#
-"""A
youngoli commented on pull request #12364:
URL: https://github.com/apache/beam/pull/12364#issuecomment-663292844
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
youngoli removed a comment on pull request #12364:
URL: https://github.com/apache/beam/pull/12364#issuecomment-663291683
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the
chamikaramj commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459795347
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -15,12 +15,17 @@
# limitations under the License.
#
-"""A
youngoli commented on pull request #12364:
URL: https://github.com/apache/beam/pull/12364#issuecomment-663292504
R: @Hannah-Jiang
Hannah, do you know if running the PythonDocker PreCommit will test this, or
if any extra steps have to be taken to make sure Jenkins uses the updated
robertwb commented on pull request #12361:
URL: https://github.com/apache/beam/pull/12361#issuecomment-663292613
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
robertwb commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459795151
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -15,12 +15,16 @@
# limitations under the License.
#
-"""A cross-language
TheNeuralBit commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459795116
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -15,12 +15,16 @@
# limitations under the License.
#
-"""A
youngoli commented on pull request #12364:
URL: https://github.com/apache/beam/pull/12364#issuecomment-663291683
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
youngoli opened a new pull request #12364:
URL: https://github.com/apache/beam/pull/12364
Looks like etcd's github repo changed from https://github.com/coreos/etcd to
https://github.com/etcd-io/etcd. That may be the source of the
:sdks:go:resolveBuildDependencies in the PythonDocker
ettirapp commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663287660
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459788328
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -31,51 +35,35 @@
from apache_beam.io import WriteToText
from
chamikaramj commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459787582
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -15,12 +15,16 @@
# limitations under the License.
#
-"""A
ettirapp commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663284529
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ettirapp commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663284231
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459785878
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -101,12 +89,33 @@ def main():
# workflow rely on global context (e.g.,
ettirapp commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663283902
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663283554
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay merged pull request #12077:
URL: https://github.com/apache/beam/pull/12077
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay merged pull request #12328:
URL: https://github.com/apache/beam/pull/12328
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay merged pull request #12356:
URL: https://github.com/apache/beam/pull/12356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663280275
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-663279975
Run JavaPortabilityApi PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663278351
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj opened a new pull request #12363:
URL: https://github.com/apache/beam/pull/12363
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
saavannanavati commented on pull request #12352:
URL: https://github.com/apache/beam/pull/12352#issuecomment-663274833
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459775292
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -31,51 +35,35 @@
from apache_beam.io import WriteToText
from
robertwb merged pull request #12347:
URL: https://github.com/apache/beam/pull/12347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-663269119
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on a change in pull request #12355:
URL: https://github.com/apache/beam/pull/12355#discussion_r459765700
##
File path: sdks/python/apache_beam/examples/wordcount_xlang_sql.py
##
@@ -15,12 +15,16 @@
# limitations under the License.
#
-"""A cross-language
sddhrthrt commented on pull request #12347:
URL: https://github.com/apache/beam/pull/12347#issuecomment-663267094
Ready for merge
This is an automated message from the Apache Git Service.
To respond to the message,
danielxjd commented on pull request #12106:
URL: https://github.com/apache/beam/pull/12106#issuecomment-663266467
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663263325
Tried just running precommit locally and publishing a scan. See a timeout
(flake?) in Euphoria tests:
pabloem commented on a change in pull request #12082:
URL: https://github.com/apache/beam/pull/12082#discussion_r459756841
##
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##
@@ -1465,3 +1465,23 @@ def get_avro_schema_from_table_schema(schema):
tvalentyn edited a comment on pull request #12228:
URL: https://github.com/apache/beam/pull/12228#issuecomment-663256339
Good catch, @charlesccychen . Thanks!
This is an automated message from the Apache Git Service.
To
tvalentyn commented on pull request #12228:
URL: https://github.com/apache/beam/pull/12228#issuecomment-663256339
Good catch, @charlesccychen
This is an automated message from the Apache Git Service.
To respond to the
tvalentyn closed pull request #12228:
URL: https://github.com/apache/beam/pull/12228
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robertwb commented on pull request #11963:
URL: https://github.com/apache/beam/pull/11963#issuecomment-663254641
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb commented on pull request #11963:
URL: https://github.com/apache/beam/pull/11963#issuecomment-663252987
Thanks. Filed a bug and added a TODO about a Python SDK logical type. I'll
look at the inference separately.
udim merged pull request #12300:
URL: https://github.com/apache/beam/pull/12300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663250011
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
udim commented on pull request #12300:
URL: https://github.com/apache/beam/pull/12300#issuecomment-663249697
Opened bug for PythonDocker failure:
https://issues.apache.org/jira/browse/BEAM-10567
This is an automated message
udim commented on pull request #12326:
URL: https://github.com/apache/beam/pull/12326#issuecomment-663248519
> With that change, all workspaces will be always cleared, just after the
build. Isn't that a problem in case of some possible investigations in the
future?
>
> We may
robertwb commented on pull request #12362:
URL: https://github.com/apache/beam/pull/12362#issuecomment-663246772
R: @henryken
This is an automated message from the Apache Git Service.
To respond to the message, please log on
aaltay edited a comment on pull request #12198:
URL: https://github.com/apache/beam/pull/12198#issuecomment-663161698
Thank you @busunkim96. We do not get notifications for all PRs. For python
PRs feel free to ping me or @tvalentyn in a comment for reviews. (We usually do
this with R:
robertwb opened a new pull request #12362:
URL: https://github.com/apache/beam/pull/12362
This is the preferred style for writing Beam pipelines.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
udim merged pull request #12358:
URL: https://github.com/apache/beam/pull/12358
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pabloem commented on pull request #12335:
URL: https://github.com/apache/beam/pull/12335#issuecomment-663243103
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
charlesccychen commented on pull request #12228:
URL: https://github.com/apache/beam/pull/12228#issuecomment-663242953
We should drop this PR because it is against the 2.22 release branch. The
corresponding PR for master was already merged:
https://github.com/apache/beam/pull/12104.
robertwb commented on pull request #12360:
URL: https://github.com/apache/beam/pull/12360#issuecomment-663242468
R: @mszb
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lostluck commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r459721826
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##
@@ -302,31 +302,67 @@ func (n *DataSource) Split(splits []int64, frac float64,
bufSize
TheNeuralBit merged pull request #12344:
URL: https://github.com/apache/beam/pull/12344
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
robertwb opened a new pull request #12361:
URL: https://github.com/apache/beam/pull/12361
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
kennknowles commented on pull request #12338:
URL: https://github.com/apache/beam/pull/12338#issuecomment-663239945
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on pull request #12349:
URL: https://github.com/apache/beam/pull/12349#issuecomment-663239693
Run JavaPortabilityApi PreCommit
This is an automated message from the Apache Git Service.
To respond to the
kennknowles commented on pull request #12349:
URL: https://github.com/apache/beam/pull/12349#issuecomment-663239582
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on pull request #12354:
URL: https://github.com/apache/beam/pull/12354#issuecomment-663239250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kennknowles commented on a change in pull request #11924:
URL: https://github.com/apache/beam/pull/11924#discussion_r459729767
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
##
robertwb opened a new pull request #12360:
URL: https://github.com/apache/beam/pull/12360
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
damgad commented on pull request #12326:
URL: https://github.com/apache/beam/pull/12326#issuecomment-663238151
With that change, all workspaces will be always cleared, just after the
build. Isn't that a problem in case of some possible investigations in the
future?
We may implement
ananvay commented on pull request #12228:
URL: https://github.com/apache/beam/pull/12228#issuecomment-663235430
I think we've done something similar for the Go SDK Harness already, so we
should be set. @lostluck to confirm.
I'm surprised we missed the python side of things.
tvalentyn commented on pull request #12228:
URL: https://github.com/apache/beam/pull/12228#issuecomment-663234092
@ananvay @lukecwik do you know if we need to adjust maximum message size on
the harness as well?
This is an
tvalentyn commented on pull request #12198:
URL: https://github.com/apache/beam/pull/12198#issuecomment-663232598
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tvalentyn commented on pull request #12198:
URL: https://github.com/apache/beam/pull/12198#issuecomment-663232471
Run Python 3.5 Postcommit
This is an automated message from the Apache Git Service.
To respond to the message,
tvalentyn commented on pull request #12198:
URL: https://github.com/apache/beam/pull/12198#issuecomment-663232055
R: @chamikaramj
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on pull request #12198:
URL: https://github.com/apache/beam/pull/12198#issuecomment-663232379
Run Python 2 Postcommit
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on a change in pull request #12155:
URL: https://github.com/apache/beam/pull/12155#discussion_r459724232
##
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/QuiescenceDriver.java
##
@@ -70,6 +71,8 @@ public static
kennknowles merged pull request #12155:
URL: https://github.com/apache/beam/pull/12155
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pabloem commented on a change in pull request #12082:
URL: https://github.com/apache/beam/pull/12082#discussion_r459717944
##
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##
@@ -1465,3 +1465,23 @@ def get_avro_schema_from_table_schema(schema):
pabloem commented on a change in pull request #12082:
URL: https://github.com/apache/beam/pull/12082#discussion_r459713758
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryResourceNaming.java
##
@@ -0,0 +1,107 @@
+/*
+
chamikaramj commented on a change in pull request #12203:
URL: https://github.com/apache/beam/pull/12203#discussion_r459703269
##
File path: CHANGES.md
##
@@ -55,6 +55,9 @@
* New overloads for BigtableIO.Read.withKeyRange() and
BigtableIO.Read.withRowFilter()
methods
aaltay commented on pull request #12356:
URL: https://github.com/apache/beam/pull/12356#issuecomment-663214713
LGTM. I can merge once @rosetn reviews.
This is an automated message from the Apache Git Service.
To respond to
aaltay commented on pull request #12328:
URL: https://github.com/apache/beam/pull/12328#issuecomment-663212932
Is this ready to be merged now? Seems like the snippet issue is fixed.
This is an automated message from the
pabloem commented on a change in pull request #12082:
URL: https://github.com/apache/beam/pull/12082#discussion_r459700149
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryResourceNaming.java
##
@@ -0,0 +1,107 @@
+/*
+
udim commented on a change in pull request #12358:
URL: https://github.com/apache/beam/pull/12358#discussion_r459699455
##
File path: .github/PULL_REQUEST_TEMPLATE.md
##
@@ -26,7 +26,7 @@ Pre-Commit Tests Status (on master branch)
--- |Java | Python | Go | Website
--- |
1 - 100 of 188 matches
Mail list logo
