[GitHub] [beam] jayendra13 commented on a change in pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:exten…

2020-08-15 Thread GitBox
jayendra13 commented on a change in pull request #12596: URL: https://github.com/apache/beam/pull/12596#discussion_r471062914 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java ## @@ -128,7 +129,8 @@

[GitHub] [beam] jayendra13 commented on a change in pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:exten…

2020-08-15 Thread GitBox
jayendra13 commented on a change in pull request #12596: URL: https://github.com/apache/beam/pull/12596#discussion_r471062809 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/test/TestBoundedTable.java ## @@ -91,7 +92,7 @@ p

[GitHub] [beam] jayendra13 commented on a change in pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:exten…

2020-08-15 Thread GitBox
jayendra13 commented on a change in pull request #12596: URL: https://github.com/apache/beam/pull/12596#discussion_r471062820 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java ## @@ -735,7 +735,7 @@ public Builder addValues(List values) { ret

[GitHub] [beam] jayendra13 opened a new pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:exten…

2020-08-15 Thread GitBox
jayendra13 opened a new pull request #12596: URL: https://github.com/apache/beam/pull/12596 …sions:sql:zetasql Fixing nullability errors for :sdks:java:extensions:sql:zetasql, Work is still in progress. Thank you for your contribution! Follow th

[GitHub] [beam] pabloem merged pull request #12575: [BEAM-10707] Adding Python docs precommit as separate suite.

2020-08-15 Thread GitBox
pabloem merged pull request #12575: URL: https://github.com/apache/beam/pull/12575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] jhnmora000 commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-08-15 Thread GitBox
jhnmora000 commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-674475549 R: @amaliujia @Mark-Zeng This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] jhnmora000 opened a new pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-08-15 Thread GitBox
jhnmora000 opened a new pull request #12595: URL: https://github.com/apache/beam/pull/12595 Add support for Analytic Functions in ZetaSQL: - Implement AnalyticScan to BeamWindowRel. - Add tests for ZetaSQL. Thank you for your contribution!

[GitHub] [beam] lukecwik commented on pull request #12594: [BEAM-10670] Make Twister2Runner opt-out for using an SDF powered Read transform.

2020-08-15 Thread GitBox
lukecwik commented on pull request #12594: URL: https://github.com/apache/beam/pull/12594#issuecomment-674473865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] lukecwik opened a new pull request #12594: [BEAM-10670] Make Twister2Runner opt-out for using an SDF powered Read transform.

2020-08-15 Thread GitBox
lukecwik opened a new pull request #12594: URL: https://github.com/apache/beam/pull/12594 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] ettirapp removed a comment on pull request #12581: [BEAM-10378] Add Azure Blob Storage Filesystem

2020-08-15 Thread GitBox
ettirapp removed a comment on pull request #12581: URL: https://github.com/apache/beam/pull/12581#issuecomment-674471625 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [beam] ettirapp commented on pull request #12581: [BEAM-10378] Add Azure Blob Storage Filesystem

2020-08-15 Thread GitBox
ettirapp commented on pull request #12581: URL: https://github.com/apache/beam/pull/12581#issuecomment-674471650 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] ettirapp commented on pull request #12581: [BEAM-10378] Add Azure Blob Storage Filesystem

2020-08-15 Thread GitBox
ettirapp commented on pull request #12581: URL: https://github.com/apache/beam/pull/12581#issuecomment-674471666 Run PythonDocs PreCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] ettirapp commented on pull request #12581: [BEAM-10378] Add Azure Blob Storage Filesystem

2020-08-15 Thread GitBox
ettirapp commented on pull request #12581: URL: https://github.com/apache/beam/pull/12581#issuecomment-674471637 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ettirapp commented on pull request #12581: [BEAM-10378] Add Azure Blob Storage Filesystem

2020-08-15 Thread GitBox
ettirapp commented on pull request #12581: URL: https://github.com/apache/beam/pull/12581#issuecomment-674471625 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] ettirapp commented on pull request #12581: [BEAM-10378] Add Azure Blob Storage Filesystem

2020-08-15 Thread GitBox
ettirapp commented on pull request #12581: URL: https://github.com/apache/beam/pull/12581#issuecomment-674471645 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] tweise commented on pull request #12531: [BEAM-10676] Use the fire timestamp as the output timestamp for timers

2020-08-15 Thread GitBox
tweise commented on pull request #12531: URL: https://github.com/apache/beam/pull/12531#issuecomment-674471619 @boyuanzz thanks for the review. For future PRs, please ensure that fixup commits are squashed. I noticed this while cherry-picking the changes, which would have been simpler if t

[GitHub] [beam] boyuanzz merged pull request #12574: Remove redundant setMaxNumRecords.

2020-08-15 Thread GitBox
boyuanzz merged pull request #12574: URL: https://github.com/apache/beam/pull/12574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] boyuanzz commented on pull request #12574: Remove redundant setMaxNumRecords.

2020-08-15 Thread GitBox
boyuanzz commented on pull request #12574: URL: https://github.com/apache/beam/pull/12574#issuecomment-674460383 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] lukecwik merged pull request #12519: [BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

2020-08-15 Thread GitBox
lukecwik merged pull request #12519: URL: https://github.com/apache/beam/pull/12519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #12575: [BEAM-10707] Adding Python docs precommit as separate suite.

2020-08-15 Thread GitBox
pabloem commented on pull request #12575: URL: https://github.com/apache/beam/pull/12575#issuecomment-674441165 Run Python Precommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] saavannanavati commented on pull request #12566: [BEAM-10701] Add Codecov YAML

2020-08-15 Thread GitBox
saavannanavati commented on pull request #12566: URL: https://github.com/apache/beam/pull/12566#issuecomment-674440307 run python precommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] samaitra opened a new pull request #12593: BEAM-9045 Implement an Ignite runner using Apache Ignite compute grid

2020-08-15 Thread GitBox
samaitra opened a new pull request #12593: URL: https://github.com/apache/beam/pull/12593 BEAM-9045 Implement an Ignite runner using Apache Ignite compute grid. This is work in progress PR. I have created IgniteRunner and IgnitePipelineOptions. I have implemented normalize pi

[GitHub] [beam] lukecwik commented on pull request #12519: [BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

2020-08-15 Thread GitBox
lukecwik commented on pull request #12519: URL: https://github.com/apache/beam/pull/12519#issuecomment-674434636 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] pabloem commented on pull request #12575: [BEAM-10707] Adding Python docs precommit as separate suite.

2020-08-15 Thread GitBox
pabloem commented on pull request #12575: URL: https://github.com/apache/beam/pull/12575#issuecomment-674431843 Run Python Precommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] mxm commented on pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-08-15 Thread GitBox
mxm commented on pull request #12564: URL: https://github.com/apache/beam/pull/12564#issuecomment-674378273 Thanks for making this happen! This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] mxm merged pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-08-15 Thread GitBox
mxm merged pull request #12564: URL: https://github.com/apache/beam/pull/12564 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [beam] mxm commented on pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-08-15 Thread GitBox
mxm commented on pull request #12564: URL: https://github.com/apache/beam/pull/12564#issuecomment-674377842 Unrelated test failure in Python: ``` Test Result (2 failures / +1) apache_beam.transforms.ptransform_test.PTransformTypeCheckTestCase.test_pardo_properly_type_c

[GitHub] [beam] mxm commented on pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-08-15 Thread GitBox
mxm commented on pull request #12564: URL: https://github.com/apache/beam/pull/12564#issuecomment-674377804 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] lukecwik commented on pull request #12519: [BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

2020-08-15 Thread GitBox
lukecwik commented on pull request #12519: URL: https://github.com/apache/beam/pull/12519#issuecomment-674375384 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] mxm commented on pull request #12564: [BEAM-10612] add Flink 1.11 runner

2020-08-15 Thread GitBox
mxm commented on pull request #12564: URL: https://github.com/apache/beam/pull/12564#issuecomment-674372723 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] pabloem commented on pull request #12575: [BEAM-10707] Adding Python docs precommit as separate suite.

2020-08-15 Thread GitBox
pabloem commented on pull request #12575: URL: https://github.com/apache/beam/pull/12575#issuecomment-674363068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [beam] pabloem merged pull request #12592: [BEAM-8025] Update tests to use TemporaryFolder instead of rolling their own implementation.

2020-08-15 Thread GitBox
pabloem merged pull request #12592: URL: https://github.com/apache/beam/pull/12592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t