[GitHub] [beam] nehsyc edited a comment on pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-24 Thread GitBox
nehsyc edited a comment on pull request #12678: URL: https://github.com/apache/beam/pull/12678#issuecomment-679680154 Please advice if there is a better way than simply matching the DoFn with GroupIntoBatchesFn. This should not be merged until the backend can recognize the new property. Bu

[GitHub] [beam] nehsyc commented on pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-24 Thread GitBox
nehsyc commented on pull request #12678: URL: https://github.com/apache/beam/pull/12678#issuecomment-679680154 Please advice if there is a better way than simply matching the DoFn with GroupIntoBatchesFn. This should not be merged before the backend can recognize the option. But would like

[GitHub] [beam] nehsyc commented on pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-24 Thread GitBox
nehsyc commented on pull request #12678: URL: https://github.com/apache/beam/pull/12678#issuecomment-679669283 R: @boyuanzz This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] nehsyc opened a new pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-08-24 Thread GitBox
nehsyc opened a new pull request #12678: URL: https://github.com/apache/beam/pull/12678 To enable optimization for the transform `GroupIntoBatches`, add a new step property when translating stateful DoFns to inform the backend that the special transform allows shardable states.

[GitHub] [beam] udim merged pull request #12657: [BEAM-10777] Add two blog posts detailing changes to the type hints module of the Python SDK

2020-08-24 Thread GitBox
udim merged pull request #12657: URL: https://github.com/apache/beam/pull/12657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] nehsyc commented on pull request #12677: [BEAM-10703] Dedup computation-and-key definitions

2020-08-24 Thread GitBox
nehsyc commented on pull request #12677: URL: https://github.com/apache/beam/pull/12677#issuecomment-679585283 R: @boyuanzz, @lukecwik This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] nehsyc opened a new pull request #12677: [BEAM-10703] Dedup computation-and-key definitions

2020-08-24 Thread GitBox
nehsyc opened a new pull request #12677: URL: https://github.com/apache/beam/pull/12677 A follow-up PR of [12578](https://github.com/apache/beam/pull/12578). Replaced duplicated definitions of computation-and-key in different classes with `WindmillComputationKey`. --

[GitHub] [beam] boyuanzz commented on a change in pull request #12419: [BEAM-10303] Handle split when truncate observes windows.

2020-08-24 Thread GitBox
boyuanzz commented on a change in pull request #12419: URL: https://github.com/apache/beam/pull/12419#discussion_r476125331 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -1035,6 +1046,130 @@ private Progress getProgress() {

[GitHub] [beam] codecov[bot] edited a comment on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679334534 # [Codecov](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=h1) Report > Merging [#12674](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=desc) into

[GitHub] [beam] chamikaramj commented on a change in pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API

2020-08-24 Thread GitBox
chamikaramj commented on a change in pull request #12494: URL: https://github.com/apache/beam/pull/12494#discussion_r475960972 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java ## @@ -348,22 +347,17 @@ stati

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12676: set_index is not index preserving

2020-08-24 Thread GitBox
TheNeuralBit commented on a change in pull request #12676: URL: https://github.com/apache/beam/pull/12676#discussion_r475973354 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -261,15 +261,21 @@ def __setitem__(self, key, value): else: raise NotImple

[GitHub] [beam] leiyiz commented on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
leiyiz commented on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679423173 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robertwb opened a new pull request #12676: set_index is not index preserving

2020-08-24 Thread GitBox
robertwb opened a new pull request #12676: URL: https://github.com/apache/beam/pull/12676 This causes trouble with downstream operations. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily

[GitHub] [beam] codecov[bot] edited a comment on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679334534 # [Codecov](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=h1) Report > Merging [#12674](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=desc) into

[GitHub] [beam] rezarokni commented on a change in pull request #12663: [BEAM-10597] Propagate BigQuery streaming insert throttled time to Dataflow worker in Python SDK

2020-08-24 Thread GitBox
rezarokni commented on a change in pull request #12663: URL: https://github.com/apache/beam/pull/12663#discussion_r475953736 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1257,6 +1260,7 @@ def _flush_batch(self, destination): _LOGGER.info(

[GitHub] [beam] codecov[bot] edited a comment on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679334534 # [Codecov](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=h1) Report > Merging [#12674](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=desc) into

[GitHub] [beam] chamikaramj commented on pull request #12297: [BEAM-10137] Add KinesisIO for cross-language usage with python wrapper

2020-08-24 Thread GitBox
chamikaramj commented on pull request #12297: URL: https://github.com/apache/beam/pull/12297#issuecomment-679414147 Please resolve the conflict. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] codecov[bot] edited a comment on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679334534 # [Codecov](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=h1) Report > Merging [#12674](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=desc) into

[GitHub] [beam] leiyiz commented on a change in pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
leiyiz commented on a change in pull request #12674: URL: https://github.com/apache/beam/pull/12674#discussion_r475940875 ## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/nexmark_util.py ## @@ -221,5 +228,34 @@ def unnest_to_json(cand): def millis_to_timest

[GitHub] [beam] pabloem commented on pull request #12479: [BEAM-10649] Add BigQuery Avro logical type support on read

2020-08-24 Thread GitBox
pabloem commented on pull request #12479: URL: https://github.com/apache/beam/pull/12479#issuecomment-679400395 I am surprised that we didn't have this already. Let's see... This is an automated message from the Apache Git Se

[GitHub] [beam] pabloem merged pull request #12663: [BEAM-10597] Propagate BigQuery streaming insert throttled time to Dataflow worker in Python SDK

2020-08-24 Thread GitBox
pabloem merged pull request #12663: URL: https://github.com/apache/beam/pull/12663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] pabloem commented on pull request #12663: [BEAM-10597] Propagate BigQuery streaming insert throttled time to Dataflow worker in Python SDK

2020-08-24 Thread GitBox
pabloem commented on pull request #12663: URL: https://github.com/apache/beam/pull/12663#issuecomment-679393188 @rezarokni can you still share your thoughts about making this a distribution? This is an automated message from

[GitHub] [beam] y1chi commented on pull request #12640: Fix PairWithRestrictionFn process no attribute signature error

2020-08-24 Thread GitBox
y1chi commented on pull request #12640: URL: https://github.com/apache/beam/pull/12640#issuecomment-679391442 > Thanks! I'm wondering what failure you have met because of this. was trying to run a pipeline with BundleBasedDirectRunner and got no attribute error on sdf runner. -

[GitHub] [beam] y1chi commented on pull request #12640: Fix PairWithRestrictionFn process no attribute signature error

2020-08-24 Thread GitBox
y1chi commented on pull request #12640: URL: https://github.com/apache/beam/pull/12640#issuecomment-679353442 R: @boyuanzz This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] jhnmora000 commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-08-24 Thread GitBox
jhnmora000 commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-679351771 Hi Rui. Yes, please give it a look if you have time. I think it is ready for review. This is an automat

[GitHub] [beam] y1chi commented on a change in pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
y1chi commented on a change in pull request #12674: URL: https://github.com/apache/beam/pull/12674#discussion_r475871022 ## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/monitor.py ## @@ -0,0 +1,48 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [beam] codecov[bot] edited a comment on pull request #12675: [BEAM-2855] implement query 12

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12675: URL: https://github.com/apache/beam/pull/12675#issuecomment-679343742 # [Codecov](https://codecov.io/gh/apache/beam/pull/12675?src=pr&el=h1) Report > Merging [#12675](https://codecov.io/gh/apache/beam/pull/12675?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12675: [BEAM-2855] implement query 12

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12675: URL: https://github.com/apache/beam/pull/12675#issuecomment-679343742 # [Codecov](https://codecov.io/gh/apache/beam/pull/12675?src=pr&el=h1) Report > Merging [#12675](https://codecov.io/gh/apache/beam/pull/12675?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12675: [BEAM-2855] implement query 12

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12675: URL: https://github.com/apache/beam/pull/12675#issuecomment-679343742 # [Codecov](https://codecov.io/gh/apache/beam/pull/12675?src=pr&el=h1) Report > Merging [#12675](https://codecov.io/gh/apache/beam/pull/12675?src=pr&el=desc) into [master

[GitHub] [beam] codecov[bot] edited a comment on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679334534 # [Codecov](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=h1) Report > Merging [#12674](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679334534 # [Codecov](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=h1) Report > Merging [#12674](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679334534 # [Codecov](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=h1) Report > Merging [#12674](https://codecov.io/gh/apache/beam/pull/12674?src=pr&el=desc) into [master

[GitHub] [beam] leiyiz commented on pull request #12675: [BEAM-2855] implement query 12

2020-08-24 Thread GitBox
leiyiz commented on pull request #12675: URL: https://github.com/apache/beam/pull/12675#issuecomment-679331499 R: @y1chi R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] leiyiz opened a new pull request #12675: [BEAM-2855] implement query 12

2020-08-24 Thread GitBox
leiyiz opened a new pull request #12675: URL: https://github.com/apache/beam/pull/12675 implemented query 12, which only runs in streaming mode currently Thank you for your contribution! Follow this checklist to help us incorporate your contribution qu

[GitHub] [beam] pabloem merged pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

2020-08-24 Thread GitBox
pabloem merged pull request #12415: URL: https://github.com/apache/beam/pull/12415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] leiyiz commented on pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
leiyiz commented on pull request #12674: URL: https://github.com/apache/beam/pull/12674#issuecomment-679320648 R: @y1chi R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] leiyiz opened a new pull request #12674: [BEAM-8258] basic metric feature for nexmark

2020-08-24 Thread GitBox
leiyiz opened a new pull request #12674: URL: https://github.com/apache/beam/pull/12674 added beam-metric based performance monitoring performance are logged to console after the query is done or canceled by nexmark suite Thank you for your contribu

[GitHub] [beam] codecov[bot] edited a comment on pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12415: URL: https://github.com/apache/beam/pull/12415#issuecomment-679302193 # [Codecov](https://codecov.io/gh/apache/beam/pull/12415?src=pr&el=h1) Report > Merging [#12415](https://codecov.io/gh/apache/beam/pull/12415?src=pr&el=desc) into

[GitHub] [beam] lostluck commented on pull request #12170: [BEAM-10166] Improve execution time errors with more concise error messages from DoFns

2020-08-24 Thread GitBox
lostluck commented on pull request #12170: URL: https://github.com/apache/beam/pull/12170#issuecomment-679304134 Your image is missing the whole error, but I suspect that the build doesn't know where that package is coming from. `go get github.cmo/google/go-cmp/cmp/cmpopts` should so

[GitHub] [beam] codecov[bot] commented on pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12415: URL: https://github.com/apache/beam/pull/12415#issuecomment-679302193 # [Codecov](https://codecov.io/gh/apache/beam/pull/12415?src=pr&el=h1) Report > Merging [#12415](https://codecov.io/gh/apache/beam/pull/12415?src=pr&el=desc) into [master

[GitHub] [beam] pabloem merged pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
pabloem merged pull request #12671: URL: https://github.com/apache/beam/pull/12671 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] pabloem commented on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
pabloem commented on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679293147 LGTM. Thanks @kamilwu ! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] meredithslota commented on pull request #12559: [BEAM-7705] Update BigQuery docs with new code snippets

2020-08-24 Thread GitBox
meredithslota commented on pull request #12559: URL: https://github.com/apache/beam/pull/12559#issuecomment-679288254 @chamikaramj Do you have a moment to take a look at these? Thank you! :) This is an automated message from

[GitHub] [beam] pabloem commented on pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

2020-08-24 Thread GitBox
pabloem commented on pull request #12415: URL: https://github.com/apache/beam/pull/12415#issuecomment-679286776 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on a change in pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

2020-08-24 Thread GitBox
pabloem commented on a change in pull request #12415: URL: https://github.com/apache/beam/pull/12415#discussion_r475799361 ## File path: sdks/python/apache_beam/runners/interactive/recording_manager_test.py ## @@ -0,0 +1,301 @@ +# +# Licensed to the Apache Software Foundation (

[GitHub] [beam] pabloem commented on a change in pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

2020-08-24 Thread GitBox
pabloem commented on a change in pull request #12415: URL: https://github.com/apache/beam/pull/12415#discussion_r475799128 ## File path: sdks/python/apache_beam/runners/interactive/recording_manager.py ## @@ -0,0 +1,334 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [beam] trucleduc commented on pull request #12661: Add export FHIR resources to GCS IO Connector

2020-08-24 Thread GitBox
trucleduc commented on pull request #12661: URL: https://github.com/apache/beam/pull/12661#issuecomment-679271437 @lastomato Just updated the pull request with the ExportGcs IO connector. PTAL. This is an automated message f

[GitHub] [beam] codecov[bot] commented on pull request #12640: Fix PairWithRestrictionFn process no attribute signature error

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12640: URL: https://github.com/apache/beam/pull/12640#issuecomment-679263084 # [Codecov](https://codecov.io/gh/apache/beam/pull/12640?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@32b67ec`). [Click here to

[GitHub] [beam] udim merged pull request #12602: Silence red PYTHONPATH warning from tox

2020-08-24 Thread GitBox
udim merged pull request #12602: URL: https://github.com/apache/beam/pull/12602 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12672: URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177 # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into

[GitHub] [beam] rohdesamuel commented on pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

2020-08-24 Thread GitBox
rohdesamuel commented on pull request #12415: URL: https://github.com/apache/beam/pull/12415#issuecomment-679255172 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12672: URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177 # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12672: URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177 # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into

[GitHub] [beam] lazylynx opened a new pull request #12673: [BEAM-9944] made run_pytest allow options to indicate specific test package

2020-08-24 Thread GitBox
lazylynx opened a new pull request #12673: URL: https://github.com/apache/beam/pull/12673 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https

[GitHub] [beam] codecov[bot] edited a comment on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12672: URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177 # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into

[GitHub] [beam] kmjung commented on pull request #12494: [BEAM-10658] Update BigQuery storage sources to v1 API

2020-08-24 Thread GitBox
kmjung commented on pull request #12494: URL: https://github.com/apache/beam/pull/12494#issuecomment-679242125 @chamikaramj ping? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] codecov[bot] commented on pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12672: URL: https://github.com/apache/beam/pull/12672#issuecomment-679242177 # [Codecov](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=h1) Report > Merging [#12672](https://codecov.io/gh/apache/beam/pull/12672?src=pr&el=desc) into [master

[GitHub] [beam] y1chi commented on pull request #12640: Fix PairWithRestrictionFn process no attribute signature error

2020-08-24 Thread GitBox
y1chi commented on pull request #12640: URL: https://github.com/apache/beam/pull/12640#issuecomment-679234293 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] y1chi removed a comment on pull request #12640: Fix PairWithRestrictionFn process no attribute signature error

2020-08-24 Thread GitBox
y1chi removed a comment on pull request #12640: URL: https://github.com/apache/beam/pull/12640#issuecomment-678477828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] ricardolui opened a new pull request #12672: [BEAM-10805] Adding MySQL connector lib to dependencies, so it can be used with external JDBC (e.g. jdbcio on python)

2020-08-24 Thread GitBox
ricardolui opened a new pull request #12672: URL: https://github.com/apache/beam/pull/12672 Adding MySQL connector lib to dependencies, so it can be used with external JDBC. This is for cross language support on python and so it gets added on beam-sdks-java-io-expansion-service*.jar

[GitHub] [beam] kamilwu removed a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu removed a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679208026 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [beam] kamilwu removed a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu removed a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679096177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679207648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679207946 Run Load Tests Python GBK Dataflow Batch This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679208026 Run Load Tests Python GBK Dataflow Streaming This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679204422 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on a change in pull request #12612: URL: https://github.com/apache/beam/pull/12612#discussion_r475707404 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Python.groovy ## @@ -22,119 +22,138 @@ import InfluxDBCredentialsHelper def now = new Date().format(

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > Merging [#12612](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > Merging [#12612](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=desc) into

[GitHub] [beam] kamilwu merged pull request #12541: [BEAM-10682] Add workflow to run Java tests on Linux/Windows/Mac

2020-08-24 Thread GitBox
kamilwu merged pull request #12541: URL: https://github.com/apache/beam/pull/12541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] kamilwu commented on pull request #12541: [BEAM-10682] Add workflow to run Java tests on Linux/Windows/Mac

2020-08-24 Thread GitBox
kamilwu commented on pull request #12541: URL: https://github.com/apache/beam/pull/12541#issuecomment-679114434 It looks like all comments have been addressed, so I'm going to merge it now. Thanks! This is an automated messa

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679096177 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click

[GitHub] [beam] kamilwu commented on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
kamilwu commented on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679079836 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679064210 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679063372 @tysonjh Thanks! Could you verify my fixes before I merge? This is an automated message from the Apache Git Servi

[GitHub] [beam] codecov[bot] edited a comment on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click

[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on a change in pull request #12612: URL: https://github.com/apache/beam/pull/12612#discussion_r475520818 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Python_reiterate.groovy ## @@ -58,43 +58,47 @@ def loadTestConfigurations = { datasetName -> pip

[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on a change in pull request #12612: URL: https://github.com/apache/beam/pull/12612#discussion_r475520818 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Python_reiterate.groovy ## @@ -58,43 +58,47 @@ def loadTestConfigurations = { datasetName -> pip

[GitHub] [beam] codecov[bot] edited a comment on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click

[GitHub] [beam] mareksimunek commented on pull request #12610: [BEAM-10723] ElasticsearchIO SSL authentication key fix

2020-08-24 Thread GitBox
mareksimunek commented on pull request #12610: URL: https://github.com/apache/beam/pull/12610#issuecomment-679050116 R: @echauchot This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679036724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679036617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679032396 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] codecov[bot] commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12612: URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190 # [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to

[GitHub] [beam] codeBehindMe commented on pull request #12170: [BEAM-10166] Improve execution time errors with more concise error messages from DoFns

2020-08-24 Thread GitBox
codeBehindMe commented on pull request #12170: URL: https://github.com/apache/beam/pull/12170#issuecomment-679030201 So i've been banging my head against the wall with the following error. Am I missing something obvious here? ![image](https://user-images.githubusercontent.com/11843941/9

[GitHub] [beam] codecov[bot] edited a comment on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click

[GitHub] [beam] codecov[bot] edited a comment on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] edited a comment on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click

[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow

2020-08-24 Thread GitBox
kamilwu commented on a change in pull request #12612: URL: https://github.com/apache/beam/pull/12612#discussion_r475467063 ## File path: .test-infra/jenkins/job_LoadTests_GBK_Python.groovy ## @@ -22,119 +22,138 @@ import InfluxDBCredentialsHelper def now = new Date().format(

[GitHub] [beam] codecov[bot] commented on pull request #12671: [BEAM-10524] JSON decoder for ReadFromBigQuery supports repeatable fields

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12671: URL: https://github.com/apache/beam/pull/12671#issuecomment-679014547 # [Codecov](https://codecov.io/gh/apache/beam/pull/12671?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@f7b49b6`). [Click here to

[GitHub] [beam] codecov[bot] commented on pull request #12541: [BEAM-10682] Add workflow to run Java tests on Linux/Windows/Mac

2020-08-24 Thread GitBox
codecov[bot] commented on pull request #12541: URL: https://github.com/apache/beam/pull/12541#issuecomment-679010663 # [Codecov](https://codecov.io/gh/apache/beam/pull/12541?src=pr&el=h1) Report > Merging [#12541](https://codecov.io/gh/apache/beam/pull/12541?src=pr&el=desc) into [master

  1   2   >