[GitHub] [beam] lostluck commented on pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

2020-09-10 Thread GitBox
lostluck commented on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-690891253 Thanks! I appreciate that. On Thu, Sep 10, 2020, 10:46 PM Daniel Oliveira wrote: > Progress update: Started reviewing this today, about 2/3 of the way >

[GitHub] [beam] youngoli commented on pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

2020-09-10 Thread GitBox
youngoli commented on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-690889052 Progress update: Started reviewing this today, about 2/3 of the way through. Wanted to let you know I was working on it, so you don't just get radio silence.

[GitHub] [beam] codecov[bot] edited a comment on pull request #12748: [BEAM-8715] update avro - extract avro to it's own module [WIP]

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12748: URL: https://github.com/apache/beam/pull/12748#issuecomment-684999675 # [Codecov](https://codecov.io/gh/apache/beam/pull/12748?src=pr=h1) Report > Merging [#12748](https://codecov.io/gh/apache/beam/pull/12748?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12808: add readme file to python nexmark

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12808: URL: https://github.com/apache/beam/pull/12808#issuecomment-690009424 # [Codecov](https://codecov.io/gh/apache/beam/pull/12808?src=pr=h1) Report > Merging [#12808](https://codecov.io/gh/apache/beam/pull/12808?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12808: add readme file to python nexmark

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12808: URL: https://github.com/apache/beam/pull/12808#issuecomment-690009424 # [Codecov](https://codecov.io/gh/apache/beam/pull/12808?src=pr=h1) Report > Merging [#12808](https://codecov.io/gh/apache/beam/pull/12808?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12808: add readme file to python nexmark

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12808: URL: https://github.com/apache/beam/pull/12808#issuecomment-690009424 # [Codecov](https://codecov.io/gh/apache/beam/pull/12808?src=pr=h1) Report > Merging [#12808](https://codecov.io/gh/apache/beam/pull/12808?src=pr=desc) into

[GitHub] [beam] amaliujia merged pull request #12532: [Beam-9543] support MATCH_RECOGNIZE with NFA

2020-09-10 Thread GitBox
amaliujia merged pull request #12532: URL: https://github.com/apache/beam/pull/12532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #12808: add readme file to python nexmark

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12808: URL: https://github.com/apache/beam/pull/12808#issuecomment-690009424 # [Codecov](https://codecov.io/gh/apache/beam/pull/12808?src=pr=h1) Report > Merging [#12808](https://codecov.io/gh/apache/beam/pull/12808?src=pr=desc) into

[GitHub] [beam] leiyiz commented on a change in pull request #12813: write to file ability for java suite

2020-09-10 Thread GitBox
leiyiz commented on a change in pull request #12813: URL: https://github.com/apache/beam/pull/12813#discussion_r486767972 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkConfiguration.java ## @@ -42,6 +42,9 @@ /** Where events come

[GitHub] [beam] pabloem commented on pull request #12721: [BEAM-10871] Add deidentify for FhirIO connector

2020-09-10 Thread GitBox
pabloem commented on pull request #12721: URL: https://github.com/apache/beam/pull/12721#issuecomment-690864594 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12807: [BEAM-2855] implement query 10

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689997960 # [Codecov](https://codecov.io/gh/apache/beam/pull/12807?src=pr=h1) Report > Merging [#12807](https://codecov.io/gh/apache/beam/pull/12807?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12807: [BEAM-2855] implement query 10

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689997960 # [Codecov](https://codecov.io/gh/apache/beam/pull/12807?src=pr=h1) Report > Merging [#12807](https://codecov.io/gh/apache/beam/pull/12807?src=pr=desc) into

[GitHub] [beam] jayendra13 commented on pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:extensions:sql:zetasql

2020-09-10 Thread GitBox
jayendra13 commented on pull request #12596: URL: https://github.com/apache/beam/pull/12596#issuecomment-690844900 I have fixed the most of the issues, yet needed help for few so have asked questions at those locations.

[GitHub] [beam] jayendra13 edited a comment on pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:extensions:sql:zetasql

2020-09-10 Thread GitBox
jayendra13 edited a comment on pull request #12596: URL: https://github.com/apache/beam/pull/12596#issuecomment-690844900 I have fixed the most of the issues, yet needed help for few so have asked questions at those locations. Yes in that way we can say this is WIP but can continue only

[GitHub] [beam] leiyiz commented on a change in pull request #12807: [BEAM-2855] implement query 10

2020-09-10 Thread GitBox
leiyiz commented on a change in pull request #12807: URL: https://github.com/apache/beam/pull/12807#discussion_r486742790 ## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/query10.py ## @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] leiyiz commented on a change in pull request #12807: [BEAM-2855] implement query 10

2020-09-10 Thread GitBox
leiyiz commented on a change in pull request #12807: URL: https://github.com/apache/beam/pull/12807#discussion_r486742699 ## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/query10.py ## @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] leiyiz commented on a change in pull request #12807: [BEAM-2855] implement query 10

2020-09-10 Thread GitBox
leiyiz commented on a change in pull request #12807: URL: https://github.com/apache/beam/pull/12807#discussion_r486742739 ## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/query10.py ## @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] stale[bot] closed pull request #11186: [BEAM-9564] Remove insecure ssl options from MongoDBIO

2020-09-10 Thread GitBox
stale[bot] closed pull request #11186: URL: https://github.com/apache/beam/pull/11186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] stale[bot] commented on pull request #10487: [BEAM-5504] Introduce PubsubAvroTable

2020-09-10 Thread GitBox
stale[bot] commented on pull request #10487: URL: https://github.com/apache/beam/pull/10487#issuecomment-690839310 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] stale[bot] commented on pull request #11850: [BEAM-1438] Allow 0 shards on WriteFiles streaming

2020-09-10 Thread GitBox
stale[bot] commented on pull request #11850: URL: https://github.com/apache/beam/pull/11850#issuecomment-690839314 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] stale[bot] commented on pull request #11186: [BEAM-9564] Remove insecure ssl options from MongoDBIO

2020-09-10 Thread GitBox
stale[bot] commented on pull request #11186: URL: https://github.com/apache/beam/pull/11186#issuecomment-690839344 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[GitHub] [beam] stale[bot] commented on pull request #7949: [BEAM-3713] Add pytest testing infrastructure

2020-09-10 Thread GitBox
stale[bot] commented on pull request #7949: URL: https://github.com/apache/beam/pull/7949#issuecomment-690839304 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] yifanmai commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
yifanmai commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-690835921 Run Python 3.5 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12807: [BEAM-2855] implement query 10

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689997960 # [Codecov](https://codecov.io/gh/apache/beam/pull/12807?src=pr=h1) Report > Merging [#12807](https://codecov.io/gh/apache/beam/pull/12807?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] monicadsong commented on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
monicadsong commented on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-690811376 thank you all for reviewing :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] monicadsong closed pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
monicadsong closed pull request #12756: URL: https://github.com/apache/beam/pull/12756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] youngoli commented on pull request #12792: [DO NOT MERGE] Run Python RC Validation Tests

2020-09-10 Thread GitBox
youngoli commented on pull request #12792: URL: https://github.com/apache/beam/pull/12792#issuecomment-690810818 Run Python ReleaseCandidate This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12773: [BEAM-10505][BEAM-10530] Add truncate capability.

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12773: URL: https://github.com/apache/beam/pull/12773#issuecomment-690802617 # [Codecov](https://codecov.io/gh/apache/beam/pull/12773?src=pr=h1) Report > Merging [#12773](https://codecov.io/gh/apache/beam/pull/12773?src=pr=desc) into

[GitHub] [beam] aaltay commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1

2020-09-10 Thread GitBox
aaltay commented on pull request #12692: URL: https://github.com/apache/beam/pull/12692#issuecomment-690809163 Is this PR obsolete after https://github.com/apache/beam/pull/12776 ? This is an automated message from the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12764: [BEAM-10009] Add beam:logical_type:micros_instant:v1

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12764: URL: https://github.com/apache/beam/pull/12764#issuecomment-686100810 # [Codecov](https://codecov.io/gh/apache/beam/pull/12764?src=pr=h1) Report > Merging [#12764](https://codecov.io/gh/apache/beam/pull/12764?src=pr=desc) into

[GitHub] [beam] aaltay commented on pull request #12596: [BEAM-10498] [WIP] Eliminate nullability errors from :sdks:java:extensions:sql:zetasql

2020-09-10 Thread GitBox
aaltay commented on pull request #12596: URL: https://github.com/apache/beam/pull/12596#issuecomment-690808675 This is still marked as WIP. Is it ready for reviews? This is an automated message from the Apache Git Service.

[GitHub] [beam] aaltay commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-09-10 Thread GitBox
aaltay commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-690808206 @amaliujia - Could this be merged? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aaltay commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE

2020-09-10 Thread GitBox
aaltay commented on pull request #12735: URL: https://github.com/apache/beam/pull/12735#issuecomment-690808007 Is this ready to be merged? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] tvalentyn commented on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
tvalentyn commented on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-690807589 LGTM, thanks a lot, @monicadsong ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12764: [BEAM-10009] Add beam:logical_type:micros_instant:v1

2020-09-10 Thread GitBox
TheNeuralBit commented on a change in pull request #12764: URL: https://github.com/apache/beam/pull/12764#discussion_r486709165 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/MicrosInstant.java ## @@ -0,0 +1,72 @@ +/* + * Licensed to the

[GitHub] [beam] ibzib commented on pull request #12820: [BEAM-9575] Only copy the Spark runner jar, not whatever other jars h…

2020-09-10 Thread GitBox
ibzib commented on pull request #12820: URL: https://github.com/apache/beam/pull/12820#issuecomment-690805242 R: @lukecwik @kamilwu Kamil, this should fix the error we encountered on BEAM-8970. This is an automated

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] ibzib commented on pull request #12820: [BEAM-9575] Only copy the Spark runner jar, not whatever other jars h…

2020-09-10 Thread GitBox
ibzib commented on pull request #12820: URL: https://github.com/apache/beam/pull/12820#issuecomment-690804557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] ibzib opened a new pull request #12820: [BEAM-9575] Only copy the Spark runner jar, not whatever other jars h…

2020-09-10 Thread GitBox
ibzib opened a new pull request #12820: URL: https://github.com/apache/beam/pull/12820 …appen to be on the classloader. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12773: [BEAM-10505][BEAM-10530] Add truncate capability.

2020-09-10 Thread GitBox
codecov[bot] commented on pull request #12773: URL: https://github.com/apache/beam/pull/12773#issuecomment-690802617 # [Codecov](https://codecov.io/gh/apache/beam/pull/12773?src=pr=h1) Report > Merging [#12773](https://codecov.io/gh/apache/beam/pull/12773?src=pr=desc) into

[GitHub] [beam] robertwb opened a new pull request #12819: [BEAM-9561] Initial framework for testing pandas website docs.

2020-09-10 Thread GitBox
robertwb opened a new pull request #12819: URL: https://github.com/apache/beam/pull/12819 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] robertwb commented on pull request #12819: [BEAM-9561] Initial framework for testing pandas website docs.

2020-09-10 Thread GitBox
robertwb commented on pull request #12819: URL: https://github.com/apache/beam/pull/12819#issuecomment-690802442 R: @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12812: URL: https://github.com/apache/beam/pull/12812#issuecomment-690611762 # [Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr=h1) Report > Merging [#12812](https://codecov.io/gh/apache/beam/pull/12812?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] kw2542 commented on pull request #12617: [BEAM-10670] Update Samza to be opt-out for SplittableDoFn powering the Read transform.

2020-09-10 Thread GitBox
kw2542 commented on pull request #12617: URL: https://github.com/apache/beam/pull/12617#issuecomment-690796364 Hi @lukecwik , I must miss some context here, could you help me understand couple of things: 1. If the PR is intended to opt Samza runner out for SplittableDoFn, why do we

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12817: URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920 # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr=h1) Report > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12817: URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920 # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr=h1) Report > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr=desc) into

[GitHub] [beam] tysonjh commented on a change in pull request #12616: [BEAM-10670] Update Jet to be opt-out for SplittableDoFn powering the Read transform.

2020-09-10 Thread GitBox
tysonjh commented on a change in pull request #12616: URL: https://github.com/apache/beam/pull/12616#discussion_r486679831 ## File path: runners/jet/build.gradle ## @@ -85,6 +84,12 @@ task validatesRunnerBatch(type: Test) { excludeCategories

[GitHub] [beam] boyuanzz commented on pull request #12773: [BEAM-10505][BEAM-10530] Add truncate capability.

2020-09-10 Thread GitBox
boyuanzz commented on pull request #12773: URL: https://github.com/apache/beam/pull/12773#issuecomment-690789314 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] boyuanzz commented on pull request #12773: [BEAM-10505][BEAM-10530] Add truncate capability.

2020-09-10 Thread GitBox
boyuanzz commented on pull request #12773: URL: https://github.com/apache/beam/pull/12773#issuecomment-690789168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] codecov[bot] commented on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
codecov[bot] commented on pull request #12817: URL: https://github.com/apache/beam/pull/12817#issuecomment-690788920 # [Codecov](https://codecov.io/gh/apache/beam/pull/12817?src=pr=h1) Report > Merging [#12817](https://codecov.io/gh/apache/beam/pull/12817?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12812: URL: https://github.com/apache/beam/pull/12812#issuecomment-690611762 # [Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr=h1) Report > Merging [#12812](https://codecov.io/gh/apache/beam/pull/12812?src=pr=desc) into

[GitHub] [beam] angoenka commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
angoenka commented on a change in pull request #12817: URL: https://github.com/apache/beam/pull/12817#discussion_r486688088 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py ## @@ -210,6 +210,14 @@ def _get_metric_value(self, metric): dist_sum =

[GitHub] [beam] ibzib merged pull request #12803: [BEAM-10762] Fix artifact staging bug in Flink/Spark uber jar runners.

2020-09-10 Thread GitBox
ibzib merged pull request #12803: URL: https://github.com/apache/beam/pull/12803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] ibzib commented on a change in pull request #12803: [BEAM-10762] Fix artifact staging bug in Flink/Spark uber jar runners.

2020-09-10 Thread GitBox
ibzib commented on a change in pull request #12803: URL: https://github.com/apache/beam/pull/12803#discussion_r486687727 ## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java ## @@ -170,13 +169,16 @@ public static void main(String[]

[GitHub] [beam] robertwb commented on a change in pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-10 Thread GitBox
robertwb commented on a change in pull request #12787: URL: https://github.com/apache/beam/pull/12787#discussion_r486686500 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -704,6 +705,71 @@ def fix_side_input_pcoll_coders(stages,

[GitHub] [beam] y1chi commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
y1chi commented on a change in pull request #12817: URL: https://github.com/apache/beam/pull/12817#discussion_r486685631 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py ## @@ -210,6 +210,14 @@ def _get_metric_value(self, metric): dist_sum =

[GitHub] [beam] angoenka commented on a change in pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
angoenka commented on a change in pull request #12817: URL: https://github.com/apache/beam/pull/12817#discussion_r486685114 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py ## @@ -210,6 +210,14 @@ def _get_metric_value(self, metric): dist_sum =

[GitHub] [beam] yifanmai commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
yifanmai commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-690780411 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] terryxian78 opened a new pull request #12818: [BEAM-10875] Support NUMERIC in spanner schema parser

2020-09-10 Thread GitBox
terryxian78 opened a new pull request #12818: URL: https://github.com/apache/beam/pull/12818 R: @chamikaramj, @nielm Spanner library supports new column type NUMERIC since 1.59. We needs to support this type in spanner schema parser. This issue is the follow-up task of the

[GitHub] [beam] robertwb commented on a change in pull request #12803: [BEAM-10762] Fix artifact staging bug in Flink/Spark uber jar runners.

2020-09-10 Thread GitBox
robertwb commented on a change in pull request #12803: URL: https://github.com/apache/beam/pull/12803#discussion_r486681364 ## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineRunner.java ## @@ -170,13 +169,16 @@ public static void

[GitHub] [beam] robertwb commented on a change in pull request #12804: Fix translations.optimize_pipeline() failure on empty pipelines

2020-09-10 Thread GitBox
robertwb commented on a change in pull request #12804: URL: https://github.com/apache/beam/pull/12804#discussion_r486679692 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -478,8 +478,10 @@ def leaf_transform_stages( if

[GitHub] [beam] codecov[bot] edited a comment on pull request #12815: [BEAM-9561] Improve WontImplement reporting.

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12815: URL: https://github.com/apache/beam/pull/12815#issuecomment-690710790 # [Codecov](https://codecov.io/gh/apache/beam/pull/12815?src=pr=h1) Report > Merging [#12815](https://codecov.io/gh/apache/beam/pull/12815?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12812: [BEAM-10873] Stronger testing of dataframe partitioning declarations.

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12812: URL: https://github.com/apache/beam/pull/12812#issuecomment-690611762 # [Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr=h1) Report > Merging [#12812](https://codecov.io/gh/apache/beam/pull/12812?src=pr=desc) into

[GitHub] [beam] y1chi commented on pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
y1chi commented on pull request #12817: URL: https://github.com/apache/beam/pull/12817#issuecomment-690773882 R: @angoenka This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] chamikaramj commented on a change in pull request #12638: [BEAM-10769] Clarify Avro IO documentation.

2020-09-10 Thread GitBox
chamikaramj commented on a change in pull request #12638: URL: https://github.com/apache/beam/pull/12638#discussion_r486675519 ## File path: sdks/python/apache_beam/io/avroio.py ## @@ -90,7 +78,7 @@ def __init__( file_pattern=None, min_bundle_size=0,

[GitHub] [beam] chamikaramj commented on pull request #12638: [BEAM-10769] Clarify Avro IO documentation.

2020-09-10 Thread GitBox
chamikaramj commented on pull request #12638: URL: https://github.com/apache/beam/pull/12638#issuecomment-690772052 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lostluck commented on pull request #12816: [BEAM-10874 Support v2 protos.

2020-09-10 Thread GitBox
lostluck commented on pull request #12816: URL: https://github.com/apache/beam/pull/12816#issuecomment-690771607 R: @happygiraffe This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] robertwb commented on pull request #12815: [BEAM-9561] Improve WontImplement reporting.

2020-09-10 Thread GitBox
robertwb commented on pull request #12815: URL: https://github.com/apache/beam/pull/12815#issuecomment-690766354 E.g. Before ``` test_dataframe_tests (apache_beam.dataframe.pandas_doctests_test.DoctestTest) ... 572 total test cases: 223 skipped (39.0%) 112 won't

[GitHub] [beam] robertwb commented on pull request #12814: [BEAM-9547] A couple trivial but common dataframe methods.

2020-09-10 Thread GitBox
robertwb commented on pull request #12814: URL: https://github.com/apache/beam/pull/12814#issuecomment-690766555 R: @robinyqiu This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] robertwb commented on pull request #12815: [BEAM-9561] Improve WontImplement reporting.

2020-09-10 Thread GitBox
robertwb commented on pull request #12815: URL: https://github.com/apache/beam/pull/12815#issuecomment-690765556 R: @y1chi This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] robertwb commented on pull request #12815: [BEAM-9561] Improve WontImplement reporting.

2020-09-10 Thread GitBox
robertwb commented on pull request #12815: URL: https://github.com/apache/beam/pull/12815#issuecomment-690765130 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] y1chi commented on a change in pull request #12813: write to file ability for java suite

2020-09-10 Thread GitBox
y1chi commented on a change in pull request #12813: URL: https://github.com/apache/beam/pull/12813#discussion_r48964 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java ## @@ -922,6 +922,11 @@ private void

[GitHub] [beam] y1chi commented on a change in pull request #12813: write to file ability for java suite

2020-09-10 Thread GitBox
y1chi commented on a change in pull request #12813: URL: https://github.com/apache/beam/pull/12813#discussion_r48964 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java ## @@ -922,6 +922,11 @@ private void

[GitHub] [beam] yifanmai edited a comment on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-10 Thread GitBox
yifanmai edited a comment on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-690763918 I'm confused by the yapf failure: when I run yapf locally, it produces the exact opposite recommendation as the precommit. i.e. if I make the change recommended by

[GitHub] [beam] yifanmai commented on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-10 Thread GitBox
yifanmai commented on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-690763918 I'm confused by the yapf failure: when I run yapf locally, it produces the exact opposite recommendation as the precommit.

[GitHub] [beam] lostluck commented on a change in pull request #12617: [BEAM-10670] Update Samza to be opt-out for SplittableDoFn powering the Read transform.

2020-09-10 Thread GitBox
lostluck commented on a change in pull request #12617: URL: https://github.com/apache/beam/pull/12617#discussion_r48371 ## File path: runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SplittableParDoProcessKeyedElementsOp.java ## @@ -0,0 +1,251 @@ +/* + *

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] leiyiz commented on a change in pull request #12813: write to file ability for java suite

2020-09-10 Thread GitBox
leiyiz commented on a change in pull request #12813: URL: https://github.com/apache/beam/pull/12813#discussion_r486663750 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java ## @@ -922,6 +922,11 @@ private void

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] y1chi commented on a change in pull request #12813: write to file ability for java suite

2020-09-10 Thread GitBox
y1chi commented on a change in pull request #12813: URL: https://github.com/apache/beam/pull/12813#discussion_r486661742 ## File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java ## @@ -922,6 +922,11 @@ private void

[GitHub] [beam] tvalentyn commented on a change in pull request #12638: [BEAM-10769] Clarify Avro IO documentation.

2020-09-10 Thread GitBox
tvalentyn commented on a change in pull request #12638: URL: https://github.com/apache/beam/pull/12638#discussion_r486660991 ## File path: sdks/python/apache_beam/io/avroio.py ## @@ -90,7 +78,7 @@ def __init__( file_pattern=None, min_bundle_size=0,

[GitHub] [beam] leiyiz commented on pull request #12813: write to file ability for java suite

2020-09-10 Thread GitBox
leiyiz commented on pull request #12813: URL: https://github.com/apache/beam/pull/12813#issuecomment-690756599 @y1chi @pabloem This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on pull request #12638: [BEAM-10769] Clarify Avro IO documentation.

2020-09-10 Thread GitBox
tvalentyn commented on pull request #12638: URL: https://github.com/apache/beam/pull/12638#issuecomment-690755945 Will merge this after we remove Py2 support. This is an automated message from the Apache Git Service. To

[GitHub] [beam] tvalentyn commented on a change in pull request #12638: [BEAM-10769] Clarify Avro IO documentation.

2020-09-10 Thread GitBox
tvalentyn commented on a change in pull request #12638: URL: https://github.com/apache/beam/pull/12638#discussion_r486658612 ## File path: sdks/python/apache_beam/io/avroio.py ## @@ -511,7 +488,9 @@ def __init__( end in a common extension, if given by

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] y1chi opened a new pull request #12817: [BEAM-10876] Fix TypeError in dataflow_metrics when distribution sum …

2020-09-10 Thread GitBox
y1chi opened a new pull request #12817: URL: https://github.com/apache/beam/pull/12817 …overflows **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-10 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

  1   2   3   >