youngoli commented on pull request #13348:
URL: https://github.com/apache/beam/pull/13348#issuecomment-727156193
R: @lostluck (feel free to merge if there's no comments)
This is an automated message from the Apache Git
youngoli opened a new pull request #13348:
URL: https://github.com/apache/beam/pull/13348
Cleaning up some stylistic warnings about redundant types. No actual changes
to behavior.
Thank you for your contribution! Follow this checklist to help us
amaliujia edited a comment on pull request #13306:
URL: https://github.com/apache/beam/pull/13306#issuecomment-726559395
Also from potential user's requetes, there are existing CombinFn
implementation and they want use those as UDAF. This is a different case from
`Scalar Fn` that rewrite
piotr-szuberski removed a comment on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727145037
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727154152
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
codecov[bot] edited a comment on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-683611200
# [Codecov](https://codecov.io/gh/apache/beam/pull/12611?src=pr=h1) Report
> Merging
[#12611](https://codecov.io/gh/apache/beam/pull/12611?src=pr=desc) (1c43284)
youngoli merged pull request #13325:
URL: https://github.com/apache/beam/pull/13325
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
youngoli commented on a change in pull request #13325:
URL: https://github.com/apache/beam/pull/13325#discussion_r523383346
##
File path: sdks/go/pkg/beam/xlang.go
##
@@ -87,61 +84,16 @@ func TryCrossLanguage(s Scope, ext
*graph.ExternalTransform, ins []*graph.Inboun
youngoli commented on a change in pull request #13325:
URL: https://github.com/apache/beam/pull/13325#discussion_r523383319
##
File path: sdks/go/pkg/beam/core/runtime/xlangx/expand.go
##
@@ -18,19 +18,79 @@ package xlangx
import (
"context"
+
youngoli commented on a change in pull request #13325:
URL: https://github.com/apache/beam/pull/13325#discussion_r523383268
##
File path: sdks/go/pkg/beam/core/runtime/graphx/xlang.go
##
@@ -16,11 +16,222 @@
package graphx
import (
+ "fmt"
+
piotr-szuberski edited a comment on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-724889360
@timrobertson100 @iemejia Could I ask you to take a look at this PR? I
screwed up a bit the previous PR (update Hadoop to 2.10.1 and test with 2.8.5)
because I
piotr-szuberski removed a comment on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-724886649
This is an automated message from the Apache Git Service.
To respond to the message, please log
piotr-szuberski commented on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-727145816
Run SQL PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski removed a comment on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-726004319
This is an automated message from the Apache Git Service.
To respond to the message, please log
piotr-szuberski commented on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-727145888
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-727145836
Run Java HadoopFormatIO Performance Test
This is an automated message from the Apache Git Service.
To
piotr-szuberski commented on pull request #13287:
URL: https://github.com/apache/beam/pull/13287#issuecomment-727145750
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski removed a comment on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-724694752
This is an automated message from the Apache Git Service.
To respond to the message, please log
piotr-szuberski commented on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-727145508
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
piotr-szuberski removed a comment on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727022314
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727145037
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
codecov[bot] edited a comment on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-683611200
# [Codecov](https://codecov.io/gh/apache/beam/pull/12611?src=pr=h1) Report
> Merging
[#12611](https://codecov.io/gh/apache/beam/pull/12611?src=pr=desc) (1c43284)
tvalentyn merged pull request #13303:
URL: https://github.com/apache/beam/pull/13303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
TheNeuralBit commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-727119983
Failure looks like flake BEAM-4136
This is an automated message from the Apache Git Service.
To respond to
TheNeuralBit commented on a change in pull request #13345:
URL: https://github.com/apache/beam/pull/13345#discussion_r523336104
##
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java
##
@@ -146,20 +147,25 @@ public void
TheNeuralBit opened a new pull request #13347:
URL: https://github.com/apache/beam/pull/13347
Another fix for using DataframeTransform at scale. Without this it's not
possible to distribute reading distinct files on distinct workers.
Post-Commit Tests Status (on master branch)
TheNeuralBit commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-727117498
R: @robertwb
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit merged pull request #13346:
URL: https://github.com/apache/beam/pull/13346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yifanmai commented on pull request #13303:
URL: https://github.com/apache/beam/pull/13303#issuecomment-727109859
Checks look good now; windows-latest, 3.7, py37 failure looks unrelated:
`PermissionError: [WinError 32] The process cannot access the file because it
is being used by another
TheNeuralBit commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-727109764
Unfortunately since we're just after the 2.26.0 release cut we won't be able
to make the website change until 2.27.0 is out (probably early 2021). Filed
BEAM-11265 to keep
TheNeuralBit commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523326593
##
File path: website/www/site/content/en/get-started/quickstart-java.md
##
@@ -266,7 +266,7 @@ For Unix shells (Instructions currently only
veblush commented on pull request #13311:
URL: https://github.com/apache/beam/pull/13311#issuecomment-727108530
@kennknowles I found that issue when running the wordcount example on
dataflow with `--experiments=use_grpc_for_gcs` option.
davidwrede edited a comment on pull request #13317:
URL: https://github.com/apache/beam/pull/13317#issuecomment-727102822
@robertwb I implemented some of your changes, but unfortunately, someone
else will have to address the rest.
I'm happy to help merge in the PR as is, or hand it
TheNeuralBit commented on pull request #13340:
URL: https://github.com/apache/beam/pull/13340#issuecomment-727107604
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pcoet commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-727106066
Okay, I think we should be good to go. I left the sample in, but removed the
header and excluded it. After the next Beam release, I'll update the docs so
that the inputFile points
aaltay commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523307893
##
File path: sdks/java/maven-archetypes/examples/sample.txt
##
@@ -0,0 +1,117 @@
+#Licensed to the Apache Software Foundation (ASF) under one or more
TheNeuralBit opened a new pull request #13346:
URL: https://github.com/apache/beam/pull/13346
Post-Commit Tests Status (on master branch)
Lang | SDK | Dataflow | Flink | Samza |
pcoet commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523304147
##
File path: sdks/java/maven-archetypes/examples/sample.txt
##
@@ -0,0 +1,117 @@
+#Licensed to the Apache Software Foundation (ASF) under one or more
davidwrede commented on pull request #13317:
URL: https://github.com/apache/beam/pull/13317#issuecomment-727102822
@robertwb I implemented some of your changes, but ran out of time to get to
the rest. Someone else will have to address them.
robertwb merged pull request #13343:
URL: https://github.com/apache/beam/pull/13343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523302254
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523302017
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523301916
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
aaltay commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523301546
##
File path: sdks/java/maven-archetypes/examples/sample.txt
##
@@ -0,0 +1,117 @@
+#Licensed to the Apache Software Foundation (ASF) under one or more
aaltay commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523301546
##
File path: sdks/java/maven-archetypes/examples/sample.txt
##
@@ -0,0 +1,117 @@
+#Licensed to the Apache Software Foundation (ASF) under one or more
pcoet commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523301162
##
File path: website/www/site/content/en/get-started/quickstart-java.md
##
@@ -283,7 +283,7 @@ We are working on adding the instruction for this runner!
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523300408
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523299584
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523299391
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523299244
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
apilloud commented on pull request #13340:
URL: https://github.com/apache/beam/pull/13340#issuecomment-727098604
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523298936
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,280 @@ use case.
{{< highlight py >}}
{{<
TheNeuralBit commented on a change in pull request #13128:
URL: https://github.com/apache/beam/pull/13128#discussion_r523294633
##
File path: website/www/site/content/en/get-started/quickstart-java.md
##
@@ -283,7 +283,7 @@ We are working on adding the instruction for this
TheNeuralBit commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-727093417
Looks like the flake is already filed as BEAM-7827
This is an automated message from the Apache Git
tysonjh commented on a change in pull request #13170:
URL: https://github.com/apache/beam/pull/13170#discussion_r523292482
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -79,6 +79,41 @@
`ReadFromBigQuery`, you can use the flag `use_json_exports` to export
hostirosti edited a comment on pull request #4080:
URL: https://github.com/apache/beam/pull/4080#issuecomment-727086784
Solution seems to be to use
```Java
options.setAwsRegion();
FileSystems.setDefaultPipelineOptions(options);
```
at runtime before using
hostirosti commented on pull request #4080:
URL: https://github.com/apache/beam/pull/4080#issuecomment-727086784
Solution seems to be to use
`FileSystems.setDefaultPipelineOptions(options);`
at runtime before using FileSystems.create(..)
TheNeuralBit opened a new pull request #13345:
URL: https://github.com/apache/beam/pull/13345
I haven't found evidence that this is the cause but I strongly suspect the
cause of the NPE on this line:
rohdesamuel commented on pull request #13215:
URL: https://github.com/apache/beam/pull/13215#issuecomment-727082892
R: @robertwb
This is an automated message from the Apache Git Service.
To respond to the message, please
rohdesamuel commented on pull request #13262:
URL: https://github.com/apache/beam/pull/13262#issuecomment-727082809
R: @pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log
tysonjh edited a comment on pull request #13259:
URL: https://github.com/apache/beam/pull/13259#issuecomment-727082642
Failed due to https://issues.apache.org/jira/browse/BEAM-11263 for which
I've made a fix in https://github.com/apache/beam/pull/13344.
All other tests pass. I'm not
tysonjh commented on pull request #13259:
URL: https://github.com/apache/beam/pull/13259#issuecomment-727082642
Failed due to https://issues.apache.org/jira/browse/BEAM-11263 for which
I've made a fix in https://github.com/apache/beam/pull/13344.
All other tests pass. I'm not going
tysonjh commented on pull request #13344:
URL: https://github.com/apache/beam/pull/13344#issuecomment-727082068
R: @boyuanzz
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tysonjh opened a new pull request #13344:
URL: https://github.com/apache/beam/pull/13344
Jenkins jobs were failing, rarely, when attempting to delete the container
image because the container was not removed first. This is likely due to a race
between shutting down the container and
aaltay commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-727081597
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-727081551
Java precommit - I think this is a flaky test :
"org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics".
@tysonjh @kennknowles - could we deflake
pcoet commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-727080918
Shakespeare is licensed! I'm not sure why "Run Java PreCommit" is failing...
This is an automated message from the
kennknowles commented on pull request #13311:
URL: https://github.com/apache/beam/pull/13311#issuecomment-727080429
Is there a way to reproduce the NPE in a Beam test?
This is an automated message from the Apache Git
kennknowles commented on pull request #13311:
URL: https://github.com/apache/beam/pull/13311#issuecomment-727080341
run java postcommit
This is an automated message from the Apache Git Service.
To respond to the message,
amaliujia commented on pull request #13339:
URL: https://github.com/apache/beam/pull/13339#issuecomment-727079850
thanks for this change!
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb commented on pull request #13343:
URL: https://github.com/apache/beam/pull/13343#issuecomment-727078781
R: @boyuanzz
This is an automated message from the Apache Git Service.
To respond to the message, please log
robertwb opened a new pull request #13343:
URL: https://github.com/apache/beam/pull/13343
These should be OK; avoid spamming the logs.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
boyuanzz merged pull request #13339:
URL: https://github.com/apache/beam/pull/13339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
boyuanzz commented on pull request #13339:
URL: https://github.com/apache/beam/pull/13339#issuecomment-727071689
Thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kennknowles merged pull request #13315:
URL: https://github.com/apache/beam/pull/13315
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kennknowles commented on pull request #13315:
URL: https://github.com/apache/beam/pull/13315#issuecomment-727070635
> Run Gradle Publish
I did not know that was an option!
This is an automated message from the Apache
TheNeuralBit commented on pull request #13340:
URL: https://github.com/apache/beam/pull/13340#issuecomment-727069687
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on a change in pull request #13342:
URL: https://github.com/apache/beam/pull/13342#discussion_r523262786
##
File path: sdks/java/build-tools/beam-linkage-check.sh
##
@@ -36,46 +36,60 @@ set -o pipefail
set -e
# These default artifacts are common
kennknowles commented on pull request #13342:
URL: https://github.com/apache/beam/pull/13342#issuecomment-727062832
R: @suztomo
Especially curious if you see the question about having a bash for loop vs
doing the linkage check on a list of artifacts. Do we need both?
tvalentyn closed pull request #13334:
URL: https://github.com/apache/beam/pull/13334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tvalentyn merged pull request #13316:
URL: https://github.com/apache/beam/pull/13316
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kennknowles commented on pull request #13311:
URL: https://github.com/apache/beam/pull/13311#issuecomment-727060995
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz merged pull request #13313:
URL: https://github.com/apache/beam/pull/13313
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
boyuanzz commented on pull request #13313:
URL: https://github.com/apache/beam/pull/13313#issuecomment-727060117
Thanks for your help!
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on pull request #13311:
URL: https://github.com/apache/beam/pull/13311#issuecomment-727060096
I fixed it in https://github.com/apache/beam/pull/13342. With those changes
I could run:
/bin/bash sdks/java/build-tools/beam-linkage-check.sh github/master
udim commented on pull request #13315:
URL: https://github.com/apache/beam/pull/13315#issuecomment-727059667
https://ci-beam.apache.org/job/beam_PostRelease_NightlySnapshot/1175/ is
successful
This is an automated message
TheNeuralBit merged pull request #13003:
URL: https://github.com/apache/beam/pull/13003
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523256644
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,282 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523255051
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,282 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523254273
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,282 @@ use case.
{{< highlight py >}}
{{<
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523252451
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,282 @@ use case.
{{< highlight py >}}
{{<
kennknowles commented on a change in pull request #13342:
URL: https://github.com/apache/beam/pull/13342#discussion_r523252500
##
File path: sdks/java/build-tools/beam-linkage-check.sh
##
@@ -36,46 +36,60 @@ set -o pipefail
set -e
# These default artifacts are common
kennknowles opened a new pull request #13342:
URL: https://github.com/apache/beam/pull/13342
This updates the beam linkage check script to be simpler to use and also
removes incorrect assumptions. Now you just pass the refs you want to compare
and that is that. A few minor fixes, too.
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523250127
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,282 @@ use case.
{{< highlight py >}}
{{<
tvalentyn commented on a change in pull request #13303:
URL: https://github.com/apache/beam/pull/13303#discussion_r523250343
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##
@@ -1212,6 +1213,22 @@ def get_ancestors(name):
return
rohdesamuel commented on pull request #13335:
URL: https://github.com/apache/beam/pull/13335#issuecomment-727051791
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523249222
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,282 @@ use case.
{{< highlight py >}}
{{<
amaliujia commented on a change in pull request #13319:
URL: https://github.com/apache/beam/pull/13319#discussion_r523246921
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigtable/BigtableRowToBeamRow.java
##
@@ -0,0
davidwrede commented on a change in pull request #13317:
URL: https://github.com/apache/beam/pull/13317#discussion_r523248814
##
File path: website/www/site/content/en/documentation/programming-guide.md
##
@@ -5431,4 +5431,282 @@ use case.
{{< highlight py >}}
{{<
tvalentyn commented on pull request #13303:
URL: https://github.com/apache/beam/pull/13303#issuecomment-727049909
> Will defer to your judgement.
Discussed offline, we can fix-forward and CP. Adverse behavior (if any)
should happen at pipeline launch, so this should not cause silent
1 - 100 of 199 matches
Mail list logo
