[GitHub] [beam] dennisylyung commented on pull request #14244: [BEAM-11907] SQS source with full functionality

2021-04-08 Thread GitBox
dennisylyung commented on pull request #14244: URL: https://github.com/apache/beam/pull/14244#issuecomment-816429265 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] m4r3x commented on pull request #10433: [BEAM-5192] Add support for Elasticsearch v7 in ElasticsearchIO

2021-04-08 Thread GitBox
m4r3x commented on pull request #10433: URL: https://github.com/apache/beam/pull/10433#issuecomment-816423342 > @echauchot > I know but it is just a deprecation for now in ES 7.0, types will be removed later on. > For backward compatibility reasons (address indexes created using ES <=

[GitHub] [beam] ihji commented on pull request #14492: [BEAM-12141] Print sha256 and size when downloading artifacts via art…

2021-04-08 Thread GitBox
ihji commented on pull request #14492: URL: https://github.com/apache/beam/pull/14492#issuecomment-816400044 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #14491: [BEAM-12140] Update artifact information when staging artifacts to gc…

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14491: URL: https://github.com/apache/beam/pull/14491#issuecomment-816389485 # [Codecov](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=h1) Report > Merging [#14491](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=desc) (7e7b4

[GitHub] [beam] ajamato commented on pull request #14493: [BEAM-11994] Update MetricsLogger, so that it does not reset the ProcessWide MetricsContainer.

2021-04-08 Thread GitBox
ajamato commented on pull request #14493: URL: https://github.com/apache/beam/pull/14493#issuecomment-816396005 R: @ihji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [beam] ajamato opened a new pull request #14493: [BEAM-11994] Update MetricsLogger, so that it does not reset the ProcessWide MetricsContainer.

2021-04-08 Thread GitBox
ajamato opened a new pull request #14493: URL: https://github.com/apache/beam/pull/14493 [BEAM-11994] Update MetricsLogger, so that it does not reset the ProcessWide MetricsContainer. This will clear legitimate process_wide metrics. Instead have the MetricsLogger calculate the delt

[GitHub] [beam] codecov[bot] edited a comment on pull request #14491: [BEAM-12140] Update artifact information when staging artifacts to gc…

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14491: URL: https://github.com/apache/beam/pull/14491#issuecomment-816389485 # [Codecov](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=h1) Report > Merging [#14491](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=desc) (7e7b4

[GitHub] [beam] tvalentyn merged pull request #14488: [BEAM-12128] replace usage of snippets_test_py3.py to snippets_test.py

2021-04-08 Thread GitBox
tvalentyn merged pull request #14488: URL: https://github.com/apache/beam/pull/14488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [beam] tvalentyn commented on pull request #14488: [BEAM-12128] replace usage of snippets_test_py3.py to snippets_test.py

2021-04-08 Thread GitBox
tvalentyn commented on pull request #14488: URL: https://github.com/apache/beam/pull/14488#issuecomment-816393546 Thanks for a quick fix, @lazylynx ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-815875872 # [Codecov](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=h1) Report > Merging [#14474](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=desc) (2cc97

[GitHub] [beam] codecov[bot] edited a comment on pull request #14491: [BEAM-12140] Update artifact information when staging artifacts to gc…

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14491: URL: https://github.com/apache/beam/pull/14491#issuecomment-816389485 # [Codecov](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=h1) Report > Merging [#14491](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=desc) (7e7b4

[GitHub] [beam] codecov[bot] commented on pull request #14491: [BEAM-12140] Update artifact information when staging artifacts to gc…

2021-04-08 Thread GitBox
codecov[bot] commented on pull request #14491: URL: https://github.com/apache/beam/pull/14491#issuecomment-816389485 # [Codecov](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=h1) Report > Merging [#14491](https://codecov.io/gh/apache/beam/pull/14491?src=pr&el=desc) (7e7b454) in

[GitHub] [beam] ihji opened a new pull request #14492: [BEAM-12141] Print sha256 and size when downloading artifacts via art…

2021-04-08 Thread GitBox
ihji opened a new pull request #14492: URL: https://github.com/apache/beam/pull/14492 …ifact retrieval service **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorpo

[GitHub] [beam] ihji commented on pull request #14491: [BEAM-12140] Update artifact information when staging artifacts to gc…

2021-04-08 Thread GitBox
ihji commented on pull request #14491: URL: https://github.com/apache/beam/pull/14491#issuecomment-816386014 R: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [beam] ihji opened a new pull request #14491: [BEAM-12140] Update artifact information when staging artifacts to gc…

2021-04-08 Thread GitBox
ihji opened a new pull request #14491: URL: https://github.com/apache/beam/pull/14491 …s for Dataflow **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] ajamato commented on pull request #14490: [BEAM-11994] Add HarnessMonitoringInfosRequest/Response InstructionRequest and MonitoringInfosMetadataRequest/Response support to Java

2021-04-08 Thread GitBox
ajamato commented on pull request #14490: URL: https://github.com/apache/beam/pull/14490#issuecomment-816383286 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] ajamato opened a new pull request #14490: [BEAM-11994] Add HarnessMonitoringInfosRequest/Response InstructionRequest and MonitoringInfosMetadataRequest/Response support to Java

2021-04-08 Thread GitBox
ajamato opened a new pull request #14490: URL: https://github.com/apache/beam/pull/14490 [BEAM-11994] Add HarnessMonitoringInfosRequest/Response InstructionRequest and MonitoringInfosMetadataRequest/Response support to Java SDK. - Adds InstructionRequest handler for MonitoringInfos

[GitHub] [beam] ajamato commented on pull request #14489: [BEAM-11994] Refactor BigQueryTornadoes to make more options parameterizable

2021-04-08 Thread GitBox
ajamato commented on pull request #14489: URL: https://github.com/apache/beam/pull/14489#issuecomment-816379370 R: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] ajamato opened a new pull request #14489: [BEAM-11994] Refactor BigQueryTornadoes to make more options parameterizable

2021-04-08 Thread GitBox
ajamato opened a new pull request #14489: URL: https://github.com/apache/beam/pull/14489 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.a

[GitHub] [beam] suztomo edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816372956 https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/3389/ got stuck at 22:53:00. ``` suztomo@apache-ci-beam-jenkins-11:~$ ps -ef |grep 'Gradle Test Executor

[GitHub] [beam] codecov[bot] edited a comment on pull request #14375: [DO NOT MERGE YET. WIP] BEAM-11994 - Add Java BigQuery IO Request Count metrics for insertAll API(AKA streaming_inserts)

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14375: URL: https://github.com/apache/beam/pull/14375#issuecomment-815419713 # [Codecov](https://codecov.io/gh/apache/beam/pull/14375?src=pr&el=h1) Report > Merging [#14375](https://codecov.io/gh/apache/beam/pull/14375?src=pr&el=desc) (8d2c3

[GitHub] [beam] codecov[bot] edited a comment on pull request #14375: [DO NOT MERGE YET. WIP] BEAM-11994 - Add Java BigQuery IO Request Count metrics for insertAll API(AKA streaming_inserts)

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14375: URL: https://github.com/apache/beam/pull/14375#issuecomment-815419713 # [Codecov](https://codecov.io/gh/apache/beam/pull/14375?src=pr&el=h1) Report > Merging [#14375](https://codecov.io/gh/apache/beam/pull/14375?src=pr&el=desc) (8d2c3

[GitHub] [beam] suztomo edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816372956 https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/3389/ got stuck at 22:53:00. ``` suztomo@apache-ci-beam-jenkins-11:~$ ps -ef |grep 'Gradle Test Executor

[GitHub] [beam] suztomo edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816372956 https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/3389/ got stuck at 22:53:00. ``` suztomo@apache-ci-beam-jenkins-11:~$ ps -ef |grep 'Gradle Test Executor

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816372956 https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/3389/ got stuck. ``` suztomo@apache-ci-beam-jenkins-11:~$ ps -ef |grep 'Gradle Test Executor' jenkins 4993

[GitHub] [beam] chamikaramj commented on pull request #14450: [BEAM-12040, BEAM-11934] Remove the option withRunnerDeterminedShardingUnboundedInternal; add a check for merging windows

2021-04-08 Thread GitBox
chamikaramj commented on pull request #14450: URL: https://github.com/apache/beam/pull/14450#issuecomment-816370089 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] chamikaramj commented on a change in pull request #14450: [BEAM-12040, BEAM-11934] Remove the option withRunnerDeterminedShardingUnboundedInternal; add a check for merging windows

2021-04-08 Thread GitBox
chamikaramj commented on a change in pull request #14450: URL: https://github.com/apache/beam/pull/14450#discussion_r610313872 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java ## @@ -349,15 +326,14 @@ public void validate(PipelineOptions options

[GitHub] [beam] pcoet commented on a change in pull request #14382: [WIP][BEAM-12074] Add @with_docs_from decorator for generating API docs

2021-04-08 Thread GitBox
pcoet commented on a change in pull request #14382: URL: https://github.com/apache/beam/pull/14382#discussion_r610300583 ## File path: sdks/python/apache_beam/dataframe/frame_base.py ## @@ -356,6 +374,85 @@ def wrapper(*args, **kwargs): return wrap +BEAM_SPECIFIC = "Diff

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816354832 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-815875872 # [Codecov](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=h1) Report > Merging [#14474](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=desc) (2cc97

[GitHub] [beam] lazylynx edited a comment on pull request #14488: [BEAM-12128] replace usage of snippets_test_py3.py to snippets_test.py

2021-04-08 Thread GitBox
lazylynx edited a comment on pull request #14488: URL: https://github.com/apache/beam/pull/14488#issuecomment-816338004 R: @tvalentyn CC: @emilymye -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816344098 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-815875872 # [Codecov](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=h1) Report > Merging [#14474](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=desc) (2cc97

[GitHub] [beam] lazylynx commented on pull request #14488: [BEAM-12128] replace usage of snippets_test_py3.py to snippets_test.py

2021-04-08 Thread GitBox
lazylynx commented on pull request #14488: URL: https://github.com/apache/beam/pull/14488#issuecomment-816338004 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] lazylynx opened a new pull request #14488: [BEAM-12128] replace usage of snippets_test_py3.py to snippets_test.py

2021-04-08 Thread GitBox
lazylynx opened a new pull request #14488: URL: https://github.com/apache/beam/pull/14488 Fixed reference to snippets_test_py3.py deleted at #1 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] ibzib commented on pull request #14483: [BEAM-11483] Spark PostCommit Test Improvements - creating one Jenkins job per Gradle task

2021-04-08 Thread GitBox
ibzib commented on pull request #14483: URL: https://github.com/apache/beam/pull/14483#issuecomment-816337591 cc @iemejia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [beam] ibzib commented on pull request #14483: [BEAM-11483] Spark PostCommit Test Improvements - creating one Jenkins job per Gradle task

2021-04-08 Thread GitBox
ibzib commented on pull request #14483: URL: https://github.com/apache/beam/pull/14483#issuecomment-816337282 It passes! Thanks Fernando. Can you please run `./gradlew spotlessApply` to fix the formatting? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (0651f

[GitHub] [beam] dennisylyung commented on pull request #14244: [BEAM-11907] SQS source with full functionality

2021-04-08 Thread GitBox
dennisylyung commented on pull request #14244: URL: https://github.com/apache/beam/pull/14244#issuecomment-816334092 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (0651f

[GitHub] [beam] lazylynx commented on pull request #14444: [BEAM-7372] cleanup codes for py2 compatibility from apache_beam/examples/snippets/*.py and apache_beam/examples/*.py

2021-04-08 Thread GitBox
lazylynx commented on pull request #1: URL: https://github.com/apache/beam/pull/1#issuecomment-816331186 @tvalentyn OK, I'll have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816329712 ? ``` 19:21:57 Error: Error building site: "/opt/website/www/site/content/en/documentation/sdks/python-type-safety.md:97:1": failed to render shortcode "highlight": fai

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (0651f

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (0651f

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816324677 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (0651f

[GitHub] [beam] benWize commented on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
benWize commented on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816321586 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] benWize commented on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
benWize commented on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816321312 run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] benWize removed a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
benWize removed a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816317768 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [beam] y1chi commented on a change in pull request #14197: [BEAM-11945] Add debug capture to SDK harness

2021-04-08 Thread GitBox
y1chi commented on a change in pull request #14197: URL: https://github.com/apache/beam/pull/14197#discussion_r610232124 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/status/BeamFnStatusClient.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on pull request #14487: [BEAM-12138] Fix groupby(level=) for values other than 0

2021-04-08 Thread GitBox
TheNeuralBit commented on pull request #14487: URL: https://github.com/apache/beam/pull/14487#issuecomment-816319933 R: @rohdesamuel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] TheNeuralBit commented on pull request #14487: [BEAM-12138] Fix groupby(level=) for values other than 0

2021-04-08 Thread GitBox
TheNeuralBit commented on pull request #14487: URL: https://github.com/apache/beam/pull/14487#issuecomment-816319063 Taken from #14438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] TheNeuralBit opened a new pull request #14487: [BEAM-11777] Fix groupby(level=) for values other than 0

2021-04-08 Thread GitBox
TheNeuralBit opened a new pull request #14487: URL: https://github.com/apache/beam/pull/14487 The current implementation of `groupby(level=)` doesn't properly handle arguments other than 0. This PR fixes that logic and adds test cases for other values of `level`. Post-Commit Tests S

[GitHub] [beam] benWize commented on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
benWize commented on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816317768 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (dedd6

[GitHub] [beam] y1chi commented on a change in pull request #14197: [BEAM-11945] Add debug capture to SDK harness

2021-04-08 Thread GitBox
y1chi commented on a change in pull request #14197: URL: https://github.com/apache/beam/pull/14197#discussion_r610202635 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/status/BeamFnStatusClient.java ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache

[GitHub] [beam] TheNeuralBit commented on pull request #14485: Misc sphinx fixes

2021-04-08 Thread GitBox
TheNeuralBit commented on pull request #14485: URL: https://github.com/apache/beam/pull/14485#issuecomment-816305309 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] boyuanzz commented on pull request #14419: [BEAM-12114] Eliminate beam_fn_api from KafkaIO expansion

2021-04-08 Thread GitBox
boyuanzz commented on pull request #14419: URL: https://github.com/apache/beam/pull/14419#issuecomment-816303492 Run Java KafkaIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] ibzib commented on pull request #14486: [DO NOT MERGE] Test PR #14483

2021-04-08 Thread GitBox
ibzib commented on pull request #14486: URL: https://github.com/apache/beam/pull/14486#issuecomment-816301778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (dedd6

[GitHub] [beam] codecov[bot] edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-815875872 # [Codecov](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=h1) Report > Merging [#14474](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=desc) (2cc97

[GitHub] [beam] codecov[bot] edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-815875872 # [Codecov](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=h1) Report > Merging [#14474](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=desc) (2cc97

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816296321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [beam] ibzib commented on pull request #14486: [DO NOT MERGE] Test PR #14483

2021-04-08 Thread GitBox
ibzib commented on pull request #14486: URL: https://github.com/apache/beam/pull/14486#issuecomment-816291369 run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] ibzib opened a new pull request #14486: [DO NOT MERGE] Test PR #14483

2021-04-08 Thread GitBox
ibzib opened a new pull request #14486: URL: https://github.com/apache/beam/pull/14486 …s job per Gradle task for the Spark streaming tests **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] TheNeuralBit opened a new pull request #14485: Misc sphinx fixes

2021-04-08 Thread GitBox
TheNeuralBit opened a new pull request #14485: URL: https://github.com/apache/beam/pull/14485 Broken up into three commits: - Change excluded paths to string literals (the original syntax doesn't work locally for me for some reason). - Add some new excluded paths. - Revert attempte

[GitHub] [beam] ibzib commented on pull request #14483: [BEAM-11483] Spark PostCommit Test Improvements - creating one Jenkins job per Gradle task

2021-04-08 Thread GitBox
ibzib commented on pull request #14483: URL: https://github.com/apache/beam/pull/14483#issuecomment-816286987 run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (dedd6

[GitHub] [beam] boyuanzz merged pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides

2021-04-08 Thread GitBox
boyuanzz merged pull request #14384: URL: https://github.com/apache/beam/pull/14384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [beam] ibzib commented on a change in pull request #14464: [BEAM-12123] Proactively reject unsupported types in Java UDFs.

2021-04-08 Thread GitBox
ibzib commented on a change in pull request #14464: URL: https://github.com/apache/beam/pull/14464#discussion_r610178548 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCatalog.java ## @@ -156,6 +159,48 @@ void

[GitHub] [beam] ibzib opened a new pull request #14484: [BEAM-10925] Add test for Java UDF with no return type.

2021-04-08 Thread GitBox
ibzib opened a new pull request #14484: URL: https://github.com/apache/beam/pull/14484 R: @apilloud Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s

[GitHub] [beam] ibzib commented on a change in pull request #14464: [BEAM-12123] Proactively reject unsupported types in Java UDFs.

2021-04-08 Thread GitBox
ibzib commented on a change in pull request #14464: URL: https://github.com/apache/beam/pull/14464#discussion_r610174784 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCatalog.java ## @@ -156,6 +159,48 @@ void

[GitHub] [beam] ibzib commented on pull request #14476: [BEAM-12009] Implement Calc splitting rule.

2021-04-08 Thread GitBox
ibzib commented on pull request #14476: URL: https://github.com/apache/beam/pull/14476#issuecomment-816277237 R: @apilloud cc: @amaliujia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] apilloud merged pull request #13930: [BEAM-9379] Simplify BeamCalcRel inputs

2021-04-08 Thread GitBox
apilloud merged pull request #13930: URL: https://github.com/apache/beam/pull/13930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [beam] TheNeuralBit merged pull request #14362: [BEAM-9547] Implementations for a few more DataFrame operations

2021-04-08 Thread GitBox
TheNeuralBit merged pull request #14362: URL: https://github.com/apache/beam/pull/14362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [beam] aaltay commented on pull request #14459: [BEAM-12137] docs: incremental --> patch

2021-04-08 Thread GitBox
aaltay commented on pull request #14459: URL: https://github.com/apache/beam/pull/14459#issuecomment-816276067 I do not remember the history. I also do not think this wording was chosen intentionally. I think this change makes sense. Adding @kennknowles in case he know if there is a

[GitHub] [beam] benWize commented on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
benWize commented on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816272017 Run Python Dataflow ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] benWize commented on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
benWize commented on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816271800 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (dedd6

[GitHub] [beam] codecov[bot] edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-815875872 # [Codecov](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=h1) Report > Merging [#14474](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=desc) (2cc97

[GitHub] [beam] codecov[bot] edited a comment on pull request #14456: [BEAM-8696] Cherry pick #14412 to release 2.29: protobuf-java to be in-line with libraries-bom 16.3.0

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14456: URL: https://github.com/apache/beam/pull/14456#issuecomment-814578396 # [Codecov](https://codecov.io/gh/apache/beam/pull/14456?src=pr&el=h1) Report > Merging [#14456](https://codecov.io/gh/apache/beam/pull/14456?src=pr&el=desc) (65c85

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816259899 Run Java Precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] suztomo commented on pull request #14456: [BEAM-8696] Cherry pick #14412 to release 2.29: protobuf-java to be in-line with libraries-bom 16.3.0

2021-04-08 Thread GitBox
suztomo commented on pull request #14456: URL: https://github.com/apache/beam/pull/14456#issuecomment-816259587 Run GoPortable PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] codecov[bot] edited a comment on pull request #14382: [WIP][BEAM-12074] Add @with_docs_from decorator for generating API docs

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14382: URL: https://github.com/apache/beam/pull/14382#issuecomment-810679126 # [Codecov](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=h1) Report > Merging [#14382](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=desc) (726ad

[GitHub] [beam] amaliujia merged pull request #14452: [BEAM-12112] Disable streaming mode for PORTABILITY_BATCH

2021-04-08 Thread GitBox
amaliujia merged pull request #14452: URL: https://github.com/apache/beam/pull/14452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [beam] melap commented on pull request #14459: docs: incremental --> patch

2021-04-08 Thread GitBox
melap commented on pull request #14459: URL: https://github.com/apache/beam/pull/14459#issuecomment-816244099 I don't know the history of this, but my concern would be that it seems that Beam's "incremental" is different from semver's "patch", as incremental is listed as forward compatible

[GitHub] [beam] codecov[bot] edited a comment on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-815875872 # [Codecov](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=h1) Report > Merging [#14474](https://codecov.io/gh/apache/beam/pull/14474?src=pr&el=desc) (2cc97

[GitHub] [beam] codecov[bot] edited a comment on pull request #14382: [WIP][BEAM-12074] Add @with_docs_from decorator for generating API docs

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14382: URL: https://github.com/apache/beam/pull/14382#issuecomment-810679126 # [Codecov](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=h1) Report > Merging [#14382](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=desc) (726ad

[GitHub] [beam] suztomo commented on pull request #14474: [BEAM-11227] Investigating Java Precommit timeout after gRPC upgrade

2021-04-08 Thread GitBox
suztomo commented on pull request #14474: URL: https://github.com/apache/beam/pull/14474#issuecomment-816224500 Run Java Precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #14382: [WIP][BEAM-12074] Add @with_docs_from decorator for generating API docs

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14382: URL: https://github.com/apache/beam/pull/14382#issuecomment-810679126 # [Codecov](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=h1) Report > Merging [#14382](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=desc) (726ad

[GitHub] [beam] fernando-wizeline opened a new pull request #14483: [BEAM-11483] Spark PostCommit Test Improvements - creating one Jenkins job per Gradle task

2021-04-08 Thread GitBox
fernando-wizeline opened a new pull request #14483: URL: https://github.com/apache/beam/pull/14483 The Gradle scripts were put into their own Jenkins job to avoid overloading the CI engine when running the tests. @ibzib, could you take a look at this? Thanks in advance! --

[GitHub] [beam] matthiasa4 commented on pull request #13642: [BEAM-11546] Cross-language pipeline pattern

2021-04-08 Thread GitBox
matthiasa4 commented on pull request #13642: URL: https://github.com/apache/beam/pull/13642#issuecomment-816196764 @aromanenko-dev Rebased & squashed, but some faults are flagged now - "file "code_samples/sdks_python_apache_beam_examples_snippets_snippets_test_py3.py" does not exist" - doe

[GitHub] [beam] TheNeuralBit commented on pull request #14382: [WIP][BEAM-12074] Add @with_docs_from decorator for generating API docs

2021-04-08 Thread GitBox
TheNeuralBit commented on pull request #14382: URL: https://github.com/apache/beam/pull/14382#issuecomment-816195866 R: @pcoet Could you review the text of the module-level and method-level docstrings I've added here? -- This is an automated message from the Apache Git Service. To re

[GitHub] [beam] codecov[bot] edited a comment on pull request #14481: [BEAM-3713] Moving integration tests from nose to pytest

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14481: URL: https://github.com/apache/beam/pull/14481#issuecomment-816167049 # [Codecov](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=h1) Report > Merging [#14481](https://codecov.io/gh/apache/beam/pull/14481?src=pr&el=desc) (dedd6

[GitHub] [beam] robertwb opened a new pull request #14482: [BEAM-6597] Use short id metric protocol for Java.

2021-04-08 Thread GitBox
robertwb opened a new pull request #14482: URL: https://github.com/apache/beam/pull/14482 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] codecov[bot] edited a comment on pull request #14382: [WIP][BEAM-12074] Add @with_docs_from decorator for generating API docs

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14382: URL: https://github.com/apache/beam/pull/14382#issuecomment-810679126 # [Codecov](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=h1) Report > Merging [#14382](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=desc) (e2676

[GitHub] [beam] codecov[bot] edited a comment on pull request #14382: [WIP][BEAM-12074] Add @with_docs_from decorator for generating API docs

2021-04-08 Thread GitBox
codecov[bot] edited a comment on pull request #14382: URL: https://github.com/apache/beam/pull/14382#issuecomment-810679126 # [Codecov](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=h1) Report > Merging [#14382](https://codecov.io/gh/apache/beam/pull/14382?src=pr&el=desc) (e2676

[GitHub] [beam] josiasrico commented on pull request #14477: Contribution Guide Improvement

2021-04-08 Thread GitBox
josiasrico commented on pull request #14477: URL: https://github.com/apache/beam/pull/14477#issuecomment-816186589 To open correct PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] josiasrico closed pull request #14477: Contribution Guide Improvement

2021-04-08 Thread GitBox
josiasrico closed pull request #14477: URL: https://github.com/apache/beam/pull/14477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [beam] boyuanzz commented on pull request #14384: [BEAM-10861] Change PubSubSource and PubSubSink translation to avoid special transform overrides

2021-04-08 Thread GitBox
boyuanzz commented on pull request #14384: URL: https://github.com/apache/beam/pull/14384#issuecomment-816185270 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

  1   2   3   4   >