[GitHub] [beam] aaltay removed a comment on pull request #14806: [BEAM-11289] [Python] Integrate Google Cloud Recommendations AI functionality

2021-06-02 Thread GitBox
aaltay removed a comment on pull request #14806: URL: https://github.com/apache/beam/pull/14806#issuecomment-853523045 > Recommendations AI Admin Done. Give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] aaltay commented on pull request #14806: [BEAM-11289] [Python] Integrate Google Cloud Recommendations AI functionality

2021-06-02 Thread GitBox
aaltay commented on pull request #14806: URL: https://github.com/apache/beam/pull/14806#issuecomment-853523142 > @aaltay - getting the following message in the console at the moment: `You don't have permission to set up a catalogue. Please get 'Owner' or 'Recommendations AI Admin' IAM role

[GitHub] [beam] aaltay commented on pull request #14806: [BEAM-11289] [Python] Integrate Google Cloud Recommendations AI functionality

2021-06-02 Thread GitBox
aaltay commented on pull request #14806: URL: https://github.com/apache/beam/pull/14806#issuecomment-853523045 > Recommendations AI Admin Done. Give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [beam] aaltay commented on pull request #14819: Update test_error_message_includes_stage test

2021-06-02 Thread GitBox
aaltay commented on pull request #14819: URL: https://github.com/apache/beam/pull/14819#issuecomment-853522550 > I really don't think we should be breaking the fusion here. The point of this test was that we implicated the right stage despite fusion. Should I revert it? -- This is

[GitHub] [beam] codecov[bot] edited a comment on pull request #14934: [BEAM-9547] Add support for `Series.cat` methods

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14934: URL: https://github.com/apache/beam/pull/14934#issuecomment-853437219 # [Codecov](https://codecov.io/gh/apache/beam/pull/14934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14398: URL: https://github.com/apache/beam/pull/14398#issuecomment-849991545 # [Codecov](https://codecov.io/gh/apache/beam/pull/14398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14934: [BEAM-9547] Add support for `Series.cat` methods

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14934: URL: https://github.com/apache/beam/pull/14934#issuecomment-853437219 # [Codecov](https://codecov.io/gh/apache/beam/pull/14934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14934: [BEAM-9547] Add support for `Series.cat` methods

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14934: URL: https://github.com/apache/beam/pull/14934#issuecomment-853437219 # [Codecov](https://codecov.io/gh/apache/beam/pull/14934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #14934: [BEAM-9547] Add support for `Series.cat` methods

2021-06-02 Thread GitBox
codecov[bot] commented on pull request #14934: URL: https://github.com/apache/beam/pull/14934#issuecomment-853437219 # [Codecov](https://codecov.io/gh/apache/beam/pull/14934?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] MiguelAnzoWizeline commented on a change in pull request #14586: [WIP][BEAM-8933] bigquery arrow

2021-06-02 Thread GitBox
MiguelAnzoWizeline commented on a change in pull request #14586: URL: https://github.com/apache/beam/pull/14586#discussion_r644373119 ## File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java ## @@ -1351,4

[GitHub] [beam] TheNeuralBit opened a new pull request #14934: [BEAM-9547] Add support for `Series.cat` methods

2021-06-02 Thread GitBox
TheNeuralBit opened a new pull request #14934: URL: https://github.com/apache/beam/pull/14934 Note the pandas doctests for categorical don't work well with our framework, so this is tested via `frames_test.py` `ValidatesRunner` compliance status (on master branch)

[GitHub] [beam] lukecwik commented on pull request #13387: Decode data channel elements after, rather than before, placing them in the queue.

2021-06-02 Thread GitBox
lukecwik commented on pull request #13387: URL: https://github.com/apache/beam/pull/13387#issuecomment-853430899 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For que

[GitHub] [beam] codecov[bot] edited a comment on pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14398: URL: https://github.com/apache/beam/pull/14398#issuecomment-849991545 # [Codecov](https://codecov.io/gh/apache/beam/pull/14398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on a change in pull request #14915: [BEAM-12104] Java WordCountIT (Dataflow runner) on Ubuntu 20.04 GHA image

2021-06-02 Thread GitBox
TheNeuralBit commented on a change in pull request #14915: URL: https://github.com/apache/beam/pull/14915#discussion_r644346956 ## File path: .github/workflows/java_tests.yml ## @@ -162,6 +160,15 @@ jobs: service_account_key: ${{ secrets.GCP_SA_KEY }} proj

[GitHub] [beam] codecov[bot] edited a comment on pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14398: URL: https://github.com/apache/beam/pull/14398#issuecomment-849991545 # [Codecov](https://codecov.io/gh/apache/beam/pull/14398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14398: URL: https://github.com/apache/beam/pull/14398#issuecomment-849991545 # [Codecov](https://codecov.io/gh/apache/beam/pull/14398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] kw2542 commented on pull request #14923: [BEAM-12419] Add Timeout and WaitForReady support in java gRPC calls

2021-06-02 Thread GitBox
kw2542 commented on pull request #14923: URL: https://github.com/apache/beam/pull/14923#issuecomment-853405694 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] codecov[bot] edited a comment on pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14398: URL: https://github.com/apache/beam/pull/14398#issuecomment-849991545 # [Codecov](https://codecov.io/gh/apache/beam/pull/14398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
TheNeuralBit commented on pull request #14398: URL: https://github.com/apache/beam/pull/14398#issuecomment-853403946 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853345427 # [Codecov](https://codecov.io/gh/apache/beam/pull/14924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] lostluck commented on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
lostluck commented on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853403725 The java precommit is failing with ``` > Task :sdks:java:io:elasticsearch-tests:elasticsearch-tests-5:test org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTes

[GitHub] [beam] codecov[bot] edited a comment on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853345427 # [Codecov](https://codecov.io/gh/apache/beam/pull/14924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on a change in pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
TheNeuralBit commented on a change in pull request #14398: URL: https://github.com/apache/beam/pull/14398#discussion_r644335507 ## File path: sdks/python/apache_beam/examples/dataframe/flight_delays.py ## @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [beam] TheNeuralBit commented on a change in pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
TheNeuralBit commented on a change in pull request #14398: URL: https://github.com/apache/beam/pull/14398#discussion_r644335342 ## File path: sdks/python/apache_beam/examples/dataframe/README.md ## @@ -143,3 +143,40 @@ Queens,81138 Staten Island,531 Unknown,28527 ``` + +## F

[GitHub] [beam] codecov[bot] edited a comment on pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14398: URL: https://github.com/apache/beam/pull/14398#issuecomment-849991545 # [Codecov](https://codecov.io/gh/apache/beam/pull/14398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on a change in pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
TheNeuralBit commented on a change in pull request #14398: URL: https://github.com/apache/beam/pull/14398#discussion_r644334392 ## File path: sdks/python/apache_beam/examples/dataframe/flight_delays_it_test.py ## @@ -0,0 +1,138 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the

[GitHub] [beam] pabloem merged pull request #14902: Twitter redesign to move the component to it's separate project.

2021-06-02 Thread GitBox
pabloem merged pull request #14902: URL: https://github.com/apache/beam/pull/14902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [beam] usingh83 commented on a change in pull request #14902: Twitter redesign to move the component to it's separate project.

2021-06-02 Thread GitBox
usingh83 commented on a change in pull request #14902: URL: https://github.com/apache/beam/pull/14902#discussion_r644270760 ## File path: examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/README.md ## @@ -34,6 +34,7 @@ This directory contains

[GitHub] [beam] usingh83 commented on a change in pull request #14902: Twitter redesign to move the component to it's separate project.

2021-06-02 Thread GitBox
usingh83 commented on a change in pull request #14902: URL: https://github.com/apache/beam/pull/14902#discussion_r644270760 ## File path: examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/README.md ## @@ -34,6 +34,7 @@ This directory contains

[GitHub] [beam] lostluck commented on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
lostluck commented on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853380727 The go postcommit had no failures (the jobs succeeded) but they did fail to contact the dataflow backend, so I'm rerunning. -- This is an automated message from the Apache Gi

[GitHub] [beam] egalpin commented on pull request #14933: [BEAM-12421] Migrates ElasticsearchIOTest to use testContainers

2021-06-02 Thread GitBox
egalpin commented on pull request #14933: URL: https://github.com/apache/beam/pull/14933#issuecomment-853380572 Looks like I need to modify the waitStrategy a bit more so these tests don't flake -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] lostluck commented on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
lostluck commented on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853380314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [beam] iemejia commented on a change in pull request #14858: [BEAM-12385] Handle VARCHAR and Date-time JDBC specific logical types in AvroUtils.

2021-06-02 Thread GitBox
iemejia commented on a change in pull request #14858: URL: https://github.com/apache/beam/pull/14858#discussion_r644308777 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java ## @@ -906,6 +906,23 @@ private void readObject(ObjectInputStr

[GitHub] [beam] iemejia commented on a change in pull request #14858: [BEAM-12385] Handle VARCHAR and Date-time JDBC specific logical types in AvroUtils.

2021-06-02 Thread GitBox
iemejia commented on a change in pull request #14858: URL: https://github.com/apache/beam/pull/14858#discussion_r644308777 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java ## @@ -906,6 +906,23 @@ private void readObject(ObjectInputStr

[GitHub] [beam] codecov[bot] edited a comment on pull request #14922: [BEAM-9547] Add support for `DataFrame.value_counts()`

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14922: URL: https://github.com/apache/beam/pull/14922#issuecomment-853279583 # [Codecov](https://codecov.io/gh/apache/beam/pull/14922?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] ibzib commented on a change in pull request #14398: [BEAM-12024] Add flight delay groupby.apply example

2021-06-02 Thread GitBox
ibzib commented on a change in pull request #14398: URL: https://github.com/apache/beam/pull/14398#discussion_r644279752 ## File path: sdks/python/apache_beam/examples/dataframe/README.md ## @@ -143,3 +143,40 @@ Queens,81138 Staten Island,531 Unknown,28527 ``` + +## Flight D

[GitHub] [beam] codecov[bot] edited a comment on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853345427 # [Codecov](https://codecov.io/gh/apache/beam/pull/14924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853345427 # [Codecov](https://codecov.io/gh/apache/beam/pull/14924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853345427 # [Codecov](https://codecov.io/gh/apache/beam/pull/14924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14922: [BEAM-9547] Add support for `DataFrame.value_counts()`

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14922: URL: https://github.com/apache/beam/pull/14922#issuecomment-853279583 # [Codecov](https://codecov.io/gh/apache/beam/pull/14922?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
codecov[bot] commented on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853345427 # [Codecov](https://codecov.io/gh/apache/beam/pull/14924?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on pull request #14922: [BEAM-9547] Add support for `DataFrame.value_counts()`

2021-06-02 Thread GitBox
TheNeuralBit commented on pull request #14922: URL: https://github.com/apache/beam/pull/14922#issuecomment-853343160 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] codecov[bot] edited a comment on pull request #14932: Log the BigQuery job id when logging its status

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14932: URL: https://github.com/apache/beam/pull/14932#issuecomment-853326119 # [Codecov](https://codecov.io/gh/apache/beam/pull/14932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] lostluck commented on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
lostluck commented on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853339650 R: @youngoli for Go @TheNeuralBit for the Schema proto change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] lostluck commented on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
lostluck commented on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853339301 Run Go PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] MaksymSkorupskyi commented on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
MaksymSkorupskyi commented on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-853338073 > ./gradlew :sdks:python:test-suites:tox:py37:lintPy37 Oh nice, thank you. I missed this point -- This is an automated message from the Apache Git Service. To re

[GitHub] [beam] codecov[bot] edited a comment on pull request #14931: Fix spelling error when starting BigQuery jobs

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14931: URL: https://github.com/apache/beam/pull/14931#issuecomment-853322822 # [Codecov](https://codecov.io/gh/apache/beam/pull/14931?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14930: [BEAM-12444] Fix bug when groupby.apply is used on a series grouped by a callable

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14930: URL: https://github.com/apache/beam/pull/14930#issuecomment-853240417 # [Codecov](https://codecov.io/gh/apache/beam/pull/14930?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] egalpin commented on pull request #14933: [BEAM-12421] Migrates ElasticsearchIOTest to use testContainers

2021-06-02 Thread GitBox
egalpin commented on pull request #14933: URL: https://github.com/apache/beam/pull/14933#issuecomment-853335619 R: @aromanenko-dev @timrobertson100 @ludovic-boutros -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [beam] y1chi commented on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
y1chi commented on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-853335490 you can use `./gradlew :sdks:python:test-suites:tox:py37:lintPy37` in your beam folder to test the lint locally -- This is an automated message from the Apache Git Service. To re

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] usingh83 commented on a change in pull request #14902: Twitter redesign to move the component to it's separate project.

2021-06-02 Thread GitBox
usingh83 commented on a change in pull request #14902: URL: https://github.com/apache/beam/pull/14902#discussion_r644270760 ## File path: examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/README.md ## @@ -34,6 +34,7 @@ This directory contains

[GitHub] [beam] codecov[bot] edited a comment on pull request #14929: [WIP][BEAM-9547] Add support for `Series.value_counts()`, add back the ability to group by a Series

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14929: URL: https://github.com/apache/beam/pull/14929#issuecomment-853319940 # [Codecov](https://codecov.io/gh/apache/beam/pull/14929?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14932: Log the BigQuery job id when logging its status

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14932: URL: https://github.com/apache/beam/pull/14932#issuecomment-853326119 # [Codecov](https://codecov.io/gh/apache/beam/pull/14932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] lostluck commented on pull request #14924: [BEAM-12438] Add Regression test for issue around LP coding Row coders.

2021-06-02 Thread GitBox
lostluck commented on pull request #14924: URL: https://github.com/apache/beam/pull/14924#issuecomment-853332847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [beam] egalpin opened a new pull request #14933: [BEAM-12421] Migrates ElasticsearchIOTest to use testContainers

2021-06-02 Thread GitBox
egalpin opened a new pull request #14933: URL: https://github.com/apache/beam/pull/14933 Tackles the migration of ElasticsearchIOTest from in mem Elasticsearch emulator to using test containers instead. This PR also drops testing support for Elasticsearch 2.x which was previously agreed to

[GitHub] [beam] codecov[bot] edited a comment on pull request #14723: [BEAM-12272] Python - Backport Firestore connector's ramp-up throttling to Datastore connector

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14723: URL: https://github.com/apache/beam/pull/14723#issuecomment-832165414 # [Codecov](https://codecov.io/gh/apache/beam/pull/14723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14929: [WIP][BEAM-9547] Add support for `Series.value_counts()`, add back the ability to group by a Series

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14929: URL: https://github.com/apache/beam/pull/14929#issuecomment-853319940 # [Codecov](https://codecov.io/gh/apache/beam/pull/14929?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14876: [BEAM-12074][WIP] Define docstrings for all DataFrame operations

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14876: URL: https://github.com/apache/beam/pull/14876#issuecomment-848079994 # [Codecov](https://codecov.io/gh/apache/beam/pull/14876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14931: Fix spelling error when starting BigQuery jobs

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14931: URL: https://github.com/apache/beam/pull/14931#issuecomment-853322822 # [Codecov](https://codecov.io/gh/apache/beam/pull/14931?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14931: Fix spelling error when starting BigQuery jobs

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14931: URL: https://github.com/apache/beam/pull/14931#issuecomment-853322822 # [Codecov](https://codecov.io/gh/apache/beam/pull/14931?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #14932: Log the BigQuery job id when logging its status

2021-06-02 Thread GitBox
codecov[bot] commented on pull request #14932: URL: https://github.com/apache/beam/pull/14932#issuecomment-853326119 # [Codecov](https://codecov.io/gh/apache/beam/pull/14932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #14931: Fix spelling error when starting BigQuery jobs

2021-06-02 Thread GitBox
codecov[bot] commented on pull request #14931: URL: https://github.com/apache/beam/pull/14931#issuecomment-853322822 # [Codecov](https://codecov.io/gh/apache/beam/pull/14931?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] codecov[bot] edited a comment on pull request #14930: [BEAM-12444] Fix bug when groupby.apply is used on a series grouped by a callable

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14930: URL: https://github.com/apache/beam/pull/14930#issuecomment-853240417 # [Codecov](https://codecov.io/gh/apache/beam/pull/14930?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14920: [WIP][BEAM-11534] Add transform implementation

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14920: URL: https://github.com/apache/beam/pull/14920#issuecomment-853307112 # [Codecov](https://codecov.io/gh/apache/beam/pull/14920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14876: [BEAM-12074][WIP] Define docstrings for all DataFrame operations

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14876: URL: https://github.com/apache/beam/pull/14876#issuecomment-848079994 # [Codecov](https://codecov.io/gh/apache/beam/pull/14876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #14929: [WIP][BEAM-9547] Add support for `Series.value_counts()`, add back the ability to group by a Series

2021-06-02 Thread GitBox
codecov[bot] commented on pull request #14929: URL: https://github.com/apache/beam/pull/14929#issuecomment-853319940 # [Codecov](https://codecov.io/gh/apache/beam/pull/14929?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] benWize commented on a change in pull request #14915: [BEAM-12104] Java WordCountIT (Dataflow runner) on Ubuntu 20.04 GHA image

2021-06-02 Thread GitBox
benWize commented on a change in pull request #14915: URL: https://github.com/apache/beam/pull/14915#discussion_r644253241 ## File path: .github/workflows/java_tests.yml ## @@ -162,6 +160,15 @@ jobs: service_account_key: ${{ secrets.GCP_SA_KEY }} project_i

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14876: [BEAM-12074][WIP] Define docstrings for all DataFrame operations

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14876: URL: https://github.com/apache/beam/pull/14876#issuecomment-848079994 # [Codecov](https://codecov.io/gh/apache/beam/pull/14876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14876: [BEAM-12074][WIP] Define docstrings for all DataFrame operations

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14876: URL: https://github.com/apache/beam/pull/14876#issuecomment-848079994 # [Codecov](https://codecov.io/gh/apache/beam/pull/14876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14723: [BEAM-12272] Python - Backport Firestore connector's ramp-up throttling to Datastore connector

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14723: URL: https://github.com/apache/beam/pull/14723#issuecomment-832165414 # [Codecov](https://codecov.io/gh/apache/beam/pull/14723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14920: [WIP][BEAM-11534] Add transform implementation

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14920: URL: https://github.com/apache/beam/pull/14920#issuecomment-853307112 # [Codecov](https://codecov.io/gh/apache/beam/pull/14920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] kw2542 commented on pull request #14923: [BEAM-12419] Add Timeout and WaitForReady support in java gRPC calls

2021-06-02 Thread GitBox
kw2542 commented on pull request #14923: URL: https://github.com/apache/beam/pull/14923#issuecomment-853313112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14795: [BEAM-3713] Move PerformanceTest and CrossLanguageValidateRunner from nosetest to pytest

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14795: URL: https://github.com/apache/beam/pull/14795#issuecomment-839974622 # [Codecov](https://codecov.io/gh/apache/beam/pull/14795?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14723: [BEAM-12272] Python - Backport Firestore connector's ramp-up throttling to Datastore connector

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14723: URL: https://github.com/apache/beam/pull/14723#issuecomment-832165414 # [Codecov](https://codecov.io/gh/apache/beam/pull/14723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] robertwb commented on pull request #14819: Update test_error_message_includes_stage test

2021-06-02 Thread GitBox
robertwb commented on pull request #14819: URL: https://github.com/apache/beam/pull/14819#issuecomment-853308807 I really don't think we should be breaking the fusion here. The point of this test was that we implicated the right stage despite fusion. -- This is an automated message from

[GitHub] [beam] codecov[bot] edited a comment on pull request #14723: [BEAM-12272] Python - Backport Firestore connector's ramp-up throttling to Datastore connector

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14723: URL: https://github.com/apache/beam/pull/14723#issuecomment-832165414 # [Codecov](https://codecov.io/gh/apache/beam/pull/14723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14920: [WIP][BEAM-11534] Add transform implementation

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14920: URL: https://github.com/apache/beam/pull/14920#issuecomment-853307112 # [Codecov](https://codecov.io/gh/apache/beam/pull/14920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #14920: [WIP][BEAM-11534] Add transform implementation

2021-06-02 Thread GitBox
codecov[bot] commented on pull request #14920: URL: https://github.com/apache/beam/pull/14920#issuecomment-853307112 # [Codecov](https://codecov.io/gh/apache/beam/pull/14920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] codecov[bot] edited a comment on pull request #14460: [BEAM-12119] [BEAM-12122] Add integer and string `_id` keys support to Python IO MongoDB

2021-06-02 Thread GitBox
codecov[bot] edited a comment on pull request #14460: URL: https://github.com/apache/beam/pull/14460#issuecomment-822457010 # [Codecov](https://codecov.io/gh/apache/beam/pull/14460?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] ajamato commented on pull request #14932: Log the BigQuery job id when logging its status

2021-06-02 Thread GitBox
ajamato commented on pull request #14932: URL: https://github.com/apache/beam/pull/14932#issuecomment-853304982 R: @chamikaramj PTAL and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] ajamato opened a new pull request #14932: Log the BigQuery job id when logging its status

2021-06-02 Thread GitBox
ajamato opened a new pull request #14932: URL: https://github.com/apache/beam/pull/14932 Log the BigQuery job id when logging its status Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  1   2   >