[GitHub] [beam] pabloem commented on pull request #15784: [BEAM-8135] - Removing BigQueryResultsPublisher and its references

2021-11-02 Thread GitBox
pabloem commented on pull request #15784: URL: https://github.com/apache/beam/pull/15784#issuecomment-958684971 I copied the PR here: https://github.com/apache/beam/pull/15877 seems like jobs that I trigger in that PR show up here as well -- This is an automated message from the Ap

[GitHub] [beam] pabloem opened a new pull request #15877: Pr 15784

2021-11-02 Thread GitBox
pabloem opened a new pull request #15877: URL: https://github.com/apache/beam/pull/15877 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickl

[GitHub] [beam] pabloem commented on pull request #15877: Pr 15784

2021-11-02 Thread GitBox
pabloem commented on pull request #15877: URL: https://github.com/apache/beam/pull/15877#issuecomment-958684666 Run Seed Job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] youngoli commented on a change in pull request #15849: [BEAM-3811] Code clean-up of the CancelleableQueue to not throw InterruptedException on cancel/reset since we are never stuck in

2021-11-02 Thread GitBox
youngoli commented on a change in pull request #15849: URL: https://github.com/apache/beam/pull/15849#discussion_r741625279 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/stream/BufferingStreamObserver.java ## @@ -73,94 +83,58 @@ private void drainQu

[GitHub] [beam] reuvenlax commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
reuvenlax commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741628071 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteRecordsInconsistent.java ## @@ -0,0 +1

[GitHub] [beam] codecov[bot] edited a comment on pull request #15742: [BEAM-11936] Fix errorprone warnings

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15742: URL: https://github.com/apache/beam/pull/15742#issuecomment-946074511 # [Codecov](https://codecov.io/gh/apache/beam/pull/15742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] reuvenlax commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
reuvenlax commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741613910 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteRecordsInconsistent.java ## @@ -0,0 +1

[GitHub] [beam] codecov[bot] edited a comment on pull request #15742: [BEAM-11936] Fix errorprone warnings

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15742: URL: https://github.com/apache/beam/pull/15742#issuecomment-946074511 # [Codecov](https://codecov.io/gh/apache/beam/pull/15742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] hlake21 commented on a change in pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
hlake21 commented on a change in pull request #15825: URL: https://github.com/apache/beam/pull/15825#discussion_r741601550 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java ## @@ -232,7 +238,7 @@ private Pending

[GitHub] [beam] codecov[bot] edited a comment on pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15825: URL: https://github.com/apache/beam/pull/15825#issuecomment-958518538 # [Codecov](https://codecov.io/gh/apache/beam/pull/15825?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
pabloem commented on pull request #15810: URL: https://github.com/apache/beam/pull/15810#issuecomment-958630425 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] pabloem commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
pabloem commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741596774 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryOptions.java ## @@ -85,6 +85,13 @@ void se

[GitHub] [beam] codecov[bot] edited a comment on pull request #15742: [BEAM-11936] Fix errorprone warnings

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15742: URL: https://github.com/apache/beam/pull/15742#issuecomment-946074511 # [Codecov](https://codecov.io/gh/apache/beam/pull/15742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15742: [BEAM-11936] Fix errorprone warnings

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15742: URL: https://github.com/apache/beam/pull/15742#issuecomment-946074511 # [Codecov](https://codecov.io/gh/apache/beam/pull/15742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
pabloem commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741594790 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteRecordsInconsistent.java ## @@ -0,0 +1,2

[GitHub] [beam] codecov[bot] edited a comment on pull request #15742: [BEAM-11936] Fix errorprone warnings

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15742: URL: https://github.com/apache/beam/pull/15742#issuecomment-946074511 # [Codecov](https://codecov.io/gh/apache/beam/pull/15742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15742: [BEAM-11936] Fix errorprone warnings

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15742: URL: https://github.com/apache/beam/pull/15742#issuecomment-946074511 # [Codecov](https://codecov.io/gh/apache/beam/pull/15742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
pabloem commented on pull request #15825: URL: https://github.com/apache/beam/pull/15825#issuecomment-958609997 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] reuvenlax commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
reuvenlax commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741580687 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/FakeDatasetService.java ## @@ -249,7 +254,21 @@ public

[GitHub] [beam] reuvenlax commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
reuvenlax commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741580524 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteRecordsInconsistent.java ## @@ -0,0 +1

[GitHub] [beam] codecov[bot] edited a comment on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958010789 # [Codecov](https://codecov.io/gh/apache/beam/pull/15869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] reuvenlax commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
reuvenlax commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741577685 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteRecordsInconsistent.java ## @@ -0,0 +1

[GitHub] [beam] reuvenlax commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
reuvenlax commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741575360 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryOptions.java ## @@ -85,6 +85,13 @@ void

[GitHub] [beam] codecov[bot] edited a comment on pull request #15673: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15673: URL: https://github.com/apache/beam/pull/15673#issuecomment-937320655 # [Codecov](https://codecov.io/gh/apache/beam/pull/15673?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15876: [BEAM-13169] Add a beam protocol MONITORING_INFOS_METADATA for denoti…

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15876: URL: https://github.com/apache/beam/pull/15876#issuecomment-958407529 # [Codecov](https://codecov.io/gh/apache/beam/pull/15876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] ibzib commented on pull request #15673: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2021-11-02 Thread GitBox
ibzib commented on pull request #15673: URL: https://github.com/apache/beam/pull/15673#issuecomment-958578108 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958010789 # [Codecov](https://codecov.io/gh/apache/beam/pull/15869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15410: URL: https://github.com/apache/beam/pull/15410#issuecomment-907330752 # [Codecov](https://codecov.io/gh/apache/beam/pull/15410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] chamikaramj commented on a change in pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-02 Thread GitBox
chamikaramj commented on a change in pull request #15857: URL: https://github.com/apache/beam/pull/15857#discussion_r741540490 ## File path: sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/JavaClassLookupTransformProvider.java ## @@ -508,12 +523

[GitHub] [beam] codecov[bot] edited a comment on pull request #15866: remove unused future / futures dependencies

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15866: URL: https://github.com/apache/beam/pull/15866#issuecomment-958488152 # [Codecov](https://codecov.io/gh/apache/beam/pull/15866?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo commented on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
suztomo commented on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958522967 Run Java_Examples_Dataflow PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] suztomo commented on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
suztomo commented on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958522563 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] tvalentyn commented on a change in pull request #15472: Add cloudpickle as optional library

2021-11-02 Thread GitBox
tvalentyn commented on a change in pull request #15472: URL: https://github.com/apache/beam/pull/15472#discussion_r741549429 ## File path: sdks/python/container/base_image_requirements.txt ## @@ -26,6 +26,7 @@ # TODO(AVRO-2429): Upgrade to >= 1.9.0 only after resolved avro-py

[GitHub] [beam] tvalentyn commented on pull request #15472: Add cloudpickle as optional library

2021-11-02 Thread GitBox
tvalentyn commented on pull request #15472: URL: https://github.com/apache/beam/pull/15472#issuecomment-958518644 Looks like there are a few errors in the suites: ``` 2:32:13 > Task :sdks:python:test-suites:portable:py36:portableWordCountFlinkRunnerBatch FAILED 12:32:13 Traceba

[GitHub] [beam] codecov[bot] commented on pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
codecov[bot] commented on pull request #15825: URL: https://github.com/apache/beam/pull/15825#issuecomment-958518538 # [Codecov](https://codecov.io/gh/apache/beam/pull/15825?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] tvalentyn commented on pull request #15472: Add cloudpickle as optional library

2021-11-02 Thread GitBox
tvalentyn commented on pull request #15472: URL: https://github.com/apache/beam/pull/15472#issuecomment-958510528 I think Run Unit Tests is not a valid trigger command, tests run by themselves when you push new changes. Github action tests don't have trigger commands, but could be re-trigg

[GitHub] [beam] tvalentyn commented on a change in pull request #15472: Add cloudpickle as optional library

2021-11-02 Thread GitBox
tvalentyn commented on a change in pull request #15472: URL: https://github.com/apache/beam/pull/15472#discussion_r741381969 ## File path: sdks/python/apache_beam/coders/coders_test_common.py ## @@ -680,14 +682,14 @@ def iterable_state_read(token, element_coder_impl): cont

[GitHub] [beam] codecov[bot] commented on pull request #15866: remove unused future / futures dependencies

2021-11-02 Thread GitBox
codecov[bot] commented on pull request #15866: URL: https://github.com/apache/beam/pull/15866#issuecomment-958488152 # [Codecov](https://codecov.io/gh/apache/beam/pull/15866?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] KevinGG commented on a change in pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
KevinGG commented on a change in pull request #15825: URL: https://github.com/apache/beam/pull/15825#discussion_r741543285 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java ## @@ -232,7 +238,7 @@ private Pending

[GitHub] [beam] codecov[bot] edited a comment on pull request #15876: [BEAM-13169] Add a beam protocol MONITORING_INFOS_METADATA for denoti…

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15876: URL: https://github.com/apache/beam/pull/15876#issuecomment-958407529 # [Codecov](https://codecov.io/gh/apache/beam/pull/15876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] hlake21 commented on a change in pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
hlake21 commented on a change in pull request #15825: URL: https://github.com/apache/beam/pull/15825#discussion_r741536325 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java ## @@ -232,7 +238,7 @@ private Pending

[GitHub] [beam] codecov[bot] edited a comment on pull request #15876: [BEAM-13169] Add a beam protocol MONITORING_INFOS_METADATA for denoti…

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15876: URL: https://github.com/apache/beam/pull/15876#issuecomment-958407529 # [Codecov](https://codecov.io/gh/apache/beam/pull/15876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15410: URL: https://github.com/apache/beam/pull/15410#issuecomment-907330752 # [Codecov](https://codecov.io/gh/apache/beam/pull/15410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #15876: [BEAM-13169] Add a beam protocol MONITORING_INFOS_METADATA for denoti…

2021-11-02 Thread GitBox
codecov[bot] commented on pull request #15876: URL: https://github.com/apache/beam/pull/15876#issuecomment-958407529 # [Codecov](https://codecov.io/gh/apache/beam/pull/15876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] codecov[bot] edited a comment on pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15410: URL: https://github.com/apache/beam/pull/15410#issuecomment-907330752 # [Codecov](https://codecov.io/gh/apache/beam/pull/15410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] AlikRodriguez commented on a change in pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
AlikRodriguez commented on a change in pull request #15410: URL: https://github.com/apache/beam/pull/15410#discussion_r741513223 ## File path: sdks/python/apache_beam/typehints/schemas.py ## @@ -285,6 +285,21 @@ def _hydrate_namedtuple_instance(encoded_schema, values): p

[GitHub] [beam] AlikRodriguez commented on a change in pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
AlikRodriguez commented on a change in pull request #15410: URL: https://github.com/apache/beam/pull/15410#discussion_r741513115 ## File path: model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml ## @@ -409,6 +409,40 @@ examples:

[GitHub] [beam] AlikRodriguez commented on a change in pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
AlikRodriguez commented on a change in pull request #15410: URL: https://github.com/apache/beam/pull/15410#discussion_r741512913 ## File path: sdks/python/apache_beam/coders/row_coder.py ## @@ -182,7 +188,6 @@ def encode_to_stream(self, value, out, nested): words[i /

[GitHub] [beam] AlikRodriguez commented on a change in pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
AlikRodriguez commented on a change in pull request #15410: URL: https://github.com/apache/beam/pull/15410#discussion_r741512749 ## File path: sdks/python/apache_beam/coders/row_coder.py ## @@ -164,7 +164,13 @@ class RowCoderImpl(StreamCoderImpl): def __init__(self, schema,

[GitHub] [beam] codecov[bot] edited a comment on pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15410: URL: https://github.com/apache/beam/pull/15410#issuecomment-907330752 # [Codecov](https://codecov.io/gh/apache/beam/pull/15410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] tvalentyn commented on pull request #15864: [BEAM-12730] Python. Custom delimiter add corner case

2021-11-02 Thread GitBox
tvalentyn commented on pull request #15864: URL: https://github.com/apache/beam/pull/15864#issuecomment-958296457 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] tvalentyn merged pull request #15864: [BEAM-12730] Python. Custom delimiter add corner case

2021-11-02 Thread GitBox
tvalentyn merged pull request #15864: URL: https://github.com/apache/beam/pull/15864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] y1chi opened a new pull request #15876: [BEAM-13169] Add a beam protocol MONITORING_INFOS_METADATA for denoti…

2021-11-02 Thread GitBox
y1chi opened a new pull request #15876: URL: https://github.com/apache/beam/pull/15876 …ng SDK capability of handling metric short id. **Please** add a meaningful description for your change here Thank you for your contribution! Follow this check

[GitHub] [beam] fernando-wizeline commented on pull request #15784: [BEAM-8135] - Removing BigQueryResultsPublisher and its references

2021-11-02 Thread GitBox
fernando-wizeline commented on pull request #15784: URL: https://github.com/apache/beam/pull/15784#issuecomment-958290032 > LoadTestConfig > Publish to BQ seems to exist in several places in this file: https://github.com/apache/beam/blob/master/.test-infra/jenkins/LoadTestCon

[GitHub] [beam] codecov[bot] edited a comment on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958010789 # [Codecov](https://codecov.io/gh/apache/beam/pull/15869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15751: [BEAM-12939][Playground] Backend app - Docker container

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15751: URL: https://github.com/apache/beam/pull/15751#issuecomment-951601232 # [Codecov](https://codecov.io/gh/apache/beam/pull/15751?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] yirutang commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
yirutang commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741490133 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/FakeDatasetService.java ## @@ -249,7 +254,21 @@ public

[GitHub] [beam] codecov[bot] edited a comment on pull request #15751: [BEAM-12939][Playground] Backend app - Docker container

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15751: URL: https://github.com/apache/beam/pull/15751#issuecomment-951601232 # [Codecov](https://codecov.io/gh/apache/beam/pull/15751?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15751: [BEAM-12939][Playground] Backend app - Docker container

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15751: URL: https://github.com/apache/beam/pull/15751#issuecomment-951601232 # [Codecov](https://codecov.io/gh/apache/beam/pull/15751?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15751: [BEAM-12939][Playground] Backend app - Docker container

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15751: URL: https://github.com/apache/beam/pull/15751#issuecomment-951601232 # [Codecov](https://codecov.io/gh/apache/beam/pull/15751?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15819: [BEAM-8152] Use venv instead of virtualenv to avoid a virtualenv dependency that can be avoided.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15819: URL: https://github.com/apache/beam/pull/15819#issuecomment-953384753 # [Codecov](https://codecov.io/gh/apache/beam/pull/15819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958010789 # [Codecov](https://codecov.io/gh/apache/beam/pull/15869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15819: [BEAM-8152] Use venv instead of virtualenv to avoid a virtualenv dependency that can be avoided.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15819: URL: https://github.com/apache/beam/pull/15819#issuecomment-953384753 # [Codecov](https://codecov.io/gh/apache/beam/pull/15819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15819: [BEAM-8152] Use venv instead of virtualenv to avoid a virtualenv dependency that can be avoided.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15819: URL: https://github.com/apache/beam/pull/15819#issuecomment-953384753 # [Codecov](https://codecov.io/gh/apache/beam/pull/15819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15410: [BEAM-10277] Encoding position initial implementation

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15410: URL: https://github.com/apache/beam/pull/15410#issuecomment-907330752 # [Codecov](https://codecov.io/gh/apache/beam/pull/15410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem opened a new pull request #15875: Revert "Revert "Merge pull request #15441 from [BEAM-8823] Make FnApi…

2021-11-02 Thread GitBox
pabloem opened a new pull request #15875: URL: https://github.com/apache/beam/pull/15875 …Runner work by executing ready elements instead of stages"" This reverts commit a2f08e5bb2efcea5a54209249f4e5ee3c8dfdc8c. **Please** add a meaningful description for your change here

[GitHub] [beam] pabloem commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

2021-11-02 Thread GitBox
pabloem commented on a change in pull request #15810: URL: https://github.com/apache/beam/pull/15810#discussion_r741463763 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryOptions.java ## @@ -85,6 +85,13 @@ void se

[GitHub] [beam] lukecwik commented on pull request #15849: [BEAM-3811] Code clean-up of the CancelleableQueue to not throw InterruptedException on cancel/reset since we are never stuck in a loop here

2021-11-02 Thread GitBox
lukecwik commented on pull request #15849: URL: https://github.com/apache/beam/pull/15849#issuecomment-958182272 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] apilloud closed pull request #15861: [BEAM-13164] Double timeout

2021-11-02 Thread GitBox
apilloud closed pull request #15861: URL: https://github.com/apache/beam/pull/15861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15773: [BEAM-12566] Implement set_axis for DataFrame and Series

2021-11-02 Thread GitBox
TheNeuralBit commented on a change in pull request #15773: URL: https://github.com/apache/beam/pull/15773#discussion_r741336462 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -1500,6 +1500,23 @@ def dropna(self, **kwargs): preserves_partition_by=pa

[GitHub] [beam] codecov[bot] commented on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
codecov[bot] commented on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958010789 # [Codecov](https://codecov.io/gh/apache/beam/pull/15869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] suztomo commented on pull request #15869: [BEAM-11205][WIP] Libraries BOM 24 with google api client 1.32.2

2021-11-02 Thread GitBox
suztomo commented on pull request #15869: URL: https://github.com/apache/beam/pull/15869#issuecomment-958012460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] pabloem commented on pull request #15784: [BEAM-8135] - Removing BigQueryResultsPublisher and its references

2021-11-02 Thread GitBox
pabloem commented on pull request #15784: URL: https://github.com/apache/beam/pull/15784#issuecomment-958160866 Publish to BQ seems to exist in several places in this file: https://github.com/apache/beam/blob/master/.test-infra/jenkins/LoadTestConfig.groovy It seems that the Seed Job

[GitHub] [beam] jrmccluskey commented on pull request #15871: Add window mapping to CHANGES.md

2021-11-02 Thread GitBox
jrmccluskey commented on pull request #15871: URL: https://github.com/apache/beam/pull/15871#issuecomment-958028314 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] aromanenko-dev commented on a change in pull request #15832: [BEAM-13149] Changing readWithPartitions to work with longs. Removing untested (non-working) code path

2021-11-02 Thread GitBox
aromanenko-dev commented on a change in pull request #15832: URL: https://github.com/apache/beam/pull/15832#discussion_r741112568 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ## @@ -1060,53 +1060,36 @@ public void populateDisplayData(Di

[GitHub] [beam] msbukal commented on pull request #15868: Minor HL7v2IO improvements

2021-11-02 Thread GitBox
msbukal commented on pull request #15868: URL: https://github.com/apache/beam/pull/15868#issuecomment-958162024 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] aromanenko-dev commented on a change in pull request #15811: [BEAM-12070] Make ParquetIO splittable by default

2021-11-02 Thread GitBox
aromanenko-dev commented on a change in pull request #15811: URL: https://github.com/apache/beam/pull/15811#discussion_r740948806 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -387,11 +389,26 @@ public Read withBeamSchemas

[GitHub] [beam] ibzib commented on a change in pull request #15712: [BEAM-12976] Add Java interfaces for projection pushdown.

2021-11-02 Thread GitBox
ibzib commented on a change in pull request #15712: URL: https://github.com/apache/beam/pull/15712#discussion_r741454282 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/ProjectionProducer.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software F

[GitHub] [beam] riteshghorse commented on pull request #15872: [BEAM-13001] updated CHANGES.md to include msec counter for Go

2021-11-02 Thread GitBox
riteshghorse commented on pull request #15872: URL: https://github.com/apache/beam/pull/15872#issuecomment-958091663 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] aromanenko-dev commented on pull request #15811: [BEAM-12070] Make ParquetIO splittable by default

2021-11-02 Thread GitBox
aromanenko-dev commented on pull request #15811: URL: https://github.com/apache/beam/pull/15811#issuecomment-957500385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [beam] pabloem commented on pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
pabloem commented on pull request #15825: URL: https://github.com/apache/beam/pull/15825#issuecomment-957104615 sorry about the delay : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] codecov[bot] edited a comment on pull request #15773: [BEAM-12566] Implement set_axis for DataFrame and Series

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15773: URL: https://github.com/apache/beam/pull/15773#issuecomment-948896809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #15842: [BEAM-13125][Playground] Update documentation for environments

2021-11-02 Thread GitBox
AydarZaynutdinov commented on a change in pull request #15842: URL: https://github.com/apache/beam/pull/15842#discussion_r740852132 ## File path: playground/backend/internal/environment/application.go ## @@ -38,8 +38,13 @@ func (serverEnvs NetworkEnvs) Address() string { //C

[GitHub] [beam] pavel-avilov commented on a change in pull request #15838: [BEAM-13127] [Playground] Implement TCP listener

2021-11-02 Thread GitBox
pavel-avilov commented on a change in pull request #15838: URL: https://github.com/apache/beam/pull/15838#discussion_r741098258 ## File path: playground/backend/cmd/server/server.go ## @@ -50,10 +50,16 @@ func runServer() error { }) grpclog.SetLoggerV2(grpclog

[GitHub] [beam] reuvenlax commented on a change in pull request #15731: [BEAM-13067] Mark GroupIntoBatches output as preserving keys

2021-11-02 Thread GitBox
reuvenlax commented on a change in pull request #15731: URL: https://github.com/apache/beam/pull/15731#discussion_r740639484 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java ## @@ -716,13 +716,13 @@

[GitHub] [beam] pabloem commented on a change in pull request #15842: [BEAM-13125][Playground] Update documentation for environments

2021-11-02 Thread GitBox
pabloem commented on a change in pull request #15842: URL: https://github.com/apache/beam/pull/15842#discussion_r740714418 ## File path: playground/backend/internal/environment/application.go ## @@ -69,8 +74,13 @@ func NewCacheEnvs(cacheType, cacheAddress string, cacheExpirati

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15809: [BEAM-12550] Skew Implementation

2021-11-02 Thread GitBox
TheNeuralBit commented on a change in pull request #15809: URL: https://github.com/apache/beam/pull/15809#discussion_r741341214 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -1430,6 +1430,72 @@ def corr(self, other, method, min_periods): [self._

[GitHub] [beam] pabloem merged pull request #15832: [BEAM-13149] Changing readWithPartitions to work with longs. Removing untested (non-working) code path

2021-11-02 Thread GitBox
pabloem merged pull request #15832: URL: https://github.com/apache/beam/pull/15832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #15863: Autosharding jfor JdbcIO.write* transforms

2021-11-02 Thread GitBox
pabloem commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-957100316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] riteshghorse commented on pull request #15865: [BEAM-13001] fixes nil reference error in Extractor.ExtractFrom

2021-11-02 Thread GitBox
riteshghorse commented on pull request #15865: URL: https://github.com/apache/beam/pull/15865#issuecomment-957725544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [beam] reuvenlax commented on pull request #15465: [BEAM-12795] When using schemas, allow state/timers use without KV objects.

2021-11-02 Thread GitBox
reuvenlax commented on pull request #15465: URL: https://github.com/apache/beam/pull/15465#issuecomment-958129039 @lukecwik any more thoughts on this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [beam] codecov[bot] edited a comment on pull request #15775: [BEAM-12730] Python. Custom delimiter add corner case

2021-11-02 Thread GitBox
codecov[bot] edited a comment on pull request #15775: URL: https://github.com/apache/beam/pull/15775#issuecomment-948931380 # [Codecov](https://codecov.io/gh/apache/beam/pull/15775?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on a change in pull request #15825: [BEAM-13140] Fixes bug in WriteRename class

2021-11-02 Thread GitBox
pabloem commented on a change in pull request #15825: URL: https://github.com/apache/beam/pull/15825#discussion_r740721806 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java ## @@ -232,7 +238,7 @@ private Pending

[GitHub] [beam] aromanenko-dev merged pull request #15811: [BEAM-12070] Make ParquetIO splittable by default

2021-11-02 Thread GitBox
aromanenko-dev merged pull request #15811: URL: https://github.com/apache/beam/pull/15811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] apilloud commented on pull request #15807: [BEAM-13015] Migrate bundle processing in the SDK harness to using BeamFnDataInboundObserver2 and BeamFnDataGrpcMultiplexer2.

2021-11-02 Thread GitBox
apilloud commented on pull request #15807: URL: https://github.com/apache/beam/pull/15807#issuecomment-957013117 It is possible this broke the `Run Java Spark PortableValidatesRunner Batch` test. After this change the test is reliably timing out (BEAM-13164). I have #15861 to up the timeou

  1   2   3   4   >