[GitHub] [beam] hughack commented on pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2021-11-12 Thread GitBox
hughack commented on pull request #15378: URL: https://github.com/apache/beam/pull/15378#issuecomment-967766895 @pabloem - Yeah looks good, the only comment would be around @kennknowles point. I don't think "key-limited parallelism" is mentioned anywhere else in the Beam model. My understa

[GitHub] [beam] hughack commented on a change in pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2021-11-12 Thread GitBox
hughack commented on a change in pull request #15378: URL: https://github.com/apache/beam/pull/15378#discussion_r748669254 ## File path: website/www/site/data/capability_matrix.yaml ## @@ -1704,3 +1704,42 @@ capability-matrix: l1: l2:

[GitHub] [beam] katsiapis commented on pull request #15969: Key-inferable type hints for CombinePerKey.

2021-11-12 Thread GitBox
katsiapis commented on pull request #15969: URL: https://github.com/apache/beam/pull/15969#issuecomment-967761525 Thanks Robert, much appreciated! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] chamikaramj merged pull request #15941: [BEAM-13223] Documents two new features of cross-language transforms

2021-11-12 Thread GitBox
chamikaramj merged pull request #15941: URL: https://github.com/apache/beam/pull/15941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [beam] chamikaramj commented on a change in pull request #15941: [BEAM-13223] Documents two new features of cross-language transforms

2021-11-12 Thread GitBox
chamikaramj commented on a change in pull request #15941: URL: https://github.com/apache/beam/pull/15941#discussion_r748653865 ## File path: website/www/site/content/en/documentation/programming-guide.md ## @@ -6555,6 +6555,115 @@ In this section, we will use [KafkaIO.Read](ht

[GitHub] [beam] chamikaramj commented on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-12 Thread GitBox
chamikaramj commented on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-967746526 Hi Robert, any updates on this ? It's great if we can get this into Beam 2.35.0 (cut 11/17) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #15969: Key-inferable type hints for CombinePerKey.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15969: URL: https://github.com/apache/beam/pull/15969#issuecomment-967737599 # [Codecov](https://codecov.io/gh/apache/beam/pull/15969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15968: [WIP][BEAM-12572] Beam python examples continuously exercised on at least 2 runners

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15968: URL: https://github.com/apache/beam/pull/15968#issuecomment-967731018 # [Codecov](https://codecov.io/gh/apache/beam/pull/15968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15969: Key-inferable type hints for CombinePerKey.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15969: URL: https://github.com/apache/beam/pull/15969#issuecomment-967737599 # [Codecov](https://codecov.io/gh/apache/beam/pull/15969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #15969: Key-inferable type hints for CombinePerKey.

2021-11-12 Thread GitBox
codecov[bot] commented on pull request #15969: URL: https://github.com/apache/beam/pull/15969#issuecomment-967737599 # [Codecov](https://codecov.io/gh/apache/beam/pull/15969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] pabloem commented on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-12 Thread GitBox
pabloem commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-967735753 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #15949: Implement type variable binding for union types.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15949: URL: https://github.com/apache/beam/pull/15949#issuecomment-966678226 # [Codecov](https://codecov.io/gh/apache/beam/pull/15949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-12 Thread GitBox
pabloem commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-967733143 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] robertwb commented on pull request #15969: Key-inferable type hints for CombinePerKey.

2021-11-12 Thread GitBox
robertwb commented on pull request #15969: URL: https://github.com/apache/beam/pull/15969#issuecomment-967732375 R: @katsiapis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [beam] robertwb opened a new pull request #15969: Key-inferable type hints for CombinePerKey.

2021-11-12 Thread GitBox
robertwb opened a new pull request #15969: URL: https://github.com/apache/beam/pull/15969 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] codecov[bot] edited a comment on pull request #15968: [WIP][BEAM-12572] Beam python examples continuously exercised on at least 2 runners

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15968: URL: https://github.com/apache/beam/pull/15968#issuecomment-967731018 # [Codecov](https://codecov.io/gh/apache/beam/pull/15968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #15968: [WIP][BEAM-12572] Beam python examples continuously exercised on at least 2 runners

2021-11-12 Thread GitBox
codecov[bot] commented on pull request #15968: URL: https://github.com/apache/beam/pull/15968#issuecomment-967731018 # [Codecov](https://codecov.io/gh/apache/beam/pull/15968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] codecov[bot] edited a comment on pull request #15949: Implement type variable binding for union types.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15949: URL: https://github.com/apache/beam/pull/15949#issuecomment-966678226 # [Codecov](https://codecov.io/gh/apache/beam/pull/15949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15949: Implement type variable binding for union types.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15949: URL: https://github.com/apache/beam/pull/15949#issuecomment-966678226 # [Codecov](https://codecov.io/gh/apache/beam/pull/15949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] benWize opened a new pull request #15968: [WIP][BEAM-12572] Beam python examples continuously exercised on at least 2 runners

2021-11-12 Thread GitBox
benWize opened a new pull request #15968: URL: https://github.com/apache/beam/pull/15968 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickl

[GitHub] [beam] codecov[bot] edited a comment on pull request #15949: Implement type variable binding for union types.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15949: URL: https://github.com/apache/beam/pull/15949#issuecomment-966678226 # [Codecov](https://codecov.io/gh/apache/beam/pull/15949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15967: Fully resolve type variables after PTransform type inference.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15967: URL: https://github.com/apache/beam/pull/15967#issuecomment-967698863 # [Codecov](https://codecov.io/gh/apache/beam/pull/15967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-12 Thread GitBox
pabloem commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-967703267 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] codecov[bot] commented on pull request #15967: Fully resolve type variables after PTransform type inference.

2021-11-12 Thread GitBox
codecov[bot] commented on pull request #15967: URL: https://github.com/apache/beam/pull/15967#issuecomment-967698863 # [Codecov](https://codecov.io/gh/apache/beam/pull/15967?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] robertwb opened a new pull request #15967: Fully resolve type variables after PTransform type inference.

2021-11-12 Thread GitBox
robertwb opened a new pull request #15967: URL: https://github.com/apache/beam/pull/15967 Type variables are useful for relating inputs to outputs, but any remaining unbound type variables after this iference must be resolved to Any to prevent unwanted interactions downstream. -

[GitHub] [beam] robertwb commented on pull request #15967: Fully resolve type variables after PTransform type inference.

2021-11-12 Thread GitBox
robertwb commented on pull request #15967: URL: https://github.com/apache/beam/pull/15967#issuecomment-967646598 R: @udim -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] lostluck merged pull request #15966: [BEAM-3293] Add NewKeyedIterable function to SideInputAdapter interface

2021-11-12 Thread GitBox
lostluck merged pull request #15966: URL: https://github.com/apache/beam/pull/15966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #15949: Implement type variable binding for union types.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15949: URL: https://github.com/apache/beam/pull/15949#issuecomment-966678226 # [Codecov](https://codecov.io/gh/apache/beam/pull/15949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] jrmccluskey commented on a change in pull request #15966: [BEAM-3293] Add NewKeyedIterable function to SideInputAdapter interface

2021-11-12 Thread GitBox
jrmccluskey commented on a change in pull request #15966: URL: https://github.com/apache/beam/pull/15966#discussion_r748585779 ## File path: sdks/go/pkg/beam/core/runtime/exec/sideinput.go ## @@ -58,7 +59,16 @@ func NewSideInputAdapter(sid StreamID, sideInputID string, c *code

[GitHub] [beam] pcoet commented on a change in pull request #15941: [BEAM-13223] Documents two new features of cross-language transforms

2021-11-12 Thread GitBox
pcoet commented on a change in pull request #15941: URL: https://github.com/apache/beam/pull/15941#discussion_r748574358 ## File path: website/www/site/content/en/documentation/programming-guide.md ## @@ -6555,6 +6555,115 @@ In this section, we will use [KafkaIO.Read](https://

[GitHub] [beam] pcoet commented on a change in pull request #15941: [BEAM-13223] Documents two new features of cross-language transforms

2021-11-12 Thread GitBox
pcoet commented on a change in pull request #15941: URL: https://github.com/apache/beam/pull/15941#discussion_r748572408 ## File path: website/www/site/content/en/documentation/programming-guide.md ## @@ -6555,6 +6555,115 @@ In this section, we will use [KafkaIO.Read](https://

[GitHub] [beam] lostluck commented on a change in pull request #15966: [BEAM-3293] Add NewKeyedIterable function to SideInputAdapter interface

2021-11-12 Thread GitBox
lostluck commented on a change in pull request #15966: URL: https://github.com/apache/beam/pull/15966#discussion_r748580456 ## File path: sdks/go/pkg/beam/core/runtime/exec/sideinput.go ## @@ -58,7 +59,16 @@ func NewSideInputAdapter(sid StreamID, sideInputID string, c *coder.C

[GitHub] [beam] lostluck commented on a change in pull request #15966: [BEAM-3293] Add NewKeyedIterable function to SideInputAdapter interface

2021-11-12 Thread GitBox
lostluck commented on a change in pull request #15966: URL: https://github.com/apache/beam/pull/15966#discussion_r748576460 ## File path: sdks/go/pkg/beam/core/runtime/exec/sideinput.go ## @@ -58,7 +59,16 @@ func NewSideInputAdapter(sid StreamID, sideInputID string, c *coder.C

[GitHub] [beam] jrmccluskey commented on pull request #15966: [BEAM-3293] Add NewKeyedIterable function to SideInputAdapter interface

2021-11-12 Thread GitBox
jrmccluskey commented on pull request #15966: URL: https://github.com/apache/beam/pull/15966#issuecomment-967496822 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] jrmccluskey commented on a change in pull request #15966: [BEAM-3293] Add NewKeyedIterable function to SideInputAdapter interface

2021-11-12 Thread GitBox
jrmccluskey commented on a change in pull request #15966: URL: https://github.com/apache/beam/pull/15966#discussion_r748567812 ## File path: sdks/go/pkg/beam/core/runtime/exec/sideinput.go ## @@ -58,7 +59,16 @@ func NewSideInputAdapter(sid StreamID, sideInputID string, c *code

[GitHub] [beam] jrmccluskey opened a new pull request #15966: [BEAM-3293] Add NewKeyedIterable function to SideInputAdapter interface

2021-11-12 Thread GitBox
jrmccluskey opened a new pull request #15966: URL: https://github.com/apache/beam/pull/15966 Adds a NewKeyedIterable method to the SideInputAdapter interface, creating a route to request a side input with a specific key. Adds NewKeyedIterable() methods to test case implementations of the i

[GitHub] [beam] lostluck merged pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
lostluck merged pull request #15952: URL: https://github.com/apache/beam/pull/15952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] pabloem commented on pull request #15489: [BEAM-12865] Allow custom batch_duration in WriteToBigQuery

2021-11-12 Thread GitBox
pabloem commented on pull request #15489: URL: https://github.com/apache/beam/pull/15489#issuecomment-967389960 no... I'll take a lo0ok in a bit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] pabloem commented on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-12 Thread GitBox
pabloem commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-967377167 adding a test makes sense. I'll work on that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [beam] pabloem commented on a change in pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-12 Thread GitBox
pabloem commented on a change in pull request #15863: URL: https://github.com/apache/beam/pull/15863#discussion_r748534021 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ## @@ -1494,8 +1509,49 @@ void set( checkArgument(

[GitHub] [beam] pabloem commented on a change in pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-12 Thread GitBox
pabloem commented on a change in pull request #15863: URL: https://github.com/apache/beam/pull/15863#discussion_r748533384 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ## @@ -1494,8 +1509,49 @@ void set( checkArgument(

[GitHub] [beam] y1chi merged pull request #15917: [BEAM-13193] Add elements field in ProcessBundleRequest and ProcessBu…

2021-11-12 Thread GitBox
y1chi merged pull request #15917: URL: https://github.com/apache/beam/pull/15917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [beam] mosche commented on pull request #15955: [BEAM-13236] Properly close kinesis producer on teardown

2021-11-12 Thread GitBox
mosche commented on pull request #15955: URL: https://github.com/apache/beam/pull/15955#issuecomment-967345074 @aromanenko-dev done 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] pabloem merged pull request #15959: [BEAM-13224][Playground] Local cache creates an forever used goroutine

2021-11-12 Thread GitBox
pabloem merged pull request #15959: URL: https://github.com/apache/beam/pull/15959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #15959: [BEAM-13224][Playground] Local cache creates an forever used goroutine

2021-11-12 Thread GitBox
pabloem commented on pull request #15959: URL: https://github.com/apache/beam/pull/15959#issuecomment-967343762 I'm glad we caught this : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] mosche opened a new pull request #15965: [BEAM-7559] Add integration test for DynamoDBIO

2021-11-12 Thread GitBox
mosche opened a new pull request #15965: URL: https://github.com/apache/beam/pull/15965 Add integration test for DynamoDBIO Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [

[GitHub] [beam] mosche opened a new pull request #15964: [BEAM-13209] Fix DynamoDBIO.write to properly handle partial success (SDK v2)

2021-11-12 Thread GitBox
mosche opened a new pull request #15964: URL: https://github.com/apache/beam/pull/15964 Fix DynamoDBIO.write to properly handle partial success with unprocessed items remaining (SDK v2). I'll follow up with a similar PR for SDK v1. Thank you for you

[GitHub] [beam] codecov[bot] edited a comment on pull request #15917: [BEAM-13193] Add elements field in ProcessBundleRequest and ProcessBu…

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15917: URL: https://github.com/apache/beam/pull/15917#issuecomment-963509156 # [Codecov](https://codecov.io/gh/apache/beam/pull/15917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem opened a new pull request #15963: [BEAM-8033] Throwing an error if a dataSourceProviderFn is defined twice

2021-11-12 Thread GitBox
pabloem opened a new pull request #15963: URL: https://github.com/apache/beam/pull/15963 …ice in a transform **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorpora

[GitHub] [beam] pabloem commented on pull request #15954: [BEAM-960][BEAM-1675] Improvements to JdbcIO coder inference

2021-11-12 Thread GitBox
pabloem commented on pull request #15954: URL: https://github.com/apache/beam/pull/15954#issuecomment-967328710 opened https://github.com/apache/beam/pull/15963 for the unrelated change -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] pabloem commented on pull request #15954: [BEAM-960][BEAM-8033][BEAM-1675] Improvements to JdbcIO

2021-11-12 Thread GitBox
pabloem commented on pull request #15954: URL: https://github.com/apache/beam/pull/15954#issuecomment-967326732 Mainly laziness : ) @aromanenko-dev These three commits+two jiras are pretty related to each other: - [BEAM-960] support coder inference for JdbcIO - [BEAM-1

[GitHub] [beam] aromanenko-dev commented on pull request #15954: [BEAM-960][BEAM-8033][BEAM-1675] Improvements to JdbcIO

2021-11-12 Thread GitBox
aromanenko-dev commented on pull request #15954: URL: https://github.com/apache/beam/pull/15954#issuecomment-967324801 @pabloem Why not three different PRs since they are related to different Jiras? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] aromanenko-dev merged pull request #15898: [BEAM-13009] Bugfix: Prevent dataloss in DynamoDBIO write if deduplication keys are not set (aws SDK v1)

2021-11-12 Thread GitBox
aromanenko-dev merged pull request #15898: URL: https://github.com/apache/beam/pull/15898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] riteshghorse commented on pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
riteshghorse commented on pull request #15952: URL: https://github.com/apache/beam/pull/15952#issuecomment-967321786 Run Go PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] lostluck commented on pull request #15694: [WIP] Add coverage report for go

2021-11-12 Thread GitBox
lostluck commented on pull request #15694: URL: https://github.com/apache/beam/pull/15694#issuecomment-967321064 Ok. Looks like the reason it didn't work is that only PRs by committers can have the seed job run on them. To that end I copied this PR to here: https://github.com/apache/beam/p

[GitHub] [beam] pabloem commented on pull request #15954: [BEAM-960][BEAM-8033][BEAM-1675] Improvements to JdbcIO

2021-11-12 Thread GitBox
pabloem commented on pull request #15954: URL: https://github.com/apache/beam/pull/15954#issuecomment-967320602 Postcommit run: https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/834/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] lostluck opened a new pull request #15962: Pr 15694 seed job help

2021-11-12 Thread GitBox
lostluck opened a new pull request #15962: URL: https://github.com/apache/beam/pull/15962 Only exists to run the seed job. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ]

[GitHub] [beam] lostluck commented on pull request #15962: Pr 15694 seed job help

2021-11-12 Thread GitBox
lostluck commented on pull request #15962: URL: https://github.com/apache/beam/pull/15962#issuecomment-967320147 Run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] pabloem commented on pull request #15954: [BEAM-960][BEAM-8033][BEAM-1675] Improvements to JdbcIO

2021-11-12 Thread GitBox
pabloem commented on pull request #15954: URL: https://github.com/apache/beam/pull/15954#issuecomment-967316705 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] aromanenko-dev merged pull request #15895: [BEAM-13009] Bugfix: Prevent dataloss in DynamoDBIO write if deduplication keys are not set (aws SDK v2)

2021-11-12 Thread GitBox
aromanenko-dev merged pull request #15895: URL: https://github.com/apache/beam/pull/15895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] pabloem commented on pull request #15954: [BEAM-960][BEAM-8033][BEAM-1675] Improvements to JdbcIO

2021-11-12 Thread GitBox
pabloem commented on pull request #15954: URL: https://github.com/apache/beam/pull/15954#issuecomment-967309944 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] codecov[bot] edited a comment on pull request #15927: Generate Python container dependencies in an automated way.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15927: URL: https://github.com/apache/beam/pull/15927#issuecomment-964528900 # [Codecov](https://codecov.io/gh/apache/beam/pull/15927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] y1chi commented on pull request #15917: [BEAM-13193] Add elements field in ProcessBundleRequest and ProcessBu…

2021-11-12 Thread GitBox
y1chi commented on pull request #15917: URL: https://github.com/apache/beam/pull/15917#issuecomment-967306781 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] chamikaramj merged pull request #15817: [BEAM-13052] Implement ProtoPlusCoder and add it to the default options

2021-11-12 Thread GitBox
chamikaramj merged pull request #15817: URL: https://github.com/apache/beam/pull/15817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [beam] chamikaramj commented on pull request #15817: [BEAM-13052] Implement ProtoPlusCoder and add it to the default options

2021-11-12 Thread GitBox
chamikaramj commented on pull request #15817: URL: https://github.com/apache/beam/pull/15817#issuecomment-967299918 PostCommit failure is unrelated (https://issues.apache.org/jira/browse/BEAM-13218) -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] lostluck commented on a change in pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
lostluck commented on a change in pull request #15952: URL: https://github.com/apache/beam/pull/15952#discussion_r748453793 ## File path: sdks/go/pkg/beam/core/graph/window/trigger/trigger.go ## @@ -138,49 +143,116 @@ func (tr Trigger) AlignedTo(period time.Duration, offset ti

[GitHub] [beam] codecov[bot] edited a comment on pull request #15927: Generate Python container dependencies in an automated way.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15927: URL: https://github.com/apache/beam/pull/15927#issuecomment-964528900 # [Codecov](https://codecov.io/gh/apache/beam/pull/15927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] lostluck merged pull request #15960: [BEAM-3293] Add encoding of map/multimap side inputs into proto

2021-11-12 Thread GitBox
lostluck merged pull request #15960: URL: https://github.com/apache/beam/pull/15960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] tvalentyn commented on pull request #15927: Generate Python container dependencies in an automated way.

2021-11-12 Thread GitBox
tvalentyn commented on pull request #15927: URL: https://github.com/apache/beam/pull/15927#issuecomment-967269117 R: @ryanthompson591 @TheNeuralBit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] fernando-wizeline commented on pull request #15675: [BEAM-12313] - Initial changes to support Java 17 SDK Harness docker image

2021-11-12 Thread GitBox
fernando-wizeline commented on pull request #15675: URL: https://github.com/apache/beam/pull/15675#issuecomment-967268916 @pabloem what do you think? Would it be ok to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [beam] aromanenko-dev commented on pull request #15955: [adhoc] Properly close kinesis producer on teardown

2021-11-12 Thread GitBox
aromanenko-dev commented on pull request #15955: URL: https://github.com/apache/beam/pull/15955#issuecomment-967267713 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] codecov[bot] edited a comment on pull request #15927: Generate Python container dependencies in an automated way.

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15927: URL: https://github.com/apache/beam/pull/15927#issuecomment-964528900 # [Codecov](https://codecov.io/gh/apache/beam/pull/15927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] ibzib commented on pull request #14767: [BEAM-7819] Add missing fields to python apache_beam.io.gcp.pubsub.PubsubMessage

2021-11-12 Thread GitBox
ibzib commented on pull request #14767: URL: https://github.com/apache/beam/pull/14767#issuecomment-967258718 @astorrs All changes are automatically picked up by a "release cut" that happens roughly once every 6 weeks. https://beam.apache.org/contribute/#when-will-my-change-show-up-in-an-a

[GitHub] [beam] tvalentyn commented on pull request #15819: [BEAM-8152] Use venv instead of virtualenv to create Python environments in Gradle scripts.

2021-11-12 Thread GitBox
tvalentyn commented on pull request #15819: URL: https://github.com/apache/beam/pull/15819#issuecomment-967253642 r: @ryanthompson591 @TheNeuralBit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] borovikovd opened a new pull request #15961: Allow values with smaller precision and scale for Numeric

2021-11-12 Thread GitBox
borovikovd opened a new pull request #15961: URL: https://github.com/apache/beam/pull/15961 This is a fix for `IllegalArgumentException` that happens during reading of a numeric column. The issue is following: say you have a numeric field with precision 15 and scale 2. When JdbcIO reads va

[GitHub] [beam] aromanenko-dev commented on a change in pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-12 Thread GitBox
aromanenko-dev commented on a change in pull request #15863: URL: https://github.com/apache/beam/pull/15863#discussion_r748398715 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java ## @@ -1494,8 +1509,49 @@ void set( checkArgument(

[GitHub] [beam] riteshghorse commented on pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
riteshghorse commented on pull request #15952: URL: https://github.com/apache/beam/pull/15952#issuecomment-967229035 Run Go PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] jrmccluskey commented on pull request #15960: [BEAM-3293] Add encoding of map/multimap side inputs into proto

2021-11-12 Thread GitBox
jrmccluskey commented on pull request #15960: URL: https://github.com/apache/beam/pull/15960#issuecomment-967219767 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] jrmccluskey opened a new pull request #15960: [BEAM-3293] Add encoding of map/multimap side inputs into proto

2021-11-12 Thread GitBox
jrmccluskey opened a new pull request #15960: URL: https://github.com/apache/beam/pull/15960 Adds encoding of map and multimap side inputs into proto form for pipeline execution. Also refactors the switch statement setting the side input window mapping function into a helper function so it

[GitHub] [beam] aromanenko-dev merged pull request #15843: [BEAM-13147] Fix nullability issues in aws (SDK v1 + v2) for AwsModule

2021-11-12 Thread GitBox
aromanenko-dev merged pull request #15843: URL: https://github.com/apache/beam/pull/15843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] aromanenko-dev commented on pull request #15843: [BEAM-13147] Fix nullability issues in aws (SDK v1 + v2) for AwsModule

2021-11-12 Thread GitBox
aromanenko-dev commented on pull request #15843: URL: https://github.com/apache/beam/pull/15843#issuecomment-967208657 Thanks, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] AydarZaynutdinov commented on pull request #15959: [BEAM-13224][Playground] Local cache creates an forever used goroutine

2021-11-12 Thread GitBox
AydarZaynutdinov commented on pull request #15959: URL: https://github.com/apache/beam/pull/15959#issuecomment-967202752 @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] AydarZaynutdinov opened a new pull request #15959: [BEAM-13224][Playground] Local cache creates an forever used goroutine

2021-11-12 Thread GitBox
AydarZaynutdinov opened a new pull request #15959: URL: https://github.com/apache/beam/pull/15959 [BEAM-13224] Add using context to local cache to stop goroutine Thank you for your contribution! Follow this checklist to help us incorporate your cont

[GitHub] [beam] riteshghorse commented on a change in pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
riteshghorse commented on a change in pull request #15952: URL: https://github.com/apache/beam/pull/15952#discussion_r748373269 ## File path: sdks/go/pkg/beam/core/graph/window/trigger/trigger.go ## @@ -138,49 +143,114 @@ func (tr Trigger) AlignedTo(period time.Duration, offset

[GitHub] [beam] AydarZaynutdinov commented on pull request #15958: [BEAM-13178][Playground] Refactoring for controller

2021-11-12 Thread GitBox
AydarZaynutdinov commented on pull request #15958: URL: https://github.com/apache/beam/pull/15958#issuecomment-967198221 @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] AydarZaynutdinov opened a new pull request #15958: [BEAM-13178][Playground] Refactoring for controller

2021-11-12 Thread GitBox
AydarZaynutdinov opened a new pull request #15958: URL: https://github.com/apache/beam/pull/15958 [BEAM-13178] moving setup methods to a new module; moving processing methods to a new module; Thank you for your contribution! Follow this checklist

[GitHub] [beam] riteshghorse commented on a change in pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
riteshghorse commented on a change in pull request #15952: URL: https://github.com/apache/beam/pull/15952#discussion_r748369532 ## File path: sdks/go/pkg/beam/core/graph/window/trigger/trigger.go ## @@ -138,49 +143,114 @@ func (tr Trigger) AlignedTo(period time.Duration, offset

[GitHub] [beam] daria-malkova commented on pull request #15957: [BEAM-13045][Playground] Implemented examples api

2021-11-12 Thread GitBox
daria-malkova commented on pull request #15957: URL: https://github.com/apache/beam/pull/15957#issuecomment-967195929 R: @pabloem @damondouglas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] riteshghorse commented on a change in pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
riteshghorse commented on a change in pull request #15952: URL: https://github.com/apache/beam/pull/15952#discussion_r748368847 ## File path: sdks/go/pkg/beam/core/graph/window/trigger/trigger.go ## @@ -138,49 +143,114 @@ func (tr Trigger) AlignedTo(period time.Duration, offset

[GitHub] [beam] riteshghorse commented on a change in pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
riteshghorse commented on a change in pull request #15952: URL: https://github.com/apache/beam/pull/15952#discussion_r748368647 ## File path: sdks/go/pkg/beam/core/graph/window/trigger/trigger.go ## @@ -138,49 +143,114 @@ func (tr Trigger) AlignedTo(period time.Duration, offset

[GitHub] [beam] riteshghorse commented on a change in pull request #15952: [BEAM-3304] Refactor trigger API

2021-11-12 Thread GitBox
riteshghorse commented on a change in pull request #15952: URL: https://github.com/apache/beam/pull/15952#discussion_r748365829 ## File path: sdks/go/pkg/beam/core/graph/window/trigger/trigger.go ## @@ -138,49 +143,114 @@ func (tr Trigger) AlignedTo(period time.Duration, offset

[GitHub] [beam] daria-malkova opened a new pull request #15957: [BEAM-13045][Playground] Implemented examples api

2021-11-12 Thread GitBox
daria-malkova opened a new pull request #15957: URL: https://github.com/apache/beam/pull/15957 [BEAM-13045] API for reading precompiled examples from public GCP bucket Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] aromanenko-dev merged pull request #15932: [BEAM-4868] Bump com.amazonaws to 1.12.106

2021-11-12 Thread GitBox
aromanenko-dev merged pull request #15932: URL: https://github.com/apache/beam/pull/15932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] ElessarST commented on pull request #15956: [BEAM-13210] [Playground]: support streaming output on the frontend

2021-11-12 Thread GitBox
ElessarST commented on pull request #15956: URL: https://github.com/apache/beam/pull/15956#issuecomment-967165245 R: @damondouglas cc: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] codecov[bot] edited a comment on pull request #15932: [BEAM-4868] Bump com.amazonaws to 1.12.106

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15932: URL: https://github.com/apache/beam/pull/15932#issuecomment-965350418 # [Codecov](https://codecov.io/gh/apache/beam/pull/15932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] ElessarST opened a new pull request #15956: [BEAM-13210] [Playground]: support streaming output on the frontend

2021-11-12 Thread GitBox
ElessarST opened a new pull request #15956: URL: https://github.com/apache/beam/pull/15956 **Please** add a meaningful description for your change here I added support streaming output and handling new execution statuses on the frontend. Now execution status provides an output tha

[GitHub] [beam] codecov[bot] edited a comment on pull request #15932: [BEAM-4868] Bump com.amazonaws to 1.12.106

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15932: URL: https://github.com/apache/beam/pull/15932#issuecomment-965350418 # [Codecov](https://codecov.io/gh/apache/beam/pull/15932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] mosche commented on pull request #15955: [adhoc] Properly close kinesis producer on teardown

2021-11-12 Thread GitBox
mosche commented on pull request #15955: URL: https://github.com/apache/beam/pull/15955#issuecomment-967080808 R: @aromanenko-dev Just a small adhoc fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [beam] codecov[bot] edited a comment on pull request #15932: [BEAM-4868] Bump com.amazonaws to 1.12.106

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15932: URL: https://github.com/apache/beam/pull/15932#issuecomment-965350418 # [Codecov](https://codecov.io/gh/apache/beam/pull/15932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15932: [BEAM-4868] Bump com.amazonaws to 1.12.106

2021-11-12 Thread GitBox
codecov[bot] edited a comment on pull request #15932: URL: https://github.com/apache/beam/pull/15932#issuecomment-965350418 # [Codecov](https://codecov.io/gh/apache/beam/pull/15932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

  1   2   >