[GitHub] [beam] codecov[bot] edited a comment on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-961468620 # [Codecov](https://codecov.io/gh/apache/beam/pull/15857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] tvalentyn commented on a change in pull request #15472: [BEAM-8123] Add cloudpickle as optional library

2021-11-16 Thread GitBox
tvalentyn commented on a change in pull request #15472: URL: https://github.com/apache/beam/pull/15472#discussion_r750907099 ## File path: sdks/python/apache_beam/runners/worker/sdk_worker_main.py ## @@ -76,6 +77,8 @@ def create_harness(environment, dry_run=False): RuntimeVa

[GitHub] [beam] tvalentyn commented on pull request #15472: [BEAM-8123] Add cloudpickle as optional library

2021-11-16 Thread GitBox
tvalentyn commented on pull request #15472: URL: https://github.com/apache/beam/pull/15472#issuecomment-971255413 > valentyn can you take another look. Also are there any other people that you think I should review this beforehand? you could mention this PR on the mailing list in a threa

[GitHub] [beam] codecov[bot] edited a comment on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-961468620 # [Codecov](https://codecov.io/gh/apache/beam/pull/15857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] reuvenlax commented on pull request #15994: [BEAM-13263] Support OnWindowExpiration in (non-portable) Flink runner

2021-11-16 Thread GitBox
reuvenlax commented on pull request #15994: URL: https://github.com/apache/beam/pull/15994#issuecomment-971226575 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] tvalentyn commented on a change in pull request #16000: [BEAM-13624] Run `generatePythonRequirementsAll` for pyarrow 6

2021-11-16 Thread GitBox
tvalentyn commented on a change in pull request #16000: URL: https://github.com/apache/beam/pull/16000#discussion_r750890949 ## File path: sdks/python/container/py38/base_image_requirements.txt ## @@ -98,12 +99,13 @@ pandas==1.3.4 parameterized==0.7.5 pbr==5.7.0 Pillow==7.2.

[GitHub] [beam] reuvenlax commented on pull request #15994: [BEAM-13263] Support OnWindowExpiration in (non-portable) Flink runner

2021-11-16 Thread GitBox
reuvenlax commented on pull request #15994: URL: https://github.com/apache/beam/pull/15994#issuecomment-971142719 Run Flink ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] codecov[bot] edited a comment on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-961468620 # [Codecov](https://codecov.io/gh/apache/beam/pull/15857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-961468620 # [Codecov](https://codecov.io/gh/apache/beam/pull/15857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-961468620 # [Codecov](https://codecov.io/gh/apache/beam/pull/15857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-961468620 # [Codecov](https://codecov.io/gh/apache/beam/pull/15857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-961468620 # [Codecov](https://codecov.io/gh/apache/beam/pull/15857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16000: [BEAM-13624] Run `generatePythonRequirementsAll` for pyarrow 6

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #16000: URL: https://github.com/apache/beam/pull/16000#issuecomment-970985203 # [Codecov](https://codecov.io/gh/apache/beam/pull/16000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] tvalentyn commented on a change in pull request #15819: [BEAM-8152] Use venv instead of virtualenv to create Python environments in Gradle scripts.

2021-11-16 Thread GitBox
tvalentyn commented on a change in pull request #15819: URL: https://github.com/apache/beam/pull/15819#discussion_r750804941 ## File path: dev-support/docker/pkglist ## @@ -33,7 +33,22 @@ openjdk-8-jdk python3-setuptools python3-pip python3.6 +python3.6-dev +python3.6-venv

[GitHub] [beam] tvalentyn commented on a change in pull request #15819: [BEAM-8152] Use venv instead of virtualenv to create Python environments in Gradle scripts.

2021-11-16 Thread GitBox
tvalentyn commented on a change in pull request #15819: URL: https://github.com/apache/beam/pull/15819#discussion_r750804675 ## File path: dev-support/docker/pkglist ## @@ -33,7 +33,22 @@ openjdk-8-jdk python3-setuptools python3-pip python3.6 +python3.6-dev +python3.6-venv

[GitHub] [beam] tvalentyn commented on a change in pull request #15819: [BEAM-8152] Use venv instead of virtualenv to create Python environments in Gradle scripts.

2021-11-16 Thread GitBox
tvalentyn commented on a change in pull request #15819: URL: https://github.com/apache/beam/pull/15819#discussion_r750804351 ## File path: website/www/site/content/en/contribute/_index.md ## @@ -80,8 +80,9 @@ detail. changes locally. - For SDK Development: - [Go](h

[GitHub] [beam] codecov[bot] edited a comment on pull request #16000: [BEAM-13624] Run `generatePythonRequirementsAll` for pyarrow 6

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #16000: URL: https://github.com/apache/beam/pull/16000#issuecomment-970985203 # [Codecov](https://codecov.io/gh/apache/beam/pull/16000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15819: [BEAM-8152] Use venv instead of virtualenv to create Python environments in Gradle scripts.

2021-11-16 Thread GitBox
TheNeuralBit commented on a change in pull request #15819: URL: https://github.com/apache/beam/pull/15819#discussion_r750780200 ## File path: website/www/site/content/en/contribute/_index.md ## @@ -80,8 +80,9 @@ detail. changes locally. - For SDK Development: - [Go

[GitHub] [beam] codecov[bot] commented on pull request #16000: [BEAM-13624] Run `generatePythonRequirementsAll` for pyarrow 6

2021-11-16 Thread GitBox
codecov[bot] commented on pull request #16000: URL: https://github.com/apache/beam/pull/16000#issuecomment-970985203 # [Codecov](https://codecov.io/gh/apache/beam/pull/16000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] pcoet opened a new pull request #16001: created quickstart guide for multi-language pipelines (Python)

2021-11-16 Thread GitBox
pcoet opened a new pull request #16001: URL: https://github.com/apache/beam/pull/16001 Created a quickstart guide for multi-language pipelines using the Python SDK. @chamikaramj Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] TheNeuralBit commented on pull request #16000: [BEAM-13624] Run `generatePythonRequirementsAll` for pyarrow 6

2021-11-16 Thread GitBox
TheNeuralBit commented on pull request #16000: URL: https://github.com/apache/beam/pull/16000#issuecomment-970941930 This went very smoothly once I realized I just needed to install `python-3.x-venv` in the `start-build-env.sh` container. It looks like this is already handled in https://gi

[GitHub] [beam] TheNeuralBit opened a new pull request #16000: [BEAM-13624] Run `generatePythonRequirementsAll` for pyarrow 6

2021-11-16 Thread GitBox
TheNeuralBit opened a new pull request #16000: URL: https://github.com/apache/beam/pull/16000 `ValidatesRunner` compliance status (on master branch) Lang ULR Dataflow Flink

[GitHub] [beam] codecov[bot] edited a comment on pull request #15827: [WIP][BEAM-12560] Dataframe idxmin and idxmax implementation

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15827: URL: https://github.com/apache/beam/pull/15827#issuecomment-966457087 # [Codecov](https://codecov.io/gh/apache/beam/pull/15827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15827: [WIP][BEAM-12560] Dataframe idxmin and idxmax implementation

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15827: URL: https://github.com/apache/beam/pull/15827#issuecomment-966457087 # [Codecov](https://codecov.io/gh/apache/beam/pull/15827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo merged pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo merged pull request #15997: URL: https://github.com/apache/beam/pull/15997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] kennknowles commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
kennknowles commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970867722 I see. Good point. Still LGTM. (and I trust your judgment so feel free to merge in the form you think is best) -- This is an automated message from the Apache Git Service.

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] lostluck merged pull request #15999: Golint fixes for recent Go SDK import

2021-11-16 Thread GitBox
lostluck merged pull request #15999: URL: https://github.com/apache/beam/pull/15999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] riteshghorse commented on pull request #15999: Golint fixes for recent Go SDK import

2021-11-16 Thread GitBox
riteshghorse commented on pull request #15999: URL: https://github.com/apache/beam/pull/15999#issuecomment-970748072 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] riteshghorse opened a new pull request #15999: Golint fixes for recent Go SDK import

2021-11-16 Thread GitBox
riteshghorse opened a new pull request #15999: URL: https://github.com/apache/beam/pull/15999 Fixes Golint issue in recent import Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] riteshghorse commented on pull request #15999: Golint fixes for recent Go SDK import

2021-11-16 Thread GitBox
riteshghorse commented on pull request #15999: URL: https://github.com/apache/beam/pull/15999#issuecomment-970747653 Run Go PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] MiguelAnzoWizeline commented on pull request #15694: [BEAM-12645][WIP] Add coverage report for go

2021-11-16 Thread GitBox
MiguelAnzoWizeline commented on pull request #15694: URL: https://github.com/apache/beam/pull/15694#issuecomment-970742997 Thank for the help with the job! It seems that the check is running fine, I'm checking why is not being reported as it should. -- This is an automated message fro

[GitHub] [beam] robertwb commented on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
robertwb commented on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-970732012 Looks like someone is monkey-patching mock into there and it's not getting un-mocked... It passed locally. I'll try to fix this. -- This is an automated message from the Apac

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2021-11-16 Thread GitBox
pabloem commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-970727554 hi @aromanenko-dev : ) - I'd love to get this in for the release cut on wednesday (though don't feel pressured to allow bad quality code. if fixes are needed, I'll happily make t

[GitHub] [beam] lostluck merged pull request #15985: Go Quickstart: switch to Spark 3 JobServer for better out-of-box experience using embedded Spark cluster

2021-11-16 Thread GitBox
lostluck merged pull request #15985: URL: https://github.com/apache/beam/pull/15985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] lostluck merged pull request #15945: Update the go get command with v2

2021-11-16 Thread GitBox
lostluck merged pull request #15945: URL: https://github.com/apache/beam/pull/15945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] suztomo commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970722180 @kennknowles gcsio 2.2.4 requires flogger 0.7.1. In this case, I think one commit is better (even when we revert the version). -- This is an automated message from the Apache G

[GitHub] [beam] chamikaramj commented on pull request #15857: Allow wildcards for java class lookup transform providers.

2021-11-16 Thread GitBox
chamikaramj commented on pull request #15857: URL: https://github.com/apache/beam/pull/15857#issuecomment-970720304 Seems like Python failure is related: https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/20540/testReport/junit/apache_beam.utils.subprocess_server_test/JavaJarServer

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] mattcasters commented on pull request #15916: [BEAM-1857] Add Neo4jIO (initial code drop)

2021-11-16 Thread GitBox
mattcasters commented on pull request #15916: URL: https://github.com/apache/beam/pull/15916#issuecomment-970715935 Ah, I had a look at that file and it seems like they changed the option to `-PenableCheckerFramework=true`. That works for me at least. Now we can puzzle :-) -- This is

[GitHub] [beam] kennknowles commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
kennknowles commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970714381 I think separate commit per upgrade is useful, in case we want to `git revert` just one of the commits. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [beam] suztomo edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970707402 R: @kennknowles @mprashanthsagar @dzou 33 successful checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] suztomo commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970707402 R: @kennknowles @mprashanthsagar 33 successful checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] lostluck commented on pull request #15694: [BEAM-12645][WIP] Add coverage report for go

2021-11-16 Thread GitBox
lostluck commented on pull request #15694: URL: https://github.com/apache/beam/pull/15694#issuecomment-970707111 Patched in, and re-ran. I see a github check here! "@github-actions Go tests / build (pull_request) " https://github.com/apache/beam/runs/4230883999?check_suite_focus=true

[GitHub] [beam] lostluck commented on pull request #15962: Pr 15694 seed job help

2021-11-16 Thread GitBox
lostluck commented on pull request #15962: URL: https://github.com/apache/beam/pull/15962#issuecomment-970706204 Run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] pabloem commented on pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2021-11-16 Thread GitBox
pabloem commented on pull request #15378: URL: https://github.com/apache/beam/pull/15378#issuecomment-970700349 @kennknowles PTAL : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] tvalentyn merged pull request #15988: update dlp dependency version range

2021-11-16 Thread GitBox
tvalentyn merged pull request #15988: URL: https://github.com/apache/beam/pull/15988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] tvalentyn commented on pull request #15988: update dlp dependency version range

2021-11-16 Thread GitBox
tvalentyn commented on pull request #15988: URL: https://github.com/apache/beam/pull/15988#issuecomment-970693741 Postcommit failure is a known issue tracked in BEAM-13218. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] codecov[bot] edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970609592 # [Codecov](https://codecov.io/gh/apache/beam/pull/15997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970609592 # [Codecov](https://codecov.io/gh/apache/beam/pull/15997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo closed pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
suztomo closed pull request #14921: URL: https://github.com/apache/beam/pull/14921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #15675: [BEAM-12313] - Initial changes to support Java 17 SDK Harness docker image

2021-11-16 Thread GitBox
pabloem commented on pull request #15675: URL: https://github.com/apache/beam/pull/15675#issuecomment-970673033 this looks fine to me, though I'll let @kennknowles finish the review as he had started doing it, and must have more context. Happy to help with seed jobs / etc -- This is an

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-970672887 Java preommit and Java postcommit both succeeded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [beam] suztomo commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970671096 Run Java Postcommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970669288 Run Java_Examples_Dataflow PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on pull request #15995: [BEAM-13264] Allow pyarrow up to 6.x

2021-11-16 Thread GitBox
TheNeuralBit commented on pull request #15995: URL: https://github.com/apache/beam/pull/15995#issuecomment-970650641 I can give it a shot in a separate PR to trial run the process On Tue, Nov 16, 2021, 12:09 PM tvalentyn ***@***.***> wrote: > If you'd like to update pyarrow in

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970609592 # [Codecov](https://codecov.io/gh/apache/beam/pull/15997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] tvalentyn commented on pull request #15995: [BEAM-13264] Allow pyarrow up to 6.x

2021-11-16 Thread GitBox
tvalentyn commented on pull request #15995: URL: https://github.com/apache/beam/pull/15995#issuecomment-970638930 > If you'd like to update pyarrow in beam's containers, you could try fetch changes from master and run gradlew :sdks:python:container:generatePythonRequirementsAll. You

[GitHub] [beam] kennknowles commented on a change in pull request #15998: [BEAM-13265] Allow for no-reshuffle optimization in BigQueryIO.Write

2021-11-16 Thread GitBox
kennknowles commented on a change in pull request #15998: URL: https://github.com/apache/beam/pull/15998#discussion_r750622496 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TagWithUniqueIds.java ## @@ -38,15 +39,32 @@ pri

[GitHub] [beam] pabloem commented on pull request #15963: [BEAM-8033] Throwing an error if a dataSourceProviderFn is defined twice

2021-11-16 Thread GitBox
pabloem commented on pull request #15963: URL: https://github.com/apache/beam/pull/15963#issuecomment-970637193 thanks <3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] pabloem merged pull request #15963: [BEAM-8033] Throwing an error if a dataSourceProviderFn is defined twice

2021-11-16 Thread GitBox
pabloem merged pull request #15963: URL: https://github.com/apache/beam/pull/15963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] TheNeuralBit merged pull request #15995: [BEAM-13264] Allow pyarrow up to 6.x

2021-11-16 Thread GitBox
TheNeuralBit merged pull request #15995: URL: https://github.com/apache/beam/pull/15995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
suztomo edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-970631158 Run Java PreCommit 2 tests failed: ``` org.apache.beam.runners.flink.FlinkSavepointTest.testSavepointRestoreLegacy org.apache.beam.sdk.io.gcp.pubsublite

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-970631158 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970609592 # [Codecov](https://codecov.io/gh/apache/beam/pull/15997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-970618990 Run Java_Examples_Dataflow PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970609592 # [Codecov](https://codecov.io/gh/apache/beam/pull/15997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] minherz commented on pull request #15988: update dlp dependency version range

2021-11-16 Thread GitBox
minherz commented on pull request #15988: URL: https://github.com/apache/beam/pull/15988#issuecomment-970613868 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970609592 # [Codecov](https://codecov.io/gh/apache/beam/pull/15997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
codecov[bot] commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970609592 # [Codecov](https://codecov.io/gh/apache/beam/pull/15997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [beam] DonAtMabl commented on pull request #15224: [BEAM-12661] Fix stuck GetData Windmill calls

2021-11-16 Thread GitBox
DonAtMabl commented on pull request #15224: URL: https://github.com/apache/beam/pull/15224#issuecomment-970607927 In my case it seems to have been caused by an internal GCP issue. We opened a ticket and it was resolved. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [beam] suztomo edited a comment on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo edited a comment on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970607339 https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/19714/consoleFull ``` 14:22:10 > Task :runners:core-construction-java:compileJava 14:22:10 Note: Some

[GitHub] [beam] suztomo commented on pull request #15997: [BEAM-8688] Upgrading gcsio library to latest along with flogger

2021-11-16 Thread GitBox
suztomo commented on pull request #15997: URL: https://github.com/apache/beam/pull/15997#issuecomment-970607339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] slavachernyak opened a new pull request #15998: [BEAM-13265] Allow for no-reshuffle optimization in BigQueryIO.Write

2021-11-16 Thread GitBox
slavachernyak opened a new pull request #15998: URL: https://github.com/apache/beam/pull/15998 In certain situations it is beneficial to skip the reshuffle - add that as an experimental optimization to BigQueryIO.Write when using STREAMING_INSERTS mode R:@kennknowles

[GitHub] [beam] codecov[bot] edited a comment on pull request #15665: [BEAM-12999] Add ReshufflePerKey and ReshufflePerRandomKey Transform

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #15665: URL: https://github.com/apache/beam/pull/15665#issuecomment-935233129 # [Codecov](https://codecov.io/gh/apache/beam/pull/15665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2021-11-16 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-970586634 Run Java_Examples_Dataflow PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   >