[GitHub] [beam] nausharipov commented on a diff in pull request #17205: [BEAM-14145] [Website] add carousel to homepage

2022-04-06 Thread GitBox
nausharipov commented on code in PR #17205: URL: https://github.com/apache/beam/pull/17205#discussion_r844648342 ## website/www/site/assets/js/quotes-slider.js: ## @@ -10,33 +10,99 @@ // License for the specific language governing permissions and limitations under // the Lice

[GitHub] [beam] nishantjain91 commented on pull request #17297: [BEAM-14000] Fixes Elastic search IO doesnot work when both password and keystore are used

2022-04-06 Thread GitBox
nishantjain91 commented on PR #17297: URL: https://github.com/apache/beam/pull/17297#issuecomment-1091082592 For test, can you guide me how to setup a elastic cluster with ssl and username/password configuration -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] nishantjain91 commented on a diff in pull request #17297: [BEAM-14000] Fixes Elastic search IO doesnot work when both password and keystore are used

2022-04-06 Thread GitBox
nishantjain91 commented on code in PR #17297: URL: https://github.com/apache/beam/pull/17297#discussion_r844660303 ## sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java: ## @@ -637,13 +638,16 @@ RestClient createClient() throws IOE

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-06 Thread GitBox
ryanthompson591 commented on code in PR #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r844607799 ## sdks/python/apache_beam/ml/inference/base.py: ## @@ -0,0 +1,262 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor lice

[GitHub] [beam] ryanthompson591 commented on pull request #16970: [BEAM-13982] A base class for run inference

2022-04-06 Thread GitBox
ryanthompson591 commented on PR #16970: URL: https://github.com/apache/beam/pull/16970#issuecomment-1091032504 @TheNeuralBit I'm not opposed to discussing the interface, though you are right, this has been discussed a lot, leading to many delays in this project. It sounds like you are a

[GitHub] [beam] chamikaramj commented on pull request #16981: [BEAM-14009] Sets 'sdk_harness_container_images' property for all Dataflow jobs - Java SDK

2022-04-06 Thread GitBox
chamikaramj commented on PR #16981: URL: https://github.com/apache/beam/pull/16981#issuecomment-1090976467 @kennknowles we can set this property for all Dataflow jobs now. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] chamikaramj commented on pull request #16974: [BEAM-14009] Sets 'sdk_harness_container_images' property for all Dataflow jobs - Python SDK

2022-04-06 Thread GitBox
chamikaramj commented on PR #16974: URL: https://github.com/apache/beam/pull/16974#issuecomment-1090976442 @kennknowles we can set this property for all Dataflow jobs now. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] thiagotnunes commented on a diff in pull request #17200: [BEAM-12164]: fix the autoscaling backlog estimation for Spanner Change Streams Connector

2022-04-06 Thread GitBox
thiagotnunes commented on code in PR #17200: URL: https://github.com/apache/beam/pull/17200#discussion_r844548301 ## sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimatorTest.java: ## @@ -0,0 +1,115 @@ +

[GitHub] [beam] reuvenlax merged pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark

2022-04-06 Thread GitBox
reuvenlax merged PR #17262: URL: https://github.com/apache/beam/pull/17262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apach

[GitHub] [beam] robertwb commented on a diff in pull request #17280: [BEAM-14251] add output_coder_override to ExpansionRequest

2022-04-06 Thread GitBox
robertwb commented on code in PR #17280: URL: https://github.com/apache/beam/pull/17280#discussion_r844532488 ## model/job-management/src/main/proto/beam_expansion_api.proto: ## @@ -46,6 +46,9 @@ message ExpansionRequest { // A namespace (prefix) to use for the id of any newl

[GitHub] [beam] TheNeuralBit commented on pull request #17308: [BEAM-11745] Fix author list rendering

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17308: URL: https://github.com/apache/beam/pull/17308#issuecomment-1090951149 ![image](https://user-images.githubusercontent.com/675055/162095791-a28d49e1-3923-41dd-867a-41595ff9a948.png) -- This is an automated message from the Apache Git Service. To res

[GitHub] [beam] TheNeuralBit commented on pull request #17308: [BEAM-11745] Fix author list rendering

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17308: URL: https://github.com/apache/beam/pull/17308#issuecomment-1090950900 ![image](https://user-images.githubusercontent.com/675055/162095733-1afd37ee-7d05-4958-ba88-9eeb0e0aaac9.png) -- This is an automated message from the Apache Git Service. To res

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090949988 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] TheNeuralBit commented on pull request #17308: [BEAM-11745] Fix author list rendering

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17308: URL: https://github.com/apache/beam/pull/17308#issuecomment-1090949386 Ideally we would do this with the [delimit](https://gohugo.io/functions/delimit/) function (as we do with categories, in this same file), but I can't for the life of me figure out how

[GitHub] [beam] robertwb commented on a diff in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-06 Thread GitBox
robertwb commented on code in PR #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r844531031 ## sdks/python/apache_beam/ml/inference/base.py: ## @@ -0,0 +1,262 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agr

[GitHub] [beam] apilloud commented on pull request #16911: [WIP][BEAM-12097] ZetaSQL OVER clause converted to Logical SQL Plan

2022-04-06 Thread GitBox
apilloud commented on PR #16911: URL: https://github.com/apache/beam/pull/16911#issuecomment-1090934645 The question is essentially what is the purpose of the ZetaSQL translation library. `AggregateScan` is a SQL query with a group by for example `select value*2, sum(key+1) from KeyValue gr

[GitHub] [beam] Shiv22Wabale commented on a diff in pull request #17279: [BEAM-14236] Parquet IO support for list to conform with Apache Parqu…

2022-04-06 Thread GitBox
Shiv22Wabale commented on code in PR #17279: URL: https://github.com/apache/beam/pull/17279#discussion_r844522034 ## sdks/python/apache_beam/io/parquetio_test.py: ## @@ -314,6 +348,28 @@ def test_sink_transform(self): | Map(json.dumps) assert_that(readback,

[GitHub] [beam] Shiv22Wabale commented on a diff in pull request #17279: [BEAM-14236] Parquet IO support for list to conform with Apache Parqu…

2022-04-06 Thread GitBox
Shiv22Wabale commented on code in PR #17279: URL: https://github.com/apache/beam/pull/17279#discussion_r844521163 ## sdks/python/apache_beam/io/parquetio_test.py: ## @@ -109,6 +111,37 @@ def setUp(self): ('favorite_number', pa.timestamp('ns'), Fal

[GitHub] [beam] TheNeuralBit opened a new pull request, #17308: [BEAM-11745] Fix author list rendering

2022-04-06 Thread GitBox
TheNeuralBit opened a new pull request, #17308: URL: https://github.com/apache/beam/pull/17308 GitHub Actions Tests Status (on master branch) [![Build python source distribution and wh

[GitHub] [beam] y1chi commented on a diff in pull request #17271: Factors enable_prime flag in when checking use_unified_worker conditions

2022-04-06 Thread GitBox
y1chi commented on code in PR #17271: URL: https://github.com/apache/beam/pull/17271#discussion_r844515506 ## sdks/python/apache_beam/runners/dataflow/internal/apiclient.py: ## @@ -1174,11 +1174,22 @@ def _use_unified_worker(pipeline_options): debug_options = pipeline_options

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #17159: [BEAM-11587] Generate PColl element from TableSchema

2022-04-06 Thread GitBox
TheNeuralBit commented on code in PR #17159: URL: https://github.com/apache/beam/pull/17159#discussion_r844504179 ## sdks/python/apache_beam/io/gcp/bigquery_schema_tools.py: ## @@ -0,0 +1,115 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribu

[GitHub] [beam-starter-java] apilloud commented on a diff in pull request #1: Initial commit

2022-04-06 Thread GitBox
apilloud commented on code in PR #1: URL: https://github.com/apache/beam-starter-java/pull/1#discussion_r844509689 ## README.md: ## @@ -1,5 +1,10 @@ # Apache Beam starter for Java +ℹ️ This repository is dual licensed on both [Apache ASL2](LICENSE-APACHE) and [MIT](LICENSE-MI

[GitHub] [beam] steveniemitz commented on pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark

2022-04-06 Thread GitBox
steveniemitz commented on PR #17262: URL: https://github.com/apache/beam/pull/17262#issuecomment-1090912966 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] TheNeuralBit merged pull request #17257: [BEAM-11936] Fix rawtypes warnings in SnowflakeIO

2022-04-06 Thread GitBox
TheNeuralBit merged PR #17257: URL: https://github.com/apache/beam/pull/17257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.ap

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #17257: [BEAM-11936] Fix rawtypes warnings in SnowflakeIO

2022-04-06 Thread GitBox
TheNeuralBit commented on code in PR #17257: URL: https://github.com/apache/beam/pull/17257#discussion_r844498553 ## sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServices.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] codecov[bot] commented on pull request #17306: [BEAM-14112] Fixed ReadFromBigQuery with Interactive Beam

2022-04-06 Thread GitBox
codecov[bot] commented on PR #17306: URL: https://github.com/apache/beam/pull/17306#issuecomment-1090900275 # [Codecov](https://codecov.io/gh/apache/beam/pull/17306?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] hengfengli commented on a diff in pull request #17200: [BEAM-12164]: fix the autoscaling backlog estimation for Spanner Change Streams Connector

2022-04-06 Thread GitBox
hengfengli commented on code in PR #17200: URL: https://github.com/apache/beam/pull/17200#discussion_r844491417 ## sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimatorTest.java: ## @@ -0,0 +1,57 @@ +/*

[GitHub] [beam] hengfengli commented on a diff in pull request #17200: [BEAM-12164]: fix the autoscaling backlog estimation for Spanner Change Streams Connector

2022-04-06 Thread GitBox
hengfengli commented on code in PR #17200: URL: https://github.com/apache/beam/pull/17200#discussion_r844491417 ## sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimatorTest.java: ## @@ -0,0 +1,57 @@ +/*

[GitHub] [beam] codecov[bot] commented on pull request #17307: DO NOT MERGE: Clone #17252 for seed job

2022-04-06 Thread GitBox
codecov[bot] commented on PR #17307: URL: https://github.com/apache/beam/pull/17307#issuecomment-1090897087 # [Codecov](https://codecov.io/gh/apache/beam/pull/17307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] hengfengli commented on a diff in pull request #17200: [BEAM-12164]: fix the autoscaling backlog estimation for Spanner Change Streams Connector

2022-04-06 Thread GitBox
hengfengli commented on code in PR #17200: URL: https://github.com/apache/beam/pull/17200#discussion_r844489873 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/TimestampUtils.java: ## @@ -30,6 +30,11 @@ BigD

[GitHub] [beam] ihji commented on a diff in pull request #17279: [BEAM-14236] Parquet IO support for list to conform with Apache Parqu…

2022-04-06 Thread GitBox
ihji commented on code in PR #17279: URL: https://github.com/apache/beam/pull/17279#discussion_r844483370 ## sdks/python/apache_beam/io/parquetio_test.py: ## @@ -109,6 +111,37 @@ def setUp(self): ('favorite_number', pa.timestamp('ns'), False),

[GitHub] [beam] youngoli commented on pull request #17259: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-04-06 Thread GitBox
youngoli commented on PR #17259: URL: https://github.com/apache/beam/pull/17259#issuecomment-1090893374 Resolved: [Dataflow Java Post Commit Tests](https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/86/) - All bugs on this have been addressed and determined to be non-relea

[GitHub] [beam] youngoli commented on pull request #17259: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-04-06 Thread GitBox
youngoli commented on PR #17259: URL: https://github.com/apache/beam/pull/17259#issuecomment-1090890684 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090887061 Run GoPortable PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] angoenka commented on a diff in pull request #17271: Factors enable_prime flag in when checking use_unified_worker conditions

2022-04-06 Thread GitBox
angoenka commented on code in PR #17271: URL: https://github.com/apache/beam/pull/17271#discussion_r844479607 ## sdks/python/apache_beam/runners/dataflow/internal/apiclient.py: ## @@ -1174,11 +1174,22 @@ def _use_unified_worker(pipeline_options): debug_options = pipeline_opti

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090886791 CommunityMetrics is perma-red: BEAM-14017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] KevinGG commented on pull request #17306: [BEAM-14112] Fixed ReadFromBigQuery with Interactive Beam

2022-04-06 Thread GitBox
KevinGG commented on PR #17306: URL: https://github.com/apache/beam/pull/17306#issuecomment-1090884493 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090883634 Run Portable_Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] ibzib commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
ibzib commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090877891 run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [beam] ibzib commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
ibzib commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090877318 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090875614 Turns out you can't run seed job if the author of the PR is not a committer. I cloned your PR in #17307 to run the seed job there. -- This is an automated message from the Apache Gi

[GitHub] [beam] KevinGG commented on pull request #17306: [BEAM-14112] Fixed ReadFromBigQuery with Interactive Beam

2022-04-06 Thread GitBox
KevinGG commented on PR #17306: URL: https://github.com/apache/beam/pull/17306#issuecomment-1090875094 I take the liberty to move forward the changes in https://github.com/apache/beam/pull/17153. Inspired by @chunyang 's changes, I added a dataclass to hold only necessary final attributes n

[GitHub] [beam] TheNeuralBit commented on pull request #17307: DO NOT MERGE: Clone #17252 for seed job

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17307: URL: https://github.com/apache/beam/pull/17307#issuecomment-1090874157 Run Seed Job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] TheNeuralBit opened a new pull request, #17307: DO NOT MERGE: Clone #17252 for seed job

2022-04-06 Thread GitBox
TheNeuralBit opened a new pull request, #17307: URL: https://github.com/apache/beam/pull/17307 GitHub Actions Tests Status (on master branch) [![Build python source distribution and

[GitHub] [beam] KevinGG opened a new pull request, #17306: [BEAM-14112] Fixed ReadFromBigQuery with Interactive Beam

2022-04-06 Thread GitBox
KevinGG opened a new pull request, #17306: URL: https://github.com/apache/beam/pull/17306 Converted the split_result attribute to a dataclass that is pickle-able and only stores paths and coder instead of sources or table schemas to further reduce the size of the transform objects and r

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090868648 Run CommunityMetrics PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] ibzib commented on pull request #17239: [BEAM-14226] Remove standalone seed job.

2022-04-06 Thread GitBox
ibzib commented on PR #17239: URL: https://github.com/apache/beam/pull/17239#issuecomment-1090867118 So it seems the main reason for having a standalone seed job still stands. But we probably don't need to run both of them as cron jobs. What do you think about leaving the standalone job ena

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090866689 Run Seed Job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] ibzib commented on pull request #17239: [BEAM-14226] Remove standalone seed job.

2022-04-06 Thread GitBox
ibzib commented on PR #17239: URL: https://github.com/apache/beam/pull/17239#issuecomment-1090864191 > Perhaps the seed job just doesn't create itself any more? That would probably be smart. Whoa, judging from the logs the seed job does generate itself. That definitely doesn't seem i

[GitHub] [beam] hengfengli commented on a diff in pull request #17200: [BEAM-12164]: fix the autoscaling backlog estimation for Spanner Change Streams Connector

2022-04-06 Thread GitBox
hengfengli commented on code in PR #17200: URL: https://github.com/apache/beam/pull/17200#discussion_r844462293 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dofn/ReadChangeStreamPartitionDoFn.java: ## @@ -98,6 +102,7 @@ pub

[GitHub] [beam] steveniemitz commented on pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark

2022-04-06 Thread GitBox
steveniemitz commented on PR #17262: URL: https://github.com/apache/beam/pull/17262#issuecomment-1090858243 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090854717 Run Seed Job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090854300 Run SQL_Java17 PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090854154 Run SQL PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] Shiv22Wabale commented on pull request #17279: [BEAM-14236] Parquet IO support for list to conform with Apache Parqu…

2022-04-06 Thread GitBox
Shiv22Wabale commented on PR #17279: URL: https://github.com/apache/beam/pull/17279#issuecomment-1090854055 R: @ihji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090853749 Run Portable_Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] kennknowles commented on pull request #17239: [BEAM-14226] Remove standalone seed job.

2022-04-06 Thread GitBox
kennknowles commented on PR #17239: URL: https://github.com/apache/beam/pull/17239#issuecomment-1090849183 Ah, and specifically, the seed job shared "library" code with all the other jobs, so it could be broken by breakage in the shared groovy files. It is all extremely fragile so this is a

[GitHub] [beam] kennknowles commented on pull request #17239: [BEAM-14226] Remove standalone seed job.

2022-04-06 Thread GitBox
kennknowles commented on PR #17239: URL: https://github.com/apache/beam/pull/17239#issuecomment-1090848197 We had cases where the seed job recreated itself and the new seed job was broken. If the seed job still recreates itself and a bug in the groovy could break it, we probably still want

[GitHub] [beam] steveniemitz commented on pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark

2022-04-06 Thread GitBox
steveniemitz commented on PR #17262: URL: https://github.com/apache/beam/pull/17262#issuecomment-1090835326 I filed BEAM-14269 for the pulsar flake -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] Abacn commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files

2022-04-06 Thread GitBox
Abacn commented on PR #17305: URL: https://github.com/apache/beam/pull/17305#issuecomment-1090827478 R: @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [beam] youngoli commented on pull request #17259: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-04-06 Thread GitBox
youngoli commented on PR #17259: URL: https://github.com/apache/beam/pull/17259#issuecomment-1090824901 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] lostluck commented on a diff in pull request #17265: [BEAM-11104] Add ProcessContinuation type to Go SDK

2022-04-06 Thread GitBox
lostluck commented on code in PR #17265: URL: https://github.com/apache/beam/pull/17265#discussion_r844235564 ## sdks/go/pkg/beam/core/funcx/fn.go: ## @@ -302,6 +305,16 @@ func (u *Fn) OutEventTime() (pos int, exists bool) { return -1, false } +// ProcessContinuation

[GitHub] [beam] lostluck commented on a diff in pull request #17216: Simplify specifying additional dependencies in Go SDK in XLang IOs

2022-04-06 Thread GitBox
lostluck commented on code in PR #17216: URL: https://github.com/apache/beam/pull/17216#discussion_r844431673 ## sdks/go/pkg/beam/core/runtime/xlangx/registry.go: ## @@ -276,6 +278,16 @@ func UseAutomatedJavaExpansionService(gradleTarget string) string { return autoJava

[GitHub] [beam] asf-ci commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files

2022-04-06 Thread GitBox
asf-ci commented on PR #17305: URL: https://github.com/apache/beam/pull/17305#issuecomment-1090817477 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files

2022-04-06 Thread GitBox
asf-ci commented on PR #17305: URL: https://github.com/apache/beam/pull/17305#issuecomment-1090817476 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] Abacn opened a new pull request, #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files

2022-04-06 Thread GitBox
Abacn opened a new pull request, #17305: URL: https://github.com/apache/beam/pull/17305 * Added overload versions of continuously for FileIO.match and .matchAll accepting a third matchUpdatedFiles parameter. * Watching for both new files and timestamp change of existing files

[GitHub] [beam] asf-ci commented on pull request #17305: [BEAM-14267] Update watchForNewFiles to allow watching updated files

2022-04-06 Thread GitBox
asf-ci commented on PR #17305: URL: https://github.com/apache/beam/pull/17305#issuecomment-1090817475 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] lostluck merged pull request #17302: [BEAM-14266] Replace deprecated ptypes package uses

2022-04-06 Thread GitBox
lostluck merged PR #17302: URL: https://github.com/apache/beam/pull/17302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] steveniemitz commented on pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark

2022-04-06 Thread GitBox
steveniemitz commented on PR #17262: URL: https://github.com/apache/beam/pull/17262#issuecomment-1090810652 `org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic` seems really flaky... -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] steveniemitz commented on pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark

2022-04-06 Thread GitBox
steveniemitz commented on PR #17262: URL: https://github.com/apache/beam/pull/17262#issuecomment-1090810369 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-06 Thread GitBox
TheNeuralBit commented on code in PR #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r844408711 ## sdks/python/apache_beam/ml/inference/base.py: ## @@ -0,0 +1,262 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [beam] lostluck commented on pull request #17161: [BEAM-13857] Switched Go IT script to using Go flags for expansion services

2022-04-06 Thread GitBox
lostluck commented on PR #17161: URL: https://github.com/apache/beam/pull/17161#issuecomment-1090805260 Run CommunityMetrics PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] ibzib merged pull request #17303: [BEAM-14262] Update plugins for Dockerized Jenkins.

2022-04-06 Thread GitBox
ibzib merged PR #17303: URL: https://github.com/apache/beam/pull/17303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] lostluck merged pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
lostluck merged PR #17304: URL: https://github.com/apache/beam/pull/17304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] ibzib commented on pull request #17303: [BEAM-14262] Update plugins for Dockerized Jenkins.

2022-04-06 Thread GitBox
ibzib commented on PR #17303: URL: https://github.com/apache/beam/pull/17303#issuecomment-1090794588 I asked infra about this before, but all I learned is we don't have permissions to view the list. This list seems to work well enough though. -- This is an automated message from th

[GitHub] [beam] steveniemitz commented on pull request #17262: [BEAM-14244] Use the supplied output timestamp for processing time timers rather than the input watermark

2022-04-06 Thread GitBox
steveniemitz commented on PR #17262: URL: https://github.com/apache/beam/pull/17262#issuecomment-1090776674 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] ibzib commented on pull request #17239: [BEAM-14226] Remove standalone seed job.

2022-04-06 Thread GitBox
ibzib commented on PR #17239: URL: https://github.com/apache/beam/pull/17239#issuecomment-1090773999 R: @kennknowles ping :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] damccorm commented on a diff in pull request #17296: [BEAM-14262] Remove deprecated Jenkins plugins.

2022-04-06 Thread GitBox
damccorm commented on code in PR #17296: URL: https://github.com/apache/beam/pull/17296#discussion_r844405535 ## .test-infra/dockerized-jenkins/plugins.txt: ## @@ -22,7 +22,6 @@ throttle-concurrents JiraTestResultReporter active-directory -analysis-core Review Comment: I

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-06 Thread GitBox
ryanthompson591 commented on code in PR #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r844405042 ## sdks/python/apache_beam/ml/inference/base.py: ## @@ -0,0 +1,194 @@ +import logging +import platform +import resource +import sys +import time +from typing impo

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-06 Thread GitBox
ryanthompson591 commented on code in PR #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r844405042 ## sdks/python/apache_beam/ml/inference/base.py: ## @@ -0,0 +1,194 @@ +import logging +import platform +import resource +import sys +import time +from typing impo

[GitHub] [beam] TheNeuralBit commented on pull request #17252: [BEAM-13657] Sunset python 3.6

2022-04-06 Thread GitBox
TheNeuralBit commented on PR #17252: URL: https://github.com/apache/beam/pull/17252#issuecomment-1090771809 Please also resolve the conflict in tox.ini -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] lostluck commented on pull request #17161: [BEAM-13857] Switched Go IT script to using Go flags for expansion services

2022-04-06 Thread GitBox
lostluck commented on PR #17161: URL: https://github.com/apache/beam/pull/17161#issuecomment-1090762615 Run XVR_Flink PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-06 Thread GitBox
TheNeuralBit commented on code in PR #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r844397432 ## sdks/python/apache_beam/ml/inference/base.py: ## @@ -0,0 +1,194 @@ +import logging +import platform +import resource +import sys +import time +from typing import

[GitHub] [beam] lostluck commented on pull request #17161: [BEAM-13857] Switched Go IT script to using Go flags for expansion services

2022-04-06 Thread GitBox
lostluck commented on PR #17161: URL: https://github.com/apache/beam/pull/17161#issuecomment-1090760773 Run Flink CrossLanguageValidatesRunner Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] johnjcasey commented on pull request #16888: DataflowRunner: Removed KafkaIO.Read SDF->Legacy forced override

2022-04-06 Thread GitBox
johnjcasey commented on PR #16888: URL: https://github.com/apache/beam/pull/16888#issuecomment-1090758689 I don't have much knowledge of whether runner can support SDF or not, sorry. I've been primarily focused on improving the SDF implementation, and less on where it has been running --

[GitHub] [beam] kennknowles commented on pull request #16888: DataflowRunner: Removed KafkaIO.Read SDF->Legacy forced override

2022-04-06 Thread GitBox
kennknowles commented on PR #16888: URL: https://github.com/apache/beam/pull/16888#issuecomment-1090749083 I know that @johnjcasey has looked into KafkaIO dynamic reads a bit lately. I do not know whether runner v1 has sufficient support for SDF to execute KafkaIO properly without the overr

[GitHub] [beam] johnjcasey commented on pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
johnjcasey commented on PR #17304: URL: https://github.com/apache/beam/pull/17304#issuecomment-1090721953 comments LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] youngoli commented on pull request #17259: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-04-06 Thread GitBox
youngoli commented on PR #17259: URL: https://github.com/apache/beam/pull/17259#issuecomment-1090717967 Run PostCommit_Java_Dataflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] youngoli commented on pull request #17259: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-04-06 Thread GitBox
youngoli commented on PR #17259: URL: https://github.com/apache/beam/pull/17259#issuecomment-1090717866 Run PostCommit_Java_DataflowV2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] youngoli commented on pull request #17259: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-04-06 Thread GitBox
youngoli commented on PR #17259: URL: https://github.com/apache/beam/pull/17259#issuecomment-1090717396 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] youngoli merged pull request #17295: [cherry-pick][release-2.38.0][BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constr

2022-04-06 Thread GitBox
youngoli merged PR #17295: URL: https://github.com/apache/beam/pull/17295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] pabloem merged pull request #17207: [Playground] add meta tags

2022-04-06 Thread GitBox
pabloem merged PR #17207: URL: https://github.com/apache/beam/pull/17207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.

[GitHub] [beam] pabloem commented on pull request #17207: [Playground] add meta tags

2022-04-06 Thread GitBox
pabloem commented on PR #17207: URL: https://github.com/apache/beam/pull/17207#issuecomment-1090712598 LGTM thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] codecov[bot] commented on pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
codecov[bot] commented on PR #17304: URL: https://github.com/apache/beam/pull/17304#issuecomment-1090706988 # [Codecov](https://codecov.io/gh/apache/beam/pull/17304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] github-actions[bot] commented on pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
github-actions[bot] commented on PR #17304: URL: https://github.com/apache/beam/pull/17304#issuecomment-1090697516 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] riteshghorse commented on pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
riteshghorse commented on PR #17304: URL: https://github.com/apache/beam/pull/17304#issuecomment-1090695047 R: @lostluck @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] asf-ci commented on pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
asf-ci commented on PR #17304: URL: https://github.com/apache/beam/pull/17304#issuecomment-1090694100 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
asf-ci commented on PR #17304: URL: https://github.com/apache/beam/pull/17304#issuecomment-1090694107 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] riteshghorse opened a new pull request, #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
riteshghorse opened a new pull request, #17304: URL: https://github.com/apache/beam/pull/17304 Small fixes for golint and godeprecated issues in Go SDK. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quic

[GitHub] [beam] asf-ci commented on pull request #17304: fixes golint and deprecated issues in recent Go SDK import

2022-04-06 Thread GitBox
asf-ci commented on PR #17304: URL: https://github.com/apache/beam/pull/17304#issuecomment-1090694109 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   3   >