[GitHub] [beam] lukecwik commented on pull request #17327: [BEAM-13015] Update the SDK harness grouping table to be memory bounded based upon the amount of assigned cache memory and to use an LRU evic

2022-04-08 Thread GitBox
lukecwik commented on PR #17327: URL: https://github.com/apache/beam/pull/17327#issuecomment-1093705714 R: @youngoli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] lukecwik opened a new pull request, #17327: [BEAM-13015] Update the SDK harness grouping table to be memory bounded based upon the amount of assigned cache memory and to use an LRU evi

2022-04-08 Thread GitBox
lukecwik opened a new pull request, #17327: URL: https://github.com/apache/beam/pull/17327 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] apilloud opened a new pull request, #17326: [BEAM-13151] Support multiple layers of AutoValue nesting

2022-04-08 Thread GitBox
apilloud opened a new pull request, #17326: URL: https://github.com/apache/beam/pull/17326 This supports AutoValue nesting, including Memoized. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and e

[GitHub] [beam] codecov[bot] commented on pull request #17323: [BEAM-14219] Auto opt-in SDK container image prebuilding when eligibl…

2022-04-08 Thread GitBox
codecov[bot] commented on PR #17323: URL: https://github.com/apache/beam/pull/17323#issuecomment-1093527824 # [Codecov](https://codecov.io/gh/apache/beam/pull/17323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] y1chi commented on pull request #17323: [BEAM-14219] Auto opt-in SDK container image prebuilding when eligibl…

2022-04-08 Thread GitBox
y1chi commented on PR #17323: URL: https://github.com/apache/beam/pull/17323#issuecomment-1093513329 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] chamikaramj merged pull request #17325: [BEAM-14263] Disable BigQueryIOStorageWriteIT for Runner v2 test suite

2022-04-08 Thread GitBox
chamikaramj merged PR #17325: URL: https://github.com/apache/beam/pull/17325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[GitHub] [beam] chamikaramj commented on pull request #17325: [BEAM-14263] Disable BigQueryIOStorageWriteIT for Runner v2 test suite

2022-04-08 Thread GitBox
chamikaramj commented on PR #17325: URL: https://github.com/apache/beam/pull/17325#issuecomment-1093468039 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] robertwb commented on a diff in pull request #17253: [BEAM-14213] Add API and construction time validation for Batched DoFns

2022-04-08 Thread GitBox
robertwb commented on code in PR #17253: URL: https://github.com/apache/beam/pull/17253#discussion_r846527918 ## sdks/python/apache_beam/transforms/batch_dofn_test.py: ## @@ -0,0 +1,123 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor li

[GitHub] [beam] github-actions[bot] commented on pull request #17324: [BEAM-13898] Add tests to the pubsubx package.

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #17324: URL: https://github.com/apache/beam/pull/17324#issuecomment-1093452485 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. Available commands: - `stop r

[GitHub] [beam] kileys commented on a diff in pull request #17312: [BEAM-14013] Add PreCommit Kotlin examples Jenkins Job

2022-04-08 Thread GitBox
kileys commented on code in PR #17312: URL: https://github.com/apache/beam/pull/17312#discussion_r846529919 ## .test-infra/jenkins/job_PreCommit_Kotlin_Examples.groovy: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [beam] chamikaramj commented on pull request #17325: [BEAM-14263] Disable BigQueryIOStorageWriteIT for Runner v2 test suite

2022-04-08 Thread GitBox
chamikaramj commented on PR #17325: URL: https://github.com/apache/beam/pull/17325#issuecomment-1093443797 R: @emilymye @kennknowles -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] tvalentyn commented on pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

2022-04-08 Thread GitBox
tvalentyn commented on PR #16658: URL: https://github.com/apache/beam/pull/16658#issuecomment-1093443621 > Another possibility is to try using `python -m pip install` in place of `pip install` throughout. It may help as well. I think this will work. -- This is an automated message

[GitHub] [beam] tvalentyn commented on a diff in pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

2022-04-08 Thread GitBox
tvalentyn commented on code in PR #16658: URL: https://github.com/apache/beam/pull/16658#discussion_r846529441 ## sdks/python/container/boot.go: ## @@ -137,46 +145,49 @@ func main() { options, err := provision.ProtoToJSON(info.GetPipelineOptions()) if err != ni

[GitHub] [beam] chamikaramj opened a new pull request, #17325: [BEAM-14263] Disable BigQueryIOStorageWriteIT for Runner v2 test suite

2022-04-08 Thread GitBox
chamikaramj opened a new pull request, #17325: URL: https://github.com/apache/beam/pull/17325 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution qu

[GitHub] [beam] tvalentyn commented on a diff in pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

2022-04-08 Thread GitBox
tvalentyn commented on code in PR #16658: URL: https://github.com/apache/beam/pull/16658#discussion_r846526882 ## sdks/python/container/boot.go: ## @@ -137,46 +145,49 @@ func main() { options, err := provision.ProtoToJSON(info.GetPipelineOptions()) if err != ni

[GitHub] [beam] codecov[bot] commented on pull request #17324: [BEAM-13898] Add tests to the pubsubx package.

2022-04-08 Thread GitBox
codecov[bot] commented on PR #17324: URL: https://github.com/apache/beam/pull/17324#issuecomment-1093429492 # [Codecov](https://codecov.io/gh/apache/beam/pull/17324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] tvalentyn commented on pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

2022-04-08 Thread GitBox
tvalentyn commented on PR #16658: URL: https://github.com/apache/beam/pull/16658#issuecomment-1093427827 Another possibility is to try using `python -m pip install` in place of `pip install` throughout. It may help as well. -- This is an automated message from the Apache Git Service. To r

[GitHub] [beam] lostluck opened a new pull request, #17324: [BEAM-13898] Add tests to the pubsubx package.

2022-04-08 Thread GitBox
lostluck opened a new pull request, #17324: URL: https://github.com/apache/beam/pull/17324 Use the pstest fake pubsub server to test the pubsubx package. Adds unit test coverage, and does small refactors to allow testing of the existing helper methods with the fake client.

[GitHub] [beam] tvalentyn commented on pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

2022-04-08 Thread GitBox
tvalentyn commented on PR #16658: URL: https://github.com/apache/beam/pull/16658#issuecomment-1093416997 As for what to do next... @phoerious if you are interested and have access to a GCP project, you could continue investigate what happens in https://github.com/apache/beam/pull/16658#issu

[GitHub] [beam] tvalentyn commented on pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

2022-04-08 Thread GitBox
tvalentyn commented on PR #16658: URL: https://github.com/apache/beam/pull/16658#issuecomment-1093407575 Here's a repro without Dataflow in the picture: ``` gcloud compute instances create valentyn-cos2 --zone=us-central1-f --project= --image-family cos-stable --image-project=cos-clou

[GitHub] [beam] robertwb commented on pull request #16970: [BEAM-13982] A base class for run inference

2022-04-08 Thread GitBox
robertwb commented on PR #16970: URL: https://github.com/apache/beam/pull/16970#issuecomment-1093401254 @TheNeuralBit I agree that there are still improvements that can be done to both the public and private APIs. I would declare even the public API here to be non-final and we should iterat

[GitHub] [beam] tvalentyn commented on pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

2022-04-08 Thread GitBox
tvalentyn commented on PR #16658: URL: https://github.com/apache/beam/pull/16658#issuecomment-1093395167 I spent some time debugging this today and got this far: Dataflow container pod for SDK container has the following mount (from container manifest): ``` "volumeMounts": [

[GitHub] [beam] robertwb merged pull request #17129: Improvements to Beam/Spark quickstart.

2022-04-08 Thread GitBox
robertwb merged PR #17129: URL: https://github.com/apache/beam/pull/17129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] robertwb merged pull request #17272: Cleanup docs on Shared.

2022-04-08 Thread GitBox
robertwb merged PR #17272: URL: https://github.com/apache/beam/pull/17272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] robertwb commented on a diff in pull request #17272: Cleanup docs on Shared.

2022-04-08 Thread GitBox
robertwb commented on code in PR #17272: URL: https://github.com/apache/beam/pull/17272#discussion_r846512037 ## sdks/python/apache_beam/utils/shared.py: ## @@ -55,18 +50,17 @@ def process(self, element): yield self._giant_list[element] p = beam.Pipeline() - shared_

[GitHub] [beam] ibzib commented on a diff in pull request #16928: [BEAM-11971] Re add reverted timer consistency PR

2022-04-08 Thread GitBox
ibzib commented on code in PR #16928: URL: https://github.com/apache/beam/pull/16928#discussion_r846505369 ## runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectTimerInternals.java: ## @@ -46,6 +52,11 @@ private DirectTimerInternals( this.processingTimeC

[GitHub] [beam] svetakvsundhar commented on pull request #17159: [BEAM-11587] Generate PColl element from TableSchema

2022-04-08 Thread GitBox
svetakvsundhar commented on PR #17159: URL: https://github.com/apache/beam/pull/17159#issuecomment-1093380765 thanks @TheNeuralBit ! Have added the two relevant files with the suggested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] y1chi commented on pull request #17323: [BEAM-14219] Auto opt-in SDK container image prebuilding when eligibl…

2022-04-08 Thread GitBox
y1chi commented on PR #17323: URL: https://github.com/apache/beam/pull/17323#issuecomment-1093374779 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] y1chi commented on pull request #17323: [BEAM-14219] Auto opt-in SDK container image prebuilding when eligibl…

2022-04-08 Thread GitBox
y1chi commented on PR #17323: URL: https://github.com/apache/beam/pull/17323#issuecomment-1093374455 Run Python Dataflow V2 ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] TheNeuralBit merged pull request #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
TheNeuralBit merged PR #17322: URL: https://github.com/apache/beam/pull/17322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.ap

[GitHub] [beam] y1chi opened a new pull request, #17323: [BEAM-14219] Auto opt-in SDK container image prebuilding when eligibl…

2022-04-08 Thread GitBox
y1chi opened a new pull request, #17323: URL: https://github.com/apache/beam/pull/17323 …e on DataflowRunner **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporat

[GitHub] [beam] KevinGG merged pull request #17314: [BEAM-10708] Updated beam_sql error message

2022-04-08 Thread GitBox
KevinGG merged PR #17314: URL: https://github.com/apache/beam/pull/17314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.

[GitHub] [beam] ahmedabu98 commented on pull request #17209: [BEAM-13945] add json type support for bigquery connector

2022-04-08 Thread GitBox
ahmedabu98 commented on PR #17209: URL: https://github.com/apache/beam/pull/17209#issuecomment-1093321653 Run PostCommit_Java_Dataflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] ibzib merged pull request #17276: Nit: correct description for precommit cron jobs.

2022-04-08 Thread GitBox
ibzib merged PR #17276: URL: https://github.com/apache/beam/pull/17276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] egalpin commented on pull request #17297: [BEAM-14000] Fixes Elastic search IO doesnot work when both password and keystore are used

2022-04-08 Thread GitBox
egalpin commented on PR #17297: URL: https://github.com/apache/beam/pull/17297#issuecomment-1093305644 @nishantjain91 I'm thinking it might be sufficient to test that calling `ConnectionConfiguration#createClient` with username/password, ssl, and then both set, would generate a RestClient w

[GitHub] [beam] tvalentyn commented on pull request #17321: [BEAM-13864] Add remaining Dataflow test suites for Python 3.9.

2022-04-08 Thread GitBox
tvalentyn commented on PR #17321: URL: https://github.com/apache/beam/pull/17321#issuecomment-1093299513 R: @AnandInguva -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] johnjcasey commented on pull request #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
johnjcasey commented on PR #17322: URL: https://github.com/apache/beam/pull/17322#issuecomment-1093284667 run python precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] benWize commented on pull request #17273: [BEAM-11714] Spotbugs print errors to Jenkins UI

2022-04-08 Thread GitBox
benWize commented on PR #17273: URL: https://github.com/apache/beam/pull/17273#issuecomment-1093245222 Thank you, Kiley! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] benWize commented on pull request #17312: [BEAM-14013] Add PreCommit Kotlin examples Jenkins Job

2022-04-08 Thread GitBox
benWize commented on PR #17312: URL: https://github.com/apache/beam/pull/17312#issuecomment-1093219743 R: @kileys -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] benWize commented on pull request #17312: [WIP][BEAM-14013] Add PreCommit Kotlin examples Jenkins Job

2022-04-08 Thread GitBox
benWize commented on PR #17312: URL: https://github.com/apache/beam/pull/17312#issuecomment-1093212737 Results of new Jenkins Job for Kotlin examples: https://ci-beam.apache.org/job/beam_PreCommit_Kotlin_Examples_Phrase/1/ -- This is an automated message from the Apache Git Service. To re

[GitHub] [beam] benWize commented on pull request #17312: [WIP][BEAM-14013] Add PreCommit Kotlin examples Jenkins Job

2022-04-08 Thread GitBox
benWize commented on PR #17312: URL: https://github.com/apache/beam/pull/17312#issuecomment-1093204288 Run Kotlin_Examples PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] kileys merged pull request #17273: [BEAM-11714] Spotbugs print errors to Jenkins UI

2022-04-08 Thread GitBox
kileys merged PR #17273: URL: https://github.com/apache/beam/pull/17273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.o

[GitHub] [beam] kileys commented on pull request #17316: [DO NOT MERGE] Seed job for BEAM-14013 Add PreCommit Kotlin examples Jenkins Job

2022-04-08 Thread GitBox
kileys commented on PR #17316: URL: https://github.com/apache/beam/pull/17316#issuecomment-1093158033 Run Seed Job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] codecov[bot] commented on pull request #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
codecov[bot] commented on PR #17322: URL: https://github.com/apache/beam/pull/17322#issuecomment-1093157959 # [Codecov](https://codecov.io/gh/apache/beam/pull/17322?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] benWize commented on pull request #17273: [BEAM-11714] Spotbugs print errors to Jenkins UI

2022-04-08 Thread GitBox
benWize commented on PR #17273: URL: https://github.com/apache/beam/pull/17273#issuecomment-1093150761 R: @kileys -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] johnjcasey commented on pull request #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
johnjcasey commented on PR #17322: URL: https://github.com/apache/beam/pull/17322#issuecomment-1093132424 R: @robertwb R: @emilymye -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] asf-ci commented on pull request #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
asf-ci commented on PR #17322: URL: https://github.com/apache/beam/pull/17322#issuecomment-1093131956 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] johnjcasey opened a new pull request, #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
johnjcasey opened a new pull request, #17322: URL: https://github.com/apache/beam/pull/17322 Update nullable coder to try and generate a deterministic value coder when it is requested as a deterministic coder. Thank you for your contribution! Follow thi

[GitHub] [beam] asf-ci commented on pull request #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
asf-ci commented on PR #17322: URL: https://github.com/apache/beam/pull/17322#issuecomment-1093131947 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17322: [BEAM-14281] add as_deterministic_coder to nullable coder

2022-04-08 Thread GitBox
asf-ci commented on PR #17322: URL: https://github.com/apache/beam/pull/17322#issuecomment-1093131953 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] commented on pull request #17321: [BEAM-13864] Add remaining Dataflow test suites for Python 3.9.

2022-04-08 Thread GitBox
codecov[bot] commented on PR #17321: URL: https://github.com/apache/beam/pull/17321#issuecomment-1093119335 # [Codecov](https://codecov.io/gh/apache/beam/pull/17321?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] tvalentyn commented on pull request #17321: [BEAM-13864] Add remaining Dataflow test suites for Python 3.9.

2022-04-08 Thread GitBox
tvalentyn commented on PR #17321: URL: https://github.com/apache/beam/pull/17321#issuecomment-1093092084 Run Python Examples_Dataflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] tvalentyn commented on pull request #17321: [BEAM-13864] Add remaining Dataflow test suites for Python 3.9.

2022-04-08 Thread GitBox
tvalentyn commented on PR #17321: URL: https://github.com/apache/beam/pull/17321#issuecomment-1093088783 Run Python Dataflow ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] tvalentyn commented on pull request #17321: [BEAM-13864] Add remaining Dataflow test suites for Python 3.9.

2022-04-08 Thread GitBox
tvalentyn commented on PR #17321: URL: https://github.com/apache/beam/pull/17321#issuecomment-1093088450 Run Dataflow Python ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] tvalentyn commented on pull request #17321: [BEAM-13864] Add remaining Dataflow test suites for Python 3.9.

2022-04-08 Thread GitBox
tvalentyn commented on PR #17321: URL: https://github.com/apache/beam/pull/17321#issuecomment-1093088297 Run Python 3.9 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] yeandy commented on pull request #17043: [BEAM-13966] Add pivot(), a non-deferred column operation on categorical columns

2022-04-08 Thread GitBox
yeandy commented on PR #17043: URL: https://github.com/apache/beam/pull/17043#issuecomment-1093086777 I see this error ``` ERROR: Could not find a version that satisfies the requirement cython==0.29.27 (from versions: 0.9.6.5, 0.9.6.6, 0.9.6.7, 0.9.6.8, 0.9.6.10b0, 0.9.6.10, 0.9.6.10

[GitHub] [beam] aromanenko-dev commented on pull request #17246: [WIP][BEAM-8715] Bump Avro version to 1.11.0

2022-04-08 Thread GitBox
aromanenko-dev commented on PR #17246: URL: https://github.com/apache/beam/pull/17246#issuecomment-1093085981 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] aromanenko-dev commented on pull request #17246: [WIP][BEAM-8715] Bump Avro version to 1.11.0

2022-04-08 Thread GitBox
aromanenko-dev commented on PR #17246: URL: https://github.com/apache/beam/pull/17246#issuecomment-1093085862 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] y1chi merged pull request #17106: [BEAM-13767] Remove eclipse plugin as it generates a lot of unused tasks

2022-04-08 Thread GitBox
y1chi merged PR #17106: URL: https://github.com/apache/beam/pull/17106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] codecov[bot] commented on pull request #17320: Do not merge.

2022-04-08 Thread GitBox
codecov[bot] commented on PR #17320: URL: https://github.com/apache/beam/pull/17320#issuecomment-1093077642 # [Codecov](https://codecov.io/gh/apache/beam/pull/17320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] asf-ci commented on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-08 Thread GitBox
asf-ci commented on PR #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1093046867 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-08 Thread GitBox
asf-ci commented on PR #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1093046862 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] commented on pull request #17319: [BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys

2022-04-08 Thread GitBox
codecov[bot] commented on PR #17319: URL: https://github.com/apache/beam/pull/17319#issuecomment-1093015207 # [Codecov](https://codecov.io/gh/apache/beam/pull/17319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] ahmedabu98 commented on pull request #17209: [BEAM-13945] add json type support for bigquery connector

2022-04-08 Thread GitBox
ahmedabu98 commented on PR #17209: URL: https://github.com/apache/beam/pull/17209#issuecomment-1093009473 Run PostCommit_Java_Dataflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] ahmedabu98 commented on pull request #17209: [BEAM-13945] add json type support for bigquery connector

2022-04-08 Thread GitBox
ahmedabu98 commented on PR #17209: URL: https://github.com/apache/beam/pull/17209#issuecomment-1093007196 @pabloem Thanks for running it and checking. I made a little fix to the table in apache-beam-testing, can you try again? Also, could the permission errors only be coming from my side?

[GitHub] [beam] asf-ci commented on pull request #17319: [BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys

2022-04-08 Thread GitBox
asf-ci commented on PR #17319: URL: https://github.com/apache/beam/pull/17319#issuecomment-1092981852 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17319: [BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys

2022-04-08 Thread GitBox
asf-ci commented on PR #17319: URL: https://github.com/apache/beam/pull/17319#issuecomment-1092981858 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17319: [BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys

2022-04-08 Thread GitBox
asf-ci commented on PR #17319: URL: https://github.com/apache/beam/pull/17319#issuecomment-1092981851 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] johnjcasey opened a new pull request, #17319: [BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys

2022-04-08 Thread GitBox
johnjcasey opened a new pull request, #17319: URL: https://github.com/apache/beam/pull/17319 Update the kafkaIO xlang integration test to publish and receive a null key instead of an empty byte string. This will validate the changes to KafkaIO Xlang that enables nullable keys and values

[GitHub] [beam] johnjcasey commented on pull request #17096: [BEAM-14111] Increase timeout for data handover in KafkaReader's internal queue

2022-04-08 Thread GitBox
johnjcasey commented on PR #17096: URL: https://github.com/apache/beam/pull/17096#issuecomment-1092898575 This makes sense to me. Could you attach your before and after measurements to this PR if you have them? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] johnjcasey commented on pull request #17268: [BEAM-10529] enable nullable for kafkaIO xlang

2022-04-08 Thread GitBox
johnjcasey commented on PR #17268: URL: https://github.com/apache/beam/pull/17268#issuecomment-1092884667 Ah, will do that in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] egalpin commented on pull request #17112: [BEAM-14064] fix es io windowing

2022-04-08 Thread GitBox
egalpin commented on PR #17112: URL: https://github.com/apache/beam/pull/17112#issuecomment-1092870262 So was the conclusion that the issue of holding back the watermark for in flight data being processed as part of a bundle was specific to FlinkRunner? i.e. other runners do in fact hold ba

[GitHub] [beam] kennknowles commented on pull request #17317: Unvendor bytebuddy

2022-04-08 Thread GitBox
kennknowles commented on PR #17317: URL: https://github.com/apache/beam/pull/17317#issuecomment-1092851833 run dataflow validatesrunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] kennknowles commented on pull request #17317: Unvendor bytebuddy

2022-04-08 Thread GitBox
kennknowles commented on PR #17317: URL: https://github.com/apache/beam/pull/17317#issuecomment-1092851703 run samza validatesrunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] kennknowles commented on pull request #17317: Unvendor bytebuddy

2022-04-08 Thread GitBox
kennknowles commented on PR #17317: URL: https://github.com/apache/beam/pull/17317#issuecomment-1092851577 run spark validatesrunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] kennknowles commented on pull request #17317: Unvendor bytebuddy

2022-04-08 Thread GitBox
kennknowles commented on PR #17317: URL: https://github.com/apache/beam/pull/17317#issuecomment-1092851455 run flink validatesrunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] kennknowles commented on pull request #17317: Unvendor bytebuddy

2022-04-08 Thread GitBox
kennknowles commented on PR #17317: URL: https://github.com/apache/beam/pull/17317#issuecomment-1092851351 run java postcommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] kennknowles commented on pull request #16931: Upgrade to Gradle 7.4

2022-04-08 Thread GitBox
kennknowles commented on PR #16931: URL: https://github.com/apache/beam/pull/16931#issuecomment-1092838394 It was a blend. Rebased and pushed to see where we are at now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] kennknowles commented on pull request #17106: [BEAM-13767] Remove eclipse plugin as it generates a lot of unused tasks

2022-04-08 Thread GitBox
kennknowles commented on PR #17106: URL: https://github.com/apache/beam/pull/17106#issuecomment-1092836655 Nobody responded to say they cared, so I think it can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [beam] bullet03 commented on pull request #17318: [BEAM-14247] [Website] add image

2022-04-08 Thread GitBox
bullet03 commented on PR #17318: URL: https://github.com/apache/beam/pull/17318#issuecomment-1092835429 R: @AydarZaynutdinov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] asf-ci commented on pull request #17318: [BEAM-14247] [Website] add image

2022-04-08 Thread GitBox
asf-ci commented on PR #17318: URL: https://github.com/apache/beam/pull/17318#issuecomment-1092835287 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17318: [BEAM-14247] [Website] add image

2022-04-08 Thread GitBox
asf-ci commented on PR #17318: URL: https://github.com/apache/beam/pull/17318#issuecomment-1092835283 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17318: [BEAM-14247] [Website] add image

2022-04-08 Thread GitBox
asf-ci commented on PR #17318: URL: https://github.com/apache/beam/pull/17318#issuecomment-1092835280 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] bullet03 opened a new pull request, #17318: [BEAM-14247] [Website] add image

2022-04-08 Thread GitBox
bullet03 opened a new pull request, #17318: URL: https://github.com/apache/beam/pull/17318 [BEAM-14247] - add compressed ipng - add image to content page Thank you for your contribution! Follow this checklist to help us incorporate your contributi

[GitHub] [beam] github-actions[bot] closed pull request #16636: Fix bug in the main_session unit test

2022-04-08 Thread GitBox
github-actions[bot] closed pull request #16636: Fix bug in the main_session unit test URL: https://github.com/apache/beam/pull/16636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] github-actions[bot] commented on pull request #16636: Fix bug in the main_session unit test

2022-04-08 Thread GitBox
github-actions[bot] commented on PR #16636: URL: https://github.com/apache/beam/pull/16636#issuecomment-1092828547 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. -- This is

[GitHub] [beam] thempatel commented on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-08 Thread GitBox
thempatel commented on PR #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1092822080 thanks @lostluck @lukecwik @tvalentyn @robertwb for the thoughtful reviews, i had fun on this one! 🙏🏽 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [beam] kennknowles commented on a diff in pull request #17070: Handle changing schemas in Storage API sink

2022-04-08 Thread GitBox
kennknowles commented on code in PR #17070: URL: https://github.com/apache/beam/pull/17070#discussion_r846065333 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/CreateTableDestinations.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apa

[GitHub] [beam] baeminbo commented on a diff in pull request #17201: [BEAM-14187] Fix concurrency issue in IsmReaderImpl

2022-04-08 Thread GitBox
baeminbo commented on code in PR #17201: URL: https://github.com/apache/beam/pull/17201#discussion_r845993595 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/IsmReaderImpl.java: ## @@ -370,7 +373,7 @@ boolean bloomFilterMightCon

[GitHub] [beam] bullet03 commented on pull request #17089: [BEAM-13992] [Website] update Contribute/Code Contribution Guide page

2022-04-08 Thread GitBox
bullet03 commented on PR #17089: URL: https://github.com/apache/beam/pull/17089#issuecomment-1092699858 This task was fixed in https://github.com/apache/beam/pull/17136 [BEAM-13991], that was merged in master. There is no more need in this PR. -- This is an automated message from the

[GitHub] [beam] bullet03 closed pull request #17089: [BEAM-13992] [Website] update Contribute/Code Contribution Guide page

2022-04-08 Thread GitBox
bullet03 closed pull request #17089: [BEAM-13992] [Website] update Contribute/Code Contribution Guide page URL: https://github.com/apache/beam/pull/17089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] baeminbo commented on a diff in pull request #17201: [BEAM-14187] Fix concurrency issue in IsmReaderImpl

2022-04-08 Thread GitBox
baeminbo commented on code in PR #17201: URL: https://github.com/apache/beam/pull/17201#discussion_r845919183 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/IsmReaderImpl.java: ## @@ -370,7 +373,7 @@ boolean bloomFilterMightCon

[GitHub] [beam] baeminbo commented on a diff in pull request #17201: [BEAM-14187] Fix concurrency issue in IsmReaderImpl

2022-04-08 Thread GitBox
baeminbo commented on code in PR #17201: URL: https://github.com/apache/beam/pull/17201#discussion_r845915573 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/IsmReaderImpl.java: ## @@ -370,7 +373,7 @@ boolean bloomFilterMightCon

[GitHub] [beam] baeminbo commented on a diff in pull request #17201: [BEAM-14187] Fix concurrency issue in IsmReaderImpl

2022-04-08 Thread GitBox
baeminbo commented on code in PR #17201: URL: https://github.com/apache/beam/pull/17201#discussion_r845915573 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/IsmReaderImpl.java: ## @@ -370,7 +373,7 @@ boolean bloomFilterMightCon

[GitHub] [beam] ihji merged pull request #17279: [BEAM-14236] Parquet IO support for list to conform with Apache Parqu…

2022-04-08 Thread GitBox
ihji merged PR #17279: URL: https://github.com/apache/beam/pull/17279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org