[GitHub] [beam] asf-ci commented on pull request #17764: Fix for creating NOT NULL fields for optional fields

2022-05-25 Thread GitBox
asf-ci commented on PR #17764: URL: https://github.com/apache/beam/pull/17764#issuecomment-1138160968 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17764: Fix for creating NOT NULL fields for optional fields

2022-05-25 Thread GitBox
asf-ci commented on PR #17764: URL: https://github.com/apache/beam/pull/17764#issuecomment-1138160975 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] nbali opened a new pull request, #17764: Fix for creating NOT NULL fields for optional fields

2022-05-25 Thread GitBox
nbali opened a new pull request, #17764: URL: https://github.com/apache/beam/pull/17764 We create a schema with NOT NULL fields even if the proto field is optional. IMO the code was at the wrong place in the switch-case instead of after it Thank you for

[GitHub] [beam] asf-ci commented on pull request #17764: Fix for creating NOT NULL fields for optional fields

2022-05-25 Thread GitBox
asf-ci commented on PR #17764: URL: https://github.com/apache/beam/pull/17764#issuecomment-1138160967 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] nbali commented on pull request #16773: DataflowRunner: Experiment added to disable unbounded PCcollection checks turning batch into streaming

2022-05-25 Thread GitBox
nbali commented on PR #16773: URL: https://github.com/apache/beam/pull/16773#issuecomment-1138130175 ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [beam] nbali commented on pull request #16888: Modified KafkaIO.Read SDF->Legacy forced override to fail if configured functionality would be lost

2022-05-25 Thread GitBox
nbali commented on PR #16888: URL: https://github.com/apache/beam/pull/16888#issuecomment-1138130150 ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [beam] lostluck commented on a diff in pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
lostluck commented on code in PR #17755: URL: https://github.com/apache/beam/pull/17755#discussion_r882286246 ## sdks/go/pkg/beam/core/runtime/exec/sdf.go: ## @@ -308,7 +308,12 @@ func (n *TruncateSizedRestriction) StartBundle(ctx context.Context, id string, d // Timestamp

[GitHub] [beam] riteshghorse commented on a diff in pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17755: URL: https://github.com/apache/beam/pull/17755#discussion_r882263387 ## sdks/go/pkg/beam/core/runtime/exec/sdf.go: ## @@ -308,7 +308,12 @@ func (n *TruncateSizedRestriction) StartBundle(ctx context.Context, id string, d // Times

[GitHub] [beam] riteshghorse commented on a diff in pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17755: URL: https://github.com/apache/beam/pull/17755#discussion_r882260463 ## sdks/go/pkg/beam/core/runtime/exec/sdf.go: ## @@ -308,7 +308,12 @@ func (n *TruncateSizedRestriction) StartBundle(ctx context.Context, id string, d // Times

[GitHub] [beam] codecov[bot] commented on pull request #17763: [BEAM-14516] Add context support for Python callables

2022-05-25 Thread GitBox
codecov[bot] commented on PR #17763: URL: https://github.com/apache/beam/pull/17763#issuecomment-1138048537 # [Codecov](https://codecov.io/gh/apache/beam/pull/17763?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] ihji opened a new pull request, #17763: [BEAM-14516] Add context support for Python callables

2022-05-25 Thread GitBox
ihji opened a new pull request, #17763: URL: https://github.com/apache/beam/pull/17763 Adding context support for Python callable. We could remove unnecessary workaround like: ``` PythonCallableSource.of( "lambda: __import__('apache_beam.ml.inference.sklearn_inference')"

[GitHub] [beam] robertwb commented on a diff in pull request #17761: [BEAM-14481] Make ScopedState explicitly not re-entrant

2022-05-25 Thread GitBox
robertwb commented on code in PR #17761: URL: https://github.com/apache/beam/pull/17761#discussion_r88407 ## sdks/python/apache_beam/runners/worker/operations.py: ## @@ -1214,9 +1213,9 @@ def __init__( def setup(self): # type: () -> None +_LOGGER.debug('Setup c

[GitHub] [beam] robertwb commented on pull request #17762: Add typing information to RunInferrence.

2022-05-25 Thread GitBox
robertwb commented on PR #17762: URL: https://github.com/apache/beam/pull/17762#issuecomment-1138012527 R: @yeandy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] robertwb opened a new pull request, #17762: Add typing information to RunInferrence.

2022-05-25 Thread GitBox
robertwb opened a new pull request, #17762: URL: https://github.com/apache/beam/pull/17762 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] youngoli commented on a diff in pull request #17748: [BEAM-14513] Add read transform and initial healthcare client

2022-05-25 Thread GitBox
youngoli commented on code in PR #17748: URL: https://github.com/apache/beam/pull/17748#discussion_r882199263 ## sdks/go/pkg/beam/io/healthcare/fhirio/read.go: ## @@ -0,0 +1,87 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agre

[GitHub] [beam] lostluck commented on a diff in pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
lostluck commented on code in PR #17755: URL: https://github.com/apache/beam/pull/17755#discussion_r882204700 ## sdks/go/pkg/beam/core/runtime/exec/sdf.go: ## @@ -308,7 +308,12 @@ func (n *TruncateSizedRestriction) StartBundle(ctx context.Context, id string, d // Timestamp

[GitHub] [beam] github-actions[bot] commented on pull request #17751: Bump google.golang.org/api from 0.76.0 to 0.81.0 in /sdks

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #17751: URL: https://github.com/apache/beam/pull/17751#issuecomment-1137961582 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. Available commands: - `stop r

[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap

2022-05-25 Thread GitBox
chamikaramj commented on PR #17696: URL: https://github.com/apache/beam/pull/17696#issuecomment-1137939966 Run XVR_JavaUsingPython_Dataflow PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] TheNeuralBit commented on pull request #17761: [BEAM-14481] Make ScopedState explicitly not re-entrant

2022-05-25 Thread GitBox
TheNeuralBit commented on PR #17761: URL: https://github.com/apache/beam/pull/17761#issuecomment-1137937121 Run Python 3.9 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] TheNeuralBit commented on pull request #17758: [BEAM-14336] Re-enable `flight_delays_it_test` with `apache-beam-testing` dataset

2022-05-25 Thread GitBox
TheNeuralBit commented on PR #17758: URL: https://github.com/apache/beam/pull/17758#issuecomment-1137936789 Run Python 3.9 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] codecov[bot] commented on pull request #17761: [BEAM-14481] Make ScopedState explicitly not re-entrant

2022-05-25 Thread GitBox
codecov[bot] commented on PR #17761: URL: https://github.com/apache/beam/pull/17761#issuecomment-1137936956 # [Codecov](https://codecov.io/gh/apache/beam/pull/17761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] youngoli merged pull request #17720: Bump cloud.google.com/go/storage from 1.22.0 to 1.22.1 in /sdks

2022-05-25 Thread GitBox
youngoli merged PR #17720: URL: https://github.com/apache/beam/pull/17720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] youngoli merged pull request #17759: Fix 2.38.0 download page.

2022-05-25 Thread GitBox
youngoli merged PR #17759: URL: https://github.com/apache/beam/pull/17759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] codecov[bot] commented on pull request #17751: Bump google.golang.org/api from 0.76.0 to 0.81.0 in /sdks

2022-05-25 Thread GitBox
codecov[bot] commented on PR #17751: URL: https://github.com/apache/beam/pull/17751#issuecomment-1137932677 # [Codecov](https://codecov.io/gh/apache/beam/pull/17751?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] TheNeuralBit commented on pull request #17758: [BEAM-14336] Re-enable `flight_delays_it_test` with `apache-beam-testing` dataset

2022-05-25 Thread GitBox
TheNeuralBit commented on PR #17758: URL: https://github.com/apache/beam/pull/17758#issuecomment-1137930008 Run Python_PVR_Flink PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] alejandrorm commented on pull request #17717: Add standard logging when exception is thrown

2022-05-25 Thread GitBox
alejandrorm commented on PR #17717: URL: https://github.com/apache/beam/pull/17717#issuecomment-1137924822 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] TheNeuralBit commented on pull request #17761: [BEAM-14481] Make ScopedState explicitly not re-entrant

2022-05-25 Thread GitBox
TheNeuralBit commented on PR #17761: URL: https://github.com/apache/beam/pull/17761#issuecomment-1137920391 Note that a9b5da8 fixes several locations where we re-entering `ScopedState` instances. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap

2022-05-25 Thread GitBox
chamikaramj commented on PR #17696: URL: https://github.com/apache/beam/pull/17696#issuecomment-1137902071 Run XVR_JavaUsingPython_Dataflow PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] TheNeuralBit opened a new pull request, #17761: [BEAM-14481] Make ScopedState explicitly not re-entrant

2022-05-25 Thread GitBox
TheNeuralBit opened a new pull request, #17761: URL: https://github.com/apache/beam/pull/17761 This PR makes both `ScopedState` implementations raise an `AssertionError` if re-entered. This is necessary because the "fast" implementation ends up with an inconsistent state when re-entered. In

[GitHub] [beam] robertwb commented on a diff in pull request #16818: [BEAM-13806] Add x-lang BigQuery IO integration test to Go SDK.

2022-05-25 Thread GitBox
robertwb commented on code in PR #16818: URL: https://github.com/apache/beam/pull/16818#discussion_r882152259 ## sdks/go/test/integration/io/xlang/bigquery/bigquery.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor li

[GitHub] [beam] kileys commented on pull request #17760: Update beam-master version for legacy

2022-05-25 Thread GitBox
kileys commented on PR #17760: URL: https://github.com/apache/beam/pull/17760#issuecomment-1137866164 R: @ihji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] kileys opened a new pull request, #17760: Update beam-master version for legacy

2022-05-25 Thread GitBox
kileys opened a new pull request, #17760: URL: https://github.com/apache/beam/pull/17760 New images: https://gcr.io/cloud-dataflow/v1beta3/beam-java8-latest-batch:beam-master05252022 https://gcr.io/cloud-dataflow/v1beta3/beam-java8-latest-streaming:beam-master05252022

[GitHub] [beam] robertwb commented on pull request #17327: [BEAM-13015] Update the SDK harness grouping table to be memory bounded based upon the amount of assigned cache memory and to use an LRU evic

2022-05-25 Thread GitBox
robertwb commented on PR #17327: URL: https://github.com/apache/beam/pull/17327#issuecomment-1137863948 I should note that before either change I was getting on the order of 15k ops/sec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb merged pull request #17568: [BEAM-14426] Allow skipping of any output when writing an empty PCollection.

2022-05-25 Thread GitBox
robertwb merged PR #17568: URL: https://github.com/apache/beam/pull/17568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] KevinGG commented on pull request #17736: [BEAM-14449] Support cluster provisioning when using Flink on Dataproc

2022-05-25 Thread GitBox
KevinGG commented on PR #17736: URL: https://github.com/apache/beam/pull/17736#issuecomment-1137852735 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] robertwb commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap

2022-05-25 Thread GitBox
robertwb commented on code in PR #17696: URL: https://github.com/apache/beam/pull/17696#discussion_r882117830 ## sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] robertwb commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap

2022-05-25 Thread GitBox
robertwb commented on code in PR #17696: URL: https://github.com/apache/beam/pull/17696#discussion_r882116881 ## sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] kileys commented on pull request #17739: [BEAM-14503] Add support for Flink 1.15

2022-05-25 Thread GitBox
kileys commented on PR #17739: URL: https://github.com/apache/beam/pull/17739#issuecomment-1137843884 Thanks Kyle! Filed https://issues.apache.org/jira/browse/INFRA-23301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap

2022-05-25 Thread GitBox
chamikaramj commented on PR #17696: URL: https://github.com/apache/beam/pull/17696#issuecomment-1137839650 Run XVR_JavaUsingPython_Dataflow PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] chamikaramj commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap

2022-05-25 Thread GitBox
chamikaramj commented on code in PR #17696: URL: https://github.com/apache/beam/pull/17696#discussion_r881987405 ## sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Softw

[GitHub] [beam] damccorm commented on a diff in pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
damccorm commented on code in PR #17755: URL: https://github.com/apache/beam/pull/17755#discussion_r882106313 ## sdks/go/pkg/beam/core/runtime/exec/sdf.go: ## @@ -308,7 +308,12 @@ func (n *TruncateSizedRestriction) StartBundle(ctx context.Context, id string, d // Timestamp

[GitHub] [beam] reuvenlax commented on pull request #17423: Handle invalid rows in the Storage Api sink

2022-05-25 Thread GitBox
reuvenlax commented on PR #17423: URL: https://github.com/apache/beam/pull/17423#issuecomment-1137834110 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] reuvenlax commented on pull request #17423: Handle invalid rows in the Storage Api sink

2022-05-25 Thread GitBox
reuvenlax commented on PR #17423: URL: https://github.com/apache/beam/pull/17423#issuecomment-1137833613 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] y1chi merged pull request #17756: [BEAM-14494] Fix publish_docker_images.sh

2022-05-25 Thread GitBox
y1chi merged PR #17756: URL: https://github.com/apache/beam/pull/17756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] jrmccluskey commented on a diff in pull request #17747: [BEAM-14505] Add Dataflow streaming pipeline update support to the Go SDK

2022-05-25 Thread GitBox
jrmccluskey commented on code in PR #17747: URL: https://github.com/apache/beam/pull/17747#discussion_r882097746 ## sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go: ## @@ -83,6 +87,8 @@ type JobOptions struct { TeardownPolicy string } +const replaceIdPlaceholder

[GitHub] [beam] jrmccluskey commented on a diff in pull request #17747: [BEAM-14505] Add Dataflow streaming pipeline update support to the Go SDK

2022-05-25 Thread GitBox
jrmccluskey commented on code in PR #17747: URL: https://github.com/apache/beam/pull/17747#discussion_r882097610 ## sdks/go/pkg/beam/runners/dataflow/dataflow_test.go: ## @@ -197,3 +197,50 @@ func TestGetJobOptions_DockerNoImage(t *testing.T) { t.Fatalf("getConta

[GitHub] [beam] y1chi opened a new pull request, #17759: Fix 2.38.0 download page.

2022-05-25 Thread GitBox
y1chi opened a new pull request, #17759: URL: https://github.com/apache/beam/pull/17759 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] youngoli commented on a diff in pull request #17690: Update Beam website to release 2.39.0

2022-05-25 Thread GitBox
youngoli commented on code in PR #17690: URL: https://github.com/apache/beam/pull/17690#discussion_r882088511 ## website/www/site/content/en/get-started/downloads.md: ## @@ -88,6 +88,14 @@ versions denoted `0.x.y`. ## Releases +### 2.39.0 (2022-05-25) +Official [source code

[GitHub] [beam] riteshghorse commented on a diff in pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17755: URL: https://github.com/apache/beam/pull/17755#discussion_r882066312 ## sdks/go/pkg/beam/core/runtime/exec/sdf.go: ## @@ -308,7 +308,12 @@ func (n *TruncateSizedRestriction) StartBundle(ctx context.Context, id string, d // Times

[GitHub] [beam] damccorm commented on a diff in pull request #17747: [BEAM-14505] Add Dataflow streaming pipeline update support to the Go SDK

2022-05-25 Thread GitBox
damccorm commented on code in PR #17747: URL: https://github.com/apache/beam/pull/17747#discussion_r882061858 ## sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go: ## @@ -239,6 +252,13 @@ func Translate(ctx context.Context, p *pipepb.Pipeline, opts *JobOptions, worker //

[GitHub] [beam] damccorm commented on a diff in pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
damccorm commented on code in PR #17755: URL: https://github.com/apache/beam/pull/17755#discussion_r882052841 ## sdks/go/pkg/beam/core/runtime/exec/sdf.go: ## @@ -308,7 +308,12 @@ func (n *TruncateSizedRestriction) StartBundle(ctx context.Context, id string, d // Timestamp

[GitHub] [beam] robertwb commented on pull request #17568: [BEAM-14426] Allow skipping of any output when writing an empty PCollection.

2022-05-25 Thread GitBox
robertwb commented on PR #17568: URL: https://github.com/apache/beam/pull/17568#issuecomment-1137784761 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] robertwb commented on pull request #17568: [BEAM-14426] Allow skipping of any output when writing an empty PCollection.

2022-05-25 Thread GitBox
robertwb commented on PR #17568: URL: https://github.com/apache/beam/pull/17568#issuecomment-1137783668 sdks:java:io:hcatalog:compileJava is failing again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] fernando-wizeline commented on a diff in pull request #17471: [BEAM-14170] - Create a test that runs sickbayed tests

2022-05-25 Thread GitBox
fernando-wizeline commented on code in PR #17471: URL: https://github.com/apache/beam/pull/17471#discussion_r882047968 ## runners/direct-java/build.gradle: ## @@ -178,6 +192,26 @@ task validatesRunner(type: Test) { } } +tasks.register("validatesRunnerSickbay", Test) { Rev

[GitHub] [beam] KevinGG commented on pull request #17736: [BEAM-14449] Support cluster provisioning when using Flink on Dataproc

2022-05-25 Thread GitBox
KevinGG commented on PR #17736: URL: https://github.com/apache/beam/pull/17736#issuecomment-1137763456 R: @rohdesamuel PTAL, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] KevinGG commented on pull request #17736: [BEAM-14449] Support cluster provisioning when using Flink on Dataproc

2022-05-25 Thread GitBox
KevinGG commented on PR #17736: URL: https://github.com/apache/beam/pull/17736#issuecomment-1137762995 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] lostluck merged pull request #17752: [BEAM-14509] Add several flags to dataflow runner

2022-05-25 Thread GitBox
lostluck merged PR #17752: URL: https://github.com/apache/beam/pull/17752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] riteshghorse commented on pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
riteshghorse commented on PR #17755: URL: https://github.com/apache/beam/pull/17755#issuecomment-1137760512 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] riteshghorse commented on pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on PR #17754: URL: https://github.com/apache/beam/pull/17754#issuecomment-1137760444 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] y1chi commented on pull request #17756: [BEAM-14494] Fix publish_docker_images.sh

2022-05-25 Thread GitBox
y1chi commented on PR #17756: URL: https://github.com/apache/beam/pull/17756#issuecomment-1137733522 Run Java_Examples_Dataflow_Java17 PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [beam] yeandy commented on a diff in pull request #17758: [BEAM-14336] Re-enable `flight_delays_it_test` with `apache-beam-testing` dataset

2022-05-25 Thread GitBox
yeandy commented on code in PR #17758: URL: https://github.com/apache/beam/pull/17758#discussion_r882020082 ## sdks/python/apache_beam/examples/dataframe/flight_delays_it_test.py: ## @@ -35,59 +35,58 @@ from apache_beam.testing.test_pipeline import TestPipeline -@unittest.s

[GitHub] [beam] msbukal commented on a diff in pull request #17741: [BEAM-14504] Add support for including addittional parameters to executebundle method in fhirio.

2022-05-25 Thread GitBox
msbukal commented on code in PR #17741: URL: https://github.com/apache/beam/pull/17741#discussion_r881954049 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleWithMetadata.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881994891 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go: ## @@ -299,3 +301,225 @@ func TestTracker_TrySplit(t *testing.T) { }) } }

[GitHub] [beam] reuvenlax commented on pull request #17423: Handle invalid rows in the Storage Api sink

2022-05-25 Thread GitBox
reuvenlax commented on PR #17423: URL: https://github.com/apache/beam/pull/17423#issuecomment-1137702810 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] commented on pull request #17758: [BEAM-14336] Re-enable `flight_delays_it_test` with `apache-beam-testing` dataset

2022-05-25 Thread GitBox
codecov[bot] commented on PR #17758: URL: https://github.com/apache/beam/pull/17758#issuecomment-1137700263 # [Codecov](https://codecov.io/gh/apache/beam/pull/17758?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] y1chi merged pull request #17690: Update Beam website to release 2.39.0

2022-05-25 Thread GitBox
y1chi merged PR #17690: URL: https://github.com/apache/beam/pull/17690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] Abacn commented on a diff in pull request #17604: [BEAM-14315] Match updated files continuously

2022-05-25 Thread GitBox
Abacn commented on code in PR #17604: URL: https://github.com/apache/beam/pull/17604#discussion_r881978749 ## sdks/python/apache_beam/io/filebasedsource.py: ## @@ -449,3 +458,102 @@ def expand(self, pvalue): | 'ReadRange' >> ParDo( _ReadRange(

[GitHub] [beam] Abacn commented on a diff in pull request #17604: [BEAM-14315] Match updated files continuously

2022-05-25 Thread GitBox
Abacn commented on code in PR #17604: URL: https://github.com/apache/beam/pull/17604#discussion_r881976544 ## sdks/python/apache_beam/io/filebasedsource.py: ## @@ -338,15 +338,25 @@ def default_output_coder(self): class _ExpandIntoRanges(DoFn): def __init__( - self, s

[GitHub] [beam] alejandrorm commented on pull request #17717: Add standard logging when exception is thrown

2022-05-25 Thread GitBox
alejandrorm commented on PR #17717: URL: https://github.com/apache/beam/pull/17717#issuecomment-1137666766 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881972483 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] TheNeuralBit commented on pull request #17758: [BEAM-14336] Re-enable `flight_delays_it_test` with `apache-beam-testing` dataset

2022-05-25 Thread GitBox
TheNeuralBit commented on PR #17758: URL: https://github.com/apache/beam/pull/17758#issuecomment-1137661255 R: @yeandy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] TheNeuralBit commented on pull request #17758: [BEAM-14336] Re-enable `flight_delays_it_test` with `apache-beam-testing` dataset

2022-05-25 Thread GitBox
TheNeuralBit commented on PR #17758: URL: https://github.com/apache/beam/pull/17758#issuecomment-1137661104 Run Python 3.9 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] TheNeuralBit opened a new pull request, #17758: [BEAM-14336] Re-enable `flight_delays_it_test` with `apache-beam-testing` dataset

2022-05-25 Thread GitBox
TheNeuralBit opened a new pull request, #17758: URL: https://github.com/apache/beam/pull/17758 The `bigquery-samples.airline_ontime_data.flights` dataset, which this integration test relied on, was deleted. I was able to find a dataset with largely equivalent data and copy it into `apache-b

[GitHub] [beam] github-actions[bot] commented on pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #17755: URL: https://github.com/apache/beam/pull/17755#issuecomment-1137658562 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] riteshghorse commented on pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
riteshghorse commented on PR #17755: URL: https://github.com/apache/beam/pull/17755#issuecomment-1137657668 R: @damccorm @youngoli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] github-actions[bot] commented on pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #17755: URL: https://github.com/apache/beam/pull/17755#issuecomment-1137656665 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck for label go. Available commands: - `stop revi

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881966575 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] codecov[bot] commented on pull request #17757: Adds __repr__ to NullableCoder

2022-05-25 Thread GitBox
codecov[bot] commented on PR #17757: URL: https://github.com/apache/beam/pull/17757#issuecomment-1137652718 # [Codecov](https://codecov.io/gh/apache/beam/pull/17757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881963324 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] ibzib merged pull request #17739: [BEAM-14503] Add support for Flink 1.15

2022-05-25 Thread GitBox
ibzib merged PR #17739: URL: https://github.com/apache/beam/pull/17739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881962204 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] y1chi commented on a diff in pull request #17690: Update Beam website to release 2.39.0

2022-05-25 Thread GitBox
y1chi commented on code in PR #17690: URL: https://github.com/apache/beam/pull/17690#discussion_r881961746 ## website/www/site/data/authors.yml: ## @@ -231,3 +231,6 @@ hermannb: iht: name: Israel Herraiz email: i...@google.com +yichi: + name: Yichi Zhang + email: zyi...

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881960322 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] Abacn commented on a diff in pull request #17604: [BEAM-14315] Match updated files continuously

2022-05-25 Thread GitBox
Abacn commented on code in PR #17604: URL: https://github.com/apache/beam/pull/17604#discussion_r881959947 ## sdks/python/apache_beam/io/avroio.py: ## @@ -176,20 +181,70 @@ def __init__( name and the value being the actual data. If False, it only returns the da

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881956686 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881955914 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] riteshghorse commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
riteshghorse commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881954256 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker)

[GitHub] [beam] jrmccluskey commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
jrmccluskey commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881944088 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go: ## @@ -299,3 +301,225 @@ func TestTracker_TrySplit(t *testing.T) { }) } } +

[GitHub] [beam] codecov[bot] commented on pull request #17756: [BEAM-14494] Fix publish_docker_images.sh

2022-05-25 Thread GitBox
codecov[bot] commented on PR #17756: URL: https://github.com/apache/beam/pull/17756#issuecomment-1137637094 # [Codecov](https://codecov.io/gh/apache/beam/pull/17756?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] ihji commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap

2022-05-25 Thread GitBox
ihji commented on code in PR #17696: URL: https://github.com/apache/beam/pull/17696#discussion_r881952432 ## sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [beam] TheNeuralBit merged pull request #17728: [BEAM-9324] Fix incompatibility of direct runner with cython

2022-05-25 Thread GitBox
TheNeuralBit merged PR #17728: URL: https://github.com/apache/beam/pull/17728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.ap

[GitHub] [beam] codecov[bot] commented on pull request #17755: [BEAM-11106] small nits to truncate sdf exec unit

2022-05-25 Thread GitBox
codecov[bot] commented on PR #17755: URL: https://github.com/apache/beam/pull/17755#issuecomment-1137633134 # [Codecov](https://codecov.io/gh/apache/beam/pull/17755?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] zwestrick commented on pull request #17757: Adds __repr__ to NullableCoder

2022-05-25 Thread GitBox
zwestrick commented on PR #17757: URL: https://github.com/apache/beam/pull/17757#issuecomment-1137624024 R: TheNeuralBit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] github-actions[bot] commented on pull request #17747: [BEAM-14505] Add Dataflow streaming pipeline update support to the Go SDK

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #17747: URL: https://github.com/apache/beam/pull/17747#issuecomment-1137623456 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label go. Available commands: - `stop

[GitHub] [beam] asf-ci commented on pull request #17757: Adds __repr__ to NullableCoder

2022-05-25 Thread GitBox
asf-ci commented on PR #17757: URL: https://github.com/apache/beam/pull/17757#issuecomment-1137622810 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] zwestrick opened a new pull request, #17757: Adds __repr__ to NullableCoder

2022-05-25 Thread GitBox
zwestrick opened a new pull request, #17757: URL: https://github.com/apache/beam/pull/17757 This will make it easier to see what underlying coder is in use, and matches several other coders in this file. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] asf-ci commented on pull request #17757: Adds __repr__ to NullableCoder

2022-05-25 Thread GitBox
asf-ci commented on PR #17757: URL: https://github.com/apache/beam/pull/17757#issuecomment-1137622798 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] asf-ci commented on pull request #17757: Adds __repr__ to NullableCoder

2022-05-25 Thread GitBox
asf-ci commented on PR #17757: URL: https://github.com/apache/beam/pull/17757#issuecomment-1137622797 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] damccorm commented on a diff in pull request #17754: [BEAM-14511] Growable Tracker for Go SDK

2022-05-25 Thread GitBox
damccorm commented on code in PR #17754: URL: https://github.com/apache/beam/pull/17754#discussion_r881913985 ## sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange.go: ## @@ -223,3 +229,119 @@ func (tracker *Tracker) GetRestriction() interface{} { func (tracker *Tracker) IsB

[GitHub] [beam] lnogueir commented on pull request #17748: [BEAM-14513] Add read transform and initial healthcare client

2022-05-25 Thread GitBox
lnogueir commented on PR #17748: URL: https://github.com/apache/beam/pull/17748#issuecomment-1137590300 R: @youngoli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

  1   2   >