[GitHub] [beam] VladMatyunin opened a new issue, #22360: [Task]: Update existing not self-contained code snippets on web-site to use Playground with code hiding

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22360: URL: https://github.com/apache/beam/issues/22360 ### What needs to happen? Update existing not self-contained code snippets on web-site to use Playground with code hiding TBD: clarifying requirements ### Issue Priority Priority

[GitHub] [beam] VladMatyunin opened a new issue, #22359: [Task]: Update Hugo Playground shortcode to pass named sections to show to Playground

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22359: URL: https://github.com/apache/beam/issues/22359 ### What needs to happen? Update Hugo Playground shortcode to pass named sections to show to Playground TBD: clarifying requirements ### Issue Priority Priority: 3 ### Issu

[GitHub] [beam] VladMatyunin opened a new issue, #22358: [Task]: Migrate Playground code editor to a new library

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22358: URL: https://github.com/apache/beam/issues/22358 ### What needs to happen? Migrate Playground code editor to a new library TBD: clarifying requirements ### Issue Priority Priority: 3 ### Issue Component Component:

[GitHub] [beam] mosche commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
mosche commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189893383 Thanks for catching that @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] VladMatyunin opened a new issue, #22357: [Task]: Modify Playground's code editor to handle hidden sections

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22357: URL: https://github.com/apache/beam/issues/22357 ### What needs to happen? - [ ] Code parser to load named sections by comments - [ ] Hide service comments in code editor - [ ] Hide specific sections of code in the editor ##

[GitHub] [beam] github-actions[bot] commented on pull request #22164: Modify RunInference to return PipelineResult for the benchmark tests

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22164: URL: https://github.com/apache/beam/pull/22164#issuecomment-1189888156 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] VladMatyunin opened a new issue, #22356: [Feature Request]: A code snippet that is not fully self-contained can run on the Playground (e.g. imports hidden, setup hidden).

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22356: URL: https://github.com/apache/beam/issues/22356 ### What would you like to happen? - [ ] Task1 ### Issue Priority Priority: 3 ### Issue Component Component: beam-playground -- This is an automated message from the

[GitHub] [beam] VladMatyunin opened a new issue, #22355: [Task]: Replace e2e examples with Playground on Website

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22355: URL: https://github.com/apache/beam/issues/22355 ### What needs to happen? Replace e2e examples with Playground on Website TBD: clarifying requirements ### Issue Priority Priority: 3 ### Issue Component Component:

[GitHub] [beam] AnandInguva commented on pull request #22164: Modify RunInference to return PipelineResult for the benchmark tests

2022-07-19 Thread GitBox
AnandInguva commented on PR #22164: URL: https://github.com/apache/beam/pull/22164#issuecomment-1189884047 R: @tvalentyn . This PR is needed for the benchmark tests as I need `PipelineResult` object to publish metrics to the BQ using `LoadTest` class -- This is an automated message from t

[GitHub] [beam] VladMatyunin opened a new issue, #22354: [Task]: Develop Hugo shortcodes to embed playground with specific snippets

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22354: URL: https://github.com/apache/beam/issues/22354 ### What needs to happen? Develop Hugo shortcodes to embed playground with specific snippets TBD: clarifying requirements ### Issue Priority Priority: 3 ### Issue Component

[GitHub] [beam] AnandInguva closed pull request #22254: Runinference examples for the wesbsite

2022-07-19 Thread GitBox
AnandInguva closed pull request #22254: Runinference examples for the wesbsite URL: https://github.com/apache/beam/pull/22254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] VladMatyunin opened a new issue, #22353: [Task]: Add support for loading multiple snippets via query string for Playground

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22353: URL: https://github.com/apache/beam/issues/22353 ### What needs to happen? Add support for loading multiple snippets via query string for Playground TBD: Clarifying requirements ### Issue Priority Priority: 3 ### Issue Co

[GitHub] [beam] VladMatyunin opened a new issue, #22352: [Task]: Implement filtering of Playground catalog to not include web-site examples in the catalog

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22352: URL: https://github.com/apache/beam/issues/22352 ### What needs to happen? Implement filtering of Playground catalog to not include web-site examples in the catalog TBD: clarifying requirements ### Issue Priority Priority: 3

[GitHub] [beam] VladMatyunin opened a new issue, #22351: [Task]: Develop Playground examples that will replace static snippets on transform catalog section of web-site

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22351: URL: https://github.com/apache/beam/issues/22351 ### What needs to happen? Develop Playground examples that will replace static snippets on transform catalog section of web-site TBD: clarifying requirements ### Issue Priority P

[GitHub] [beam] lukecwik merged pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
lukecwik merged PR #22345: URL: https://github.com/apache/beam/pull/22345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] shhivam commented on issue #19985: RedisIO.ReadAll incorrectly alters windowing behavior

2022-07-19 Thread GitBox
shhivam commented on issue #19985: URL: https://github.com/apache/beam/issues/19985#issuecomment-1189871571 Is this a verified bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] Amar3tto commented on pull request #22313: [CdapIO] Add integration tests for CdapIO (Batch)

2022-07-19 Thread GitBox
Amar3tto commented on PR #22313: URL: https://github.com/apache/beam/pull/22313#issuecomment-1189852153 Run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [beam] lukecwik merged pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik merged PR #22346: URL: https://github.com/apache/beam/pull/22346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #22350: Bump google.golang.org/api from 0.87.0 to 0.88.0 in /sdks

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22350: URL: https://github.com/apache/beam/pull/22350#issuecomment-1189836007 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label go. Available commands: - `stop revi

[GitHub] [beam] codecov[bot] commented on pull request #22350: Bump google.golang.org/api from 0.87.0 to 0.88.0 in /sdks

2022-07-19 Thread GitBox
codecov[bot] commented on PR #22350: URL: https://github.com/apache/beam/pull/22350#issuecomment-1189824701 # [Codecov](https://codecov.io/gh/apache/beam/pull/22350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] dependabot[bot] opened a new pull request, #22350: Bump google.golang.org/api from 0.87.0 to 0.88.0 in /sdks

2022-07-19 Thread GitBox
dependabot[bot] opened a new pull request, #22350: URL: https://github.com/apache/beam/pull/22350 Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.87.0 to 0.88.0. Release notes Sourced from https://github.com/googleapis/google-api-go-client/

[GitHub] [beam] reuvenlax commented on pull request #22347: [22188] Set allowed lateness in storage-api transform

2022-07-19 Thread GitBox
reuvenlax commented on PR #22347: URL: https://github.com/apache/beam/pull/22347#issuecomment-1189809756 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189808376 Run Java_PVR_Flink_Docker PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189740496 Run Python_PVR_Flink_Docker PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189740278 Run Python_PVR_Flink PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189740040 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189739859 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189739603 Run GoPortable PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] Abacn commented on issue #22331: [Bug]: JDBCIO Performance test has been broken for a long time

2022-07-19 Thread GitBox
Abacn commented on issue #22331: URL: https://github.com/apache/beam/issues/22331#issuecomment-1189731015 .take-issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] cisaacstern commented on issue #22349: [Feature Request]: Host docker images with the `conda` package manager for Beam's Python SDK.

2022-07-19 Thread GitBox
cisaacstern commented on issue #22349: URL: https://github.com/apache/beam/issues/22349#issuecomment-1189675038 IIUC, Yuvi discovered that copying the pre-compiled Beam boot script could be brittle, because it invokes system Python, whereas for this use case we want Python processes to run

[GitHub] [beam] cisaacstern commented on issue #22349: [Feature Request]: Host docker images with the `conda` package manager for Beam's Python SDK.

2022-07-19 Thread GitBox
cisaacstern commented on issue #22349: URL: https://github.com/apache/beam/issues/22349#issuecomment-1189666886 Thanks for raising this, Alex. @yuvipanda found a solution for us in Pangeo Forge which achieves this goal: https://github.com/pangeo-data/pangeo-docker-images/pull/355

[GitHub] [beam] alxmrs commented on issue #22349: [Feature Request]: Host docker images with the `conda` package manager for Beam's Python SDK.

2022-07-19 Thread GitBox
alxmrs commented on issue #22349: URL: https://github.com/apache/beam/issues/22349#issuecomment-1189664025 CC: @pabloem, @rabernat, @cisaacstern -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] alxmrs opened a new issue, #22349: [Feature Request]: Host docker images with the `conda` package manager for Beam's Python SDK.

2022-07-19 Thread GitBox
alxmrs opened a new issue, #22349: URL: https://github.com/apache/beam/issues/22349 ### What would you like to happen? Acquiring scientific dependencies in the Python ecosystem is challenging. `pip` and `apt-get` alone are not sufficient, for various reasons, the most significant of

[GitHub] [beam] github-actions[bot] commented on pull request #22304: Fix JDBCIOIT

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189659416 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189658999 R: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189655150 Run Java JdbcIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] chamikaramj commented on a diff in pull request #22308: Deduplicate identical environments in a pipeline.

2022-07-19 Thread GitBox
chamikaramj commented on code in PR #22308: URL: https://github.com/apache/beam/pull/22308#discussion_r925042609 ## sdks/python/apache_beam/pipeline.py: ## @@ -919,11 +918,49 @@ def visit_transform(self, transform_node): requirements=context.requirements()) proto.c

[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189629569 Run Java JdbcIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] codecov[bot] commented on pull request #22348: Initial Commit for AvroPayloadSerializer

2022-07-19 Thread GitBox
codecov[bot] commented on PR #22348: URL: https://github.com/apache/beam/pull/22348#issuecomment-1189622465 # [Codecov](https://codecov.io/gh/apache/beam/pull/22348?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] rahuliyer95 commented on issue #20996: BigQuery pipelines which query INFORMATION_SCHEMA views can fail to determine a query location

2022-07-19 Thread GitBox
rahuliyer95 commented on issue #20996: URL: https://github.com/apache/beam/issues/20996#issuecomment-1189612156 We also recently faced a similar issue and managed to work around this by setting the [withQueryLocation](https://beam.apache.org/releases/javadoc/2.40.0/org/apache/beam/sdk/io/gc

[GitHub] [beam] robertwb merged pull request #22327: Require unique names for stages.

2022-07-19 Thread GitBox
robertwb merged PR #22327: URL: https://github.com/apache/beam/pull/22327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #22348: Initial Commit for AvroPayloadSerializer

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22348: URL: https://github.com/apache/beam/pull/22348#issuecomment-1189607165 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] talatuyarer commented on pull request #22348: Initial Commit for AvroPayloadSerializer

2022-07-19 Thread GitBox
talatuyarer commented on PR #22348: URL: https://github.com/apache/beam/pull/22348#issuecomment-1189606385 R: @TheNeuralBit Could you review this ? This is initial commit. I will continue develop based on your feedbacks. Thanks -- This is an automated message from the Apache Git Se

[GitHub] [beam] talatuyarer opened a new pull request, #22348: Initial Commit for AvroPayloadSerializer

2022-07-19 Thread GitBox
talatuyarer opened a new pull request, #22348: URL: https://github.com/apache/beam/pull/22348 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution qu

[GitHub] [beam] Naireen commented on a diff in pull request #21915: convert windmill min timestamp to beam min timestamp

2022-07-19 Thread GitBox
Naireen commented on code in PR #21915: URL: https://github.com/apache/beam/pull/21915#discussion_r924989506 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java: ## @@ -351,12 +356,25 @@ public static Tim

[GitHub] [beam] codecov[bot] commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
codecov[bot] commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189580963 # [Codecov](https://codecov.io/gh/apache/beam/pull/22346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] codecov[bot] commented on pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
codecov[bot] commented on PR #22345: URL: https://github.com/apache/beam/pull/22345#issuecomment-1189577769 # [Codecov](https://codecov.io/gh/apache/beam/pull/22345?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] steveniemitz commented on a diff in pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
steveniemitz commented on code in PR #22345: URL: https://github.com/apache/beam/pull/22345#discussion_r924974526 ## sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteStringOutputStream.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [beam] lukecwik commented on pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
lukecwik commented on PR #22345: URL: https://github.com/apache/beam/pull/22345#issuecomment-1189562078 Run GoPortable PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189561951 Run Java_PVR_Flink_Docker PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189561737 Run GoPortable PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189538304 Run Java JdbcIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189537327 Run Java JdbcIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] github-actions[bot] commented on pull request #22347: [22188] Set allowed lateness in storage-api transform

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22347: URL: https://github.com/apache/beam/pull/22347#issuecomment-1189532502 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] reuvenlax commented on pull request #22347: [22188] Set allowed lateness in storage-api transform

2022-07-19 Thread GitBox
reuvenlax commented on PR #22347: URL: https://github.com/apache/beam/pull/22347#issuecomment-1189531694 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] AnandInguva commented on pull request #22255: [DONT MERGE]Pytest update debugging

2022-07-19 Thread GitBox
AnandInguva commented on PR #22255: URL: https://github.com/apache/beam/pull/22255#issuecomment-1189526543 Run XVR_JavaUsingPython_Dataflow PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] github-actions[bot] commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189515677 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] lukecwik commented on pull request #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik commented on PR #22346: URL: https://github.com/apache/beam/pull/22346#issuecomment-1189514829 R: @mosche @TheNeuralBit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] lukecwik opened a new pull request, #22346: [#22181] Fix java package for SDK java core benchmark org.apache.beam.sdk.schemas -> org.apache.beam.sdk.jmh.schemas

2022-07-19 Thread GitBox
lukecwik opened a new pull request, #22346: URL: https://github.com/apache/beam/pull/22346 Missed during review of https://github.com/apache/beam/pull/22182 Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] lostluck merged pull request #22332: Bump cloud.google.com/go/pubsub from 1.23.1 to 1.24.0 in /sdks

2022-07-19 Thread GitBox
lostluck merged PR #22332: URL: https://github.com/apache/beam/pull/22332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] lukecwik commented on a diff in pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
lukecwik commented on code in PR #22345: URL: https://github.com/apache/beam/pull/22345#discussion_r924909774 ## sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteStringOutputStream.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [beam] lukecwik commented on a diff in pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
lukecwik commented on code in PR #22345: URL: https://github.com/apache/beam/pull/22345#discussion_r924906442 ## sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteStringOutputStream.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [beam] AnandInguva commented on pull request #22255: [DONT MERGE]Pytest update debugging

2022-07-19 Thread GitBox
AnandInguva commented on PR #22255: URL: https://github.com/apache/beam/pull/22255#issuecomment-1189487538 Run XVR_JavaUsingPython_Dataflow PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] github-actions[bot] commented on pull request #22344: [BEAM-13004] DebeziumIO Load Test

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22344: URL: https://github.com/apache/beam/pull/22344#issuecomment-1189475119 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @AnandInguva for label python. Available commands: - `st

[GitHub] [beam] Abacn commented on pull request #22304: Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189453696 Run Java JdbcIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189444084 Run Java JdbcIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] Capstan commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`

2022-07-19 Thread GitBox
Capstan commented on PR #22022: URL: https://github.com/apache/beam/pull/22022#issuecomment-1189434932 See also https://issuetracker.google.com/236761233. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [beam] steveniemitz commented on a diff in pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
steveniemitz commented on code in PR #22345: URL: https://github.com/apache/beam/pull/22345#discussion_r924840472 ## sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteStringOutputStream.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [beam] steveniemitz commented on a diff in pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
steveniemitz commented on code in PR #22345: URL: https://github.com/apache/beam/pull/22345#discussion_r924838200 ## sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteStringOutputStream.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [beam] AnandInguva commented on pull request #22255: [DONT MERGE]Pytest update debugging

2022-07-19 Thread GitBox
AnandInguva commented on PR #22255: URL: https://github.com/apache/beam/pull/22255#issuecomment-1189419944 Run XVR_JavaUsingPython_Dataflow PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] github-actions[bot] commented on pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
github-actions[bot] commented on PR #22345: URL: https://github.com/apache/beam/pull/22345#issuecomment-1189399810 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] lukecwik commented on pull request #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
lukecwik commented on PR #22345: URL: https://github.com/apache/beam/pull/22345#issuecomment-1189398844 R: @steveniemitz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] lukecwik opened a new pull request, #22345: [BEAM-13015, #21250] Optimize encoding to a ByteString

2022-07-19 Thread GitBox
lukecwik opened a new pull request, #22345: URL: https://github.com/apache/beam/pull/22345 This leverages the fact that all encoding is done from a thread safe manner allowing us to drop the syncrhonization that ByteString.Output adds and it also optimizes the max chunk size based upon

[GitHub] [beam] bullet03 commented on pull request #22256: [Website] change getting window width method

2022-07-19 Thread GitBox
bullet03 commented on PR #22256: URL: https://github.com/apache/beam/pull/22256#issuecomment-1189379901 @pcoet, could you, please, review this PR? It is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [beam] lukecwik commented on pull request #22260: Generalize interface of InfluxDBPublisher to support more use cases (test-utils)

2022-07-19 Thread GitBox
lukecwik commented on PR #22260: URL: https://github.com/apache/beam/pull/22260#issuecomment-1189363806 Any of the people that you tagged seems to make sense but if they don't respond I can take a look once I'm back from vacation in two weeks. Also, I understand that we could customiz

[GitHub] [beam] lukecwik closed issue #22181: [Feature Request]: JMH benchmarks for getters / setters of GetterBasedSchemaProvider

2022-07-19 Thread GitBox
lukecwik closed issue #22181: [Feature Request]: JMH benchmarks for getters / setters of GetterBasedSchemaProvider URL: https://github.com/apache/beam/issues/22181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [beam] lukecwik merged pull request #22182: JMH module for sdks:java:core with benchmarks for GetterBasedSchemaProvider (resolves #22181)

2022-07-19 Thread GitBox
lukecwik merged PR #22182: URL: https://github.com/apache/beam/pull/22182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] codecov[bot] commented on pull request #22344: [BEAM-13004] DebeziumIO Load Test

2022-07-19 Thread GitBox
codecov[bot] commented on PR #22344: URL: https://github.com/apache/beam/pull/22344#issuecomment-1189354599 # [Codecov](https://codecov.io/gh/apache/beam/pull/22344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] lukecwik commented on a diff in pull request #22182: JMH module for sdks:java:core with benchmarks for GetterBasedSchemaProvider (resolves #22181)

2022-07-19 Thread GitBox
lukecwik commented on code in PR #22182: URL: https://github.com/apache/beam/pull/22182#discussion_r924774823 ## sdks/java/core/jmh/src/main/java/org/apache/beam/sdk/schemas/RowBundle.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [beam] yeandy commented on pull request #22131: TensorRT Initial commit

2022-07-19 Thread GitBox
yeandy commented on PR #22131: URL: https://github.com/apache/beam/pull/22131#issuecomment-1189341878 Oh, great to know! Thanks @pranavm-nvidia, I'll check that out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [beam] Abacn commented on pull request #22304: [WIP] Fix JDBCIOIT

2022-07-19 Thread GitBox
Abacn commented on PR #22304: URL: https://github.com/apache/beam/pull/22304#issuecomment-1189336542 Run Java JdbcIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] roger-mike opened a new pull request, #22344: [BEAM-13004] DebeziumIO Load Test

2022-07-19 Thread GitBox
roger-mike opened a new pull request, #22344: URL: https://github.com/apache/beam/pull/22344 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https:/

[GitHub] [beam] benWize commented on issue #21825: [Bug]: RedisIO#readKeyPatterns failing with OutOfMemory on version 2.39.0

2022-07-19 Thread GitBox
benWize commented on issue #21825: URL: https://github.com/apache/beam/issues/21825#issuecomment-1189332083 Hi Alexey, sorry for the late response, Miguel is busy and he can't take the issue, but we will find someone else in our team, to take this. -- This is an automated message from the

[GitHub] [beam] pranavm-nvidia commented on pull request #22131: TensorRT Initial commit

2022-07-19 Thread GitBox
pranavm-nvidia commented on PR #22131: URL: https://github.com/apache/beam/pull/22131#issuecomment-1189325427 @yeandy With Sphinx, you can specify modules to mock in your `conf.py` ([example](https://github.com/NVIDIA/TensorRT/blob/main/tools/Polygraphy/docs/conf.py#L34)). With that, you wo

[GitHub] [beam] yeandy commented on pull request #22131: TensorRT Initial commit

2022-07-19 Thread GitBox
yeandy commented on PR #22131: URL: https://github.com/apache/beam/pull/22131#issuecomment-1189323009 The Sphinx docs generation requires module imports `import tensorrt as trt` and `from cuda import cuda`. I think our script just needs to detect that those modules exist in `tensorrt_infere

[GitHub] [beam] damccorm commented on a diff in pull request #22316: cleaned up types in standard_coders.ts

2022-07-19 Thread GitBox
damccorm commented on code in PR #22316: URL: https://github.com/apache/beam/pull/22316#discussion_r924724441 ## sdks/typescript/src/apache_beam/coders/standard_coders.ts: ## @@ -28,52 +28,44 @@ import { } from "./coders"; import { BytesCoder, InstantCoder } from "./required_c

[GitHub] [beam] damccorm merged pull request #22316: cleaned up types in standard_coders.ts

2022-07-19 Thread GitBox
damccorm merged PR #22316: URL: https://github.com/apache/beam/pull/22316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] kumarrk21 closed issue #22279: [Bug]: BigQueryIO Storage API doesn't return errors in WriteResult when data schema mismatches BQ Schema

2022-07-19 Thread GitBox
kumarrk21 closed issue #22279: [Bug]: BigQueryIO Storage API doesn't return errors in WriteResult when data schema mismatches BQ Schema URL: https://github.com/apache/beam/issues/22279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [beam] kumarrk21 commented on issue #22279: [Bug]: BigQueryIO Storage API doesn't return errors in WriteResult when data schema mismatches BQ Schema

2022-07-19 Thread GitBox
kumarrk21 commented on issue #22279: URL: https://github.com/apache/beam/issues/22279#issuecomment-1189306985 Correct. Sorry, this was user error. Closing the issue now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] TheNeuralBit commented on issue #21131: Update to_dataframe API Docs to focus on schema use

2022-07-19 Thread GitBox
TheNeuralBit commented on issue #21131: URL: https://github.com/apache/beam/issues/21131#issuecomment-1189225795 See https://stackoverflow.com/questions/72996664 for an example of confusion this causes. proxy argument is being used rather than declaring a schema. -- This is an automated m

[GitHub] [beam] dennisatspaceape commented on issue #22279: [Bug]: BigQueryIO Storage API doesn't return errors in WriteResult when data schema mismatches BQ Schema

2022-07-19 Thread GitBox
dennisatspaceape commented on issue #22279: URL: https://github.com/apache/beam/issues/22279#issuecomment-1189214365 I believe you can access the failed records via the [getFailedStorageApiInserts](https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/bigquery/WriteResu

[GitHub] [beam] AnandInguva commented on pull request #22255: [DONT MERGE]Pytest update debugging

2022-07-19 Thread GitBox
AnandInguva commented on PR #22255: URL: https://github.com/apache/beam/pull/22255#issuecomment-1189213136 Run XVR_JavaUsingPython_Dataflow PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] VladMatyunin opened a new issue, #22343: [Task]: Cleanup of Playground examples: remove examples that are not useful

2022-07-19 Thread GitBox
VladMatyunin opened a new issue, #22343: URL: https://github.com/apache/beam/issues/22343 ### What needs to happen? Remove some of the rarely used code examples from Playground catalog of examples ### Issue Priority Priority: 3 ### Issue Component Component

[GitHub] [beam] egalpin commented on a diff in pull request #22216: BEAM-13592 Add getOrderingKey in o.a.b.sdk.io.gcp.pubsub.PubsubMessage

2022-07-19 Thread GitBox
egalpin commented on code in PR #22216: URL: https://github.com/apache/beam/pull/22216#discussion_r924653796 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessageCoder.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] egalpin commented on a diff in pull request #22216: BEAM-13592 Add getOrderingKey in o.a.b.sdk.io.gcp.pubsub.PubsubMessage

2022-07-19 Thread GitBox
egalpin commented on code in PR #22216: URL: https://github.com/apache/beam/pull/22216#discussion_r924635506 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessageCoder.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [beam] yeandy commented on a diff in pull request #22131: TensorRT Initial commit

2022-07-19 Thread GitBox
yeandy commented on code in PR #22131: URL: https://github.com/apache/beam/pull/22131#discussion_r924614352 ## sdks/python/apache_beam/ml/inference/tensorrt_inference.py: ## @@ -0,0 +1,281 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [beam] tvalentyn commented on a diff in pull request #22250: Update RunInference documentation

2022-07-19 Thread GitBox
tvalentyn commented on code in PR #22250: URL: https://github.com/apache/beam/pull/22250#discussion_r924581965 ## website/www/site/layouts/partials/section-menu/en/sdks.html: ## @@ -39,6 +39,7 @@ Python SDK dependencies Python streaming pipelines Ensuring Python

[GitHub] [beam] tvalentyn commented on a diff in pull request #22250: Update RunInference documentation

2022-07-19 Thread GitBox
tvalentyn commented on code in PR #22250: URL: https://github.com/apache/beam/pull/22250#discussion_r923676270 ## website/www/site/layouts/partials/section-menu/en/sdks.html: ## @@ -39,6 +39,7 @@ Python SDK dependencies Python streaming pipelines Ensuring Python

[GitHub] [beam] tvalentyn commented on pull request #22324: Unskip RunInference IT tests

2022-07-19 Thread GitBox
tvalentyn commented on PR #22324: URL: https://github.com/apache/beam/pull/22324#issuecomment-1189130064 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [beam] tvalentyn merged pull request #22324: Unskip RunInference IT tests

2022-07-19 Thread GitBox
tvalentyn merged PR #22324: URL: https://github.com/apache/beam/pull/22324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apach

  1   2   >