[GitHub] [beam] mosche commented on issue #26291: [Feature Request]: SqsUnboundedStream (Java, aws2): Modify message VisibilityTimeout extension parameters and Acknowledgement

2023-04-26 Thread via GitHub
mosche commented on issue #26291: URL: https://github.com/apache/beam/issues/26291#issuecomment-1524846155 @AlonHarell That would be awesome and much appreciated. > Is it possible to contribute to previous versions, or only the newest release of Beam? There's no patch releases,

[GitHub] [beam] damondouglas closed issue #20500: Eliminate nullability errors from :sdks:java:extensions:sql:hcatalog

2023-04-26 Thread via GitHub
damondouglas closed issue #20500: Eliminate nullability errors from :sdks:java:extensions:sql:hcatalog URL: https://github.com/apache/beam/issues/20500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] damondouglas merged pull request #26443: Eliminate nullness errors from sdks/java/extensions/sql/hcatalog

2023-04-26 Thread via GitHub
damondouglas merged PR #26443: URL: https://github.com/apache/beam/pull/26443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.ap

[GitHub] [beam] cozos commented on issue #18121: Allow a DoFn to opt in to mutating it's input

2023-04-26 Thread via GitHub
cozos commented on issue #18121: URL: https://github.com/apache/beam/issues/18121#issuecomment-1524832762 @kennknowles @francesperry I'm trying to understand this better. So a DoFn does something like this in Python: ``` def process(self, element: Dict[str, Any]) -> Iterator[Di

[GitHub] [beam] damondouglas merged pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
damondouglas merged PR #26422: URL: https://github.com/apache/beam/pull/26422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.ap

[GitHub] [beam] damondouglas commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
damondouglas commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1524803965 FYI Run Java_GCP_IO_Direct PreCommit shows success even though it has a yellow light. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] damondouglas commented on pull request #26413: [20498] Remove SuppressWarnings nullness from SelectByteBuddyHelpers

2023-04-26 Thread via GitHub
damondouglas commented on PR #26413: URL: https://github.com/apache/beam/pull/26413#issuecomment-1524796278 @kennknowles nullness check cleanup score: Kenn: 30 Damon: 1 😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26384: Add field annotations for high-priority Syndeo schema transforms

2023-04-26 Thread via GitHub
ahmedabu98 commented on code in PR #26384: URL: https://github.com/apache/beam/pull/26384#discussion_r1178637008 ## sdks/java/io/file-schema-transform/src/main/java/org/apache/beam/sdk/io/fileschematransform/FileWriteSchemaTransformConfiguration.java: ## @@ -51,43 +52,41 @@ publ

[GitHub] [beam] github-actions[bot] commented on pull request #26446: Lower the lower bound of protobuf.

2023-04-26 Thread via GitHub
github-actions[bot] commented on PR #26446: URL: https://github.com/apache/beam/pull/26446#issuecomment-1524706944 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label python. Available commands: - `stop

[GitHub] [beam] reuvenlax commented on pull request #25940: Fix triggered side inputs

2023-04-26 Thread via GitHub
reuvenlax commented on PR #25940: URL: https://github.com/apache/beam/pull/25940#issuecomment-1524672350 Run Dataflow Streaming ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] AnandInguva opened a new issue, #26447: [Task]: Drop support for Python 3.7

2023-04-26 Thread via GitHub
AnandInguva opened a new issue, #26447: URL: https://github.com/apache/beam/issues/26447 ### What needs to happen? Python 3.7 will be sunset on June 27th, 2023(https://endoflife.date/python). Filing an issue to track the drop. This can be a target for the release 2.49.0. The r

[GitHub] [beam] AnandInguva commented on pull request #26446: Lower the lower bound of protobuf.

2023-04-26 Thread via GitHub
AnandInguva commented on PR #26446: URL: https://github.com/apache/beam/pull/26446#issuecomment-1524627773 Run Python 3.7 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] AnandInguva commented on pull request #26446: Lower the lower bound of protobuf.

2023-04-26 Thread via GitHub
AnandInguva commented on PR #26446: URL: https://github.com/apache/beam/pull/26446#issuecomment-1524627535 Run Python 3.11 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] AnandInguva commented on pull request #26446: Lower the lower bound of protobuf.

2023-04-26 Thread via GitHub
AnandInguva commented on PR #26446: URL: https://github.com/apache/beam/pull/26446#issuecomment-1524627264 Run Python 3.10 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] codecov[bot] commented on pull request #26446: Lower the lower bound of protobuf and also adjust dependencies in build-requirements.txt

2023-04-26 Thread via GitHub
codecov[bot] commented on PR #26446: URL: https://github.com/apache/beam/pull/26446#issuecomment-1524560510 ## [Codecov](https://codecov.io/gh/apache/beam/pull/26446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+F

[GitHub] [beam] AnandInguva opened a new pull request, #26446: Lower the lower bound of protobuf and also adjust dependencies in build-requirements.txt

2023-04-26 Thread via GitHub
AnandInguva opened a new pull request, #26446: URL: https://github.com/apache/beam/pull/26446 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contributio

[GitHub] [beam] liferoad commented on issue #26445: [Feature Request]: Use the canonical link when generating javadoc

2023-04-26 Thread via GitHub
liferoad commented on issue #26445: URL: https://github.com/apache/beam/issues/26445#issuecomment-1524405738 I believe we could do this for other SDK docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] liferoad opened a new issue, #26445: [Feature Request]: Use the canonical link when generating javadoc

2023-04-26 Thread via GitHub
liferoad opened a new issue, #26445: URL: https://github.com/apache/beam/issues/26445 ### What would you like to happen? Using google search such as Kafka IO could lead to the old javadoc for Beam. We can use [the canonical link](https://developers.google.com/search/docs/crawling-ind

[GitHub] [beam] rjhallsted closed issue #26440: [Bug]: `Key.from_client_key` does not assign parent key

2023-04-26 Thread via GitHub
rjhallsted closed issue #26440: [Bug]: `Key.from_client_key` does not assign parent key URL: https://github.com/apache/beam/issues/26440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] rjhallsted commented on issue #26440: [Bug]: `Key.from_client_key` does not assign parent key

2023-04-26 Thread via GitHub
rjhallsted commented on issue #26440: URL: https://github.com/apache/beam/issues/26440#issuecomment-1524297495 Nvm, I realized this is me misunderstanding how keys are represented here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] ryucc commented on a diff in pull request #26437: Basic Tranform metric like throughput, watermark progress & latency support for non data shuffle transforms for Samza Runner

2023-04-26 Thread via GitHub
ryucc commented on code in PR #26437: URL: https://github.com/apache/beam/pull/26437#discussion_r1178507207 ## runners/samza/src/main/java/org/apache/beam/runners/samza/metrics/BeamTransformMetricRegistry.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [beam] lostluck commented on a diff in pull request #26023: A Transform Service that uses Docker Compose

2023-04-26 Thread via GitHub
lostluck commented on code in PR #26023: URL: https://github.com/apache/beam/pull/26023#discussion_r1178514688 ## transform-service/controller/go.mod: ## Review Comment: If the goal is to keep the released instance of this service in sync with released beam, then you do no

[GitHub] [beam] lostluck merged pull request #26426: Bump github.com/lib/pq from 1.10.7 to 1.10.9 in /sdks

2023-04-26 Thread via GitHub
lostluck merged PR #26426: URL: https://github.com/apache/beam/pull/26426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] lostluck commented on pull request #26426: Bump github.com/lib/pq from 1.10.7 to 1.10.9 in /sdks

2023-04-26 Thread via GitHub
lostluck commented on PR #26426: URL: https://github.com/apache/beam/pull/26426#issuecomment-1524236795 Run Go PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] chamikaramj commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
chamikaramj commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178460084 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%

[GitHub] [beam] kennknowles commented on a diff in pull request #26444: Integration/Load test framework

2023-04-26 Thread via GitHub
kennknowles commented on code in PR #26444: URL: https://github.com/apache/beam/pull/26444#discussion_r1178405890 ## it/cassandra/src/main/java/org/apache/beam/it/cassandra/CassandraResourceManagerUtils.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [beam] johnjcasey commented on pull request #26327: Modify batch IT to use count instead of hash

2023-04-26 Thread via GitHub
johnjcasey commented on PR #26327: URL: https://github.com/apache/beam/pull/26327#issuecomment-1524059292 Run Java KafkaIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] kennknowles commented on a diff in pull request #26444: Integration/Load test framework

2023-04-26 Thread via GitHub
kennknowles commented on code in PR #26444: URL: https://github.com/apache/beam/pull/26444#discussion_r1178401857 ## it/cassandra/src/main/java/org/apache/beam/it/cassandra/matchers/CassandraAsserts.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [beam] github-actions[bot] commented on pull request #26444: Integration/Load test framework

2023-04-26 Thread via GitHub
github-actions[bot] commented on PR #26444: URL: https://github.com/apache/beam/pull/26444#issuecomment-1524045779 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles for label java. R: @damccorm for label build.

[GitHub] [beam] codecov[bot] commented on pull request #26444: Integration/Load test framework

2023-04-26 Thread via GitHub
codecov[bot] commented on PR #26444: URL: https://github.com/apache/beam/pull/26444#issuecomment-1524039736 ## [Codecov](https://codecov.io/gh/apache/beam/pull/26444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+F

[GitHub] [beam] y1chi commented on a diff in pull request #26085: Populate getWorkStream latencies in dataflow streaming worker harness

2023-04-26 Thread via GitHub
y1chi commented on code in PR #26085: URL: https://github.com/apache/beam/pull/26085#discussion_r1178393788 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java: ## @@ -987,6 +998,84 @@ public void ap

[GitHub] [beam] lostluck commented on a diff in pull request #26101: [Go SDK] Timers with new datalayer

2023-04-26 Thread via GitHub
lostluck commented on code in PR #26101: URL: https://github.com/apache/beam/pull/26101#discussion_r1178321047 ## sdks/go/pkg/beam/core/graph/fn.go: ## @@ -1386,35 +1386,54 @@ func validateState(fn *DoFn, numIn mainInputs) error { } func validateOnTimerFn(fn *DoFn) error { -

[GitHub] [beam] jrmccluskey commented on pull request #26152: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26152: URL: https://github.com/apache/beam/pull/26152#issuecomment-1524030275 Run XVR_Spark3 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] jrmccluskey commented on pull request #26152: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26152: URL: https://github.com/apache/beam/pull/26152#issuecomment-1524030184 Run XVR_Direct PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] github-actions[bot] commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml

2023-04-26 Thread via GitHub
github-actions[bot] commented on PR #26441: URL: https://github.com/apache/beam/pull/26441#issuecomment-1524012329 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label java. Available commands: - `stop revie

[GitHub] [beam] github-actions[bot] commented on pull request #26443: Eliminate nullness errors from sdks/java/extensions/sql/hcatalog

2023-04-26 Thread via GitHub
github-actions[bot] commented on PR #26443: URL: https://github.com/apache/beam/pull/26443#issuecomment-1524012233 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @robertwb for label java. Available commands: - `stop re

[GitHub] [beam] pranavbhandari24 opened a new pull request, #26444: Integration test framework

2023-04-26 Thread via GitHub
pranavbhandari24 opened a new pull request, #26444: URL: https://github.com/apache/beam/pull/26444 Integration / Load test utilities. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] kennknowles commented on pull request #26441: Eliminate nullness errors from sdks/java/extensions/ml

2023-04-26 Thread via GitHub
kennknowles commented on PR #26441: URL: https://github.com/apache/beam/pull/26441#issuecomment-1523986602 run java precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] reuvenlax commented on pull request #25940: Fix triggered side inputs

2023-04-26 Thread via GitHub
reuvenlax commented on PR #25940: URL: https://github.com/apache/beam/pull/25940#issuecomment-1523983690 @kennknowles PTAL. Verified that tests fail without these cahnges -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] chamikaramj commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
chamikaramj commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178344513 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%

[GitHub] [beam] chamikaramj commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
chamikaramj commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178343337 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%

[GitHub] [beam] damccorm commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
damccorm commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178339678 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%m%d

[GitHub] [beam] kennknowles opened a new pull request, #26443: Eliminate nullness errors from sdks/java/extensions/sql/hcatalog

2023-04-26 Thread via GitHub
kennknowles opened a new pull request, #26443: URL: https://github.com/apache/beam/pull/26443 Fixes #20500 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Mention the appr

[GitHub] [beam] chamikaramj commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
chamikaramj commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178332228 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%

[GitHub] [beam] damccorm commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
damccorm commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178324108 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%m%d

[GitHub] [beam] damccorm commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
damccorm commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178323660 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%m%d

[GitHub] [beam] damccorm commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
damccorm commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178320502 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%m%d

[GitHub] [beam] ryucc opened a new pull request, #26442: Create PortableDoFnOp in Samza Runner

2023-04-26 Thread via GitHub
ryucc opened a new pull request, #26442: URL: https://github.com/apache/beam/pull/26442 - Initial version: copy of DoFnOp Preparation work to created a portable version of DoFnOp without side input processing. This allows a clearer diff in the future.

[GitHub] [beam] chamikaramj commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
chamikaramj commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178316169 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%

[GitHub] [beam] jrmccluskey commented on pull request #26152: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26152: URL: https://github.com/apache/beam/pull/26152#issuecomment-1523943980 Run Dataflow ValidatesRunner Java 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] jrmccluskey commented on pull request #26152: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26152: URL: https://github.com/apache/beam/pull/26152#issuecomment-1523938951 Run Java Dataflow V2 ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] jrmccluskey commented on pull request #26152: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26152: URL: https://github.com/apache/beam/pull/26152#issuecomment-1523936799 Run XVR_Direct PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] jrmccluskey commented on pull request #26152: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26152: URL: https://github.com/apache/beam/pull/26152#issuecomment-1523936568 Run XVR_Flink PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] jrmccluskey commented on pull request #26152: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26152: URL: https://github.com/apache/beam/pull/26152#issuecomment-1523936325 Run XVR_Spark3 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] kennknowles commented on issue #20504: Eliminate nullability errors from :sdks:java:extensions:sorter

2023-04-26 Thread via GitHub
kennknowles commented on issue #20504: URL: https://github.com/apache/beam/issues/20504#issuecomment-1523936239 Sorry for the delay @aditya-mistri. Do you still want to work on this? You can also use the `.take-issue` command in the future to take an issue. -- This is an automated message

[GitHub] [beam] kennknowles closed issue #19327: KV#of parameters marked with @Nullable, even though nullability is encapsulated in type variables KeyT and ValueT

2023-04-26 Thread via GitHub
kennknowles closed issue #19327: KV#of parameters marked with @Nullable, even though nullability is encapsulated in type variables KeyT and ValueT URL: https://github.com/apache/beam/issues/19327 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] kennknowles opened a new pull request, #26441: Eliminate nullness errors from sdks/java/extensions/ml

2023-04-26 Thread via GitHub
kennknowles opened a new pull request, #26441: URL: https://github.com/apache/beam/pull/26441 Fixes #20499 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Mention the appr

[GitHub] [beam] rjhallsted commented on issue #26440: [Bug]: `Key.from_client_key` does not assign parent key

2023-04-26 Thread via GitHub
rjhallsted commented on issue #26440: URL: https://github.com/apache/beam/issues/26440#issuecomment-1523929697 .add-label gcp,datastore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] github-actions[bot] commented on issue #26440: [Bug]: `Key.from_client_key` does not assign parent key

2023-04-26 Thread via GitHub
github-actions[bot] commented on issue #26440: URL: https://github.com/apache/beam/issues/26440#issuecomment-1523929169 Label cannot be managed because it does not exist in the repo. Please check your spelling. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] github-actions[bot] commented on issue #26440: [Bug]: `Key.from_client_key` does not assign parent key

2023-04-26 Thread via GitHub
github-actions[bot] commented on issue #26440: URL: https://github.com/apache/beam/issues/26440#issuecomment-1523927885 Label cannot be managed because it does not exist in the repo. Please check your spelling. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] rjhallsted commented on issue #26440: [Bug]: `Key.from_client_key` does not assign parent key

2023-04-26 Thread via GitHub
rjhallsted commented on issue #26440: URL: https://github.com/apache/beam/issues/26440#issuecomment-1523927649 .add-labels gcp, datastore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] rjhallsted opened a new issue, #26440: [Bug]: `Key.from_client_key` does not assign parent key

2023-04-26 Thread via GitHub
rjhallsted opened a new issue, #26440: URL: https://github.com/apache/beam/issues/26440 ### What happened? `apache_beam.io.gcp.datastore.v1new.types.Key.from_client_key` does not set the parent key. Among other things, this causes queries via the `ReadFromDatastore` PTransform to ret

[GitHub] [beam] jrmccluskey commented on a diff in pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
jrmccluskey commented on code in PR #26407: URL: https://github.com/apache/beam/pull/26407#discussion_r1178296792 ## release/src/main/scripts/run_rc_validation.sh: ## @@ -100,6 +100,8 @@ HUB_ARTIFACTS_NAME=hub-linux-amd64-${HUB_VERSION} BACKUP_BASHRC=.bashrc_backup_$(date +"%Y%

[GitHub] [beam] damccorm commented on pull request #26407: Add artifact validation to run_rc_validation

2023-04-26 Thread via GitHub
damccorm commented on PR #26407: URL: https://github.com/apache/beam/pull/26407#issuecomment-1523923706 R: @jrmccluskey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] johnjcasey commented on pull request #26327: Modify batch IT to use count instead of hash

2023-04-26 Thread via GitHub
johnjcasey commented on PR #26327: URL: https://github.com/apache/beam/pull/26327#issuecomment-1523915961 Run Java KafkaIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523907979 Run Java_Kinesis_IO_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523907707 Run Java_GCP_IO_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523907524 Run Java_IOs_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523906782 Run RAT PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] damccorm merged pull request #26438: Move snapshot build into cut release branch step

2023-04-26 Thread via GitHub
damccorm merged PR #26438: URL: https://github.com/apache/beam/pull/26438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523888371 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] jrmccluskey opened a new pull request, #26439: Beam 2.47.0 Release Website Updates

2023-04-26 Thread via GitHub
jrmccluskey opened a new pull request, #26439: URL: https://github.com/apache/beam/pull/26439 Updates the website with the release listing and blog post DO NOT SUBMIT until an 2.47.0 RC candidate is approved and the remaining fields are updated.

[GitHub] [beam] jrmccluskey closed issue #26359: [Bug]: WriteToFiles uses expensive ToList when all that's required is ToIterable.

2023-04-26 Thread via GitHub
jrmccluskey closed issue #26359: [Bug]: WriteToFiles uses expensive ToList when all that's required is ToIterable. URL: https://github.com/apache/beam/issues/26359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [beam] jrmccluskey commented on issue #26359: [Bug]: WriteToFiles uses expensive ToList when all that's required is ToIterable.

2023-04-26 Thread via GitHub
jrmccluskey commented on issue #26359: URL: https://github.com/apache/beam/issues/26359#issuecomment-1523879473 This has been cherrypicked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] AnandInguva closed pull request #26435: Fix bugs in notebook

2023-04-26 Thread via GitHub
AnandInguva closed pull request #26435: Fix bugs in notebook URL: https://github.com/apache/beam/pull/26435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

2023-04-26 Thread via GitHub
Dippatel98 commented on PR #26286: URL: https://github.com/apache/beam/pull/26286#issuecomment-1523865371 I have incorporated all the changes mentioned in the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [beam] kennknowles commented on a diff in pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on code in PR #26422: URL: https://github.com/apache/beam/pull/26422#discussion_r1178212952 ## sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java: ## @@ -839,16 +850,16 @@ public CheckpointMark getCheckpointMark() { } private Obje

[GitHub] [beam] riteshghorse commented on pull request #26101: [Go SDK] Timers with new datalayer

2023-04-26 Thread via GitHub
riteshghorse commented on PR #26101: URL: https://github.com/apache/beam/pull/26101#issuecomment-1523818449 Thanks for the detailed review @lostluck . I've addressed the comments, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523815996 This is undoubtedly something I added because the thing looked like it was required to be non-null. ``` Caused by: java.lang.IllegalStateException at org.apache.beam.

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523814873 huh, interestingly I failed to repro the failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] github-actions[bot] commented on pull request #26438: Move snapshot build into cut release branch step

2023-04-26 Thread via GitHub
github-actions[bot] commented on PR #26438: URL: https://github.com/apache/beam/pull/26438#issuecomment-1523809629 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] damccorm commented on pull request #26438: Move snapshot build into cut release branch step

2023-04-26 Thread via GitHub
damccorm commented on PR #26438: URL: https://github.com/apache/beam/pull/26438#issuecomment-1523808527 R: @jrmccluskey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] y1chi commented on a diff in pull request #26085: Populate getWorkStream latencies in dataflow streaming worker harness

2023-04-26 Thread via GitHub
y1chi commented on code in PR #26085: URL: https://github.com/apache/beam/pull/26085#discussion_r1178201948 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java: ## @@ -987,6 +998,84 @@ public void ap

[GitHub] [beam] damccorm opened a new pull request, #26438: Move snapshot build into cut release branch step

2023-04-26 Thread via GitHub
damccorm opened a new pull request, #26438: URL: https://github.com/apache/beam/pull/26438 Similar to #26434, this takes our already mostly automated snapshot build step and fully automates it. It also moves it into the cut_release_branch step since there's no reason not to automatically ru

[GitHub] [beam] kennknowles commented on pull request #26422: Eliminate nullness and rawtype errors from java SDK Read class

2023-04-26 Thread via GitHub
kennknowles commented on PR #26422: URL: https://github.com/apache/beam/pull/26422#issuecomment-1523806698 I'll take a look. I actually just ensured it compiled before pushing out, since I wasn't intending to make functional changes. -- This is an automated message from the Apache Git Ser

[GitHub] [beam] jrmccluskey commented on pull request #26392: Bump sqlparse from 0.4.3 to 0.4.4 in /sdks/python/container/py310

2023-04-26 Thread via GitHub
jrmccluskey commented on PR #26392: URL: https://github.com/apache/beam/pull/26392#issuecomment-1523806030 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [beam] riteshghorse commented on a diff in pull request #26101: [Go SDK] Timers with new datalayer

2023-04-26 Thread via GitHub
riteshghorse commented on code in PR #26101: URL: https://github.com/apache/beam/pull/26101#discussion_r1178196901 ## sdks/go/pkg/beam/core/runtime/exec/datasource.go: ## @@ -263,8 +263,17 @@ func (n *DataSource) Process(ctx context.Context) ([]*Checkpoint, error) {

[GitHub] [beam] Dippatel98 commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

2023-04-26 Thread via GitHub
Dippatel98 commented on code in PR #26286: URL: https://github.com/apache/beam/pull/26286#discussion_r1178187168 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java: ## @@ -118,12 +166,14 @@ public

[GitHub] [beam] Dippatel98 commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

2023-04-26 Thread via GitHub
Dippatel98 commented on code in PR #26286: URL: https://github.com/apache/beam/pull/26286#discussion_r1178186879 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java: ## @@ -59,12 +68,52 @@ public

[GitHub] [beam] damccorm merged pull request #26434: Use github actions to cut release branch

2023-04-26 Thread via GitHub
damccorm merged PR #26434: URL: https://github.com/apache/beam/pull/26434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #26434: Use github actions to cut release branch

2023-04-26 Thread via GitHub
github-actions[bot] commented on PR #26434: URL: https://github.com/apache/beam/pull/26434#issuecomment-1523775470 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] damccorm commented on pull request #26434: Use github actions to cut release branch

2023-04-26 Thread via GitHub
damccorm commented on PR #26434: URL: https://github.com/apache/beam/pull/26434#issuecomment-1523774024 R: @jrmccluskey (this should keep us from future problems with this script 🙃 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [beam] riteshghorse merged pull request #26427: Bump google.golang.org/api from 0.119.0 to 0.120.0 in /sdks

2023-04-26 Thread via GitHub
riteshghorse merged PR #26427: URL: https://github.com/apache/beam/pull/26427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.ap

[GitHub] [beam] riteshghorse commented on a diff in pull request #26101: [Go SDK] Timers with new datalayer

2023-04-26 Thread via GitHub
riteshghorse commented on code in PR #26101: URL: https://github.com/apache/beam/pull/26101#discussion_r1178161580 ## sdks/go/pkg/beam/core/timers/timers.go: ## @@ -0,0 +1,161 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agree

[GitHub] [beam] damccorm merged pull request #26436: Fix syntax issues with notebook

2023-04-26 Thread via GitHub
damccorm merged PR #26436: URL: https://github.com/apache/beam/pull/26436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] AnandInguva commented on a diff in pull request #26436: Fix syntax issues with notebook

2023-04-26 Thread via GitHub
AnandInguva commented on code in PR #26436: URL: https://github.com/apache/beam/pull/26436#discussion_r1178155780 ## examples/notebooks/beam-ml/automatic_model_refresh.ipynb: ## @@ -136,7 +136,10 @@ "from apache_beam.options.pipeline_options impo

[GitHub] [beam] damccorm commented on pull request #26436: Fix syntax issues with notebook

2023-04-26 Thread via GitHub
damccorm commented on PR #26436: URL: https://github.com/apache/beam/pull/26436#issuecomment-1523754392 (FWIW, colab masks that problem, though maybe just in my environment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] Sanil15 opened a new pull request, #26437: Basic Tranform metric like throughput, watermark progress & latency support for non data shuffle transforms for Samza Runner

2023-04-26 Thread via GitHub
Sanil15 opened a new pull request, #26437: URL: https://github.com/apache/beam/pull/26437 **Summary** - Added Support for generating throughput, watermark progress & latency metric emission - A MetricOp is attached to each input & output - Throughput Metrics are emitted for input a

[GitHub] [beam] damccorm commented on pull request #26436: Fix syntax issues with notebook

2023-04-26 Thread via GitHub
damccorm commented on PR #26436: URL: https://github.com/apache/beam/pull/26436#issuecomment-1523753823 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [beam] github-actions[bot] commented on pull request #26436: Fix syntax issues with notebook

2023-04-26 Thread via GitHub
github-actions[bot] commented on PR #26436: URL: https://github.com/apache/beam/pull/26436#issuecomment-1523752401 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

  1   2   >