[GitHub] [beam] github-actions[bot] commented on pull request #28138: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.80 to 1.11.81 in /sdks

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28138: URL: https://github.com/apache/beam/pull/28138#issuecomment-1691007967 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label go. Available commands: - `stop

[GitHub] [beam] github-actions[bot] commented on pull request #28139: Bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 in /sdks

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28139: URL: https://github.com/apache/beam/pull/28139#issuecomment-1691007929 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

[GitHub] [beam] github-actions[bot] commented on pull request #28140: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.36 to 1.18.37 in /sdks

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28140: URL: https://github.com/apache/beam/pull/28140#issuecomment-1691007844 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. Available commands: - `stop r

[GitHub] [beam] codecov[bot] commented on pull request #28138: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.80 to 1.11.81 in /sdks

2023-08-23 Thread via GitHub
codecov[bot] commented on PR #28138: URL: https://github.com/apache/beam/pull/28138#issuecomment-1690988015 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] codecov[bot] commented on pull request #28140: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.36 to 1.18.37 in /sdks

2023-08-23 Thread via GitHub
codecov[bot] commented on PR #28140: URL: https://github.com/apache/beam/pull/28140#issuecomment-1690986899 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28140?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] dependabot[bot] opened a new pull request, #28140: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.36 to 1.18.37 in /sdks

2023-08-23 Thread via GitHub
dependabot[bot] opened a new pull request, #28140: URL: https://github.com/apache/beam/pull/28140 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.36 to 1.18.37. Commits https://github.com/aws/aws-sdk-go-v2/commit/d930d631c8edb9c938cd

[GitHub] [beam] dependabot[bot] opened a new pull request, #28139: Bump cloud.google.com/go/datastore from 1.13.0 to 1.14.0 in /sdks

2023-08-23 Thread via GitHub
dependabot[bot] opened a new pull request, #28139: URL: https://github.com/apache/beam/pull/28139 Bumps [cloud.google.com/go/datastore](https://github.com/googleapis/google-cloud-go) from 1.13.0 to 1.14.0. Release notes Sourced from https://github.com/googleapis/google-cloud-go/re

[GitHub] [beam] dependabot[bot] opened a new pull request, #28138: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.80 to 1.11.81 in /sdks

2023-08-23 Thread via GitHub
dependabot[bot] opened a new pull request, #28138: URL: https://github.com/apache/beam/pull/28138 Bumps [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) from 1.11.80 to 1.11.81. Commits https://github.com/aws/aws-sdk-go-v2/commit/d930d631

[GitHub] [beam] reuvenlax commented on a diff in pull request #28124: Allow using CREATE_IF_NEEDED when writing deletes or updates to BigQuery

2023-08-23 Thread via GitHub
reuvenlax commented on code in PR #28124: URL: https://github.com/apache/beam/pull/28124#discussion_r1303735533 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java: ## @@ -3254,9 +3270,12 @@ && getStorageApiTriggeringFrequency(

[GitHub] [beam] reuvenlax commented on a diff in pull request #28124: Allow using CREATE_IF_NEEDED when writing deletes or updates to BigQuery

2023-08-23 Thread via GitHub
reuvenlax commented on code in PR #28124: URL: https://github.com/apache/beam/pull/28124#discussion_r1303735294 ## sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkRowUpdateIT.java: ## @@ -130,16 +101,19 @@ public void testCdc()

[GitHub] [beam] github-actions[bot] commented on pull request #28136: Test version of release candidate docs action.

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28136: URL: https://github.com/apache/beam/pull/28136#issuecomment-1690899663 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

[GitHub] [beam] svetakvsundhar opened a new pull request, #28137: [WIP] Add a De-ID transform for Dicom IO

2023-08-23 Thread via GitHub
svetakvsundhar opened a new pull request, #28137: URL: https://github.com/apache/beam/pull/28137 Adding a Dicom IO De-identification PTransform. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] lostluck closed pull request #28135: Test version of release candidate docs.

2023-08-23 Thread via GitHub
lostluck closed pull request #28135: Test version of release candidate docs. URL: https://github.com/apache/beam/pull/28135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] lostluck commented on pull request #28135: Test version of release candidate docs.

2023-08-23 Thread via GitHub
lostluck commented on PR #28135: URL: https://github.com/apache/beam/pull/28135#issuecomment-1690811996 Closing in favour of branch on repo for iteration purposes. https://github.com/apache/beam/pull/28136 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] lostluck opened a new pull request, #28136: Test version of release candidate docs action.

2023-08-23 Thread via GitHub
lostluck opened a new pull request, #28136: URL: https://github.com/apache/beam/pull/28136 Create Docs PR with a Github Action for building release artifacts. Based largely on the existing build_release_candidate.sh script, but with the following changes: No longer quarantine e

[GitHub] [beam] dependabot[bot] closed pull request #28081: Bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.4 to 1.38.5 in /sdks

2023-08-23 Thread via GitHub
dependabot[bot] closed pull request #28081: Bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.4 to 1.38.5 in /sdks URL: https://github.com/apache/beam/pull/28081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [beam] dependabot[bot] commented on pull request #28081: Bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.38.4 to 1.38.5 in /sdks

2023-08-23 Thread via GitHub
dependabot[bot] commented on PR #28081: URL: https://github.com/apache/beam/pull/28081#issuecomment-1690809972 Looks like github.com/aws/aws-sdk-go-v2/service/s3 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] lostluck merged pull request #28117: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.79 to 1.11.80 in /sdks

2023-08-23 Thread via GitHub
lostluck merged PR #28117: URL: https://github.com/apache/beam/pull/28117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] lostluck opened a new pull request, #28135: Test version of release candidate docs.

2023-08-23 Thread via GitHub
lostluck opened a new pull request, #28135: URL: https://github.com/apache/beam/pull/28135 Create Docs PR with a Github Action for building release artifacts. Based largely on the existing build_release_candidate.sh script, but with the following changes: * No longer quarantine eac

[GitHub] [beam] github-actions[bot] commented on pull request #28133: Update ttypescript version.

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28133: URL: https://github.com/apache/beam/pull/28133#issuecomment-1690731677 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles added as fallback since no labels match configuration

[GitHub] [beam] lostluck opened a new pull request, #28133: Update ttypescript version.

2023-08-23 Thread via GitHub
lostluck opened a new pull request, #28133: URL: https://github.com/apache/beam/pull/28133 Was running into the same error as this question, which was resolved in the same fashion: updating to ttypescript 1.5.15 https://stackoverflow.com/questions/76951014/yarn-run-build-dist-typeerr

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #28124: Allow using CREATE_IF_NEEDED when writing deletes or updates to BigQuery

2023-08-23 Thread via GitHub
ahmedabu98 commented on code in PR #28124: URL: https://github.com/apache/beam/pull/28124#discussion_r1303569885 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java: ## @@ -3254,9 +3270,12 @@ && getStorageApiTriggeringFrequency

[GitHub] [beam] dummy-work-account commented on issue #28131: [Bug]: Python sdk harness failed: TypeError: can only concatenate str (not "NoneType") to str

2023-08-23 Thread via GitHub
dummy-work-account commented on issue #28131: URL: https://github.com/apache/beam/issues/28131#issuecomment-1690661104 When I comment out the windowinto line the error goes away but the pipeline still doesn't function as expected -- which might be an issue with my custom DoFn ```pyth

[GitHub] [beam] liferoad commented on pull request #28013: use google form for feedback

2023-08-23 Thread via GitHub
liferoad commented on PR #28013: URL: https://github.com/apache/beam/pull/28013#issuecomment-1690625758 > Merged. Thank you! > > Could one of you please update the dev list thread and also change the form based on the feedback? Will do later. Thanks! -- This is an automated

[GitHub] [beam] liferoad commented on a diff in pull request #28013: use google form for feedback

2023-08-23 Thread via GitHub
liferoad commented on code in PR #28013: URL: https://github.com/apache/beam/pull/28013#discussion_r1303530143 ## website/www/site/layouts/partials/feedback.html: ## @@ -18,5 +18,5 @@ {{ T "feedback-title" }} {{ T "feedback-description" }} -mailto:d...@b

[GitHub] [beam] chamikaramj merged pull request #28128: is_service_runner now returns false with dataflow_endpoint=localhost

2023-08-23 Thread via GitHub
chamikaramj merged PR #28128: URL: https://github.com/apache/beam/pull/28128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[GitHub] [beam] chamikaramj commented on pull request #28128: is_service_runner now returns false with dataflow_endpoint=localhost

2023-08-23 Thread via GitHub
chamikaramj commented on PR #28128: URL: https://github.com/apache/beam/pull/28128#issuecomment-1690594372 LGTM. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] m-trieu commented on pull request #28016: remove sync stub list from GrpcWindmillServer

2023-08-23 Thread via GitHub
m-trieu commented on PR #28016: URL: https://github.com/apache/beam/pull/28016#issuecomment-1690586187 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] github-actions[bot] commented on pull request #28132: Update TF notebook example to auto-restart the runtime after dependency installation

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28132: URL: https://github.com/apache/beam/pull/28132#issuecomment-1690583125 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] jrmccluskey opened a new pull request, #28132: Update TF notebook example to auto-restart the runtime after dependency installation

2023-08-23 Thread via GitHub
jrmccluskey opened a new pull request, #28132: URL: https://github.com/apache/beam/pull/28132 Ensures use of new package versions by automatically restarting the Python runtime after installation. Follows the pattern in https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/r

[GitHub] [beam] dummy-work-account opened a new issue, #28131: [Bug]: Python sdk harness failed: TypeError: can only concatenate str (not "NoneType") to str

2023-08-23 Thread via GitHub
dummy-work-account opened a new issue, #28131: URL: https://github.com/apache/beam/issues/28131 ### What happened? I'm trying to send custom metrics to datadog using a DoFn but the python sdk test harness is failing with an error that I don't know how to interpret: ``` Trac

[GitHub] [beam] jrmccluskey commented on pull request #28130: [WIP] Add Vertex AI Model Handler Notebook

2023-08-23 Thread via GitHub
jrmccluskey commented on PR #28130: URL: https://github.com/apache/beam/pull/28130#issuecomment-1690556477 Closing for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] github-actions[bot] commented on pull request #28130: Add Vertex AI Model Handler Notebook

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28130: URL: https://github.com/apache/beam/pull/28130#issuecomment-1690528570 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @johnjcasey added as fallback since no labels match configuration

[GitHub] [beam] mutianf commented on a diff in pull request #28122: fix: fix a race condition in BigtableService cache

2023-08-23 Thread via GitHub
mutianf commented on code in PR #28122: URL: https://github.com/apache/beam/pull/28122#discussion_r1303444386 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java: ## @@ -75,15 +76,15 @@ static BigtableServiceEntry c

[GitHub] [beam] jrmccluskey opened a new pull request, #28130: Add Vertex AI Model Handler Notebook

2023-08-23 Thread via GitHub
jrmccluskey opened a new pull request, #28130: URL: https://github.com/apache/beam/pull/28130 Adds an example notebook that demonstrates running the Vertex AI model handler image classification example. Thank you for your contribution! Follow this chec

[GitHub] [beam] codecov[bot] commented on pull request #28128: is_service_runner now returns false with dataflow_endpoint=localhost

2023-08-23 Thread via GitHub
codecov[bot] commented on PR #28128: URL: https://github.com/apache/beam/pull/28128#issuecomment-1690496899 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] damccorm merged pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
damccorm merged PR #28121: URL: https://github.com/apache/beam/pull/28121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] kerrydc opened a new pull request, #28128: is_service_runner now returns false with dataflow_endpoint=localhost

2023-08-23 Thread via GitHub
kerrydc opened a new pull request, #28128: URL: https://github.com/apache/beam/pull/28128 This change makes 'localhost' a non service runner. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and eas

[GitHub] [beam] chamikaramj commented on pull request #27876: Code completion plugin: Add Starcoder Completions

2023-08-23 Thread via GitHub
chamikaramj commented on PR #27876: URL: https://github.com/apache/beam/pull/27876#issuecomment-1690444591 BTW I suggest following :) Update the Beam dev list regarding this plugin via an email that includes a short proposal if you haven't already done so (a doc with one to few pages

[GitHub] [beam] aaltay commented on pull request #28013: use google form for feedback

2023-08-23 Thread via GitHub
aaltay commented on PR #28013: URL: https://github.com/apache/beam/pull/28013#issuecomment-1690442516 Merged. Thank you! Could one of you please update the dev list thread and also change the form based on the feedback? -- This is an automated message from the Apache Git Service. T

[GitHub] [beam] aaltay merged pull request #28013: use google form for feedback

2023-08-23 Thread via GitHub
aaltay merged PR #28013: URL: https://github.com/apache/beam/pull/28013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.o

[GitHub] [beam] github-actions[bot] commented on pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28121: URL: https://github.com/apache/beam/pull/28121#issuecomment-1690432963 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] damccorm commented on pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
damccorm commented on PR #28121: URL: https://github.com/apache/beam/pull/28121#issuecomment-1690427869 R: @riteshghorse -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] damccorm commented on pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
damccorm commented on PR #28121: URL: https://github.com/apache/beam/pull/28121#issuecomment-1690427748 Run Python_Runners PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] tvalentyn closed issue #22413: [Bug]: `:sdks:python:test-suites:direct:py39:torchInferenceTest` and `:sdks:python:test-suites:direct:py38:torchInferenceTest` failing in Python PostComm

2023-08-23 Thread via GitHub
tvalentyn closed issue #22413: [Bug]: `:sdks:python:test-suites:direct:py39:torchInferenceTest` and `:sdks:python:test-suites:direct:py38:torchInferenceTest` failing in Python PostCommits URL: https://github.com/apache/beam/issues/22413 -- This is an automated message from the Apache Git Se

[GitHub] [beam] lostluck opened a new issue, #28126: [Bug][prism]: Insufficient context when prism is unable to LP unknown coders (eg. base coder is missing).

2023-08-23 Thread via GitHub
lostluck opened a new issue, #28126: URL: https://github.com/apache/beam/issues/28126 ### What happened? When attempting to run the Swift SDK wordcount, prism failed due to a missing base coder, but ultimately there was no coder id. However, each transform and PCollection had appropr

[GitHub] [beam] github-actions[bot] commented on pull request #28117: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.79 to 1.11.80 in /sdks

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28117: URL: https://github.com/apache/beam/pull/28117#issuecomment-1690407224 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck for label go. Available commands: - `stop revi

[GitHub] [beam] github-actions[bot] commented on pull request #28124: Allow using CREATE_IF_NEEDED when writing deletes or updates to BigQuery

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28124: URL: https://github.com/apache/beam/pull/28124#issuecomment-1690407007 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @robertwb for label java. R: @ahmedabu98 for label io. A

[GitHub] [beam] tvalentyn commented on pull request #27522: Add type hint to CounterCell

2023-08-23 Thread via GitHub
tvalentyn commented on PR #27522: URL: https://github.com/apache/beam/pull/27522#issuecomment-1690406981 gotcha, nice, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] jrmccluskey merged pull request #28087: Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /sdks

2023-08-23 Thread via GitHub
jrmccluskey merged PR #28087: URL: https://github.com/apache/beam/pull/28087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[GitHub] [beam] jrmccluskey commented on pull request #27522: Add type hint to CounterCell

2023-08-23 Thread via GitHub
jrmccluskey commented on PR #27522: URL: https://github.com/apache/beam/pull/27522#issuecomment-1690401298 It is, this just also adds a type hint to the metric counter that _should_ give a more clear type check error rather than the error only coming when the metric is serialized. -- Th

[GitHub] [beam] jrmccluskey merged pull request #28089: Bump github.com/proullon/ramsql from 0.0.1 to 0.1.1 in /sdks

2023-08-23 Thread via GitHub
jrmccluskey merged PR #28089: URL: https://github.com/apache/beam/pull/28089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[GitHub] [beam] github-actions[bot] commented on pull request #28123: Free disk space before running build_release_candidate

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28123: URL: https://github.com/apache/beam/pull/28123#issuecomment-1690366432 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label build. Available commands: - `stop revi

[GitHub] [beam] codecov[bot] commented on pull request #28087: Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /sdks

2023-08-23 Thread via GitHub
codecov[bot] commented on PR #28087: URL: https://github.com/apache/beam/pull/28087#issuecomment-1690362453 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] codecov[bot] commented on pull request #28089: Bump github.com/proullon/ramsql from 0.0.1 to 0.1.1 in /sdks

2023-08-23 Thread via GitHub
codecov[bot] commented on PR #28089: URL: https://github.com/apache/beam/pull/28089#issuecomment-1690360943 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] reuvenlax opened a new pull request, #28124: Allow using CREATE_IF_NEEDED when writing deletes or updates to BigQuery

2023-08-23 Thread via GitHub
reuvenlax opened a new pull request, #28124: URL: https://github.com/apache/beam/pull/28124 Since tables must be created using a primary key, this PR also adds support for specifying the primary key. R: @ahmedabu98 -- This is an automated message from the Apache Git Service. To re

[GitHub] [beam] riteshghorse merged pull request #28046: [Python] Get available python version and use it for Python SDK harness boot entry point

2023-08-23 Thread via GitHub
riteshghorse merged PR #28046: URL: https://github.com/apache/beam/pull/28046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.ap

[GitHub] [beam] Abacn merged pull request #28113: Update `it` module.

2023-08-23 Thread via GitHub
Abacn merged PR #28113: URL: https://github.com/apache/beam/pull/28113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] damccorm opened a new pull request, #28123: Free disk space before running build_release_candidate

2023-08-23 Thread via GitHub
damccorm opened a new pull request, #28123: URL: https://github.com/apache/beam/pull/28123 Right now, we're repeatedly running out of disk space when trying to publish docker images. This should free up ~30 GB for us to use. Thank you for your contribut

[GitHub] [beam] bvolpato commented on a diff in pull request #28122: fix: fix a race condition in BigtableService cache

2023-08-23 Thread via GitHub
bvolpato commented on code in PR #28122: URL: https://github.com/apache/beam/pull/28122#discussion_r1303312575 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java: ## @@ -75,15 +76,15 @@ static BigtableServiceEntry

[GitHub] [beam] bvolpato commented on a diff in pull request #28122: fix: fix a race condition in BigtableService cache

2023-08-23 Thread via GitHub
bvolpato commented on code in PR #28122: URL: https://github.com/apache/beam/pull/28122#discussion_r1303312575 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java: ## @@ -75,15 +76,15 @@ static BigtableServiceEntry

[GitHub] [beam] Abacn commented on a diff in pull request #28122: fix: fix a race condition in BigtableService cache

2023-08-23 Thread via GitHub
Abacn commented on code in PR #28122: URL: https://github.com/apache/beam/pull/28122#discussion_r1303307732 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java: ## @@ -105,8 +106,12 @@ BigtableServiceEntry getServic

[GitHub] [beam] Abacn commented on a diff in pull request #28122: fix: fix a race condition in BigtableService cache

2023-08-23 Thread via GitHub
Abacn commented on code in PR #28122: URL: https://github.com/apache/beam/pull/28122#discussion_r1303305418 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java: ## @@ -75,15 +76,15 @@ static BigtableServiceEntry cre

[GitHub] [beam] damccorm commented on pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
damccorm commented on PR #28121: URL: https://github.com/apache/beam/pull/28121#issuecomment-1690313892 Run Python_Runners PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] riteshghorse commented on pull request #28046: [Python] Get available python version and use it for Python SDK harness boot entry point

2023-08-23 Thread via GitHub
riteshghorse commented on PR #28046: URL: https://github.com/apache/beam/pull/28046#issuecomment-1690314091 The error message we wrote is logged for this [job](https://pantheon.corp.google.com/dataflow/jobs/us-central1/2023-08-23_09_49_03-4656118819153030201;bottomTab=WORKER_LOGS;graphView=0

[GitHub] [beam] riteshghorse commented on pull request #28046: [Python] Get available python version and use it for Python SDK harness boot entry point

2023-08-23 Thread via GitHub
riteshghorse commented on PR #28046: URL: https://github.com/apache/beam/pull/28046#issuecomment-1690314515 Run PythonDocs PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] github-actions[bot] commented on pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28121: URL: https://github.com/apache/beam/pull/28121#issuecomment-1690282491 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @liferoad for label python. Available commands: - `stop

[GitHub] [beam] github-actions[bot] commented on pull request #28122: fix: fix a race condition in BigtableService cache

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28122: URL: https://github.com/apache/beam/pull/28122#issuecomment-1690282344 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @bvolpato for label java. R: @johnjcasey for label io. A

[GitHub] [beam] Abacn commented on a diff in pull request #28079: Replace StorageV1 client with GCS client (take 4)

2023-08-23 Thread via GitHub
Abacn commented on code in PR #28079: URL: https://github.com/apache/beam/pull/28079#discussion_r1303272756 ## sdks/python/apache_beam/io/gcp/gcsio.py: ## @@ -271,186 +190,110 @@ def delete(self, path): Args: path: GCS file path pattern in the form gs:///. """ -

[GitHub] [beam] BjornPrime commented on a diff in pull request #28079: Replace StorageV1 client with GCS client (take 4)

2023-08-23 Thread via GitHub
BjornPrime commented on code in PR #28079: URL: https://github.com/apache/beam/pull/28079#discussion_r1303233717 ## sdks/python/apache_beam/io/gcp/gcsio.py: ## @@ -271,186 +190,110 @@ def delete(self, path): Args: path: GCS file path pattern in the form gs:///.

[GitHub] [beam] AnandInguva commented on a diff in pull request #27620: Add MLTransform IT test

2023-08-23 Thread via GitHub
AnandInguva commented on code in PR #27620: URL: https://github.com/apache/beam/pull/27620#discussion_r1303226925 ## sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py: ## @@ -55,7 +55,7 @@ def _publish_metrics(pipeline, metric_value, metrics_table, me

[GitHub] [beam] jrmccluskey commented on a diff in pull request #27620: Add MLTransform IT test

2023-08-23 Thread via GitHub
jrmccluskey commented on code in PR #27620: URL: https://github.com/apache/beam/pull/27620#discussion_r1303225166 ## sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py: ## @@ -55,7 +55,7 @@ def _publish_metrics(pipeline, metric_value, metrics_table, me

[GitHub] [beam] Abacn commented on pull request #27971: Increase consistency for BQ typed read with avro source

2023-08-23 Thread via GitHub
Abacn commented on PR #27971: URL: https://github.com/apache/beam/pull/27971#issuecomment-1690207136 I see the difficulty here. Thanks again for addressing this. In this case, would you mind sending the proposed change to Beam devlist for the discussion to the change of AvroSource? A

[GitHub] [beam] damccorm merged pull request #28076: Fix error condition checking

2023-08-23 Thread via GitHub
damccorm merged PR #28076: URL: https://github.com/apache/beam/pull/28076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] mutianf opened a new pull request, #28122: fix: fix a race condition in BigtableService cache

2023-08-23 Thread via GitHub
mutianf opened a new pull request, #28122: URL: https://github.com/apache/beam/pull/28122 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickl

[GitHub] [beam] riteshghorse commented on pull request #28046: [Python] Get available python version and use it for Python SDK harness boot entry point

2023-08-23 Thread via GitHub
riteshghorse commented on PR #28046: URL: https://github.com/apache/beam/pull/28046#issuecomment-1690187012 I'll give a try with custom container image and merge this after that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] codecov[bot] commented on pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
codecov[bot] commented on PR #28121: URL: https://github.com/apache/beam/pull/28121#issuecomment-1690177231 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] Abacn commented on a diff in pull request #28079: Replace StorageV1 client with GCS client (take 4)

2023-08-23 Thread via GitHub
Abacn commented on code in PR #28079: URL: https://github.com/apache/beam/pull/28079#discussion_r1303196233 ## sdks/python/apache_beam/io/gcp/gcsio.py: ## @@ -271,186 +190,110 @@ def delete(self, path): Args: path: GCS file path pattern in the form gs:///. """ -

[GitHub] [beam] damccorm commented on pull request #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
damccorm commented on PR #28121: URL: https://github.com/apache/beam/pull/28121#issuecomment-1690145481 Run Python 3.9 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] damccorm opened a new pull request, #28121: Add integration tests to exercise large model on different frameworks

2023-08-23 Thread via GitHub
damccorm opened a new pull request, #28121: URL: https://github.com/apache/beam/pull/28121 In my per-key model handler work I've found some issues with the large model setting on a per-framework basis. This adds some IT tests for each framework. Thank y

[GitHub] [beam] damccorm commented on a diff in pull request #28107: Explicitly call out dependency installation issues as unrecoverable

2023-08-23 Thread via GitHub
damccorm commented on code in PR #28107: URL: https://github.com/apache/beam/pull/28107#discussion_r1303151087 ## sdks/python/container/boot.go: ## @@ -380,26 +380,26 @@ func installSetupPackages(files []string, workDir string, requirementsFiles []st pkgName := "apache-

[GitHub] [beam] damccorm commented on a diff in pull request #28107: Explicitly call out dependency installation issues as unrecoverable

2023-08-23 Thread via GitHub
damccorm commented on code in PR #28107: URL: https://github.com/apache/beam/pull/28107#discussion_r1303151576 ## sdks/python/container/boot.go: ## @@ -380,26 +380,26 @@ func installSetupPackages(files []string, workDir string, requirementsFiles []st pkgName := "apache-

[GitHub] [beam] damccorm commented on a diff in pull request #27620: Add MLTransform IT test

2023-08-23 Thread via GitHub
damccorm commented on code in PR #27620: URL: https://github.com/apache/beam/pull/27620#discussion_r1303137734 ## sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py: ## @@ -55,7 +55,7 @@ def _publish_metrics(pipeline, metric_value, metrics_table, metri

[GitHub] [beam] jrmccluskey commented on a diff in pull request #28107: Explicitly call out dependency installation issues as unrecoverable

2023-08-23 Thread via GitHub
jrmccluskey commented on code in PR #28107: URL: https://github.com/apache/beam/pull/28107#discussion_r1303139682 ## sdks/python/container/boot.go: ## @@ -380,26 +380,26 @@ func installSetupPackages(files []string, workDir string, requirementsFiles []st pkgName := "apac

[GitHub] [beam] damccorm commented on a diff in pull request #28107: Explicitly call out dependency installation issues as unrecoverable

2023-08-23 Thread via GitHub
damccorm commented on code in PR #28107: URL: https://github.com/apache/beam/pull/28107#discussion_r1303130987 ## sdks/python/container/boot.go: ## @@ -380,26 +380,26 @@ func installSetupPackages(files []string, workDir string, requirementsFiles []st pkgName := "apache-

[GitHub] [beam] Abacn commented on pull request #28097: Change GH Issue linked to ignored DICOM IT

2023-08-23 Thread via GitHub
Abacn commented on PR #28097: URL: https://github.com/apache/beam/pull/28097#issuecomment-1690073998 thanks for catching this. As there is ongoing work we can leave the file as is and always add tests to it -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] Abacn merged pull request #28097: Change GH Issue linked to ignored DICOM IT

2023-08-23 Thread via GitHub
Abacn merged PR #28097: URL: https://github.com/apache/beam/pull/28097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] jrmccluskey commented on pull request #28107: Explicitly call out dependency installation issues as unrecoverable

2023-08-23 Thread via GitHub
jrmccluskey commented on PR #28107: URL: https://github.com/apache/beam/pull/28107#issuecomment-1690030294 Run PythonDocs PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] svetakvsundhar commented on pull request #28013: use google form for feedback

2023-08-23 Thread via GitHub
svetakvsundhar commented on PR #28013: URL: https://github.com/apache/beam/pull/28013#issuecomment-1689938998 @aaltay do you want to merge? Think it's safe to assume no objections will happen on the dev discussion list -- This is an automated message from the Apache Git Service. To respon

[GitHub] [beam] github-actions[bot] closed pull request #17761: [BEAM-14481] Make ScopedState explicitly not re-entrant

2023-08-23 Thread via GitHub
github-actions[bot] closed pull request #17761: [BEAM-14481] Make ScopedState explicitly not re-entrant URL: https://github.com/apache/beam/pull/17761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] github-actions[bot] commented on pull request #27129: [WIP] Attempt to bump avro version to 1.11 for the overall dependency in Beam.

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #27129: URL: https://github.com/apache/beam/pull/27129#issuecomment-1689891428 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull r

[GitHub] [beam] github-actions[bot] commented on pull request #26943: Vortex test

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #26943: URL: https://github.com/apache/beam/pull/26943#issuecomment-1689854195 Reminder, please take a look at this pr: @robertwb @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] github-actions[bot] commented on pull request #27999: Add GitHub Workflow Replacement for Jenkins job_PreCommit_Java

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #27999: URL: https://github.com/apache/beam/pull/27999#issuecomment-1689854107 Reminder, please take a look at this pr: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [beam] github-actions[bot] commented on pull request #28002: Remove unneeded View.asList when View.asIterable suffices.

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28002: URL: https://github.com/apache/beam/pull/28002#issuecomment-1689854054 Reminder, please take a look at this pr: @kennknowles -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] github-actions[bot] commented on pull request #28013: use google form for feedback

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28013: URL: https://github.com/apache/beam/pull/28013#issuecomment-1689854010 Reminder, please take a look at this pr: @kennknowles -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] AnandInguva commented on a diff in pull request #27620: Add MLTransform IT test

2023-08-23 Thread via GitHub
AnandInguva commented on code in PR #27620: URL: https://github.com/apache/beam/pull/27620#discussion_r1302878204 ## sdks/python/apache_beam/examples/ml_transform/vocab_tfidf_processing.py: ## @@ -0,0 +1,190 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] aleksandr-dudko opened a new pull request, #28119: Add GitHub Workflow Replacement for Jenkins job_PreCommit_Java_File-schema-transform_IO_Direct

2023-08-23 Thread via GitHub
aleksandr-dudko opened a new pull request, #28119: URL: https://github.com/apache/beam/pull/28119 The following jenkins jobs have been migrated: https://ci-beam.apache.org/view/PreCommit/job/beam_PreCommit_Java_File-schema-transform_IO_Direct_Commit/ https://ci-beam.apache.org/vie

[GitHub] [beam] AnandInguva closed pull request #28095: Revert "[Python]Don't stage beam SDK in Stager"

2023-08-23 Thread via GitHub
AnandInguva closed pull request #28095: Revert "[Python]Don't stage beam SDK in Stager" URL: https://github.com/apache/beam/pull/28095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] kberezin-nshl commented on pull request #28093: SpannerIO: retry if concurrent transaction is aborted by emulator

2023-08-23 Thread via GitHub
kberezin-nshl commented on PR #28093: URL: https://github.com/apache/beam/pull/28093#issuecomment-1689446949 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [beam] github-actions[bot] commented on pull request #28090: Add Java Neo4j IO Direct job

2023-08-23 Thread via GitHub
github-actions[bot] commented on PR #28090: URL: https://github.com/apache/beam/pull/28090#issuecomment-1689432586 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

  1   2   >