[GitHub] [beam] Amar3tto commented on a diff in pull request #28431: Add Python Load Tests Combine Dataflow Batch github action

2023-09-15 Thread via GitHub
Amar3tto commented on code in PR #28431: URL: https://github.com/apache/beam/pull/28431#discussion_r1327911955 ## .github/workflows/beam_LoadTests_Python_Combine_Dataflow_Batch.yml: ## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# con

[GitHub] [beam] hjtran commented on pull request #28489: Propagate annotations of CombinePerKey transforms to resulting component transforms

2023-09-15 Thread via GitHub
hjtran commented on PR #28489: URL: https://github.com/apache/beam/pull/28489#issuecomment-1722111741 > Thanks. LGTM once yapf/lint are happy. Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [beam] github-actions[bot] commented on pull request #28274: Remove TableSchema to JSON conversion.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28274: URL: https://github.com/apache/beam/pull/28274#issuecomment-1722105098 ## Test Results   7 files    7 suites   54m 7s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "duration of all t

[GitHub] [beam] codecov[bot] commented on pull request #28489: Propagate annotations of CombinePerKey transforms to resulting component transforms

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28489: URL: https://github.com/apache/beam/pull/28489#issuecomment-1722073037 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28489?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] github-actions[bot] commented on pull request #28489: Propagate annotations of CombinePerKey transforms to resulting component transforms

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28489: URL: https://github.com/apache/beam/pull/28489#issuecomment-1722063241 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] hjtran commented on pull request #28489: Propagate annotations of CombinePerKey transforms to resulting component transforms

2023-09-15 Thread via GitHub
hjtran commented on PR #28489: URL: https://github.com/apache/beam/pull/28489#issuecomment-1722060510 R: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [beam] hjtran opened a new pull request, #28489: Propagate annotations of CombinePerKey transforms to resulting component transforms

2023-09-15 Thread via GitHub
hjtran opened a new pull request, #28489: URL: https://github.com/apache/beam/pull/28489 **Please** add a meaningful description for your change here Issue: -- If somehow you have an annotation(s) on a `CombinePerKey` transform (e.g. because you s

[GitHub] [beam] github-actions[bot] commented on pull request #28488: Remove extra registrations for createFn.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28488: URL: https://github.com/apache/beam/pull/28488#issuecomment-1722027338 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label go. Available commands: - `stop

[GitHub] [beam] robertwb commented on a diff in pull request #28210: Upgrade transforms without upgrading the pipelines

2023-09-15 Thread via GitHub
robertwb commented on code in PR #28210: URL: https://github.com/apache/beam/pull/28210#discussion_r1327810238 ## runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/CreateTranslation.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache So

[GitHub] [beam] github-actions[bot] commented on pull request #28488: Remove extra registrations for createFn.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28488: URL: https://github.com/apache/beam/pull/28488#issuecomment-1721965344 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

[GitHub] [beam] codecov[bot] commented on pull request #28486: Add schema-aware text file reading and writing.

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28486: URL: https://github.com/apache/beam/pull/28486#issuecomment-1721947209 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] github-actions[bot] commented on pull request #28476: Add tox tests for Pandas 2.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28476: URL: https://github.com/apache/beam/pull/28476#issuecomment-1721932387 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] codecov[bot] commented on pull request #28488: Remove extra registrations for createFn.

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28488: URL: https://github.com/apache/beam/pull/28488#issuecomment-1721930105 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] github-actions[bot] commented on pull request #28487: [#28187] Add standalone prism validates runner precommit

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28487: URL: https://github.com/apache/beam/pull/28487#issuecomment-1721927994 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. R: @damccorm for label build.

[GitHub] [beam] tvalentyn commented on pull request #28455: Change pd.core.strings.StringMethods for Pandas 2 compatability.

2023-09-15 Thread via GitHub
tvalentyn commented on PR #28455: URL: https://github.com/apache/beam/pull/28455#issuecomment-1721923713 Run Python_PVR_Flink PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] tvalentyn commented on pull request #28455: Change pd.core.strings.StringMethods for Pandas 2 compatability.

2023-09-15 Thread via GitHub
tvalentyn commented on PR #28455: URL: https://github.com/apache/beam/pull/28455#issuecomment-1721923510 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] tvalentyn commented on pull request #28455: Change pd.core.strings.StringMethods for Pandas 2 compatability.

2023-09-15 Thread via GitHub
tvalentyn commented on PR #28455: URL: https://github.com/apache/beam/pull/28455#issuecomment-1721913053 Run Python_PVR_Flink PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] caneff commented on a diff in pull request #28455: Change pd.core.strings.StringMethods for Pandas 2 compatability.

2023-09-15 Thread via GitHub
caneff commented on code in PR #28455: URL: https://github.com/apache/beam/pull/28455#discussion_r1327827588 ## sdks/python/apache_beam/dataframe/frames.py: ## @@ -4907,9 +4907,9 @@ def __setitem__(self, index, value): class _DeferredStringMethods(frame_base.DeferredBase):

[GitHub] [beam] lostluck opened a new pull request, #28488: Remove extra registrations for createFn.

2023-09-15 Thread via GitHub
lostluck opened a new pull request, #28488: URL: https://github.com/apache/beam/pull/28488 The additional registrations were causing log spam for *all* Go SDK pipelines. This removes the code gen registrations for createFn, and the redundant init block for the generic registrations.

[GitHub] [beam] arvindram03 commented on a diff in pull request #28442: Sets recommended max Xmx 32G when set_recommended_max_xmx experiment is enabled

2023-09-15 Thread via GitHub
arvindram03 commented on code in PR #28442: URL: https://github.com/apache/beam/pull/28442#discussion_r1327826967 ## sdks/java/container/boot.go: ## @@ -266,9 +267,12 @@ func makePipelineOptionsFile(options string) error { // it returns 70% of the physical memory on the machine

[GitHub] [beam] codecov[bot] commented on pull request #28442: Sets recommended max Xmx 32G when set_recommended_max_xmx experiment is enabled

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28442: URL: https://github.com/apache/beam/pull/28442#issuecomment-1721902006 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28442?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] tvalentyn commented on issue #28364: [Bug]: pip install apache_beam is very slow

2023-09-15 Thread via GitHub
tvalentyn commented on issue #28364: URL: https://github.com/apache/beam/issues/28364#issuecomment-1721895131 i looked at dependency chain, we have a dep on grpcio also through other packages, so would be harder to let go of it completely, i'll reach out to maintainers again. -- This is

[GitHub] [beam] tvalentyn closed issue #28364: [Bug]: pip install apache_beam is very slow

2023-09-15 Thread via GitHub
tvalentyn closed issue #28364: [Bug]: pip install apache_beam is very slow URL: https://github.com/apache/beam/issues/28364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] codecov[bot] commented on pull request #28487: [#28187] Add standalone prism validates runner precommit

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28487: URL: https://github.com/apache/beam/pull/28487#issuecomment-1721892757 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28487?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] tvalentyn commented on a diff in pull request #28385: Add pyproject.toml

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28385: URL: https://github.com/apache/beam/pull/28385#discussion_r1327815331 ## sdks/python/container/py310/base_image_requirements.txt: ## @@ -26,11 +26,12 @@ astunparse==1.6.3 attrs==23.1.0 Review Comment: i'd revert changes to these for

[GitHub] [beam] tvalentyn commented on a diff in pull request #28385: Add pyproject.toml

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28385: URL: https://github.com/apache/beam/pull/28385#discussion_r1327814379 ## sdks/python/apache_beam/io/gcp/bigquery_test.py: ## @@ -103,6 +102,51 @@ def _load_or_default(filename): return {} +_DESTINATION_ELEMENT_PAIRS = [ Review

[GitHub] [beam] tvalentyn commented on a diff in pull request #28385: Add pyproject.toml

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28385: URL: https://github.com/apache/beam/pull/28385#discussion_r1327814379 ## sdks/python/apache_beam/io/gcp/bigquery_test.py: ## @@ -103,6 +102,51 @@ def _load_or_default(filename): return {} +_DESTINATION_ELEMENT_PAIRS = [ Review

[GitHub] [beam] tvalentyn commented on a diff in pull request #28385: Add pyproject.toml

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28385: URL: https://github.com/apache/beam/pull/28385#discussion_r1327813313 ## buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy: ## @@ -3032,30 +3032,40 @@ class BeamModulePlugin implements Plugin { } r

[GitHub] [beam] github-actions[bot] commented on pull request #28476: Add tox tests for Pandas 2.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28476: URL: https://github.com/apache/beam/pull/28476#issuecomment-1721887563 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label python. Available commands: - `s

[GitHub] [beam] tvalentyn commented on a diff in pull request #28385: Add pyproject.toml

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28385: URL: https://github.com/apache/beam/pull/28385#discussion_r1327811895 ## sdks/python/setup.py: ## @@ -213,22 +242,9 @@ def get_portability_package_data(): *get_portability_package_data() ] }, - ext_m

[GitHub] [beam] lostluck opened a new pull request, #28487: [#28187] Add standalone prism validates runner precommit

2023-09-15 Thread via GitHub
lostluck opened a new pull request, #28487: URL: https://github.com/apache/beam/pull/28487 Add a github action precommit for the standalone prism runner. Standalone prism uses job specified environments (usually docker containers), by default. * Updates the go run_validates_runner.sh

[GitHub] [beam] tvalentyn commented on a diff in pull request #28474: Update HuggingFace api doc and add text2audio pipeline task

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28474: URL: https://github.com/apache/beam/pull/28474#discussion_r1327788133 ## sdks/python/apache_beam/ml/inference/huggingface_inference.py: ## @@ -593,9 +594,11 @@ def __init__( Args: task (str or enum.Enum): task supported by Hu

[GitHub] [beam] tvalentyn commented on a diff in pull request #28474: Update HuggingFace api doc and add text2audio pipeline task

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28474: URL: https://github.com/apache/beam/pull/28474#discussion_r1327788133 ## sdks/python/apache_beam/ml/inference/huggingface_inference.py: ## @@ -593,9 +594,11 @@ def __init__( Args: task (str or enum.Enum): task supported by Hu

[GitHub] [beam] Abacn commented on a diff in pull request #28477: add setJoinSubsetType to inject joinSubsetType to BeamSqlSeekableTable

2023-09-15 Thread via GitHub
Abacn commented on code in PR #28477: URL: https://github.com/apache/beam/pull/28477#discussion_r1327793796 ## sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java: ## @@ -28,6 +29,7 @@ * FROM FACT_TABLE JOIN LOOKUP_TABLE ON ...}.

[GitHub] [beam] damccorm merged pull request #28484: Update dataflow container version

2023-09-15 Thread via GitHub
damccorm merged PR #28484: URL: https://github.com/apache/beam/pull/28484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] Abacn commented on a diff in pull request #28477: add setJoinSubsetType to inject joinSubsetType to BeamSqlSeekableTable

2023-09-15 Thread via GitHub
Abacn commented on code in PR #28477: URL: https://github.com/apache/beam/pull/28477#discussion_r1327785313 ## sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java: ## @@ -116,6 +116,7 @@ public JoinAsLookup( thi

[GitHub] [beam] Abacn commented on a diff in pull request #28477: add setJoinSubsetType to inject joinSubsetType to BeamSqlSeekableTable

2023-09-15 Thread via GitHub
Abacn commented on code in PR #28477: URL: https://github.com/apache/beam/pull/28477#discussion_r1327785313 ## sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java: ## @@ -116,6 +116,7 @@ public JoinAsLookup( thi

[GitHub] [beam] codecov[bot] commented on pull request #28485: [BEAM-28399] Ensure dataflow experiments are always set when dataflowflow runner is used.

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28485: URL: https://github.com/apache/beam/pull/28485#issuecomment-1721848098 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28485?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] Abacn commented on pull request #28382: Support legacy DATE and TIME logical types in xlang JdbcIO

2023-09-15 Thread via GitHub
Abacn commented on PR #28382: URL: https://github.com/apache/beam/pull/28382#issuecomment-1721847530 Thanks, added comments to both paths -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] github-actions[bot] commented on pull request #28486: Add schema-aware text file reading and writing.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28486: URL: https://github.com/apache/beam/pull/28486#issuecomment-1721844124 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] robertwb commented on pull request #28486: Add schema-aware text file reading and writing.

2023-09-15 Thread via GitHub
robertwb commented on PR #28486: URL: https://github.com/apache/beam/pull/28486#issuecomment-1721842447 R: @Polber -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] robertwb opened a new pull request, #28486: Add schema-aware text file reading and writing.

2023-09-15 Thread via GitHub
robertwb opened a new pull request, #28486: URL: https://github.com/apache/beam/pull/28486 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

[GitHub] [beam] robertwb commented on pull request #28485: [BEAM-28399] Ensure dataflow experiments are always set when dataflowflow runner is used.

2023-09-15 Thread via GitHub
robertwb commented on PR #28485: URL: https://github.com/apache/beam/pull/28485#issuecomment-1721807716 R: @liferoad Fixes #28399. I verified manually that this makes the repo pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] robertwb opened a new pull request, #28485: [BEAM-28399] Ensure dataflow experiments are always set when dataflowflow runner is used.

2023-09-15 Thread via GitHub
robertwb opened a new pull request, #28485: URL: https://github.com/apache/beam/pull/28485 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in yo

[GitHub] [beam] robertwb commented on issue #28399: [Bug]: The DataflowRunner behavior is changed when removing the runner v1 code

2023-09-15 Thread via GitHub
robertwb commented on issue #28399: URL: https://github.com/apache/beam/issues/28399#issuecomment-1721805319 This boils down to https://s.apache.org/no-beam-pipeline :). It looks like manually setting these flags after construction may be sufficient. Right now we're hijacking the `ap

[GitHub] [beam] github-actions[bot] commented on pull request #28484: Update dataflow container version

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28484: URL: https://github.com/apache/beam/pull/28484#issuecomment-1721777975 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] damccorm commented on pull request #28484: Update dataflow container version

2023-09-15 Thread via GitHub
damccorm commented on PR #28484: URL: https://github.com/apache/beam/pull/28484#issuecomment-1721775235 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [beam] codecov[bot] commented on pull request #28484: Update dataflow container version

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28484: URL: https://github.com/apache/beam/pull/28484#issuecomment-1721772921 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] damccorm commented on a diff in pull request #28483: Migrate "beam_PostCommit_Python_Nexmark_Direct" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
damccorm commented on code in PR #28483: URL: https://github.com/apache/beam/pull/28483#discussion_r1327714211 ## .github/workflows/beam_PostCommit_Python_Nexmark_Direct.yml: ## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

[GitHub] [beam] damccorm opened a new pull request, #28484: Update dataflow container version

2023-09-15 Thread via GitHub
damccorm opened a new pull request, #28484: URL: https://github.com/apache/beam/pull/28484 Needs to wait until container cloning completes Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily

[GitHub] [beam] tvalentyn commented on a diff in pull request #28422: Fix numeric_only logic in frames_test for Pandas 2

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28422: URL: https://github.com/apache/beam/pull/28422#discussion_r1327694184 ## sdks/python/apache_beam/dataframe/frames_test.py: ## @@ -1900,14 +1916,35 @@ def test_dataframe_groupby_series(self, agg_type): self.skipTest( "ht

[GitHub] [beam] robertwb merged pull request #28479: Remove implicitly defined IOs.

2023-09-15 Thread via GitHub
robertwb merged PR #28479: URL: https://github.com/apache/beam/pull/28479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] andreydevyatkin commented on a diff in pull request #28483: Migrate "beam_PostCommit_Python_Nexmark_Direct" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
andreydevyatkin commented on code in PR #28483: URL: https://github.com/apache/beam/pull/28483#discussion_r1327682892 ## .github/workflows/beam_PostCommit_Python_Nexmark_Direct.yml: ## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [beam] github-actions[bot] commented on pull request #28479: Remove implicitly defined IOs.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28479: URL: https://github.com/apache/beam/pull/28479#issuecomment-1721721664 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @AnandInguva for label python. Available commands: - `st

[GitHub] [beam] github-actions[bot] commented on pull request #28483: Migrate "beam_PostCommit_Python_Nexmark_Direct" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28483: URL: https://github.com/apache/beam/pull/28483#issuecomment-1721721581 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label build. Available commands: - `stop revi

[GitHub] [beam] svetakvsundhar commented on pull request #28482: [Document]: `HealthcareApiClient` methods.

2023-09-15 Thread via GitHub
svetakvsundhar commented on PR #28482: URL: https://github.com/apache/beam/pull/28482#issuecomment-1721720756 > Spotless error: `Error: eckstyle] [ERROR] /runner/_work/beam/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HealthcareApiClient.java:19

[GitHub] [beam] Abacn commented on pull request #28482: [Document]: `HealthcareApiClient` methods.

2023-09-15 Thread via GitHub
Abacn commented on PR #28482: URL: https://github.com/apache/beam/pull/28482#issuecomment-1721718934 Spotless error: `Error: eckstyle] [ERROR] /runner/_work/beam/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HealthcareApiClient.java:194:6: Unuse

[GitHub] [beam] github-actions[bot] commented on pull request #28482: [Document]: `HealthcareApiClient` methods.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28482: URL: https://github.com/apache/beam/pull/28482#issuecomment-1721715431 ## Test Results   6 files   -   1    6 suites   - 1   54m 7s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "dur

[GitHub] [beam] tvalentyn commented on pull request #28454: Support kw only arguments for frame methods for Pandas 2

2023-09-15 Thread via GitHub
tvalentyn commented on PR #28454: URL: https://github.com/apache/beam/pull/28454#issuecomment-1721714800 Run Python_Runners PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] tvalentyn commented on pull request #28454: Support kw only arguments for frame methods for Pandas 2

2023-09-15 Thread via GitHub
tvalentyn commented on PR #28454: URL: https://github.com/apache/beam/pull/28454#issuecomment-1721714521 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] liferoad commented on a diff in pull request #28475: Feature/add retry to gcp auth

2023-09-15 Thread via GitHub
liferoad commented on code in PR #28475: URL: https://github.com/apache/beam/pull/28475#discussion_r1327672361 ## sdks/python/apache_beam/internal/gcp/auth_test.py: ## @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

[GitHub] [beam] damccorm commented on pull request #28412: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_PVR_*

2023-09-15 Thread via GitHub
damccorm commented on PR #28412: URL: https://github.com/apache/beam/pull/28412#issuecomment-1721712126 I'll merge once conflicts are resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] damccorm commented on a diff in pull request #28301: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Python

2023-09-15 Thread via GitHub
damccorm commented on code in PR #28301: URL: https://github.com/apache/beam/pull/28301#discussion_r1327670161 ## .github/workflows/beam_PostCommit_Sickbay_Python.yml: ## @@ -52,27 +52,29 @@ env: jobs: beam_PostCommit_Sickbay_Python: -name: ${{matrix.job_name}} (${{mat

[GitHub] [beam] liferoad commented on a diff in pull request #28475: Feature/add retry to gcp auth

2023-09-15 Thread via GitHub
liferoad commented on code in PR #28475: URL: https://github.com/apache/beam/pull/28475#discussion_r1327668893 ## sdks/python/apache_beam/internal/gcp/auth.py: ## @@ -159,12 +159,19 @@ def _get_service_credentials(pipeline_options): 'Credentials.') return crede

[GitHub] [beam] damccorm merged pull request #28368: Github Workflow Replacement for Jenkins Job, beam_PostCommit_Website_Test

2023-09-15 Thread via GitHub
damccorm merged PR #28368: URL: https://github.com/apache/beam/pull/28368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] damccorm commented on a diff in pull request #28483: Migrate "beam_PostCommit_Python_Nexmark_Direct" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
damccorm commented on code in PR #28483: URL: https://github.com/apache/beam/pull/28483#discussion_r1327668214 ## .github/workflows/beam_PostCommit_Python_Nexmark_Direct.yml: ## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

[GitHub] [beam] damccorm commented on a diff in pull request #28352: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Examples_Dataflow_V2

2023-09-15 Thread via GitHub
damccorm commented on code in PR #28352: URL: https://github.com/apache/beam/pull/28352#discussion_r1327665636 ## .github/workflows/beam_PostCommit_Java_Examples_Dataflow_V2_Java.yml: ## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[GitHub] [beam] liferoad commented on issue #28399: [Bug]: The DataflowRunner behavior is changed when removing the runner v1 code

2023-09-15 Thread via GitHub
liferoad commented on issue #28399: URL: https://github.com/apache/beam/issues/28399#issuecomment-1721700395 I could not figure out what cause this issue. I am wondering whether we need call `_check_and_add_missing_options` somewhere. -- This is an automated message from the Apache Git Se

[GitHub] [beam] tvalentyn commented on a diff in pull request #28455: Change pd.core.strings.StringMethods for Pandas 2 compatability.

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28455: URL: https://github.com/apache/beam/pull/28455#discussion_r1327660945 ## sdks/python/apache_beam/dataframe/frames.py: ## @@ -4907,9 +4907,9 @@ def __setitem__(self, index, value): class _DeferredStringMethods(frame_base.DeferredBase

[GitHub] [beam] damccorm commented on a diff in pull request #28451: Added jacoco plugin to GitHub Actions

2023-09-15 Thread via GitHub
damccorm commented on code in PR #28451: URL: https://github.com/apache/beam/pull/28451#discussion_r1327660813 ## sdks/java/io/google-cloud-platform/build.gradle: ## @@ -244,6 +244,23 @@ task integrationTestKms(type: Test) { } } +task codeCoverageReport(type: JacocoReport,

[GitHub] [beam] tvalentyn commented on a diff in pull request #28455: Change pd.core.strings.StringMethods for Pandas 2 compatability.

2023-09-15 Thread via GitHub
tvalentyn commented on code in PR #28455: URL: https://github.com/apache/beam/pull/28455#discussion_r1327660413 ## sdks/python/apache_beam/dataframe/frames.py: ## @@ -4907,9 +4907,9 @@ def __setitem__(self, index, value): class _DeferredStringMethods(frame_base.DeferredBase

[GitHub] [beam] damccorm merged pull request #28473: Migrate "beam_PostCommit_Java_Hadoop_Versions" Jenkins job to GitHub Actions

2023-09-15 Thread via GitHub
damccorm merged PR #28473: URL: https://github.com/apache/beam/pull/28473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #28475: Feature/add retry to gcp auth

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28475: URL: https://github.com/apache/beam/pull/28475#issuecomment-1721687860 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @liferoad for label python. Available commands: - `stop

[GitHub] [beam] damccorm merged pull request #28472: Migrate "beam_PostCommit_Python_MongoDBIO_IT" Jenkins job to GitHub Actions

2023-09-15 Thread via GitHub
damccorm merged PR #28472: URL: https://github.com/apache/beam/pull/28472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #28482: [Document]: `HealthcareApiClient` methods.

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28482: URL: https://github.com/apache/beam/pull/28482#issuecomment-1721679931 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] svetakvsundhar commented on pull request #28482: [Document]: `HealthcareApiClient` methods.

2023-09-15 Thread via GitHub
svetakvsundhar commented on PR #28482: URL: https://github.com/apache/beam/pull/28482#issuecomment-1721677822 R: @Abacn for committer review R: [@rachelgagnon](https://github.com/rachelgagnon) for domain review -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [beam] andreydevyatkin opened a new pull request, #28483: Migrate "beam_PostCommit_Python_Nexmark_Direct" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
andreydevyatkin opened a new pull request, #28483: URL: https://github.com/apache/beam/pull/28483 The following jenkins job has been migrated: - https://ci-beam.apache.org/job/beam_PostCommit_Python_Nexmark_Direct/ ### How has it been tested? The jobs have been tested on Self

[GitHub] [beam] svetakvsundhar opened a new pull request, #28482: [Document]: `HealthcareApiClient` methods.

2023-09-15 Thread via GitHub
svetakvsundhar opened a new pull request, #28482: URL: https://github.com/apache/beam/pull/28482 Fixes https://github.com/apache/beam/issues/28415. Several methods are undocumented in the `HealthcareApiClient`. We should document these parameters for better user experience, given that

[GitHub] [beam] Abacn commented on pull request #28272: Fix pane info in BigQuery load job id

2023-09-15 Thread via GitHub
Abacn commented on PR #28272: URL: https://github.com/apache/beam/pull/28272#issuecomment-1721668308 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] tvalentyn commented on issue #28399: [Bug]: The DataflowRunner behavior is changed when removing the runner v1 code

2023-09-15 Thread via GitHub
tvalentyn commented on issue #28399: URL: https://github.com/apache/beam/issues/28399#issuecomment-1721664056 Repro: ``` import argparse import logging import apache_beam as beam from apache_beam.options.pipeline_options import PipelineOptions from apache_beam.runner

[GitHub] [beam] damccorm commented on a diff in pull request #28431: Add Python Load Tests Combine Dataflow Batch github action

2023-09-15 Thread via GitHub
damccorm commented on code in PR #28431: URL: https://github.com/apache/beam/pull/28431#discussion_r1327632501 ## .github/workflows/beam_LoadTests_Python_Combine_Dataflow_Batch.yml: ## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# con

[GitHub] [beam] xinyuiscool merged pull request #28461: Allow dropLataData in GBK for SamzaRunner

2023-09-15 Thread via GitHub
xinyuiscool merged PR #28461: URL: https://github.com/apache/beam/pull/28461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[GitHub] [beam] kennknowles merged pull request #28374: Add mechanism to override bigtable client for testing

2023-09-15 Thread via GitHub
kennknowles merged PR #28374: URL: https://github.com/apache/beam/pull/28374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[GitHub] [beam] kennknowles commented on a diff in pull request #28374: Add mechanism to override bigtable client for testing

2023-09-15 Thread via GitHub
kennknowles commented on code in PR #28374: URL: https://github.com/apache/beam/pull/28374#discussion_r1327629142 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableConfig.java: ## @@ -156,6 +162,12 @@ public BigtableConfig withEmulat

[GitHub] [beam] github-actions[bot] commented on pull request #28475: Feature/add retry to gcp auth

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28475: URL: https://github.com/apache/beam/pull/28475#issuecomment-1721657584 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

[GitHub] [beam] codecov[bot] commented on pull request #28481: Suppress FutureWarnings for Pandas < 2

2023-09-15 Thread via GitHub
codecov[bot] commented on PR #28481: URL: https://github.com/apache/beam/pull/28481#issuecomment-1721628739 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28481?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] jrmccluskey merged pull request #28444: Prism docker env

2023-09-15 Thread via GitHub
jrmccluskey merged PR #28444: URL: https://github.com/apache/beam/pull/28444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[GitHub] [beam] damccorm commented on pull request #28372: Add Load Tests CoGBK Dataflow Streaming Java github action

2023-09-15 Thread via GitHub
damccorm commented on PR #28372: URL: https://github.com/apache/beam/pull/28372#issuecomment-1721622073 Will merge once conflicts are resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] damccorm merged pull request #28409: Migrate "beam_PostCommit_Java_Examples_*" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
damccorm merged PR #28409: URL: https://github.com/apache/beam/pull/28409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] damccorm merged pull request #28432: Github Workflow Replacement for Jenkins Jobs, beam_PostCommit_XVR_*

2023-09-15 Thread via GitHub
damccorm merged PR #28432: URL: https://github.com/apache/beam/pull/28432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] damccorm merged pull request #28466: Github Workflow Replacement for Jenkins Jobs, beam_PostCommit_Python_Xlang_*

2023-09-15 Thread via GitHub
damccorm merged PR #28466: URL: https://github.com/apache/beam/pull/28466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] damccorm commented on pull request #28472: Migrate "beam_PostCommit_Python_MongoDBIO_IT" Jenkins job to GitHub Actions

2023-09-15 Thread via GitHub
damccorm commented on PR #28472: URL: https://github.com/apache/beam/pull/28472#issuecomment-1721613127 Looks like there are conflicts preventing merging unfortunately, will merge once those are resolved -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] caneff commented on a diff in pull request #28454: Support kw only arguments for frame methods for Pandas 2

2023-09-15 Thread via GitHub
caneff commented on code in PR #28454: URL: https://github.com/apache/beam/pull/28454#discussion_r1327592711 ## sdks/python/apache_beam/dataframe/frame_base_test.py: ## @@ -129,6 +132,45 @@ def func_removed_args(self, a, c, **kwargs): proxy.func_removed_args() self.a

[GitHub] [beam] damccorm merged pull request #28448: Migrate "beam_PostCommit_Python_ValidatesContainer_Dataflow" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
damccorm merged PR #28448: URL: https://github.com/apache/beam/pull/28448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] caneff commented on a diff in pull request #28454: Support kw only arguments for frame methods for Pandas 2

2023-09-15 Thread via GitHub
caneff commented on code in PR #28454: URL: https://github.com/apache/beam/pull/28454#discussion_r1327592167 ## sdks/python/apache_beam/dataframe/frame_base_test.py: ## @@ -72,7 +72,7 @@ def add_one(frame): def test_args_to_kwargs(self): class Base(object): - def

[GitHub] [beam] damccorm merged pull request #28447: Migrate "beam_PostCommit_PortableJar_*" Jenkins jobs to GitHub Actions

2023-09-15 Thread via GitHub
damccorm merged PR #28447: URL: https://github.com/apache/beam/pull/28447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #28480: Comment results to PR only when issue_comments

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28480: URL: https://github.com/apache/beam/pull/28480#issuecomment-1721608757 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] Abacn commented on pull request #28480: Comment results to PR only when issue_comments

2023-09-15 Thread via GitHub
Abacn commented on PR #28480: URL: https://github.com/apache/beam/pull/28480#issuecomment-1721607212 R: @magicgoody @andreydevyatkin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] caneff commented on a diff in pull request #28454: Support kw only arguments for frame methods for Pandas 2

2023-09-15 Thread via GitHub
caneff commented on code in PR #28454: URL: https://github.com/apache/beam/pull/28454#discussion_r1327587669 ## sdks/python/apache_beam/dataframe/frame_base.py: ## @@ -500,6 +500,8 @@ def wrap(func): removed_arg_names = removed_args if removed_args is not None else [] +

[GitHub] [beam] github-actions[bot] commented on pull request #28481: Suppress FutureWarnings for Pandas < 2

2023-09-15 Thread via GitHub
github-actions[bot] commented on PR #28481: URL: https://github.com/apache/beam/pull/28481#issuecomment-1721606971 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

  1   2   >