Re: [PR] Change pubsub message cap size from 10MiB to 10MB [beam]

github-actions[bot] commented on PR #29791: URL: https://github.com/apache/beam/pull/29791#issuecomment-1858689992 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [PR] Change pubsub message cap size from 10MiB to 10MB [beam]

arunpandianp commented on PR #29791: URL: https://github.com/apache/beam/pull/29791#issuecomment-1858689684 R: @scwhittle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] Change pubsub message cap size from 10MiB to 10MB [beam]

arunpandianp opened a new pull request, #29791: URL: https://github.com/apache/beam/pull/29791 Change pubsub message cap size from 10MiB to 10MB Pubsub's max allowed message size is 10million bytes and not 10 * 2^20 bytes https://cloud.google.com/pubsub/quotas -

Re: [PR] add alts to grpc vendored lib [beam]

m-trieu commented on PR #29763: URL: https://github.com/apache/beam/pull/29763#issuecomment-1858647877 @damccorm ready for merge! thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update dataflow container tag [beam]

github-actions[bot] commented on PR #29790: URL: https://github.com/apache/beam/pull/29790#issuecomment-1858645930 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

Re: [PR] Update dataflow container tag [beam]

AnandInguva commented on PR #29790: URL: https://github.com/apache/beam/pull/29790#issuecomment-1858636902 R : @damccorm @tvalentyn @jrmccluskey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] Update dataflow container tag [beam]

AnandInguva opened a new pull request, #29790: URL: https://github.com/apache/beam/pull/29790 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution qu

Re: [PR] getProcessingTimesByStep returns a modifiable map [beam]

github-actions[bot] commented on PR #29786: URL: https://github.com/apache/beam/pull/29786#issuecomment-1858590022 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [PR] getProcessingTimesByStep returns a modifiable map [beam]

clmccart commented on PR #29786: URL: https://github.com/apache/beam/pull/29786#issuecomment-1858589118 R: @jrmccluskey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] make DataSample external [beam]

github-actions[bot] commented on PR #29788: URL: https://github.com/apache/beam/pull/29788#issuecomment-1858584214 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [PR] make DataSample external [beam]

zechenj18 commented on PR #29788: URL: https://github.com/apache/beam/pull/29788#issuecomment-1858583467 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] add alts to grpc vendored lib [beam]

m-trieu commented on PR #29763: URL: https://github.com/apache/beam/pull/29763#issuecomment-1858581020 @Abacn https://docs.google.com/document/d/1ztEoyGkqq9ie5riQxRtMuBu3vb6BUO91mSMn1PU0pDA/edit#heading=h.ev6nn5h2yrb1 After this is submitted can I just follow the steps here? -- T

Re: [PR] make DataSample external [beam]

codecov[bot] commented on PR #29788: URL: https://github.com/apache/beam/pull/29788#issuecomment-1858575787 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/29788?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[PR] make DataSample external [beam]

zechenj18 opened a new pull request, #29788: URL: https://github.com/apache/beam/pull/29788 make DataSample external based on Golint: exported method GetSamples returns unexported type map[string][]*exec.dataSample, which can be annoying to use Thank

Re: [I] [Bug]: DaskRunner GBK failures related to partitioning prevent use of string keys and break `assert_that` [beam]

cisaacstern commented on issue #29365: URL: https://github.com/apache/beam/issues/29365#issuecomment-1858571049 Pleased to report that https://github.com/dask/distributed/pull/8400 provides a path forward for this. I'll open a draft PR bumping the dask version we use in Beam (to be c

Re: [I] [Bug]: Reenable Dask suite [beam]

cisaacstern commented on issue #25696: URL: https://github.com/apache/beam/issues/25696#issuecomment-1858568698 .take-issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Bug]: Reenable Dask suite [beam]

cisaacstern commented on issue #25696: URL: https://github.com/apache/beam/issues/25696#issuecomment-1858569033 Looks like this has sat for a while, I'll take it as part of my ongoing efforts on DaskRunner. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] Add documentation and improved errors for QueryFn in MongoDbIO [beam]

johnjcasey commented on issue #21005: URL: https://github.com/apache/beam/issues/21005#issuecomment-1858471085 Yep, will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Python] Enrichment Transform v1 [beam]

riteshghorse commented on PR #29782: URL: https://github.com/apache/beam/pull/29782#issuecomment-1858439914 Run Python_Integration PreCommit 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [Python] Enrichment Transform v1 [beam]

riteshghorse commented on PR #29782: URL: https://github.com/apache/beam/pull/29782#issuecomment-1858423190 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] getProcessingTimesByStep returns a modifiable map [beam]

clmccart opened a new pull request, #29786: URL: https://github.com/apache/beam/pull/29786 patch to fix issue raise in b/316589235 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [PR] Fix typos [beam]

github-actions[bot] commented on PR #29785: URL: https://github.com/apache/beam/pull/29785#issuecomment-1858389076 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [PR] Fix typos [beam]

chamikaramj commented on PR #29785: URL: https://github.com/apache/beam/pull/29785#issuecomment-1858387562 R: @AnandInguva -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Fix typos [beam]

chamikaramj opened a new pull request, #29785: URL: https://github.com/apache/beam/pull/29785 This fixes https://github.com/apache/beam/issues/29783 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

Re: [I] PreSubmit Java failing Spotbug on master [beam]

jrmccluskey commented on issue #29784: URL: https://github.com/apache/beam/issues/29784#issuecomment-1858345840 Does this impact the release branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] PreSubmit Java failing Spotbug on master [beam]

Abacn commented on issue #29784: URL: https://github.com/apache/beam/issues/29784#issuecomment-1858312337 CC: @jrmccluskey @damccorm to bring attention -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] [Task]: Fix typos in sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java [beam]

AnandInguva commented on issue #29783: URL: https://github.com/apache/beam/issues/29783#issuecomment-1858310287 @chamikaramj I am assigning this to you since you are the owner of the https://github.com/apache/beam/pull/29731 -- This is an automated message from the Apache Git Service. To

Re: [PR] add alts to grpc vendored lib [beam]

Abacn commented on PR #29763: URL: https://github.com/apache/beam/pull/29763#issuecomment-1858303731 LGTM. This change itself won't take effect as beam (dev or release) use the packaged artifact for vendor dep, and this file is for the rule to package that effect. That said ne

Re: [PR] Dataflow Streaming: Add a pipeline option `--desiredNumUnboundedSourceSplits` [beam]

arunpandianp commented on PR #29704: URL: https://github.com/apache/beam/pull/29704#issuecomment-1858118668 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Improve varint encoding throughput with unrolled loop [beam]

sjvanrossum commented on PR #29689: URL: https://github.com/apache/beam/pull/29689#issuecomment-1858071294 Note to self: Perform integration benchmarks to verify the instruction bloat does not negatively affect cache behavior. -- This is an automated message from the Apache Git Service. T

Re: [I] Add documentation and improved errors for QueryFn in MongoDbIO [beam]

damccorm commented on issue #21005: URL: https://github.com/apache/beam/issues/21005#issuecomment-1858067852 @johnjcasey could you help here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Fixes breakages of the upgrade feature (#29731) [beam]

jrmccluskey merged PR #29766: URL: https://github.com/apache/beam/pull/29766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

[PR] [Python] Enrichment Transform v1 [beam]

riteshghorse opened a new pull request, #29782: URL: https://github.com/apache/beam/pull/29782 Implemented enrichment transform Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: -

Re: [PR] Add SparkStructuredStreamingRunner to beam_PostCommit_Java_Tpcds_Spark workflow [beam]

aromanenko-dev merged PR #29781: URL: https://github.com/apache/beam/pull/29781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.

Re: [PR] Add WindmillConnectionsCache used to consume GetWorkerMetadata response and updates [beam]

scwhittle commented on PR #28428: URL: https://github.com/apache/beam/pull/28428#issuecomment-1857910130 I belive this is replaced by the other PRs, closing this one. Repush after rebasing if there are things worht keeping in this one. -- This is an automated message from the Apache Git S

Re: [PR] Add WindmillConnectionsCache used to consume GetWorkerMetadata response and updates [beam]

scwhittle closed pull request #28428: Add WindmillConnectionsCache used to consume GetWorkerMetadata response and updates URL: https://github.com/apache/beam/pull/28428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Dataflow Streaming: Add a pipeline option `--desiredNumUnboundedSourceSplits` [beam]

scwhittle commented on PR #29704: URL: https://github.com/apache/beam/pull/29704#issuecomment-1857907008 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump actions/upload-artifact from 3 to 4 [beam]

damccorm merged PR #29777: URL: https://github.com/apache/beam/pull/29777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] Add SparkStructuredStreamingRunner to beam_PostCommit_Java_Tpcds_Spark workflow [beam]

damccorm commented on code in PR #29781: URL: https://github.com/apache/beam/pull/29781#discussion_r1427901826 ## .github/workflows/beam_PostCommit_Java_Tpcds_Spark.yml: ## @@ -85,6 +84,7 @@ jobs: matrix: job_name: ["beam_PostCommit_Java_Tpcds_Spark"] jo

Re: [PR] Ignore testOnNewWorkerMetadata_correctlyRemovesStaleWindmillServers [beam]

Abacn merged PR #29744: URL: https://github.com/apache/beam/pull/29744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

Re: [PR] Ignore testOnNewWorkerMetadata_correctlyRemovesStaleWindmillServers [beam]

Abacn commented on PR #29744: URL: https://github.com/apache/beam/pull/29744#issuecomment-1857753243 It seems the master is unhealthy with spotbug error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add SparkStructuredStreamingRunner to beam_PostCommit_Java_Tpcds_Spark workflow [beam]

github-actions[bot] commented on PR #29781: URL: https://github.com/apache/beam/pull/29781#issuecomment-1857732808 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [PR] Add SparkStructuredStreamingRunner to beam_PostCommit_Java_Tpcds_Spark workflow [beam]

aromanenko-dev commented on PR #29781: URL: https://github.com/apache/beam/pull/29781#issuecomment-1857731246 R: @damccorm PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add SparkStructuredStreamingRunner to beam_PostCommit_Java_Tpcds_Spark workflow [beam]

aromanenko-dev commented on PR #29781: URL: https://github.com/apache/beam/pull/29781#issuecomment-1857717312 Run Spark Runner Tpcds Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] Add SparkStructuredStreamingRunner to beam_PostCommit_Java_Tpcds_Spark workflow [beam]

aromanenko-dev opened a new pull request, #29781: URL: https://github.com/apache/beam/pull/29781 Add `SparkStructuredStreamingRunner` to `beam_PostCommit_Java_Tpcds_Spark` workflow since it was lost during Jenkins -> GitHub Actions migration. Thank you